[tip: sched/core] sched/fair: Use load instead of runnable load in load_balance()

2019-10-21 Thread tip-bot2 for Vincent Guittot
The following commit has been merged into the sched/core branch of tip: Commit-ID: b0fb1eb4f04ae4768231b9731efb1134e22053a4 Gitweb: https://git.kernel.org/tip/b0fb1eb4f04ae4768231b9731efb1134e22053a4 Author:Vincent Guittot AuthorDate:Fri, 18 Oct 2019 15:26:33 +02:00

[tip: sched/core] sched/fair: Use rq->nr_running when balancing load

2019-10-21 Thread tip-bot2 for Vincent Guittot
The following commit has been merged into the sched/core branch of tip: Commit-ID: 5e23e474431529b7d1480f649ce33d0e9c1b2e48 Gitweb: https://git.kernel.org/tip/5e23e474431529b7d1480f649ce33d0e9c1b2e48 Author:Vincent Guittot AuthorDate:Fri, 18 Oct 2019 15:26:32 +02:00

[tip: sched/core] sched/fair: Use load instead of runnable load in wakeup path

2019-10-21 Thread tip-bot2 for Vincent Guittot
The following commit has been merged into the sched/core branch of tip: Commit-ID: 11f10e5420f6cecac7d4823638bff040c257aba9 Gitweb: https://git.kernel.org/tip/11f10e5420f6cecac7d4823638bff040c257aba9 Author:Vincent Guittot AuthorDate:Fri, 18 Oct 2019 15:26:36 +02:00

[tip: sched/core] sched/fair: Rework load_balance()

2019-10-21 Thread tip-bot2 for Vincent Guittot
The following commit has been merged into the sched/core branch of tip: Commit-ID: 0b0695f2b34a4afa3f6e9aa1ff0e5336d8dad912 Gitweb: https://git.kernel.org/tip/0b0695f2b34a4afa3f6e9aa1ff0e5336d8dad912 Author:Vincent Guittot AuthorDate:Fri, 18 Oct 2019 15:26:31 +02:00

[tip: sched/core] sched/fair: Rework find_idlest_group()

2019-10-21 Thread tip-bot2 for Vincent Guittot
The following commit has been merged into the sched/core branch of tip: Commit-ID: 57abff067a084889b6e06137e61a3dc3458acd56 Gitweb: https://git.kernel.org/tip/57abff067a084889b6e06137e61a3dc3458acd56 Author:Vincent Guittot AuthorDate:Fri, 18 Oct 2019 15:26:38 +02:00

[tip: sched/core] sched/fair: Clean up asym packing

2019-10-21 Thread tip-bot2 for Vincent Guittot
The following commit has been merged into the sched/core branch of tip: Commit-ID: 490ba971d8b498ba3a47999ab94c6a0d1830ad41 Gitweb: https://git.kernel.org/tip/490ba971d8b498ba3a47999ab94c6a0d1830ad41 Author:Vincent Guittot AuthorDate:Fri, 18 Oct 2019 15:26:28 +02:00

Re: [PATCH v4 00/10] sched/fair: rework the CFS load balance

2019-10-21 Thread Vincent Guittot
On Mon, 21 Oct 2019 at 09:50, Ingo Molnar wrote: > > > * Vincent Guittot wrote: > > > Several wrong task placement have been raised with the current load > > balance algorithm but their fixes are not always straight forward and > > end up with using biased values

TRADING ACCOUNT

2019-10-19 Thread HUREL Vincent
Dear sir , I am M HUREL Vincent , purchasing and sales manager of ABB FRANCE . Our Company specialised in Supplying computer hardware and Electronic . We want to extend our supplier list because of concurrency in prices on the international market . We are seeking a supplier with whom we can

Re: [RFC PATCH v3 0/6] sched/cpufreq: Make schedutil energy aware

2019-10-18 Thread Vincent Guittot
On Fri, 18 Oct 2019 at 16:44, Douglas Raillard wrote: > > > > On 10/18/19 1:07 PM, Peter Zijlstra wrote: > > On Fri, Oct 18, 2019 at 12:46:25PM +0100, Douglas Raillard wrote: > > > >>> What I don't see is how that that difference makes sense as input to: > >>> > >>> cost(x) : (1 + x) * cost_j

Re: [RFC PATCH v3 0/6] sched/cpufreq: Make schedutil energy aware

2019-10-18 Thread Vincent Guittot
On Fri, 18 Oct 2019 at 16:44, Douglas Raillard wrote: > > > > On 10/18/19 1:07 PM, Peter Zijlstra wrote: > > On Fri, Oct 18, 2019 at 12:46:25PM +0100, Douglas Raillard wrote: > > > >>> What I don't see is how that that difference makes sense as input to: > >>> > >>> cost(x) : (1 + x) * cost_j

[PATCH v4 08/11] sched/fair: use utilization to select misfit task

2019-10-18 Thread Vincent Guittot
of using the load. Signed-off-by: Vincent Guittot Acked-by: Valentin Schneider --- kernel/sched/fair.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 9b8e20d..670856d 100644 --- a/kernel/sched/fair.c +++ b/kernel

[PATCH v4 04/11] sched/fair: rework load_balance

2019-10-18 Thread Vincent Guittot
. - find_busiest_group() checks if there is an imbalance between local and busiest group. - calculate_imbalance() decides what have to be moved. Finally, the now unused field total_running of struct sd_lb_stats has been removed. Signed-off-by: Vincent Guittot --- kernel/sched/fair.c | 611

[PATCH v4 06/11] sched/fair: use load instead of runnable load in load_balance

2019-10-18 Thread Vincent Guittot
being conservative and taking into account the sleeping tasks that might wakeup on the cpu. Signed-off-by: Vincent Guittot --- kernel/sched/fair.c | 24 ++-- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index e09fe12b

[PATCH v4 11/11] sched/fair: rework find_idlest_group

2019-10-18 Thread Vincent Guittot
(). Signed-off-by: Vincent Guittot --- kernel/sched/fair.c | 384 ++-- 1 file changed, 256 insertions(+), 128 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index ed1800d..fbaafae 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched

[PATCH v4 03/11] sched/fair: remove meaningless imbalance calculation

2019-10-18 Thread Vincent Guittot
clean up load_balance and remove meaningless calculation and fields before adding new algorithm. Signed-off-by: Vincent Guittot Acked-by: Rik van Riel --- kernel/sched/fair.c | 105 +--- 1 file changed, 1 insertion(+), 104 deletions(-) diff

[PATCH v4 05/11] sched/fair: use rq->nr_running when balancing load

2019-10-18 Thread Vincent Guittot
of nr_running in the statistics and use it to detect such situation. Signed-off-by: Vincent Guittot --- kernel/sched/fair.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 5ae5281..e09fe12b 100644 --- a/kernel/sched/fair.c

[PATCH v4 09/11] sched/fair: use load instead of runnable load in wakeup path

2019-10-18 Thread Vincent Guittot
before comparing runnable load and it's worth aligning the wake up path with the load_balance. Signed-off-by: Vincent Guittot --- kernel/sched/fair.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 670856d

[PATCH v4 10/11] sched/fair: optimize find_idlest_group

2019-10-18 Thread Vincent Guittot
find_idlest_group() now reads CPU's load_avg in 2 different ways. Consolidate the function to read and use load_avg only once and simplify the algorithm to only look for the group with lowest load_avg. Signed-off-by: Vincent Guittot --- kernel/sched/fair.c | 50

[PATCH v4 07/11] sched/fair: evenly spread tasks when not overloaded

2019-10-18 Thread Vincent Guittot
When there is only 1 cpu per group, using the idle cpus to evenly spread tasks doesn't make sense and nr_running is a better metrics. Signed-off-by: Vincent Guittot --- kernel/sched/fair.c | 40 1 file changed, 28 insertions(+), 12 deletions(-) diff

[PATCH v4 02/11] sched/fair: rename sum_nr_running to sum_h_nr_running

2019-10-18 Thread Vincent Guittot
Rename sum_nr_running to sum_h_nr_running because it effectively tracks cfs->h_nr_running so we can use sum_nr_running to track rq->nr_running when needed. There is no functional changes. Signed-off-by: Vincent Guittot Acked-by: Rik van Riel Reviewed-by: Valentin Schneider --- kernel

[PATCH v4 00/10] sched/fair: rework the CFS load balance

2019-10-18 Thread Vincent Guittot
order code - some minor code fixes - optimize the find_idles_group() Not covered in this patchset: - Better detection of overloaded and fully busy state, especially for cases when nr_running > nr CPUs. Vincent Guittot (11): sched/fair: clean up asym packing sched/fair: rename s

[PATCH v4 01/11] sched/fair: clean up asym packing

2019-10-18 Thread Vincent Guittot
the calculation of imbalance in calculate_imbalance(). There is no functional changes. Signed-off-by: Vincent Guittot Acked-by: Rik van Riel --- kernel/sched/fair.c | 63 ++--- 1 file changed, 16 insertions(+), 47 deletions(-) diff --git

Re: [Patch v3 2/7] sched: Add infrastructure to store and update instantaneous thermal pressure

2019-10-18 Thread Vincent Guittot
Hi Thara, On Thu, 17 Oct 2019 at 18:40, Thara Gopinath wrote: > > On 10/17/2019 04:44 AM, Vincent Guittot wrote: > > Hi Thara, > > > > On Wed, 16 Oct 2019 at 23:22, Thara Gopinath > > wrote: > >> > >> Hi Vincent, > >> > >>

Re: [Patch v3 2/7] sched: Add infrastructure to store and update instantaneous thermal pressure

2019-10-17 Thread Vincent Guittot
Hi Thara, On Wed, 16 Oct 2019 at 23:22, Thara Gopinath wrote: > > Hi Vincent, > > Thanks for the review > On 10/14/2019 11:50 AM, Vincent Guittot wrote: > > Hi Thara, > > > > On Mon, 14 Oct 2019 at 02:58, Thara Gopinath > > wrote: > >> >

Re: [PATCH v3 04/10] sched/fair: rework load_balance

2019-10-16 Thread Vincent Guittot
On Wed, 16 Oct 2019 at 09:21, Parth Shah wrote: > > > > On 9/19/19 1:03 PM, Vincent Guittot wrote: > > [...] > > > Signed-off-by: Vincent Guittot > > --- > > kernel/sched/fair.c | 585 > > ++-- > >

Re: [PATCH v3 0/8] sched/fair: rework the CFS load balance

2019-10-16 Thread Vincent Guittot
Hi Parth, On Wed, 16 Oct 2019 at 09:21, Parth Shah wrote: > > > > On 9/19/19 1:03 PM, Vincent Guittot wrote: > > Several wrong task placement have been raised with the current load > > balance algorithm but their fixes are not always straight forward and > > e

Re: [Patch v3 2/7] sched: Add infrastructure to store and update instantaneous thermal pressure

2019-10-14 Thread Vincent Guittot
Hi Thara, On Mon, 14 Oct 2019 at 02:58, Thara Gopinath wrote: > > Add thermal.c and thermal.h files that provides interface > APIs to initialize, update/average, track, accumulate and decay > thermal pressure per cpu basis. A per cpu structure max_capacity_info is > introduced to keep track of

Re: [PATCH] sched/fair: util_est: fast ramp-up EWMA on utilization increases

2019-10-14 Thread Vincent Guittot
On Mon, 14 Oct 2019 at 16:52, Peter Zijlstra wrote: > > > The energy aware schedutil patches remimded me this was still pending. > > On Fri, Aug 02, 2019 at 10:47:25AM +0100, Patrick Bellasi wrote: > > Hi Peter, Vincent, > > is there anything different I can do on thi

Re: [Patch v3 1/7] sched/pelt.c: Add support to track thermal pressure

2019-10-14 Thread Vincent Guittot
Hi Thara, On Mon, 14 Oct 2019 at 02:58, Thara Gopinath wrote: > > Extrapolating on the exisitng framework to track rt/dl utilization using s/exisitng/existing/ > pelt signals, add a similar mechanism to track thermal pressue. The s/pessure/pressure/ > difference here from rt/dl utilization

Re: [PATCH] sched/topology: Disable sched_asym_cpucapacity on domain destruction

2019-10-14 Thread Vincent Guittot
On Mon, 14 Oct 2019 at 14:16, Quentin Perret wrote: > > Hi Valentin, > > On Monday 14 Oct 2019 at 12:47:10 (+0100), Valentin Schneider wrote: > > While the static key is correctly initialized as being disabled, it will > > remain forever enabled once turned on. This means that if we start with an

Re: [PATCH] sched/topology: Disable sched_asym_cpucapacity on domain destruction

2019-10-14 Thread Vincent Guittot
een hotplugged out. > > Disable the static key when destroying domains, and let > build_sched_domains() (re) enable it as needed. > > Cc: > Fixes: df054e8445a4 ("sched/topology: Add static_key for asymmetric CPU > capacity optimizations") > Signed-off-by: Valentin

TRADING ACCOUNT

2019-10-12 Thread HUREL Vincent
Dear sir , I am M HUREL Vincent , purchasing and sales manager of ABB FRANCE . Our Company specialised in Supplying computer hardware and Electronic . We want to extend our supplier list because of concurrency in prices on the international market . We are seeking a supplier with whom we can

TRADING ACCOUNT

2019-10-11 Thread HUREL Vincent
Dear sir , I am M HUREL Vincent , purchasing and sales manager of ABB FRANCE . Our Company specialised in Supplying computer hardware and Electronic . We want to extend our supplier list because of concurrency in prices on the international market . We are seeking a supplier with whom we can

Re: [PATCH v3 0/8] sched/fair: rework the CFS load balance

2019-10-10 Thread Vincent Guittot
On Wed, 9 Oct 2019 at 21:33, Phil Auld wrote: > > On Tue, Oct 08, 2019 at 05:53:11PM +0200 Vincent Guittot wrote: > > Hi Phil, > > > > ... > > > While preparing v4, I have noticed that I have probably oversimplified > > the end of find_idlest

Re: [RFC v5 4/6] sched/fair: Tune task wake-up logic to pack small background tasks on fewer cores

2019-10-09 Thread Vincent Guittot
On Wed, 9 Oct 2019 at 11:23, Parth Shah wrote: > > > > On 10/8/19 6:58 PM, Hillf Danton wrote: > > > > On Mon, 7 Oct 2019 14:00:49 +0530 Parth Shah wrote: > >> +/* > >> + * Try to find a non idle core in the system based on few heuristics: > >> + * - Keep track of overutilized (>80% util) and

Re: [PATCH v3 04/10] sched/fair: rework load_balance

2019-10-08 Thread Vincent Guittot
On Tue, 8 Oct 2019 at 19:55, Peter Zijlstra wrote: > > On Thu, Sep 19, 2019 at 09:33:35AM +0200, Vincent Guittot wrote: > > + if (busiest->group_type == group_asym_packing) { > > + /* > > + * In case of asym capacity, we w

Re: [PATCH v3 04/10] sched/fair: rework load_balance

2019-10-08 Thread Vincent Guittot
On Tue, 8 Oct 2019 at 19:39, Peter Zijlstra wrote: > > On Tue, Oct 08, 2019 at 05:30:02PM +0200, Vincent Guittot wrote: > > > This is how I plan to get ride of the problem: > > + if (busiest->group_weight == 1 || sds->prefer_sibling) { > > +

Re: [RFC v5 4/6] sched/fair: Tune task wake-up logic to pack small background tasks on fewer cores

2019-10-08 Thread Vincent Guittot
On Mon, 7 Oct 2019 at 18:54, Parth Shah wrote: > > > > On 10/7/19 5:49 PM, Vincent Guittot wrote: > > On Mon, 7 Oct 2019 at 10:31, Parth Shah wrote: > >> > >> The algorithm finds the first non idle core in the system and tries to > >> place a task in

Re: [PATCH v3 0/8] sched/fair: rework the CFS load balance

2019-10-08 Thread Vincent Guittot
Hi Phil, On Tue, 8 Oct 2019 at 16:33, Phil Auld wrote: > > Hi Vincent, > > On Thu, Sep 19, 2019 at 09:33:31AM +0200 Vincent Guittot wrote: > > Several wrong task placement have been raised with the current load > > balance algorithm but their fixes are not always straigh

Re: [PATCH v3 04/10] sched/fair: rework load_balance

2019-10-08 Thread Vincent Guittot
Le Tuesday 08 Oct 2019 à 15:34:04 (+0100), Valentin Schneider a écrit : > On 08/10/2019 15:16, Peter Zijlstra wrote: > > On Wed, Oct 02, 2019 at 11:47:59AM +0100, Valentin Schneider wrote: > > > >> Yeah, right shift on signed negative values are implementation defined. > > > > Seriously? Even

Re: [PATCH 4/4] riscv: remove the switch statement in do_trap_break()

2019-10-07 Thread Vincent Chen
Sorry, I missed the comment. Christoph's suggestion is also good to me. I will modify it as you suggested. Thanks On Tue, Oct 8, 2019 at 12:31 AM Paul Walmsley wrote: > > On Mon, 7 Oct 2019, Christoph Hellwig wrote: > > > On Mon, Oct 07, 2019 at 09:08:23AM -0700, Paul Walmsley wrote: > > >

Re: [PATCH v3 09/10] sched/fair: use load instead of runnable load in wakeup path

2019-10-07 Thread Vincent Guittot
On Mon, 7 Oct 2019 at 17:14, Rik van Riel wrote: > > On Thu, 2019-09-19 at 09:33 +0200, Vincent Guittot wrote: > > runnable load has been introduced to take into account the case where > > blocked load biases the wake up path which may end to select an > > overloaded >

Re: [RFC v5 4/6] sched/fair: Tune task wake-up logic to pack small background tasks on fewer cores

2019-10-07 Thread Vincent Guittot
On Mon, 7 Oct 2019 at 10:31, Parth Shah wrote: > > The algorithm finds the first non idle core in the system and tries to > place a task in the idle CPU in the chosen core. To maintain > cache hotness, work of finding non idle core starts from the prev_cpu, > which also reduces task ping-pong

Re: [PATCH v2 2/2] cpufreq: intel_pstate: Conditional frequency invariant accounting

2019-10-04 Thread Vincent Guittot
On Fri, 4 Oct 2019 at 10:24, Giovanni Gherdovich wrote: > > On Thu, 2019-10-03 at 20:31 -0700, Srinivas Pandruvada wrote: > > On Thu, 2019-10-03 at 20:05 +0200, Rafael J. Wysocki wrote: > > > On Wednesday, October 2, 2019 2:29:26 PM CEST Giovanni Gherdovich > > > wrote: > > > > From: Srinivas

Re: [PATCH 1/2] dt-bindings: ptp: Add binding doc for IDT ClockMatrix based PTP clock

2019-10-03 Thread Vincent Cheng
On Tue, Oct 01, 2019 at 06:09:06PM EDT, Rob Herring wrote: >On Wed, Sep 18, 2019 at 04:06:37PM -0400, vincent.cheng...@renesas.com wrote: >> From: Vincent Cheng Hi Rob, Welcome back. Thank-you for providing feedback. >> >> Add device tree binding doc for the IDT ClockMa

Re: [PATCH v3 04/10] sched/fair: rework load_balance

2019-10-02 Thread Vincent Guittot
On Tue, 1 Oct 2019 at 19:47, Valentin Schneider wrote: > > On 19/09/2019 08:33, Vincent Guittot wrote: > > [...] > > > @@ -8283,69 +8363,133 @@ static inline void update_sd_lb_stats(struct > > lb_env *env, struct sd_lb_stats *sd > > */ > > static inline

Re: [PATCH v3 04/10] sched/fair: rework load_balance

2019-10-02 Thread Vincent Guittot
On Tue, 1 Oct 2019 at 18:53, Dietmar Eggemann wrote: > > On 01/10/2019 10:14, Vincent Guittot wrote: > > On Mon, 30 Sep 2019 at 18:24, Dietmar Eggemann > > wrote: > >> > >> Hi Vincent, > >> > >> On 19/09/2019 09:33, Vincent Guittot wrote: &g

Re: [PATCH v3 04/10] sched/fair: rework load_balance

2019-10-02 Thread Vincent Guittot
On Tue, 1 Oct 2019 at 18:53, Dietmar Eggemann wrote: > > On 01/10/2019 10:14, Vincent Guittot wrote: > > On Mon, 30 Sep 2019 at 18:24, Dietmar Eggemann > > wrote: > >> > >> Hi Vincent, > >> > >> On 19/09/2019 09:33, Vincent Guittot wro

Re: [PATCH v3 03/10] sched/fair: remove meaningless imbalance calculation

2019-10-02 Thread Vincent Guittot
On Tue, 1 Oct 2019 at 19:12, Valentin Schneider wrote: > > On 19/09/2019 08:33, Vincent Guittot wrote: > > clean up load_balance and remove meaningless calculation and fields before > > adding new algorithm. > > > > Signed-off-by: Vincent Guittot > > We'll

Re: [PATCH v3 04/10] sched/fair: rework load_balance

2019-10-01 Thread Vincent Guittot
group_asym_packing On Tue, 1 Oct 2019 at 10:15, Dietmar Eggemann wrote: > > On 19/09/2019 09:33, Vincent Guittot wrote: > > > [...] > > > @@ -8042,14 +8104,24 @@ static inline void update_sg_lb_stats(struct lb_env > > *env, > > } > >

Re: [PATCH v3 04/10] sched/fair: rework load_balance

2019-10-01 Thread Vincent Guittot
On Mon, 30 Sep 2019 at 18:24, Dietmar Eggemann wrote: > > Hi Vincent, > > On 19/09/2019 09:33, Vincent Guittot wrote: > > these are just some comments & questions based on a code study. Haven't > run any tests with it yet. > > [...] > > > The type of

Re: [PATCH v3 04/10] sched/fair: rework load_balance

2019-09-30 Thread Vincent Guittot
On Mon, 30 Sep 2019 at 03:13, Rik van Riel wrote: > > On Thu, 2019-09-19 at 09:33 +0200, Vincent Guittot wrote: > > > > Also the load balance decisions have been consolidated in the 3 > > functions > > below after removing the few bypasses

Re: [PATCH 2/4] rsicv: avoid sending a SIGTRAP to a user thread trapped in WARN()

2019-09-29 Thread Vincent Chen
On Sat, Sep 28, 2019 at 6:56 AM Christoph Hellwig wrote: > > Oh and s/rsicv/riscv/ in the subject, please. Oh! Thank you for finding this typo. I will correct it.

Re: [PATCH v2 2/2] ptp: Add a ptp clock driver for IDT ClockMatrix.

2019-09-27 Thread Vincent Cheng
returned %d\n", cnt); >> +return cnt; >> +} else if (cnt != 2) { >> +dev_err(>dev, >> +"i2c_transfer sent only %d of %d messages\n", cnt, 2); >> +return -EIO; >> +} >> + >>

[PATCH v2 2/2] ptp: Add a ptp clock driver for IDT ClockMatrix.

2019-09-26 Thread vincent . cheng . xh
From: Vincent Cheng The IDT ClockMatrix (TM) family includes integrated devices that provide eight PLL channels. Each PLL channel can be independently configured as a frequency synthesizer, jitter attenuator, digitally controlled oscillator (DCO), or a digital phase lock loop (DPLL). Typically

[PATCH v2 1/2] dt-bindings: ptp: Add bindings doc for IDT ClockMatrix based PTP clock

2019-09-26 Thread vincent . cheng . xh
From: Vincent Cheng Add device tree binding doc for the IDT ClockMatrix PTP clock driver. Co-developed-by: Richard Cochran Signed-off-by: Richard Cochran Signed-off-by: Vincent Cheng --- Changes since v1: - No changes --- Documentation/devicetree/bindings/ptp/ptp-idtcm.txt | 15

[PATCH 1/4] riscv: avoid kernel hangs when trapped in BUG()

2019-09-22 Thread Vincent Chen
() to deal with the break exception as the type of break is BUG_TRAP_TYPE_BUG. Signed-off-by: Vincent Chen --- arch/riscv/kernel/traps.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/riscv/kernel/traps.c b/arch/riscv/kernel/traps.c index 424eb72d56b1..055a937aca70 100644

[PATCH 0/4] riscv: correct the do_trap_break()

2019-09-22 Thread Vincent Chen
ebreak, it may cause the kernel thread to be stuck in the ebreak instruction. This patch set will solve the above problems by adjusting the implementations of the do_trap_break(). Vincent Chen (4): riscv: avoid kernel hangs when trapped in BUG() rsicv: avoid sending a SIGTRAP to a user

[PATCH 2/4] rsicv: avoid sending a SIGTRAP to a user thread trapped in WARN()

2019-09-22 Thread Vincent Chen
On RISC-V, when the kernel runs code on behalf of a user thread, and the kernel executes a WARN() or WARN_ON(), the user thread will be sent a bogus SIGTRAP. Fix the RISC-V kernel code to not send a SIGTRAP when a WARN()/WARN_ON() is executed. Signed-off-by: Vincent Chen --- arch/riscv/kernel

[PATCH 4/4] riscv: remove the switch statement in do_trap_break()

2019-09-22 Thread Vincent Chen
To make the code more straightforward, replacing the switch statement with if statement. Suggested-by: Paul Walmsley Signed-off-by: Vincent Chen --- arch/riscv/kernel/traps.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/arch/riscv/kernel/traps.c

[PATCH 3/4] riscv: Correct the handling of unexpected ebreak in do_trap_break()

2019-09-22 Thread Vincent Chen
to the trapped process only when the ebreak is in userspace. Signed-off-by: Vincent Chen --- arch/riscv/kernel/traps.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/arch/riscv/kernel/traps.c b/arch/riscv/kernel/traps.c index 82f42a55451e..dd13bc90aeb6 100644 --- a/arch

Re: [PATCH 2/2] ptp: Add a ptp clock driver for IDT ClockMatrix.

2019-09-19 Thread Vincent Cheng
s32 err; >> +s32 len; >> +u8 val; >> +u8 loaddr; >> + >> +pr_info("requesting firmware '%s'\n", FW_FILENAME); > >dev_debug() Thanks, will make the change. >> + >> +err = request_firmware(, FW_FILENAME, dev); >> + >> +if (err) >> +return err; >> + >> +pr_info("firmware size %zu bytes\n", fw->size); > >dev_debug() > >Maybe look through all your pr_info and downgrade most of them to >dev_debug() Yes, will go through and downgrade to dev_debug() accordingly. Thanks, Vincent

Re: [PATCH 1/1] sched/rt: avoid contend with CFS task

2019-09-19 Thread Vincent Guittot
On Thu, 19 Sep 2019 at 16:32, Vincent Guittot wrote: > > On Thu, 19 Sep 2019 at 16:23, Qais Yousef wrote: > > > > On 09/19/19 14:27, Vincent Guittot wrote: > > > > > > But for requirement of performance, I think it is better to > > > > > &g

Re: [PATCH 1/1] sched/rt: avoid contend with CFS task

2019-09-19 Thread Vincent Guittot
On Thu, 19 Sep 2019 at 16:23, Qais Yousef wrote: > > On 09/19/19 14:27, Vincent Guittot wrote: > > > > > But for requirement of performance, I think it is better to > > > > > differentiate between idle CPU and CPU has CFS task. > > > > > > &

Re: [PATCH 1/1] sched/rt: avoid contend with CFS task

2019-09-19 Thread Vincent Guittot
On Thu, 19 Sep 2019 at 13:22, Jing-Ting Wu wrote: > > On Thu, 2019-09-05 at 16:01 +0200, Vincent Guittot wrote: > > Hi Jing-Ting, > > > > On Thu, 5 Sep 2019 at 15:26, Jing-Ting Wu wrote: > > > > > > On Fri, 2019-08-30 at 15:55 +0100, Qais Yousef

Re: [PATCH 1/1] sched/eas: introduce system-wide overutil indicator

2019-09-19 Thread Vincent Guittot
On Thu, 19 Sep 2019 at 09:20, YT Chang wrote: > > When the system is overutilization, the load-balance crossing s/overutilization/overutilized/ > clusters will be triggered and scheduler will not use energy > aware scheduling to choose CPUs. > > The overutilization means the loading of ANY

[PATCH v3 03/10] sched/fair: remove meaningless imbalance calculation

2019-09-19 Thread Vincent Guittot
clean up load_balance and remove meaningless calculation and fields before adding new algorithm. Signed-off-by: Vincent Guittot --- kernel/sched/fair.c | 105 +--- 1 file changed, 1 insertion(+), 104 deletions(-) diff --git a/kernel/sched/fair.c

[PATCH v3 04/10] sched/fair: rework load_balance

2019-09-19 Thread Vincent Guittot
. - find_busiest_group() checks if there is an imbalance between local and busiest group. - calculate_imbalance() decides what have to be moved. Finally, the now unused field total_running of struct sd_lb_stats has been removed. Signed-off-by: Vincent Guittot --- kernel/sched/fair.c | 585

[PATCH v3 06/10] sched/fair: use load instead of runnable load in load_balance

2019-09-19 Thread Vincent Guittot
being conservative and taking into account the sleeping tasks that might wakeup on the cpu. Signed-off-by: Vincent Guittot --- kernel/sched/fair.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 7e74836..15ec38c

[PATCH v3 01/10] sched/fair: clean up asym packing

2019-09-19 Thread Vincent Guittot
the calculation of imbalance in calculate_imbalance(). There is no functional changes. Signed-off-by: Vincent Guittot --- kernel/sched/fair.c | 63 ++--- 1 file changed, 16 insertions(+), 47 deletions(-) diff --git a/kernel/sched/fair.c b/kernel

[PATCH v3 02/10] sched/fair: rename sum_nr_running to sum_h_nr_running

2019-09-19 Thread Vincent Guittot
Rename sum_nr_running to sum_h_nr_running because it effectively tracks cfs->h_nr_running so we can use sum_nr_running to track rq->nr_running when needed. There is no functional changes. Signed-off-by: Vincent Guittot --- kernel/sched/fair.c | 32

[PATCH v3 05/10] sched/fair: use rq->nr_running when balancing load

2019-09-19 Thread Vincent Guittot
of nr_running in the statistics and use it to detect such situation. Signed-off-by: Vincent Guittot --- kernel/sched/fair.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index d33379c..7e74836 100644 --- a/kernel/sched/fair.c

[PATCH v3 09/10] sched/fair: use load instead of runnable load in wakeup path

2019-09-19 Thread Vincent Guittot
before comparing runnable load and it's worth aligning the wake up path with the load_balance. Signed-off-by: Vincent Guittot --- kernel/sched/fair.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index acca869..39a37ae 100644

[PATCH v3 07/10] sched/fair: evenly spread tasks when not overloaded

2019-09-19 Thread Vincent Guittot
When there is only 1 cpu per group, using the idle cpus to evenly spread tasks doesn't make sense and nr_running is a better metrics. Signed-off-by: Vincent Guittot --- kernel/sched/fair.c | 40 1 file changed, 28 insertions(+), 12 deletions(-) diff

[PATCH v3 0/8] sched/fair: rework the CFS load balance

2019-09-19 Thread Vincent Guittot
to delay this version because of this update which is not ready yet - Better detection of overloaded and fully busy state, especially for cases when nr_running > nr CPUs. Vincent Guittot (8): sched/fair: clean up asym packing sched/fair: rename sum_nr_running to sum_h_nr_running sched/f

[PATCH v3 08/10] sched/fair: use utilization to select misfit task

2019-09-19 Thread Vincent Guittot
utilization is used to detect a misfit task but the load is then used to select the task on the CPU which can lead to select a small task with high weight instead of the task that triggered the misfit migration. Signed-off-by: Vincent Guittot Acked-by: Valentin Schneider --- kernel/sched

[PATCH v3 10/10] sched/fair: optimize find_idlest_group

2019-09-19 Thread Vincent Guittot
find_idlest_group() now loads CPU's load_avg in 2 different ways. Consolidate the function to read and use load_avg only once and simplify the algorithm to only look for the group with lowest load_avg. Signed-off-by: Vincent Guittot --- kernel/sched/fair.c | 52

[PATCH 2/2] ptp: Add a ptp clock driver for IDT ClockMatrix.

2019-09-18 Thread vincent . cheng . xh
From: Vincent Cheng The IDT ClockMatrix (TM) family includes integrated devices that provide eight PLL channels. Each PLL channel can be independently configured as a frequency synthesizer, jitter attenuator, digitally controlled oscillator (DCO), or a digital phase lock loop (DPLL). Typically

[PATCH 1/2] dt-bindings: ptp: Add binding doc for IDT ClockMatrix based PTP clock

2019-09-18 Thread vincent . cheng . xh
From: Vincent Cheng Add device tree binding doc for the IDT ClockMatrix PTP clock driver. Signed-off-by: Vincent Cheng --- Documentation/devicetree/bindings/ptp/ptp-idtcm.txt | 15 +++ 1 file changed, 15 insertions(+) create mode 100644 Documentation/devicetree/bindings/ptp/ptp

Re: Usecases for the per-task latency-nice attribute

2019-09-18 Thread Vincent Guittot
On Wed, 18 Sep 2019 at 17:46, Patrick Bellasi wrote: > > > On Wed, Sep 18, 2019 at 16:22:32 +0100, Vincent Guittot wrote... > > > On Wed, 18 Sep 2019 at 16:19, Patrick Bellasi > > wrote: > > [...] > > >> $> Wakeup path tunings > >> ===

Re: Usecases for the per-task latency-nice attribute

2019-09-18 Thread Vincent Guittot
On Wed, 18 Sep 2019 at 16:19, Patrick Bellasi wrote: > > > On Wed, Sep 18, 2019 at 13:41:04 +0100, Parth Shah wrote... > > > Hello everyone, > > Hi Parth, > thanks for staring this discussion. > > [ + patrick.bell...@matbug.net ] my new email address, since with > @arm.com I will not be reachable

Re: [PATCH 1/2] x86,sched: Add support for frequency invariance

2019-09-17 Thread Vincent Guittot
+/* > > > + * APERF/MPERF frequency ratio computation. > > > + * > > > + * The scheduler wants to do frequency invariant accounting and > > > needs a <1 > > > + * ratio to account for the 'current' frequency, corresponding to > > > + * fr

[PATCH] riscv: Avoid interrupts being erroneously enabled in handle_exception()

2019-09-16 Thread Vincent Chen
, it will be taken when interrupts are enabled. In this case, it may cause a deadlock problem if the rq.lock is locked again in the timer ISR. Hence, the handle_exception() can only enable interrupts when the state of sstatus.SPIE is 1. This patch is tested on HiFive Unleashed board. Signed-off-by: Vincent

Re: [RFC PATCH 1/9] sched,cgroup: Add interface for latency-nice

2019-09-06 Thread Vincent Guittot
On Fri, 6 Sep 2019 at 16:13, Valentin Schneider wrote: > > On 06/09/2019 13:45, Parth Shah wrote:> > > I guess there is some usecase in case of thermal throttling. > > If a task is heating up the core then in ideal scenarios POWER systems > > throttle > > down to rated frequency. > > In such

Re: [PATCH 1/1] sched/rt: avoid contend with CFS task

2019-09-05 Thread Vincent Guittot
s runnable time for CFS task. > > The detailed log is shown as following, CFS task(thread1-6580) is preempted > by RT task(thread0-6674) about 332ms: 332ms is quite long and is probably not an idle load blanace but a busy load balance > thread1-6580 [003] dnh294.452898: sched_

Re: [PATCH 09/15] sched,fair: refactor enqueue/dequeue_entity

2019-09-04 Thread Vincent Guittot
On Tue, 3 Sep 2019 at 22:27, Rik van Riel wrote: > > On Tue, 2019-09-03 at 17:38 +0200, Vincent Guittot wrote: > > Hi Rik, > > > > On Thu, 22 Aug 2019 at 04:18, Rik van Riel wrote: > > > Refactor enqueue_entity, dequeue_entity, and update_load_avg, in > > &

Re: [PATCH 09/15] sched,fair: refactor enqueue/dequeue_entity

2019-09-03 Thread Vincent Guittot
Hi Rik, On Thu, 22 Aug 2019 at 04:18, Rik van Riel wrote: > > Refactor enqueue_entity, dequeue_entity, and update_load_avg, in order > to split out the things we still want to happen at every level in the > cgroup hierarchy with a flat runqueue from the things we only need to > happen once. > >

Re: [PATCH v2 5/8] sched/fair: use rq->nr_running when balancing load

2019-09-02 Thread Vincent Guittot
Hi Hillf, Sorry for the late reply. I have noticed that i didn't answer your question while preparing v3 On Fri, 9 Aug 2019 at 07:21, Hillf Danton wrote: > > > On Thu, 1 Aug 2019 16:40:21 +0200 Vincent Guittot wrote: > > > > cfs load_balance only takes care of CFS t

Re: [PATCH 08/15] sched,fair: simplify timeslice length code

2019-09-02 Thread Vincent Guittot
On Fri, 30 Aug 2019 at 17:02, Rik van Riel wrote: > > On Fri, 2019-08-30 at 08:41 +0200, Vincent Guittot wrote: > > > > When tasks get their timeslice rounded up, that will increase > > > the total sched period in a similar way the old code did by > >

Re: [PATCH v2 0/8] sched/fair: rework the CFS load balance

2019-08-30 Thread Vincent Guittot
Hi Phil, On Thu, 29 Aug 2019 at 21:23, Phil Auld wrote: > > On Thu, Aug 01, 2019 at 04:40:16PM +0200 Vincent Guittot wrote: > > Several wrong task placement have been raised with the current load > > > > -- > > 2.7.4 > > > > I keep expecting a v3 so I h

Re: [PATCH 08/15] sched,fair: simplify timeslice length code

2019-08-30 Thread Vincent Guittot
On Thu, 29 Aug 2019 at 18:00, Rik van Riel wrote: > > On Thu, 2019-08-29 at 16:02 +0200, Vincent Guittot wrote: > > On Thu, 29 Aug 2019 at 01:19, Rik van Riel wrote: > > > > > What am I overlooking? > > > > My point is more for task that runs severa

Re: [PATCH v2 4/8] sched/fair: rework load_balance

2019-08-29 Thread Vincent Guittot
On Wed, 28 Aug 2019 at 16:19, Valentin Schneider wrote: > > On 26/08/2019 11:11, Vincent Guittot wrote: > >>> + case group_fully_busy: > >>> + /* > >>> + * Select the fully busy group with highest avg_load. > >>>

Re: [PATCH v2 4/4] sched/fair: Prevent active LB from preempting higher sched classes

2019-08-29 Thread Vincent Guittot
On Wed, 28 Aug 2019 at 11:46, Valentin Schneider wrote: > > On 27/08/2019 13:28, Vincent Guittot wrote: > > On Thu, 15 Aug 2019 at 16:52, Valentin Schneider > > wrote: > >> > >> The CFS load balancer can cause the cpu_stopper to run a function to > >

Re: [PATCH 08/15] sched,fair: simplify timeslice length code

2019-08-29 Thread Vincent Guittot
On Thu, 29 Aug 2019 at 01:19, Rik van Riel wrote: > > On Wed, 2019-08-28 at 19:32 +0200, Vincent Guittot wrote: > > On Thu, 22 Aug 2019 at 04:18, Rik van Riel wrote: > > > The idea behind __sched_period makes sense, but the results do not > > > always. >

Re: [PATCH 08/15] sched,fair: simplify timeslice length code

2019-08-28 Thread Vincent Guittot
On Thu, 22 Aug 2019 at 04:18, Rik van Riel wrote: > > The idea behind __sched_period makes sense, but the results do not always. > > When a CPU has one high priority task and a large number of low priority > tasks, __sched_period will return a value larger than sysctl_sched_latency, > and the one

Re: [PATCH 07/15] sched,cfs: fix zero length timeslice calculation

2019-08-28 Thread Vincent Guittot
On Thu, 22 Aug 2019 at 04:18, Rik van Riel wrote: > > The way the time slice length is currently calculated, not only do high > priority tasks get longer time slices than low priority tasks, but due > to fixed point math, low priority tasks could end up with a zero length > time slice. This can

Re: [PATCH 06/15] sched,cfs: use explicit cfs_rq of parent se helper

2019-08-28 Thread Vincent Guittot
On Wed, 28 Aug 2019 at 17:28, Rik van Riel wrote: > > On Wed, 2019-08-28 at 15:53 +0200, Vincent Guittot wrote: > > On Thu, 22 Aug 2019 at 04:18, Rik van Riel wrote: > > > Use an explicit "cfs_rq of parent sched_entity" helper in a few > > > strategic p

Re: [PATCH 03/15] sched,fair: redefine runnable_load_avg as the sum of task_h_load

2019-08-28 Thread Vincent Guittot
On Wed, 28 Aug 2019 at 16:48, Rik van Riel wrote: > > On Wed, 2019-08-28 at 15:50 +0200, Vincent Guittot wrote: > > Hi Rik, > > > > On Thu, 22 Aug 2019 at 04:18, Rik van Riel wrote: > > > The runnable_load magic is used to quickly propagate information &g

Re: [PATCH 05/15] sched,fair: remove cfs_rqs from leaf_cfs_rq_list bottom up

2019-08-28 Thread Vincent Guittot
> is on the rq->leaf_cfs_rq_list. > > By only removing a cfs_rq from the list once it no longer has children > on the list, we can avoid walking the sched_entity hierarchy if the bottom > cfs_rq is on the list, once the runqueues have been flattened. > > Signed-off-by: Rik van Riel

Re: [PATCH 06/15] sched,cfs: use explicit cfs_rq of parent se helper

2019-08-28 Thread Vincent Guittot
On Thu, 22 Aug 2019 at 04:18, Rik van Riel wrote: > > Use an explicit "cfs_rq of parent sched_entity" helper in a few > strategic places, where cfs_rq_of(se) may no longer point at the The only case is the sched_entity of a task which will point to root cfs, isn't it ? > right runqueue once we

<    5   6   7   8   9   10   11   12   13   14   >