Re: [PATCH] staging: xillybus: fix some coding style errors

2014-08-10 Thread Vincent Bernat
❦ 9 août 2014 20:34 -0700, Greg Kroah-Hartman  : >> This includes: >> - keep "else" on the same line as the closing brace >> - don't use "else" after "return" > >> - don't issue a message for an out-of-memory error >&g

[PATCH] staging: visorchipset: fix sparse warnings about static declaration

2014-08-01 Thread Vincent Bernat
Some functions were prototyped as static but the actual definition wasn't. While this is valid (the function is static because the two declarations don't conflict and the first one is static), this makes sparse unhappy and cause confusion of normal people too. Signed-off-by: Vinc

[PATCH] staging: visorchipset: fix sparse warnings about static declaration

2014-08-01 Thread Vincent Bernat
Some functions were prototyped as static but the actual definition wasn't. While this is valid (the function is static because the two declarations don't conflict and the first one is static), this makes sparse unhappy and cause confusion of normal people too. Signed-off-by: Vinc

[PATCH] staging: visorchipset: fix sparse warnings about static declaration

2014-07-27 Thread Vincent Bernat
Some functions were prototyped as static but the actual definition wasn't. While this is valid (the function is static because the two declarations don't conflict and the first one is static), this makes sparse unhappy and cause confusion of normal people too. Signed-off-by: Vinc

[PATCH] staging: xillybus: fix some coding style errors

2014-07-16 Thread Vincent Bernat
This includes: - keep "else" on the same line as the closing brace - don't use "else" after "return" - don't issue a message for an out-of-memory error - blank line after a declaration Signed-off-by: Vincent Bernat --- drivers/staging/xillybus/xi