with other signals.
Mark deprecated sched_thermal_decay_shift boot parameter.
Signed-off-by: Vincent Guittot
---
.../admin-guide/kernel-parameters.txt | 1 +
kernel/sched/core.c| 2 +-
kernel/sched/fair.c| 10 ++
kernel/sched
as an example. Such high frequency signal needs filtering to be
smoothed and provide an value that reflects the average available capacity
into the scheduler time scale.
Signed-off-by: Vincent Guittot
---
arch/arm/include/asm/topology.h | 6 ++---
arch/arm64/include/asm/topology.h
Aggregate the different pressures applied on the capacity of CPUs and
create a new function that returns the actual capacity of the CPU:
get_actual_cpu_capacity()
Signed-off-by: Vincent Guittot
Reviewed-by: Lukasz Luba
---
kernel/sched/fair.c | 45
includes cpufreq cooling device. Remove the call to
arch_update_thermal_pressure() in cpufreq cooling device as this is
handled by cpufreq_get_pressure().
Signed-off-by: Vincent Guittot
Reviewed-by: Lukasz Luba
---
drivers/thermal/cpufreq_cooling.c | 3 ---
1 file changed, 3 deletions(-)
diff
Provide to the scheduler a feedback about the temporary max available
capacity. Unlike arch_update_thermal_pressure, this doesn't need to be
filtered as the pressure will happen for dozens ms or more.
Signed-off-by: Vincent Guittot
---
drivers/cpufreq/cpufreq.c | 34
cpufreq_policy as parameter of cpufreq_update_pressure()
- Fix typos and comments
- Make sched_thermal_decay_shift boot param as deprecated
Vincent Guittot (5):
cpufreq: Add a cpufreq pressure feedback for the scheduler
sched: Take cpufreq feedback into account
thermal/cpufreq: Remove
On Thu, 14 Dec 2023 at 10:20, Lukasz Luba wrote:
>
>
>
> On 12/12/23 14:27, Vincent Guittot wrote:
> > Provide to the scheduler a feedback about the temporary max available
> > capacity. Unlike arch_update_thermal_pressure, this doesn't need to be
> > filter
On Thu, 14 Dec 2023 at 09:53, Lukasz Luba wrote:
>
>
>
> On 12/14/23 08:36, Vincent Guittot wrote:
> > On Thu, 14 Dec 2023 at 09:30, Lukasz Luba wrote:
> >>
> >>
> >> On 12/12/23 14:27, Vincent Guittot wrote:
>
> [snip]
>
> >
On Thu, 14 Dec 2023 at 09:30, Lukasz Luba wrote:
>
>
> On 12/12/23 14:27, Vincent Guittot wrote:
> > Now that cpufreq provides a pressure value to the scheduler, rename
> > arch_update_thermal_pressure into hw pressure to reflect that it returns
> > a pressure applied
On Thu, 14 Dec 2023 at 09:21, Lukasz Luba wrote:
>
> Hi Vincent,
>
> I've been waiting for this feature, thanks!
>
>
> On 12/12/23 14:27, Vincent Guittot wrote:
> > Following the consolidation and cleanup of CPU capacity in [1], this serie
> > reworks how the sch
On Thu, 14 Dec 2023 at 06:43, Viresh Kumar wrote:
>
> On 12-12-23, 15:27, Vincent Guittot wrote:
> > @@ -2618,6 +2663,9 @@ static int cpufreq_set_policy(struct cpufreq_policy
> > *policy,
> > policy->max = __resolve_freq(policy, poli
On Wed, 13 Dec 2023 at 08:17, Viresh Kumar wrote:
>
> On 12-12-23, 15:27, Vincent Guittot wrote:
> > Provide to the scheduler a feedback about the temporary max available
> > capacity. Unlike arch_update_thermal_pressure, this doesn't need to be
> > filtered as the pressur
by max current limitation as an example.
Signed-off-by: Vincent Guittot
---
arch/arm/include/asm/topology.h | 6 ++---
arch/arm64/include/asm/topology.h | 6 ++---
drivers/base/arch_topology.c | 26 +--
drivers/cpufreq/qcom-cpufreq
Provide to the scheduler a feedback about the temporary max available
capacity. Unlike arch_update_thermal_pressure, this doesn't need to be
filtered as the pressure will happen for dozens ms or more.
Signed-off-by: Vincent Guittot
---
drivers/cpufreq/cpufreq.c | 48
includes cpufreq cooling device. Remove the call to
arch_update_thermal_pressure() in cpufreq cooling device as this is
handled by cpufreq_get_pressure().
Signed-off-by: Vincent Guittot
---
drivers/thermal/cpufreq_cooling.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/thermal
Aggregate the different pressures applied on the capacity of CPUs and
create a new function that returns the actual capacity of the CPU:
get_actual_cpu_capacity()
Signed-off-by: Vincent Guittot
---
kernel/sched/fair.c | 43 +++
1 file changed, 23
sysfs. The latter is already taken into
account by this serie but as a temporary pressure which is not always the
best choice when we know that it will happen for seconds or more.
[1]
https://lore.kernel.org/lkml/20231211104855.558096-1-vincent.guit...@linaro.org/
Vincent Guittot (4):
cpufreq
On Tue, 20 Apr 2021 at 17:20, Rik van Riel wrote:
>
> On Tue, 2021-04-20 at 11:04 +0200, Vincent Guittot wrote:
> > On Mon, 19 Apr 2021 at 18:51, Rik van Riel wrote:
> > >
> > > @@ -10688,7 +10697,7 @@ static int newidle_balance(struct rq
>
On Mon, 19 Apr 2021 at 19:13, Valentin Schneider
wrote:
>
> On 16/04/21 15:51, Vincent Guittot wrote:
> > Le jeudi 15 avril 2021 � 18:58:46 (+0100), Valentin Schneider a �crit :
> >> +
> >> +/*
> >> + * What does migrating this task do to our ca
On Mon, 19 Apr 2021 at 18:51, Rik van Riel wrote:
>
> The try_to_wake_up function has an optimization where it can queue
> a task for wakeup on its previous CPU, if the task is still in the
> middle of going to sleep inside schedule().
>
> Once schedule() re-enables IRQs, the task will be woken
On Mon, 19 Apr 2021 at 04:18, Rik van Riel wrote:
>
> The try_to_wake_up function has an optimization where it can queue
> a task for wakeup on its previous CPU, if the task is still in the
> middle of going to sleep inside schedule().
>
> Once schedule() re-enables IRQs, the task will be woken
Le jeudi 15 avril 2021 à 18:58:46 (+0100), Valentin Schneider a écrit :
> Consider the following topology:
>
> DIE [ ]
> MC [][]
>0 1 2 3
>
> capacity_orig_of(x \in {0-1}) < capacity_orig_of(x \in {2-3})
>
> w/ CPUs 2-3 idle and CPUs 0-1 running CPU hogs
On Thu, 15 Apr 2021 at 19:58, Valentin Schneider
wrote:
>
> Consider the following (hypothetical) asymmetric CPU capacity topology,
> with some amount of capacity pressure (RT | DL | IRQ | thermal):
>
> DIE [ ]
> MC [][]
>0 1 2 3
>
> | CPU | capacity_orig |
On Mon, 12 Apr 2021 at 17:24, Mel Gorman wrote:
>
> On Mon, Apr 12, 2021 at 02:21:47PM +0200, Vincent Guittot wrote:
> > > > Peter, Valentin, Vincent, Mel, etal
> > > >
> > > > On architectures where we have multiple levels of cache access latencies
>
On Mon, 12 Apr 2021 at 11:37, Mel Gorman wrote:
>
> On Mon, Apr 12, 2021 at 11:54:36AM +0530, Srikar Dronamraju wrote:
> > * Gautham R. Shenoy [2021-04-02 11:07:54]:
> >
> > >
> > > To remedy this, this patch proposes that the LLC be moved to the MC
> > > level which is a group of cores in one
On Fri, 9 Apr 2021 at 01:05, Tim Chen wrote:
>
>
>
>
> On 4/8/21 7:51 AM, Vincent Guittot wrote:
>
> >> I was suprised to find the overall cpu% consumption of
> >> update_blocked_averages
> >> and throughput of the benchmark still didn't change
On Wed, 7 Apr 2021 at 19:19, Tim Chen wrote:
>
>
>
> On 4/7/21 7:02 AM, Vincent Guittot wrote:
> > Hi Tim,
> >
> > On Wed, 24 Mar 2021 at 17:05, Tim Chen wrote:
> >>
> >>
> >>
> >> On 3/24/21 6:44 AM, Vincent Guitto
Hi Tim,
On Wed, 24 Mar 2021 at 17:05, Tim Chen wrote:
>
>
>
> On 3/24/21 6:44 AM, Vincent Guittot wrote:
> > Hi Tim,
>
> >
> > IIUC your problem, we call update_blocked_averages() but because of:
> >
> > if (this_rq-&g
On Wed, 7 Apr 2021 at 12:19, Peter Zijlstra wrote:
>
> On Wed, Apr 07, 2021 at 11:54:37AM +0200, Peter Zijlstra wrote:
>
> > Let me have another poke at it.
>
> Pretty much what you did, except I also did s/smt/has_idle_core/ and
> fixed that @sd thing.
>
> Like so then?
Yes. Looks good to me
>
On Wed, 7 Apr 2021 at 11:55, Peter Zijlstra wrote:
>
> On Wed, Apr 07, 2021 at 11:42:17AM +0200, Vincent Guittot wrote:
> > I would really prefer to keep that out of select_idle_cpu which aims to
> > merge in one
> > single loop the walk through sd_llc. In the
Le mercredi 07 avril 2021 à 09:17:18 (+0200), Peter Zijlstra a écrit :
> On Tue, Apr 06, 2021 at 11:26:37AM -0400, Rik van Riel wrote:
> > I would be happy to pull the static branch out of select_idle_smt()
> > and place it into this if condition, though. You are right that
> > would save some
On Tue, 6 Apr 2021 at 17:55, Rik van Riel wrote:
>
> On Tue, 2021-04-06 at 17:31 +0200, Vincent Guittot wrote:
> > On Tue, 6 Apr 2021 at 17:26, Rik van Riel wrote:
> > > On Tue, 2021-04-06 at 17:10 +0200, Vincent Guittot wrote:
> > > > On Fri, 26 Mar 2021 at 2
On Tue, 6 Apr 2021 at 17:31, Vincent Guittot wrote:
>
> On Tue, 6 Apr 2021 at 17:26, Rik van Riel wrote:
> >
> > On Tue, 2021-04-06 at 17:10 +0200, Vincent Guittot wrote:
> > > On Fri, 26 Mar 2021 at 20:19, Rik van Riel wrote:
> > >
> > > > -
On Tue, 6 Apr 2021 at 17:26, Rik van Riel wrote:
>
> On Tue, 2021-04-06 at 17:10 +0200, Vincent Guittot wrote:
> > On Fri, 26 Mar 2021 at 20:19, Rik van Riel wrote:
> >
> > > -static int select_idle_cpu(struct task_struct *p, struct
> > > sched_domai
On Fri, 26 Mar 2021 at 20:19, Rik van Riel wrote:
>
> On Mon, 22 Mar 2021 11:03:06 +
> Mel Gorman wrote:
>
>
> > Second, select_idle_smt() does not use the cpus mask so consider moving
> > the cpus initialisation after select_idle_smt() has been called.
> > Specifically this initialisation
>
On Tue, 6 Apr 2021 at 06:11, Ricardo Neri
wrote:
>
> Introduce arch_sched_asym_prefer_early() so that architectures with SMT
> can delay the decision to label a candidate busiest group as
> group_asym_packing.
>
> When using asymmetric packing, high priority idle CPUs pull tasks from
> scheduling
gt;
> While at it, replace group_smaller_{min, max}_cpu_capacity() with
> comparisons of the source group's min/max capacity and the destination
> CPU's capacity.
>
> Reviewed-by: Qais Yousef
> Tested-by: Lingutla Chandrasekhar
> Signed-off-by: Valentin Schneider
Reviewed-by: V
ven happens on the CPU that appended the stopper work.
>
> Add a struct lb_env flag to denote active balancing, and use it in
> can_migrate_task(). Remove the sd->nr_balance_failed write that served the
> same purpose. Cleanup the LBF_DST_PINNED active balance special case.
>
>
la Chandrasekhar
> [Use kthread_is_per_cpu() rather than p->nr_cpus_allowed]
> [Reword changelog]
> Signed-off-by: Valentin Schneider
Reviewed-by: Vincent Guittot
> ---
> kernel/sched/fair.c | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/kernel/sched/
On Tue, 30 Mar 2021 at 14:06, Kefeng Wang wrote:
>
> update_nohz_stats() only call _nohz_idle_balance() under CONFIG_NO_HZ_COMMON.
a similar patch has already been sent and reviewed :
20210329144029.29200-1-yuehaib...@huawei.com
>
> Signed-off-by: Kefeng Wang
> ---
> kernel/sched/fair.c | 40
alance()
With these small nits above:
Reviewed-by: Vincent Guittot
>
> Signed-off-by: YueHaibing
> ---
> kernel/sched/fair.c | 40 ++--
> 1 file changed, 18 insertions(+), 22 deletions(-)
>
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.
On Fri, 26 Mar 2021 at 11:43, Peter Zijlstra wrote:
>
> The current sched_slice() seems to have issues; there's two possible
> things that could be improved:
>
> - the 'nr_running' used for __sched_period() is daft when cgroups are
>considered. Using the RQ wide h_nr_running seems like a
Hi Tim,
Le mardi 23 mars 2021 à 14:37:59 (-0700), Tim Chen a écrit :
>
>
> On 1/29/21 9:27 AM, Vincent Guittot wrote:
> >
> > The patch below moves the update of the blocked load of CPUs outside
> > newidle_balance().
>
> On a well known database workload, we
t; > to the long-tail load balance cost.
> >
> > This patch clears LBF_ALL_PINNED flag for this race condition, and hence
> > reduces the long-tail cost of newly idle balance.
>
> Ping...
Reviewed-by: Vincent Guittot
>
> >
> > Cc: Vincent Guittot
>
.7436 5.4501 6.9522 8.2882 9.9535 11.3367
> +4.1% +8.3% +7.3% +6.3%
>
> Signed-off-by: Barry Song
Reviewed-by: Vincent Guittot
> ---
> kernel/sched/fair.c | 8 +---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/ke
On Mon, 15 Mar 2021 at 20:18, Valentin Schneider
wrote:
>
> On 15/03/21 16:13, Vincent Guittot wrote:
> > On Thu, 11 Mar 2021 at 13:05, Valentin Schneider
> > wrote:
> >>
> >> Consider the following (hypothetical) asymmetric CPU capacity topology,
> >&
On Thu, 11 Mar 2021 at 13:05, Valentin Schneider
wrote:
>
> Consider the following (hypothetical) asymmetric CPU capacity topology,
> with some amount of capacity pressure (RT | DL | IRQ | thermal):
>
> DIE [ ]
> MC [][]
>0 1 2 3
>
> | CPU | capacity_orig |
On Thu, 11 Mar 2021 at 13:05, Valentin Schneider
wrote:
>
> During load-balance, groups classified as group_misfit_task are filtered
> out if they do not pass
>
> group_smaller_max_cpu_capacity(, );
>
> which itself employs fits_capacity() to compare the sgc->max_capacity of
> both groups.
>
>
On Thu, 11 Mar 2021 at 13:05, Valentin Schneider
wrote:
>
> Rik noted a while back that a handful of
>
> sd->flags & SD_ASYM_CPUCAPACITY
>
> & family in the CFS load-balancer code aren't guarded by the
> sched_asym_cpucapacity static branch.
guarding asym capacity with static branch in fast
On Wed, 10 Mar 2021 at 06:53, Srikar Dronamraju
wrote:
>
> * Vincent Guittot [2021-03-08 14:52:39]:
>
> > On Fri, 26 Feb 2021 at 17:41, Srikar Dronamraju
> > wrote:
> > >
>
> Thanks Vincent for your review comments.
>
> > > +static int prefe
> + return cppc_freq_invariance_exit();
> > +
> > + ret = cppc_get_perf_ctrs(i, _ctrs);
> > + if (ret) {
> > + pr_warn("%s: failed to read perf counters: %d\n",
> > + __func__, ret);
> > + return cppc_freq_invariance_exit();
> > + }
> > +
> > + cppc_fi->prev_perf_fb_ctrs = fb_ctrs;
> > + }
> > +
> > + /* Register for freq-invariance */
> > + topology_set_scale_freq_source(_sftd, cpu_present_mask);
> > +}
>
> After another very quick round of testing:
>
> Reviewed-by: Ionela Voinescu
> Tested-by: Ionela Voinescu
>
> I did not get the chance to test on ThunderX2 yet, but if you are happy
> with your testing on it, I won't delay this any further.
I have just run some functional tests on thx2 with rt-app: I have run
a periodic task (6ms running / 30ms periods) at different frequencies
(2.5Ghz, 2Ghz, 1.5Ghz, 1.333Ghz, 1Ghz) and the PELT signals stays the
same for all frequencies.
Tested-by: Vincent Guittot
>
> Thanks,
> Ionela.
USERS throughput 4420.64553.3 (3.00%)4405.8
> (-0.33%)
> sys/user:time 79.13/20.32 78.76/21.01 79/20
>
> Cc: LKML
> Cc: Michael Ellerman
> Cc: Michael Neuling
> Cc: Gautham R Shenoy
> Cc: Parth Shah
> Cc: Ingo M
Hi Aubrey,
On Thu, 4 Mar 2021 at 14:51, Li, Aubrey wrote:
>
> Hi Peter,
>
> On 2020/12/11 23:07, Vincent Guittot wrote:
> > On Thu, 10 Dec 2020 at 02:44, Aubrey Li wrote:
> >>
> >> Add idle cpumask to track idle cpus in sched domain. Every time
> >&
On Tue, 2 Mar 2021 at 00:08, Barry Song wrote:
>
> ARM64 chip Kunpeng 920 has 6 or 8 clusters in each NUMA node, and each
> cluster has 4 cpus. All clusters share L3 cache data, but each cluster
> has local L3 tag. On the other hand, each clusters will share some
> internal system bus. This means
The following commit has been merged into the sched/core branch of tip:
Commit-ID: 0826530de3cbdc89e60a89e86def94a5f0fc81ca
Gitweb:
https://git.kernel.org/tip/0826530de3cbdc89e60a89e86def94a5f0fc81ca
Author:Vincent Guittot
AuthorDate:Wed, 24 Feb 2021 14:30:01 +01:00
The following commit has been merged into the sched/core branch of tip:
Commit-ID: 64f84f273592d17dcdca20244168ad9f525a39c3
Gitweb:
https://git.kernel.org/tip/64f84f273592d17dcdca20244168ad9f525a39c3
Author:Vincent Guittot
AuthorDate:Wed, 24 Feb 2021 14:30:03 +01:00
The following commit has been merged into the sched/core branch of tip:
Commit-ID: ab2dde5e98db23387147fb4e7a52b6cf8141cdb3
Gitweb:
https://git.kernel.org/tip/ab2dde5e98db23387147fb4e7a52b6cf8141cdb3
Author:Vincent Guittot
AuthorDate:Wed, 24 Feb 2021 14:30:02 +01:00
The following commit has been merged into the sched/core branch of tip:
Commit-ID: 6553fc18179113a11835d5fde1735259f8943a55
Gitweb:
https://git.kernel.org/tip/6553fc18179113a11835d5fde1735259f8943a55
Author:Vincent Guittot
AuthorDate:Wed, 24 Feb 2021 14:30:05 +01:00
The following commit has been merged into the sched/core branch of tip:
Commit-ID: c6f886546cb8a38617cdbe755fe50d3acd2463e4
Gitweb:
https://git.kernel.org/tip/c6f886546cb8a38617cdbe755fe50d3acd2463e4
Author:Vincent Guittot
AuthorDate:Wed, 24 Feb 2021 14:30:06 +01:00
The following commit has been merged into the sched/core branch of tip:
Commit-ID: 7a82e5f52a3506bc35a4dc04d53ad2c9daf82e7f
Gitweb:
https://git.kernel.org/tip/7a82e5f52a3506bc35a4dc04d53ad2c9daf82e7f
Author:Vincent Guittot
AuthorDate:Wed, 24 Feb 2021 14:30:04 +01:00
The following commit has been merged into the sched/core branch of tip:
Commit-ID: 39b6a429c30482c349f1bb3746470fe473cbdb0f
Gitweb:
https://git.kernel.org/tip/39b6a429c30482c349f1bb3746470fe473cbdb0f
Author:Vincent Guittot
AuthorDate:Wed, 24 Feb 2021 14:30:07 +01:00
The following commit has been merged into the sched/core branch of tip:
Commit-ID: 63dbe695827f0f612a0cdbc82a43a974bcd536cd
Gitweb:
https://git.kernel.org/tip/63dbe695827f0f612a0cdbc82a43a974bcd536cd
Author:Vincent Guittot
AuthorDate:Wed, 24 Feb 2021 14:30:06 +01:00
The following commit has been merged into the sched/core branch of tip:
Commit-ID: 21c5d27a4c5d9fddb2c35ccdd5cddc11b75f753d
Gitweb:
https://git.kernel.org/tip/21c5d27a4c5d9fddb2c35ccdd5cddc11b75f753d
Author:Vincent Guittot
AuthorDate:Wed, 24 Feb 2021 14:30:03 +01:00
The following commit has been merged into the sched/core branch of tip:
Commit-ID: 780eec5b50930b34e2f096b4dce5368d90497b55
Gitweb:
https://git.kernel.org/tip/780eec5b50930b34e2f096b4dce5368d90497b55
Author:Vincent Guittot
AuthorDate:Wed, 24 Feb 2021 14:30:07 +01:00
The following commit has been merged into the sched/core branch of tip:
Commit-ID: 1690607f4232c120a2d6ff1f9d0766551d9609f1
Gitweb:
https://git.kernel.org/tip/1690607f4232c120a2d6ff1f9d0766551d9609f1
Author:Vincent Guittot
AuthorDate:Wed, 24 Feb 2021 14:30:01 +01:00
The following commit has been merged into the sched/core branch of tip:
Commit-ID: 2aa7f2f6d1e4308b81bef079091561445b9cb949
Gitweb:
https://git.kernel.org/tip/2aa7f2f6d1e4308b81bef079091561445b9cb949
Author:Vincent Guittot
AuthorDate:Wed, 24 Feb 2021 14:30:04 +01:00
The following commit has been merged into the sched/core branch of tip:
Commit-ID: 053192dea58da994fb3dd7ad235440accf292a08
Gitweb:
https://git.kernel.org/tip/053192dea58da994fb3dd7ad235440accf292a08
Author:Vincent Guittot
AuthorDate:Wed, 24 Feb 2021 14:30:05 +01:00
The following commit has been merged into the sched/core branch of tip:
Commit-ID: f2c0af1dabdae4674fb7ddba0ac88ca78d0fe675
Gitweb:
https://git.kernel.org/tip/f2c0af1dabdae4674fb7ddba0ac88ca78d0fe675
Author:Vincent Guittot
AuthorDate:Wed, 24 Feb 2021 14:30:02 +01:00
The following commit has been merged into the sched/core branch of tip:
Commit-ID: 8af3f0fbfbaa3b78bb1fc577ee42c3228f3cc822
Gitweb:
https://git.kernel.org/tip/8af3f0fbfbaa3b78bb1fc577ee42c3228f3cc822
Author:Vincent Guittot
AuthorDate:Wed, 24 Feb 2021 14:30:03 +01:00
The following commit has been merged into the sched/core branch of tip:
Commit-ID: 81df323258719a0194fadbf4aa93e213a552e460
Gitweb:
https://git.kernel.org/tip/81df323258719a0194fadbf4aa93e213a552e460
Author:Vincent Guittot
AuthorDate:Wed, 24 Feb 2021 14:30:02 +01:00
The following commit has been merged into the sched/core branch of tip:
Commit-ID: 839ffb99d94f930fecbdee2fdfb883b10c30326b
Gitweb:
https://git.kernel.org/tip/839ffb99d94f930fecbdee2fdfb883b10c30326b
Author:Vincent Guittot
AuthorDate:Wed, 24 Feb 2021 14:30:07 +01:00
The following commit has been merged into the sched/core branch of tip:
Commit-ID: c0d2f3b54ed88ce1079f8ffb094205d3f578a9bb
Gitweb:
https://git.kernel.org/tip/c0d2f3b54ed88ce1079f8ffb094205d3f578a9bb
Author:Vincent Guittot
AuthorDate:Wed, 24 Feb 2021 14:30:04 +01:00
The following commit has been merged into the sched/core branch of tip:
Commit-ID: 06a35afe89800789fc47ca5c41fbe435cc77d8e0
Gitweb:
https://git.kernel.org/tip/06a35afe89800789fc47ca5c41fbe435cc77d8e0
Author:Vincent Guittot
AuthorDate:Wed, 24 Feb 2021 14:30:01 +01:00
The following commit has been merged into the sched/core branch of tip:
Commit-ID: 1705e3b449f62d957e897239ef6c67ca574acfc6
Gitweb:
https://git.kernel.org/tip/1705e3b449f62d957e897239ef6c67ca574acfc6
Author:Vincent Guittot
AuthorDate:Wed, 24 Feb 2021 14:30:06 +01:00
The following commit has been merged into the sched/core branch of tip:
Commit-ID: 0c067f38e1b9640e9121fb7e0bb38fa8f867a248
Gitweb:
https://git.kernel.org/tip/0c067f38e1b9640e9121fb7e0bb38fa8f867a248
Author:Vincent Guittot
AuthorDate:Wed, 24 Feb 2021 14:30:05 +01:00
UtilConvergence:test_means on
> the sd845c board.
>
> No regression observed with Hackbench on sd845c and Perf-bench sched pipe
> on hikey/hikey960.
>
> Signed-off-by: Vincent Donnefort
> Reviewed-by: Dietmar Eggemann
Reviewed-by: Vincent Guittot
>
> diff --git a/kernel/s
oing a load balance before a offline tasks to run.
>
> Signed-off-by: Chen Xiaoguang
> Signed-off-by: Chen He
Reviewed-by: Vincent Guittot
Thanks
> ---
> v1 -> v2:
> - Add checking in balance_fair
> - Remove task state checking in pick_next_task_fair
&
On Mon, 22 Feb 2021 at 10:24, Vincent Donnefort
wrote:
>
> On Fri, Feb 19, 2021 at 11:48:28AM +0100, Vincent Guittot wrote:
> > On Tue, 16 Feb 2021 at 17:39, wrote:
> > >
> > > From: Vincent Donnefort
> > >
> > > Being called for each deq
Hi Valentin,
On Wed, 24 Feb 2021 at 19:46, Valentin Schneider
wrote:
>
> On 24/02/21 14:30, Vincent Guittot wrote:
> > Joel reported long preempt and irq off sequence in newidle_balance because
> > of a large number of CPU cgroups in use and having to be updated. This
On Wed, 24 Feb 2021 at 18:41, Peter Zijlstra wrote:
>
> On Wed, Feb 24, 2021 at 04:57:15PM +0100, Vincent Guittot wrote:
> > On Wed, 24 Feb 2021 at 16:54, Peter Zijlstra wrote:
> > >
> > > On Wed, Feb 24, 2021 at 02:30:00PM +0100, Vincent Guittot wrote:
> > &g
On Wed, 24 Feb 2021 at 16:54, Peter Zijlstra wrote:
>
> On Wed, Feb 24, 2021 at 02:30:00PM +0100, Vincent Guittot wrote:
> > Joel reported long preempt and irq off sequence in newidle_balance because
> > of a large number of CPU cgroups in use and having to be updated. This
Instead of waking up a random and already idle CPU, we can take advantage
of this_cpu being about to enter idle to run the ILB and update the
blocked load.
Signed-off-by: Vincent Guittot
---
kernel/sched/core.c | 2 +-
kernel/sched/fair.c | 24 +---
kernel/sched/idle.c
Start to update last_blocked_load_update_tick to reduce the possibility
of another cpu starting the update one more time
Signed-off-by: Vincent Guittot
---
kernel/sched/fair.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/kernel/sched/fair.c b/kernel/sched
Reorder the tests and skip useless ones when no load balance has been
performed and rq lock has not been released.
Signed-off-by: Vincent Guittot
---
kernel/sched/fair.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
update. We don't need a special case for handling the update of
nohz.next_balance for this_cpu anymore because it is now handled by the
loop like others.
Signed-off-by: Vincent Guittot
---
kernel/sched/fair.c | 32 +++-
1 file changed, 7 insertions(+), 25 deletions
idle load balance is the only user of update_nohz_stats and doesn't use
force parameter. Remove it
Signed-off-by: Vincent Guittot
---
kernel/sched/fair.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index e23709f6854b
the update from newidle_balance and trigger a normal ILB that
will take care of the update instead.
Signed-off-by: Vincent Guittot
---
kernel/sched/fair.c | 33 +
1 file changed, 5 insertions(+), 28 deletions(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
The return of _nohz_idle_balance() is not used anymore so we can remove
it
Signed-off-by: Vincent Guittot
---
kernel/sched/fair.c | 10 +-
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 0d45b7716384..e23709f6854b 100644
ave been removed yet from previous
idle phase.
Vincent Guittot (7):
sched/fair: remove update of blocked load from newidle_balance
sched/fair: remove unused return of _nohz_idle_balance
sched/fair: remove unused parameter of update_nohz_stats
sched/fair: merge for each idle cpu loop of ILB
On Tue, 23 Feb 2021 at 06:41, Li, Aubrey wrote:
>
> Hi Vincent,
>
> Sorry for the delay, I just returned from Chinese New Year holiday.
>
> On 2021/1/25 22:51, Vincent Guittot wrote:
> > On Mon, 25 Jan 2021 at 15:00, Li, Aubrey wrote:
> >>
> >>
On Tue, 23 Feb 2021 at 13:03, Valentin Schneider
wrote:
>
>
> +Vincent
>
> On 22/02/21 09:12, syzbot wrote:
> > syzbot has found a reproducer for the following issue on:
> >
> > HEAD commit:31caf8b2 Merge branch 'linus' of git://git.kernel.org/pub/..
> > git tree: upstream
> > console
On Tue, 16 Feb 2021 at 17:39, wrote:
>
> From: Vincent Donnefort
>
> Being called for each dequeue, util_est reduces the number of its updates
> by filtering out when the EWMA signal is different from the task util_avg
> by less than 1%. It is a problem for a sudden util_avg ramp-up. Due to the
On Wed, 17 Feb 2021 at 12:51, Valentin Schneider
wrote:
>
> On 15/02/21 16:02, Vincent Guittot wrote:
> > On Fri, 12 Feb 2021 at 20:19, Valentin Schneider
> > wrote:
> >> I don't think there is anything inherently wrong with it - the
> >> nohz_idle_balanc
On Fri, 12 Feb 2021 at 20:19, Valentin Schneider
wrote:
>
> On 12/02/21 15:17, Vincent Guittot wrote:
> > Instead of waking up a random and already idle CPU, we can take advantage
> > of this_cpu being about to enter idle to run the ILB and update the
> > blocked
Start to update last_blocked_load_update_tick to reduce the possibility
of another cpu starting the update one more time
Signed-off-by: Vincent Guittot
---
kernel/sched/fair.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/kernel/sched/fair.c b/kernel/sched
Instead of waking up a random and already idle CPU, we can take advantage
of this_cpu being about to enter idle to run the ILB and update the
blocked load.
Signed-off-by: Vincent Guittot
---
kernel/sched/fair.c | 24 +---
kernel/sched/idle.c | 6 ++
kernel/sched
Reorder the tests and skip useless ones when no load balance has been
performed and rq lock has not been released.
Signed-off-by: Vincent Guittot
---
kernel/sched/fair.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
idle load balance is the only user of update_nohz_stats and doesn't use
force parameter. Remove it
Signed-off-by: Vincent Guittot
---
kernel/sched/fair.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index f3f0f8cca061
the update from newidle_balance and trigger a normal ILB that
will take care of the update instead.
Signed-off-by: Vincent Guittot
---
kernel/sched/fair.c | 33 +
1 file changed, 5 insertions(+), 28 deletions(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
update. We don't need a special case for handling the update of
nohz.next_balance for this_cpu anymore because it is now handled by the
loop like others.
Signed-off-by: Vincent Guittot
---
kernel/sched/fair.c | 32 +++-
1 file changed, 7 insertions(+), 25 deletions
1 - 100 of 3961 matches
Mail list logo
