Re: [PATCH] Sky Cpu: use C99 style for struct init

2007-07-06 Thread Vincent Hanquez
On Thu, Jul 05, 2007 at 09:59:10PM +0400, Cyrill Gorcunov wrote: > + .fasync= NULL, > + .poll = NULL, > + .ioctl = NULL, you can remove those since C99 automaticly initialize missing fields to 0. Cheers, -- Vincent Hanquez - To unsubscribe from this list: send

Re: kernel guide to space (updated)

2005-07-30 Thread Vincent Hanquez
is an option. please no, it's really better to have a unified CodingStyle. and "if (" is a lot more used than "if(". $ grep -r "if (" linux-2.6.12/* | wc -l 288027 $ grep -r "if(" linux-2.6.12/* | wc -l 20682 -- Vincent Hanquez - To unsubscribe from

[PATCH] arch/i386/kernel/signal.c: fix err test twice

2005-01-19 Thread Vincent Hanquez
Hi, the following patch: - correct the err variable tested twice when _NSIG_WORDS == 1 (unlikely to happen, but ..) - remove some |= in favor of = because we don't need to 'pack' err Please apply, Signed-off-by: Vincent Hanquez <[EMAIL PROTECTED]>