[PATCH v3] cifs: Silently ignore unknown oplock break handle

2021-03-19 Thread Vincent Whitchurch
NumMids 2 : 424d53fe 0040 0012 .SMB@... 0010: 0001 0020: 0030: Signed-off-by: Vincent Whitchurch

[PATCH v2] cifs: Silently ignore unknown oplock break handle

2021-03-16 Thread Vincent Whitchurch
f 0020: 0030: Signed-off-by: Vincent Whitchurch --- Notes: v2: - Drop change to lease break - Rewrite commit message fs/cifs/smb2misc.c

Re: [PATCH] CIFS: Prevent error log on spurious oplock break

2021-03-12 Thread Vincent Whitchurch
On Tue, Mar 09, 2021 at 04:29:14PM +0100, Steve French wrote: > On Tue, Mar 9, 2021, 07:42 Vincent Whitchurch via samba-technical > mailto:samba-techni...@lists.samba.org>> > wrote: >> Thank you for the suggestions. In my case, I've only received some >> reports

Re: [PATCH] CIFS: Prevent error log on spurious oplock break

2021-03-09 Thread Vincent Whitchurch
On Tue, Mar 09, 2021 at 01:05:11AM +0100, ronnie sahlberg wrote: > On Sun, Mar 7, 2021 at 8:52 PM Shyam Prasad N via samba-technical > wrote: > > The reason for rejecting the request maybe a number of things like: > > corrupted request, stale request (for some old session), or for a > > wrong hand

[PATCH] CIFS: Prevent error log on spurious oplock break

2021-03-05 Thread Vincent Whitchurch
ch we ignore as per the spec. Signed-off-by: Vincent Whitchurch --- fs/cifs/smb2misc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/cifs/smb2misc.c b/fs/cifs/smb2misc.c index 60d4bd1eae2b..3ea3bda64083 100644 --- a/fs/cifs/smb2misc.c +++ b/fs/cifs

Re: [PATCH 1/9] regulator: Update DA9121 dt-bindings

2020-11-25 Thread Vincent Whitchurch
On Fri, Nov 20, 2020 at 02:47:42PM +0100, Vincent Whitchurch wrote: > On Fri, Nov 20, 2020 at 01:14:50PM +0100, Adam Ward wrote: > > - buck1: > > -description: > > - Initial data for the Buck1 regulator. > > -$ref: "regulator.yaml#" > >

Re: [PATCH 1/9] regulator: Update DA9121 dt-bindings

2020-11-20 Thread Vincent Whitchurch
ml > @@ -8,40 +8,185 @@ title: Dialog Semiconductor DA9121 voltage regulator > > maintainers: >- Vincent Whitchurch > + - Adam Ward I'm quite happy to have myself removed from the list instead. You are in a much better position to maintain the bindings for these chip

Re: [PATCH 4.19 48/71] of: Fix reserved-memory overlap detection

2020-11-11 Thread Vincent Whitchurch
On Wed, Nov 11, 2020 at 01:53:59PM +0100, Pavel Machek wrote: > > OF: reserved mem: OVERLAP DETECTED! > > bar@0 (0x--0x1000) overlaps with foo@0 (0x--0x2000) > > OF: reserved mem: OVERLAP DETECTED! > > foo@0 (0x--0x2000) overlaps with baz@1000 > > (0x100

[PATCH] dt-bindings: regulator: da9121: Use additionalProperties

2020-11-09 Thread Vincent Whitchurch
Herring Signed-off-by: Vincent Whitchurch --- Documentation/devicetree/bindings/regulator/dlg,da9121.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/regulator/dlg,da9121.yaml b/Documentation/devicetree/bindings/regulator/dlg,da

Re: [PATCH v2 1/2] dt-bindings: regulator: Add DA9121

2020-11-05 Thread Vincent Whitchurch
On Wed, Nov 04, 2020 at 07:57:55PM +0100, Rob Herring wrote: > On Tue, 03 Nov 2020 11:00:20 +0100, Vincent Whitchurch wrote: > > Add bindings for the Dialog Semiconductor DA9121 voltage regulator. > > > > Signed-off-by: Vincent Whitchurch > > --- > > .../b

Re: [PATCH AUTOSEL 4.4 3/5] of: Fix reserved-memory overlap detection

2020-11-03 Thread Vincent Whitchurch
On Tue, Nov 03, 2020 at 02:21:16AM +0100, Sasha Levin wrote: > From: Vincent Whitchurch > > [ Upstream commit ca05f33316559a04867295dd49f85aeedbfd6bfd ] > > The reserved-memory overlap detection code fails to detect overlaps if > either of the regions starts at address 0x0. T

[PATCH v2 0/2] DA9121 regulator support

2020-11-03 Thread Vincent Whitchurch
ode in the device tree. Vincent Whitchurch (2): dt-bindings: regulator: Add DA9121 regulator: Add support for DA9121 regulator .../bindings/regulator/dlg,da9121.yaml| 47 drivers/regulator/Kconfig | 12 ++ drivers/regulator/Makefile| 1

[PATCH v2 1/2] dt-bindings: regulator: Add DA9121

2020-11-03 Thread Vincent Whitchurch
Add bindings for the Dialog Semiconductor DA9121 voltage regulator. Signed-off-by: Vincent Whitchurch --- .../bindings/regulator/dlg,da9121.yaml| 47 +++ 1 file changed, 47 insertions(+) create mode 100644 Documentation/devicetree/bindings/regulator/dlg,da9121.yaml

[PATCH v2 2/2] regulator: Add support for DA9121 regulator

2020-11-03 Thread Vincent Whitchurch
Add support for the Dialog Semiconductor DA9121, a single-channel dual-phase buck converter controlled via I2C. Signed-off-by: Vincent Whitchurch --- drivers/regulator/Kconfig| 12 +++ drivers/regulator/Makefile | 1 + drivers/regulator/da9121-regulator.c | 108

Re: [PATCH 2/2] regulator: Add support for DA9121 regulator

2020-11-02 Thread Vincent Whitchurch
On Thu, Oct 29, 2020 at 03:28:43PM +, Mark Brown wrote: > On Thu, Oct 29, 2020 at 04:15:38PM +0100, Vincent Whitchurch wrote: > > > + config.init_data = of_get_regulator_init_data(dev, dev->of_node, > > &da9121_reg); > > + if (!config.init_data) > > +

[PATCH 0/2] DA9121 regulator support

2020-10-29 Thread Vincent Whitchurch
This series adds support for the DA9121, a "High-Performance, 10 A, Dual-Phase DC-DC Converter". The datasheet is currently available here: https://www.dialog-semiconductor.com/sites/default/files/da9121_datasheet_2v3.pdf Vincent Whitchurch (2): dt-bindings: regulator:

[PATCH 1/2] dt-bindings: regulator: Add DA9121

2020-10-29 Thread Vincent Whitchurch
Add bindings for the Dialog Semiconductor DA9121 voltage regulator. Signed-off-by: Vincent Whitchurch --- .../bindings/regulator/dlg,da9121.yaml| 42 +++ 1 file changed, 42 insertions(+) create mode 100644 Documentation/devicetree/bindings/regulator/dlg,da9121.yaml

[PATCH 2/2] regulator: Add support for DA9121 regulator

2020-10-29 Thread Vincent Whitchurch
Add support for the Dialog Semiconductor DA9121, a single-channel dual-phase buck converter controlled via I2C. Signed-off-by: Vincent Whitchurch --- drivers/regulator/Kconfig| 12 +++ drivers/regulator/Makefile | 1 + drivers/regulator/da9121-regulator.c | 111

Re: [PATCH V3 2/4] misc: vop: do not allocate and reassign the used ring

2020-10-29 Thread Vincent Whitchurch
On Wed, Oct 28, 2020 at 04:50:36PM +0100, Arnd Bergmann wrote: > I think we should try to do something on top of the PCIe endpoint subsystem > to make it work across arbitrary combinations of host and device > implementations, > and provide a superset of what the MIC driver, (out-of-tree) Bluefield

[PATCH v4] gpio: mockup: Allow probing from device tree

2020-10-29 Thread Vincent Whitchurch
Allow the mockup driver to be probed via the device tree without any module parameters, allowing it to be used to configure and test higher level drivers like the leds-gpio driver and corresponding userspace before actual hardware is available. Signed-off-by: Vincent Whitchurch --- Notes

Re: [PATCH v2] gpio: mockup: Allow probing from device tree

2020-10-29 Thread Vincent Whitchurch
On Wed, Oct 28, 2020 at 09:25:32PM +0100, Andy Shevchenko wrote: > On Wed, Oct 28, 2020 at 8:41 PM Bartosz Golaszewski wrote: > > On Tue, Oct 27, 2020 at 2:54 PM Vincent Whitchurch > > > +#ifdef CONFIG_OF > > > +static const struct of_dev

[PATCH v3] gpio: mockup: Allow probing from device tree

2020-10-28 Thread Vincent Whitchurch
Allow the mockup driver to be probed via the device tree without any module parameters, allowing it to be used to configure and test higher level drivers like the leds-gpio driver and corresponding userspace before actual hardware is available. Signed-off-by: Vincent Whitchurch --- Notes

Re: [PATCH v2] gpio: mockup: Allow probing from device tree

2020-10-28 Thread Vincent Whitchurch
On Tue, Oct 27, 2020 at 07:12:13PM +0100, Bartosz Golaszewski wrote: > On Tue, Oct 27, 2020 at 2:54 PM Vincent Whitchurch > wrote: > > diff --git a/drivers/gpio/gpio-mockup.c b/drivers/gpio/gpio-mockup.c > > index 67ed4f238d43..c93892a6936a 100644 > > --- a/drivers/gpio

Re: [PATCH v2] gpio: mockup: Allow probing from device tree

2020-10-28 Thread Vincent Whitchurch
On Wed, Oct 28, 2020 at 12:43:22PM +0100, Andy Shevchenko wrote: > On Wed, Oct 28, 2020 at 10:00 AM Vincent Whitchurch > wrote: > > Allow the mockup driver to be probed via the device tree without any > > module parameters, allowing it to be used to configure and test higher

Re: [PATCH V5 0/2] Change vring space from nomal memory to dma coherent memory

2020-10-28 Thread Vincent Whitchurch
On Wed, Oct 28, 2020 at 06:58:36AM +0100, Greg KH wrote: > Have you all seen: > > https://lore.kernel.org/r/8c1443136563de34699d2c084df478181c205db4.1603854416.git.sudeep.d...@intel.com No, that link doesn't work and I can't find that email from Sudeep in any of the archives: https://lore

Re: [PATCH V3 2/4] misc: vop: do not allocate and reassign the used ring

2020-10-28 Thread Vincent Whitchurch
On Wed, Oct 28, 2020 at 02:47:49AM +0100, Sherry Sun wrote: > > Subject: Re: [PATCH V3 2/4] misc: vop: do not allocate and reassign the used > > ring > > > > On Tue, Oct 27, 2020 at 08:05:43AM +0100, Sherry Sun wrote: > > > Can you help test the patch about removing the codes of reassign used > >

Re: [PATCH V3 2/4] misc: vop: do not allocate and reassign the used ring

2020-10-27 Thread Vincent Whitchurch
On Tue, Oct 27, 2020 at 08:05:43AM +0100, Sherry Sun wrote: > Can you help test the patch about removing the codes of reassign used > ring, and comment on the impact for Intel MIC platform? Thanks for > any help. I don't have access to MIC hardware myself, either. But this patch is quite certain

[PATCH v2] gpio: mockup: Allow probing from device tree

2020-10-27 Thread Vincent Whitchurch
Allow the mockup driver to be probed via the device tree without any module parameters, allowing it to be used to configure and test higher level drivers like the leds-gpio driver and corresponding userspace before actual hardware is available. Signed-off-by: Vincent Whitchurch --- v2: Remove

Re: [PATCH] of: Fix reserved-memory overlap detection

2020-10-21 Thread Vincent Whitchurch
On Tue, Oct 20, 2020 at 04:17:27PM +0200, Rob Herring wrote: > On Tue, Oct 20, 2020 at 8:46 AM Vincent Whitchurch > wrote: > > On Tue, Oct 20, 2020 at 03:00:14PM +0200, Rob Herring wrote: > > > On Tue, Oct 20, 2020 at 2:36 AM Vincent Whitchurch > > > wrote: >

[PATCH v2] of: Fix reserved-memory overlap detection

2020-10-21 Thread Vincent Whitchurch
: OVERLAP DETECTED! bar@0 (0x--0x1000) overlaps with foo@0 (0x--0x2000) OF: reserved mem: OVERLAP DETECTED! foo@0 (0x--0x2000) overlaps with baz@1000 (0x1000--0x00002000) Signed-off-by: Vincent Whitchurch --- v2: Fix handling of dynamically allocat

Re: [PATCH] of: Fix reserved-memory overlap detection

2020-10-20 Thread Vincent Whitchurch
On Tue, Oct 20, 2020 at 03:00:14PM +0200, Rob Herring wrote: > On Tue, Oct 20, 2020 at 2:36 AM Vincent Whitchurch > wrote: > > > > The reserved-memory overlap detection code fails to detect overlaps if > > either of the regions starts at address 0x0. For some reason

[PATCH] of: Fix reserved-memory overlap detection

2020-10-20 Thread Vincent Whitchurch
(0x1000--0x2000) Signed-off-by: Vincent Whitchurch --- drivers/of/of_reserved_mem.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/of/of_reserved_mem.c b/drivers/of/of_reserved_mem.c index 46b9371c8a33..1c5259e3e81f 100644 --- a/drivers/of/of_reserved_mem.c +

Re: [PATCH AUTOSEL 4.14 05/15] regulator: pwm: Fix machine constraints application

2020-09-15 Thread Vincent Whitchurch
On Mon, Sep 14, 2020 at 03:05:16PM +0200, Sasha Levin wrote: > From: Vincent Whitchurch > > [ Upstream commit 59ae97a7a9e1499c2070e29841d1c4be4ae2994a ] > > If the zero duty cycle doesn't correspond to any voltage in the voltage > table, the PWM regulator returns an -EINV

[PATCH] regulator: pwm: Fix machine constraints application

2020-09-02 Thread Vincent Whitchurch
fooregulator: failed to get the current voltage(-22) After this patch: fooregulator: Setting 225-225uV fooregulator: 2250 mV Signed-off-by: Vincent Whitchurch --- drivers/regulator/pwm-regulator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/

Re: [PATCH v3 2/2] dynamic debug: allow printing to trace event

2020-09-02 Thread Vincent Whitchurch
On Wed, Aug 26, 2020 at 09:53:57PM +0200, Joe Perches wrote: > On Wed, 2020-08-26 at 15:32 -0400, Steven Rostedt wrote: > > On Tue, 25 Aug 2020 08:53:25 -0700 > > Joe Perches wrote: > > > > > > The print buffer is statically allocated and managed using code borrowed > > > > from __ftrace_trace_st

Re: [PATCH v2] dynamic debug: allow printing to trace event

2020-08-25 Thread Vincent Whitchurch
On Fri, Aug 14, 2020 at 07:15:31PM +0200, Steven Rostedt wrote: > On Fri, 14 Aug 2020 15:31:51 +0200 > Vincent Whitchurch wrote: > > index aa9ff9e1c0b3..f599ed21ecc5 100644 > > --- a/include/linux/dynamic_debug.h > > +++ b/include/linux/dynamic_debug.h > > @@ -

[PATCH v3 2/2] dynamic debug: allow printing to trace event

2020-08-25 Thread Vincent Whitchurch
e truncated. Signed-off-by: Vincent Whitchurch --- .../admin-guide/dynamic-debug-howto.rst | 1 + include/linux/dynamic_debug.h | 4 +- include/trace/events/printk.h | 12 +- lib/dynamic_debug.c | 153 +++---

[PATCH v3 0/2] Dynamic debug trace support

2020-08-25 Thread Vincent Whitchurch
v3: - Split flag rename to a separate patch - Rename event to printk:dyndbg v2: - Remove stack buffer and use code similar to __ftrace_trace_stack() - Use an event with the same class as printk:console Vincent Whitchurch (2): dynamic debug: split enable and printk flags dynamic debug

[PATCH v3 1/2] dynamic debug: split enable and printk flags

2020-08-25 Thread Vincent Whitchurch
ff-by: Vincent Whitchurch --- include/linux/dynamic_debug.h | 9 + lib/dynamic_debug.c | 8 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/include/linux/dynamic_debug.h b/include/linux/dynamic_debug.h index aa9ff9e1c0b3..738421898aac 100644 --- a/include/

Re: [PATCH v2] dynamic debug: allow printing to trace event

2020-08-25 Thread Vincent Whitchurch
On Fri, Aug 14, 2020 at 11:30:34PM +0200, Jason Baron wrote: > On 8/14/20 1:15 PM, Steven Rostedt wrote: > > On Fri, 14 Aug 2020 15:31:51 +0200 > > Vincent Whitchurch wrote: > >> index aa9ff9e1c0b3..f599ed21ecc5 100644 > >> --- a/include/linux/dynamic

Re: [PATCH] dynamic debug: allow printing to trace event

2020-08-14 Thread Vincent Whitchurch
On Thu, Jul 23, 2020 at 05:26:44PM +0200, Steven Rostedt wrote: > On Thu, 23 Jul 2020 12:57:35 +0200 > Vincent Whitchurch wrote: > > > Would it be acceptable to just use a fixed size for the event? At least > > for my own debugging use cases it's preferable to jus

[PATCH v2] dynamic debug: allow printing to trace event

2020-08-14 Thread Vincent Whitchurch
er will be truncated. Signed-off-by: Vincent Whitchurch --- v2: - Remove stack buffer and use code similar to __ftrace_trace_stack() - Use an event with the same class as printk:console .../admin-guide/dynamic-debug-howto.rst | 1 + include/linux/dynamic_debug.h | 7 +-

[PATCH] perf bench mem: Always memset source before memcpy

2020-08-10 Thread Vincent Whitchurch
LLC-loads 8.674301124 seconds time elapsed $ $cmd --cycles 214,758,651 LLC-loads 8.644480006 seconds time elapsed Fixes: 47b5757bac03c3387c ("perf bench mem: Move boilerplate memory allocation to the infrastructure") Signed-off-by: Vincent Whitchurch --- tools/perf/b

[PATCH] tracing: Remove outdated comment in stack handling

2020-07-27 Thread Vincent Whitchurch
ned in the comment has never existed, it probably should have said FTRACE_STACK_ENTRIES.) Signed-off-by: Vincent Whitchurch --- kernel/trace/trace.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c index bb62269724d5..0a0fd197888c 100644 --- a/ke

Re: [PATCH] dynamic debug: allow printing to trace event

2020-07-23 Thread Vincent Whitchurch
On Wed, Jul 22, 2020 at 05:28:23PM +0200, Steven Rostedt wrote: > For you, I made this quick patch. If this works for you, I can make it > into a formal patch. It includes a test use case in do_sys_openat2() to > show the file name and file descriptor. Obviously, that wont be part of > the final pa

Re: [PATCH 6/7] usb: dwc3: Add support for a role-switch notifier

2020-07-23 Thread Vincent Whitchurch
On Wed, Mar 11, 2020 at 07:15:00PM +, Bryan O'Donoghue wrote: > diff --git a/drivers/usb/dwc3/drd.c b/drivers/usb/dwc3/drd.c > index 2705871ec95e..789e93dd93b4 100644 > --- a/drivers/usb/dwc3/drd.c > +++ b/drivers/usb/dwc3/drd.c > @@ -497,6 +497,8 @@ static int dwc3_usb_role_switch_set(struct

Re: [PATCH v3] usb: dwc3: Add support for VBUS power control

2020-07-23 Thread Vincent Whitchurch
On Fri, Jun 19, 2020 at 04:25:12PM +0200, Mike Looijmans wrote: > +void dwc3_set_vbus(struct dwc3 *dwc, bool enable) > +{ > + int ret; > + > + if (enable != dwc->vbus_reg_enabled) { > + if (enable) > + ret = regulator_enable(dwc->vbus_reg); > + el

Re: [PATCH] dynamic debug: allow printing to trace event

2020-07-22 Thread Vincent Whitchurch
On Wed, Jul 22, 2020 at 03:52:22PM +0200, John Ogness wrote: > On 2020-07-21, Steven Rostedt wrote: > >> diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c > >> index 321437bbf87d..9f6d8867af7c 100644 > >> --- a/lib/dynamic_debug.c > >> +++ b/lib/dynamic_debug.c > [..] > >> +static void dynami

[PATCH] dynamic debug: allow printing to trace event

2020-07-21 Thread Vincent Whitchurch
nt. The trace event can be emitted instead of or in addition to the printk(). The print buffer is placed on the stack and is limited to a somewhat arbitrarily chosen 256 bytes; anything larger will be truncated. Signed-off-by: Vincent Whitchurch --- .../admin-guide/dynamic-debug-howto.rst

Re: [PATCH v2 1/2] module: allow arch overrides for .init section names

2020-05-14 Thread Vincent Whitchurch
On Mon, May 11, 2020 at 05:45:00PM +0200, Jessica Yu wrote: > +++ Vincent Whitchurch [11/05/20 13:48 +0200]: > >ARM stores unwind information for .init.text in sections named > >.ARM.extab.init.text and .ARM.exidx.init.text. Since those aren't > >currently recognized

[PATCH v2 2/2] ARM: module: fix handling of unwind init sections

2020-05-11 Thread Vincent Whitchurch
of range (0xcbb54078 -> 0x7f80) Fix this by informing the module core that these sections are init sections, and by removing the init unwind tables before the module core frees the init sections. Signed-off-by: Vincent Whitchurch --- v2: No changes. arch/arm/kernel/module.c | 22 +++

[PATCH v2 1/2] module: allow arch overrides for .init section names

2020-05-11 Thread Vincent Whitchurch
override the section name so that ARM can fix this. Signed-off-by: Vincent Whitchurch --- v2: Add comment and move module_init_section() next to module_exit_section(). include/linux/moduleloader.h | 5 + kernel/module.c | 9 +++-- 2 files changed, 12 insertions(+), 2 deleti

[PATCH 1/2] module: allow arch overrides for .init section names

2020-05-06 Thread Vincent Whitchurch
override the section name so that ARM can fix this. Signed-off-by: Vincent Whitchurch --- include/linux/moduleloader.h | 2 ++ kernel/module.c | 9 +++-- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/include/linux/moduleloader.h b/include/linux/modul

[PATCH 2/2] ARM: module: fix handling of unwind init sections

2020-05-06 Thread Vincent Whitchurch
of range (0xcbb54078 -> 0x7f80) Fix this by informing the module core that these sections are init sections, and by removing the init unwind tables before the module core frees the init sections. Signed-off-by: Vincent Whitchurch --- arch/arm/kernel/module.c | 22 +++--- 1 file chang

Re: [PATCH v2] printk: Do not lose last line in kmsg buffer dump

2019-07-12 Thread Vincent Whitchurch
On Fri, Jul 12, 2019 at 10:09:04AM +0200, Petr Mladek wrote: > The patch looks like a hack using a hole that the next cycle > does not longer check the number of really stored characters. > > What would happen when msg_print_text() starts adding > the trailing '\0' as suggested by > https://lkml.k

[PATCH v2] printk: Do not lose last line in kmsg buffer dump

2019-07-11 Thread Vincent Whitchurch
31 32 33 34 35 0a ] 12345. 0020: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0030: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 Signed-off-by: Vincent Whitchurch --- v2: Move fix to kmsg_dump_get_buffer() kernel/printk/printk.c | 2 +- 1 file cha

Re: [PATCH] printk: Do not lose last line in kmsg dump

2019-07-10 Thread Vincent Whitchurch
On Tue, Jul 09, 2019 at 04:29:39PM +0200, Petr Mladek wrote: > On Tue 2019-07-09 19:12:30, Sergey Senozhatsky wrote: > > On (07/09/19 10:10), Vincent Whitchurch wrote: > > > A dump of a 64-byte buffer filled by kmsg_dump_get_buffer(), before this > > > patch: > > &

[PATCH] printk: Do not lose last line in kmsg dump

2019-07-09 Thread Vincent Whitchurch
lways LOG_LINE_MAX + PREFIX_MAX, and PREFIX_MAX has a value which is larger than the largest possible prefix). Signed-off-by: Vincent Whitchurch --- I posted this patch two years ago and received no replies. This problem is still present in mainline. https://lore.kernel.org/patchwork/patch/78110

[PATCH] crypto: cryptd - Fix skcipher instance memory leak

2019-07-02 Thread Vincent Whitchurch
2, jiffies 4294894830 (age 52.760s) backtrace: kmem_cache_alloc_trace+0x270/0x2d0 cryptd_create+0x990/0x124c cryptomgr_probe+0x5c/0x1e8 kthread+0x258/0x318 ret_from_fork+0x10/0x1c Signed-off-by: Vincent Whitchurch --- crypto/cryptd.c | 1 + 1 file changed, 1 insertion(+) di

Re: [PATCH] tty: Add NULL TTY driver

2019-04-11 Thread Vincent Whitchurch
On Fri, Apr 05, 2019 at 02:32:41PM +0200, Enrico Weigelt, metux IT consult wrote: > On 05.04.19 11:00, Vincent Whitchurch wrote: > > On Fri, Apr 05, 2019 at 10:39:43AM +0200, Enrico Weigelt, metux IT consult > > wrote: > >> On 03.04.19 16:11, Vincent Whitchurch wrote:

Re: [PATCH] tty: Add NULL TTY driver

2019-04-05 Thread Vincent Whitchurch
On Fri, Apr 05, 2019 at 10:39:43AM +0200, Enrico Weigelt, metux IT consult wrote: > On 03.04.19 16:11, Vincent Whitchurch wrote: > > > Especially on embedded systems, it would be convenient to have a simple > > way to disable the console (both for kernel and userspace) on

Re: [PATCH] tty: Add NULL TTY driver

2019-04-03 Thread Vincent Whitchurch
On Wed, Apr 03, 2019 at 03:12:13PM +0200, Greg KH wrote: > On Wed, Apr 03, 2019 at 01:33:27PM +0200, Vincent Whitchurch wrote: > > If no console driver is enabled (or if a non-present driver is selected > > with something like console=null in an attempt to disable the console), &

[PATCH] tty: Add NULL TTY driver

2019-04-03 Thread Vincent Whitchurch
. with console=ttynull. Signed-off-by: Vincent Whitchurch --- drivers/tty/Kconfig | 14 ++ drivers/tty/Makefile | 1 + drivers/tty/ttynull.c | 109 ++ 3 files changed, 124 insertions(+) create mode 100644 drivers/tty/ttynull.c diff --git a

[PATCH v2 char-misc-next 0/7] Virtio-over-PCIe on non-MIC

2019-02-22 Thread Vincent Whitchurch
patches which have merged - Use unsigned long instead of uintptr_t - Drop "Use consistent DMA" for now since it's not needed for loopback - Add race fix - Build on all architectures, not just ARM and x86 - Add sample userspace code Vincent Whitchurch (7): mic: vop: Cast pointers t

[PATCH v2 char-misc-next 7/7] samples: mic: Add sample VOP userspace

2019-02-22 Thread Vincent Whitchurch
uest: # ping6 fe80::1%mic0 Ping from guest to host: # ping6 fe80::0%eth1 Signed-off-by: Vincent Whitchurch --- samples/mic/mpssd/.gitignore | 1 + samples/mic/mpssd/Makefile | 5 - samples/mic/mpssd/vopd.c | 25 + 3 files changed, 30 insertions(+), 1 dele

[PATCH v2 char-misc-next 1/7] mic: vop: Cast pointers to unsigned long

2019-02-22 Thread Vincent Whitchurch
Fix these on 32-bit: vop_vringh.c:711:13: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast] Signed-off-by: Vincent Whitchurch --- drivers/misc/mic/vop/vop_main.c | 13 + drivers/misc/mic/vop/vop_vringh.c | 5 +++-- 2 files changed, 12

[PATCH v2 char-misc-next 2/7] mic: Rename ioremap pointer to remap

2019-02-22 Thread Vincent Whitchurch
o "ioremap" passed 3 arguments, but takes just 2 Rename ioremap to remap to fix this. Likewise for iounmap. Signed-off-by: Vincent Whitchurch --- drivers/misc/mic/bus/scif_bus.h| 8 drivers/misc/mic/bus/vop_bus.h | 8 drivers/misc/mic/card/mic_device.c | 8 ++

[PATCH v2 char-misc-next 6/7] samples: mic: Split out vop code from mpssd

2019-02-22 Thread Vincent Whitchurch
is just movement of unmodified code between files. Signed-off-by: Vincent Whitchurch --- samples/mic/mpssd/Makefile |4 +- samples/mic/mpssd/mpssd.c | 1317 +- samples/mic/mpssd/mpssd.h |1 + samples/mic/mpssd/vop.c| 1357

[PATCH v2 char-misc-next 3/7] vop: Allow building on more systems

2019-02-22 Thread Vincent Whitchurch
VOP_BUS does not actually depend on x86-64 or PCI or X86_DEV_DMA_OPS. The dependency on X86_DEV_DMA_OPS has been unnecessary since commit 5657933dbb6e25fe ("treewide: Move dma_ops from struct dev_archdata into struct device"). Signed-off-by: Vincent Whitchurch --- drivers/misc/mic/K

[PATCH v2 char-misc-next 1/7] vop: Cast pointers to unsigned long

2019-02-22 Thread Vincent Whitchurch
Fix these on 32-bit: vop_vringh.c:711:13: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast] Signed-off-by: Vincent Whitchurch --- drivers/misc/mic/vop/vop_main.c | 13 + drivers/misc/mic/vop/vop_vringh.c | 5 +++-- 2 files changed, 12

[PATCH v2 char-misc-next 4/7] mic: vop: Add loopback driver

2019-02-22 Thread Vincent Whitchurch
Add a loopback driver to allow testing and evaluation of the VOP framework without special hardware. The host and the guest will run under the same kernel. Signed-off-by: Vincent Whitchurch --- drivers/misc/mic/Kconfig| 10 + drivers/misc/mic/vop/Makefile | 2 + drivers

[PATCH v2 char-misc-next 3/7] mic: vop: Allow building on more systems

2019-02-22 Thread Vincent Whitchurch
VOP_BUS does not actually depend on x86-64 or PCI or X86_DEV_DMA_OPS. The dependency on X86_DEV_DMA_OPS has been unnecessary since commit 5657933dbb6e25fe ("treewide: Move dma_ops from struct dev_archdata into struct device"). Signed-off-by: Vincent Whitchurch --- drivers/misc/mic/K

[PATCH v2 char-misc-next 4/7] vop: Add loopback driver

2019-02-22 Thread Vincent Whitchurch
Add a loopback driver to allow testing and evaluation of the VOP framework without special hardware. The host and the guest will run under the same kernel. Signed-off-by: Vincent Whitchurch --- drivers/misc/mic/Kconfig| 10 + drivers/misc/mic/vop/Makefile | 2 + drivers

[PATCH v2 char-misc-next 5/7] mic: vop: Fix init race with shared interrupts

2019-02-22 Thread Vincent Whitchurch
eeping a local list of virtqueues in this driver and using that instead of the list inside the struct virtio_device, similar to how virtio-pci handles this. Signed-off-by: Vincent Whitchurch --- drivers/misc/mic/vop/vop_main.c | 42 ++--- 1 file changed, 39 insertio

Re: [PATCH v2] mic: vop: Fix broken virtqueues

2019-02-01 Thread Vincent Whitchurch
On Wed, Jan 30, 2019 at 08:40:23PM +0100, Greg KH wrote: > This patch is already in my tree, can you just send a "fixup" patch > instead of me having to revert the old one and then adding this one > again? I've now posted the fixup patch separately as "mic: vop: Fix crash on remove". Thanks.

[PATCH] mic: vop: Fix use-after-free on remove

2019-02-01 Thread Vincent Whitchurch
8800da18600: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb 88800da18680: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb == Fixes: 0063e8bbd2b62d136 ("virtio_vop: don't kfree device on register failure") Sign

[PATCH] mic: vop: Fix crash on remove

2019-02-01 Thread Vincent Whitchurch
oved. The structure in question is only examined to get the virtual address of the allocated used page. Store that pointer locally instead to fix the crash. Fixes: 1ce9e6055fa0 ("virtio_ring: introduce packed ring support") Signed-off-by: Vincent Whitchurch --- drivers/misc/mi

[PATCH v2] mic: vop: Fix broken virtqueues

2019-01-30 Thread Vincent Whitchurch
commit message. The removal patch also has the hack and we need to save the used ring pointer separately to remove it. Fixes: 1ce9e6055fa0 ("virtio_ring: introduce packed ring support") Signed-off-by: Vincent Whitchurch --- v2: fix removal path also drivers/misc/mic/vop/vop_main.c |

Re: [PATCH v2] sysctl: Add panic-fatal-signals

2019-01-30 Thread Vincent Whitchurch
On Wed, Jan 30, 2019 at 04:02:36PM +0100, Richard Weinberger wrote: > Hmm, why can't this be a core dump helper? > Such as: > > #!/bin/sh > # Usage: > # echo "|/root/crash.sh %p %e %s" > /proc/sys/kernel/core_pattern > > PID="$1" > COMM="$2" > SIGNAL="$3" > > echo "$COMM ($PID) died by signal $S

Re: [PATCH] mic: vop: Fix broken virtqueues

2019-01-30 Thread Vincent Whitchurch
On Wed, Jan 30, 2019 at 08:29:57AM -0800, Sudeep Dutt wrote: > On Tue, 2019-01-29 at 11:22 +0100, Vincent Whitchurch wrote: > > VOP is broken in mainline since commit 1ce9e6055fa0a9043 ("virtio_ring: > > introduce packed ring support"); attempting to use the virtqueues le

[PATCH] mic: vop: Fix broken virtqueues

2019-01-29 Thread Vincent Whitchurch
virtqueue() to create the needed vring layout from the start, instead of attempting to patch in the used ring later. __vring_new_virtqueue() was added way back in commit 2a2d1382fe9dcc ("virtio: Add improved queue allocation API") in order to address mic's usecase, according

[PATCH v2] sysctl: Add panic-fatal-signals

2019-01-28 Thread Vincent Whitchurch
ned-off-by: Vincent Whitchurch --- v2: Put the sysctl behind a config option include/linux/signal.h | 1 + init/Kconfig | 14 ++ kernel/signal.c| 5 - kernel/sysctl.c| 9 + 4 files changed, 28 insertions(+), 1 deletion(-) diff --git a/include/linu

Re: [PATCH 0/8] Virtio-over-PCIe on non-MIC

2019-01-21 Thread Vincent Whitchurch
On Fri, Jan 18, 2019 at 04:49:16PM -0700, Stephen Warren wrote: > On 1/16/19 9:32 AM, Vincent Whitchurch wrote: > > The Virtio-over-PCIe framework living under drivers/misc/mic/vop implements > > a > > generic framework to use virtio between two Linux systems, given shared

Re: [PATCH 0/8] Virtio-over-PCIe on non-MIC

2019-01-17 Thread Vincent Whitchurch
On Thu, Jan 17, 2019 at 04:53:25PM +0100, Arnd Bergmann wrote: > On Thu, Jan 17, 2019 at 4:19 PM Vincent Whitchurch > wrote: > > On Thu, Jan 17, 2019 at 01:39:27PM +0100, Arnd Bergmann wrote: > > > Can you describe how you expect a VOP device over NTB or > > > P

Re: [PATCH 0/8] Virtio-over-PCIe on non-MIC

2019-01-17 Thread Vincent Whitchurch
On Thu, Jan 17, 2019 at 07:21:42AM -0800, Christoph Hellwig wrote: > On Thu, Jan 17, 2019 at 04:19:06PM +0100, Vincent Whitchurch wrote: > > On the RC, a vop-host-backend driver (PCI driver) sets up some shared > > memory area which the RC and the endpoint can use to communicate t

Re: [PATCH 0/8] Virtio-over-PCIe on non-MIC

2019-01-17 Thread Vincent Whitchurch
On Thu, Jan 17, 2019 at 01:39:27PM +0100, Arnd Bergmann wrote: > Correct, and again we have to see if this is a good interface. The NTB > and PCIe-endpoint interfaces have a number of differences and a > number of similarities. In particular they should both be usable with > virtio-style drivers, b

Re: [PATCH] sysctl: Add panic-fatal-signals

2019-01-17 Thread Vincent Whitchurch
On Wed, Jan 16, 2019 at 09:06:18AM -0800, Kees Cook wrote: > On Wed, Jan 16, 2019 at 4:54 AM Vincent Whitchurch > wrote: > > Add a sysctl which asks the kernel to panic when any userspace process > > receives a fatal signal which would trigger a core dump. This has > > p

Re: [PATCH 0/8] Virtio-over-PCIe on non-MIC

2019-01-17 Thread Vincent Whitchurch
On Wed, Jan 16, 2019 at 06:07:53PM +0100, Arnd Bergmann wrote: > On Wed, Jan 16, 2019 at 5:33 PM Vincent Whitchurch > wrote: > > The Virtio-over-PCIe framework living under drivers/misc/mic/vop implements > > a > > generic framework to use virtio between two Lin

[PATCH 0/8] Virtio-over-PCIe on non-MIC

2019-01-16 Thread Vincent Whitchurch
the series does not break anything there. Vincent Whitchurch (8): vop: Use %z for size_t vop: Cast pointers to uintptr_t vop: Add definition of readq/writeq if missing vop: Allow building on more systems vop: vringh: Do not crash if no DMA channel vop: Fix handling of >32 featu

[PATCH 2/8] vop: Cast pointers to uintptr_t

2019-01-16 Thread Vincent Whitchurch
Fix these on 32-bit: vop_vringh.c:711:13: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast] Signed-off-by: Vincent Whitchurch --- drivers/misc/mic/vop/vop_main.c | 8 drivers/misc/mic/vop/vop_vringh.c | 4 ++-- 2 files changed, 6 insertions(+), 6

[PATCH 6/8] vop: Fix handling of >32 feature bits

2019-01-16 Thread Vincent Whitchurch
This is needed, for example, for VIRTIO_F_IOMMU_PLATFORM. Signed-off-by: Vincent Whitchurch --- drivers/misc/mic/vop/vop_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/misc/mic/vop/vop_main.c b/drivers/misc/mic/vop/vop_main.c index 26b23f2cf94c

[PATCH 4/8] vop: Allow building on more systems

2019-01-16 Thread Vincent Whitchurch
VOP_BUS does not actually depend on 32-bit X86 or PCI. The code uses archdata.dma_ops so it can be built on ARM too. Signed-off-by: Vincent Whitchurch --- drivers/misc/mic/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/misc/mic/Kconfig b/drivers/misc

[PATCH 1/8] vop: Use %z for size_t

2019-01-16 Thread Vincent Whitchurch
Fixes these kind of errors on 32-bit: drivers/misc/mic/vop/vop_vringh.c:590:3: error: format '%lx' expects argument of type 'long unsigned int', but argument 7 has type 'size_t {aka unsigned int}' [-Werror=format=] Signed-off-by: Vincent Whitchurch --- drivers

[PATCH 5/8] vop: vringh: Do not crash if no DMA channel

2019-01-16 Thread Vincent Whitchurch
Fallback gracefully if no DMA channel is provided instead of dereferencing NULL pointers. Signed-off-by: Vincent Whitchurch --- drivers/misc/mic/vop/vop_vringh.c | 32 +++ 1 file changed, 20 insertions(+), 12 deletions(-) diff --git a/drivers/misc/mic/vop

[PATCH 8/8] vop: Add loopback

2019-01-16 Thread Vincent Whitchurch
Add a loopback driver to allow testing and evaluation of the VOP framework without special hardware. The host and the guest will run under the same kernel. Signed-off-by: Vincent Whitchurch --- drivers/misc/mic/Kconfig| 10 + drivers/misc/mic/vop/Makefile | 2 + drivers

[PATCH 3/8] vop: Add definition of readq/writeq if missing

2019-01-16 Thread Vincent Whitchurch
Include so that readq/writeq are replaced by two readl/writel on systems that do not support them. The values read/written are pointers which will be 32-bit on 32-bit systems so the non-atomicity should not matter. Signed-off-by: Vincent Whitchurch --- drivers/misc/mic/vop/vop_main.c | 1 + 1

[PATCH 7/8] vop: Use consistent DMA

2019-01-16 Thread Vincent Whitchurch
The vop code maps buffers using the streaming DMA API but never syncs them so it doesn't work on systems without cache coherence. The vrings want consistent mappings, and not streaming mappings so use that API to allocate and map buffers. Signed-off-by: Vincent Whitchurch --- drivers/mis

[PATCH] sysctl: Add panic-fatal-signals

2019-01-16 Thread Vincent Whitchurch
ned-off-by: Vincent Whitchurch --- include/linux/signal.h | 1 + kernel/signal.c| 5 - kernel/sysctl.c| 7 +++ 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/include/linux/signal.h b/include/linux/signal.h index cc7e2c1cd444..109efd1432e9 100644 --- a/inc

[PATCH] Documentation/sysctl/vm.txt: Fix drop_caches bit number

2019-01-11 Thread Vincent Whitchurch
Bits are usually numbered starting from zero, so 4 should be bit 2, not bit 3. Suggested-by: Matthew Wilcox Signed-off-by: Vincent Whitchurch --- Documentation/sysctl/vm.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/sysctl/vm.txt b/Documentation/sysctl

[PATCH] drop_caches: Allow unmapping pages

2019-01-07 Thread Vincent Whitchurch
tive(file):240 kB Inactive(file): 2344 kB Signed-off-by: Vincent Whitchurch --- Documentation/sysctl/vm.txt | 4 fs/drop_caches.c| 3 ++- include/linux/fs.h | 10 -- kernel/sysctl.c | 4 ++-- mm/truncat

  1   2   >