Re: [PATCH] arch: s390: Remove duplicate struct ccw1 declaration

2021-03-30 Thread Vineeth Vijayan
Thank you for the patch. Acked-by: Vineeth Vijayan Heiko/Vasily will pick this up and will be part of the s390-tree patchset. On 3/30/21 12:56 PM, Wan Jiabing wrote: struct ccw1 is declared twice. One has been declared at 21st line. Remove the duplicate. Signed-off-by: Wan Jiabing --- arch

Re: [PATCH -next 2/2] s390/cio: use DECLARE_WAIT_QUEUE_HEAD() for wait_queue

2021-03-29 Thread Vineeth Vijayan
For both the patches, Acked-by: Vineeth Vijayan I will correct the description, and Heiko/Vasily will pick this up and will be part of the s390-tree patchset. On 3/29/21 11:40 AM, Shixin Liu wrote: wait_queue_head_t can be initialized automatically with DECLARE_WAIT_QUEUE_HEAD() rather

Re: [PATCH -next 1/2] s390/cio: use DEFINE_SPINLOCK() for spinlock

2021-03-29 Thread Vineeth Vijayan
Thank you. Acked-by: Vineeth Vijayan On 3/29/21 11:40 AM, Shixin Liu wrote: spinlock can be initialized automatically with DEFINE_SPINLOCK() rather than explicitly calling spin_lock_init(). static spinlock Signed-off-by: Shixin Liu --- drivers/s390/cio/css.c | 3 +-- 1 file changed, 1

Re: [abaci-bug...@linux.alibaba.com: [PATCH] s390: Simplify the calculation of variables]

2021-01-27 Thread Vineeth Vijayan
(scsw->cmd.actl & SCSW_ACTL_SUSPENDED)); } /** Thank you. Reviewed-by: Vineeth Vijayan this will go via next s390-tree upstream-release. Regards Vineeth Vijayan.

Re: [PATCH] s390: cio: fix use-after-free in ccw_device_destroy_console

2020-12-02 Thread Vineeth Vijayan
Thank you.With a very minor modification in the commit-message, Reviewed-by: Vineeth Vijayan I will push this and Vasliy/Heiko will take this up for the next s390-tree upstream-release. On 12/1/20 7:31 AM, Qinglang Miao wrote: put_device calls release function which do kfree() inside. So

Re: [PATCH v4 04/27] s390: fix kernel-doc markups

2020-11-16 Thread Vineeth Vijayan
Heiko/Vasily will pick this up and will be part of the s390-tree patchset. Regards Vineeth On 11/16/20 11:38 AM, Vineeth Vijayan wrote: Thank you very much for the fix. Reviewed-by: Vineeth Vijayan On 11/16/20 11:18 AM, Mauro Carvalho Chehab wrote: fix one typo: ccw driver

Re: [PATCH v4 04/27] s390: fix kernel-doc markups

2020-11-16 Thread Vineeth Vijayan
Thank you very much for the fix. Reviewed-by: Vineeth Vijayan On 11/16/20 11:18 AM, Mauro Carvalho Chehab wrote: fix one typo: ccw driver -> ccw_driver and one function rename. Signed-off-by: Mauro Carvalho Chehab --- arch/s390/include/asm/ccwdev.h | 2 +- arch/s390/incl

Re: [PATCH -next] s390/cio: Remove unused inline functionidset_sch_get_first

2020-05-11 Thread Vineeth Vijayan
Thank you. This patch will be part of the s390's next patch submission. Reviewed-by: Vineeth Vijayan Regards, Vineeth On Fri, 2020-05-08 at 22:06 +0800, YueHaibing wrote: > commit 8ebd51a705c5 ("s390/cio: idset.c: remove some unused > functions") > left behind this, remove

Re: [PATCH] [powerpc] Fix Text randomization

2014-11-17 Thread Vineeth Vijayan
On Mon, Nov 17, 2014 at 12:23 PM, Michael Ellerman wrote: > On Fri, 2014-11-14 at 14:42 +0530, Vineeth Vijayan wrote: >> Now there is no way to disable TEXT randomization on a PPC32/PPC64 >> machine. Text randomization happens even in the case of "echo 0 > >> /proc/

Re: [PATCH] [powerpc] Fix Text randomization

2014-11-17 Thread Vineeth Vijayan
On Mon, Nov 17, 2014 at 12:23 PM, Michael Ellerman m...@ellerman.id.au wrote: On Fri, 2014-11-14 at 14:42 +0530, Vineeth Vijayan wrote: Now there is no way to disable TEXT randomization on a PPC32/PPC64 machine. Text randomization happens even in the case of echo 0 /proc/sys/kernel

[PATCH] [powerpc] Fix Text randomization

2014-11-14 Thread Vineeth Vijayan
The function randomize_et_dyn is redundant and is removed. Signed-off-by: Vineeth Vijayan --- arch/powerpc/Kconfig |1 + arch/powerpc/include/asm/elf.h |3 +-- arch/powerpc/kernel/process.c |9 - 3 files changed, 2 insertions(+), 11 deletions(-) diff --git a/arch/powerpc/K

Re: powerpc: Fix Text randomization

2014-11-14 Thread Vineeth Vijayan
On Fri, Nov 14, 2014 at 11:50 AM, Michael Ellerman wrote: > On Fri, 2014-11-14 at 11:03 +0530, Vineeth Vijayan wrote: >> ping ! >> >> any update on this ? As i understand, only powerpc and s390 uses the >> randomize_et_dyn call; for all other architecture this is a

Re: powerpc: Fix Text randomization

2014-11-14 Thread Vineeth Vijayan
On Fri, Nov 14, 2014 at 11:50 AM, Michael Ellerman m...@ellerman.id.au wrote: On Fri, 2014-11-14 at 11:03 +0530, Vineeth Vijayan wrote: ping ! any update on this ? As i understand, only powerpc and s390 uses the randomize_et_dyn call; for all other architecture this is an obsolete function

[PATCH] [powerpc] Fix Text randomization

2014-11-14 Thread Vineeth Vijayan
is redundant and is removed. Signed-off-by: Vineeth Vijayan vvija...@mvista.com --- arch/powerpc/Kconfig |1 + arch/powerpc/include/asm/elf.h |3 +-- arch/powerpc/kernel/process.c |9 - 3 files changed, 2 insertions(+), 11 deletions(-) diff --git a/arch/powerpc

Re: powerpc: Fix Text randomization

2014-11-13 Thread Vineeth Vijayan
ping ! any update on this ? As i understand, only powerpc and s390 uses the randomize_et_dyn call; for all other architecture this is an obsolete function call. this call for another patch where randomize_et_dyn is removed. On Wed, Oct 15, 2014 at 12:08 PM, Vineeth Vijayan wrote: > On Wed,

Re: powerpc: Fix Text randomization

2014-11-13 Thread Vineeth Vijayan
ping ! any update on this ? As i understand, only powerpc and s390 uses the randomize_et_dyn call; for all other architecture this is an obsolete function call. this call for another patch where randomize_et_dyn is removed. On Wed, Oct 15, 2014 at 12:08 PM, Vineeth Vijayan vvija...@mvista.com

Re: powerpc: Fix Text randomization

2014-10-15 Thread Vineeth Vijayan
On Wed, Oct 15, 2014 at 7:38 AM, Michael Ellerman wrote: > On Fri, 2014-10-10 at 05:45:26 UTC, Vineeth Vijayan wrote: >> Right now there is no way to disable TEXT randomization on a PPC32 >> machine. text randomization happens even in the case of "echo 0 > >> /proc/

Re: powerpc: Fix Text randomization

2014-10-15 Thread Vineeth Vijayan
On Wed, Oct 15, 2014 at 7:38 AM, Michael Ellerman m...@ellerman.id.au wrote: On Fri, 2014-10-10 at 05:45:26 UTC, Vineeth Vijayan wrote: Right now there is no way to disable TEXT randomization on a PPC32 machine. text randomization happens even in the case of echo 0 /proc/sys/kernel

[PATCH] powerpc: Fix Text randomization

2014-10-09 Thread Vineeth Vijayan
Right now there is no way to disable TEXT randomization on a PPC32 machine. text randomization happens even in the case of "echo 0 > /proc/sys/kernel/randomize_va_space" This happens due to the incorrect definition of ELF_ET_DYN_BASE at arch/powerpc/include/asm/elf.h Signed-of

[PATCH] powerpc: Fix Text randomization

2014-10-09 Thread Vineeth Vijayan
Right now there is no way to disable TEXT randomization on a PPC32 machine. text randomization happens even in the case of echo 0 /proc/sys/kernel/randomize_va_space This happens due to the incorrect definition of ELF_ET_DYN_BASE at arch/powerpc/include/asm/elf.h Signed-off-by: Vineeth Vijayan