Re: [PATCH v2 00/10] soundwire: intel: add multi-link support

2020-09-03 Thread Vinod Koul
On 01-09-20, 23:05, Bard Liao wrote: > This series enables multi-link support for Intel platforms. Applied all, thanks > > Changes in v2: > - Remove the "soundwire: intel: Only call sdw stream APIs for the first > cpu_dai" patch form this series. We will move the sounwdire stream >

Re: [PATCH 0/7] ASoC: soundwire: Move sdw stream operations to

2020-09-03 Thread Vinod Koul
On 01-09-20, 23:02, Bard Liao wrote: > sdw stream operation APIs can be called once per stream. dailink > callbacks are good places to call these APIs. Again, please mention here if this is to be merged thru sdw tree or ASoC tree > > Pierre-Louis Bossart (7): > ASoC: soc-dai: clarify return

Re: [PATCH v4 0/3] ASoC: soundwire: fix port_ready[] dynamic allocation

2020-09-03 Thread Vinod Koul
On 31-08-20, 21:43, Bard Liao wrote: > The existing code allocates memory for the total number of ports. > This only works if the ports are contiguous, but will break if e.g. a > Devices uses port0, 1, and 14. The port_ready[] array would contain 3 > elements, which would lead to an out-of-bounds

Re: [PATCH v2] soundwire: fix double free of dangling pointer

2020-09-03 Thread Vinod Koul
On 02-09-20, 13:26, t...@redhat.com wrote: > From: Tom Rix > > clang static analysis flags this problem > > stream.c:844:9: warning: Use of memory after > it is freed > kfree(bus->defer_msg.msg->buf); > ^~~ > > This happens in an error handler

Re: [RESEND PATCH v2] dt-bindings: renesas,rcar-dmac: Document r8a7742 support

2020-09-03 Thread Vinod Koul
On 03-09-20, 08:38, Lad Prabhakar wrote: > Renesas RZ/G SoC also have the R-Car gen2/3 compatible DMA controllers. > Document RZ/G1H (also known as R8A7742) SoC bindings. Applied, thanks -- ~Vinod

Re: [PATCH] dmaengine: ti: k3-udma: Update rchan_oes_offset for am654 SYSFW ABI 3.0

2020-09-03 Thread Vinod Koul
On 31-08-20, 12:10, Peter Ujfalusi wrote: > SYSFW ABI 3.0 has changed the rchan_oes_offset value for am654 to support > SR2. > > Since the kernel now needs SYSFW API 3.0 to work because the merged irqchip > update, we need to also update the am654 rchan_oes_offset. Applied to fixes, thanks --

Re: [PATCH v2 05/10] dt-bindings: renesas,rcar-dmac: Document r8a7742 support

2020-09-03 Thread Vinod Koul
On 27-08-20, 12:08, Lad, Prabhakar wrote: > Hi Vinod, > > On Sun, May 3, 2020 at 10:47 PM Lad Prabhakar > wrote: > > > > Renesas RZ/G SoC also have the R-Car gen2/3 compatible DMA controllers. > > Document RZ/G1H (also known as R8A7742) SoC bindings. > > > > Signed-off-by: Lad Prabhakar > >

Re: [PATCH 1/3] dmaengine: pl330: Simplify with dev_err_probe()

2020-09-03 Thread Vinod Koul
On 28-08-20, 17:26, Krzysztof Kozlowski wrote: > Common pattern of handling deferred probe can be simplified with > dev_err_probe(). Less code and the error value gets printed. Applied all, thanks -- ~Vinod

Re: [PATCH] dmaengine: Mark dma_request_slave_channel() deprecated

2020-09-03 Thread Vinod Koul
On 28-08-20, 14:05, Peter Ujfalusi wrote: > New drivers should use dma_request_chan() instead > dma_request_slave_channel() > > dma_request_slave_channel() is a simple wrapper for dma_request_chan() > eating up the error code for channel request failure and makes deferred > probing impossible. >

Re: [PATCH 09/11] soundwire: intel: add dynamic debug trace for clock-stop invalid configs

2020-09-01 Thread Vinod Koul
On 31-08-20, 10:15, Pierre-Louis Bossart wrote: > > > > > > > > Detect cases where the clock is assumed to be stopped but the IP > > > > > > > is > > > > > > > not in the relevant state, and add a dynamic debug trace. > > > > > > > > > > > > you meant a debug print..and it looks like error

Re: [PATCH] regmap: soundwire: remove unsed header mod_devicetable.h

2020-09-01 Thread Vinod Koul
On 31-08-20, 09:12, Pierre-Louis Bossart wrote: > typo in commit message? Thanks for spotting, will send v2. > > On 8/29/20 5:39 AM, Vinod Koul wrote: > > mod_devicetable.h does not seem to be required for this file, so > > remove it. > > > > Signed-off-by:

[PATCH v2] regmap: soundwire: remove unused header mod_devicetable.h

2020-09-01 Thread Vinod Koul
mod_devicetable.h does not seem to be required for this file, so remove it. Signed-off-by: Vinod Koul --- changes in v2: - fix typo in patch subject drivers/base/regmap/regmap-sdw.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/base/regmap/regmap-sdw.c b/drivers/base/regmap

Re: [PATCH] soundwire: fix error handling

2020-09-01 Thread Vinod Koul
Hello Tom, On 29-08-20, 08:35, t...@redhat.com wrote: > From: Tom Rix > > clang static analysis flags this problem > > stream.c:844:9: warning: Use of memory after > it is freed > kfree(bus->defer_msg.msg->buf); > ^~~ > > This happens in an error

Re: [PATCH v7 2/3] dt-bindings: phy: intel: Add Keem Bay eMMC PHY bindings

2020-08-31 Thread Vinod Koul
On 01-09-20, 04:58, Wan Mohamad, Wan Ahmad Zainie wrote: > > > @@ -0,0 +1,44 @@ > > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) %YAML 1.2 > > > +--- > > > +$id: "http://devicetree.org/schemas/phy/intel,keembay-emmc- > > phy.yaml#" > > > +$schema:

Re: [PATCH] phy: Move phy-rockchip-dphy-rx0 out of staging

2020-08-31 Thread Vinod Koul
On 25-08-20, 19:07, Ezequiel Garcia wrote: > There is no need for this driver to be in staging. > Let's promote it! Applied, thanks -- ~Vinod

Re: [RESEND PATCH v4 0/2] Add new UniPhier AHCI PHY driver

2020-08-31 Thread Vinod Koul
On 25-08-20, 19:41, Kunihiko Hayashi wrote: > This series adds support for AHCI PHY interface implemented in Socionext > UniPhier SoCs. This driver supports PXs2 and PXs3 SoCs. Applied both, thanks -- ~Vinod

Re: [PATCH v4 1/1] phy: tusb1210: use bitmasks to set VENDOR_SPECIFIC2

2020-08-31 Thread Vinod Koul
Hi Liam, On 22-08-20, 16:53, Liam Beguin wrote: > From: Liam Beguin > > Start by reading the content of the VENDOR_SPECIFIC2 register and update > each bit field based on device properties when defined. > > The use of bit masks prevents fields from overriding each other and > enables users to

Re: [PATCH v4] dt-binding: phy: convert ti,omap-usb2 to YAML

2020-08-31 Thread Vinod Koul
On 24-08-20, 10:47, Roger Quadros wrote: > Hi, > > On 21/08/2020 11:11, Roger Quadros wrote: > > Move ti,omap-usb2 to its own YAML schema. > > > > Signed-off-by: Roger Quadros > > Reviewed-by: Rob Herring > > --- > > > > v4 > > - fix example to fix dt_binding_check warnings > > - '#phy-cells'

Re: [PATCH v5 1/2] dt-bindings: dma: Add bindings for intel LGM SOC

2020-08-31 Thread Vinod Koul
On 31-08-20, 16:06, Reddy, MallikarjunaX wrote: > Hi Vinod, > > Thanks for the review. Please see my comment inline. > > On 8/28/2020 6:45 PM, Vinod Koul wrote: > > On 27-08-20, 17:54, Reddy, MallikarjunaX wrote: > > > Hi Vinod, > > > Thanks for the revie

Re: [PATCH v7 3/3] phy: intel: Add Keem Bay eMMC PHY support

2020-08-31 Thread Vinod Koul
On 21-08-20, 19:37, Wan Ahmad Zainie wrote: > +/* From ACS_eMMC51_16nFFC_RO1100_Userguide_v1p0.pdf p17 */ > +#define FREQSEL_200M_170M0x0 > +#define FREQSEL_170M_140M0x1 > +#define FREQSEL_140M_110M0x2 > +#define FREQSEL_110M_80M 0x3 > +#define FREQSEL_80M_50M 0x4 > +

Re: [PATCH v7 2/3] dt-bindings: phy: intel: Add Keem Bay eMMC PHY bindings

2020-08-31 Thread Vinod Koul
On 21-08-20, 19:37, Wan Ahmad Zainie wrote: > Binding description for Intel Keem Bay eMMC PHY. > > Signed-off-by: Wan Ahmad Zainie > Reviewed-by: Rob Herring > --- > .../bindings/phy/intel,keembay-emmc-phy.yaml | 44 +++ > 1 file changed, 44 insertions(+) > create mode 100644

Re: [PATCH 0/8] drivers: phy: Constify static phy_ops structs

2020-08-31 Thread Vinod Koul
On 24-08-20, 00:00, Rikard Falkeborn wrote: > This series constifies all static phy_ops structs in drivers/phy. > Typically the only usage is to pass the address of it to devm_phy_create() > which takes a const pointer. The lone exception is in > drivers/phy/qualcomm/phy-qcom-ipq4019-usb.c where

Re: [PATCH v6 0/2] phy: omap-usb2-phy: Errata and coding style fix

2020-08-31 Thread Vinod Koul
On 24-08-20, 10:51, Roger Quadros wrote: > Hi, > > This series addresses silicon errata > i2075 - "USB2PHY: USB2PHY Charger Detect is Enabled by Default > Without VBUS Presence" > > It also fixes coding style issues. Applied, thanks -- ~Vinod

Re: [RESEND PATCH v3 3/3] phy: Add USB HSIC PHY driver for Marvell MMP3 SoC

2020-08-31 Thread Vinod Koul
On 18-08-20, 00:34, Lubomir Rintel wrote: > Add PHY driver for the HSICs found on Marvell MMP3 SoC. The driver is > rather straightforward -- the PHY essentially just needs to be enabled. > > Signed-off-by: Lubomir Rintel > > --- > Changes since v1: > - Explicitely cast drvdata pointer to make

Re: [PATCH V5 5/7] phy: tegra: xusb: Add support for charger detect

2020-08-31 Thread Vinod Koul
On 20-07-20, 15:25, Nagarjuna Kristam wrote: > +#define USB2_BATTERY_CHRG_OTGPADX_CTL0(x)(0x80 + (x) * 0x40) > +#define PD_CHG BIT(0) > +#define VDCD_DET_FILTER_EN BIT(4) > +#define VDAT_DETBIT(5) > +#define

Re: [PATCH V5 4/7] phy: tegra: xusb: Add soc ops API to enable UTMI PAD protection

2020-08-31 Thread Vinod Koul
On 20-07-20, 15:25, Nagarjuna Kristam wrote: > When USB charger is enabled, UTMI PAD needs to be protected according > to the direction and current level. Add support for the same on Tegra210 > and Tegra186. > > Signed-off-by: Nagarjuna Kristam > Acked-by: Thierry Reding > --- > V5: > - No

Re: [PATCH] fsldma: fsl_ioread64*() do not need lower_32_bits()

2020-08-31 Thread Vinod Koul
; looks like it always returned a completely incorrect value. > > And again - the driver may have worked even with that completely > incorrect value, since the use of it seems to be very incidental. Thank you for the fix. Acked-By: Vinod Koul > > In either case ("i

Re: [PATCH 09/11] soundwire: intel: add dynamic debug trace for clock-stop invalid configs

2020-08-29 Thread Vinod Koul
On 28-08-20, 09:54, Pierre-Louis Bossart wrote: > > > > > > Detect cases where the clock is assumed to be stopped but the IP is > > > > > not in the relevant state, and add a dynamic debug trace. > > > > > > > > you meant a debug print..and it looks like error print below (also in > > > >

[PATCH] regmap: soundwire: remove unsed header mod_devicetable.h

2020-08-29 Thread Vinod Koul
mod_devicetable.h does not seem to be required for this file, so remove it. Signed-off-by: Vinod Koul --- drivers/base/regmap/regmap-sdw.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/base/regmap/regmap-sdw.c b/drivers/base/regmap/regmap-sdw.c index 50a66382d87d..c92d614b4943

Re: [PATCH v5 1/2] dt-bindings: dma: Add bindings for intel LGM SOC

2020-08-28 Thread Vinod Koul
On 27-08-20, 17:54, Reddy, MallikarjunaX wrote: > Hi Vinod, > Thanks for the review comments. > > On 8/25/2020 7:21 PM, Vinod Koul wrote: > > On 18-08-20, 15:00, Reddy, MallikarjunaX wrote: > > > > > > > + > > > > > +intel,cha

Re: [PATCH] dmaengine: Remove unused define for dma_request_slave_channel_reason()

2020-08-28 Thread Vinod Koul
On 28-08-20, 11:41, Peter Ujfalusi wrote: > No users left in the kernel, it can be removed. Applied, thanks -- ~Vinod

Re: [PATCH] soundwire: cadence: fix race condition between suspend and Slave device alerts

2020-08-28 Thread Vinod Koul
On 21-08-20, 10:17, Pierre-Louis Bossart wrote: > > > > > cancel_work_sync() will either > > > a) wait until the current work completes, or > > > b) prevent a new one from starting. > > > > > > there's no way to really 'abort' a workqueue, 'cancel' means either > > > complete > > > or don't

Re: [PATCH 09/11] soundwire: intel: add dynamic debug trace for clock-stop invalid configs

2020-08-28 Thread Vinod Koul
On 26-08-20, 09:38, Pierre-Louis Bossart wrote: > > > On 8/26/20 4:48 AM, Vinod Koul wrote: > > On 18-08-20, 10:41, Bard Liao wrote: > > > From: Pierre-Louis Bossart > > > > > > Detect cases where the clock is assumed to be stopped but the IP i

Re: [PATCH 07/11] soundwire: intel: Only call sdw stream APIs for the first cpu_dai

2020-08-28 Thread Vinod Koul
On 26-08-20, 09:35, Pierre-Louis Bossart wrote: > > > > - ret = sdw_prepare_stream(dma->stream); > > > + /* > > > + * All cpu dais belong to a stream. To ensure sdw_prepare_stream > > > + * is called once per stream, we should call it only when > > > + * dai = first_cpu_dai. > > > + */ > > >

Re: [PATCH 07/11] soundwire: intel: Only call sdw stream APIs for the first cpu_dai

2020-08-28 Thread Vinod Koul
On 28-08-20, 01:47, Liao, Bard wrote: > > snd_pcm_substream *substream, > > > goto err; > > > } > > > > > > - ret = sdw_prepare_stream(dma->stream); > > > + /* > > > + * All cpu dais belong to a stream. To ensure sdw_prepare_stream > > > + * is called once per stream, we

[PATCH] arm64: dts: qcom: sdm845-db845c: Fix hdmi nodes

2020-08-28 Thread Vinod Koul
As per binding documentation, we should have dsi as node 0 and hdmi audio as node 1, so fix it Reported-by: Dmitry Baryshkov Fixes: aef9a119dfb9 ("arm64: dts: qcom: sdm845-db845c: Add hdmi bridge nodes") Signed-off-by: Vinod Koul --- arch/arm64/boot/dts/qcom/sdm845-db845

[PATCH] drm/bridge: Fix the dsi remote end-points

2020-08-28 Thread Vinod Koul
DSI end-points are supposed to be at node 0 and node 1 as per binding. So fix this and use node 0 and node 1 for dsi. Reported-by: Dmitry Baryshkov Fixes: 23278bf54afe ("drm/bridge: Introduce LT9611 DSI to HDMI bridge") Signed-off-by: Vinod Koul --- drivers/gpu/drm/bridge/lontium-lt

Re: [PATCH 05/11] soundwire: bus: update multi-link definition with hw sync details

2020-08-28 Thread Vinod Koul
On 26-08-20, 09:09, Pierre-Louis Bossart wrote: > > > > > + * @hw_sync_min_links: Number of links used by a stream above which > > > + * hardware-based synchronization is required. This value is only > > > + * meaningful if multi_link is set. If set to 1, hardware-based > > > + * synchronization

Re: [PATCH 4/4] regmap: sdw: add support for SoundWire 1.2 MBQ

2020-08-28 Thread Vinod Koul
On 26-08-20, 11:57, Pierre-Louis Bossart wrote: > > > > +#include > > > +#include > > > +#include > > > > Curious why do you need this header? > > I'll return the question back to you, since you added this header for > regmap-sdw.c: >

Re: [PATCH 1/7] soundwire: bus: use property to set interrupt masks

2020-08-28 Thread Vinod Koul
Hi Mark, On 18-08-20, 22:06, Bard Liao wrote: > From: Pierre-Louis Bossart > > Add a slave-level property and program the SCP_INT1_MASK as desired by > the codec driver. Since there is no DisCo property this has to be an > implementation-specific firmware property or hard-coded in the driver. >

Re: [PATCH 1/3] dt-bindings: dmaengine: Document qcom,gpi dma binding

2020-08-26 Thread Vinod Koul
On 26-08-20, 08:35, Rob Herring wrote: > On Wed, Aug 26, 2020 at 12:32 AM Vinod Koul wrote: > > > > On 25-08-20, 20:21, Vinod Koul wrote: > > > Hey Rob, > > > > > > On 24-08-20, 11:40, Rob Herring wrote: > > > > On Mon, 24 Aug 2020 14:1

Re: [PATCH 3/4] soundwire: SDCA: add helper macro to access controls

2020-08-26 Thread Vinod Koul
On 26-08-20, 10:00, Pierre-Louis Bossart wrote: > > > > > +/* v1.2 device - SDCA address mapping */ > > > > Can you please add description of bits used by each field here, > > something like we have done for DevId > > were you referring to something like this? > > * Spec definition > *

[PATCH v2 1/5] ASoC: max98373: Fix return check for devm_regmap_init_sdw()

2020-08-26 Thread Vinod Koul
devm_regmap_init_sdw() returns a valid pointer on success or ERR_PTR on failure which should be checked with IS_ERR. Also use PTR_ERR for returning error codes. Reported-by: Takashi Iwai Fixes: 56a5b7910e96 ("ASoC: codecs: max98373: add SoundWire support") Signed-off-by: Vinod Koul

[PATCH v2 4/5] ASoC: rt715: Fix return check for devm_regmap_init_sdw()

2020-08-26 Thread Vinod Koul
devm_regmap_init_sdw() returns a valid pointer on success or ERR_PTR on failure which should be checked with IS_ERR. Also use PTR_ERR for returning error codes. Reported-by: Takashi Iwai Fixes: d1ede0641b05 ("ASoC: rt715: add RT715 codec driver") Signed-off-by: Vinod Koul --- sound/

[PATCH v2 5/5] ASoC: rt700: Fix return check for devm_regmap_init_sdw()

2020-08-26 Thread Vinod Koul
devm_regmap_init_sdw() returns a valid pointer on success or ERR_PTR on failure which should be checked with IS_ERR. Also use PTR_ERR for returning error codes. Reported-by: Takashi Iwai Fixes: 7d2a5f9ae41e ("ASoC: rt700: add rt700 codec driver") Signed-off-by: Vinod Koul --- sound/

[PATCH v2 3/5] ASoC: rt711: Fix return check for devm_regmap_init_sdw()

2020-08-26 Thread Vinod Koul
devm_regmap_init_sdw() returns a valid pointer on success or ERR_PTR on failure which should be checked with IS_ERR. Also use PTR_ERR for returning error codes. Reported-by: Takashi Iwai Fixes: 320b8b0d13b8 ("ASoC: rt711: add rt711 codec driver") Signed-off-by: Vinod Koul --- sound/

[PATCH v2 2/5] ASoC: rt1308-sdw: Fix return check for devm_regmap_init_sdw()

2020-08-26 Thread Vinod Koul
devm_regmap_init_sdw() returns a valid pointer on success or ERR_PTR on failure which should be checked with IS_ERR. Also use PTR_ERR for returning error codes. Reported-by: Takashi Iwai Fixes: a87a6653a28c ("ASoC: rt1308-sdw: add rt1308 SdW amplifier driver") Signed-off-by:

[PATCH v2 0/5] ASoC: Fix return check for devm_regmap_init_sdw()

2020-08-26 Thread Vinod Koul
This series attempts to fix return check for devm_regmap_init_sdw() Changes in v2: - Add missing patch for rt711 - Add patch for rt700 Vinod Koul (5): ASoC: max98373: Fix return check for devm_regmap_init_sdw() ASoC: rt1308-sdw: Fix return check for devm_regmap_init_sdw() ASoC: rt711

Re: [PATCH 4/4] ASoC: rt715: Fix return check for devm_regmap_init_sdw()

2020-08-26 Thread Vinod Koul
On 26-08-20, 10:09, Pierre-Louis Bossart wrote: > > > On 8/26/20 7:28 AM, Vinod Koul wrote: > > devm_regmap_init_sdw() returns a valid pointer on success or ERR_PTR on > > failure which should be checked with IS_ERR. Also use PTR_ERR for > > returning error codes

[PATCH 2/4] ASoC: rt1308-sdw: Fix return check for devm_regmap_init_sdw()

2020-08-26 Thread Vinod Koul
devm_regmap_init_sdw() returns a valid pointer on success or ERR_PTR on failure which should be checked with IS_ERR. Also use PTR_ERR for returning error codes. Reported-by: Takashi Iwai Fixes: a87a6653a28c ("ASoC: rt1308-sdw: add rt1308 SdW amplifier driver") Signed-off-by:

[PATCH 1/4] ASoC: max98373: Fix return check for devm_regmap_init_sdw()

2020-08-26 Thread Vinod Koul
devm_regmap_init_sdw() returns a valid pointer on success or ERR_PTR on failure which should be checked with IS_ERR. Also use PTR_ERR for returning error codes. Reported-by: Takashi Iwai Fixes: 56a5b7910e96 ("ASoC: codecs: max98373: add SoundWire support") Signed-off-by: Vinod Koul

[PATCH 4/4] ASoC: rt715: Fix return check for devm_regmap_init_sdw()

2020-08-26 Thread Vinod Koul
devm_regmap_init_sdw() returns a valid pointer on success or ERR_PTR on failure which should be checked with IS_ERR. Also use PTR_ERR for returning error codes. Reported-by: Takashi Iwai Fixes: d1ede0641b05 ("ASoC: rt715: add RT715 codec driver") Signed-off-by: Vinod Koul --- sound/

[PATCH 2/4] ASoC: rt1308-sdw: Fix return check for devm_regmap_init_sdw()

2020-08-26 Thread Vinod Koul
pointer on success or ERR_PTR on failure which should be checked with IS_ERR. Also use PTR_ERR for returning error codes. Reported-by: Takashi Iwai Fixes: 320b8b0d13b8 ("ASoC: rt711: add rt711 codec driver") Signed-off-by: Vinod Koul --- sound/soc/codecs/rt711-sdw.c | 4 ++-- 1 file

Re: [PATCH 1/4] regmap: sdw: move to -EOPNOTSUPP

2020-08-26 Thread Vinod Koul
On 26-08-20, 12:22, Takashi Iwai wrote: > On Wed, 26 Aug 2020 12:13:01 +0200, > Mark Brown wrote: > > > > On Wed, Aug 26, 2020 at 12:09:28PM +0200, Takashi Iwai wrote: > > > Mark Brown wrote: > > > > > > checkpatch is broken. > > > > > Heh, I'm not objecting it :) > > > > > OTOH, it's also

Re: [PATCH 09/11] soundwire: intel: add dynamic debug trace for clock-stop invalid configs

2020-08-26 Thread Vinod Koul
On 18-08-20, 10:41, Bard Liao wrote: > From: Pierre-Louis Bossart > > Detect cases where the clock is assumed to be stopped but the IP is > not in the relevant state, and add a dynamic debug trace. you meant a debug print..and it looks like error print below (also in title). > >

Re: [PATCH 07/11] soundwire: intel: Only call sdw stream APIs for the first cpu_dai

2020-08-26 Thread Vinod Koul
On 18-08-20, 10:41, Bard Liao wrote: > We should call these APIs once per stream. So we can only call it > when the dai ops is invoked for the first cpu dai. > > Signed-off-by: Bard Liao > Reviewed-by: Pierre-Louis Bossart > Reviewed-by: Ranjani Sridharan > --- > drivers/soundwire/intel.c |

Re: [PATCH 05/11] soundwire: bus: update multi-link definition with hw sync details

2020-08-26 Thread Vinod Koul
On 18-08-20, 10:41, Bard Liao wrote: > From: Pierre-Louis Bossart > > Hardware-based synchronization is typically required when the > bus->multi_link flag is set. > > On Intel platforms, when the Cadence IP is configured in 'Multi Master > Mode', the hardware synchronization is required even

Re: [PATCH 4/4] regmap: sdw: add support for SoundWire 1.2 MBQ

2020-08-26 Thread Vinod Koul
On 25-08-20, 12:16, Pierre-Louis Bossart wrote: > The SoundWire 1.1 specification only allowed for reads and writes of > bytes. The SoundWire 1.2 specification adds a new capability to > transfer "Multi-Byte Quantities" (MBQ) across the bus. The transfers > still happens one-byte-at-a-time, but

Re: [PATCH 3/4] soundwire: SDCA: add helper macro to access controls

2020-08-26 Thread Vinod Koul
On 25-08-20, 12:16, Pierre-Louis Bossart wrote: > The upcoming SDCA (SoundWire Device Class Audio) specification defines > a hierarchical encoding to interface with Class-defined capabilities. > > The specification is not yet accessible to the general public but this > information is released

Re: [PATCH v2] soundwire: intel: fix intel_suspend/resume defined but not used warning

2020-08-26 Thread Vinod Koul
On 24-08-20, 21:32, Bard Liao wrote: > When CONFIG_PM_SLEEP is not defined, GCC throws compilation warnings: > > drivers/soundwire/intel.c:1799:12: warning: ‘intel_resume’ defined but not > used [-Wunused-function] > static int intel_resume(struct device *dev) > ^~~~ >

Re: [PATCH 1/3] dt-bindings: dmaengine: Document qcom,gpi dma binding

2020-08-26 Thread Vinod Koul
On 25-08-20, 20:21, Vinod Koul wrote: > Hey Rob, > > On 24-08-20, 11:40, Rob Herring wrote: > > On Mon, 24 Aug 2020 14:17:10 +0530, Vinod Koul wrote: > > > Add devicetree binding documentation for GPI DMA controller > > > implemented on Qualcomm SoCs >

Re: [RESEND PATCH v2 0/6] dmaengine: axi-dmac: add support for reading bus attributes from register

2020-08-25 Thread Vinod Koul
On 25-08-20, 18:19, Alexandru Ardelean wrote: > The series adds support for reading the DMA bus attributes from the > INTERFACE_DESCRIPTION (0x10) register. > > The first 5 changes are a bit of rework prior to adding the actual > change in patch 6, as things need to be shifted around a bit, to

Re: [PATCH 1/3] dt-bindings: dmaengine: Document qcom,gpi dma binding

2020-08-25 Thread Vinod Koul
Hey Rob, On 24-08-20, 11:40, Rob Herring wrote: > On Mon, 24 Aug 2020 14:17:10 +0530, Vinod Koul wrote: > > Add devicetree binding documentation for GPI DMA controller > > implemented on Qualcomm SoCs > > > > Signed-off-by: Vinod Koul > > --- > > ..

Re: [PATCH v2 0/6] dmaengine: axi-dmac: add support for reading bus attributes from register

2020-08-25 Thread Vinod Koul
On 25-08-20, 15:48, Alexandru Ardelean wrote: > The series adds support for reading the DMA bus attributes from the > INTERFACE_DESCRIPTION (0x10) register. > > The first 5 changes are a bit of rework prior to adding the actual > change in patch 6, as things need to be shifted around a bit, to

Re: [PATCH 2/5] dmaengine: axi-dmac: move clock enable earlier

2020-08-25 Thread Vinod Koul
On 19-08-20, 10:16, Alexandru Ardelean wrote: > The clock may also be required to read registers from the IP core (if it is > provided and the driver needs to control it). > So, move it earlier in the probe. > > Signed-off-by: Alexandru Ardelean > --- > drivers/dma/dma-axi-dmac.c | 8 >

Re: [PATCH 3/5] dmaengine: axi-dmac: wrap entire dt parse in a function

2020-08-25 Thread Vinod Koul
On 19-08-20, 10:16, Alexandru Ardelean wrote: > All these attributes will be read from registers in newer core versions, so > just wrap the logic into a function. > > Signed-off-by: Alexandru Ardelean > --- > drivers/dma/dma-axi-dmac.c | 39 -- > 1 file

Re: [PATCH v5 1/2] dt-bindings: dma: Add bindings for intel LGM SOC

2020-08-25 Thread Vinod Koul
On 18-08-20, 15:00, Reddy, MallikarjunaX wrote: > > > + > > > +intel,chans: > > > + $ref: /schemas/types.yaml#/definitions/uint32-array > > > + description: > > > + The channels included on this port. Format is channel > > > start > > > +

Re: [PATCH v5 1/3] dmaengine: ptdma: Initial driver for the AMD PTDMA controller

2020-08-25 Thread Vinod Koul
On 24-08-20, 13:11, Sanjay R Mehta wrote: > Apologies for my delayed response. > > On 7/3/2020 12:48 PM, Vinod Koul wrote: > > [CAUTION: External Email] > > > > On 16-06-20, 20:11, Sanjay R Mehta wrote: > > > >> +static int p

Re: [PATCH v2] drivers/dma/dma-jz4780: Fix race condition between probe and irq handler

2020-08-25 Thread Vinod Koul
On 21-08-20, 09:14, madhuparnabhowmi...@gmail.com wrote: > From: Madhuparna Bhowmik > > In probe, IRQ is requested before zchan->id is initialized which can be > read in the irq handler. Hence, shift request irq after other initializations > complete. Applied, thanks -- ~Vinod

Re: [PATCH] dmaengine: pl330: fix instruction dump formatting

2020-08-25 Thread Vinod Koul
On 13-08-20, 22:41, Łukasz Stelmach wrote: > Instruction dump uses two printk() in a row to print one instruction. Use > KERN_CONT to prevent breaking the output in the middle. Applied, thanks > > Signed-off-by: Łukasz Stelmach > --- > drivers/dma/pl330.c | 2 +- > 1 file changed, 1

Re: [RFC PATCH 2/3] dmaengine: add peripheral configuration

2020-08-25 Thread Vinod Koul
Hi Peter, On 25-08-20, 11:00, Peter Ujfalusi wrote: > Hi Vinod, > > On 25/08/2020 10.10, Vinod Koul wrote: > >>> /** > >>> * struct dma_slave_config - dma slave channel runtime config > >>> * @direction: whether the data shall go in or out

Re: [PATCH] dmaengine: pl330: Fix burst length if burst size is smaller than bus width

2020-08-25 Thread Vinod Koul
On 25-08-20, 08:46, Marek Szyprowski wrote: > Move the burst len fixup after setting the generic value for it. This > finally enables the fixup introduced by commit 137bd11090d8 ("dmaengine: > pl330: Align DMA memcpy operations to MFIFO width"), which otherwise was > overwritten by the generic

Re: [RFC PATCH 2/3] dmaengine: add peripheral configuration

2020-08-25 Thread Vinod Koul
Hello Peter, On 25-08-20, 09:52, Peter Ujfalusi wrote: > Hi Vinod, > > On 24/08/2020 11.47, Vinod Koul wrote: > > Some complex dmaengine controllers have capability to program the > > peripheral device, so pass on the peripheral configuration as part of > > dma_slave

Re: drivers/dma/pl330.c:2981:9: warning: Identical condition 'ret', second condition is always false

2020-08-24 Thread Vinod Koul
On 24-08-20, 15:50, Marek Szyprowski wrote: > Hi Vinod, > > On 08.08.2020 14:59, Vinod Koul wrote: > > On 08-08-20, 10:53, kernel test robot wrote: > >> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > >> master > >> head:

[PATCH 1/3] dt-bindings: dmaengine: Document qcom,gpi dma binding

2020-08-24 Thread Vinod Koul
Add devicetree binding documentation for GPI DMA controller implemented on Qualcomm SoCs Signed-off-by: Vinod Koul --- .../devicetree/bindings/dma/qcom-gpi.yaml | 87 +++ 1 file changed, 87 insertions(+) create mode 100644 Documentation/devicetree/bindings/dma/qcom-gpi.yaml

[RFC PATCH 2/3] dmaengine: add peripheral configuration

2020-08-24 Thread Vinod Koul
Some complex dmaengine controllers have capability to program the peripheral device, so pass on the peripheral configuration as part of dma_slave_config Signed-off-by: Vinod Koul --- include/linux/dmaengine.h | 75 +++ 1 file changed, 75 insertions(+) diff

[PATCH 3/3] dmaengine: qcom: Add GPI dma driver

2020-08-24 Thread Vinod Koul
This controller provides DMAengine capabilities for a variety of peripheral buses such as I2C, UART, and SPI. By using GPI dmaengine driver, bus drivers can use a standardize interface that is protocol independent to transfer data between memory and peripheral. Signed-off-by: Vinod Koul

Re: [PATCH v5] phy: omap-usb2-phy: disable PHY charger detect

2020-08-23 Thread Vinod Koul
On 21-08-20, 11:03, Roger Quadros wrote: > AM654x PG1.0 has a silicon bug that D+ is pulled high after POR, which > could cause enumeration failure with some USB hubs. Disabling the > USB2_PHY Charger Detect function will put D+ into the normal state. > > This addresses Silicon Errata: > i2075 -

Re: [PATCH -next] phy: ti: j721e-wiz: Remove duplicate include

2020-08-23 Thread Vinod Koul
On 18-08-20, 19:47, YueHaibing wrote: > Remove duplicate include file Applied, thanks > > Signed-off-by: YueHaibing > --- > drivers/phy/ti/phy-j721e-wiz.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/phy/ti/phy-j721e-wiz.c b/drivers/phy/ti/phy-j721e-wiz.c > index

Re: [RESEND PATCH v8 2/2] phy: Add USB3 PHY support for Intel LGM SoC

2020-08-23 Thread Vinod Koul
On 17-08-20, 15:05, Ramuthevar,Vadivel MuruganX wrote: > From: Ramuthevar Vadivel Murugan > > Add support for USB PHY on Intel LGM SoC. > > Signed-off-by: Ramuthevar Vadivel Murugan > > Reviewed-by: Philipp Zabel > --- > drivers/phy/Kconfig | 11 ++ > drivers/phy/Makefile | 1

Re: [PATCH V2 3/7] phy: qcom-qmp: Use correct values for ipq8074 PCIe Gen2 PHY init

2020-08-23 Thread Vinod Koul
On 29-07-20, 21:00, Sivaprakash Murugesan wrote: > There were some problem in ipq8074 Gen2 PCIe phy init sequence. > > 1. Few register values were wrongly updated in the phy init sequence. > 2. The register QSERDES_RX_SIGDET_CNTRL is a RX tuning parameter >register which is added in serdes

Re: [PATCH V2 5/7] PCI: qcom: Do PHY power on before PCIe init

2020-08-23 Thread Vinod Koul
On 29-07-20, 21:00, Sivaprakash Murugesan wrote: > Commit cc1e06f033af ("phy: qcom: qmp: Use power_on/off ops for PCIe") > changed phy ops from init/deinit to power on/off, due to this phy enable > is getting called after PCIe init. > > On some platforms like ipq8074 phy should be inited before

Re: [PATCH V2 4/7] phy: qcom-qmp: Add compatible for ipq8074 PCIe Gen3 qmp phy

2020-08-23 Thread Vinod Koul
Hi Sivaprakash, On 29-07-20, 21:00, Sivaprakash Murugesan wrote: > ipq8074 has two PCIe ports, One Gen2 and one Gen3 ports. > Since support for Gen2 phy is already available, add support for > PCIe Gen3 phy. > > Co-developed-by: Selvam Sathappan Periakaruppan > Signed-off-by: Selvam Sathappan

Re: [PATCH V2 1/7] dt-bindings: PCI: qcom: Add ipq8074 Gen3 PCIe compatible

2020-08-23 Thread Vinod Koul
On 29-07-20, 21:00, Sivaprakash Murugesan wrote: > ipq8074 has two PCIe ports while the support for Gen2 PCIe port is > already available add the support for Gen3 binding. > > Co-developed-by: Selvam Sathappan Periakaruppan > Signed-off-by: Selvam Sathappan Periakaruppan > Reviewed-by: Rob

Re: [PATCH v2 0/3] phy: ti: am654: improve PCIe enumeration performance

2020-08-23 Thread Vinod Koul
On 28-07-20, 01:16, Sekhar Nori wrote: > This patch series updates AM654x PCIe serdes settings to > latest recommended by hardware. This fixes Gen2 enumeration > issues seen previously. Applied after fixing typo 'threshold' in last patch, thanks -- ~Vinod

Re: [PATCH v5] phy: samsung: Use readl_poll_timeout function

2020-08-23 Thread Vinod Koul
On 20-07-20, 17:35, Anand Moon wrote: > Instead of a busy waiting while loop using udelay > use readl_poll_timeout function to check the condition > is met or timeout occurs in crport_handshake function. > readl_poll_timeout is called in non atomic context so > it safe to sleep until the condition

Re: [PATCH V5 3/7] phy: tegra: xusb: Add USB2 pad power control support for Tegra210

2020-08-23 Thread Vinod Koul
On 20-07-20, 15:25, Nagarjuna Kristam wrote: > Add USB2 pad power on and off API's for TEgra210 and provide its control > via soc ops. It can be used by operations like charger detect to power on > and off USB2 pad if needed. > > Signed-off-by: Nagarjuna Kristam > Acked-by: Thierry Reding > ---

Re: [PATCH v4 0/2] Add new UniPhier AHCI PHY driver

2020-08-23 Thread Vinod Koul
Hello, On 21-08-20, 18:20, Kunihiko Hayashi wrote: > Gentle ping. > Are there any comments in this series? Sorry I dont have this in my inbox, can you please rebease and resend to me as well Thanks > > Thank you, > > On 2020/07/16 17:32, Kunihiko Hayashi wrote: > > This series adds support

Re: [PATCH v3 1/1] phy: tusb1210: use bitmasks to set VENDOR_SPECIFIC2

2020-08-20 Thread Vinod Koul
On 19-08-20, 15:57, Geert Uytterhoeven wrote: > Hi Liam, > > > On Mon, Aug 17, 2020 at 7:38 PM Liam Beguin wrote: > > From: Liam Beguin > > > > Start by reading the content of the VENDOR_SPECIFIC2 register and update > > each bit field based on device properties when defined. > > > > The use

Re: [PATCH v5] phy: omap-usb2-phy: disable PHY charger detect

2020-08-20 Thread Vinod Koul
On 20-08-20, 20:27, Sekhar Nori wrote: > On 8/20/20 7:09 PM, Roger Quadros wrote: > > AM654x PG1.0 has a silicon bug that D+ is pulled high after POR, which > > could cause enumeration failure with some USB hubs. Disabling the > > USB2_PHY Charger Detect function will put D+ into the normal

Re: [PATCH 2/2] soundwire: fix port_ready[] dynamic allocation in mipi_disco and ASoC codecs

2020-08-20 Thread Vinod Koul
On 18-08-20, 07:09, Pierre-Louis Bossart wrote: > > > On 8/18/20 1:36 AM, Vinod Koul wrote: > > On 18-08-20, 01:47, Bard Liao wrote: > > > From: Pierre-Louis Bossart > > > > > > The existing code allocates memory for the total number of ports. > &g

Re: [PATCH v2] soundwire: SDCA: add helper macro to access controls

2020-08-20 Thread Vinod Koul
On 17-08-20, 10:14, Pierre-Louis Bossart wrote: > > > > The upcoming SDCA (SoundWire Device Class Audio) specification defines > > > a hiearchical encoding to interface with Class-defined capabilities, > > > > typo hiearchical > > ok > > > > based on which audio function, entity, control and

Re: [PATCH] soundwire: cadence: fix race condition between suspend and Slave device alerts

2020-08-20 Thread Vinod Koul
On 19-08-20, 07:51, Pierre-Louis Bossart wrote: > > > On 8/19/20 4:06 AM, Vinod Koul wrote: > > On 18-08-20, 06:23, Bard Liao wrote: > > > From: Pierre-Louis Bossart > > > > > > In system suspend stress cases, the SOF CI reports timeouts. The root

Re: [PATCH] soundwire: intel: fix CONFIG_PM and CONFIG_PM_SLEEP confusion

2020-08-20 Thread Vinod Koul
On 20-08-20, 22:04, Bard Liao wrote: > From: Pierre-Louis Bossart > > When CONFIG_PM_SLEEP is not defined, GCC throws compilation warnings: > > drivers/soundwire/intel.c:1816:12: warning: ‘intel_resume’ defined but > not used [-Wunused-function] > 1816 | static int intel_resume(struct device

Re: [PATCH] soundwire: bus: fix typo in comment on INTSTAT registers

2020-08-19 Thread Vinod Koul
On 18-08-20, 06:09, Bard Liao wrote: > From: Pierre-Louis Bossart > > s/Instat/Intstat/ Applied, thanks -- ~Vinod

Re: [PATCH] soundwire: cadence: fix race condition between suspend and Slave device alerts

2020-08-19 Thread Vinod Koul
On 18-08-20, 06:23, Bard Liao wrote: > From: Pierre-Louis Bossart > > In system suspend stress cases, the SOF CI reports timeouts. The root > cause is that an alert is generated while the system suspends. The > interrupt handling generates transactions on the bus that will never > be handled

Re: [PATCH V2 0/3] do exception handling appropriately in at_dma_xlate()

2020-08-18 Thread Vinod Koul
On 17-08-20, 19:57, Yu Kuai wrote: > changes from V1: > -separate different changes to different patches, as suggested by Vinod. Please write proper cover letter explaining the patch series and also the changes from v1.. I have applied the patches. Thanks > Yu Kuai (3): > dmaengine:

Re: [PATCH v3] usb: renesas-xhci: remove version check

2020-08-18 Thread Vinod Koul
On 18-08-20, 10:46, Greg Kroah-Hartman wrote: > On Tue, Aug 18, 2020 at 02:09:19PM +0530, Vinod Koul wrote: > > On 18-08-20, 09:31, Greg Kroah-Hartman wrote: > > > On Tue, Aug 18, 2020 at 12:47:39PM +0530, Vinod Koul wrote: > > > > Some devices in wild are reporting

Re: [PATCH v3] usb: renesas-xhci: remove version check

2020-08-18 Thread Vinod Koul
On 18-08-20, 09:31, Greg Kroah-Hartman wrote: > On Tue, Aug 18, 2020 at 12:47:39PM +0530, Vinod Koul wrote: > > Some devices in wild are reporting bunch of firmware versions, so remove > > the check for versions in driver > > > > Reported by: Anastasios Vacharakis >

Re: [PATCH 1/2] soundwire: add definition for maximum number of ports

2020-08-18 Thread Vinod Koul
On 18-08-20, 06:53, Liao, Bard wrote: > > -Original Message- > > From: Vinod Koul > > Sent: Tuesday, August 18, 2020 2:36 PM > > To: Bard Liao > > Cc: alsa-de...@alsa-project.org; linux-kernel@vger.kernel.org; > > ti...@suse.de; > > broo...

<    4   5   6   7   8   9   10   11   12   13   >