> On Tue, Mar 16, 2021 at 05:27:06PM +0800, Shengjiu Wang wrote:
> > From: Viorel Suman
> >
> > SAI software reset is done in runtime resume, there is no need to do
> > it in fsl_sai_dai_probe.
>
> People can disable runtime PM in their configurations - d
From: Viorel Suman
"fw" variable must be relased before return.
Signed-off-by: Viorel Suman
---
sound/soc/fsl/fsl_xcvr.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/fsl/fsl_xcvr.c b/sound/soc/fsl/fsl_xcvr.c
index 2a28810d0e29..3d58c88ea603 100644
--- a/sou
Hi Peter,
> DTS is supposed to look as follows:
> >
> > / {
> > ak4458_reset: gpio-reset {
> >compatible = "gpio-reset";
> >reset-gpios = < 4 GPIO_ACTIVE_LOW>;
> >#reset-cells = <0>;
> >initially-in-reset;
>
> I can not find anything resembling to this in
> On Tue, Nov 17, 2020 at 06:17:36PM +0000, Viorel Suman wrote:
> > > On Tue, Nov 17, 2020 at 12:20:36AM +0200, Viorel Suman (OSS) wrote:
>
> > > One thing I'm not clear on is if there's some way to ensure that we
> > > don't have different instances of the de
> On Tue, Nov 17, 2020 at 12:20:36AM +0200, Viorel Suman (OSS) wrote:
>
> > static void ak4458_power_off(struct ak4458_priv *ak4458) {
> > - if (ak4458->reset_gpiod) {
> > - gpiod_set_value_cansleep(ak4458->reset_gpiod, 0);
> >
From: Viorel Suman
Using GPIO API seems not a way to go for the case
when the same reset GPIO is used to control several codecs.
For a such case we can use the "gpio-reset" driver
and the "shared" reset API to manage the reset GPIO -
to deassert the reset when the first
From: Viorel Suman
The break condition copied by mistake as same
as loop condition in the previous version, but must
be the opposite. So fix it.
Signed-off-by: Viorel Suman
---
sound/soc/fsl/fsl_xcvr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/fsl
From: Viorel Suman
DAI driver for new XCVR IP found in i.MX8MP.
Viorel Suman (2):
ASoC: fsl_xcvr: Add XCVR ASoC CPU DAI driver
ASoC: dt-bindings: fsl_xcvr: Add document for XCVR
Changes since v1:
- improved 6- and 12-ch layout comment
- used regmap polling function, improved
clocks
From: Viorel Suman
XCVR (Audio Transceiver) is a new IP module found on i.MX8MP.
Signed-off-by: Viorel Suman
---
.../devicetree/bindings/sound/fsl,xcvr.yaml | 104 ++
1 file changed, 104 insertions(+)
create mode 100644 Documentation/devicetree/bindings/sound/fsl,xcvr.yaml
From: Viorel Suman
XCVR (Audio Transceiver) is a on-chip functional module found
on i.MX8MP. It support HDMI2.1 eARC, HDMI1.4 ARC and SPDIF.
Signed-off-by: Viorel Suman
---
sound/soc/fsl/Kconfig| 10 +
sound/soc/fsl/Makefile |2 +
sound/soc/fsl/fsl_xcvr.c | 1359
Hi Rob,
Thank you for review, fixed in V4.
/Viorel
> -Original Message-
> From: Rob Herring [mailto:r...@kernel.org]
> Sent: Tuesday, October 6, 2020 9:35 PM
> To: Viorel Suman (OSS)
> Cc: Liam Girdwood ; Mark Brown
> ; Jaroslav Kysela ; Takashi Iwai
> ; Timu
Hi Philipp,
Thank you for your review, please check my comments inline.
/Viorel
> -Original Message-
> From: Philipp Zabel [mailto:p...@pengutronix.de]
> Sent: Tuesday, September 22, 2020 3:09 PM
> To: Viorel Suman (OSS)
> Cc: Liam Girdwood ; Mark Brown
> ; Rob
From: Viorel Suman
DAI driver for new XCVR IP found in i.MX8MP.
Viorel Suman (2):
ASoC: fsl_xcvr: Add XCVR ASoC CPU DAI driver
ASoC: dt-bindings: fsl_xcvr: Add document for XCVR
Changes since v1:
- improved 6- and 12-ch layout comment
- used regmap polling function, improved
clocks
From: Viorel Suman
XCVR (Audio Transceiver) is a on-chip functional module found
on i.MX8MP. It support HDMI2.1 eARC, HDMI1.4 ARC and SPDIF.
Signed-off-by: Viorel Suman
---
sound/soc/fsl/Kconfig| 10 +
sound/soc/fsl/Makefile |2 +
sound/soc/fsl/fsl_xcvr.c | 1356
From: Viorel Suman
XCVR (Audio Transceiver) is a new IP module found on i.MX8MP.
Signed-off-by: Viorel Suman
---
.../devicetree/bindings/sound/fsl,xcvr.yaml| 103 +
1 file changed, 103 insertions(+)
create mode 100644 Documentation/devicetree/bindings/sound/fsl
From: Viorel Suman
XCVR (Audio Transceiver) is a on-chip functional module found
on i.MX8MP. It support HDMI2.1 eARC, HDMI1.4 ARC and SPDIF.
Signed-off-by: Viorel Suman
---
sound/soc/fsl/Kconfig| 10 +
sound/soc/fsl/Makefile |2 +
sound/soc/fsl/fsl_xcvr.c | 1343
From: Viorel Suman
XCVR (Audio Transceiver) is a new IP module found on i.MX8MP.
Signed-off-by: Viorel Suman
---
.../devicetree/bindings/sound/fsl,xcvr.yaml| 103 +
1 file changed, 103 insertions(+)
create mode 100644 Documentation/devicetree/bindings/sound/fsl
From: Viorel Suman
DAI driver for new XCVR IP found in i.MX8MP.
Viorel Suman (2):
ASoC: fsl_xcvr: Add XCVR ASoC CPU DAI driver
ASoC: dt-bindings: fsl_xcvr: Add document for XCVR
Changes since v1:
- improved 6- and 12-ch layout comment
- used regmap polling function, improved
clocks
> On Fri, Sep 18, 2020 at 03:02:39PM +0000, Viorel Suman (OSS) wrote:
>
> Please fix your mail client to word wrap within paragraphs at something
> substantially less than 80 columns. Doing this makes your messages much
> easier
> to read and reply to.
&
Hi Mark,
Thank you for your review.
> On Wed, Sep 16, 2020 at 12:17:55PM +0300, Viorel Suman (OSS) wrote:
> > +static int fsl_xcvr_load_firmware(struct fsl_xcvr *xcvr) {
> > + struct device *dev = >pdev->dev;
> > + const struct firmware *fw;
> > + int
Hi Nicolin,
Thank you for your review.
> > +static const u32 fsl_xcvr_earc_channels[] = { 1, 2, 8, 16, 32, }; /*
> > +one bit 6, 12 ? */
>
> What's the meaning of the comments?
Just a thought noted as comment. HDMI2.1 spec defines 6- and 12-channels layout
when
one bit audio stream is
From: Viorel Suman
XCVR (Audio Transceiver) is a new IP module found on i.MX8MP.
Signed-off-by: Viorel Suman
---
.../devicetree/bindings/sound/fsl,xcvr.yaml| 104 +
1 file changed, 104 insertions(+)
create mode 100644 Documentation/devicetree/bindings/sound/fsl
From: Viorel Suman
XCVR (Audio Transceiver) is a on-chip functional module found
on i.MX8MP. It support HDMI2.1 eARC, HDMI1.4 ARC and SPDIF.
Signed-off-by: Viorel Suman
---
sound/soc/fsl/Kconfig| 10 +
sound/soc/fsl/Makefile |2 +
sound/soc/fsl/fsl_xcvr.c | 1352
From: Viorel Suman
DAI driver for new XCVR IP found in i.MX8MP.
Viorel Suman (2):
ASoC: fsl_xcvr: Add XCVR ASoC CPU DAI driver
ASoC: dt-bindings: fsl_xcvr: Add document for XCVR
.../devicetree/bindings/sound/fsl,xcvr.yaml| 104 ++
sound/soc/fsl/Kconfig
From: Viorel Suman
"alsactl -f state.conf store/restore" sequence fails because setting
"mixing clock source" and "output source" requires active TDM clock
being started for configuration propagation. Make these two controls
write only so that their values ar
On Jo, 2019-05-16 at 10:14 -0300, Fabio Estevam wrote:
> On Thu, May 16, 2019 at 10:02 AM Viorel Suman wrote:
>
> >
> > + for (i = 0; i < ARRAY_SIZE(ak4458->supplies); i++)
> > + ak4458->supplies[i].supply = ak4458_suppl
From: Shengjiu Wang
Add regulator for ak4458.
Signed-off-by: Shengjiu Wang
Signed-off-by: Viorel Suman
---
sound/soc/codecs/ak4458.c | 27 ++-
1 file changed, 26 insertions(+), 1 deletion(-)
diff --git a/sound/soc/codecs/ak4458.c b/sound/soc/codecs/ak4458.c
index
AK4458 is probed successfully even if AK4458 is not present - this
is caused by probe function returning no error on i2c access failure.
Return an error on probe if i2c access has failed.
Signed-off-by: Shengjiu Wang
Signed-off-by: Viorel Suman
---
sound/soc/codecs/ak4458.c | 13
AK4458 is probed successfully even if AK4458 is not present - this
is caused by probe function returning no error on i2c access failure.
The patchset fixes this.
Changes since V1:
Conditional statement rewritten as suggested by Mark.
Viorel Suman (2):
ASoC: ak4458: rstn_control - return
snd_soc_component_update_bits() may return 1 if operation
was successful and the value of the register changed.
Return a non-zero in ak4458_rstn_control for an error only.
Signed-off-by: Shengjiu Wang
Signed-off-by: Viorel Suman
---
sound/soc/codecs/ak4458.c | 5 -
1 file changed, 4
AK4458 is probed successfully even if AK4458 is not present - this
is caused by probe function returning no error on i2c access failure.
The patchset fixes this.
Viorel Suman (2):
ASoC: ak4458: rstn_control - return a non-zero on error only
ASoC: ak4458: add return value for ak4458_probe
AK4458 is probed successfully even if AK4458 is not present - this
is caused by probe function returning no error on i2c access failure.
Return an error on probe if i2c access has failed.
Signed-off-by: Shengjiu Wang
Signed-off-by: Viorel Suman
---
sound/soc/codecs/ak4458.c | 13
snd_soc_component_update_bits() may return 1 if operation
was successful and the value of the register changed.
Return a non-zero in ak4458_rstn_control for an error only.
Signed-off-by: Shengjiu Wang
Signed-off-by: Viorel Suman
---
sound/soc/codecs/ak4458.c | 3 ++-
1 file changed, 2
There should be no trouble to understand dev = pdev->dev.
This can save some space to have more print info or save
some wrapped lines.
Signed-off-by: Viorel Suman
Suggested-by: Nicolin Chen
---
sound/soc/fsl/fsl_audmix.c | 27 +--
1 file changed, 13 insertions(+),
Use "of_device_id.data" to specify the machine driver
instead of "model" DTS attribute.
Signed-off-by: Viorel Suman
Acked-by: Nicolin Chen
---
sound/soc/fsl/fsl_audmix.c | 43 +++
1 file changed, 23 insertions(+), 20 deletions(-)
di
probe reported by
Julia Lawall.
Viorel Suman (4):
ASoC: fsl_audmix: remove "model" attribute
ASoC: fsl_audmix: remove "model" attribute from DT document
ASoC: imx-audmix: fix object reference leaks in probe
ASoC: fsl_audmix: cache pdev->dev pointer
Changes since V1:
a) Rem
Hi Mark,
On Mi, 2019-04-10 at 11:39 +0100, Mark Brown wrote:
> On Wed, Apr 10, 2019 at 10:37:30AM +0000, Viorel Suman wrote:
> >
> > Remove "model" attribute.
> >
> > Signed-off-by: Viorel Suman
> > Acked-by: Nicolin Chen
> Please use subj
This patch implements Audio Mixer machine driver for NXP iMX8 SOCs.
It connects together Audio Mixer and related SAI instances.
Signed-off-by: Viorel Suman
Acked-by: Nicolin Chen
---
sound/soc/fsl/Kconfig | 9 ++
sound/soc/fsl/Makefile | 2 +
sound/soc/fsl/imx-audmix.c | 327
Add the DT binding documentation for NXP Audio Mixer
CPU DAI driver.
Signed-off-by: Viorel Suman
Acked-by: Nicolin Chen
Acked-by: Rob Herring
---
.../devicetree/bindings/sound/fsl,audmix.txt | 50 ++
1 file changed, 50 insertions(+)
create mode 100644 Documentation
-by: Viorel Suman
Acked-by: Nicolin Chen
---
sound/soc/fsl/Kconfig | 7 +
sound/soc/fsl/Makefile | 3 +
sound/soc/fsl/fsl_audmix.c | 578 +
sound/soc/fsl/fsl_audmix.h | 102
4 files changed, 690 insertions(+)
create mode 100644
vice driver and
DT binding documentation.
2. Replaced AMIX with AUDMIX in both code and file names as it looks more
RM-compliant.
3. Removed polarity control from CPU DAI driver as suggested by Nicolin.
4. Added machine driver and related DT binding documentation.
Viorel Suman (3):
ASoC: fsl: Add
According to RM SPDIF STC SYSCLK_DF field is 9-bit wide, values
being in 0..511 range. Use a proper type to handle sysclk_df.
Signed-off-by: Viorel Suman
---
sound/soc/fsl/fsl_spdif.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/sound/soc/fsl/fsl_spdif.c b
According to RM SPDIF TXCLK_DF mask is 7-bit wide.
Signed-off-by: Viorel Suman
---
sound/soc/fsl/fsl_spdif.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/fsl/fsl_spdif.h b/sound/soc/fsl/fsl_spdif.h
index 7666dab..e6c61e0 100644
--- a/sound/soc/fsl/fsl_spdif.h
-by: Viorel Suman
---
sound/soc/fsl/Kconfig | 7 +
sound/soc/fsl/Makefile | 3 +
sound/soc/fsl/fsl_audmix.c | 578 +
sound/soc/fsl/fsl_audmix.h | 102
4 files changed, 690 insertions(+)
create mode 100644 sound/soc/fsl/fsl_audmix.c
Add the DT binding documentation for NXP Audio Mixer
CPU DAI driver.
Signed-off-by: Viorel Suman
---
.../devicetree/bindings/sound/fsl,audmix.txt | 50 ++
1 file changed, 50 insertions(+)
create mode 100644 Documentation/devicetree/bindings/sound/fsl,audmix.txt
diff
This patch implements Audio Mixer machine driver for NXP iMX8 SOCs.
It connects together Audio Mixer and related SAI instances.
Signed-off-by: Viorel Suman
---
sound/soc/fsl/Kconfig | 9 ++
sound/soc/fsl/Makefile | 2 +
sound/soc/fsl/imx-audmix.c | 327
vice driver and
DT binding documentation.
2. Replaced AMIX with AUDMIX in both code and file names as it looks more
RM-compliant.
3. Removed polarity control from CPU DAI driver as suggested by Nicolin.
4. Added machine driver and related DT binding documentation.
Viorel Suman (3):
ASoC: fsl: Add
Hi Rob,
On Lu, 2019-01-21 at 09:23 -0600, Rob Herring wrote:
> On Fri, Jan 18, 2019 at 11:46:42AM -0800, Nicolin Chen wrote:
> >
> > On Fri, Jan 18, 2019 at 01:16:24PM +0000, Viorel Suman wrote:
> > >
> > > >
> > > > >
> > > >
Hi Nicolin,
On Vi, 2019-01-18 at 11:46 -0800, Nicolin Chen wrote:
> On Fri, Jan 18, 2019 at 01:16:24PM +0000, Viorel Suman wrote:
> >
> > >
> > > >
> > > > 1. Moved "dais" node from machine driver DTS node to device
> >
3. Removed polarity control from CPU DAI driver as suggested by Nicolin.
4. Added machine driver and related DT binding documentation.
Viorel Suman (3):
ASoC: fsl: Add Audio Mixer CPU DAI driver
ASoC: add fsl_audmix DT binding documentation
ASoC: fsl: Add Audio Mixer machine driver
.../
-by: Viorel Suman
---
sound/soc/fsl/Kconfig | 7 +
sound/soc/fsl/Makefile | 3 +
sound/soc/fsl/fsl_audmix.c | 576 +
sound/soc/fsl/fsl_audmix.h | 102
4 files changed, 688 insertions(+)
create mode 100644 sound/soc/fsl/fsl_audmix.c
Add the DT binding documentation for NXP Audio Mixer
CPU DAI driver.
Signed-off-by: Viorel Suman
---
.../devicetree/bindings/sound/fsl,audmix.txt | 54 ++
1 file changed, 54 insertions(+)
create mode 100644 Documentation/devicetree/bindings/sound/fsl,audmix.txt
diff
This patch implements Audio Mixer machine driver for NXP iMX8 SOCs.
It connects together Audio Mixer and related SAI instances.
Signed-off-by: Viorel Suman
---
sound/soc/fsl/Kconfig | 9 ++
sound/soc/fsl/Makefile | 2 +
sound/soc/fsl/imx-audmix.c | 327
Hi Rob, Nicolin, All,
On Jo, 2019-01-17 at 10:18 -0600, Rob Herring wrote:
> On Thu, Jan 17, 2019 at 12:46:25PM +0000, Viorel Suman wrote:
> >
> > The patchset adds NXP Audio Mixer (AUDMIX) device and machine
> > drivers and related DT bindings documentation.
> >
Add the DT binding documentation for Audio Mixer
machine driver.
Signed-off-by: Viorel Suman
---
Documentation/devicetree/bindings/sound/imx-audmix.txt | 18 ++
1 file changed, 18 insertions(+)
create mode 100644 Documentation/devicetree/bindings/sound/imx-audmix.txt
diff
This patch implements Audio Mixer machine driver for NXP iMX8 SOCs.
It connects together Audio Mixer and related SAI instances.
Signed-off-by: Viorel Suman
---
sound/soc/fsl/Kconfig | 9 ++
sound/soc/fsl/Makefile | 2 +
sound/soc/fsl/imx-audmix.c | 334
ct patches for the device driver and
DT binding documentation.
2. Replaced AMIX with AUDMIX in both code and file names as it looks more
RM-compliant.
3. Removed polarity control from CPU DAI driver as suggested by Nicolin.
4. Added machine driver and related DT binding documentation.
Viorel Suman (
-by: Viorel Suman
---
sound/soc/fsl/Kconfig | 7 +
sound/soc/fsl/Makefile | 3 +
sound/soc/fsl/fsl_audmix.c | 551 +
sound/soc/fsl/fsl_audmix.h | 102 +
4 files changed, 663 insertions(+)
create mode 100644 sound/soc/fsl/fsl_audmix.c
Add the DT binding documentation for NXP Audio Mixer
CPU DAI driver.
Signed-off-by: Viorel Suman
---
.../devicetree/bindings/sound/fsl,audmix.txt | 50 ++
1 file changed, 50 insertions(+)
create mode 100644 Documentation/devicetree/bindings/sound/fsl,audmix.txt
diff
Add the DT binding documentation for Audio Mixer
machine driver.
Signed-off-by: Viorel Suman
---
.../devicetree/bindings/sound/imx-audmix.txt | 24 ++
1 file changed, 24 insertions(+)
create mode 100644 Documentation/devicetree/bindings/sound/imx-audmix.txt
diff
This patch implements Audio Mixer machine driver for NXP iMX8 SOCs.
It connects together Audio Mixer and related SAI instances.
Signed-off-by: Viorel Suman
---
sound/soc/fsl/Kconfig | 9 ++
sound/soc/fsl/Makefile | 2 +
sound/soc/fsl/imx-audmix.c | 333
Add the DT binding documentation for NXP Audio Mixer
CPU DAI driver.
Signed-off-by: Viorel Suman
---
.../devicetree/bindings/sound/fsl,audmix.txt | 44 ++
1 file changed, 44 insertions(+)
create mode 100644 Documentation/devicetree/bindings/sound/fsl,audmix.txt
diff
-by: Viorel Suman
---
sound/soc/fsl/Kconfig | 7 +
sound/soc/fsl/Makefile | 3 +
sound/soc/fsl/fsl_audmix.c | 551 +
sound/soc/fsl/fsl_audmix.h | 102 +
4 files changed, 663 insertions(+)
create mode 100644 sound/soc/fsl/fsl_audmix.c
more
RM-compliant.
3. Removed polarity control from CPU DAI driver as suggested by Nicolin.
4. Added machine driver and related DT binding documentation.
Viorel Suman (4):
ASoC: fsl: Add Audio Mixer CPU DAI driver
ASoC: add fsl_audmix DT binding documentation
ASoC: fsl: Add Audio Mixer
Hi Nicolin,
On Jo, 2019-01-03 at 12:03 -0800, Nicolin Chen wrote:
> Hi,
>
> On Thu, Jan 03, 2019 at 03:56:46PM +0000, Viorel Suman wrote:
> >
> > >
> > > >
> > > > sound/soc/fsl/fsl_amix.c | 554
> > >
> -Original Message-
> From: Rob Herring [mailto:robh...@kernel.org]
> Sent: Thursday, January 3, 2019 8:26 PM
> To: Viorel Suman
> Cc: nicoleots...@gmail.com; dl-linux-imx ; linux-
> ker...@vger.kernel.org; linuxppc-...@lists.ozlabs.org; ti...@kernel.org;
> devic
estions
> below.
>
> On Wed, Dec 19, 2018 at 12:30 AM Viorel Suman
> wrote:
> >
> >
> > This patch implements Audio Mixer CPU DAI driver for NXP iMX8 SOCs.
> > The Audio Mixer is a on-chip functional module that allows mixing
> > of
> > two audio str
Hi Rob,
On Vi, 2018-12-28 at 17:32 -0600, Rob Herring wrote:
> On Tue, Dec 18, 2018 at 04:30:01PM +0000, Viorel Suman wrote:
> >
> > This patch implements Audio Mixer CPU DAI driver for NXP iMX8 SOCs.
> > The Audio Mixer is a on-chip functional module that allows mixing
-by: Viorel Suman
---
.../devicetree/bindings/sound/fsl,amix.txt | 45 ++
sound/soc/fsl/Kconfig | 7 +
sound/soc/fsl/Makefile | 3 +
sound/soc/fsl/fsl_amix.c | 554 +
sound/soc/fsl
A hardware fifo reset always imply an invalidation of the
existing timestamps, so we'll clear timestamps fifo on
successfull hardware fifo reset.
Signed-off-by: Viorel Suman
---
v2: Addressed Jonathan's comment regarding the subject prefix.
drivers/iio/imu/inv_mpu6050/inv_mpu_ring.c | 25
A hardware fifo reset always imply an invalidation of the
existing timestamps, so we'll clear timestamps fifo on
successfull hardware fifo reset.
Signed-off-by: Viorel Suman viorel.su...@gmail.com
---
v2: Addressed Jonathan's comment regarding the subject prefix.
drivers/iio/imu/inv_mpu6050
The timestamp kfifo must be cleared once the
hardware fifo is reset, thus are removed
timestamps related to unprocessed events from
hardware fifo - see "inv_mpu6050_read_fifo"
method implementation.
Signed-off-by: Viorel Suman
---
drivers/iio/imu/inv_mpu6050/inv_mpu_trig
The timestamp kfifo must be cleared once the
hardware fifo is reset, thus are removed
timestamps related to unprocessed events from
hardware fifo - see inv_mpu6050_read_fifo
method implementation.
Signed-off-by: Viorel Suman viorel.su...@gmail.com
---
drivers/iio/imu/inv_mpu6050
73 matches
Mail list logo
