actly like in the past
by stripping the directory part of each file path, before printing the
message.
Signed-off-by: Vladislav Valtchev (VMware)
---
scripts/utils.mk | 26 +-
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/scripts/utils.mk b/scripts/utils.mk
inde
trace-cmd stat is a handy way for users to see what tracing is currently going
on, but currently it does not say anything about the stack tracing. This patch
makes the command to show a message when the stack tracer is ON.
Signed-off-by: Vladislav Valtchev (VMware)
---
trace-cmd.h | 2
il in case there is something wrong with the stack tracer. Only the call to
die() in case the file is empty has been left in this patch: it will be removed
as well in a separate commit.
Signed-off-by: Vladislav Valtchev (VMware)
---
trace-st
This short patch series makes trace-cmd stat aware of the stack tracer: now,
when the stack tracker is ON, the command will report that.
Vladislav Valtchev (VMware) (3):
trace-cmd: Make read_proc() to return int status via OUT arg
trace-cmd: Remove the die() call from read_proc()
trace-cmd
d of using die().
Signed-off-by: Vladislav Valtchev (VMware)
---
trace-stack.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/trace-stack.c b/trace-stack.c
index fada62d..3e1e41b 100644
--- a/trace-stack.c
+++ b/trace-stack.c
@@ -79,7 +79,7 @@ static int read_proc(i
il in case there is something wrong with the stack tracer. Only the call to
die() in case the file is empty has been left in this patch: it will be removed
as well in a separate commit.
Signed-off-by: Vladislav Valtchev (VMware)
---
trace-st
d of using die().
Signed-off-by: Vladislav Valtchev (VMware)
---
trace-stack.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/trace-stack.c b/trace-stack.c
index c1058ca..d55d994 100644
--- a/trace-stack.c
+++ b/trace-stack.c
@@ -79,9 +79,9 @@ static int read_proc(i
This short patch series makes trace-cmd stat aware of the stack tracer: now,
when the stack tracker is ON, the command will report that.
Vladislav Valtchev (VMware) (3):
trace-cmd: Make read_proc() to return int status via OUT arg
trace-cmd: Remove the die() call from read_proc()
trace-cmd
trace-cmd stat is a handy way for users to see what tracing is currently going
on, but currently it does not say anything about the stack tracing. This patch
makes the command to show a message when the stack tracer is ON.
Signed-off-by: Vladislav Valtchev (VMware)
---
trace-cmd.h | 2
making the parent Makefile to
invoke it.
Signed-off-by: Vladislav Valtchev (VMware)
---
Makefile | 42 +--
python/Makefile | 40 +
ctracecmd.i => python/ctracecmd.i | 0
c
d of using die().
Signed-off-by: Vladislav Valtchev (VMware)
---
trace-stack.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/trace-stack.c b/trace-stack.c
index c1058ca..d55d994 100644
--- a/trace-stack.c
+++ b/trace-stack.c
@@ -79,9 +79,9 @@ static int read_proc(i
trace-cmd stat is a handy way for users to see what tracing is currently going
on, but currently it does not say anything about the stack tracing. This patch
makes the command to show a message when the stack tracer is ON.
Signed-off-by: Vladislav Valtchev (VMware)
---
trace-cmd.h | 2
il in case there is something wrong with the stack tracer. Only the call to
die() in case the file is empty has been left in this patch: it will be removed
as well in a separate commit.
Signed-off-by: Vladislav Valtchev (VMware)
---
trace-st
This short patch series makes trace-cmd stat aware of the stack tracer: now,
when the stack tracker is ON, the stat command will report that.
Vladislav Valtchev (VMware) (3):
trace-cmd: Make read_proc() to return int status via OUT arg
trace-cmd: Remove the die() call from read_proc()
trace
This patch moves trace-cmd.h and trace-hash.h in include/trace-cmd as part of a
bigger restructuring plan of trace-cmd's code base. In this case, the new
directory will be the "public headers" directory of the trace-cmd library.
Signed-off-by: Vladislav Valtchev (VMware)
This patch moves event-parse.h and kbuffer.h in include/traceevent as part of a
bigger restructuring plan of trace-cmd's code base. In this case, the new
directory will be the "public headers" directory of the traceevent library.
Signed-off-by: Vladislav Valtchev (VMware)
ed in lib/trace-cmd.
Signed-off-by: Vladislav Valtchev (VMware)
---
Makefile | 1 +
trace-hash-local.h => lib/trace-cmd/include/trace-hash-local.h | 0
2 files changed, 1 insertion(+)
rename trace-hash-local.h => lib/trace-cmd/include/tr
Valtchev (VMware)
---
Makefile | 42 -
lib/traceevent/Makefile | 45 +++
event-parse.c => lib/traceevent/event-parse.c | 0
event-plugin.c => lib/traceevent/event-plugin.c | 0
k
This simple patch renames libparsevent to libtraceevent in order to trace-cmd to
be consistent with the kernel.
Signed-off-by: Vladislav Valtchev (VMware)
---
Makefile | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/Makefile b/Makefile
index b7bb3cc..bd2d844
-by: Vladislav Valtchev (VMware)
---
Makefile | 54 ++
lib/trace-cmd/Makefile | 45 ++
trace-blk-hack.c => lib/trace-cmd/trace-blk-hack.c | 0
trace-ftrace.c => lib/trace-cmd/trace-ft
Makefile
to invoke it.
Signed-off-by: Vladislav Valtchev (VMware)
---
Makefile | 190 -
kernel-shark/Makefile | 84 +
kernel-shark.c => kernel-shark/kernel-shark.c | 0
trace-capture.c =>
Currenly the ctracecmdgui.so target is broken beacause the object files
trace-view.o trace-view-store.o are not built with -fPIC. This patch just fixes
the kernel-shark/Makefile in order to those files to be built with -fPIC.
Signed-off-by: Vladislav Valtchev (VMware)
---
kernel-shark/Makefile
le
to invoke it.
Signed-off-by: Vladislav Valtchev (VMware)
---
Makefile | 115 ++---
lib/trace-cmd/Makefile | 2 +
plugins/Makefile | 69 +
plugin_blk.c =>
This patch moves trace-cmd's private headers in a dedicated directory called
tracecmd/include, as part of a bigger restructuring plan of trace-cmd's code
base.
Signed-off-by: Vladislav Valtchev (VMware)
---
Makefile| 1 +
bug.h => tra
making the parent Makefile to
invoke it.
Signed-off-by: Vladislav Valtchev (VMware)
---
Makefile | 41 +--
python/Makefile | 40 ++
ctracecmd.i => python/ctracecmd.i | 0
c
This patch moves all the remaining C files in the project's root directory to
tracecmd, a directory dedicated to the trace-cmd application itself. This patch
completes the bigger restructuring plan of trace-cmd's code base.
Signed-off-by: Vladislav Valtchev (VMware)
---
This trivial patch just moves the only header file remained in project's root
directory to the include/ directory, common for all of the trace-cmd's
sub-projects.
Signed-off-by: Vladislav Valtchev (VMware)
---
version.h => include/version.h | 0
1 file changed, 0 insertions(+)
.
Signed-off-by: Vladislav Valtchev (VMware)
---
Makefile | 7 +++
1 file changed, 7 insertions(+)
diff --git a/Makefile b/Makefile
index 0a2a78d..f463d1f 100644
--- a/Makefile
+++ b/Makefile
@@ -119,6 +119,8 @@ ifeq ($(shell sh -c "pkg-config --cflags $(PYTHON_VERS) >
/dev/null 2>
the problem by using the POSIX 'comamnd -v {CMD}'
in $(shell ...) to detect the presence of the swig and restores this way the
fake report_noswig target.
Signed-off-by: Vladislav Valtchev (VMware)
---
Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Mak
This patch moves, as part of a bigger code base restructuring, all the header
files of kernelshark in a dedicated directory. The next patch will move all
of kernelshark's source files in kernel-shark/.
Signed-off-by: Vladislav Valtchev (VMware)
---
Mak
This patch extracts useful functions for Makefile in order to allow the new
Makefiles that will be introduced in the next steps to reuse them.
Signed-off-by: Vladislav Valtchev (VMware)
---
Makefile | 57 +++--
scripts/utils.mk | 64
moved there as well.
Signed-off-by: Vladislav Valtchev (VMware)
---
Makefile | 1 +
event-utils.h => lib/traceevent/include/event-utils.h | 0
2 files changed, 1 insertion(+)
rename event-utils.h => lib/traceevent/include/event-utils.h (100%)
d
ost all of the effort in this
series has been spent on updating the build system to support the new structure.
The side-effect of that is a simpler and easier to maintain build system.
Vladislav Valtchev (VMware) (18):
trace-cmd: Rename libparsevent to libtraceevent
trace-cmd: Move libtraceevent
This patch extracts the code in record_trace() under if (IS_PROFILE(ctx)): now
that profile has its own function, that code could be moved there after removing
the IS_PROFILE(ctx) checks, clearly.
Signed-off-by: Vladislav Valtchev (VMware)
---
trace-record.c | 18 --
1 file
made
to call do_trace_profile() after some initialization.
Signed-off-by: Vladislav Valtchev (VMware)
---
trace-local.h | 2 +-
trace-profile.c | 2 +-
trace-read.c| 2 +-
trace-record.c | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/trace-local.h b/trace-local.h
index c01
int, making the code simpler to
maintain.
Signed-off-by: Vladislav Valtchev (VMware)
---
trace-cmd.c| 8 +++
trace-local.h | 8 +++
trace-record.c | 72 ++
3 files changed, 64 insertions(+), 24 deletions(-)
diff --git a/trac
This patch replaces 5 mutually exclusive flag variables (extract, start, stream,
record, profile) in trace_record() with a more convenient enum. The point of
doing that is to make the code simpler and easier to maintain.
Signed-off-by: Vladislav Valtchev (VMware)
---
trace-record.c | 94
scope and the
complexity of trace_record().
Signed-off-by: Vladislav Valtchev (VMware)
---
trace-record.c | 335 ++---
1 file changed, 179 insertions(+), 156 deletions(-)
diff --git a/trace-record.c b/trace-record.c
index 770b5bd..487d35e
after the
call of parse_record_option(), since they did not actually affect it.
Signed-off-by: Vladislav Valtchev (VMware)
---
trace-record.c | 19 ---
1 file changed, 8 insertions(+), 11 deletions(-)
diff --git a/trace-record.c b/trace-record.c
index 55e81cf..7688565 100644
--- a
This patch aims to reduce the size of common_record_commads_code() by removing
a relatively long 'else if' sequence that was used to do the mapping between the
current trace command and the trace_type used by it.
Signed-off-by: Vladislav Valtchev (VMware)
---
trace-rec
false] has been
applyed to record_trace().
The purpose of doing that is to reduce the amount of branches in both the cases
(extract and everything else), making the code simpler to understand and follow
but at the price of having some copy-pasted code.
Signed-off-by: Vladislav Valtchev (VMware
#x27;stream' and 'profile' to have an
independent entry-point from 'record'.
Signed-off-by: Vladislav Valtchev (VMware)
---
trace-record.c | 146 +
1 file changed, 75 insertions(+), 71 deletions(-)
diff --git a/trac
This patch splits record_trace() in two parts by moving its finalization part
in a separate function. This will also allow splitting out trace-cmd extract
code from trace-cmd record code, by using a shared function.
Signed-off-by: Vladislav Valtchev (VMware)
---
trace-record.c | 48
this effort is to make the code much easier to maintain.
Vladislav Valtchev (VMware) (10):
trace-cmd: Extract parse_record_options() from trace_record()
trace-cmd: Replacing cmd flags w/ a trace_cmd enum
trace-cmd: Extracting record_trace()
trace-cmd: Rename trace_profile() to
ned-off-by: Vladislav Valtchev (VMware)
---
trace-cmd.c| 2 +-
trace-local.h | 2 ++
trace-record.c | 74 --
3 files changed, 44 insertions(+), 34 deletions(-)
diff --git a/trace-cmd.c b/trace-cmd.c
index de5283c..2b9146e 100644
-
ned-off-by: Vladislav Valtchev (VMware)
---
trace-cmd.c| 2 +-
trace-local.h | 2 +
trace-record.c | 147 ++---
3 files changed, 81 insertions(+), 70 deletions(-)
diff --git a/trace-cmd.c b/trace-cmd.c
index 2b9146e..7bab476 100644
--- a/t
this effort is to make the code much easier to maintain.
Vladislav Valtchev (VMware) (11):
trace-cmd: Extract trace_stop() from trace_record()
trace-cmd: Extract trace_restart() from trace_record()
trace-cmd: Extract trace_reset() from trace_record()
trace-cmd: Extract parse_record_options
scope and the
complexity of trace_record().
Signed-off-by: Vladislav Valtchev (VMware)
---
trace-record.c | 336 ++---
1 file changed, 180 insertions(+), 156 deletions(-)
diff --git a/trace-record.c b/trace-record.c
index 8f8d270..6dc828b
Vladislav Valtchev (VMware)
---
trace-cmd.h | 2 ++
trace-local.h | 6 +++---
trace-util.c | 8 +++-
3 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/trace-cmd.h b/trace-cmd.h
index 3fb6aab..6fd34d7 100644
--- a/trace-cmd.h
+++ b/trace-cmd.h
@@ -23,6 +23,8 @@
#include &quo
int, making the code simpler to
maintain.
Signed-off-by: Vladislav Valtchev (VMware)
---
trace-cmd.c| 8 ++---
trace-local.h | 8 +
trace-record.c | 102 +
3 files changed, 78 insertions(+), 40 deletions(-)
diff --git a/trac
Since ARRAY_SIZE() is a very useful macro, it makes sense to move it in a common
header file, in order to avoid several C files to re-define it.
Signed-off-by: Vladislav Valtchev (VMware)
---
plugin_blk.c | 1 -
trace-cmd.c | 2 --
trace-cmd.h | 2 ++
3 files changed, 2 insertions(+), 3
#x27;stream' and 'profile' to have an
independent entry-point from 'record'.
Signed-off-by: Vladislav Valtchev (VMware)
---
trace-record.c | 148 +
1 file changed, 76 insertions(+), 72 deletions(-)
diff --git a/trac
This patch replaces 5 mutually exclusive flag variables (extract, start, stream,
record, profile) in trace_record() with a more convenient enum. The point of
doing that is to make the code simpler and easier to maintain.
Signed-off-by: Vladislav Valtchev (VMware)
---
trace-record.c | 94
This patch aims to reduce the size of common_record_commads_code() by removing
a relatively long 'else if' sequence that was used to do the mapping between the
current trace command and the trace_type used by it.
Signed-off-by: Vladislav Valtchev (VMware)
---
trace-rec
made
to call trace_profile_int() after some initialization.
Signed-off-by: Vladislav Valtchev (VMware)
---
trace-local.h | 2 +-
trace-profile.c | 2 +-
trace-read.c| 2 +-
trace-record.c | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/trace-local.h b/trace-local.h
index 49e
ned-off-by: Vladislav Valtchev (VMware)
---
trace-cmd.c| 2 +-
trace-local.h | 2 ++
trace-record.c | 78 --
3 files changed, 46 insertions(+), 36 deletions(-)
diff --git a/trace-cmd.c b/trace-cmd.c
index 5a10605..de5283c 100644
--- a/t
anged over time: what we call today "tracers" use to be called "plugins" when
ftrace was created. This simple patch updates trace-cmd record's man page
accordingly, in order to avoid any confusion and improve the user experience.
Signed-off-by: Vladislav Valtchev (VMware)
--
trace_record() allowing, in the same case, the execution to
continue a few more statements and fail more gracefully in the function
check_doing_something() with the following message:
no event or plugin was specified... aborting
Signed-off-by: Vladislav Valtchev (VMware)
---
trace-record.c | 6
trace-cmd stat is a handy way for users to see what tracing is currently going
on, but currently is does not say anything about the stack tracing. This simple
patch makes the command to show a message when the stack tracer is ON.
Signed-off-by: Vladislav Valtchev (VMware)
---
trace-cmd.h | 3
is enabled
The purpose of this effort is to improve the user experience of the tool.
Vladislav Valtchev (VMware) (3):
trace-cmd: Fix err msg for record w/o the -e option
trace-cmd: s/plugin/tracer/ in record's man page
trace-cmd: Making stat to report when the stack tracer is ON
Document
anged over time: what we call today "tracers" use to be called "plugins" when
ftrace was created. This simple patch updates trace-cmd record's man page
accordingly, in order to avoid any confusion and improve the user experience.
Signed-off-by: Vladislav Valtchev (VMware)
--
trace-cmd stat is a handy way for users to see what tracing is currently going
on, but currently is does not say anything about the stack tracing. This simple
patch makes the command to show a message when the stack tracer is ON.
Signed-off-by: Vladislav Valtchev (VMware)
---
trace-cmd.h | 3
trace_record() allowing, in the same case, the execution to
continue a few more statements and fail more gracefully in the function
check_doing_something() with the following message:
no event or plugin was specified... aborting
Signed-off-by: Vladislav Valtchev (VMware)
---
trace-record.c | 6
63 matches
Mail list logo
