Re: [PATCH] Fix ALPS sync loss

2005-02-08 Thread Vojtech Pavlik
->pktcnt <= 6 && > - (psmouse->packet[psmouse->pktcnt] & 0x80)) > + if (psmouse->pktcnt >= 2 && psmouse->pktcnt <= 6 && > + (psmouse->packet[psmouse->pktcnt - 1] & 0x80)) > return PSMOUSE_BAD_DATA; >

Re: [PATCH] hot-swapping support for PSX controllers

2005-02-08 Thread Vojtech Pavlik
; -- > Fixes hotplug support for PSX controllers and some mis-sized arrays. > > Signed-off-by: Eric Piel <[EMAIL PROTECTED]> > Signed-off-by: Peter Nelson <[EMAIL PROTECTED]> > -- Thanks; applied. -- Vojtech Pavlik SuSE Labs, SuSE CR - To unsubscribe from this list: s

Re: [PATCH] Linux joydev joystick disconnect patch 2.6.11-rc2

2005-02-08 Thread Vojtech Pavlik
On Mon, Feb 07, 2005 at 09:22:19AM -0500, Dmitry Torokhov wrote: > On Mon, 7 Feb 2005 13:20:33 +0100, Vojtech Pavlik <[EMAIL PROTECTED]> wrote: > > On Sun, Feb 06, 2005 at 08:21:13PM -0500, Dmitry Torokhov wrote: > > > > > Opening braces should go on

[RFC/RFT] [patch] Elo serial touchscreen driver

2005-02-08 Thread Vojtech Pavlik
if you have the time, please comment on the code of the patch, and if you have an Elo, please try the driver with it. Patch attached, also attached is an uptodate version of inputattach, a program needed to get the kernel to talk to the device. -- Vojtech Pavlik SuSE Labs, SuSE CR [EMAIL PROTECTED

Re: [PATCH] hid-core: Configurable USB HID Mouse Interrupt Polling Interval

2005-02-08 Thread Vojtech Pavlik
new patch is not modifying the device descriptors, which should be considered read-only by driver code, it only changes only the actual polling behavior. -- Vojtech Pavlik SuSE Labs, SuSE CR - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: [PATCH] hid-core: Configurable USB HID Mouse Interrupt Polling Interval

2005-02-08 Thread Vojtech Pavlik
by driver code, it only changes only the actual polling behavior. -- Vojtech Pavlik SuSE Labs, SuSE CR - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read

[RFC/RFT] [patch] Elo serial touchscreen driver

2005-02-08 Thread Vojtech Pavlik
if you have the time, please comment on the code of the patch, and if you have an Elo, please try the driver with it. Patch attached, also attached is an uptodate version of inputattach, a program needed to get the kernel to talk to the device. -- Vojtech Pavlik SuSE Labs, SuSE CR [EMAIL PROTECTED

Re: [PATCH] Linux joydev joystick disconnect patch 2.6.11-rc2

2005-02-08 Thread Vojtech Pavlik
On Mon, Feb 07, 2005 at 09:22:19AM -0500, Dmitry Torokhov wrote: On Mon, 7 Feb 2005 13:20:33 +0100, Vojtech Pavlik [EMAIL PROTECTED] wrote: On Sun, Feb 06, 2005 at 08:21:13PM -0500, Dmitry Torokhov wrote: Opening braces should go on the same line as the statement

Re: [PATCH] hot-swapping support for PSX controllers

2005-02-08 Thread Vojtech Pavlik
. Signed-off-by: Eric Piel [EMAIL PROTECTED] Signed-off-by: Peter Nelson [EMAIL PROTECTED] -- Thanks; applied. -- Vojtech Pavlik SuSE Labs, SuSE CR - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH] Fix ALPS sync loss

2005-02-08 Thread Vojtech Pavlik
)) return PSMOUSE_BAD_DATA; if (psmouse-pktcnt == 6) { -- Vojtech Pavlik SuSE Labs, SuSE CR - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read

Re: [PATCH] Linux joydev joystick disconnect patch 2.6.11-rc2

2005-02-07 Thread Vojtech Pavlik
t; disconnect routines as well? This should do it: [EMAIL PROTECTED], 2005-02-07 13:19:59+01:00, [EMAIL PROTECTED] input: Do a kill_fasync() in input handlers on device disconnect to notify a client using poll() that the device is gone. Signed-off-by: Vojtech Pavlik <[EMAIL PROTECTED]>

Re: [PATCH] twiddler compile fix.

2005-02-07 Thread Vojtech Pavlik
], 2005-02-06 20:25:21-05:00, [EMAIL PROTECTED] > Input: fix compie error in twidjoy.c > > Signed-off-by: Dmitry Torokhov <[EMAIL PROTECTED]> > > > twidjoy.c |4 +++- > 1 files changed, 3 insertions(+), 1 deletion(-) > > > ====

Re: [PATCH 2.6.11-rc3] IBM Trackpoint support

2005-02-07 Thread Vojtech Pavlik
n-to-scroll would be doable in userspace, yes. -- Vojtech Pavlik SuSE Labs, SuSE CR - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [2.6 patch] input: make some code static

2005-02-07 Thread Vojtech Pavlik
is ready for Vojtech to pull from. Yes, it's now in my tree, too. -- Vojtech Pavlik SuSE Labs, SuSE CR - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/major

Re: [patch] ns558 bug

2005-02-07 Thread Vojtech Pavlik
patch. Thanks; applied. -- Vojtech Pavlik SuSE Labs, SuSE CR - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [patch] ns558 bug

2005-02-07 Thread Vojtech Pavlik
On Fri, Feb 04, 2005 at 09:00:54PM +0100, matthieu castet wrote: Hi, this patch is based on http://bugzilla.kernel.org/show_bug.cgi?id=2962 patch from adam belay. It solve a oops when pnp_register_driver(ns558_pnp_driver) failed. Please apply this patch. Thanks; applied. -- Vojtech

Re: [2.6 patch] input: make some code static

2005-02-07 Thread Vojtech Pavlik
, it's now in my tree, too. -- Vojtech Pavlik SuSE Labs, SuSE CR - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 2.6.11-rc3] IBM Trackpoint support

2005-02-07 Thread Vojtech Pavlik
in userspace? It is probably usable on non-trackpoint devices, too... For a big part it's not possible to do in userspace, because the touchpoint doesn't give the pressure information, it only can be mapped to a button click. But middle-button-to-scroll would be doable in userspace, yes. -- Vojtech

Re: [PATCH] twiddler compile fix.

2005-02-07 Thread Vojtech Pavlik
: fix compie error in twidjoy.c Signed-off-by: Dmitry Torokhov [EMAIL PROTECTED] twidjoy.c |4 +++- 1 files changed, 3 insertions(+), 1 deletion(-) === Thanks; applied. -- Vojtech Pavlik SuSE Labs, SuSE CR

Re: [PATCH] Linux joydev joystick disconnect patch 2.6.11-rc2

2005-02-07 Thread Vojtech Pavlik
it: [EMAIL PROTECTED], 2005-02-07 13:19:59+01:00, [EMAIL PROTECTED] input: Do a kill_fasync() in input handlers on device disconnect to notify a client using poll() that the device is gone. Signed-off-by: Vojtech Pavlik [EMAIL PROTECTED] evdev.c|3 +++ joydev.c |3

Re: [PATCH] Linux joydev joystick disconnect patch 2.6.11-rc2

2005-02-06 Thread Vojtech Pavlik
On Sun, Feb 06, 2005 at 08:21:13PM -0500, Dmitry Torokhov wrote: > On Sunday 06 February 2005 08:12, Vojtech Pavlik wrote: > > On Tue, Feb 01, 2005 at 10:24:39AM -0500, Dmitry Torokhov wrote: > > > On Tue, 1 Feb 2005 08:52:15 -0600, David Fries <[EMAIL PROTECTED]>

Re: [2.6 patch] drivers/input/gameport/cs461x.c: remove bouncing email address

2005-02-06 Thread Vojtech Pavlik
ODULE_AUTHOR("Victor Krapivin"); > MODULE_LICENSE("GPL"); Thanks; applied. -- Vojtech Pavlik SuSE Labs, SuSE CR - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] remove pointless <0 comparisons for unsigned vars, and avoid a few signed vs unsigned comparisons in drivers/char/keyboard.c

2005-02-06 Thread Vojtech Pavlik
variables are > comared, and as far as I can tell they really should just all be unsigned. > > Comments welcome (I must confess that I've only compile tested this so > far). > > Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> Looks sane: Applied. -- Vojtech Pa

Re: [PATCH] hid-core: Configurable USB HID Mouse Interrupt Polling Interval

2005-02-06 Thread Vojtech Pavlik
h-speed when setting the parameter. Also the endpoint descriptor should be considered read only. > Signed-off-by: Mikkel Krautz <[EMAIL PROTECTED]> > --- > > > hid-core.c |9 - > 1 files changed, 8 insertions(+), 1 deletion(-) > > > --- clean/dr

Re: Linux input event extending tool exist?

2005-02-06 Thread Vojtech Pavlik
On Wed, Dec 15, 2004 at 11:41:38PM -0500, Eric Lammerts wrote: > Vojtech Pavlik wrote: > >You can use evtest (attached). It's often found in the joystick RPMs. > >It's also in the linuxconsole.sf.net CVS repository. On recent kernels > >it'll show the scancodes as well as t

Re: [PATCH] Linux joydev joystick disconnect patch 2.6.11-rc2

2005-02-06 Thread Vojtech Pavlik
{ > >joydev_free(joydev); > > + } > > Opening braces should go on the same line as the statement (if (...) {). How about this patch? [EMAIL PROTECTED], 2005-02-06 13:58:37+01:00, [EMAIL PROTECTED] input: Fix poll() behavior of input handlers on disc

Re: [PATCH] adding the ICS MK712 touchscreen driver to 2.6

2005-02-06 Thread Vojtech Pavlik
return 0; > > + > > + outb(0, mk712_io + MK712_CONTROL); /* Reset */ > > + > > We really should stop ignoring races and locking issues. Atomic perhaps? You're right, as usual. ;) How about this one? The spinlock also protects from concurrent hardware register ac

Re: [PATCH] Add resume support to serio bus.

2005-02-06 Thread Vojtech Pavlik
longer > needed. > > Tested on S4 (swsusp) with Synaptics touchpad. Nice. Applied. -- Vojtech Pavlik SuSE Labs, SuSE CR - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.ker

Re: [RFC/RFT] Better handling of bad xfers/interrupt delays in psmouse

2005-02-06 Thread Vojtech Pavlik
command, and after the three bytes from POLL are sent, the mouse could just continue sending the packet like with any other command. -- Vojtech Pavlik SuSE Labs, SuSE CR - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTE

Re: [RFC/RFT] Better handling of bad xfers/interrupt delays in psmouse

2005-02-06 Thread Vojtech Pavlik
On Sun, Feb 06, 2005 at 12:29:20AM -0500, Dmitry Torokhov wrote: > On Saturday 05 February 2005 16:11, Vojtech Pavlik wrote: > > On Sat, Feb 05, 2005 at 02:48:56PM -0500, Dmitry Torokhov wrote: > > > Hi, > > > > > > The patch below attempts to better han

Re: [RFC/RFT] Better handling of bad xfers/interrupt delays in psmouse

2005-02-06 Thread Vojtech Pavlik
On Sun, Feb 06, 2005 at 12:29:20AM -0500, Dmitry Torokhov wrote: On Saturday 05 February 2005 16:11, Vojtech Pavlik wrote: On Sat, Feb 05, 2005 at 02:48:56PM -0500, Dmitry Torokhov wrote: Hi, The patch below attempts to better handle situation when psmouse interrupt is delayed

Re: [RFC/RFT] Better handling of bad xfers/interrupt delays in psmouse

2005-02-06 Thread Vojtech Pavlik
, the mouse could just continue sending the packet like with any other command. -- Vojtech Pavlik SuSE Labs, SuSE CR - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Add resume support to serio bus.

2005-02-06 Thread Vojtech Pavlik
. Tested on S4 (swsusp) with Synaptics touchpad. Nice. Applied. -- Vojtech Pavlik SuSE Labs, SuSE CR - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read

Re: [PATCH] adding the ICS MK712 touchscreen driver to 2.6

2005-02-06 Thread Vojtech Pavlik
converting a driver ... [EMAIL PROTECTED], 2005-02-06 10:13:52+01:00, [EMAIL PROTECTED] input: New driver for ICS MicroClock MK712 TouchScreens. Signed-off-by: Vojtech Pavlik [EMAIL PROTECTED] Kconfig | 11 +++ Makefile |3 mk712.c | 222

Re: [PATCH] Linux joydev joystick disconnect patch 2.6.11-rc2

2005-02-06 Thread Vojtech Pavlik
() behavior of input handlers on disconnect. Signed-off-by: Vojtech Pavlik [EMAIL PROTECTED] evdev.c|5 ++--- joydev.c | 10 +- mousedev.c |6 +++--- tsdev.c|6 ++ 4 files changed, 12 insertions(+), 15 deletions(-) diff -Nru a/drivers/input/evdev.c b/drivers/input

Re: Linux input event extending tool exist?

2005-02-06 Thread Vojtech Pavlik
On Wed, Dec 15, 2004 at 11:41:38PM -0500, Eric Lammerts wrote: Vojtech Pavlik wrote: You can use evtest (attached). It's often found in the joystick RPMs. It's also in the linuxconsole.sf.net CVS repository. On recent kernels it'll show the scancodes as well as the generated keycodes

Re: [PATCH] hid-core: Configurable USB HID Mouse Interrupt Polling Interval

2005-02-06 Thread Vojtech Pavlik
/drviers/usb/input/hid-core.c @@ -37,11 +37,12 @@ * Version Information */ -#define DRIVER_VERSION v2.0 +#define DRIVER_VERSION v2.01 #define DRIVER_AUTHOR Andreas Gal, Vojtech Pavlik #define DRIVER_DESC USB HID core driver #define DRIVER_LICENSE GPL +static unsigned int

Re: [PATCH] remove pointless 0 comparisons for unsigned vars, and avoid a few signed vs unsigned comparisons in drivers/char/keyboard.c

2005-02-06 Thread Vojtech Pavlik
they really should just all be unsigned. Comments welcome (I must confess that I've only compile tested this so far). Signed-off-by: Jesper Juhl [EMAIL PROTECTED] Looks sane: Applied. -- Vojtech Pavlik SuSE Labs, SuSE CR - To unsubscribe from this list: send the line unsubscribe linux-kernel

Re: [2.6 patch] drivers/input/gameport/cs461x.c: remove bouncing email address

2005-02-06 Thread Vojtech Pavlik
; applied. -- Vojtech Pavlik SuSE Labs, SuSE CR - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] Linux joydev joystick disconnect patch 2.6.11-rc2

2005-02-06 Thread Vojtech Pavlik
On Sun, Feb 06, 2005 at 08:21:13PM -0500, Dmitry Torokhov wrote: On Sunday 06 February 2005 08:12, Vojtech Pavlik wrote: On Tue, Feb 01, 2005 at 10:24:39AM -0500, Dmitry Torokhov wrote: On Tue, 1 Feb 2005 08:52:15 -0600, David Fries [EMAIL PROTECTED] wrote: Currently a blocking read

Re: [RFC/RFT] Better handling of bad xfers/interrupt delays in psmouse

2005-02-05 Thread Vojtech Pavlik
gt; + goto out; > + } > } > > psmouse->last = jiffies; > diff -Nru a/drivers/input/mouse/psmouse.h b/drivers/input/mouse/psmouse.h > --- a/drivers/input/mouse/psmouse.h 2005-02-05 14:37:51 -05:00 > +++ b/drivers/input/mouse/psmouse.h 2005-

Re: [PATCH] adding the ICS MK712 touchscreen driver to 2.6

2005-02-05 Thread Vojtech Pavlik
: http://home.comcast.net/~n1gp/mk712_2.6_patch I converted it to a proper input driver for you. ;) Can you check it if it still works? [EMAIL PROTECTED], 2005-02-05 22:00:45+01:00, [EMAIL PROTECTED] input: New driver for ICS MicroClock MK712 TouchScreens. Signed-off-by: Vojtech Pav

Re: [PATCH] adding the ICS MK712 touchscreen driver to 2.6

2005-02-05 Thread Vojtech Pavlik
12 is ISA and hard-coded to a particular IRQ, so the > + driver should keep the IRQ as long as it is loaded. */ > + if(request_irq(mk712_irq, mk712_interrupt, 0, "mk712_touchscreen", > +queue)) > + { > + printk("mk712: unable to

Re: [PATCH 2.6.11-rc3] IBM Trackpoint support

2005-02-05 Thread Vojtech Pavlik
On Sat, Feb 05, 2005 at 01:56:07AM -0500, Dmitry Torokhov wrote: > On Friday 04 February 2005 09:45, Vojtech Pavlik wrote: > > On Fri, Feb 04, 2005 at 09:17:33AM -0500, Dmitry Torokhov wrote: > > > > > It is still a problem if driver is registered after the port has

Re: [PATCH 2.6.11-rc3] IBM Trackpoint support

2005-02-05 Thread Vojtech Pavlik
On Sat, Feb 05, 2005 at 01:56:07AM -0500, Dmitry Torokhov wrote: On Friday 04 February 2005 09:45, Vojtech Pavlik wrote: On Fri, Feb 04, 2005 at 09:17:33AM -0500, Dmitry Torokhov wrote: It is still a problem if driver is registered after the port has been detected wich quite often

Re: [PATCH] adding the ICS MK712 touchscreen driver to 2.6

2005-02-05 Thread Vojtech Pavlik
/*#define ADB_MOUSE_MINOR 10 FIXME OBSOLETE */ +#define MK712_MINOR 15 /* MK712 touch screen */ #define WATCHDOG_MINOR130 /* Watchdog timer */ #define TEMP_MINOR131 /* Temperature Sensor */ #define RTC_MINOR 135 -- Vojtech Pavlik

Re: [PATCH] adding the ICS MK712 touchscreen driver to 2.6

2005-02-05 Thread Vojtech Pavlik
check it if it still works? [EMAIL PROTECTED], 2005-02-05 22:00:45+01:00, [EMAIL PROTECTED] input: New driver for ICS MicroClock MK712 TouchScreens. Signed-off-by: Vojtech Pavlik [EMAIL PROTECTED] Kconfig | 11 +++ Makefile |3 mk712.c | 201

Re: [RFC/RFT] Better handling of bad xfers/interrupt delays in psmouse

2005-02-05 Thread Vojtech Pavlik
PSMOUSE_CMD_RESET_BAT0x02ff #define PSMOUSE_RET_BAT 0xaa @@ -48,6 +49,7 @@ unsigned long last; unsigned long out_of_sync; enum psmouse_state state; + unsigned int resend; char devname[64]; char phys[32]; -- Vojtech Pavlik

Re: [2.6 patch] input/gameport/cs461x.c: make 2 functions static

2005-02-04 Thread Vojtech Pavlik
On Sat, Feb 05, 2005 at 03:41:32AM +0100, Adrian Bunk wrote: > This patch makes two needlessly global functions static. > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Thanks, applied. -- Vojtech Pavlik SuSE Labs, SuSE CR - To unsubscribe from this list: send the line &qu

Re: [2.6 patch] input: make some code static

2005-02-04 Thread Vojtech Pavlik
is ready for Vojtech to pull from. Dmitry, I already pulled. :) Btw, please use my [EMAIL PROTECTED] (or @suse.de) e-mail addresses during the weekend, as mu @suse.cz doesn't work and likely won't be fixed until Monday. -- Vojtech Pavlik SuSE Labs, SuSE CR - To unsubscribe from this list: send t

Re: i386 HPET code

2005-02-04 Thread Vojtech Pavlik
te after writing TN_SETVAL to the config register sets the counter value, the second write sets the threshold. When you only do the first write you never set the threshold and interrupts won't be generated properly. -- Vojtech Pavlik SuSE Labs, SuSE CR - To unsubscribe from this list: sen

Re: i386 HPET code

2005-02-04 Thread Vojtech Pavlik
On Fri, Feb 04, 2005 at 09:02:38PM +0100, Vojtech Pavlik wrote: > On Thu, Feb 03, 2005 at 10:30:26PM +0100, Andi Kleen wrote: > > On Thu, Feb 03, 2005 at 06:28:27AM -0800, Pallipadi, Venkatesh wrote: > > > > > > Hi John, Andrew, > > > > > > > >

Re: Logitech MX1000 Horizontal Scrolling

2005-02-04 Thread Vojtech Pavlik
On Thu, Feb 03, 2005 at 03:42:16PM +0100, Esben Stien wrote: > Esben Stien <[EMAIL PROTECTED]> writes: > > > I got a 12 button logitech MX1000 mouse. > > I have still not resolved this issue. Anyone who can point me in any > direction? Please try if 2.6.11-rc3

Re: i386 HPET code

2005-02-04 Thread Vojtech Pavlik
es, then it looks like a hardware issue. > > > > > hpet_writel(hpet_tick, HPET_T0_CMP); > > >+ hpet_writel(hpet_tick, HPET_T0_CMP); /* AK: why twice? */ > > > Ask Vojtech (cced), he wrote the x86-64 HPET code. Can you add some background of the thread? --

Re: [PATCH] PNP support for i8042 driver

2005-02-04 Thread Vojtech Pavlik
On Fri, Feb 04, 2005 at 06:37:29PM +0100, matthieu castet wrote: > Hi, > > Vojtech Pavlik wrote: > >On Sat, Nov 13, 2004 at 02:23:53PM +0100, matthieu castet wrote: > > > >>Hi, > >>this patch add PNP support for the i8042 driver in 2.6.10-rc1-mm5. Acpi >

Re: Fw: Re: 2.6.11-rc2-mm2

2005-02-04 Thread Vojtech Pavlik
usb/input/hid-input.c: event field not found > > > > > > > I this it was fixed in Vojtech tree, probably with the following patch: > > > > http://marc.theaimsgroup.com/?l=linux-kernel=110702712719062=raw > > > > -- > > Dmitry > > >

Re: [PATCH 2.6.11-rc3] IBM Trackpoint support

2005-02-04 Thread Vojtech Pavlik
synchronous too. Probably yes. > I > don't forsee any issues providing that I bump up module's reference > count while driver structure is "in flight", do you? No, looks OK to me, too. -- Vojtech Pavlik SuSE Labs, SuSE CR - To unsubscribe from this list: send the line &quo

Re: [PATCH 6/8] Kconfig: cleanup input menu

2005-02-04 Thread Vojtech Pavlik
s had no dependencies. > Below is an alternative patch, which does a rather complete cleanup. Applied. -- Vojtech Pavlik SuSE Labs, SuSE CR - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH 6/8] Kconfig: cleanup input menu

2005-02-04 Thread Vojtech Pavlik
On Fri, Feb 04, 2005 at 08:51:41AM -0500, Dmitry Torokhov wrote: > On Fri, 4 Feb 2005 14:14:36 +0100, Vojtech Pavlik <[EMAIL PROTECTED]> wrote: > > On Sun, Jan 30, 2005 at 06:39:37PM -0500, Dmitry Torokhov wrote: > > > On Sunday 30 January 2005 10:45, Roman

Re: [PATCH 2.6.11-rc3] IBM Trackpoint support

2005-02-04 Thread Vojtech Pavlik
On Fri, Feb 04, 2005 at 08:17:43AM -0500, Stephen Evanchik wrote: > On Fri, 4 Feb 2005 07:35:20 +0100, Vojtech Pavlik <[EMAIL PROTECTED]> wrote: > > > > /* > > > > + * Try to initialize the IBM TrackPoint > > > > + */ > > > > + if

Re: Touchpad problems with 2.6.11-rc2

2005-02-04 Thread Vojtech Pavlik
On Fri, Feb 04, 2005 at 07:40:43AM +0100, Peter Osterlund wrote: > Vojtech Pavlik <[EMAIL PROTECTED]> writes: > > > On Thu, Feb 03, 2005 at 10:54:51PM +0100, Peter Osterlund wrote: > > > > > * Removes the xres/yres scaling so that you get the same speed in th

Re: Touchpad problems with 2.6.11-rc2

2005-02-04 Thread Vojtech Pavlik
d-off-by: Peter Osterlund <[EMAIL PROTECTED]> Thanks, applied. -- Vojtech Pavlik SuSE Labs, SuSE CR - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-inf

Re: [PATCH 4/4] Add support for Synaptics touchpad scroll wheels

2005-02-04 Thread Vojtech Pavlik
AIL PROTECTED]> > --- Thanks, applied. -- Vojtech Pavlik SuSE Labs, SuSE CR - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 3/4] Fix "pointer jumps to corner of screen" problem on ALPS Glidepoint touchpads.

2005-02-04 Thread Vojtech Pavlik
If > such a packet is parsed as a stick packet, the mouse pointer will > typically jump to one corner of the screen. > > Signed-off-by: Peter Osterlund <[EMAIL PROTECTED]> Doesn't apply without 2/4, sorry. Please resend it. -- Vojtech Pavlik SuSE Labs, SuSE CR - To unsu

Re: [PATCH 6/8] Kconfig: cleanup input menu

2005-02-04 Thread Vojtech Pavlik
s first one I select options I think are needed I could > skip over the HW I/O ports thinking that I already selected everything I > need as far as keyboard/mouse goes. > > Does this make any sense? Dmitry, will you make a patch that has the port options first? If no, I'll likely m

Re: [PATCH 1/4] Make mousedev.c report all events to user space immediately

2005-02-04 Thread Vojtech Pavlik
sing your patch 2/4 - it got lost somewhere. -- Vojtech Pavlik SuSE Labs, SuSE CR - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [2.6 patch] input: make some code static

2005-02-04 Thread Vojtech Pavlik
, I already pulled. :) Btw, please use my [EMAIL PROTECTED] (or @suse.de) e-mail addresses during the weekend, as mu @suse.cz doesn't work and likely won't be fixed until Monday. -- Vojtech Pavlik SuSE Labs, SuSE CR - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

Re: [2.6 patch] input/gameport/cs461x.c: make 2 functions static

2005-02-04 Thread Vojtech Pavlik
On Sat, Feb 05, 2005 at 03:41:32AM +0100, Adrian Bunk wrote: This patch makes two needlessly global functions static. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] Thanks, applied. -- Vojtech Pavlik SuSE Labs, SuSE CR - To unsubscribe from this list: send the line unsubscribe linux-kernel

Re: Fw: Re: 2.6.11-rc2-mm2

2005-02-04 Thread Vojtech Pavlik
but the keyboard LED lights are still non functional. Should be fixed in rc3. It was yet another bug. -- Vojtech Pavlik SuSE Labs, SuSE CR - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH 1/4] Make mousedev.c report all events to user space immediately

2005-02-04 Thread Vojtech Pavlik
. -- Vojtech Pavlik SuSE Labs, SuSE CR - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 6/8] Kconfig: cleanup input menu

2005-02-04 Thread Vojtech Pavlik
I need as far as keyboard/mouse goes. Does this make any sense? Dmitry, will you make a patch that has the port options first? If no, I'll likely merge Roman's patch. -- Vojtech Pavlik SuSE Labs, SuSE CR - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

Re: [PATCH 3/4] Fix pointer jumps to corner of screen problem on ALPS Glidepoint touchpads.

2005-02-04 Thread Vojtech Pavlik
is parsed as a stick packet, the mouse pointer will typically jump to one corner of the screen. Signed-off-by: Peter Osterlund [EMAIL PROTECTED] Doesn't apply without 2/4, sorry. Please resend it. -- Vojtech Pavlik SuSE Labs, SuSE CR - To unsubscribe from this list: send the line unsubscribe linux

Re: Touchpad problems with 2.6.11-rc2

2005-02-04 Thread Vojtech Pavlik
] Thanks, applied. -- Vojtech Pavlik SuSE Labs, SuSE CR - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 4/4] Add support for Synaptics touchpad scroll wheels

2005-02-04 Thread Vojtech Pavlik
. -- Vojtech Pavlik SuSE Labs, SuSE CR - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: Touchpad problems with 2.6.11-rc2

2005-02-04 Thread Vojtech Pavlik
On Fri, Feb 04, 2005 at 07:40:43AM +0100, Peter Osterlund wrote: Vojtech Pavlik [EMAIL PROTECTED] writes: On Thu, Feb 03, 2005 at 10:54:51PM +0100, Peter Osterlund wrote: * Removes the xres/yres scaling so that you get the same speed in the X and Y directions even if your screen

Re: [PATCH 2.6.11-rc3] IBM Trackpoint support

2005-02-04 Thread Vojtech Pavlik
On Fri, Feb 04, 2005 at 08:17:43AM -0500, Stephen Evanchik wrote: On Fri, 4 Feb 2005 07:35:20 +0100, Vojtech Pavlik [EMAIL PROTECTED] wrote: /* + * Try to initialize the IBM TrackPoint + */ + if (max_proto PSMOUSE_PS2 trackpoint_init(psmouse) == 0) { + psmouse

Re: [PATCH 6/8] Kconfig: cleanup input menu

2005-02-04 Thread Vojtech Pavlik
On Fri, Feb 04, 2005 at 08:51:41AM -0500, Dmitry Torokhov wrote: On Fri, 4 Feb 2005 14:14:36 +0100, Vojtech Pavlik [EMAIL PROTECTED] wrote: On Sun, Jan 30, 2005 at 06:39:37PM -0500, Dmitry Torokhov wrote: On Sunday 30 January 2005 10:45, Roman Zippel wrote: Hi, On Sat, 29 Jan

Re: [PATCH 6/8] Kconfig: cleanup input menu

2005-02-04 Thread Vojtech Pavlik
is an alternative patch, which does a rather complete cleanup. Applied. -- Vojtech Pavlik SuSE Labs, SuSE CR - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read

Re: [PATCH 2.6.11-rc3] IBM Trackpoint support

2005-02-04 Thread Vojtech Pavlik
yes. I don't forsee any issues providing that I bump up module's reference count while driver structure is in flight, do you? No, looks OK to me, too. -- Vojtech Pavlik SuSE Labs, SuSE CR - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message

Re: [PATCH] PNP support for i8042 driver

2005-02-04 Thread Vojtech Pavlik
On Fri, Feb 04, 2005 at 06:37:29PM +0100, matthieu castet wrote: Hi, Vojtech Pavlik wrote: On Sat, Nov 13, 2004 at 02:23:53PM +0100, matthieu castet wrote: Hi, this patch add PNP support for the i8042 driver in 2.6.10-rc1-mm5. Acpi is try before the pnp driver so if you don't disable

Re: i386 HPET code

2005-02-04 Thread Vojtech Pavlik
. hpet_writel(hpet_tick, HPET_T0_CMP); + hpet_writel(hpet_tick, HPET_T0_CMP); /* AK: why twice? */ Ask Vojtech (cced), he wrote the x86-64 HPET code. Can you add some background of the thread? -- Vojtech Pavlik SuSE Labs, SuSE CR - To unsubscribe from this list: send the line unsubscribe linux

Re: Logitech MX1000 Horizontal Scrolling

2005-02-04 Thread Vojtech Pavlik
On Thu, Feb 03, 2005 at 03:42:16PM +0100, Esben Stien wrote: Esben Stien [EMAIL PROTECTED] writes: I got a 12 button logitech MX1000 mouse. I have still not resolved this issue. Anyone who can point me in any direction? Please try if 2.6.11-rc3 is any better. -- Vojtech Pavlik SuSE

Re: i386 HPET code

2005-02-04 Thread Vojtech Pavlik
On Fri, Feb 04, 2005 at 09:02:38PM +0100, Vojtech Pavlik wrote: On Thu, Feb 03, 2005 at 10:30:26PM +0100, Andi Kleen wrote: On Thu, Feb 03, 2005 at 06:28:27AM -0800, Pallipadi, Venkatesh wrote: Hi John, Andrew, Can you check whether only the following change makes the problem

Re: i386 HPET code

2005-02-04 Thread Vojtech Pavlik
the threshold. When you only do the first write you never set the threshold and interrupts won't be generated properly. -- Vojtech Pavlik SuSE Labs, SuSE CR - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info

Re: Touchpad problems with 2.6.11-rc2

2005-02-03 Thread Vojtech Pavlik
On Fri, Feb 04, 2005 at 07:40:43AM +0100, Peter Osterlund wrote: > Vojtech Pavlik <[EMAIL PROTECTED]> writes: > > > On Thu, Feb 03, 2005 at 10:54:51PM +0100, Peter Osterlund wrote: > > > > > * Removes the xres/yres scaling so that you get the same speed in th

Re: [PATCH 2.6.11-rc3] IBM Trackpoint support

2005-02-03 Thread Vojtech Pavlik
On Fri, Feb 04, 2005 at 01:52:39AM -0500, Dmitry Torokhov wrote: > On Friday 04 February 2005 01:35, Vojtech Pavlik wrote: > > On Thu, Feb 03, 2005 at 07:34:16PM -0500, Dmitry Torokhov wrote: > > > On Thursday 03 February 2005 17:43, Stephen Evanchik wrote: > > > >

Re: [PATCH 2.6.11-rc3] IBM Trackpoint support

2005-02-03 Thread Vojtech Pavlik
hitespace damage (tabs vs spaces) plus it should be "} else {" > on one line. What a shame that this thing doesn't have a raw mode where it'd report the pressure ... > > +int trackpoint_reconnect(struct psmouse *psmouse) > > +{ > > + unsigned char toggle; >

Re: Touchpad problems with 2.6.11-rc2

2005-02-03 Thread Vojtech Pavlik
On Thu, Feb 03, 2005 at 10:54:51PM +0100, Peter Osterlund wrote: > Vojtech Pavlik <[EMAIL PROTECTED]> writes: > > > On Wed, Feb 02, 2005 at 11:58:05PM +0100, Peter Osterlund wrote: > > > > > In practice I don't think it will make any significant difference. What

Re: Touchpad problems with 2.6.11-rc2

2005-02-03 Thread Vojtech Pavlik
case difference (DualPoint vs Dualpoint)? > > > > I am not sure but on this page ALPS states that they have trademark on > DualPoint (TM): > > http://www3.alps.co.jp/cgi-bin/WebObjects/catalog.woa/wa/varietyList?language=english=com_mode=2003=11=3 Maybe that's why IBM calls the

Re: Touchpad problems with 2.6.11-rc2

2005-02-03 Thread Vojtech Pavlik
On Thu, Feb 03, 2005 at 06:30:14AM -0200, Alexandre Oliva wrote: > On Feb 2, 2005, Pete Zaitcev <[EMAIL PROTECTED]> wrote: > > > On Wed, 2 Feb 2005 18:07:27 +0100, Vojtech Pavlik <[EMAIL PROTECTED]> wrote: > > >> With a Synaptics I suppose? You wouldn't l

Re: Touchpad problems with 2.6.11-rc2

2005-02-03 Thread Vojtech Pavlik
On Thu, Feb 03, 2005 at 06:30:14AM -0200, Alexandre Oliva wrote: On Feb 2, 2005, Pete Zaitcev [EMAIL PROTECTED] wrote: On Wed, 2 Feb 2005 18:07:27 +0100, Vojtech Pavlik [EMAIL PROTECTED] wrote: With a Synaptics I suppose? You wouldn't like it with an ALPS. No, it's a Dualpoint

Re: Touchpad problems with 2.6.11-rc2

2005-02-03 Thread Vojtech Pavlik
on DualPoint (TM): http://www3.alps.co.jp/cgi-bin/WebObjects/catalog.woa/wa/varietyList?language=englishcountry=comtop_mode=2003productId=11varietyId=3 Maybe that's why IBM calls their Synaptics touchpad + IBM touchpoint solution IBM UltrNav(tm)? ;) -- Vojtech Pavlik SuSE Labs, SuSE CR

Re: Touchpad problems with 2.6.11-rc2

2005-02-03 Thread Vojtech Pavlik
On Thu, Feb 03, 2005 at 10:54:51PM +0100, Peter Osterlund wrote: Vojtech Pavlik [EMAIL PROTECTED] writes: On Wed, Feb 02, 2005 at 11:58:05PM +0100, Peter Osterlund wrote: In practice I don't think it will make any significant difference. What the code should do depends on what you

Re: [PATCH 2.6.11-rc3] IBM Trackpoint support

2005-02-03 Thread Vojtech Pavlik
*/ + I'd like to verify that it still recognized as trackpoint - suspends often play tricks on PS/2 devices. + + printk(IBM TrackPoint firmware: 0x%02X\n, param[1]); KERN_INFO? -- Vojtech Pavlik SuSE Labs, SuSE CR - To unsubscribe from this list: send the line unsubscribe linux-kernel

Re: [PATCH 2.6.11-rc3] IBM Trackpoint support

2005-02-03 Thread Vojtech Pavlik
On Fri, Feb 04, 2005 at 01:52:39AM -0500, Dmitry Torokhov wrote: On Friday 04 February 2005 01:35, Vojtech Pavlik wrote: On Thu, Feb 03, 2005 at 07:34:16PM -0500, Dmitry Torokhov wrote: On Thursday 03 February 2005 17:43, Stephen Evanchik wrote: Vojtech, Here is a patch

Re: Touchpad problems with 2.6.11-rc2

2005-02-03 Thread Vojtech Pavlik
On Fri, Feb 04, 2005 at 07:40:43AM +0100, Peter Osterlund wrote: Vojtech Pavlik [EMAIL PROTECTED] writes: On Thu, Feb 03, 2005 at 10:54:51PM +0100, Peter Osterlund wrote: * Removes the xres/yres scaling so that you get the same speed in the X and Y directions even if your screen

Re: Touchpad problems with 2.6.11-rc2

2005-02-02 Thread Vojtech Pavlik
ode though, > using gcc 3.4.2 from Fedora Core 3. > > > + enum { FRACTION_DENOM = 100 }; > > The enum is much nicer than my #define. OK. I like this patch, too. Can you guys send me a final version incorporating the changes of you both for inclusion in the input tree? -- Vojte

[PATCH 3/4] Ignore non-LED events in hid-input hidinput_event().

2005-02-02 Thread Vojtech Pavlik
of the "event field not found" message caused by EV_MSC type events. Signed-off-by: Vojtech Pavlik <[EMAIL PROTECTED]> hid-input.c |3 +++ 1 files changed, 3 insertions(+) === diff -Nru a/drivers/usb/i

[PATCH 4/4] Fix HID LED mapping.

2005-02-02 Thread Vojtech Pavlik
contains the page code in high 16 bits. Signed-off-by: Vojtech Pavlik <[EMAIL PROTECTED]> hid-debug.h |2 +- hid-input.c |4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) === diff -Nru a/drivers/usb/inp

[PATCH 2/4] Document the atkbd.softraw module parameter.

2005-02-02 Thread Vojtech Pavlik
<[EMAIL PROTECTED]> Signed-off-by: Vojtech Pavlik <[EMAIL PROTECTED]> kernel-parameters.txt | 10 +++--- 1 files changed, 7 insertions(+), 3 deletions(-) === diff -Nru a/Documentation/kernel-parameters.txt b/D

<    1   2   3   4   5   6   7   8   9   10   >