Re: Hook up a PCIe device into the thermal framework

2021-01-15 Thread Waldemar Rymarkiewicz
Hi, > > topology that DT modification will not work and still I have no device > > node. > > I'm absolutely not a DT expert, but I assume that a thermal zone would > be associated with some resource fixed by the platform, such as a fan, > so I would think a thermal zone would have to be described

Hook up a PCIe device into the thermal framework

2021-01-14 Thread Waldemar Rymarkiewicz
Hi, I've been looking for a nice way to hook up a PCIe device into the thermal framework recently and I want to confront my findings with the right people here. I have a PCIe wireless adapter connected to PCI-to-PCI bridge which in turns is connected to a PCI root complex (RC). I want to define

Re: [PATCH] cpufreq: conservative: Take limits changes into account properly

2018-10-16 Thread Waldemar Rymarkiewicz
along with the local copy of it when the previous > requested frequency is beyond the policy limits and avoid decreasing > the requested frequency below the min policy limit when taking > idle periods into account. > > Reported-by: Waldemar Rymarkiewicz > Signed-off-by: Rafael J. Wysocki

Re: [PATCH] cpufreq: conservative: Take limits changes into account properly

2018-10-16 Thread Waldemar Rymarkiewicz
along with the local copy of it when the previous > requested frequency is beyond the policy limits and avoid decreasing > the requested frequency below the min policy limit when taking > idle periods into account. > > Reported-by: Waldemar Rymarkiewicz > Signed-off-by: Rafael J. Wysocki

Re: [PATCH] cpufreq: conservative: Fix requested_freq handling

2018-10-15 Thread Waldemar Rymarkiewicz
On Mon, 15 Oct 2018 at 13:34, Rafael J. Wysocki wrote: > > On Monday, October 15, 2018 11:34:33 AM CEST Waldemar Rymarkiewicz wrote: > > On Thu, 11 Oct 2018 at 23:10, Rafael J. Wysocki wrote: > > > > > > On Tuesday, October 9, 2018 6:06:08 PM CEST Waldemar Rymarki

Re: [PATCH] cpufreq: conservative: Fix requested_freq handling

2018-10-15 Thread Waldemar Rymarkiewicz
On Mon, 15 Oct 2018 at 13:34, Rafael J. Wysocki wrote: > > On Monday, October 15, 2018 11:34:33 AM CEST Waldemar Rymarkiewicz wrote: > > On Thu, 11 Oct 2018 at 23:10, Rafael J. Wysocki wrote: > > > > > > On Tuesday, October 9, 2018 6:06:08 PM CEST Waldemar Rymarki

Re: [PATCH] cpufreq: conservative: Fix requested_freq handling

2018-10-15 Thread Waldemar Rymarkiewicz
On Thu, 11 Oct 2018 at 23:10, Rafael J. Wysocki wrote: > > On Tuesday, October 9, 2018 6:06:08 PM CEST Waldemar Rymarkiewicz wrote: > > On Tue, 9 Oct 2018 at 09:47, Rafael J. Wysocki wrote: > > > > > > On Mon, Oct 8, 2018 at 5:11 PM Waldemar Rymarkiewicz >

Re: [PATCH] cpufreq: conservative: Fix requested_freq handling

2018-10-15 Thread Waldemar Rymarkiewicz
On Thu, 11 Oct 2018 at 23:10, Rafael J. Wysocki wrote: > > On Tuesday, October 9, 2018 6:06:08 PM CEST Waldemar Rymarkiewicz wrote: > > On Tue, 9 Oct 2018 at 09:47, Rafael J. Wysocki wrote: > > > > > > On Mon, Oct 8, 2018 at 5:11 PM Waldemar Rymarkiewicz >

Re: [PATCH] cpufreq: conservative: Fix requested_freq handling

2018-10-09 Thread Waldemar Rymarkiewicz
On Tue, 9 Oct 2018 at 09:47, Rafael J. Wysocki wrote: > > On Mon, Oct 8, 2018 at 5:11 PM Waldemar Rymarkiewicz > wrote: > > > > From: Waldemar Rymarkiewicz > > > > The governor updates dbs_info->requested_freq only after increasing or > > decreasing

Re: [PATCH] cpufreq: conservative: Fix requested_freq handling

2018-10-09 Thread Waldemar Rymarkiewicz
On Tue, 9 Oct 2018 at 09:47, Rafael J. Wysocki wrote: > > On Mon, Oct 8, 2018 at 5:11 PM Waldemar Rymarkiewicz > wrote: > > > > From: Waldemar Rymarkiewicz > > > > The governor updates dbs_info->requested_freq only after increasing or > > decreasing

[PATCH] cpufreq: conservative: Fix requested_freq handling

2018-10-08 Thread Waldemar Rymarkiewicz
From: Waldemar Rymarkiewicz The governor updates dbs_info->requested_freq only after increasing or decreasing frequency. There is, however, an use case when this is not sufficient. Imagine, external module constraining cpufreq policy in a way that policy->max = policy->min = max_avail

[PATCH] cpufreq: conservative: Fix requested_freq handling

2018-10-08 Thread Waldemar Rymarkiewicz
From: Waldemar Rymarkiewicz The governor updates dbs_info->requested_freq only after increasing or decreasing frequency. There is, however, an use case when this is not sufficient. Imagine, external module constraining cpufreq policy in a way that policy->max = policy->min = max_avail

[PATCH] PM / OPP: Update voltage in case freq == old_freq

2018-06-14 Thread Waldemar Rymarkiewicz
d_freq is modified!) old_freq= 1GHz Signed-off-by: Waldemar Rymarkiewicz --- drivers/opp/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/opp/core.c b/drivers/opp/core.c index ab2f3fe..31ff03d 100644 --- a/drivers/opp/core.c +++ b/drivers/opp/core.

[PATCH] PM / OPP: Update voltage in case freq == old_freq

2018-06-14 Thread Waldemar Rymarkiewicz
d_freq is modified!) old_freq= 1GHz Signed-off-by: Waldemar Rymarkiewicz --- drivers/opp/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/opp/core.c b/drivers/opp/core.c index ab2f3fe..31ff03d 100644 --- a/drivers/opp/core.c +++ b/drivers/opp/core.

Re: How to power gate a specific single device from outside?

2017-10-25 Thread Waldemar Rymarkiewicz
On 25 October 2017 at 01:56, Alan Cox wrote: > > For a lot of devices if you close it then it will try and put the device > into a low power state. If a driver isn't doing that then (unless there > are hardware constraints preventing it) it would make sense to fix it.

Re: How to power gate a specific single device from outside?

2017-10-25 Thread Waldemar Rymarkiewicz
On 25 October 2017 at 01:56, Alan Cox wrote: > > For a lot of devices if you close it then it will try and put the device > into a low power state. If a driver isn't doing that then (unless there > are hardware constraints preventing it) it would make sense to fix it. > > There are some things

How to power gate a specific single device from outside?

2017-10-24 Thread Waldemar Rymarkiewicz
Hi I am looking for a convenient way to power gate specific single device when the platform is running in backup mode - the platform lost main power supply and it's on backup buttery now. The intention is to save max power in backup mode and switch off all unnecessary blocks. I could not find

How to power gate a specific single device from outside?

2017-10-24 Thread Waldemar Rymarkiewicz
Hi I am looking for a convenient way to power gate specific single device when the platform is running in backup mode - the platform lost main power supply and it's on backup buttery now. The intention is to save max power in backup mode and switch off all unnecessary blocks. I could not find

Re: Where to update regulator register with initial voltage set by HW

2017-07-04 Thread Waldemar Rymarkiewicz
Hi Mark, On 3 July 2017 at 17:36, Mark Brown <broo...@kernel.org> wrote: > On Mon, Jul 03, 2017 at 05:33:03PM +0200, Waldemar Rymarkiewicz wrote: > >> I've asked also on TI forum if this is typical to the regulator not to >> determine the startup voltage but still wait

Re: Where to update regulator register with initial voltage set by HW

2017-07-04 Thread Waldemar Rymarkiewicz
Hi Mark, On 3 July 2017 at 17:36, Mark Brown wrote: > On Mon, Jul 03, 2017 at 05:33:03PM +0200, Waldemar Rymarkiewicz wrote: > >> I've asked also on TI forum if this is typical to the regulator not to >> determine the startup voltage but still waiting for feedback. Anyway, >

Re: Where to update regulator register with initial voltage set by HW

2017-07-03 Thread Waldemar Rymarkiewicz
On 3 July 2017 at 17:11, Mark Brown wrote: > On Fri, Jun 30, 2017 at 12:26:52PM +, Bartholomae, Thomas wrote: >> Hi Mark, > >> The problem is that our used regulator TPS65273V from TI do not have >> the possibility to read the current voltage defined by the HW, means >> by

Re: Where to update regulator register with initial voltage set by HW

2017-07-03 Thread Waldemar Rymarkiewicz
On 3 July 2017 at 17:11, Mark Brown wrote: > On Fri, Jun 30, 2017 at 12:26:52PM +, Bartholomae, Thomas wrote: >> Hi Mark, > >> The problem is that our used regulator TPS65273V from TI do not have >> the possibility to read the current voltage defined by the HW, means >> by the circuit of the

Re: Where to update regulator register with initial voltage set by HW

2017-06-30 Thread Waldemar Rymarkiewicz
On 30 June 2017 at 14:14, Mark Brown <broo...@kernel.org> wrote: > On Fri, Jun 30, 2017 at 01:37:32PM +0200, Waldemar Rymarkiewicz wrote: > >> I am not sure if I understand. Do you mean, a regulator should >> determine a voltage and update a register with a right selector

Re: Where to update regulator register with initial voltage set by HW

2017-06-30 Thread Waldemar Rymarkiewicz
On 30 June 2017 at 14:14, Mark Brown wrote: > On Fri, Jun 30, 2017 at 01:37:32PM +0200, Waldemar Rymarkiewicz wrote: > >> I am not sure if I understand. Do you mean, a regulator should >> determine a voltage and update a register with a right selector when >> system

Re: Where to update regulator register with initial voltage set by HW

2017-06-30 Thread Waldemar Rymarkiewicz
On 30 June 2017 at 12:41, Mark Brown <broo...@kernel.org> wrote: > On Thu, Jun 29, 2017 at 09:18:09AM +0200, Waldemar Rymarkiewicz wrote: > >> Initially, on boot, the voltage is set by HW (sensing resistors). When >> OS starts and the reg driver registers regulator with the

Re: Where to update regulator register with initial voltage set by HW

2017-06-30 Thread Waldemar Rymarkiewicz
On 30 June 2017 at 12:41, Mark Brown wrote: > On Thu, Jun 29, 2017 at 09:18:09AM +0200, Waldemar Rymarkiewicz wrote: > >> Initially, on boot, the voltage is set by HW (sensing resistors). When >> OS starts and the reg driver registers regulator with the specific >> const

Where to update regulator register with initial voltage set by HW

2017-06-29 Thread Waldemar Rymarkiewicz
Hi, I do a power regulator driver and I have faced an issue with an initial voltage value set (or rather not set) in regulator register. Initially, on boot, the voltage is set by HW (sensing resistors). When OS starts and the reg driver registers regulator with the specific constraints uV_min

Where to update regulator register with initial voltage set by HW

2017-06-29 Thread Waldemar Rymarkiewicz
Hi, I do a power regulator driver and I have faced an issue with an initial voltage value set (or rather not set) in regulator register. Initially, on boot, the voltage is set by HW (sensing resistors). When OS starts and the reg driver registers regulator with the specific constraints uV_min

Re: [PATCH] thermal: Fix improper clock_cooling header guard

2017-06-28 Thread Waldemar Rymarkiewicz
On 8 June 2017 at 17:47, Waldemar Rymarkiewicz <waldemar.rymarkiew...@gmail.com> wrote: > Most likely copy-paste mistake, so replace __CPU_COOLING_H__ header guard > with more suitable __CLOCK_COOLING_H__. > > Signed-off-by: Waldemar Rymarkiewicz <waldemar.rymarkiew...@gmail.

Re: [PATCH] thermal: Fix improper clock_cooling header guard

2017-06-28 Thread Waldemar Rymarkiewicz
On 8 June 2017 at 17:47, Waldemar Rymarkiewicz wrote: > Most likely copy-paste mistake, so replace __CPU_COOLING_H__ header guard > with more suitable __CLOCK_COOLING_H__. > > Signed-off-by: Waldemar Rymarkiewicz > --- > include/linux/clock_cooling.h | 6 +++--- > 1 file

[PATCH] thermal: Fix improper clock_cooling header guard

2017-06-08 Thread Waldemar Rymarkiewicz
Most likely copy-paste mistake, so replace __CPU_COOLING_H__ header guard with more suitable __CLOCK_COOLING_H__. Signed-off-by: Waldemar Rymarkiewicz <waldemar.rymarkiew...@gmail.com> --- include/linux/clock_cooling.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff

[PATCH] thermal: Fix improper clock_cooling header guard

2017-06-08 Thread Waldemar Rymarkiewicz
Most likely copy-paste mistake, so replace __CPU_COOLING_H__ header guard with more suitable __CLOCK_COOLING_H__. Signed-off-by: Waldemar Rymarkiewicz --- include/linux/clock_cooling.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/linux/clock_cooling.h b

Re: Network cooling device and how to control NIC speed on thermal condition

2017-05-15 Thread Waldemar Rymarkiewicz
On 8 May 2017 at 16:02, Andrew Lunn wrote: > Yes, this is true. I got an off-list email suggesting this power > difference is very significant, more so than actually processing > packets. this is a reason I've started to discuss this topic. PHYS consume a lot of power so from

Re: Network cooling device and how to control NIC speed on thermal condition

2017-05-15 Thread Waldemar Rymarkiewicz
On 8 May 2017 at 16:02, Andrew Lunn wrote: > Yes, this is true. I got an off-list email suggesting this power > difference is very significant, more so than actually processing > packets. this is a reason I've started to discuss this topic. PHYS consume a lot of power so from thermal perspective

Re: Network cooling device and how to control NIC speed on thermal condition

2017-05-08 Thread Waldemar Rymarkiewicz
On 28 April 2017 at 13:56, Andrew Lunn wrote: > Is that a realistic test? No traffic over the network? If you are > hitting your thermal limit, to me that means one of two things: > > 1) The device is under very heavy load, consuming a lot of power to do >what it needs to to.

Re: Network cooling device and how to control NIC speed on thermal condition

2017-05-08 Thread Waldemar Rymarkiewicz
On 28 April 2017 at 13:56, Andrew Lunn wrote: > Is that a realistic test? No traffic over the network? If you are > hitting your thermal limit, to me that means one of two things: > > 1) The device is under very heavy load, consuming a lot of power to do >what it needs to to. > > 2) Your

Re: Network cooling device and how to control NIC speed on thermal condition

2017-04-28 Thread Waldemar Rymarkiewicz
On 25 April 2017 at 15:45, Alan Cox wrote: >> I am looking on Linux thermal framework and on how to cool down the >> system effectively when it hits thermal condition. Already existing >> cooling methods cpu_cooling and clock_cooling are good. However, I >> wanted to

Re: Network cooling device and how to control NIC speed on thermal condition

2017-04-28 Thread Waldemar Rymarkiewicz
On 25 April 2017 at 15:45, Alan Cox wrote: >> I am looking on Linux thermal framework and on how to cool down the >> system effectively when it hits thermal condition. Already existing >> cooling methods cpu_cooling and clock_cooling are good. However, I >> wanted to go further and dynamically

Network cooling device and how to control NIC speed on thermal condition

2017-04-25 Thread Waldemar Rymarkiewicz
Hi, I am not much aware of linux networking architecture so I'd like to ask first before will start to dig into the code. Appreciate any feedback. I am looking on Linux thermal framework and on how to cool down the system effectively when it hits thermal condition. Already existing cooling

Network cooling device and how to control NIC speed on thermal condition

2017-04-25 Thread Waldemar Rymarkiewicz
Hi, I am not much aware of linux networking architecture so I'd like to ask first before will start to dig into the code. Appreciate any feedback. I am looking on Linux thermal framework and on how to cool down the system effectively when it hits thermal condition. Already existing cooling