Re: [PATCH] f2fs: enable inline data by default

2015-03-19 Thread Wang Shilong
BLE_EXT_IDENTIFY)) > seq_puts(seq, ",disable_ext_identify"); > - if (test_opt(sbi, INLINE_DATA)) > - seq_puts(seq, ",inline_data”); Wow, do you remove inline_data mount options? I don’t think this is a good idea..since mount option have been there…

Re: [PATCH] Btrfs: Fix memory corruption by ulist_add_merge() on 32bit arch

2014-07-28 Thread Wang Shilong
Hi Takashi, This seems like a promising fix, i just have a little question: ulist_add() logic is we firstly cast a pointer to u64(see ptr_to_u64()), and then cast u64 to pointer back(u64_to_ptr()). So normally, arg u64 is actually a pointer. If the below overflow happens, that means casting

Re: [PATCH] Btrfs: cleanup redundant code in __btrfs_close_devices()

2013-09-10 Thread Wang Shilong
> On Mon, Sep 9, 2013 at 7:28 AM, Wang Shilong > wrote: >> On 09/08/2013 12:15 AM, Azat Khuzhin wrote: >>> >>> Signed-off-by: Azat Khuzhin >>> --- >>> fs/btrfs/volumes.c |2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >

Re: [PATCH -next] ALSA: hda - fix error return code in patch_alc662()

2013-04-17 Thread Wang Shilong
Sorry, i miss something.. Thanks, wang > Hello Wei, > > +++ b/sound/pci/hda/patch_realtek.c > @@ -3787,7 +3787,8 @@ static int patch_alc662(struct hda_codec *codec) > if ((alc_get_coef0(codec) & (1 << 14)) && > codec->bus->pci->subsystem_vendor == 0x1025 && > spec->cdef

Re:[PATCH -next] ALSA: hda - fix error return code in patch_alc662()

2013-04-17 Thread Wang Shilong
Hello Wei, +++ b/sound/pci/hda/patch_realtek.c @@ -3787,7 +3787,8 @@ static int patch_alc662(struct hda_codec *codec) if ((alc_get_coef0(codec) & (1 << 14)) && codec->bus->pci->subsystem_vendor == 0x1025 && spec->cdefine.platform_type == 1) { - if (alc