Re: [PATCH][AGPGART] intel_agp: don't load if no IGD and AGP port

2007-06-24 Thread Wang Zhenyu
On 2007.06.23 11:50:49 +, Andrew Morton wrote: > On Sat, 23 Jun 2007 14:42:21 -0400 Dave Jones <[EMAIL PROTECTED]> wrote: > > > > I probably _could_ work this out, and kinda did with a bit of > > list-trolling > > > (verdict: needed in 2.6.22) but please, take care to describe the > > >

Re: [PATCH][AGPGART] intel_agp: don't load if no IGD and AGP port

2007-06-24 Thread Wang Zhenyu
On 2007.06.23 11:50:49 +, Andrew Morton wrote: On Sat, 23 Jun 2007 14:42:21 -0400 Dave Jones [EMAIL PROTECTED] wrote: I probably _could_ work this out, and kinda did with a bit of list-trolling (verdict: needed in 2.6.22) but please, take care to describe the importance of a

Re: [PATCH][AGPGART] intel_agp: don't load if no IGD and AGP port

2007-06-21 Thread Wang Zhenyu
On 2007.06.21 18:10:50 +, Carlo Wood wrote: > > I am glad to see that you found a real reason for why it might have > gone wrong. Just not initializing because it's not needed, but not > understanding WHY it went wrong would have been rather unsatisfactory. > yes, I understand, but it looks

Re: [PATCH][AGPGART] intel_agp: don't load if no IGD and AGP port

2007-06-21 Thread Wang Zhenyu
On 2007.06.21 18:10:50 +, Carlo Wood wrote: I am glad to see that you found a real reason for why it might have gone wrong. Just not initializing because it's not needed, but not understanding WHY it went wrong would have been rather unsatisfactory. yes, I understand, but it looks we

[PATCH][AGPGART] intel_agp: don't load if no IGD and AGP port

2007-06-20 Thread Wang Zhenyu
. This may cause problem. So mark them as NULL in the table, we won't load if no IGD got detect and bridge has no AGP port. Signed-off-by: Wang Zhenyu <[EMAIL PROTECTED]> --- drivers/char/agp/intel-agp.c | 35 +++ 1 files changed, 19 insertions(+), 16 del

Re: 2.6.22-rc5 regression

2007-06-20 Thread Wang Zhenyu
On 2007.06.20 16:02:37 +, Carlo Wood wrote: > > and I am not sure if you will consider the: > > agpgart: Failed to find bridge device (chip_id: 29a2) > > a bug. yeah, the error message needs to be fixed only if AGP cap exists. I was checking with other GMCH data sheets, we'd better

Re: 2.6.22-rc5 regression

2007-06-20 Thread Wang Zhenyu
On 2007.06.20 16:02:37 +, Carlo Wood wrote: and I am not sure if you will consider the: agpgart: Failed to find bridge device (chip_id: 29a2) a bug. yeah, the error message needs to be fixed only if AGP cap exists. I was checking with other GMCH data sheets, we'd better disable AGP

[PATCH][AGPGART] intel_agp: don't load if no IGD and AGP port

2007-06-20 Thread Wang Zhenyu
. This may cause problem. So mark them as NULL in the table, we won't load if no IGD got detect and bridge has no AGP port. Signed-off-by: Wang Zhenyu [EMAIL PROTECTED] --- drivers/char/agp/intel-agp.c | 35 +++ 1 files changed, 19 insertions(+), 16 deletions

Re: 2.6.22-rc5 regression

2007-06-19 Thread Wang Zhenyu
On 2007.06.20 09:15:21 +, Wang Zhenyu wrote: > > I think for i965 we could have following patch to fix this, we may > fail if no IGD device got detected. > oops, missing 946G, what a name... Signed-off-by: Wang Zhenyu <[EMAIL PROTECTED]> --- diff --git a/drivers/char

Re: 2.6.22-rc5 regression

2007-06-19 Thread Wang Zhenyu
imilar issue also happen like https://bugzilla.novell.com/show_bug.cgi?id=228683 I think for i965 we could have following patch to fix this, we may fail if no IGD device got detected. Signed-off-by: Wang Zhenyu <[EMAIL PROTECTED]> --- diff --git a/drivers/char/agp/intel-agp.c b/drivers/ch

Re: 2.6.22-rc5 regression

2007-06-19 Thread Wang Zhenyu
://bugzilla.novell.com/show_bug.cgi?id=228683 I think for i965 we could have following patch to fix this, we may fail if no IGD device got detected. Signed-off-by: Wang Zhenyu [EMAIL PROTECTED] --- diff --git a/drivers/char/agp/intel-agp.c b/drivers/char/agp/intel-agp.c index 0439ee9..5a54a9c 100644

Re: 2.6.22-rc5 regression

2007-06-19 Thread Wang Zhenyu
On 2007.06.20 09:15:21 +, Wang Zhenyu wrote: I think for i965 we could have following patch to fix this, we may fail if no IGD device got detected. oops, missing 946G, what a name... Signed-off-by: Wang Zhenyu [EMAIL PROTECTED] --- diff --git a/drivers/char/agp/intel-agp.c b/drivers

Re: [AGPGART] intel_agp: use table for device probe

2007-06-17 Thread Wang Zhenyu
On 2007.06.18 03:56:36 +, Carlo Wood wrote: > On Mon, Jun 18, 2007 at 10:57:38AM +1000, Dave Airlie wrote: > > >Right now, I'm at a loss to explain the corruption, so it's > > >difficult to suggest what to try. > > > > The thing is here, this is PCIE, so if there is a GPU plugged into the > >

Re: [AGPGART] intel_agp: use table for device probe

2007-06-17 Thread Wang Zhenyu
On 2007.06.18 03:56:36 +, Carlo Wood wrote: On Mon, Jun 18, 2007 at 10:57:38AM +1000, Dave Airlie wrote: Right now, I'm at a loss to explain the corruption, so it's difficult to suggest what to try. The thing is here, this is PCIE, so if there is a GPU plugged into the PCIE 16x

Re: I815 suddenly unkown to agpgart?

2007-06-13 Thread Wang Zhenyu
On 2007.06.14 09:34:12 +, Wang Zhenyu wrote: > > Dave, after rethinking about this, I think we mixed two cases > need to be fixed here. This is the patch for this, sorry for mess > it up. Meelis, could you help to test by replace my last patch with this? > oop, for 945GM

Re: I815 suddenly unkown to agpgart?

2007-06-13 Thread Wang Zhenyu
ts, like an add-in card is plugged. Second on some type of intel GMCH, it might have multiple graphic chip models, like 945GME case, so we should be sure the detect works through the whole table. Signed-off-by: Wang Zhenyu <[EMAIL PROTECTED]> --- drivers/char/a

Re: I815 suddenly unkown to agpgart?

2007-06-13 Thread Wang Zhenyu
On 2007.06.13 12:15:13 +, Dave Jones wrote: > > [AGPGART] intel_agp: use table for device probe > > > Oh, we have this check in find_gmch .. > > if (gmch_device && PCI_FUNC(gmch_device->devfn) != 0) { > ^ > >

Re: I815 suddenly unkown to agpgart?

2007-06-13 Thread Wang Zhenyu
On 2007.06.13 12:15:13 +, Dave Jones wrote: [AGPGART] intel_agp: use table for device probe Oh, we have this check in find_gmch .. if (gmch_device PCI_FUNC(gmch_device-devfn) != 0) { ^ Which isn't going

Re: I815 suddenly unkown to agpgart?

2007-06-13 Thread Wang Zhenyu
is plugged. Second on some type of intel GMCH, it might have multiple graphic chip models, like 945GME case, so we should be sure the detect works through the whole table. Signed-off-by: Wang Zhenyu [EMAIL PROTECTED] --- drivers/char/agp/intel-agp.c | 97

Re: I815 suddenly unkown to agpgart?

2007-06-13 Thread Wang Zhenyu
On 2007.06.14 09:34:12 +, Wang Zhenyu wrote: Dave, after rethinking about this, I think we mixed two cases need to be fixed here. This is the patch for this, sorry for mess it up. Meelis, could you help to test by replace my last patch with this? oop, for 945GME like case, we should

Re: [RFC][AGPGART]intel-agp: save whole config space in suspend/resume

2007-06-11 Thread Wang Zhenyu
On 2007.06.11 22:23:21 +, Dave Jones wrote: > > I'd feel much safer if we only did this on chipsets where we know we > have to do it. Doing this for *every* Intel chipset ever made _will_ > bite us. There are some early chipsets (440BX era iirc) that would just > hang the box when you

[RFC][AGPGART]intel-agp: save whole config space in suspend/resume

2007-06-11 Thread Wang Zhenyu
on agpgart.git tip. http://git.kernel.org/?p=linux/kernel/git/davej/agpgart.git;a=summary Signed-off-by: Wang Zhenyu <[EMAIL PROTECTED]> --- drivers/char/agp/intel-agp.c | 44 +- 1 files changed, 43 insertions(+), 1 deletions(-) diff --git a/drivers/char/agp

[RFC][AGPGART]intel-agp: save whole config space in suspend/resume

2007-06-11 Thread Wang Zhenyu
on agpgart.git tip. http://git.kernel.org/?p=linux/kernel/git/davej/agpgart.git;a=summary Signed-off-by: Wang Zhenyu [EMAIL PROTECTED] --- drivers/char/agp/intel-agp.c | 44 +- 1 files changed, 43 insertions(+), 1 deletions(-) diff --git a/drivers/char/agp/intel

Re: [RFC][AGPGART]intel-agp: save whole config space in suspend/resume

2007-06-11 Thread Wang Zhenyu
On 2007.06.11 22:23:21 +, Dave Jones wrote: I'd feel much safer if we only did this on chipsets where we know we have to do it. Doing this for *every* Intel chipset ever made _will_ bite us. There are some early chipsets (440BX era iirc) that would just hang the box when you tried to

Re: [AGPGART] intel_agp: Add support for G33, Q33 and Q35 chipsets

2007-06-05 Thread Wang Zhenyu
On 2007.06.06 09:01:57 +, Wang Zhenyu wrote: > > This patch adds pci ids for G33, Q33 and Q35 chips > > It bases on below intel-agp patches currently in -mm tree: > intel_agp-cleanup-intel-private-data.patch > intel_agp-cleanup-intel-private-data-update.patch > intel_agp

[AGPGART] intel_agp: Add support for G33, Q33 and Q35 chipsets

2007-06-05 Thread Wang Zhenyu
intel_agp-use-table-for-device-probe.patch intel_agp-use-table-for-device-probe-update.patch intel_agp-add-support-for-965gme-gle.patch intel_agp-add-support-for-945gme.patch Signed-off-by: Wang Zhenyu <[EMAIL PROTECTED]> --- drivers/char/agp/agp.h |6 +++- drivers/char/agp/intel-agp.c

[AGPGART] intel_agp: Add support for G33, Q33 and Q35 chipsets

2007-06-05 Thread Wang Zhenyu
intel_agp-use-table-for-device-probe.patch intel_agp-use-table-for-device-probe-update.patch intel_agp-add-support-for-965gme-gle.patch intel_agp-add-support-for-945gme.patch Signed-off-by: Wang Zhenyu [EMAIL PROTECTED] --- drivers/char/agp/agp.h |6 +++- drivers/char/agp/intel-agp.c | 78

Re: [AGPGART] intel_agp: Add support for G33, Q33 and Q35 chipsets

2007-06-05 Thread Wang Zhenyu
On 2007.06.06 09:01:57 +, Wang Zhenyu wrote: This patch adds pci ids for G33, Q33 and Q35 chips It bases on below intel-agp patches currently in -mm tree: intel_agp-cleanup-intel-private-data.patch intel_agp-cleanup-intel-private-data-update.patch intel_agp-use-table-for-device

[AGPGART] intel_agp: add support for 945GME

2007-05-30 Thread Wang Zhenyu
[AGPGART] intel_agp: add support for 945GME Add pci id info for 945GME. Signed-off-by: Wang Zhenyu <[EMAIL PROTECTED]> --- drivers/char/agp/intel-agp.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/char/agp/intel-agp.c b/drivers/char/agp/intel-agp.c

[AGPGART] intel_agp: add support for 965GME/GLE

2007-05-30 Thread Wang Zhenyu
Dave, Here's the patch to add pci ids for 965GME/GLE chip. It is based on latest git and with these two applied. + intel_agp-cleanup-intel-private-data.patch + intel_agp-use-table-for-device-probe.patch Add pci id info for 965GME/GLE support. Signed-off-by: Wang Zhenyu <[EMAIL PROTEC

[AGPGART] intel_agp: add support for 965GME/GLE

2007-05-30 Thread Wang Zhenyu
Dave, Here's the patch to add pci ids for 965GME/GLE chip. It is based on latest git and with these two applied. + intel_agp-cleanup-intel-private-data.patch + intel_agp-use-table-for-device-probe.patch Add pci id info for 965GME/GLE support. Signed-off-by: Wang Zhenyu [EMAIL PROTECTED

[AGPGART] intel_agp: add support for 945GME

2007-05-30 Thread Wang Zhenyu
[AGPGART] intel_agp: add support for 945GME Add pci id info for 945GME. Signed-off-by: Wang Zhenyu [EMAIL PROTECTED] --- drivers/char/agp/intel-agp.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/char/agp/intel-agp.c b/drivers/char/agp/intel-agp.c index

[resend] [AGPGART] intel_agp: use table for device probe

2007-05-29 Thread Wang Zhenyu
. Signed-off-by: Wang Zhenyu <[EMAIL PROTECTED]> --- drivers/char/agp/intel-agp.c | 300 ++ 1 files changed, 98 insertions(+), 202 deletions(-) diff --git a/drivers/char/agp/intel-agp.c b/drivers/char/agp/intel-agp.c index e12f579..dcb6d4f 100644 --- a/d

[resend] [AGPGART] intel_agp: cleanup intel private data

2007-05-29 Thread Wang Zhenyu
Remove volatile type declare for IO mem variables. A single private gart data is used by all drivers, this makes it clean. Eric Anholt wrote the original patch. Signed-off-by: Wang Zhenyu <[EMAIL PROTECTED]> --- drivers/char/agp/intel-agp.c | 195 ---

Re: [PATCH 2/2] [AGPGART] intel_agp: use table for device probe

2007-05-29 Thread Wang Zhenyu
On 2007.05.29 10:18:48 +, Christoph Hellwig wrote: > On Tue, May 29, 2007 at 02:21:25PM +0800, Wang Zhenyu wrote: > > +static const struct intel_driver_description { > > + unsigned int chip_id; > > + unsigned int gmch_chip_id; > > + char *name; > > +

[PATCH 2/2] [AGPGART] intel_agp: use table for device probe

2007-05-29 Thread Wang Zhenyu
[PATCH 2/2] [AGPGART] intel_agp: use table for device probe Remove big switch to make things clear. Eric Anholt was the original author. Signed-off-by: Wang Zhenyu <[EMAIL PROTECTED]> --- drivers/char/agp/intel-agp.c | 324 -- 1 files change

[PATCH 1/2] [AGPGART] intel_agp: cleanup intel private data

2007-05-29 Thread Wang Zhenyu
[AGPGART] intel_agp: cleanup intel private data A single private gart data is used by all drivers, this makes it clean. Eric Anholt wrote the original patch. Signed-off-by: Wang Zhenyu <[EMAIL PROTECTED]> --- drivers/char/agp/intel-agp.c | 193 ---

[PATCH 1/2] [AGPGART] intel_agp: cleanup intel private data

2007-05-29 Thread Wang Zhenyu
[AGPGART] intel_agp: cleanup intel private data A single private gart data is used by all drivers, this makes it clean. Eric Anholt wrote the original patch. Signed-off-by: Wang Zhenyu [EMAIL PROTECTED] --- drivers/char/agp/intel-agp.c | 193 -- 1 files

[PATCH 2/2] [AGPGART] intel_agp: use table for device probe

2007-05-29 Thread Wang Zhenyu
[PATCH 2/2] [AGPGART] intel_agp: use table for device probe Remove big switch to make things clear. Eric Anholt was the original author. Signed-off-by: Wang Zhenyu [EMAIL PROTECTED] --- drivers/char/agp/intel-agp.c | 324 -- 1 files changed, 122

Re: [PATCH 2/2] [AGPGART] intel_agp: use table for device probe

2007-05-29 Thread Wang Zhenyu
On 2007.05.29 10:18:48 +, Christoph Hellwig wrote: On Tue, May 29, 2007 at 02:21:25PM +0800, Wang Zhenyu wrote: +static const struct intel_driver_description { + unsigned int chip_id; + unsigned int gmch_chip_id; + char *name; + struct agp_bridge_driver *driver; + struct

[resend] [AGPGART] intel_agp: cleanup intel private data

2007-05-29 Thread Wang Zhenyu
Remove volatile type declare for IO mem variables. A single private gart data is used by all drivers, this makes it clean. Eric Anholt wrote the original patch. Signed-off-by: Wang Zhenyu [EMAIL PROTECTED] --- drivers/char/agp/intel-agp.c | 195 -- 1

[resend] [AGPGART] intel_agp: use table for device probe

2007-05-29 Thread Wang Zhenyu
. Signed-off-by: Wang Zhenyu [EMAIL PROTECTED] --- drivers/char/agp/intel-agp.c | 300 ++ 1 files changed, 98 insertions(+), 202 deletions(-) diff --git a/drivers/char/agp/intel-agp.c b/drivers/char/agp/intel-agp.c index e12f579..dcb6d4f 100644 --- a/drivers

Re: [patch 5/8] [Intel IOMMU] Graphics driver workarounds to provide unity map

2007-04-10 Thread Wang Zhenyu
On 2007.04.10 11:12:17 +, Andi Kleen wrote: > > > On Mon, Apr 09, 2007 at 02:55:57PM -0700, Ashok Raj wrote: > > > > Most GFX drivers don't call standard PCI DMA APIs to allocate DMA > > > > buffer, > > > > Such drivers will be broken with IOMMU enabled. To workaround this > > > > issue, >

Re: [patch 5/8] [Intel IOMMU] Graphics driver workarounds to provide unity map

2007-04-10 Thread Wang Zhenyu
On 2007.04.10 11:12:17 +, Andi Kleen wrote: On Mon, Apr 09, 2007 at 02:55:57PM -0700, Ashok Raj wrote: Most GFX drivers don't call standard PCI DMA APIs to allocate DMA buffer, Such drivers will be broken with IOMMU enabled. To workaround this issue, we added two

[PATCH] intel_agp: fix G965 GTT size detect

2007-04-09 Thread Wang Zhenyu
Dave, On G965, I810_PGETBL_CTL is a mmio offset, but we wrongly take it as pci config space offset in detecting GTT size. This one line patch fixs this. Signed-off-by: Wang Zhenyu <[EMAIL PROTECTED]> --- diff --git a/drivers/char/agp/intel-agp.c b/drivers/char/agp/intel-agp.c index a

[PATCH] intel_agp: fix G965 GTT size detect

2007-04-09 Thread Wang Zhenyu
Dave, On G965, I810_PGETBL_CTL is a mmio offset, but we wrongly take it as pci config space offset in detecting GTT size. This one line patch fixs this. Signed-off-by: Wang Zhenyu [EMAIL PROTECTED] --- diff --git a/drivers/char/agp/intel-agp.c b/drivers/char/agp/intel-agp.c index a9fdbf9

[PATCH] intel_agp: PCI id update for Intel 965GM

2007-04-08 Thread Wang Zhenyu
[AGPGART] intel: Add 965GM chipset support Update PCI id info for Intel 965GM chipset. Signed-off-by: Wang Zhenyu <[EMAIL PROTECTED]> --- diff --git a/drivers/char/agp/intel-agp.c b/drivers/char/agp/intel-agp.c index e542a62..a9fdbf9 100644 --- a/drivers/char/agp/intel-agp.c +++ b/driver

[PATCH] intel_agp: PCI id update for Intel 965GM

2007-04-08 Thread Wang Zhenyu
[AGPGART] intel: Add 965GM chipset support Update PCI id info for Intel 965GM chipset. Signed-off-by: Wang Zhenyu [EMAIL PROTECTED] --- diff --git a/drivers/char/agp/intel-agp.c b/drivers/char/agp/intel-agp.c index e542a62..a9fdbf9 100644 --- a/drivers/char/agp/intel-agp.c +++ b/drivers/char

Re: intel-agp PM experiences (was: 2.6.20-rc5: usb mouse breaks suspend to ram)

2007-01-30 Thread Wang Zhenyu
On 2007.01.29 22:30:53 +, Andreas Mohr wrote: > > I've post a patch which trys to resolve pci config restore issue, see > > http://lkml.org/lkml/2007/1/16/297. It resolves s3 issue with my 965G > > machine, > > that my X can come back to live after s3, but I wasn't aware of the issues > >

Re: intel-agp PM experiences (was: 2.6.20-rc5: usb mouse breaks suspend to ram)

2007-01-30 Thread Wang Zhenyu
On 2007.01.29 22:30:53 +, Andreas Mohr wrote: I've post a patch which trys to resolve pci config restore issue, see http://lkml.org/lkml/2007/1/16/297. It resolves s3 issue with my 965G machine, that my X can come back to live after s3, but I wasn't aware of the issues Andreas

Re: intel-agp PM experiences (was: 2.6.20-rc5: usb mouse breaks suspend to ram)

2007-01-21 Thread Wang Zhenyu
On 2007.01.18 23:16:51 +, Pavel Machek wrote: > Hi! > > > > > Especially the PCI video_state trick finally got me a working resume on > > > > 2.6.19-ck2 r128 Rage Mobility M4 AGP *WITH*(!) fully enabled and working > > > > (and keeping working!) DRI (3D). > > > > > > Can we get whitelist

Re: intel-agp PM experiences (was: 2.6.20-rc5: usb mouse breaks suspend to ram)

2007-01-21 Thread Wang Zhenyu
On 2007.01.18 23:16:51 +, Pavel Machek wrote: Hi! Especially the PCI video_state trick finally got me a working resume on 2.6.19-ck2 r128 Rage Mobility M4 AGP *WITH*(!) fully enabled and working (and keeping working!) DRI (3D). Can we get whitelist entry for

[PATCH] intel_agp: restore graphics device's pci space early in resume

2007-01-16 Thread Wang Zhenyu
against 2.6.20-rc5. Signed-off-by: Wang Zhenyu <[EMAIL PROTECTED]> --- diff --git a/drivers/char/agp/intel-agp.c b/drivers/char/agp/intel-agp.c index ab0a9c0..7af734b 100644 --- a/drivers/char/agp/intel-agp.c +++ b/drivers/char/agp/intel-agp.c @@ -1955,6 +1955,15 @@ static int agp_intel_

[PATCH] intel_agp: restore graphics device's pci space early in resume

2007-01-16 Thread Wang Zhenyu
against 2.6.20-rc5. Signed-off-by: Wang Zhenyu [EMAIL PROTECTED] --- diff --git a/drivers/char/agp/intel-agp.c b/drivers/char/agp/intel-agp.c index ab0a9c0..7af734b 100644 --- a/drivers/char/agp/intel-agp.c +++ b/drivers/char/agp/intel-agp.c @@ -1955,6 +1955,15 @@ static int agp_intel_resume(struct

Re: ECC Support in Linux

2005-08-01 Thread Wang, Zhenyu
On 2005.08.01 13:03:34 +, Roger Heflin wrote: > > On the newer Intels I have not found any useable ECC support > is there any in the kernels? For ia32, not in kernel now, see http://bluesmoke.sf.net For ia64, kernel already have support. > > I can test a variety of hardware if someone

Re: ECC Support in Linux

2005-08-01 Thread Wang, Zhenyu
On 2005.08.01 13:03:34 +, Roger Heflin wrote: On the newer Intels I have not found any useable ECC support is there any in the kernels? For ia32, not in kernel now, see http://bluesmoke.sf.net For ia64, kernel already have support. I can test a variety of hardware if someone needs