Sean Anderson wrote:
> On 9/30/24 13:16, Willem de Bruijn wrote:
> > Sean Anderson wrote:
> >> Rename ip_len to payload_len since the length in this case refers only
> >> to the payload, and not the entire IP packet like for IPv4. While we're
> >> at it, ju
Sean Anderson wrote:
> Rename ip_len to payload_len since the length in this case refers only
> to the payload, and not the entire IP packet like for IPv4. While we're
> at it, just use the variable directly when calling
> recv_verify_packet_udp/tcp.
>
> Signed-off-by: Sean Anderson
Not sure suc
Tiago Lam wrote:
> This follows the same rationale provided for the ipv4 counterpart, where
> the sendmsg() path is also extended here to support the IPV6_ORIGDSTADDR
> ancillary message to be able to specify a source address/port. This
> allows users to configure the source address and/or port egr
Tiago Lam wrote:
> sendmsg() doesn't currently allow users to set the src port from which
> egress traffic should be sent from. This is possible if a user wants to
> configure the src address from which egress traffic should be sent from
> - with the IP_PKTINFO ancillary message, a user is currentl
Tiago Lam wrote:
> In order to check if egress traffic should be allowed through, we run a
> reverse socket lookup (i.e. normal socket lookup with the src/dst
> addresses and ports reversed) to check if the corresponding ingress
> traffic is allowed in.
The subject and this description makes it so
Mohan Prasad J wrote:
> Add selftest case for testing the speed and duplex state of
> local NIC driver and the partner based on the supported
> link modes obtained from the ethtool. Speed and duplex states
> are varied and verified using ethtool.
>
> Signed-off-by: Mohan Prasad J
> ---
> .../dri
On Sun, Sep 15, 2024 at 8:45 AM Anders Roxell wrote:
>
> On Thu, 12 Sept 2024 at 17:23, Jakub Kicinski wrote:
> >
> > On Thu, 12 Sep 2024 08:31:18 +0200 Anders Roxell wrote:
> > > Fixes: 1d0dc857b5d8 ("selftests: drv-net: add checksum tests")
> > > Signed-off-by: Anders Roxell
> > > ---
> > > t
On Thu, Sep 12, 2024 at 2:31 AM Anders Roxell wrote:
>
> Fixes: 1d0dc857b5d8 ("selftests: drv-net: add checksum tests")
> Signed-off-by: Anders Roxell
This target is automatically built for targets that depend on it.
See the commit that introduced it, b86761ff6374.
+++ b/tools/testing/selftest
Sean Anderson wrote:
> On 9/10/24 13:42, Willem de Bruijn wrote:
> > Sean Anderson wrote:
> >> On 9/9/24 21:01, Willem de Bruijn wrote:
> >> > Jakub Kicinski wrote:
> >> >> On Mon, 09 Sep 2024 13:26:42 -0400 Willem de Bruijn wrote:
>
Sean Anderson wrote:
> On 9/9/24 21:01, Willem de Bruijn wrote:
> > Jakub Kicinski wrote:
> >> On Mon, 09 Sep 2024 13:26:42 -0400 Willem de Bruijn wrote:
> >> > > This seems to be a bug in the driver.
> >> > >
> >> > > A call to sk
Jakub Kicinski wrote:
> On Mon, 09 Sep 2024 13:26:42 -0400 Willem de Bruijn wrote:
> > > This seems to be a bug in the driver.
> > >
> > > A call to skb_put_padto(skb, ETH_ZLEN) should be added.
> >
> > In which case this test detecting it may be nic
Eric Dumazet wrote:
> On Mon, Sep 9, 2024 at 5:02 PM Sean Anderson wrote:
> >
> > On 9/6/24 22:05, Willem de Bruijn wrote:
> > > Sean Anderson wrote:
> > >> Padding is not included in UDP and TCP checksums. Therefore, reduce the
> > >> length of
Sean Anderson wrote:
> On 9/6/24 22:05, Willem de Bruijn wrote:
> > Sean Anderson wrote:
> >> Padding is not included in UDP and TCP checksums. Therefore, reduce the
> >> length of the checksummed data to include only the data in the IP
> >> payload. This fixes
Sean Anderson wrote:
> Padding is not included in UDP and TCP checksums. Therefore, reduce the
> length of the checksummed data to include only the data in the IP
> payload. This fixes spurious reported checksum failures like
>
> rx: pkt: sport=33000 len=26 csum=0xc850 verify=0xf9fe
> pkt: bad csu
Maciej Fijalkowski wrote:
> On Wed, Feb 28, 2024 at 07:05:56PM +0800, Yunjian Wang wrote:
> > This patch set allows TUN to support the AF_XDP Tx zero-copy feature,
> > which can significantly reduce CPU utilization for XDP programs.
>
> Why no Rx ZC support though? What will happen if I try rxdrop
Yunjian Wang wrote:
> Now the zero-copy feature of AF_XDP socket is supported by some
> drivers, which can reduce CPU utilization on the xdp program.
> This patch set allows tun to support AF_XDP Rx zero-copy feature.
>
> This patch tries to address this by:
> - Use peek_len to consume a xsk->desc
Mina Almasry wrote:
> Use netmem_ref instead of page in skb_frag_t. Currently netmem_ref
> is always a struct page underneath, but the abstraction allows efforts
> to add support for skb frags not backed by pages.
>
> There is unfortunately 1 instance where the skb_frag_t is assumed to be
> a bio_
Mina Almasry wrote:
> Minor fix for virtio: code wanting to access the fields inside an skb
> frag should use the skb_frag_*() helpers, instead of accessing the
> fields directly. This allows for extensions where the underlying
> memory is not a page.
>
> Signed-off-by: Mina Almasry
>
> ---
>
>
Jason Wang wrote:
> On Tue, Dec 19, 2023 at 12:36 AM Willem de Bruijn
> wrote:
> >
> > Steffen Trumtrar wrote:
> > > This series tries to pick up the work on the virtio-net timestamping
> > > feature from Willem de Bruijn.
> > >
> > > Origina
Steffen Trumtrar wrote:
> This series tries to pick up the work on the virtio-net timestamping
> feature from Willem de Bruijn.
>
> Original series
> Message-Id: 20210208185558.995292-1-willemdebruijn.ker...@gmail.com
> Subject: [PATCH RFC v2 0/4] virtio-net: add
> > >
> > >
> > > but even yours is also fixed I think.
> > >
> > > The common point is that a single spurious interrupt is not a problem.
> > > The problem only exists if there are tons of spurious interrupts with no
> > > real ones. For this to trigger, we keep polling the ring and while we do
>
On Tue, Apr 13, 2021 at 3:54 PM Michael S. Tsirkin wrote:
>
> On Tue, Apr 13, 2021 at 10:01:11AM -0400, Willem de Bruijn wrote:
> > On Tue, Apr 13, 2021 at 1:47 AM Michael S. Tsirkin wrote:
> > >
> > > virtio_disable_cb is currently a nop for split ring with event i
On Tue, Apr 13, 2021 at 10:03 AM Michael S. Tsirkin wrote:
>
> On Tue, Apr 13, 2021 at 04:54:42PM +0800, Jason Wang wrote:
> >
> > 在 2021/4/13 下午1:47, Michael S. Tsirkin 写道:
> > > It's unsafe to operate a vq from multiple threads.
> > > Unfortunately this is exactly what we do when invoking
> > >
On Tue, Apr 13, 2021 at 4:53 AM Jason Wang wrote:
>
>
> 在 2021/4/13 下午1:47, Michael S. Tsirkin 写道:
> > There are currently two cases where we poll TX vq not in response to a
> > callback: start xmit and rx napi. We currently do this with callbacks
> > enabled which can cause extra interrupts from
On Tue, Apr 13, 2021 at 1:47 AM Michael S. Tsirkin wrote:
>
> virtio_disable_cb is currently a nop for split ring with event index.
> This is because it used to be always called from a callback when we know
> device won't trigger more events until we update the index. However,
> now that we run w
On Sun, Apr 11, 2021 at 9:31 PM Hao Sun wrote:
>
> Hi
>
> When using Healer(https://github.com/SunHao-0/healer/tree/dev) to fuzz
> the Linux kernel, I found the following bug report, but I'm not sure
> about this.
> Sorry, I do not have a reproducing program for this bug.
> I hope that the stack t
On Tue, Mar 23, 2021 at 12:30 PM Arnd Bergmann wrote:
>
> On Tue, Mar 23, 2021 at 3:42 PM Willem de Bruijn
> wrote:
> >
> > On Tue, Mar 23, 2021 at 8:52 AM Arnd Bergmann wrote:
> > >>
> > A similar fix already landed in 5.12-rc3: commit b228c9b05876 (&quo
On Tue, Mar 23, 2021 at 8:52 AM Arnd Bergmann wrote:
>
> From: Arnd Bergmann
>
> gcc-11 warns that the TS_SKB_CB(&state)) cast in skb_find_text()
> leads to an out-of-bounds access in skb_prepare_seq_read() after
> the addition of a new struct member made skb_seq_state longer
> than ts_state:
>
>
col set by virtio_net_hdr_set_proto. Note that since the protocol
> is only checked if skb->dev implements header_ops->parse_protocol,
> packets from devices without the implementation are not checked at this
> stage.
>
> Fixes: 9274124f023b ("net: stricter validation of u
> again call mpls_gso_segment with the same packet leading to an infinite
> loop. In addition, ensure that the header length is a multiple of four,
> which should hold irrespective of the number of stacked labels.
>
> Signed-off-by: Balazs Nemeth
Acked-by: Willem de Bruijn
The compiler will
On Tue, Mar 9, 2021 at 6:26 AM Michael S. Tsirkin wrote:
>
> On Mon, Mar 08, 2021 at 11:31:25AM +0100, Balazs Nemeth wrote:
> > For gso packets, virtio_net_hdr_set_proto sets the protocol (if it isn't
> > set) based on the type in the virtio net hdr, but the skb could contain
> > anything since it
On Mon, Mar 8, 2021 at 11:43 AM David Ahern wrote:
>
> On 3/8/21 9:26 AM, Balazs Nemeth wrote:
> > On Mon, 2021-03-08 at 09:17 -0700, David Ahern wrote:
> >> On 3/8/21 9:07 AM, Willem de Bruijn wrote:
> >>>> diff --git a/net/mpls/mpls_gso.c b/net/mpls/
On Mon, Mar 8, 2021 at 5:32 AM Balazs Nemeth wrote:
>
> A packet with skb_inner_network_header(skb) == skb_network_header(skb)
> and ETH_P_MPLS_UC will prevent mpls_gso_segment from pulling any headers
> from the packet. Subsequently, the call to skb_mac_gso_segment will
> again call mpls_gso_segm
On Mon, Mar 8, 2021 at 5:32 AM Balazs Nemeth wrote:
>
> For gso packets, virtio_net_hdr_set_proto sets the protocol (if it isn't
> set) based on the type in the virtio net hdr, but the skb could contain
> anything since it could come from packet_snd through a raw socket. If
> there is a mismatch b
On Fri, Mar 5, 2021 at 11:10 AM Daniel Borkmann wrote:
>
> On 3/5/21 4:08 PM, Willem de Bruijn wrote:
> > On Fri, Mar 5, 2021 at 7:34 AM Xuesen Huang wrote:
> >>
> >> From: Xuesen Huang
> >>
> >> Add BPF_F_ADJ_ROOM_ENCAP_L2_ETH flag to the existi
g
> Signed-off-by: Li Wang
> Signed-off-by: Willem de Bruijn
Please don't add my signed off by without asking.
That said,
Acked-by: Willem de Bruijn
g
> Signed-off-by: Li Wang
> Signed-off-by: Willem de Bruijn
Please mark patch target: [PATCH bpf-next]
> ---
> tools/testing/selftests/bpf/progs/test_tc_tunnel.c | 113
> ++---
> tools/testing/selftests/bpf/test_tc_tunnel.sh | 15 ++-
>
ncap L2 type and set the inner_protocol
> as ETH_P_TEB.
>
> Suggested-by: Willem de Bruijn
> Signed-off-by: Xuesen Huang
> Signed-off-by: Zhiyong Cheng
> Signed-off-by: Li Wang
Acked-by: Willem de Bruijn
> > Instead of untyped macros, I'd define encap_ipv4 as a function that
> > calls __encap_ipv4.
> >
> > And no need for encap_ipv4_with_ext_proto equivalent to __encap_ipv4.
> >
> I defined these macros to try to keep the existing invocation for
> encap_ipv4/6
> as the same, if we define this as
ncap L2 type and set the inner_protocol
> as ETH_P_TEB.
>
> Update test_tc_tunnel to verify adding vxlan encapsulation works with
> this flag.
>
> Suggested-by: Willem de Bruijn
> Signed-off-by: Xuesen Huang
> Signed-off-by: Zhiyong Cheng
> Signed-off-by: Li Wang
Than
On Fri, Feb 26, 2021 at 3:15 PM Cong Wang wrote:
>
> On Thu, Feb 25, 2021 at 7:59 PM Xuesen Huang wrote:
> > v3:
> > - Fix the code format.
> >
> > v2:
> > Suggested-by: Willem de Bruijn
> > - Add a new flag to specify the type of the inne
On Tue, Feb 23, 2021 at 8:48 AM Balazs Nemeth wrote:
>
> On Mon, 2021-02-22 at 11:39 +0800, Jason Wang wrote:
> >
> > On 2021/2/19 10:55 下午, Willem de Bruijn wrote:
> > > On Fri, Feb 19, 2021 at 3:53 AM Jason Wang
> > > wrote:
> > > >
>
On Fri, Feb 19, 2021 at 3:53 AM Jason Wang wrote:
>
>
> On 2021/2/18 11:50 下午, Willem de Bruijn wrote:
> > On Thu, Feb 18, 2021 at 10:01 AM Balazs Nemeth wrote:
> >> For gso packets, virtio_net_hdr_set_proto sets the protocol (if it isn't
> >> set) based
On Thu, Feb 18, 2021 at 10:01 AM Balazs Nemeth wrote:
>
> For gso packets, virtio_net_hdr_set_proto sets the protocol (if it isn't
> set) based on the type in the virtio net hdr, but the skb could contain
> anything since it could come from packet_snd through a raw socket. If
> there is a mismatch
On Wed, Feb 17, 2021 at 6:18 PM Jason A. Donenfeld wrote:
>
> On 2/18/21, Willem de Bruijn wrote:
> > On Wed, Feb 17, 2021 at 5:56 PM Jason A. Donenfeld wrote:
> >>
> >> Hi Willem,
> >>
> >> On Wed, Feb 17, 2021 at 11:27 PM Willem de Bruijn
&
On Wed, Feb 17, 2021 at 5:56 PM Jason A. Donenfeld wrote:
>
> Hi Willem,
>
> On Wed, Feb 17, 2021 at 11:27 PM Willem de Bruijn
> wrote:
> > A vmlinux image might help. I couldn't find one for this kernel.
>
> https://data.zx2c4.com/icmp_send-crash-e03b4a42-70
On Wed, Feb 17, 2021 at 1:12 PM Jason A. Donenfeld wrote:
>
> Hi Netdev & Willem,
>
> I've received a report of stack corruption -- via the stack protector
> check -- in icmp_send. I was sent a vmcore, and was able to extract
> the OOPS from there. However, I've been unable to produce the bug and
ncap L2 type and set the inner_protocol
> as ETH_P_TEB.
>
> Suggested-by: Willem de Bruijn
> Signed-off-by: huangxuesen
> Signed-off-by: chengzhiyong
> Signed-off-by: wangli
Thanks, this is exactly what I meant.
Acked-by: Willem de Bruijn
One small point regarding Signed-off-by
ac header.
I would only not infer it based on some imprecise measure, such as
inner_maclen being 14. But add a new explicit flag
BPF_F_ADJ_ROOM_ENCAP_L2_ETH. Update inner protocol if the flag is
passed and inner_maclen >= ETH_HLEN. Fail the operation if the flag is
passed and inner_maclen is t
On Mon, Feb 8, 2021 at 7:16 AM huangxuesen wrote:
>
> From: huangxuesen
>
> When pushing vxlan tunnel header, set inner protocol as ETH_P_TEB in skb
> to avoid HW device disabling udp tunnel segmentation offload, just like
> vxlan_build_skb does.
>
> Drivers for NIC may invoke vxlan_features_chec
if
> dev->header_ops->create is present.
>
> Signed-off-by: Xie He
Acked-by: Willem de Bruijn
Indeed, existence of dev->header_ops->create is the deciding factor. Thanks Xie.
n separate
> steps (patches). Now both are moved around together in patch 5 and
> 6, which eliminates the need for the final (NAPI-only) patch.
>
> I won't repeat the patch summaries provided in v1:
> https://lore.kernel.org/netdev/20210129202019.2099259-1-el...@linaro.org/
>
>
On Mon, Feb 1, 2021 at 9:35 AM Alex Elder wrote:
>
> On 1/31/21 7:36 PM, Willem de Bruijn wrote:
> > On Sun, Jan 31, 2021 at 10:32 AM Alex Elder wrote:
> >>
> >> On 1/31/21 8:52 AM, Willem de Bruijn wrote:
> >>> On Sat, Jan 30, 2021 at 11:29 PM Alex Elde
On Sun, Jan 31, 2021 at 10:32 AM Alex Elder wrote:
>
> On 1/31/21 8:52 AM, Willem de Bruijn wrote:
> > On Sat, Jan 30, 2021 at 11:29 PM Alex Elder wrote:
> >>
> >> On 1/30/21 9:25 AM, Willem de Bruijn wrote:
> >>> On Fri, Jan 29, 2021 at 3:29 PM Alex El
On Sun, Jan 31, 2021 at 8:11 AM Hariprasad Kelam wrote:
>
> This series of patches add support for forward error correction(fec) and
> physical link configuration. Patches 1&2 adds necessary mbox handlers for fec
> mode configuration request and to fetch stats. Patch 3 registers driver
> callbacks
On Sat, Jan 30, 2021 at 12:04 PM Geetha sowjanya wrote:
>
> The current admin function (AF) driver and the netdev driver supports
> OcteonTx2 silicon variants. The same OcteonTx2's Resource Virtualization Unit
> (RVU)
> is carried forward to the next-gen silicon ie OcteonTx3, with some changes
>
On Sat, Jan 30, 2021 at 11:29 PM Alex Elder wrote:
>
> On 1/30/21 9:25 AM, Willem de Bruijn wrote:
> > On Fri, Jan 29, 2021 at 3:29 PM Alex Elder wrote:
> >>
> >> The channel stop and suspend paths both call __gsi_channel_stop(),
> >> which quiesces channel
On Fri, Jan 29, 2021 at 3:29 PM Alex Elder wrote:
>
> The channel stop and suspend paths both call __gsi_channel_stop(),
> which quiesces channel activity, disables NAPI, and (on other than
> SDM845) stops the channel. Similarly, the start and resume paths
> share __gsi_channel_start(), which sta
On Sat, Jan 30, 2021 at 4:53 AM Hariprasad Kelam wrote:
>
> Hi Willem,
>
> > -Original Message-
> > From: Willem de Bruijn
> > Sent: Thursday, January 28, 2021 1:50 AM
> > To: Hariprasad Kelam
> > Cc: Network Development ; LKML > ker
On Fri, Jan 29, 2021 at 6:03 PM Sven Van Asbroeck wrote:
>
> Hoi Willem, thanks a lot for reviewing this patch, much appreciated !!
>
> On Fri, Jan 29, 2021 at 5:11 PM Willem de Bruijn
> wrote:
> >
> > > +static struct sk_buff *
> > > +lan743x_rx_trim_sk
On Fri, Jan 29, 2021 at 2:56 PM Sven Van Asbroeck wrote:
>
> From: Sven Van Asbroeck
>
> Multi-buffer packets enable us to use rx ring buffers smaller than
> the mtu. This will allow us to change the mtu on-the-fly, without
> having to stop the network interface in order to re-size the rx
> ring
esses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King
(for netdrv)
Acked-by: Willem de Bruijn
On Wed, Jan 27, 2021 at 4:02 AM Hariprasad Kelam wrote:
>
> From: Christina Jacob
>
> CGX LMAC, the physical interface support link configuration parameters
> like speed, auto negotiation, duplex etc. Firmware saves these into
> memory region shared between firmware and this driver.
>
> This pat
On Wed, Jan 27, 2021 at 4:03 AM Hariprasad Kelam wrote:
>
> From: Christina Jacob
>
> Add ethtool support to configure fec modes baser/rs and
> support to fecth FEC stats from CGX as well PHY.
>
> Configure fec mode
> - ethtool --set-fec eth0 encoding rs/baser/off/auto
> Query fec mode
>
On Wed, Jan 27, 2021 at 4:04 AM Hariprasad Kelam wrote:
>
> From: Felix Manlunas
>
> This patch adds support to fetch fec stats from PHY. The stats are
> put in the shared data struct fwdata. A PHY driver indicates
> that it has FEC stats by setting the flag fwdata.phy.misc.has_fec_stats
>
> Bes
On Wed, Jan 27, 2021 at 4:05 AM Hariprasad Kelam wrote:
>
> From: Christina Jacob
>
> CGX block supports forward error correction modes baseR
> and RS. This patch adds support to set encoding mode
> and to read corrected/uncorrected block counters
>
> Adds new mailbox handlers set_fec to configur
On Wed, Jan 27, 2021 at 6:50 AM wrote:
>
> From: Stefan Chulski
>
> Armada hardware has a pause generation mechanism in GOP (MAC).
> The GOP generate flow control frames based on an indication programmed in
> Ports Control 0 Register. There is a bit per port.
> However assertion of the PortX Pau
On Wed, Jan 27, 2021 at 7:19 AM wrote:
>
> From: Stefan Chulski
>
> Spinlock added to MSS shared memory configuration space.
>
> Signed-off-by: Stefan Chulski
> ---
> drivers/net/ethernet/marvell/mvpp2/mvpp2.h | 5 +
> drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 3 +++
> 2 files
On Wed, Jan 27, 2021 at 7:26 AM wrote:
>
> From: Stefan Chulski
>
> RXQ non occupied descriptor threshold would be used by
> Flow Control Firmware feature to move to the XOFF mode.
> RXQ non occupied threshold would change interrupt cause
> that polled by CM3 Firmware.
> Actual non occupied inter
callback(t);
>
> without all the casting.
>
> Fixes: 6b8c7574a5f8 ("rtlwifi: fix build warning")
> Fixes: d3ccc14dfe95 ("rtlwifi/rtw88: convert tasklets to use new
> tasklet_setup() API")
> Signed-off-by: Emil Renner Berthing
Since the current code works, this could target net-next without Fixes tags.
Acked-by: Willem de Bruijn
ipa/ipa_cmd.c | 45 +--
> drivers/net/ipa/ipa_cmd.h | 24 ++-
> drivers/net/ipa/ipa_endpoint.c | 79 ++
> drivers/net/ipa/ipa_main.c | 1 +
> 5 files changed, 109 insertions(+), 42 deletions(-)
For netdrv
Acked-by: Willem de Bruijn
gested-by: Jiapeng Zhong
> Signed-off-by: Abaci Team
Signed-off-by lines need to have a real name. See
Documentation/process/submitting-patches.rst
With that change
Acked-by: Willem de Bruijn
On Sat, Jan 23, 2021 at 11:23 AM Horatiu Vultur
wrote:
>
> This patch extends the br_mrp_switchdev functions to be able to have a
> better understanding what cause the issue and if the SW needs to be used
> as a backup.
>
> There are the following cases:
> - when the code is compiled without CONFI
_F_GRO_UDP_FWD is
> enabled on a receiving netdevice.
>
> If both NETIF_F_GRO_FRAGLIST and NETIF_F_GRO_UDP_FWD are set,
> fraglisted GRO takes precedence. This keeps the current behaviour
> and is generally more optimal for now, as the number of NICs with
> hardware USO offload is relatively small.
>
> Signed-off-by: Alexander Lobakin
Acked-by: Willem de Bruijn
On Fri, Jan 22, 2021 at 6:25 AM Alexander Lobakin wrote:
>
> From: Willem de Bruijn
> Date: Thu, 21 Jan 2021 21:47:47 -0500
>
> > On Mon, Jan 18, 2021 at 2:33 PM Alexander Lobakin wrote:
> > >
> > > Commit 9fd1ff5d2ac7 ("udp: Support UDP fraglist G
On Mon, Jan 18, 2021 at 2:33 PM Alexander Lobakin wrote:
>
> Commit 9fd1ff5d2ac7 ("udp: Support UDP fraglist GRO/GSO.") actually
> not only added a support for fraglisted UDP GRO, but also tweaked
> some logics the way that non-fraglisted UDP GRO started to work for
> forwarding too.
> Commit 2e4e
> > > What it does not give is a type indication, such as
> > > VIRTIO_NET_HASH_TYPE_TCPv6. I don't understand how this would be used.
> > > In datapaths where the NIC has already computed the four-tuple hash
> > > and stored it in skb->hash --the common case for servers--, That typ
On Thu, Jan 14, 2021 at 3:05 AM kernel test robot wrote:
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> master
> head: 65f0d2414b7079556fbbcc070b3d1c9f9587606d
> commit: b0a0c2615f6f199a656ed8549d7dce625d77aa77 epoll: wire up syscall
> epoll_pwait2
> date: 4
On Tue, Jan 12, 2021 at 11:11 PM Jason Wang wrote:
>
>
> On 2021/1/13 上午7:47, Willem de Bruijn wrote:
> > On Tue, Jan 12, 2021 at 3:29 PM Yuri Benditovich
> > wrote:
> >> On Tue, Jan 12, 2021 at 9:49 PM Yuri Benditovich
> >> wrote:
> >>&g
med to 'hash_report_type'.
> > >
> > > When TUN module is called later to allocate and fill the virtio-net
> > > header and push it to destination virtqueue it populates the hash
> > > and the hash type into virtio-net header.
> > >
> > >
On Mon, Jan 11, 2021 at 7:58 PM Al Viro wrote:
>
> On Mon, Jan 11, 2021 at 07:30:11PM -0500, Willem de Bruijn wrote:
> > From: Willem de Bruijn
> >
> > Use in_compat_syscall() to differentiate compat handling exactly
> > where needed, including in nest
From: Willem de Bruijn
Add initial code coverage for select, pselect, poll and ppoll.
Open a socketpair and wait for a read event.
1. run with data waiting
2. run to timeout, if a (short) timeout is specified.
Also optionally pass sigset to pselect and ppoll, to exercise
all datapaths. Build
From: Willem de Bruijn
Apply the same compat deduplication strategy to ppoll that was
previously applied to select and pselect.
Like pselect, ppoll has timespec and sigmask arguments, which have
compat variants. poll has neither, so is not modified.
Convert the ppoll syscall to a do_ppoll
From: Willem de Bruijn
Select and pselect have multiple syscall implementations to handle
compat and 32-bit time variants.
Deduplicate core logic, which can cause divergence over time as
changes may not be applied consistently. See vmalloc support in
select, for one example.
Handle compat
From: Willem de Bruijn
Deduplicate the open coded branch on sigmask compat handling.
Signed-off-by: Willem de Bruijn
Cc: Jens Axboe
---
fs/eventpoll.c | 5 +
fs/io_uring.c | 9 +
fs/select.c| 10 ++
include/linux/compat.h | 10 ++
4
From: Willem de Bruijn
io_pgetevents has four variants, including compat variants of both
timespec and sigmask.
With set_maybe_compat_user_sigmask helper, the latter can be
deduplicated. Move the shared logic to new do_io_pgetevents,
analogous to do_io_getevents.
Signed-off-by: Willem de
From: Willem de Bruijn
Use in_compat_syscall() to differentiate compat handling exactly
where needed, including in nested function calls. Then remove
duplicated code in callers.
Changes
RFC[1]->v1
- remove kselftest dependency on variant support in teardown
(patch is out for review,
From: Willem de Bruijn
Apply the same compat deduplication strategy to epoll that was
previously applied to (p)select and ppoll.
Make do_epoll_wait handle both variants of sigmask. This removes
the need for near duplicate do_compat_epoll_pwait.
Signed-off-by: Willem de Bruijn
---
fs
On Thu, Dec 10, 2020 at 5:59 PM Willem de Bruijn
wrote:
>
> On Thu, Dec 10, 2020 at 3:34 PM Arnd Bergmann wrote:
> >
> > On Thu, Dec 10, 2020 at 6:33 PM Willem de Bruijn
> > wrote:
> > > On Sat, Nov 21, 2020 at 4:27 AM Arnd Bergmann wrote:
> > > &g
On Thu, Jan 7, 2021 at 3:53 PM Steven Rostedt wrote:
>
> On Thu, 7 Jan 2021 11:47:02 -0800
> Linus Torvalds wrote:
>
> > On Wed, Jan 6, 2021 at 8:45 PM Willem de Bruijn wrote:
> > >
> > > But there are three other kmap_atomic callers under net/ that do
On Thu, Jan 7, 2021 at 8:33 AM Daniel Borkmann wrote:
>
> On 1/7/21 2:05 PM, Willem de Bruijn wrote:
> > On Thu, Jan 7, 2021 at 7:52 AM Daniel Borkmann wrote:
> >> On 1/7/21 12:40 PM, Dongseok Yi wrote:
> >>> On 2021-01-07 20:05, Daniel Borkmann wrote:
> >&
3.426844] packet_set_ring+0x5f0/0x820
> >>> [ 4443.426849] packet_setsockopt+0x5a4/0xcd0
> >>> [ 4443.426853] __sys_setsockopt+0x188/0x278
> >>> [ 4443.426858] __arm64_sys_setsockopt+0x28/0x38
> >>> [ 4443.426869] el0_svc_common+0xf0/0x1d0
> >>&
On Wed, Jan 6, 2021 at 9:11 PM Willem de Bruijn wrote:
>
> On Wed, Jan 6, 2021 at 8:49 PM Jakub Kicinski wrote:
> >
> > On Wed, 6 Jan 2021 17:03:48 -0800 Linus Torvalds wrote:
> > > I wonder whether there is other code that "knows" about kmap() only
> >
On Wed, Jan 6, 2021 at 8:49 PM Jakub Kicinski wrote:
>
> On Wed, 6 Jan 2021 17:03:48 -0800 Linus Torvalds wrote:
> > I wonder whether there is other code that "knows" about kmap() only
> > affecting PageHighmem() pages thing that is no longer true.
> >
> > Looking at some other code, skb_gro_reset
On Tue, Jan 5, 2021 at 10:32 PM Dongseok Yi wrote:
>
> On 2021-01-06 12:07, Willem de Bruijn wrote:
> >
> > On Tue, Jan 5, 2021 at 8:29 PM Dongseok Yi wrote:
> > >
> > > On 2021-01-05 06:03, Willem de Bruijn wrote:
> > > >
> >
On Tue, Jan 5, 2021 at 8:29 PM Dongseok Yi wrote:
>
> On 2021-01-05 06:03, Willem de Bruijn wrote:
> >
> > On Mon, Jan 4, 2021 at 4:00 AM Dongseok Yi wrote:
> > >
> > > skbs in frag_list could be shared by pskb_expand_head() from BPF.
> >
> > Can y
On Mon, Jan 4, 2021 at 4:00 AM Dongseok Yi wrote:
>
> skbs in frag_list could be shared by pskb_expand_head() from BPF.
Can you elaborate on the BPF connection?
> While tcpdump, sk_receive_queue of PF_PACKET has the original frag_list.
> But the same frag_list is queued to PF_INET (or PF_INET6)
On Sun, Dec 20, 2020 at 6:43 AM Arnd Bergmann wrote:
>
> On Sun, Dec 20, 2020 at 11:00 AM Heiko Carstens wrote:
> >
> > Commit b0a0c2615f6f ("epoll: wire up syscall epoll_pwait2") wired up
> > the 64 bit syscall instead of the compat variant in a couple of pl
On Mon, Dec 14, 2020 at 9:59 AM kernel test robot wrote:
>
> Greeting,
>
> FYI, we noticed the following commit (built with gcc-9):
>
> commit: fb728736669f7805bcc0fa1c4d578faf991d62a8 ("epoll: wire up syscall
> epoll_pwait2")
> https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git mas
> >> I did not use "Fair Queue traffic policing".
> >> As for ETF, it is all about ordering packets from different
> >> applications.
> >> How can we achive it with skiping queuing?
> >> Could you elaborate on this point?
> >> >>>
> >> >>> The qdisc can only defer pacing t
1 - 100 of 488 matches
Mail list logo
