Re: [PATCH v2 0/2] Adds support to capture module's SCM version

On Wed, Nov 25, 2020 at 01:05:39AM +, Will McVicker wrote: > Hi All, > > I have updated the patchset to: > > *) Include Documentation. > *) Use a consistent output pattern for the SCM version. > > In my debugging, I found that the vermagic reported by modinfo can actually > vary based on

Re: [PATCH v2 1/5] USB: gadget: f_rndis: fix bitrate for SuperSpeed and above

On Mon, Nov 30, 2020 at 06:24:40AM +, Peter Chen wrote: > On 20-11-27 15:05:55, Greg Kroah-Hartman wrote: > > From: Will McVicker > > > > Align the SuperSpeed Plus bitrate for f_rndis to match f_ncm's ncm_bitrate > > defined by commit 1650113888fe ("usb: gadget: f_ncm: add SuperSpeed > >

Re: Potential Issue in Tracing Ring Buffer

On Mon, Nov 30, 2020 at 09:48:46AM -0500, Steven Rostedt wrote: > On Thu, 26 Nov 2020 13:26:13 -0500 > Steven Rostedt wrote: > > > On Thu, 26 Nov 2020 06:52:45 +0100 > > Greg KH wrote: > > > > > On Tue, Nov 24, 2020 at 10:39:17PM +, J. Avila wrote: > > > > Hello, > > > > > > > > In the

Re: [PATCH v1 0/2] Add support to capture external module's SCM version

On Tue, Nov 24, 2020 at 09:24:26PM +0100, Greg Kroah-Hartman wrote: > On Tue, Nov 24, 2020 at 10:31:39AM -0800, William Mcvicker wrote: > > On Tue, Nov 24, 2020 at 07:12:40PM +0100, Greg Kroah-Hartman wrote: > > > On Tue, Nov 24, 2020 at 10:05:16AM -0800, William Mcvicker wro

Re: [PATCH v1 0/2] Add support to capture external module's SCM version

On Tue, Nov 24, 2020 at 07:12:40PM +0100, Greg Kroah-Hartman wrote: > On Tue, Nov 24, 2020 at 10:05:16AM -0800, William Mcvicker wrote: > > On Tue, Nov 24, 2020 at 10:31:18AM +0100, Jessica Yu wrote: > > > +++ William Mcvicker [23/11/20 14:13 -0800]: > > > > On M

Re: [PATCH v1 0/2] Add support to capture external module's SCM version

On Tue, Nov 24, 2020 at 10:31:18AM +0100, Jessica Yu wrote: > +++ William Mcvicker [23/11/20 14:13 -0800]: > > On Mon, Nov 23, 2020 at 09:02:57AM +, Christoph Hellwig wrote: > > > On Sat, Nov 21, 2020 at 01:16:49AM +, Will McVicker wrote: > > > > These

Re: [PATCH v1 0/2] Add support to capture external module's SCM version

On Mon, Nov 23, 2020 at 09:02:57AM +, Christoph Hellwig wrote: > On Sat, Nov 21, 2020 at 01:16:49AM +, Will McVicker wrote: > > These two patches add module support to capture an external module's SCM > > version as a MODULE_INFO() attribute. This allows users to identity the SCM > >

Re: [PATCH] arm64: Fix off-by-one vdso trampoline return value

tps://reviews.llvm.org/D86263. So for kernels that use ld.lld and the VDSO compat sigreturn trampoline, they need to make sure to upgrade their toolchain. I hope this thread helps anyone running into this issue in the future. Thanks, Will On 11/12/2020, William Mcvicker wrote: > Hi Nick, > &g

Re: [PATCH] arm64: Fix off-by-one vdso trampoline return value

Hi Nick, Regarding llvm-nm, this extra thumb +1 is noticed after porting https://lore.kernel.org/linux-arm-kernel/20201013033947.2257501-1-natechancel...@gmail.com/ to the Android Common Kernel android-4.19-stable. I'm not sure why using ld.lld causes this difference, but this proposed patch

Re: [PATCH v2 1/1] netfilter: nat: add a range check for l3/l4 protonum

ll > > > > On Mon, Aug 03, 2020 at 06:31:56PM +, William Mcvicker wrote: > > [...] > > > diff --git a/net/netfilter/nf_conntrack_netlink.c > > > b/net/netfilter/nf_conntrack_netlink.c > > > index 31fa94064a62..56d310f8b29a 100644 > > > --- a/net

Re: [PATCH v2 1/1] netfilter: nat: add a range check for l3/l4 protonum

Hi, I have attached the follow up fix that checks for the proto index during conntrack creation. Thanks, Will On 07/31/2020, William Mcvicker wrote: > Hi Pablo, > > > Note that this code does not exist in the tree anymore. I'm not sure > > if this problem still exists upstrea

Re: [PATCH 1/1] netfilter: nat: add range checks for access to nf_nat_l[34]protos[]

his thread with the re-worked patch. Thanks, Will On 07/31/2020, Pablo Neira Ayuso wrote: > Hi William, > > On Fri, Jul 31, 2020 at 12:26:11AM +, William Mcvicker wrote: > > Hi Pablo, > > > > Yes, I believe this oops is only triggered by userspace when the user >

Re: [PATCH 1/1] netfilter: nat: add range checks for access to nf_nat_l[34]protos[]

Hi Pablo, Yes, I believe this oops is only triggered by userspace when the user specifically passes in an invalid nf_nat_l3protos index. I'm happy to re-work the patch to check for this in ctnetlink_create_conntrack(). > BTW, do you have a Fixes: tag for this? This will be useful for > -stable