On Thu, May 30, 2019 at 4:52 AM Ondrej Mosnacek wrote:
>
> On Thu, May 30, 2019 at 10:51 AM Gen Zhang wrote:
> > In selinux_sb_eat_lsm_opts(), 'arg' is allocated by kmemdup_nul(). It
> > returns NULL when fails. So 'arg' should be checked.
> >
> > Signed-off-by: Gen Zhang
> > Fixes: 99dbbb593fe6
On Wed, May 29, 2019 at 8:55 PM Gen Zhang wrote:
>
> In selinux_sb_eat_lsm_opts(), 'arg' is allocated by kmemdup_nul(). It
> returns NULL when fails. So 'arg' should be checked.
>
> Signed-off-by: Gen Zhang
> ---
> diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
> index 3ec702c..
On Wed, May 17, 2017 at 11:30 AM, Stephen Smalley wrote:
> On Thu, 2017-05-18 at 02:09 +0900, Sebastien Buisson wrote:
>> Add policybrief field to struct policydb. It holds a brief info
>> of the policydb, made of colon separated name and value pairs
>> that give information about how the policy i
On Wed, May 17, 2017 at 10:00 AM, Sebastien Buisson
wrote:
> 2017-05-17 18:04 GMT+02:00 William Roberts :
>> I'm assuming in the Lustre code you're going to call security_policy_brief(),
>> how would the caller know how big that buffer is going to be?
>
> We can det
On Wed, May 17, 2017 at 9:04 AM, William Roberts
wrote:
> On Wed, May 17, 2017 at 8:43 AM, Sebastien Buisson
> wrote:
>> 2017-05-17 17:34 GMT+02:00 William Roberts :
>>>>>>> Is there a particular reason to not just return policybrief_len here as
>>>&
On Wed, May 17, 2017 at 8:43 AM, Sebastien Buisson
wrote:
> 2017-05-17 17:34 GMT+02:00 William Roberts :
>>>>>> Is there a particular reason to not just return policybrief_len here as
>>>>>> well, for consistency in the interface? How do you intend
On Wed, May 17, 2017 at 8:24 AM, Sebastien Buisson
wrote:
> 2017-05-17 17:09 GMT+02:00 William Roberts :
>> On Wed, May 17, 2017 at 7:59 AM, Sebastien Buisson
>> wrote:
>>> 2017-05-16 22:40 GMT+02:00 Stephen Smalley :
>>>>> + strcpy(*brief, policydb.p
On Wed, May 17, 2017 at 7:59 AM, Sebastien Buisson
wrote:
> 2017-05-16 22:40 GMT+02:00 Stephen Smalley :
>>> + strcpy(*brief, policydb.policybrief);
>>> + /* *len is the length of the output string */
>>> + *len = policybrief_len - 1;
>>
>> Is there a particular reason to not just retu
On Fri, May 12, 2017 at 3:22 PM, Paul Moore wrote:
>
> On Thu, May 11, 2017 at 4:45 PM, Casey Schaufler
> wrote:
> > On 5/11/2017 1:22 PM, Stephen Smalley wrote:
> >> On Thu, 2017-05-11 at 08:56 -0700, Casey Schaufler wrote:
> >>> On 5/11/2017 5:59 AM, Sebastien Buisson wrote:
> Add policyb
that were
inconvenienced a drink at a conference :-P
Bill
On Tue, Feb 11, 2014 at 9:47 AM, William Roberts
wrote:
> The most up to date patches were v6. The difference between v5 and v6
> is rtrim(). Did you not want the rtrim?
> Most things end with null bytes, this helps prevent hex-
Re-factor proc_pid_cmdline() to use get_cmdline() helper
from mm.h.
Acked-by: David Rientjes
Acked-by: Stephen Smalley
Acked-by: Richard Guy Briggs
Signed-off-by: William Roberts
---
fs/proc/base.c | 36 ++--
1 file changed, 2 insertions(+), 34 deletions
key=(null)
type=UNKNOWN[1327] msg=audit(1391217013.924:386):
proctitle=6D6B646972002D70002F7661722F72756E2F636F6E736F6C65
Acked-by: Steve Grubb (wrt record formating)
Signed-off-by: William Roberts
---
include/uapi/linux/audit.h |1 +
kernel/audit.h |6
kernel/auditsc.c | 67 +++
introduce get_cmdline() for retreiving the value of a processes
proc/self/cmdline value.
Acked-by: David Rientjes
Acked-by: Stephen Smalley
Acked-by: Richard Guy Briggs
Signed-off-by: William Roberts
---
include/linux/mm.h |1 +
mm/util.c | 48
kernel&m=139093196518317&w=2
http://marc.info/?l=linux-kernel&m=139093197518332&w=2
Bill
On Tue, Feb 11, 2014 at 9:25 AM, William Roberts
wrote:
> On Tue, Feb 11, 2014 at 8:36 AM, Richard Guy Briggs wrote:
>> On 14/02/06, William Roberts wrote:
>>> During an
On Tue, Feb 11, 2014 at 8:36 AM, Richard Guy Briggs wrote:
> On 14/02/06, William Roberts wrote:
>> During an audit event, cache and print the value of the process's
>> proctitle value (proc//cmdline). This is useful in situations
>> where processes are started via for
key=(null)
type=UNKNOWN[1327] msg=audit(1391217013.924:386):
proctitle=6D6B646972002D70002F7661722F72756E2F636F6E736F6C65
Signed-off-by: William Roberts
---
include/uapi/linux/audit.h |1 +
kernel/audit.h |6
kernel/auditsc.c | 67
3 files cha
introduce get_cmdline() for retreiving the value of a processes
proc/self/cmdline value.
Acked-by: David Rientjes
Acked-by: Stephen Smalley
Signed-off-by: William Roberts
---
include/linux/mm.h |1 +
mm/util.c | 48
2 files
Re-factor proc_pid_cmdline() to use get_cmdline() helper
from mm.h.
Acked-by: David Rientjes
Acked-by: Stephen Smalley
Signed-off-by: William Roberts
---
fs/proc/base.c | 36 ++--
1 file changed, 2 insertions(+), 34 deletions(-)
diff --git a/fs/proc/base.c
introduce get_cmdline() for retreiving the value of a processes
proc/self/cmdline value.
Acked-by: David Rientjes
Acked-by: Stephen Smalley
Signed-off-by: William Roberts
---
include/linux/mm.h |1 +
mm/util.c | 48
2 files
Re-factor proc_pid_cmdline() to use get_cmdline() helper
from mm.h.
Acked-by: David Rientjes
Acked-by: Stephen Smalley
Signed-off-by: William Roberts
---
fs/proc/base.c | 36 ++--
1 file changed, 2 insertions(+), 34 deletions(-)
diff --git a/fs/proc/base.c
d=1002 gid=1002 euid=1002 suid=1002 fsuid=1002 egid=1002
sgid=1002 fsgid=1002 tty=(none) ses=4294967295 comm="bt_hc_worker"
exe="/system/bin/app_process" subj=u:r:bluetooth:s0 key=(null)
cmdline="com.android.bluetooth"
Signed-off-by: William Roberts
---
kernel
introduce get_cmdline() for retreiving the value of a processes
proc/self/cmdline value.
Acked-by: David Rientjes
Acked-by: Stephen Smalley
Signed-off-by: William Roberts
---
include/linux/mm.h |1 +
mm/util.c | 48
2 files
d=1002 gid=1002 euid=1002 suid=1002 fsuid=1002 egid=1002
sgid=1002 fsgid=1002 tty=(none) ses=4294967295 comm="bt_hc_worker"
exe="/system/bin/app_process" cmdline="com.android.bluetooth"
subj=u:r:bluetooth:s0 key=(null)
Signed-off-by: William Roberts
---
kerne
Re-factor proc_pid_cmdline() to use get_cmdline() helper
from mm.h.
Acked-by: David Rientjes
Acked-by: Stephen Smalley
Signed-off-by: William Roberts
---
fs/proc/base.c | 36 ++--
1 file changed, 2 insertions(+), 34 deletions(-)
diff --git a/fs/proc/base.c
introduce get_cmdline() for retreiving the value of a processes
proc/self/cmdline value.
Signed-off-by: William Roberts
---
include/linux/mm.h |1 +
mm/util.c | 48
2 files changed, 49 insertions(+)
diff --git a/include/linux/mm.h
Re-factor proc_pid_cmdline() to use get_cmdline() helper
from mm.h.
Signed-off-by: William Roberts
---
fs/proc/base.c | 36 ++--
1 file changed, 2 insertions(+), 34 deletions(-)
diff --git a/fs/proc/base.c b/fs/proc/base.c
index 5150706..f0c5927 100644
--- a
d=1002 gid=1002 euid=1002 suid=1002 fsuid=1002 egid=1002
sgid=1002 fsgid=1002 tty=(none) ses=4294967295 comm="bt_hc_worker"
exe="/system/bin/app_process" cmdline="com.android.bluetooth"
subj=u:r:bluetooth:s0 key=(null)
Signed-off-by: William Roberts
---
kerne
On Thu, Jan 16, 2014 at 8:40 AM, William Roberts
wrote:
> On Thu, Jan 16, 2014 at 7:11 AM, Steve Grubb wrote:
>> On Thursday, January 16, 2014 07:03:34 AM William Roberts wrote:
>>> On Thu, Jan 16, 2014 at 6:02 AM, Steve Grubb wrote:
>>> > On Wednesday, Januar
On Thu, Jan 16, 2014 at 6:02 AM, Steve Grubb wrote:
> On Wednesday, January 15, 2014 09:08:39 PM William Roberts wrote:
>> >> > Try this,
>> >> >
>> >> > cp /bin/ls 'test test test'
>> >> > auditctll -a always,exit -
On Wed, Jan 15, 2014 at 8:51 PM, Steve Grubb wrote:
> On Wednesday, January 15, 2014 05:44:29 PM William Roberts wrote:
>> On Wed, Jan 15, 2014 at 5:33 PM, Steve Grubb wrote:
>> > On Wednesday, January 15, 2014 05:08:13 PM William Roberts wrote:
>> >> On Wed, Jan 15
On Wed, Jan 15, 2014 at 5:33 PM, Steve Grubb wrote:
> On Wednesday, January 15, 2014 05:08:13 PM William Roberts wrote:
>> On Wed, Jan 15, 2014 at 4:54 PM, Steve Grubb wrote:
>> > On Wednesday, January 15, 2014 01:02:14 PM William Roberts wrote:
>> >> During an au
On Wed, Jan 15, 2014 at 4:54 PM, Steve Grubb wrote:
> On Wednesday, January 15, 2014 01:02:14 PM William Roberts wrote:
>> During an audit event, cache and print the value of the process's
>> cmdline value (proc//cmdline). This is useful in situations
>> where proces
d=1002 gid=1002 euid=1002 suid=1002 fsuid=1002 egid=1002
sgid=1002 fsgid=1002 tty=(none) ses=4294967295 comm="bt_hc_worker"
exe="/system/bin/app_process" cmdline="com.android.bluetooth"
subj=u:r:bluetooth:s0 key=(null)
Signed-off-by: William Roberts
---
kernel
introduce get_cmdline() for retreiving the value of a processes
proc/self/cmdline value.
Acked-by: David Rientjes
Acked-by: Stephen Smalley
Signed-off-by: William Roberts
---
include/linux/mm.h |1 +
mm/util.c | 48
2 files
Re-factor proc_pid_cmdline() to use get_cmdline() helper
from mm.h.
Acked-by: David Rientjes
Acked-by: Stephen Smalley
Signed-off-by: William Roberts
---
fs/proc/base.c | 36 ++--
1 file changed, 2 insertions(+), 34 deletions(-)
diff --git a/fs/proc/base.c
This bounced LKML, re-sending. My phone sent it as HTML
On Tue, Jan 14, 2014 at 7:50 PM, William Roberts
wrote:
> The race was non existent. I had the VMA locked. I switched to this to keep
> the code that gets the cmdline value almost unchanged to try and reduce
> bugs. I can still
d=1002 gid=1002 euid=1002 suid=1002 fsuid=1002 egid=1002
sgid=1002 fsgid=1002 tty=(none) ses=4294967295 comm="bt_hc_worker"
exe="/system/bin/app_process" cmdline="com.android.bluetooth"
subj=u:r:bluetooth:s0 key=(null)
Signed-off-by: William Roberts
---
kernel/audit
On Mon, Jan 13, 2014 at 12:02 PM, William Roberts
wrote:
> During an audit event, cache and print the value of the process's
> cmdline value (proc//cmdline). This is useful in situations
> where processes are started via fork'd virtual machines where the
> comm field is
Re-factor proc_pid_cmdline() to use get_cmdline() helper
from mm.h.
Signed-off-by: William Roberts
---
fs/proc/base.c | 36 ++--
1 file changed, 2 insertions(+), 34 deletions(-)
diff --git a/fs/proc/base.c b/fs/proc/base.c
index 03c8d74..cfd178d 100644
--- a
d=1002 gid=1002 euid=1002 suid=1002 fsuid=1002 egid=1002
sgid=1002 fsgid=1002 tty=(none) ses=4294967295 comm="bt_hc_worker"
exe="/system/bin/app_process" subj=u:r:bluetooth:s0 key=(null)
cmdline="com.android.bluetooth"
Signed-off-by: William Roberts
---
kernel/audit
introduce get_cmdline() for retreiving the value of a processes
proc/self/cmdline value.
Signed-off-by: William Roberts
---
include/linux/mm.h |1 +
mm/util.c | 48
2 files changed, 49 insertions(+)
diff --git a/include/linux/mm.h
t;
> On Mon, Jan 06, 2014 at 07:30:30AM -0800, William Roberts wrote:
>> +static void audit_log_cmdline(struct audit_buffer *ab, struct task_struct
>> *tsk,
>> + struct audit_context *context)
>> +{
>> + int res;
>> + char *buf;
&
-Original Message-
From: Mateusz Guzik [mailto:mgu...@redhat.com]
Sent: Monday, January 06, 2014 9:09 AM
To: William Roberts
Cc: linux-au...@redhat.com; linux...@kvack.org; linux-kernel@vger.kernel.org;
r...@redhat.com; v...@zeniv.linux.org.uk; a...@linux-foundation.org;
s
d=1002 gid=1002 euid=1002 suid=1002 fsuid=1002 egid=1002
sgid=1002 fsgid=1002 tty=(none) ses=4294967295 comm="bt_hc_worker"
exe="/system/bin/app_process" cmdline="com.android.bluetooth"
subj=u:r:bluetooth:s0 key=(null)
Signed-off-by: William Roberts
---
kernel/au
Re-factor proc_pid_cmdline() to use get_cmdline() helper
from mm.h.
Signed-off-by: William Roberts
---
fs/proc/base.c | 36 ++--
1 file changed, 2 insertions(+), 34 deletions(-)
diff --git a/fs/proc/base.c b/fs/proc/base.c
index 03c8d74..cfd178d 100644
--- a
introduce get_cmdline() for retreiving the value of a processes
proc/self/cmdline value.
Signed-off-by: William Roberts
---
include/linux/mm.h |1 +
mm/util.c | 48
2 files changed, 49 insertions(+)
diff --git a/include/linux/mm.h
Re-factor proc_pid_cmdline() to use get_cmdline() helper
from mm.h.
Signed-off-by: William Roberts
---
fs/proc/base.c | 36 ++--
1 file changed, 2 insertions(+), 34 deletions(-)
diff --git a/fs/proc/base.c b/fs/proc/base.c
index 03c8d74..cfd178d 100644
--- a
d=1002 gid=1002 euid=1002 suid=1002 fsuid=1002 egid=1002
sgid=1002 fsgid=1002 tty=(none) ses=4294967295 comm="bt_hc_worker"
exe="/system/bin/app_process" cmdline="com.android.bluetooth"
subj=u:r:bluetooth:s0 key=(null)
Signed-off-by: William Roberts
---
kernel/au
introduce get_cmdline() for retreiving the value of a processes
proc/self/cmdline value.
Signed-off-by: William Roberts
---
include/linux/mm.h |1 +
mm/util.c | 48
2 files changed, 49 insertions(+)
diff --git a/include/linux/mm.h
On Fri, Dec 13, 2013 at 10:26 AM, William Roberts
wrote:
> On Fri, Dec 13, 2013 at 10:04 AM, Stephen Smalley wrote:
>> On 12/13/2013 09:51 AM, William Roberts wrote:
>>> On Fri, Dec 13, 2013 at 9:12 AM, Stephen Smalley wrote:
>>>> Also, why not just get_task_mm(ta
On Fri, Dec 13, 2013 at 10:04 AM, Stephen Smalley wrote:
> On 12/13/2013 09:51 AM, William Roberts wrote:
>> On Fri, Dec 13, 2013 at 9:12 AM, Stephen Smalley wrote:
>>> Also, why not just get_task_mm(task) within the function rather than
>>> pass it in by the caller?
&
On Fri, Dec 13, 2013 at 9:23 AM, Stephen Smalley wrote:
> On 12/02/2013 04:10 PM, William Roberts wrote:
>> Re-factor proc_pid_cmdline() to use get_cmdline_length() and
>> copy_cmdline() helpers from mm.h
>>
>> Signed-off-by: William Roberts
>&
On Fri, Dec 13, 2013 at 9:12 AM, Stephen Smalley wrote:
> On 12/02/2013 04:10 PM, William Roberts wrote:
>> Add two new functions to mm.h:
>> * copy_cmdline()
>> * get_cmdline_length()
>>
>> Signed-off-by: William Roberts
>> ---
>> include/linux/mm.h
all,
I sent out some patches a while back (12/2) that affect mm, procfs and
audit. The audit patch (PATCH 3/3) was ack'd on by Richard Guy Briggs.
But the other patches I have not heard anything on.
Patches:
[PATCH 1/3] mm: Create utility functions for accessing a tasks commandline value
[PATCH 2
ot;?
Thank you,
Bill
-Original Message-
From: owner-linux...@kvack.org [mailto:owner-linux...@kvack.org] On Behalf Of
William Roberts
Sent: Monday, December 02, 2013 1:11 PM
To: linux-au...@redhat.com; linux...@kvack.org; linux-kernel@vger.kernel.org;
r...@redhat.com; v...@zeniv.lin
Sigh...I sent this back out from another emai address and got bounced
from the lists... resending. Sorry for the cruft.
On Fri, Dec 6, 2013 at 7:34 AM, William Roberts wrote:
> I sent out 3 patches on 12/2/2013. I didn't get any response. I thought I
> added the right peop
Re-factor proc_pid_cmdline() to use get_cmdline_length() and
copy_cmdline() helpers from mm.h
Signed-off-by: William Roberts
---
fs/proc/base.c | 35 ++-
1 file changed, 10 insertions(+), 25 deletions(-)
diff --git a/fs/proc/base.c b/fs/proc/base.c
index
ple of where this
is useful and applicable is in the realm of Android.
The cached cmdline is tied to the lifecycle of the audit_context
structure and is built on demand.
Signed-off-by: William Roberts
---
kernel/audit.h |1 +
kernel/auditsc.c | 82 +++
Add two new functions to mm.h:
* copy_cmdline()
* get_cmdline_length()
Signed-off-by: William Roberts
---
include/linux/mm.h |7 +++
mm/util.c | 48
2 files changed, 55 insertions(+)
diff --git a/include/linux/mm.h b/include
This patch series relates to work started on the audit mailing list.
It eventually involved touching other modules, so I am trying to
pull in those owners as well. In a nutshell I add new utility
functions for accessing a processes cmdline value as displayed
in proc//cmdline, and then refactor proc
60 matches
Mail list logo
