[tip: x86/urgent] RAS/CEC: Correct ce_add_elem()'s returned values

2021-04-07 Thread tip-bot2 for William Roche
The following commit has been merged into the x86/urgent branch of tip: Commit-ID: 3a62583c2853b0ab37a57dde79decea210b5fb89 Gitweb: https://git.kernel.org/tip/3a62583c2853b0ab37a57dde79decea210b5fb89 Author:William Roche AuthorDate:Tue, 06 Apr 2021 11:28:59 -04:00

[PATCH v2] RAS/CEC: Memory Corrected Errors consistent event filtering

2021-04-06 Thread William Roche
From: William Roche The Corrected Error events collected by the cec_add_elem() have to be consistently filtered out. We fix the case where the value of find_elem() to find the slot of a pfn was mistakenly used as the return value of the function. Now the MCE notifiers chain relying

Re: [PATCH v1] RAS/CEC: Memory Corrected Errors consistent event filtering

2021-04-02 Thread William Roche
On 01/04/2021 18:12, Borislav Petkov wrote: On Mon, Mar 29, 2021 at 11:44:05AM +0200, William Roche wrote: I totally agree with you, and in order to schedule a replacement, MCEs information (enriched by the notifiers chain) are more meaningful than only PFN values. Well, if you want

Re: [PATCH v1] RAS/CEC: Memory Corrected Errors consistent event filtering

2021-03-29 Thread William Roche
On 26/03/2021 23:43, Borislav Petkov wrote: On Fri, Mar 26, 2021 at 11:24:43PM +0100, William Roche wrote: What we want is to make cec_add_elem() to return !0 value only when the given pfn triggered an action, so that its callers should log the error. No, this is not what the CEC does

Re: [PATCH v1] RAS/CEC: Memory Corrected Errors consistent event filtering

2021-03-26 Thread William Roche
On 26/03/2021 20:02, Borislav Petkov wrote: On Fri, Mar 26, 2021 at 02:30:29PM -0400, “William Roche wrote: From: William Roche The Corrected Error events collected by the cec_add_elem() have to be consistently filtered out. We fix the case where the value of find_elem() to find the slot

[PATCH v1] RAS/CEC: Memory Corrected Errors consistent event filtering

2021-03-26 Thread William Roche
From: William Roche The Corrected Error events collected by the cec_add_elem() have to be consistently filtered out. We fix the case where the value of find_elem() to find the slot of a pfn was mistakenly used as the return value of the function. Now the MCE notifiers chain relying

Re: [PATCH v1] panic: push panic() messages to the console even from the MCE nmi handler

2021-01-11 Thread William Roche
Thank you for your clarification, and let me explain what I was talking about before providing my last code version. kmsg_dump(KMSG_DUMP_PANIC); + panic_flush_to_console(); > > This is wrong. kmsg_dump() flushes the messages into the registered > dumpers, e.g. pstore. It

Re: [PATCH v1] panic: push panic() messages to the console even from the MCE nmi handler

2021-01-07 Thread William Roche
On 06/01/2021 05:35, Sergey Senozhatsky wrote: > On (21/01/04 16:15), “William Roche wrote: > [..] >> diff --git a/kernel/panic.c b/kernel/panic.c >> index 332736a..eb90cc0 100644 >> --- a/kernel/panic.c >> +++ b/kernel/panic.c >> @@ -166,6 +166,15 @@ s

[PATCH v1] panic: push panic() messages to the console even from the MCE nmi handler

2021-01-04 Thread William Roche
From: William Roche Force push panic messages to the console as panic() can be called from NMI interrupt handler functions where printed messages can't always reach the console without an explicit push provided by printk_safe_flush_on_panic() and console_flush_on_panic(). This is the case