Re: [PATCH 2/4] platform/x86: wmi-bmof: Switch to sysfs_bin_attr_simple_read()

maybe you can just drop this patch? Thanks, Armin Wolf Signed-off-by: Thomas Weißschuh --- drivers/platform/x86/wmi-bmof.c | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/drivers/platform/x86/wmi-bmof.c b/drivers/platform/x86/wmi-bmof.c index

[PATCH 2/2] staging: fbtft: Fix line continuation

Fix checkpatch warning: avoid unnecessary line continuation to allow grepping of whole error message. Signed-off-by: Matthias Wolf Signed-off-by: Felix Siegel Signed-off-by: Tim Cofala --- drivers/staging/fbtft/fb_ssd1351.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff

[PATCH 1/2] staging: fbtft: Fix line over 80 characters

Fix checkpatch line over 80 characters where it seemed appropriate Signed-off-by: Matthias Wolf Signed-off-by: Felix Siegel Signed-off-by: Tim Cofala --- drivers/staging/fbtft/fb_s6d02a1.c | 30 -- 1 file changed, 20 insertions(+), 10 deletions(-) diff --git a

Re: [PATCH v3] staging: pi433: replace simple switch statements

Hi Dan, I'd like to mention once more, that the idea of the abstraction was to support multiple modules of Hope-RF. If the decision of the "team" of developer of this driver is, that it should be reduced to a Pi433 or RFM69CW driver only, I fully agree, that the abstraction layer isn't necessar

Re: [PATCH v3] staging: pi433: replace simple switch statements

Reviewed-by: Marcus Wolf Thank you Valentin, very nice patch :-) Valentin Vidic schrieb am 24.06.2018 18:31: Use const array to map switch cases to resulting values. Signed-off-by: Valentin Vidic --- v2: use correct type for const arrays v3: add missing static keyword for af_map drivers

Re: pi433: initialization of tx config in pi433_open()

Hi Hugo, thank you for all your work on Pi433 driver. For a better understanding some info about Pi433 and the ideas behind it. Pi433 was developed by me in order to have a simple to mount CE-compliant 433MHz shield for the Raspberry Pi. I wanted to put it on sale on the one side and develop a fu

Re: rf69_set_deviation in rf69.c (pi433 driver)

Hi Hugo, sorry for the late response and thank you for all that deep investigation in the pi433 driver! > According to the datasheet[0], the deviation should always be smaller > than 300kHz, and the following equation should be respected: > > (1) FDA + BRF/2 =< 500 kHz > > Why did you choose

Re: [PATCH v2] staging: pi433: cleanup tx_fifo locking

Reviewed-by: Marcus Wolf Am 19.04.2018 um 12:25 schrieb Valentin Vidic: > pi433_write requires locking due to multiple writers. After acquiring > the lock check if enough free space is available in the kfifo to write > the whole message. This check should prevent partial writes to tx_

Re: [PATCH] staging: pi433: add descriptions for mutex locks

Hi! So if you like, give me your address, and I'll send you two development samples of Pi433. Cheers, Marcus Am 19.04.2018 um 11:47 schrieb Valentin Vidic: > On Thu, Apr 19, 2018 at 11:25:19AM +0200, Marcus Wolf wrote: >> let me know, what you like to have. For sure with just o

Re: [PATCH] staging: pi433: add descriptions for mutex locks

Am 12.04.2018 um 20:46 schrieb Valentin Vidic: > On Sun, Apr 08, 2018 at 05:22:46PM +0200, Marcus Wolf wrote: >> Regarding your patch, I did not understand, why you did not remove >> the mutex_lock in pi433_write. Wasn't it the goal to remove it? > > Is it possible f

Re: [PATCH] staging: pi433: add descriptions for mutex locks

Am 12.04.2018 um 19:15 schrieb Valentin Vidic: > On Sun, Apr 08, 2018 at 04:15:30PM +0200, Marcus Wolf wrote: >> The hardware of Pi433 is working with every Raspberry Pi (on zero, you >> need to solder the GPIO-pins) and with several other fruits like banana >> pi. The on

Re: [PATCH] staging: pi433: add descriptions for mutex locks

dev, "write: generated new msg with %d bytes.", copied); return 0; } Hope this helps :-) Marcus Am 25.03.2018 um 15:09 schrieb Valentin Vidic: > On Sun, Mar 25, 2018 at 03:00:09PM +0200, Marcus Wolf wrote: >> Unfortunaly I can't find the time to have a closer lo

Re: [PATCH] staging: pi433: add descriptions for mutex locks

Am 25.03.2018 um 16:24 schrieb Valentin Vidic: > On Sun, Mar 25, 2018 at 03:12:52PM +0200, Marcus Wolf wrote: >> I am not at home the next two weeks. So I can do a codereading on >> Easter, but testing will not take place earlier then mid/end of April :-( >> >> I

Re: [PATCH] staging: pi433: add descriptions for mutex locks

On Sun, Mar 25, 2018 at 03:00:09PM +0200, Marcus Wolf wrote: >> Unfortunaly I can't find the time to have a closer look on the code this >> weekend - still busy with tax stuff :-( >> >> Idea sounds great. I'll try to look at the code and think about it >> duri

Re: [PATCH] staging: pi433: add descriptions for mutex locks

about it during Easter hollidays. Cheers, Marcus -- Smarthome-Wolf UG (haftungsbeschränkt) Helene-Lange-Weg 23 80637 München Amtsgericht München, HRB 223529 Umastzsteuer-ID: DE304719911 Geschäftsführer: Marcus Wolf

Re: [PATCH] staging: pi433: add descriptions for mutex locks

AM +0100, Marcus Wolf wrote: >> could you please decribe in short words, why you think, that hte lock >> isn't obsolete? >> >> I wasn't sure, but close to remove the lock. That's why I putted the >> comment. > > Sure, if pi433_tx_thread runs on one

Re: [PATCH] staging: pi433: add descriptions for mutex locks

intrx_position; > - struct mutexrx_lock; > + struct mutexrx_lock; /* serialize read requests */ > wait_queue_head_t rx_wait_queue; > > /* fifo wait queue */ > -- Smarthome-Wolf UG (haftungsbeschränkt) Helene-Lange-Weg 23 80637 München Amtsgericht München, HRB 223529 Umastzsteuer-ID: DE304719911 Geschäftsführer: Marcus Wolf

Re: [PATCH] staging: pi433: remove unnecessary parentheses

Joe Perches schrieb am 10.01.2018 10:05: > On Wed, 2018-01-10 at 09:44 +0100, Greg Kroah-Hartman wrote: > > On Tue, Jan 09, 2018 at 11:42:16AM -0800, Joe Perches wrote: > > > if (a == b && c == d) > > > is pretty trivial. > > > > But again, don't do that. > > We disagree. Life goes on. > > cheer

[PATCH] Staging: Pi433: Bugfix for wrong argument for sizeof() in TX thread

sizeof(array) != sizeof(pointer to array) Fixes: "staging: pi433: reduce stack size in tx thread" Signed-off-by: Marcus Wolf --- drivers/staging/pi433/pi433_if.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/staging/pi433/pi433_if.c

Re: [PATCH 6/6] staging: pi433: Rename enum modShaping in rf69_enum.h

Am 04.12.2017 um 21:18 schrieb Dan Carpenter: On Mon, Dec 04, 2017 at 08:59:35PM +0200, Marcus Wolf wrote: Am 04.12.2017 um 12:33 schrieb Dan Carpenter: On Sun, Dec 03, 2017 at 04:17:26PM +0100, Simon Sandström wrote: diff --git a/drivers/staging/pi433/pi433_if.h b/drivers/staging/pi433

rf69_get_lna_gain

Hi! This is an information for all of you, doing experiments with real hardware! I wanted to explain, what this lna_gain stuff is used for: If you are receiving messages from different sender (let's say several thermometers), it may happen (e. g. due to different distance and different batter

Re: [PATCH 6/8 v3] staging: pi433: use defines for shifting register values

Am 13.12.2017 um 19:44 schrieb Valentin Vidic: Avoid shifting by magic numbers and use defines instead. Signed-off-by: Valentin Vidic --- v2: - drop change for SHIFT_DATAMODUL_MODULATION_TYPE - move shifting to the header file v3: - drop auto case - use CURRENT suffix - precomp

Re: [PATCH 6/8 v2] staging: pi433: use defines for shifting register values

Am 13.12.2017 um 18:55 schrieb Valentin Vidic: Avoid shifting by magic numbers and use defines instead. Signed-off-by: Valentin Vidic --- v2: - drop change for SHIFT_DATAMODUL_MODULATION_TYPE - move shifting to the header file drivers/staging/pi433/rf69.c | 16 --

Re: [PATCH 6/8] staging: pi433: use defines for shifting register values

_GAIN0x07 +#define SHIFT_LNA_CURRENT_GAIN3 #define LNA_GAIN_AUTO0x00 /* default */ #define LNA_GAIN_MAX 0x01 -- Smarthome-Wolf UG (haftungsbeschränkt) Helene-Lange-Weg 23 80637 München Amtsgericht München, HRB 223529 Umastzsteuer-ID: DE304719911 Geschäftsführer: Marcus Wolf

Re: [PATCH 4/8] staging: pi433: add parentheses to mask and shift

N_AUTO: return automatic; case LNA_GAIN_MAX: return max; case LNA_GAIN_MAX_MINUS_6: return maxMinus6; -- Smarthome-Wolf UG (haftungsbeschränkt) Helene-Lange-Weg 23 80637 München Amtsgericht München, HRB 223529 Umastzsteuer-ID: DE304719911 Geschäftsführer: Marcus Wolf

staging: pi433: Plans from Smarthome-Wolf

Am 06.12.2017 um 14:47 schrieb Dan Carpenter: > On Wed, Dec 06, 2017 at 11:11:27AM +0200, Marcus Wolf wrote: >> >> Since the rule for kernel development seems to be, not to care about future, >> most probably you patch is fine, anyway. >> > > Yeah. Deleting cod

Re: [PATCH 5/6] staging: pi433: Move enum option_on_off to pi433_if.h

Am 06.12.2017 um 22:42 schrieb Simon Sandström: The enum is now only used for ioctl, so move it pi433_if.h. Signed-off-by: Simon Sandström --- drivers/staging/pi433/pi433_if.h | 5 + drivers/staging/pi433/rf69_enum.h | 5 - 2 files changed, 5 insertions(+), 5 deletions(-) diff -

Re: [PATCH v2 04/11] staging: pi433: Rename enum optionOnOff in rf69_enum.h

Am 06.12.2017 um 21:57 schrieb Simon Sandström: On Wed, Dec 06, 2017 at 01:44:14PM +0300, Dan Carpenter wrote: On Wed, Dec 06, 2017 at 12:31:31PM +0200, Marcus Wolf wrote: Am 06.12.2017 um 12:23 schrieb Dan Carpenter: Wow... This was the one patch I thought was going to sink this

Re: [PATCH v2 04/11] staging: pi433: Rename enum optionOnOff in rf69_enum.h

er is new (mainline for just something like 2 monthes) and stil under devel, I think we should "risk" it. Gruß, Marcus > Am 06.12.2017 um 11:44 schrieb Dan Carpenter : > >> On Wed, Dec 06, 2017 at 12:31:31PM +0200, Marcus Wolf wrote: >> >> >>> Am 06.12

Re: [PATCH v2 06/11] staging: pi433: Split rf69_set_crc_enabled into two functions

>> >> rf69 -set/get - action >> -> rf69_set_crc_enable > > No... Simon's name is better. His is shorter and makes more sense. I disagree. If I am going to implement a new functionality and need to think about the naming of the function name, every time I need to change a register setting th

Re: [PATCH v2 04/11] staging: pi433: Rename enum optionOnOff in rf69_enum.h

Am 06.12.2017 um 12:23 schrieb Dan Carpenter: On Wed, Dec 06, 2017 at 11:46:41AM +0200, Marcus Wolf wrote: diff --git a/drivers/staging/pi433/rf69_enum.h b/drivers/staging/pi433/rf69_enum.h index babe597e2ec6..5247e9269de9 100644 --- a/drivers/staging/pi433/rf69_enum.h +++ b/drivers/staging

Re: [PATCH v2 06/11] staging: pi433: Split rf69_set_crc_enabled into two functions

Am 06.12.2017 um 11:37 schrieb Dan Carpenter: On Wed, Dec 06, 2017 at 11:05:22AM +0200, Marcus Wolf wrote: Am 06.12.2017 um 00:08 schrieb Simon Sandström: Splits rf69_set_crc_enabled(dev, enabled) into rf69_enable_crc(dev) and rf69_disable_crc(dev). Signed-off-by: Simon Sandström

Re: [PATCH] staging: pi433: Fixes issue with bit shift in rf69_get_modulation

Am 06.12.2017 um 11:02 schrieb Greg KH: On Wed, Nov 08, 2017 at 07:13:56PM +0200, Marcus Wolf wrote: Fixes issue with bit shift in rf69_get_modulation What "issue"? Signed-off-by: Marcus Wolf --- drivers/staging/pi433/rf69.c |2 +- 1 file changed, 1 insertion(+),

Re: [PATCH v2 04/11] staging: pi433: Rename enum optionOnOff in rf69_enum.h

Am 06.12.2017 um 00:08 schrieb Simon Sandström: Renames the enum optionOnOff and its values optionOn, optionOff to enum option_on_off and OPTION_ON, OPTION_OFF. Fixes checkpatch.pl warnings: "Avoid CamelCase: , , ". Signed-off-by: Simon Sandström --- drivers/staging/pi433/pi433_if.c | 34 +

Re: [PATCH v2 09/11] staging: pi433: Combine all rf69_set_amplifier_x()

Am 06.12.2017 um 00:08 schrieb Simon Sandström: Replaces the functions rf69_set_amplifier_1, _2, _3 with two functions: rf69_enable_amplifier(dev, amp_mask) and rf69_disable_amplifier(dev, amp_mask). Signed-off-by: Simon Sandström --- drivers/staging/pi433/pi433_if.c | 6 +++--- drivers/s

Re: [PATCH v2 08/11] staging: pi433: Remove enum data_mode

Am 06.12.2017 um 00:08 schrieb Simon Sandström: Call rf69_set_data_mode with DATAMODUL_MODE value directly. Signed-off-by: Simon Sandström --- drivers/staging/pi433/pi433_if.c | 2 +- drivers/staging/pi433/rf69.c | 15 ++- drivers/staging/pi433/rf69.h | 2 +- dri

Re: [PATCH v2 06/11] staging: pi433: Split rf69_set_crc_enabled into two functions

Am 06.12.2017 um 00:08 schrieb Simon Sandström: Splits rf69_set_crc_enabled(dev, enabled) into rf69_enable_crc(dev) and rf69_disable_crc(dev). Signed-off-by: Simon Sandström --- drivers/staging/pi433/pi433_if.c | 22 -- drivers/staging/pi433/rf69.c | 18 ++--

Re: [PATCH 4/6] staging: pi433: Rename enum optionOnOff in rf69_enum.h

Am 05.12.2017 um 13:16 schrieb Dan Carpenter: > On Mon, Dec 04, 2017 at 09:59:02PM +0200, Marcus Wolf wrote: >> Keep in mind, that if you split the functions, in the interface >> implementation you also need more code: >> >> SET_CHECKED(rf69_set_sync_enable(de

Re: [PATCH 4/6] staging: pi433: Rename enum optionOnOff in rf69_enum.h

Am 04.12.2017 um 21:05 schrieb Simon Sandström: > On Mon, Dec 04, 2017 at 09:59:02PM +0200, Marcus Wolf wrote: >> >> Hi Simon, hi Dan, >> >> if you both are of the same opinion, for me, it's fine, if we go with two >> functions. >> >> But

[PATCH V3] staging: pi433: rf69.c: Replace macros READ_REG and WRITE_REG with smarter functions

x27;t introduced by this patch, but were long and camel cased before. Signed-off-by: Marcus Wolf --- drivers/staging/pi433/rf69.c | 336 ++ 1 file changed, 180 insertions(+), 156 deletions(-) diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/

[PATCH V2] staging: pi433: rf69.c: Replace macros READ_REG and WRITE_REG with inline functions rf69_set_bit, rf69_reset_bit and rf69_read_modify_write

x27;t introduced by this patch, but were long and camel cased before. Signed-off-by: Marcus Wolf --- drivers/staging/pi433/rf69.c | 336 ++ 1 file changed, 180 insertions(+), 156 deletions(-) diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/

Re: [PATCH 5/6] staging: pi433: Rename enum dataMode in rf69_enum.h

Am 04.12.2017 um 21:56 schrieb Dan Carpenter: On Mon, Dec 04, 2017 at 09:31:06PM +0200, Marcus Wolf wrote: Then it might be, that DATAMODUL_MODE_PACKET might need an other value. That's future code so we can delete that sentence for now. With the rule above, you are absolutely right

Re: [PATCH 4/6] staging: pi433: Rename enum optionOnOff in rf69_enum.h

Am 04.12.2017 um 21:42 schrieb Simon Sandström: On Mon, Dec 04, 2017 at 09:22:06PM +0200, Marcus Wolf wrote: Am 04.12.2017 um 21:15 schrieb Dan Carpenter: That's a bad name, because it doesn't just enable it also disables. Please split them. regards, dan carpenter Same appl

Re: [PATCH 6/6] staging: pi433: Rename enum modShaping in rf69_enum.h

Am 04.12.2017 um 21:18 schrieb Dan Carpenter: On Mon, Dec 04, 2017 at 08:59:35PM +0200, Marcus Wolf wrote: Am 04.12.2017 um 12:33 schrieb Dan Carpenter: On Sun, Dec 03, 2017 at 04:17:26PM +0100, Simon Sandström wrote: diff --git a/drivers/staging/pi433/pi433_if.h b/drivers/staging/pi433

Re: [PATCH 5/6] staging: pi433: Rename enum dataMode in rf69_enum.h

Second there might be the idea of supporting different chips in the future (I already thought about). Linux style is never to write code for the future. Ok. I didn't know. To be honest, I already started writing code, also supporting the rf12 some time ago, thus programming a rfxx.c, but neve

Re: [PATCH 4/6] staging: pi433: Rename enum optionOnOff in rf69_enum.h

Am 04.12.2017 um 21:15 schrieb Dan Carpenter: On Mon, Dec 04, 2017 at 08:37:51PM +0200, Marcus Wolf wrote: Am 04.12.2017 um 12:37 schrieb Dan Carpenter: On Mon, Dec 04, 2017 at 01:17:37PM +0300, Dan Carpenter wrote: Perhaps choose different function names if you want? You could do it as

Re: [PATCH 5/6] staging: pi433: Rename enum dataMode in rf69_enum.h

Am 04.12.2017 um 12:24 schrieb Dan Carpenter: On Sun, Dec 03, 2017 at 04:17:25PM +0100, Simon Sandström wrote: Renames enum dataMode and its values packet, continuous, continuousNoSync to enum data_mode and PACKET, CONTINUOUS, CONTINUOUS_NO_SYNC. Fixes checkpatch.pl warnings: "Avoid CamelCase:

Re: [PATCH 6/6] staging: pi433: Rename enum modShaping in rf69_enum.h

Am 04.12.2017 um 12:33 schrieb Dan Carpenter: On Sun, Dec 03, 2017 at 04:17:26PM +0100, Simon Sandström wrote: diff --git a/drivers/staging/pi433/pi433_if.h b/drivers/staging/pi433/pi433_if.h index 34ff0d4807bd..bcfe29840889 100644 --- a/drivers/staging/pi433/pi433_if.h +++ b/drivers/staging/pi

Re: [PATCH 4/6] staging: pi433: Rename enum optionOnOff in rf69_enum.h

Am 04.12.2017 um 12:37 schrieb Dan Carpenter: On Mon, Dec 04, 2017 at 01:17:37PM +0300, Dan Carpenter wrote: Perhaps choose different function names if you want? You could do it as several patches: patch 1: change types to bool patch 2: sed -e '/ == optionOn//' patch 3: split the functions i

[PATCH] staging: pi433: rf69.c: Replace macros READ_REG and WRITE_REG with inline functions rf69_set_bit, rf69_reset_bit and rf69_read_modify_write

. Signed-off-by: Marcus Wolf --- drivers/staging/pi433/rf69.c | 340 ++ 1 file changed, 182 insertions(+), 158 deletions(-) diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c index e69a215..8a31ed7 100644 --- a/drivers/staging/pi433

Re: [PATCH 4/6] staging: pi433: Rename enum optionOnOff in rf69_enum.h

Am 03.12.2017 um 17:17 schrieb Simon Sandström: Renames the enum optionOnOff and its values optionOn, optionOff to enum option_on_off and OPTION_ON, OPTION_OFF. Fixes checkpatch.pl warnings: "Avoid CamelCase: , , ". Signed-off-by: Simon Sandström --- drivers/staging/pi433/pi433_if.c | 34 +

Re: [PATCH] staging: pi433: Make rf69_set_dc_cut_off_frequency_intern static

Am 02.12.2017 um 18:46 schrieb Joe Perches: On Sat, 2017-12-02 at 17:20 +0200, Marcus Wolf wrote: rf69_set_dc_cut_off_frequency_intern is used by rf69.c internally only. Therefore removed the function from header and declared it staic in the implemtation. Signed-off-by: Marcus Wolf

Re: [PATCH] staging: pi433: rf69.c: Introduced define DEBUG_FUNC_ENTRY

Am 02.12.2017 um 17:00 schrieb Greg KH: On Sat, Dec 02, 2017 at 01:45:50PM +0200, Marcus Wolf wrote: Since dev_dbg already depends on define DEBUG, there was no sense, to enclose dev_dbg lines with #ifdef DEBUG. Instead of removing #ifdef DEBUG, I introduced define DEBUG_FUNC_ENTRY. So now it

Re: [PATCH] staging: pi433: Removed some obsolete or duplicated defines; moved two defines to better locations

annoying thing in e-mail? A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Sat, Dec 02, 2017 at 06:00:28PM +0200, Marcus Wolf wrote: Hi Greg, for me the action was "clean up the defines in rf69.c". So for me it was fine, that two defines were

Re: [PATCH] staging: pi433: Make rf69_set_dc_cut_off_frequency_intern static

Hi! I am sorry :-/ Can you recover, or do I need to resend? Cheers, Marcus Am 02.12.2017 um 17:56 schrieb Greg KH: On Sat, Dec 02, 2017 at 05:20:22PM +0200, Marcus Wolf wrote: rf69_set_dc_cut_off_frequency_intern is used by rf69.c internally only. Therefore removed the function from header

Re: [PATCH] staging: pi433: Removed some obsolete or duplicated defines; moved two defines to better locations

2, 2017 at 05:14:08PM +0200, Marcus Wolf wrote: The define FIFO_SIZE was moved to rf69_registers.h. Although it is not a register, it is a value, that is given by hardware (like the registers). The define FIFO_THRESHOLD was moved to pi433_if.c, since it is a value, that is freely choosen by the

[PATCH] staging: pi433: Style fix - spaces required

Leftover changes from patch [PATCH 2/5] staging: pi433: rf69.c style fix - spaces required around from Marcin Ciupak (11.10.2017) Signed-of-by: Marcus Wolf --- drivers/staging/pi433/rf69.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/pi433/rf69.c b

Re: [PATCH 4/5] staging: pi433: rf69.c style fix - code indent should use tabs

Revieved-by: Marcus Wolf Am 11.10.2017 um 21:24 schrieb Marcin Ciupak: This patch fixes the following checkpatch.pl error: ERROR: code indent should use tabs where possible in rf69.c file as requested by TODO file. Additionally some style warnings remain valid here and could be fixed by

[PATCH] staging: pi433: Make rf69_set_dc_cut_off_frequency_intern static

rf69_set_dc_cut_off_frequency_intern is used by rf69.c internally only. Therefore removed the function from header and declared it staic in the implemtation. Signed-off-by: Marcus Wolf --- drivers/staging/pi433/rf69.c |2 +- drivers/staging/pi433/rf69.h |1 - 2 files changed, 1 insertion

[PATCH] staging: pi433: Removed some obsolete or duplicated defines; moved two defines to better locations

response time of the driver, the lower threshold can be set. Signed-off-by: Marcus Wolf --- drivers/staging/pi433/pi433_if.c |1 + drivers/staging/pi433/rf69.c |1 - drivers/staging/pi433/rf69.h |5 - drivers/staging/pi433/rf69_registers.h |5 + 4 files

[PATCH] staging: pi433: rf69.c: Replace macros READ_REG and WRITE_REG with inline functions setBit rstBit and rmwBit

To increase the readability of the register accesses, the abstraction of the helpers was increased from simple read and write to set bit, reset bit and read modify write bit. In addition - according to the proposal from Walter Harms from 20.07.2017 - instead of marcros inline functions were used.

[PATCH] staging: pi433: rf69.c: Introduced define DEBUG_FUNC_ENTRY

: Marcus Wolf --- drivers/staging/pi433/rf69.c | 118 +- 1 file changed, 58 insertions(+), 60 deletions(-) diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c index 12c9df9..0df084e 100644 --- a/drivers/staging/pi433/rf69.c +++ b

[PATCH] staging: pi433: Bugfix for shift operation in rf69_get_modulation()

Defines used in cases contain already shifted bits, so currentValue must not be shifted. Signed-off-by: Marcus Wolf --- drivers/staging/pi433/rf69.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c index e69a215

[PATCH] staging: pi433: Bugfix for shift operation in rf69_get_modulation()

Defines used in cases contain already shifted bits, so currentValue must not be shifted. signed_of_by: Marcus Wolf --- drivers/staging/pi433/rf69.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c index e69a215

Re: [PATCH] staging: pi433: Bugfix for shift operation in rf69_get_modulation()

to prevent the From: line? Should I resend the patch? Thanks, Marcus Am 02.12.2017 um 12:06 schrieb Greg KH: On Sat, Dec 02, 2017 at 11:58:12AM +0200, Marcus Wolf wrote: From: root I think something went wrong here :) Also, you should never need to do kernel development as root...

[PATCH] staging: pi433: Bugfix for shift operation in rf69_get_modulation()

From: root Defines used in cases contain already shifted bits, so currentValue must not be shifted. Signed-off-by: Marcus Wolf --- drivers/staging/pi433/rf69.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c

Re: staging: pi433: Possible bug in rf69.c

Wolf wrote: Hi everybody! Just comparing the master of Gregs statging of pi433 with my local SVN to review all changes, that were done the last monthes. I am not sure, but maybe we imported a bug in rf69.c lines 378 and following: Gregs repo: case automatic: return WRITE_REG(REG_LNA

Re: staging: pi433: Possible bug in rf69.c

Hi Greg, ok. I'll postpone all my work until then. Give me a hook, when I can start :-) Thanks, Marcus Am 11.11.2017 um 13:49 schrieb Greg Kroah-Hartman: On Sat, Nov 11, 2017 at 01:42:27PM +0200, Marcus Wolf wrote: Hi Greg, that's fine. Is this the right URL: git://git.kern

Re: staging: pi433: Possible bug in rf69.c

2017 at 11:42:09AM +0200, Marcus Wolf wrote: Hi Dan, thanks fot the link. I can't remeber, why and what I wanted to redo. Maybe there was a complaint about the format of the patch... In that patch, we also have the topic with the '>> 3', we were discussing a few days ago!

Re: staging: pi433: Possible bug in rf69.c

Cheers, Marcus Am 11.11.2017 um 10:45 schrieb Dan Carpenter: On Sat, Nov 11, 2017 at 08:55:30AM +0100, Marcus Wolf wrote: Hi Dan, I checked it on my local SVN. You are right. I submitted the code with '&'. Accodring to a check-in message on my SVN, there was a bugreport end

Re: staging: pi433: Possible bug in rf69.c

x-next? Sorry for not being familiar with that stuff! Thanks a lot, Marcus Am 10.11.2017 um 20:32 schrieb Dan Carpenter: > On Fri, Nov 10, 2017 at 06:23:32PM +0100, Marcus Wolf wrote: >> Hi everybody! >> >> Just comparing the master of Gregs statging of pi433 with my local SVN &

staging: pi433: Possible bug in rf69.c

Hi everybody! Just comparing the master of Gregs statging of pi433 with my local SVN to review all changes, that were done the last monthes. I am not sure, but maybe we imported a bug in rf69.c lines 378 and following: Gregs repo: case automatic: return WRITE_REG(REG_LNA, ( (READ_REG(RE

Re: [PATCH] staging: pi433: fix missing break in switch statement.

On 10/11/17 16:49, Marcus Wolf wrote: >> Hi all! >> >> Tryed to cross check... >> >> Don't get it, sorry. >> >> On my private version control (my SVN), where I initially developed the >> driver the break isn't missing. >> Same with my

Re: [PATCH] staging: pi433: fix missing break in switch statement.

rking on a wrong version? marcus@Laptop-Wolf:~/staging/drivers/staging/pi433$ git remote show origin * remote origin Fetch URL: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git Push URL: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git Can anybody help m

[PATCH] Fixes issue with bit shift in rf69_get_modulation

Fixes issue with bit shift in rf69_get_modulation Signed-off-by: Marcus Wolf --- drivers/staging/pi433/rf69.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c index 290b419..c945b4b 100644 --- a/drivers/staging

Re: [PATCH] staging: pi433: #define shift constants in rf69.c

Hello everybody! Concerning the naming: == When writing the rf69.c it wasn't intended to write a driver for Linux. This file was written at a time, where the complete controlling of Pi433 was implemented in the application. Therefore it is written in a completely different

Re: [PATCH v2 1/4] staging: pi433: Style fix - Correct long lines

Hi everybody, from my point of view, we should stay with the old implementation. Ok - line is too long according to style guide. But these long lines are IMHO easy to read: All four are pretty similar. By having all Tokens in exact the same length and having one below other, you can easily dete

Re: [PATCH] staging: pi433: style fix - space after asterisk

Reviewed-by: Marcus Wolf Thank you Marcin! > Marcin Ciupak hat am 8. August 2017 um 15:54 > geschrieben: > > > This patch is intended to fix coding style issues in order to comply > with kernel coding style guide as requested by TODO file. > > It fixes the follo

Re: [PATCH] staging: pi433: remove some macros, introduce some inline functions

per patch. And I totally get that redoing > patches sucks... Sorry. > > On Wed, Aug 02, 2017 at 01:10:14PM +0200, Wolf Entwicklungen wrote: > > According to the proposal of Walter Harms, I removed some macros > > and added some inline functions. > > > > Since I used a

[PATCH] staging: pi433: remove some macros, introduce some inline functions

From: Marcus Wolf According to the proposal of Walter Harms, I removed some macros and added some inline functions. Since I used a bit more intelligent interface, this enhances readability and reduces problems with checkpatch.pl at the same time. In addition obsolete debug ifdefs were removed

Re: [PATCH] staging: pi433: remove some macros, introduce some inline functions

(my patch, concerning the bit shifting, we talked about last week and an other patch fixing an issue with a bit inversion). Hope it helps :-) Marcus Am Mi, 2.08.2017, 13:10 schrieb Wolf Entwicklungen: > According to the proposal of Walter Harms, I removed some macros > and added some

[PATCH] staging: pi433: remove some macros, introduce some inline functions

: Marcus Wolf --- drivers/staging/pi433/rf69.c | 544 ++ 1 file changed, 238 insertions(+), 306 deletions(-) diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c --- a/drivers/staging/pi433/rf69.c +++ b/drivers/staging/pi433/rf69.c @@ -28,33

Re: [PATCH 1/5] staging/pi433:Removed Coding style issues from pi433_if.h and other dependencies arising from it.

Hi Dan, I offered Greg to have an eye on the patches, that were submitted. He asked me to reply to those patches, I had a look for, with the Reviewed-by tag. Now I am a bit unsure, what I should do. Since I am interested in, I for sure will read every patch. It's just a little thing, to reply wi

Re: [PATCH 1/5] staging/pi433:Removed Coding style issues from pi433_if.h and other dependencies arising from it.

en: > > > On Wed, Aug 02, 2017 at 10:08:04AM +0200, Wolf Entwicklungen wrote: > > Reviewed-by: Marcus Wolf > > > > Just reviewed, not tested. > > As far as I can see, there is no technical issue with this patch. > > You need to be a bit more strict in your rev

Re: [PATCH] staging: pi433: reduce stack size in tx thread

Reviewed-by: Marcus Wolf Maybe tx_buffer is a bit more clearly then buffer. Thanks, Marcus Am Mo, 31.07.2017, 10:57 schrieb Arnd Bergmann: > Putting a 900 byte array on the stack is a clearly too much in the > kernel, and sometimes results in warnings like: > > drivers/s

Re: [PATCH] staging/pi433: Solved some coding style issues in pi433_if.c

Reviewed-by: Marcus Wolf Thank you :-) Am Di, 1.08.2017, 07:09 schrieb Rishabh Hardas: > From: Rishabh Hardas > > Solved a few coding style issues, used BIT macro to set MINORBITS. > > Signed-off-by: Rishabh Hardas > --- > drivers/staging/pi433/pi433_if.c | 24

Re: [PATCH 5/5] staging/pi433/rf69_enum.h:Removed Coding style issues from pi433_if.h and other dependencies arising from it.

Reviewed-by: Marcus Wolf Am Di, 1.08.2017, 21:31 schrieb Rishabh Hardas: > Signed-off-by: Rishabh Hardas > --- > drivers/staging/pi433/rf69_enum.h | 16 > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/staging/pi433/rf69_enum.h &

Re: [PATCH 4/5] staging/pi433/rf69.c:Removed Coding style issues from pi433_if.h and other dependencies arising from it.

Reviewed-by: Marcus Wolf Maybe lnaGain should move to lna_gain instead of lnagain (also applies to the headers...) Marcus Am Di, 1.08.2017, 21:31 schrieb Rishabh Hardas: > Signed-off-by: Rishabh Hardas > --- > drivers/staging/pi433/rf69.c | 26 +- > 1

Re: [PATCH 1/5] staging/pi433:Removed Coding style issues from pi433_if.h and other dependencies arising from it.

Reviewed-by: Marcus Wolf Just reviewed, not tested. As far as I can see, there is no technical issue with this patch. I prefer the names of the enumerations in camel case, because then they are a bit shorter. If camel case is unwanted, for sure we need that change. Please mind the allignment

Re: [PATCH 3/5] staging/pi433/rf69.h:Removed Coding style issues from pi433_if.h and other dependencies arising from it.

Reviewed-by: Marcus Wolf Am Di, 1.08.2017, 21:31 schrieb Rishabh Hardas: > Signed-off-by: Rishabh Hardas > --- > drivers/staging/pi433/rf69.h | 26 +- > 1 file changed, 13 insertions(+), 13 deletions(-) > > diff --git a/drivers/staging/pi433/rf69.h

Re: [PATCH 2/5] staging/pi433/pi433_if.c:Removed Coding style issues from pi433_if.h and other dependencies arising from it.

Reviewed-by: Marcus Wolf Am Di, 1.08.2017, 21:31 schrieb Rishabh Hardas: > Signed-off-by: Rishabh Hardas > --- > drivers/staging/pi433/pi433_if.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/pi433/pi433_if.c > b/drivers/sta

Re: [PATCH] staging/pi433: Solved some coding style issues in pi433_if.c

Reviewed-by: Marcus Wolf Thank you Rishabh! Marcus Am Mo, 31.07.2017, 12:21 schrieb RishabhHardas: > From: RishabhHardas > > Solved a few coding style issues, used BIT macro to set MINORBITS. > > Signed-off-by: RishabhHardas > --- > drivers/staging/

Re: [PATCH 1/1] staging: pi433: fix problem with division in rf69_set_deviation

change in rf69.c I will try to equip an SVN-diff with apropriate headers next week, so Dan can crosscheck with his work - I hope, I will make it without errors... Have a nice weekend, Marcus > Greg KH hat am 30. Juli 2017 um 00:21 > geschrieben: > > > On Sat, Jul 29, 2017 at 10:5

Re: [PATCH 1/1][staging-next] staging: pi433: Make functions rf69_set_dc_cut_off_frequency_intern static

Hi Greg, also had a very close look to this patch. Even in your reply I can't find any problems with line wraps or other corruptions :-/ But we have alternative patches, solving these problems as well. You e.g. could use the patch [PATCH] Make functions rf69_set_bandwidth_intern and rf69_set_dc_

Re: [PATCH 1/1] staging: pi433: fix problem with division in rf69_set_deviation

0, 2017 at 05:56:36PM +0200, Marcus Wolf wrote: > > Fixes problem with division in rf69_set_deviation > > > > Fixes: 874bcba65f9a ("staging: pi433: New driver") > > Signed-off-by: Marcus Wolf > > > > diff --git a/drivers/staging/pi433/rf69.c b/driv

Send a large patch right now or is it better to do it later?

Hi Greg, according to the proposals of Walter Harms, I revised the rf69.c: I replaced some macros with inline functions and removed some obsolete ifdefs. According to walter this will improve the resource situation. In addition the readybility is enhanced, since lines got shorter. It's a quite bi

Re: [PATCH] staging: pi433: use div_u64 for 64-bit division

l adresses and several mailboxes from one provider to another within the next two monthes). Sorry for any inconvenience, Marcus > Dan Carpenter hat am 28. Juli 2017 um 16:26 > geschrieben: > > > On Fri, Jul 28, 2017 at 04:21:05PM +0200, Marcus Wolf wrote: > > Hi Arnd, >

Re: [PATCH] staging: pi433: use div_u64 for 64-bit division

Hi Arnd, we already have a patch for this: [PATCH 1/1] staging: pi433: fix problem with division in rf69_set_deviation from 20.07.2017 Maybe I did something wrong, but my first solution was exactly like your proposal. As far as I remeber, I wasn't able to compile it that way. Therefore I made a

Re: [PATCH] staging: pi433: fix Kconfig entry

Reviewed-by: Marcus Wolf This is similar to patch "[PATCH -next] staging: pi433: depends on SPI" of Randy Dunlap > Arnd Bergmann hat am 25. Juli 2017 um 17:38 geschrieben: > > > I ran into a build error with the new pi433 driver and > CONFIG_SPI disabled: > > d

Re: [PATCH 1/3] staging: pi433: Style fix - align block comments

Hi Dan, when I started with the RFM69CW about two years ago (at the beginning not as a driver, but everything within the applicaton) I kind of automatically produced a list of all registers of the chip (most probably by importing and reorganizing the datasheet in Excel). Everytime I need to touch

  1   2   >