Re: [PATCH v3] mac80211: aead api to reduce redundancy

2017-10-11 Thread Xiang Gao
Great ! Thanks ! Xiang Gao 2017-10-11 3:48 GMT-04:00 Johannes Berg : > On Tue, 2017-10-10 at 22:31 -0400, Xiang Gao wrote: >> Currently, the aes_ccm.c and aes_gcm.c are almost line by line copy >> of >> each other. This patch reduce code redundancy by moving the code in >

[PATCH v3] mac80211: aead api to reduce redundancy

2017-10-10 Thread Xiang Gao
implemented in their headers using the newly added aead api. Signed-off-by: Xiang Gao --- net/mac80211/Makefile | 3 +- net/mac80211/{aes_ccm.c => aead_api.c} | 40 ++-- net/mac80211/aead_api.h| 27 net/mac80211/aes_ccm.h |

Re: [PATCH] mac80211: aead api to reduce redundancy

2017-10-10 Thread Xiang Gao
2017-10-09 3:09 GMT-04:00 Johannes Berg : > On Sun, 2017-10-08 at 01:43 -0400, Xiang Gao wrote: >> >> By the way, I'm still struggling on how to run unit tests. It might >> take time for me to make it run on my machine. > > I can run it easily, so don't worr

Re: [PATCH] mac80211: aead api to reduce redundancy

2017-10-07 Thread Xiang Gao
Hi Johannes, Thanks for your time on reviewing this. I will make changes following your review. See details below. By the way, I'm still struggling on how to run unit tests. It might take time for me to make it run on my machine. 2017-10-02 8:04 GMT-04:00 Johannes Berg : > Please use "v2" tag or

Re: [lkp-robot] [mac80211] 31e9170bde: hwsim.sta_dynamic_down_up.fail

2017-09-28 Thread Xiang Gao
Thanks, I will look into it. Xiang Gao 2017-09-28 4:06 GMT-04:00 kernel test robot : > > FYI, we noticed the following commit: > > commit: 31e9170bdeb6ebe66426337b4e2b9924683a412b ("mac80211: aead api to > reduce redundancy") > url: > https://github.com/0day-ci/l

[PATCH] mac80211: aead api to reduce redundancy

2017-09-26 Thread Xiang Gao
implemented in their headers using the newly added aead api. Signed-off-by: Xiang Gao --- net/mac80211/Makefile | 3 +- net/mac80211/{aes_gcm.c => aead_api.c} | 49 +++--- net/mac80211/aead_api.h| 26 net/mac80211/aes_ccm.c |

Re: [PATCH] mac80211: aead api to reduce redundancy

2017-09-24 Thread Xiang Gao
2017-09-24 13:42 GMT-04:00 Johannes Berg : > On Sun, 2017-09-24 at 13:21 -0400, Xiang Gao wrote: >> >> Do you mean to put more characters each line in the description >> > Huh, sorry, no - my bad. I was thinking of the code, not the > description at all. Oh yes, thes

Re: [PATCH] mac80211: aead api to reduce redundancy

2017-09-24 Thread Xiang Gao
2017-09-24 11:05 GMT-04:00 Johannes Berg : > On Sun, 2017-09-24 at 01:40 -0400, Xiang Gao wrote: >> Currently, the aes_ccm.c and aes_gcm.c are almost line by line >> copy of each other. This patch reduce code redundancy by moving >> the code in these two files to crypto/ae

[PATCH] mac80211: aead api to reduce redundancy

2017-09-23 Thread Xiang Gao
their headers using the newly added aead api. Signed-off-by: Xiang Gao --- crypto/Makefile | 2 +- net/mac80211/aes_gcm.c => crypto/aead_api.c | 53 +++-- include/crypto/aead_api.h | 21 + net/mac80211/Makef