Re: [PATCH] memory tier: rename destroy_memory_type() to put_memory_type()

2023-07-06 Thread Xiao Yang
he, I didn't find that destroy_memory_type(memtype) is called here on mainline kernel. Did I miss something? Other than that, it looks good to me. Reviewed-by: Xiao Yang Best Regards, Xiao Yang } mutex_unlock(_tier_lock); }

Re: [PATCH] xfs/XXX: Add xfs/XXX

2020-06-02 Thread Xiao Yang
On 2020/6/3 2:14, Darrick J. Wong wrote: On Tue, Jun 02, 2020 at 04:51:48PM +0800, Xiao Yang wrote: On 2020/4/14 0:30, Darrick J. Wong wrote: This might be a good time to introduce a few new helpers: _require_scratch_dax ("Does $SCRATCH_DEV support DAX?") _require_scratch_dax_mount

Re: [PATCH] xfs/XXX: Add xfs/XXX

2020-06-02 Thread Xiao Yang
x implementation? 2) I think _require_xfs_io_command "chattr" "x" is enough to check if fs supports FS_XFLAG_DAX. Is it necessary to add _require_scratch_dax_iflag()? like this: _require_scratch_dax_iflag() { _require_xfs_io_command "chattr" "x" } Best Regards, Xiao Yang

Re: [PATCH V4 6/8] fs/ext4: Make DAX mount option a tri-state

2020-06-01 Thread Xiao Yang
On 2020/5/28 17:41, Jan Kara wrote: On Thu 28-05-20 16:56:51, Xiao Yang wrote: On 2020/5/28 7:50, Ira Weiny wrote: On Wed, May 27, 2020 at 01:54:54PM +0800, Xiao Yang wrote: On 2020/5/22 3:13, ira.we...@intel.com wrote: From: Ira Weiny We add 'always', 'never', and 'inode' (default). '-o

Re: [PATCH V4 6/8] fs/ext4: Make DAX mount option a tri-state

2020-05-28 Thread Xiao Yang
On 2020/5/28 7:50, Ira Weiny wrote: On Wed, May 27, 2020 at 01:54:54PM +0800, Xiao Yang wrote: On 2020/5/22 3:13, ira.we...@intel.com wrote: From: Ira Weiny We add 'always', 'never', and 'inode' (default). '-o dax' continues to operate the same which is equivalent to 'always'. This new

Re: [PATCH V4 6/8] fs/ext4: Make DAX mount option a tri-state

2020-05-26 Thread Xiao Yang
break; > + case Opt_dax_inode: > + sbi->s_mount_opt&= ~EXT4_MOUNT_DAX_ALWAYS; > + sbi->s_mount_opt2&= ~EXT4_MOUNT2_DAX_NEVER; > + /* Strictly for printing options */ > + sbi->s_mount_op

Re: [PATCH v2] tools/perf/util/*.c: Use "%zu" output format for size_t type

2020-05-11 Thread Xiao Yang
Hi, Ping! Thanks, Xiao Yang On 2020/2/26 9:08, Xiao Yang wrote: > Avoid the following errors when building perf on i386: > --- > util/session.c: In function 'perf_session__process_compressed_event': > util/session.c:91:11: error: format '

Re: [PATCH 3/3] selftests/ftrace: Use /bin/echo instead of built-in echo

2020-05-11 Thread Xiao Yang
On 2020/5/7 17:15, Masami Hiramatsu wrote: On Thu, 7 May 2020 14:45:16 +0800 Xiao Yang wrote: On 2020/5/1 21:38, Masami Hiramatsu wrote: Since the built-in echo has different behavior in POSIX shell (dash) and bash, we forcibly use /bin/echo -E (not interpret backslash escapes) by default

Re: [PATCH] tracing: Wait for preempt irq delay thread to finish

2020-05-07 Thread Xiao Yang
preemptirq_delay_test in loops. 3) Ran irqsoff_tracer.tc in loops. BTW: For irqsoff_tracer.tc, should we extend code to test the burst feature and the sysfs trigger? Reviewed-by: Xiao Yang Thanks, Xiao Yang On 2020/5/6 22:30, Steven Rostedt wrote: From: "Steven Rostedt (VMware)"

Re: [PATCH 3/3] selftests/ftrace: Use /bin/echo instead of built-in echo

2020-05-07 Thread Xiao Yang
currently. Is it necessary for all tests to use /bin/echo and could we just make kprobe_syntax_errors.tc use /bin/echo? Best Regards, Xiao Yang clear_trace() { # reset trace output echo> trace diff --git a/tools/testing/selftests/ftrace/test.d/trigger/trigger-trace-marker-hist.tc b/

Re: [PATCH] kernel/trace: Stop and wait for kthread on preempt irq module unload

2020-04-29 Thread Xiao Yang
est; done for i in $(seq 1 100); do modprobe preemptirq_delay_test test_mode=preempt delay=50; rmmod preemptirq_delay_test; done - But I am not sure which fix(from you and Joel) is better. Thanks, Xiao Yang

Re: [PATCH] kernel/trace: Stop and wait for kthread on preempt irq module unload

2020-04-29 Thread Xiao Yang
one --- Thanks, Xiao Yang

Re: [PATCH] kernel/trace: Stop and wait for kthread on preempt irq module unload

2020-04-29 Thread Xiao Yang
[ 178.658903] Memory Limit: none [ 178.659263] ---[ end Kernel panic - not syncing: Fatal exception ]--- --- Thanks, Xiao Yang On 2020/4/28 18:19, Xiao Yang wrote: > Hi Joel, > > Thanks for your quick fix. > > Unfortunately, it fi

Re: [PATCH] selftests/ftrace: treat module requirement unmet situation as unsupported

2020-04-29 Thread Xiao Yang
Hi Lin, It looks fine to me. Reviewed-by: Xiao Yang Thanks, Xiao Yang On 2020/4/29 17:50, Po-Hsu Lin wrote: > When the required module for the test does not exist, use > exit_unsupported instead of exit_unresolved to indicate this test is > not supported. > > By doing this w

Re: [PATCH] kernel/trace: Stop and wait for kthread on preempt irq module unload

2020-04-28 Thread Xiao Yang
[ 3465.524939] Memory Limit: none [ 3465.525534] ---[ end Kernel panic - not syncing: Fatal exception ]--- I am looking into these issues. Thanks, Xiao Yang On 2020/4/25 6:36, Joel Fernandes (Google) wrote: > Kthread runn

[PATCH] kbuild: Remove unused variable TMPO of ld-option

2019-08-06 Thread Xiao Yang
ld-option implementation has been simplified so variable TMPO is no longer needed. Fixes: Commit 0294e6f4a000 ("kbuild: simplify ld-option implementation") Signed-off-by: Xiao Yang --- scripts/Kbuild.include | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git