Re: [PATCH] mm/filemap.c: unconditionally call mark_page_accessed

2007-03-14 Thread Xiaoning Ding
Dave Kleikamp wrote: On Wed, 2007-03-14 at 22:33 +0100, Andreas Mohr wrote: Hi, On Wed, Mar 14, 2007 at 03:55:41PM -0500, Dave Kleikamp wrote: On Wed, 2007-03-14 at 15:58 -0400, Ashif Harji wrote: This patch unconditionally calls mark_page_accessed to prevent pages, especially for small files

Re: a bug in AS scheduler?

2007-02-28 Thread Xiaoning Ding
Jens Axboe wrote: On Wed, Feb 28 2007, Benoit Boissinot wrote: On 2/28/07, Jens Axboe <[EMAIL PROTECTED]> wrote: On Tue, Feb 27 2007, Xiaoning Ding wrote: Hi, I am reading the source code AS scheduler in 2.6.18(as-ioscheduler.c). In function as_close_req, variable delay is in milli

a bug in AS scheduler?

2007-02-27 Thread Xiaoning Ding
Hi, I am reading the source code AS scheduler in 2.6.18(as-ioscheduler.c). In function as_close_req, variable delay is in millisecond, while ad->antic_expire is in jiffies. Doesn't the comparison of delay and ad->antic_expire make any problem? The related source code is quoted blow: if (