[PATCH] rtlwifi: core: use eth_broadcast_addr() to assign broadcast

2020-07-26 Thread Xu Wang
This patch is to use eth_broadcast_addr() to assign broadcast address insetad of memcpy(). Signed-off-by: Xu Wang --- drivers/net/wireless/realtek/rtlwifi/core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/wireless/realtek/rtlwifi/core.c b/drivers/net

[PATCH] coresight: Use devm_kcalloc() in coresight_alloc_conns()

2020-07-26 Thread Xu Wang
A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "devm_kcalloc". Signed-off-by: Xu Wang --- drivers/hwtracing/coresight/coresight-platform.c | 2 +- 1 file changed, 1

[PATCH] net: hns: use eth_broadcast_addr() to assign broadcast address

2020-07-20 Thread Xu Wang
This patch is to use eth_broadcast_addr() to assign broadcast address insetad of memset(). Signed-off-by: Xu Wang --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c b

[PATCH] usb: appledisplay: remove needless check before usb_free_coherent()

2020-07-19 Thread Xu Wang
usb_free_coherent() is safe with NULL addr and this check is not required. Signed-off-by: Xu Wang --- drivers/usb/misc/appledisplay.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/usb/misc/appledisplay.c b/drivers/usb/misc/appledisplay.c index ba1eaabc7796

[PATCH] media: b2bc: remove needless check before usb_free_coherent()

2020-07-19 Thread Xu Wang
usb_free_coherent() is safe with NULL addr and this check is not required. Signed-off-by: Xu Wang --- drivers/media/usb/b2c2/flexcop-usb.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/media/usb/b2c2/flexcop-usb.c b/drivers/media/usb/b2c2/flexcop-usb.c index

[PATCH] net: vxge-main: Remove unnecessary cast in kfree()

2020-07-19 Thread Xu Wang
Remove unnecassary casts in the argument to kfree. Signed-off-by: Xu Wang --- drivers/net/ethernet/neterion/vxge/vxge-main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/neterion/vxge/vxge-main.c b/drivers/net/ethernet/neterion/vxge/vxge-main.c

[PATCH] net: xilinx: fix potential NULL dereference in temac_probe()

2020-07-13 Thread Xu Wang
platform_get_resource() may return NULL, add proper check to avoid potential NULL dereferencing. Signed-off-by: Xu Wang --- drivers/net/ethernet/xilinx/ll_temac_main.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/ethernet/xilinx/ll_temac_main.c b/drivers/net/ethernet

[PATCH] f2fs: gc: fix the variable used in PTR_ERR()

2020-07-13 Thread Xu Wang
PTR_ERR should access the value just tested by IS_ERR, so fix the variable used in PTR_ERR(). Signed-off-by: Xu Wang --- drivers/gpu/drm/i915/gt/selftest_lrc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gt/selftest_lrc.c b/drivers/gpu/drm/i915/gt

[PATCH] watchdog: pcwd_usb: remove needless check before usb_free_coherent()

2020-07-12 Thread Xu Wang
usb_free_coherent() is safe with NULL usb_pcwd->intr_buffer and this check is not required. Signed-off-by: Xu Wang --- drivers/watchdog/pcwd_usb.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/watchdog/pcwd_usb.c b/drivers/watchdog/pcwd_usb.c in

[PATCH] fsi: fsi-occ: fix return value check in occ_probe()

2020-07-12 Thread Xu Wang
In case of error, the function platform_device_register_full() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Signed-off-by: Xu Wang --- drivers/fsi/fsi-occ.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] clk: clk-atlas6: fix return value check in atlas6_clk_init()

2020-07-12 Thread Xu Wang
In case of error, the function clk_register() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Signed-off-by: Xu Wang --- drivers/clk/sirf/clk-atlas6.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH] arm: omap-iommu: fix return value check in _get_pwrdm()

2020-07-12 Thread Xu Wang
In case of error, function of_clk_get() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Signed-off-by: Xu Wang --- arch/arm/mach-omap2/omap-iommu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm

[PATCH] service_layers: osunixmap: Remove unnecessary brackets in acpi_os_map_memory()

2020-07-09 Thread Xu Wang
Remove extra brackets. Signed-off-by: Xu Wang --- tools/power/acpi/os_specific/service_layers/osunixmap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/power/acpi/os_specific/service_layers/osunixmap.c b/tools/power/acpi/os_specific/service_layers/osunixmap.c

[PATCH] net: enetc: use eth_broadcast_addr() to assign broadcast

2020-07-09 Thread Xu Wang
This patch is to use eth_broadcast_addr() to assign broadcast address insetad of memset(). Signed-off-by: Xu Wang --- drivers/net/ethernet/freescale/enetc/enetc_qos.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/enetc/enetc_qos.c b/drivers

[PATCH] bcache: writeback: Remove unneeded variable i

2020-07-08 Thread Xu Wang
Remove unneeded variable i in bch_dirty_init_thread(). Signed-off-by: Xu Wang --- drivers/md/bcache/writeback.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/md/bcache/writeback.c b/drivers/md/bcache/writeback.c index 1cf1e5016cb9..71801c086b82 100644 --- a/drivers/md/bcache

[PATCH] debugfs: file: Remove unnecessary cast in kfree()

2020-07-08 Thread Xu Wang
Remove unnecassary casts in the argument to kfree. Signed-off-by: Xu Wang --- fs/debugfs/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/debugfs/file.c b/fs/debugfs/file.c index ae49a55bda00..3753c4c484fc 100644 --- a/fs/debugfs/file.c +++ b/fs/debugfs/file.c

[PATCH] bcache: writeback: Remove unneeded variable ret

2020-07-08 Thread Xu Wang
Remove unneeded variable ret i. Signed-off-by: Xu Wang --- drivers/md/bcache/writeback.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/md/bcache/writeback.c b/drivers/md/bcache/writeback.c index 1cf1e5016cb9..71801c086b82 100644 --- a/drivers/md/bcache/writeback.c +++ b/drivers

[PATCH] kernel: timer: use set_current_state macro

2020-07-08 Thread Xu Wang
Use set_current_state macro instead of current->state = TASK_RUNNING. Signed-off-by: Xu Wang --- kernel/time/timer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/time/timer.c b/kernel/time/timer.c index 398e6eadb861..2bf78ecffebe 100644 --- a/kernel/time/time

[PATCH] arch: powerpc: Remove unnecessary cast in kfree()

2020-07-08 Thread Xu Wang
Remove unnecassary casts in the argument to kfree. Signed-off-by: Xu Wang --- arch/powerpc/platforms/pseries/dlpar.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/platforms/pseries/dlpar.c b/arch/powerpc/platforms/pseries/dlpar.c index 16e86ba8aa20

[PATCH] fs: ceph: Remove unnecessary cast in kfree()

2020-07-08 Thread Xu Wang
Remove unnecassary casts in the argument to kfree. Signed-off-by: Xu Wang --- fs/ceph/xattr.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/fs/ceph/xattr.c b/fs/ceph/xattr.c index 71ee34d160c3..3a733ac33d9b 100644 --- a/fs/ceph/xattr.c +++ b/fs/ceph/xattr.c

[PATCH] kernel: perf_event: use for_each_set_bit() to simplify the code

2020-07-08 Thread Xu Wang
Using for_each_set_bit() to simplify the code. Signed-off-by: Xu Wang --- arch/xtensa/kernel/perf_event.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/arch/xtensa/kernel/perf_event.c b/arch/xtensa/kernel/perf_event.c index 9bae79f70301..99fcd63ce597 100644 --- a/arch

[PATCH] rds: send: Replace sg++ with sg = sg_next(sg)

2020-07-07 Thread Xu Wang
Replace sg++ with sg = sg_next(sg). Signed-off-by: Xu Wang --- net/rds/send.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/rds/send.c b/net/rds/send.c index 68e2bdb08fd0..57d03a6753de 100644 --- a/net/rds/send.c +++ b/net/rds/send.c @@ -387,7 +387,7 @@ int

[PATCH] input: misc: remove needless check before usb_free_coherent()

2020-07-06 Thread Xu Wang
usb_free_coherent() is safe with NULL addr and this check is not required. Signed-off-by: Xu Wang --- drivers/input/misc/cm109.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/input/misc/cm109.c b/drivers/input/misc/cm109.c index c09b9628ad34..e413801f0491

[PATCH] net: cisco : use set_current_state macro

2020-07-01 Thread Xu Wang
Use set_current_state macro instead of current->state = TASK_RUNNING. Signed-off-by: Xu Wang --- drivers/net/wireless/cisco/airo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/cisco/airo.c b/drivers/net/wireless/cisco/airo.c index 827bb6d74

[PATCH] bcache: journel: use for_each_clear_bit() to simplify the code

2020-06-24 Thread Xu Wang
Using for_each_clear_bit() to simplify the code. Signed-off-by: Xu Wang --- drivers/md/bcache/journal.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/md/bcache/journal.c b/drivers/md/bcache/journal.c index 90aac4e2333f..b01c953e214c 100644 --- a/drivers/md

[PATCH] nfsd: Use seq_putc() in two functions

2020-06-17 Thread Xu Wang
A single character (line break) should be put into a sequence. Thus use the corresponding function "seq_putc()". Signed-off-by: Xu Wang --- fs/nfsd/nfs4idmap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/nfsd/nfs4idmap.c b/fs/nfsd/nfs4idmap.c index 94

[PATCH] drivers: dpaa2: Use devm_kcalloc() in setup_dpni()

2020-06-10 Thread Xu Wang
A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "devm_kcalloc". Signed-off-by: Xu Wang --- drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 5 +++-- 1 file changed, 3

[PATCH] arch: kernel: Replace sg++ with sg = sg_next(sg)

2020-06-02 Thread Xu Wang
Replace sg++ with sg = sg_next(sg). Signed-off-by: Xu Wang --- arch/alpha/kernel/pci_iommu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/alpha/kernel/pci_iommu.c b/arch/alpha/kernel/pci_iommu.c index 7f1925a32c99..81037907268d 100644 --- a/arch/alpha/kernel

[PATCH] coresight: Use devm_kcalloc() in coresight_alloc_conns()

2020-05-25 Thread Xu Wang
A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "devm_kcalloc". Signed-off-by: Xu Wang --- drivers/hwtracing/coresight/coresight-platform.c | 5 ++--- 1 file changed, 2

[PATCH] scrpits: Remove unneeded assignment parentheses

2020-05-21 Thread Xu Wang
Remove unneeded assignment parentheses. Signed-off-by: Xu Wang --- scripts/extract-cert.c | 2 +- scripts/sign-file.c| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/extract-cert.c b/scripts/extract-cert.c index b071bf476fea..8005911926b8 100644 --- a/scripts

[PATCH] clk/ti/adpll: Add a NULL check for devm_kasprintf()

2020-05-17 Thread Xu Wang
devm_kasprintf() may fail, so we should better add a NULL check and propagate an error on failure. Signed-off-by: Xu Wang --- drivers/clk/ti/adpll.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/clk/ti/adpll.c b/drivers/clk/ti/adpll.c index bb2f283..f18a672 100644 --- a/drivers

[PATCH] kernel: events: use offset_in_page macro

2020-05-12 Thread Xu Wang
Use offset_in_page macro instead of (addr & ~PAGE_MASK). Signed-off-by: Xu Wang --- kernel/events/uprobes.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/kernel/events/uprobes.c b/kernel/events/uprobes.c index ece7e13..1552ef1 100644 --- a/kernel/events/uprob

[PATCH] drivers: block: use set_current_state macro

2020-05-07 Thread Xu Wang
Use set_current_state macro instead of current->state = TASK_RUNNING. Signed-off-by: Xu Wang --- drivers/block/swim.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/block/swim.c b/drivers/block/swim.c index 4c297f69171d..dd34504382e5 100644 --- a/drivers/bl

[PATCH] ZYNQ: platsmp: fix ioremap return value

2020-04-30 Thread Xu Wang
In ioremap we should return -ENOMEM when it reports an memory allocation failure. Signed-off-by: Xu Wang --- arch/arm/mach-zynq/platsmp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-zynq/platsmp.c b/arch/arm/mach-zynq/platsmp.c index 68ec303fa278

Re: [overlayfs] lockdep splat after mounting overlayfs over overlayfs

2015-06-25 Thread Xu Wang
> On Thu, Jun 25, 2015 at 10:24 AM, Xu Wang wrote: > >> I've accidentally mounted one overlayfs over another and got obvious > >> warning from lockdep: i_mutex lockdep classes are per-fs-type. > >> > >> # mount -t overlay overlay 1 -o > >>

Re: [overlayfs] lockdep splat after mounting overlayfs over overlayfs

2015-06-25 Thread Xu Wang
> I've accidentally mounted one overlayfs over another and got obvious > warning from lockdep: i_mutex lockdep classes are per-fs-type. > > # mount -t overlay overlay 1 -o > upperdir=1_upper,workdir=1_work,lowerdir=1_lower > # mount -t overlay overlay 2 -o

Re: [overlayfs] lockdep splat after mounting overlayfs over overlayfs

2015-06-25 Thread Xu Wang
I've accidentally mounted one overlayfs over another and got obvious warning from lockdep: i_mutex lockdep classes are per-fs-type. # mount -t overlay overlay 1 -o upperdir=1_upper,workdir=1_work,lowerdir=1_lower # mount -t overlay overlay 2 -o upperdir=2_upper,workdir=2_work,lowerdir=1 #

Re: [overlayfs] lockdep splat after mounting overlayfs over overlayfs

2015-06-25 Thread Xu Wang
On Thu, Jun 25, 2015 at 10:24 AM, Xu Wang x...@redhat.com wrote: I've accidentally mounted one overlayfs over another and got obvious warning from lockdep: i_mutex lockdep classes are per-fs-type. # mount -t overlay overlay 1 -o upperdir=1_upper,workdir=1_work,lowerdir=1_lower # mount

<    1   2