[PATCH net,v2] nfc: fix potential illegal memory access

2019-07-08 Thread Yang Wei
The frags_q is not properly initialized, it may result in illegal memory access when conn_info is NULL. The "goto free_exit" should be replaced by "goto exit". Signed-off-by: Yang Wei --- net/nfc/nci/data.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH net] nfc: fix potential illegal memory access

2019-07-07 Thread Yang Wei
The frags_q is used before __skb_queue_head_init when conn_info is NULL. It may result in illegal memory access. Signed-off-by: Yang Wei --- net/nfc/nci/data.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/nfc/nci/data.c b/net/nfc/nci/data.c index 0a0c265..b5f16cb

[tip:perf/urgent] perf clang: Remove needless extra semicolon

2019-03-09 Thread tip-bot for Yang Wei
Commit-ID: a53837a5458c5b84588dfa3fa510c6a29b7bd4d7 Gitweb: https://git.kernel.org/tip/a53837a5458c5b84588dfa3fa510c6a29b7bd4d7 Author: Yang Wei AuthorDate: Mon, 4 Mar 2019 22:36:14 +0800 Committer: Arnaldo Carvalho de Melo CommitDate: Wed, 6 Mar 2019 09:47:48 -0300 perf clang: Remove

[PATCH] perf clang: fix semicolon code style issue

2019-03-04 Thread Yang Wei
From: Yang Wei Delete a superfluous semicolon in getBPFObjectFromModule(). Signed-off-by: Yang Wei --- tools/perf/util/c++/clang.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/util/c++/clang.cpp b/tools/perf/util/c++/clang.cpp index 39c0004..fc361c3 100644

[PATCH] nds32: fix semicolon code style issue

2019-03-04 Thread Yang Wei
From: Yang Wei Delete superfluous semicolons. Signed-off-by: Yang Wei --- arch/nds32/kernel/cacheinfo.c | 2 +- arch/nds32/mm/init.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/nds32/kernel/cacheinfo.c b/arch/nds32/kernel/cacheinfo.c index 0a7bc69

[PATCH net] net: ti: replace dev_kfree_skb_irq by dev_consume_skb_irq for drop profiles

2019-01-28 Thread Yang Wei
dev_consume_skb_irq() should be called in cpmac_end_xmit() when xmit done. It makes drop profiles more friendly. Signed-off-by: Yang Wei --- drivers/net/ethernet/ti/cpmac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/ti/cpmac.c b/drivers/net/ethernet

[PATCH net] net: apple: replace dev_kfree_skb_irq by dev_consume_skb_irq for drop profiles

2019-01-28 Thread Yang Wei
dev_consume_skb_irq() should be called in bmac_txdma_intr() when xmit done. It makes drop profiles more friendly. Signed-off-by: Yang Wei --- drivers/net/ethernet/apple/bmac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/apple/bmac.c b/drivers/net

Cma mem map to cpu address when allocated in ion driver, why do this design?

2016-09-01 Thread Yangwei (Yang Wei, Device Chipset Key Technologies Platform Development Dept)
Hi all, When I review ion code in linux-3.18.y, I find a design that may cause a problem in our product. In the design, cma mem is allocated via the interface of dma_alloc_coherent , and this function will create a map to cpu. Sometimes, we just need cma phys addr, do not need cpu address.

Cma mem map to cpu address when allocated in ion driver, why do this design?

2016-09-01 Thread Yangwei (Yang Wei, Device Chipset Key Technologies Platform Development Dept)
Hi all, When I review ion code in linux-3.18.y, I find a design that may cause a problem in our product. In the design, cma mem is allocated via the interface of dma_alloc_coherent , and this function will create a map to cpu. Sometimes, we just need cma phys addr, do not need cpu address.

Re: [PATCH v1] MIPS:KDUMP: set a right value to kexec_indirection_page variable

2014-08-07 Thread Yang,Wei
Ralf, What do you think of this patch? Thanks Wei On 08/04/2014 11:46 AM, Yang,Wei wrote: ping. BR, Wei On 07/31/2014 07:42 PM, wei.y...@windriver.com wrote: From: Yang Wei Since there is not indirection page in crash type, so the vaule of the head field of kimage structure is not equal

Re: [PATCH v1] MIPS:KDUMP: set a right value to kexec_indirection_page variable

2014-08-07 Thread Yang,Wei
Ralf, What do you think of this patch? Thanks Wei On 08/04/2014 11:46 AM, Yang,Wei wrote: ping. BR, Wei On 07/31/2014 07:42 PM, wei.y...@windriver.com wrote: From: Yang Wei wei.y...@windriver.com Since there is not indirection page in crash type, so the vaule of the head field of kimage

Re: [PATCH v1] MIPS:KDUMP: set a right value to kexec_indirection_page variable

2014-08-03 Thread Yang,Wei
ping. BR, Wei On 07/31/2014 07:42 PM, wei.y...@windriver.com wrote: From: Yang Wei Since there is not indirection page in crash type, so the vaule of the head field of kimage structure is not equal to the address of indirection page but IND_DONE. so we have to set kexec_indirection_page

Re: [PATCH v1] MIPS:KDUMP: set a right value to kexec_indirection_page variable

2014-08-03 Thread Yang,Wei
ping. BR, Wei On 07/31/2014 07:42 PM, wei.y...@windriver.com wrote: From: Yang Wei wei.y...@windriver.com Since there is not indirection page in crash type, so the vaule of the head field of kimage structure is not equal to the address of indirection page but IND_DONE. so we have to set

Re: [PATCH v1] ARM:sa1100: Remove a redundant spin lock

2014-07-02 Thread Yang,Wei
On 07/02/2014 06:19 PM, Russell King - ARM Linux wrote: On Wed, Jul 02, 2014 at 05:19:40PM +0800, Yang,Wei wrote: Hi Guys, What about this patch? The only concern on the face of it is that it removes mutual exclusion from the pci config write path, where a read-modifiy-write operation

Re: [PATCH v1] ARM:sa1100: Remove a redundant spin lock

2014-07-02 Thread Yang,Wei
Hi Guys, What about this patch? Thanks Wei On 07/01/2014 03:41 PM, wei.y...@windriver.com wrote: From: Yang Wei The pair read/write of accessing pci confiuration space function has already protected by pci_lock. so remove nano_lock. Signed-off-by: Yang Wei --- arch/arm/mach-sa1100/pci

Re: [PATCH v1] ARM:sa1100: Remove a redundant spin lock

2014-07-02 Thread Yang,Wei
Hi Guys, What about this patch? Thanks Wei On 07/01/2014 03:41 PM, wei.y...@windriver.com wrote: From: Yang Wei wei.y...@windriver.com The pair read/write of accessing pci confiuration space function has already protected by pci_lock. so remove nano_lock. Signed-off-by: Yang Wei wei.y

Re: [PATCH v1] ARM:sa1100: Remove a redundant spin lock

2014-07-02 Thread Yang,Wei
On 07/02/2014 06:19 PM, Russell King - ARM Linux wrote: On Wed, Jul 02, 2014 at 05:19:40PM +0800, Yang,Wei wrote: Hi Guys, What about this patch? The only concern on the face of it is that it removes mutual exclusion from the pci config write path, where a read-modifiy-write operation

Re: [PATCH] USB:gadget: Fix a warning while loading g_mass_storage

2014-06-18 Thread Yang,Wei
On 06/18/2014 07:44 PM, Michal Nazarewicz wrote: On Wed, Jun 18 2014, Yang,Wei wrote: On 06/17/2014 10:18 PM, Alan Stern wrote: That is a strange question to ask. If you did not know that I approved the patch, why did you insert my Acked-By:? I added your Acked-By, as when you reviewed V3

Re: [PATCH] USB:gadget: Fix a warning while loading g_mass_storage

2014-06-18 Thread Yang,Wei
On 06/18/2014 07:44 PM, Michal Nazarewicz wrote: On Wed, Jun 18 2014, Yang,Wei wrote: On 06/17/2014 10:18 PM, Alan Stern wrote: That is a strange question to ask. If you did not know that I approved the patch, why did you insert my Acked-By:? I added your Acked-By, as when you reviewed V3

Re: [PATCH] USB:gadget: Fix a warning while loading g_mass_storage

2014-06-17 Thread Yang,Wei
On 06/17/2014 10:18 PM, Alan Stern wrote: That is a strange question to ask. If you did not know that I approved the patch, why did you insert my Acked-By:? I added your Acked-By, as when you reviewed V3, you mentioned that I *may* add your Acked-by in this patch. If I misunderstood your

Re: [PATCH v1] fs2dt: Refine kdump device_tree sort

2014-06-17 Thread Yang,Wei
Simon, I missed "kexec" string in subject, so please ignore this version. I would resend it with adding "kexec" in subject. Thanks Wei On 06/17/2014 02:01 PM, Yang,Wei wrote: Hi Simon, How about this patch? Thanks Wei On 06/12/2014 01:16 PM, wei.y...@windriver.com wr

Re: [PATCH v1] fs2dt: Refine kdump device_tree sort

2014-06-17 Thread Yang,Wei
Hi Simon, How about this patch? Thanks Wei On 06/12/2014 01:16 PM, wei.y...@windriver.com wrote: From: Yang Wei The commit b02d735bf was to rearrange the device-tree entries, and assumed that these entries are sorted in the ascending order. but acctually when I was validating kexec and kdump

Re: [PATCH] USB:gadget: Fix a warning while loading g_mass_storage

2014-06-17 Thread Yang,Wei
On 06/15/2014 10:42 AM, Yang,Wei wrote: Its v4, sorry for missing it in subject. Alan, How about this version? Cheers Wei Regards Wei On 06/15/2014 10:40 AM, wei.y...@windriver.com wrote: From: Yang Wei While loading g_mass_storage module, the following warning is triggered. WARNING

Re: [PATCH] USB:gadget: Fix a warning while loading g_mass_storage

2014-06-17 Thread Yang,Wei
On 06/15/2014 10:42 AM, Yang,Wei wrote: Its v4, sorry for missing it in subject. Alan, How about this version? Cheers Wei Regards Wei On 06/15/2014 10:40 AM, wei.y...@windriver.com wrote: From: Yang Wei wei.y...@windriver.com While loading g_mass_storage module, the following warning

Re: [PATCH v1] fs2dt: Refine kdump device_tree sort

2014-06-17 Thread Yang,Wei
Hi Simon, How about this patch? Thanks Wei On 06/12/2014 01:16 PM, wei.y...@windriver.com wrote: From: Yang Wei wei.y...@windriver.com The commit b02d735bf was to rearrange the device-tree entries, and assumed that these entries are sorted in the ascending order. but acctually when I

Re: [PATCH v1] fs2dt: Refine kdump device_tree sort

2014-06-17 Thread Yang,Wei
Simon, I missed kexec string in subject, so please ignore this version. I would resend it with adding kexec in subject. Thanks Wei On 06/17/2014 02:01 PM, Yang,Wei wrote: Hi Simon, How about this patch? Thanks Wei On 06/12/2014 01:16 PM, wei.y...@windriver.com wrote: From: Yang Wei wei.y

Re: [PATCH] USB:gadget: Fix a warning while loading g_mass_storage

2014-06-17 Thread Yang,Wei
On 06/17/2014 10:18 PM, Alan Stern wrote: That is a strange question to ask. If you did not know that I approved the patch, why did you insert my Acked-By:? I added your Acked-By, as when you reviewed V3, you mentioned that I *may* add your Acked-by in this patch. If I misunderstood your

Re: [PATCH] USB:gadget: Fix a warning while loading g_mass_storage

2014-06-14 Thread Yang,Wei
Its v4, sorry for missing it in subject. Regards Wei On 06/15/2014 10:40 AM, wei.y...@windriver.com wrote: From: Yang Wei While loading g_mass_storage module, the following warning is triggered. WARNING: at drivers/usb/gadget/composite.c: usb_composite_setup_continue: Unexpected call Modules

Re: [PATCH v3] USB:gadget: Fix a warning while loading g_mass_storage

2014-06-14 Thread Yang,Wei
On 06/13/2014 09:39 PM, Alan Stern wrote: On Fri, 13 Jun 2014, Yang,Wei wrote: On 06/09/2014 02:19 PM, wei.y...@windriver.com wrote: From: Yang Wei While loading g_mass_storage module, the following warning is triggered. WARNING: at drivers/usb/gadget/composite.c

Re: [PATCH v3] USB:gadget: Fix a warning while loading g_mass_storage

2014-06-14 Thread Yang,Wei
On 06/13/2014 09:39 PM, Alan Stern wrote: On Fri, 13 Jun 2014, Yang,Wei wrote: On 06/09/2014 02:19 PM, wei.y...@windriver.com wrote: From: Yang Wei wei.y...@windriver.com While loading g_mass_storage module, the following warning is triggered. WARNING: at drivers/usb/gadget/composite.c

Re: [PATCH] USB:gadget: Fix a warning while loading g_mass_storage

2014-06-14 Thread Yang,Wei
Its v4, sorry for missing it in subject. Regards Wei On 06/15/2014 10:40 AM, wei.y...@windriver.com wrote: From: Yang Wei wei.y...@windriver.com While loading g_mass_storage module, the following warning is triggered. WARNING: at drivers/usb/gadget/composite.c: usb_composite_setup_continue

Re: [PATCH v3] USB:gadget: Fix a warning while loading g_mass_storage

2014-06-13 Thread Yang,Wei
On 06/09/2014 02:19 PM, wei.y...@windriver.com wrote: From: Yang Wei While loading g_mass_storage module, the following warning is triggered. WARNING: at drivers/usb/gadget/composite.c: usb_composite_setup_continue: Unexpected call Modules linked in: fat vfat minix nls_cp437 nls_iso8859_1

Re: [PATCH v3] USB:gadget: Fix a warning while loading g_mass_storage

2014-06-13 Thread Yang,Wei
On 06/09/2014 02:19 PM, wei.y...@windriver.com wrote: From: Yang Wei wei.y...@windriver.com While loading g_mass_storage module, the following warning is triggered. WARNING: at drivers/usb/gadget/composite.c: usb_composite_setup_continue: Unexpected call Modules linked in: fat vfat minix

Re: [PATCH v2] USB:gadget: Fix a warning while loading g_mass_storage

2014-06-09 Thread Yang,Wei
Hi Alan, Sorry for my late response, as I was 000, Additionally, I am very grateful for your review. On 06/06/2014 02:08 AM, Alan Stern wrote: On Wed, 4 Jun 2014 wei.y...@windriver.com wrote: From: Yang Wei While loading g_mass_storage module, the following warning is triggered. WARNING

Re: [PATCH v2] USB:gadget: Fix a warning while loading g_mass_storage

2014-06-09 Thread Yang,Wei
Hi Alan, Sorry for my late response, as I was 000, Additionally, I am very grateful for your review. On 06/06/2014 02:08 AM, Alan Stern wrote: On Wed, 4 Jun 2014 wei.y...@windriver.com wrote: From: Yang Wei wei.y...@windriver.com While loading g_mass_storage module, the following warning

Re: [PATCH v1] USB:gadget: Fix a warning while loading g_mass_storage

2014-06-03 Thread Yang,Wei
On 06/04/2014 09:45 AM, Peter Chen wrote: commit d18f7116a5ddb8263fe62b05ad63e5ceb5875791 Author: Robert Baldyga Date: Thu Nov 21 13:49:18 2013 +0100 usb: gadget: s3c-hsotg: fix disconnect handling This patch moves s3c_hsotg_disconnect function call from USBSusp interrupt

Re: [PATCH v1] USB:gadget: Fix a warning while loading g_mass_storage

2014-06-03 Thread Yang,Wei
ently the usb_composite_setup_continue |-> is executed again. It would fininally results in the warning. Thanks Wei On 06/04/2014 09:20 AM, Yang,Wei wrote: On 06/03/2014 10:48 PM, Alan Stern wrote: On Tue, 3 Jun 2014 wei.y...@windriver.com wrote: From: Yang Wei While loadin

Re: [PATCH v1] USB:gadget: Fix a warning while loading g_mass_storage

2014-06-03 Thread Yang,Wei
On 06/03/2014 10:48 PM, Alan Stern wrote: On Tue, 3 Jun 2014 wei.y...@windriver.com wrote: From: Yang Wei While loading g_mass_storage module, the following warning is triggered. In fact, it is more easy to reproduce it with RT kernel. WARNING: at drivers/usb/gadget/composite.c

Re: [PATCH v1] USB:gadget: Fix a warning while loading g_mass_storage

2014-06-03 Thread Yang,Wei
On 06/03/2014 10:48 PM, Alan Stern wrote: On Tue, 3 Jun 2014 wei.y...@windriver.com wrote: From: Yang Wei wei.y...@windriver.com While loading g_mass_storage module, the following warning is triggered. In fact, it is more easy to reproduce it with RT kernel. WARNING: at drivers/usb/gadget

Re: [PATCH v1] USB:gadget: Fix a warning while loading g_mass_storage

2014-06-03 Thread Yang,Wei
. Thanks Wei On 06/04/2014 09:20 AM, Yang,Wei wrote: On 06/03/2014 10:48 PM, Alan Stern wrote: On Tue, 3 Jun 2014 wei.y...@windriver.com wrote: From: Yang Wei wei.y...@windriver.com While loading g_mass_storage module, the following warning is triggered. In fact, it is more easy to reproduce

Re: [PATCH v1] USB:gadget: Fix a warning while loading g_mass_storage

2014-06-03 Thread Yang,Wei
On 06/04/2014 09:45 AM, Peter Chen wrote: commit d18f7116a5ddb8263fe62b05ad63e5ceb5875791 Author: Robert Baldyga r.bald...@samsung.com Date: Thu Nov 21 13:49:18 2013 +0100 usb: gadget: s3c-hsotg: fix disconnect handling This patch moves s3c_hsotg_disconnect function call from

Re: [PATCH v1] drivers/clocksource: do not trace read_sched_clock

2014-05-22 Thread Yang,Wei
On 05/22/2014 08:03 PM, Daniel Lezcano wrote: On 05/22/2014 03:50 AM, Yang,Wei wrote: Hi Daniel, What do you think of it? Regards Wei On 05/13/2014 11:10 AM, wei.y...@windriver.com wrote: From: Yang Wei We do not need to trace read_sched_clock function, so add notrace attribute

Re: [PATCH v1] drivers/clocksource: do not trace read_sched_clock

2014-05-22 Thread Yang,Wei
On 05/22/2014 08:03 PM, Daniel Lezcano wrote: On 05/22/2014 03:50 AM, Yang,Wei wrote: Hi Daniel, What do you think of it? Regards Wei On 05/13/2014 11:10 AM, wei.y...@windriver.com wrote: From: Yang Wei wei.y...@windriver.com We do not need to trace read_sched_clock function, so add notrace

Re: [PATCH v1] drivers/clocksource: do not trace read_sched_clock

2014-05-21 Thread Yang,Wei
Hi Daniel, What do you think of it? Regards Wei On 05/13/2014 11:10 AM, wei.y...@windriver.com wrote: From: Yang Wei We do not need to trace read_sched_clock function, so add notrace attribute for this function. Signed-off-by: Yang Wei --- drivers/clocksource/dw_apb_timer_of.c |2

Re: [PATCH v1] drivers/clocksource: do not trace read_sched_clock

2014-05-21 Thread Yang,Wei
Hi Daniel, What do you think of it? Regards Wei On 05/13/2014 11:10 AM, wei.y...@windriver.com wrote: From: Yang Wei wei.y...@windriver.com We do not need to trace read_sched_clock function, so add notrace attribute for this function. Signed-off-by: Yang Wei wei.y...@windriver.com

Re: [RFC PATCH v1 1/1] powerpc/85xx: Wakeup kexec smp slave cpus in second kernel

2013-09-03 Thread Yang,Wei
On 08/31/2013 05:12 PM, Yu Chen wrote: >From 1ccf579b871dfd5938ce958f729361a203485c74 Mon Sep 17 00:00:00 2001 From: Yu Chen Date: Sat, 31 Aug 2013 23:52:31 +0800 Subject: [PATCH] powerpc/85xx: Wakeup kexec smp slave cpus in second kernel In current 85xx smp kexec implementation,master cpu

Re: [RFC PATCH v1 1/1] powerpc/85xx: Wakeup kexec smp slave cpus in second kernel

2013-09-03 Thread Yang,Wei
On 08/31/2013 05:12 PM, Yu Chen wrote: From 1ccf579b871dfd5938ce958f729361a203485c74 Mon Sep 17 00:00:00 2001 From: Yu Chen chenyu...@gmail.com Date: Sat, 31 Aug 2013 23:52:31 +0800 Subject: [PATCH] powerpc/85xx: Wakeup kexec smp slave cpus in second kernel In current 85xx smp kexec