Re: [PATCH V2 2/2] serial: 8250_omap: Fix gpio check for auto RTS/CTS

2019-10-06 Thread Yegor Yefremov
r those individual pins instead of > checking for the structure itself to restore auto RTS/CTS. > > Signed-off-by: Adam Ford Reviewed-by: Yegor Yefremov > --- > V2: Made the NULL dererence check from patch 1/2 come before this. > > diff --git a/drivers/tty/serial/8250/8

Re: [PATCH V2 1/2] serial: mctrl_gpio: Check for NULL pointer

2019-10-06 Thread Yegor Yefremov
ill also return NULL. > > Signed-off-by: Adam Ford Reviewed-by: Yegor Yefremov > --- > V2: This patch is new to the V2 of this series, so patch 2/2 can > work without risking a NULL dereference > diff --git a/drivers/tty/serial/serial_mctrl_gpio.c > b/drivers/tt

Re: [PATCH] serial: 8250_omap: Fix gpio check for auto RTS and CTS

2019-10-06 Thread Yegor Yefremov
On Sun, Oct 6, 2019 at 5:49 PM Adam Ford wrote: > > On Sun, Oct 6, 2019 at 7:34 AM Yegor Yefremov > wrote: > > > > On Sun, Oct 6, 2019 at 1:38 PM Adam Ford wrote: > > > > > > On Sun, Oct 6, 2019 at 6:21 AM Yegor Yefremov > > > wrote: > > &g

Re: [PATCH] serial: 8250_omap: Fix gpio check for auto RTS and CTS

2019-10-06 Thread Yegor Yefremov
On Sun, Oct 6, 2019 at 1:38 PM Adam Ford wrote: > > On Sun, Oct 6, 2019 at 6:21 AM Yegor Yefremov > wrote: > > > > Hi Adam, > > > > On Sun, Oct 6, 2019 at 4:33 AM Adam Ford wrote: > > > > > > There are two checks to see if the manual gpio is

Re: [PATCH] serial: 8250_omap: Fix gpio check for auto RTS and CTS

2019-10-06 Thread Yegor Yefremov
Hi Adam, On Sun, Oct 6, 2019 at 4:33 AM Adam Ford wrote: > > There are two checks to see if the manual gpio is configured, but > these the check is seeing if the structure is NULL instead it > should check to see if there are CTS and/or RTS pins defined. > > This patch uses checks for those indiv

Re: DM3730 Bluetooth Performance differences between SERIAL_8250_OMAP vs SERIAL_OMAP

2019-10-04 Thread Yegor Yefremov
Hi Adam, On Fri, Oct 4, 2019 at 12:39 PM Adam Ford wrote: > > On Fri, Oct 4, 2019 at 5:02 AM Adam Ford wrote: > > > > I am running Kernel 5.3.2 trying to troubleshoot some intermittent > > Bluetooth issues, and I think I have narrowed it down to the serial > > driver in use. > > I should have al

Re: [PATCH 3/3 v7] tty/serial/8250: use mctrl_gpio helpers

2019-06-18 Thread Yegor Yefremov
On Mon, Jun 17, 2019 at 5:00 PM Stefan Roese wrote: > > From: Yegor Yefremov > > This patch permits the usage for GPIOs to control > the CTS/RTS/DTR/DSR/DCD/RI signals. > > Changed by Stefan: > Only call mctrl_gpio_init(), if the device has no ACPI companion device >

Re: [PATCH 2/3 v7] serial: 8250: Add MSR/MCR TIOCM conversion wrapper functions

2019-06-18 Thread Yegor Yefremov
gt; Suggested-by: Andy Shevchenko > Reviewed-by: Andy Shevchenko > Reviewed-by: Mika Westerberg > Cc: Mika Westerberg > Cc: Andy Shevchenko > Cc: Yegor Yefremov > Cc: Greg Kroah-Hartman > Cc: Giulio Benetti Tested-by: Yegor Yefremov > --- > v7: > - No c

Re: [PATCH 1/3 v7] serial: mctrl_gpio: Check if GPIO property exisits before requesting it

2019-06-18 Thread Yegor Yefremov
many existing machines out there so maybe we can limit this to > only DT enabled machines. Or alternatively probe if the property first > exists before trying to acquire the GPIOs (using > device_property_present()). > " > > This patch implements the fix suggested by Mika in his statement ab

Re: [PATCH 3/3 v6] tty/serial/8250: use mctrl_gpio helpers

2019-06-17 Thread Yegor Yefremov
On Mon, Jun 17, 2019 at 2:42 PM Stefan Roese wrote: > > On 17.06.19 11:51, Yegor Yefremov wrote: > > > > >>> @@ -1944,11 +1948,15 @@ unsigned int serial8250_do_get_mctrl(struct > >>> uart_port *port) > >>> { > >

Re: [PATCH 3/3 v6] tty/serial/8250: use mctrl_gpio helpers

2019-06-17 Thread Yegor Yefremov
On Mon, Jun 17, 2019 at 11:40 AM Yegor Yefremov wrote: > > On Thu, Jun 13, 2019 at 5:45 PM Stefan Roese wrote: > > > > From: Yegor Yefremov > > > > This patch permits the usage for GPIOs to control > > the CTS/RTS/DTR/DSR/DCD/RI signals. > > > >

Re: [PATCH 3/3 v6] tty/serial/8250: use mctrl_gpio helpers

2019-06-17 Thread Yegor Yefremov
On Thu, Jun 13, 2019 at 5:45 PM Stefan Roese wrote: > > From: Yegor Yefremov > > This patch permits the usage for GPIOs to control > the CTS/RTS/DTR/DSR/DCD/RI signals. > > Changed by Stefan: > Only call mctrl_gpio_init(), if the device has no ACPI companion device >

Re: [PATCH 1/3 v6] serial: mctrl_gpio: Check if GPIO property exisits before requesting it

2019-06-14 Thread Yegor Yefremov
On Fri, Jun 14, 2019 at 11:29 AM Stefan Roese wrote: > > On 14.06.19 11:04, Yegor Yefremov wrote: > > On Thu, Jun 13, 2019 at 7:08 PM Andy Shevchenko > > wrote: > >> > >> On Thu, Jun 13, 2019 at 05:45:40PM +0200, Stefan Roese wrote: > >>> This pat

Re: [PATCH 1/3 v6] serial: mctrl_gpio: Check if GPIO property exisits before requesting it

2019-06-14 Thread Yegor Yefremov
the fix suggested by Mika in his statement above. > > > > Reviewed-by: Andy Shevchenko I cannot compile the driver without adding #include to drivers/tty/serial/serial_mctrl_gpio.c. My platform is AM335X (OMAP3). I've tried the patches both against the main repo and also tty-next.

[PATCH] Documentation: display: fix wrong documentation paths

2017-01-07 Thread Yegor Yefremov
Signed-off-by: Yegor Yefremov --- Documentation/devicetree/bindings/display/arm,pl11x.txt | 2 +- Documentation/devicetree/bindings/display/bridge/analogix_dp.txt| 2 +- Documentation/devicetree/bindings/display/cirrus,clps711x-fb.txt| 2 +- Documentation

Re: [PATCH net-next v4 0/4] Fix OdroidC2 Gigabit Tx link issue

2017-01-05 Thread Yegor Yefremov
Hi Russel, On Fri, Jan 6, 2017 at 12:25 AM, Russell King - ARM Linux wrote: > On Mon, Nov 28, 2016 at 09:54:28AM -0800, Florian Fainelli wrote: >> If we start supporting generic "enable", "disable" type of properties >> with values that map directly to register definitions of the HW, we >> leave

Re: [PATCH] Documentation: ti-syscon-reset: fix header path

2016-12-12 Thread Yegor Yefremov
On Mon, Dec 12, 2016 at 7:40 PM, Rob Herring wrote: > On Fri, Dec 09, 2016 at 11:11:27AM +0100, yegorsli...@googlemail.com wrote: >> From: Yegor Yefremov >> >> 'include' was missing from path. >> >> Signed-off-by: Yegor Yefremov >> --- >

Re: [PATCH net-next v3 1/4] net: phy: add an option to disable EEE advertisement

2016-11-28 Thread Yegor Yefremov
dle seems to be causing issues, even > breaking the link some cases. The patch provides a convenient way for these > platforms to disable EEE advertisement and work around the issue. > > Signed-off-by: Jerome Brunet Tested using Baltos ir2110 device (cpsw + at8035 PHY). Tested-by: Yegor

Re: [PATCH net-next v3 2/4] dt-bindings: net: add EEE capability constants

2016-11-28 Thread Yegor Yefremov
On Mon, Nov 28, 2016 at 10:46 AM, Jerome Brunet wrote: > Signed-off-by: Jerome Brunet Tested using Baltos ir2110 device (cpsw + at8035 PHY). Tested-by: Yegor Yefremov > --- > include/dt-bindings/net/mdio.h | 19 +++ > 1 file changed, 19 insertions(+) > cre

Re: [PATCH] MIPS: ath79: Add initial support for the HAPROXY Aloha Pocket board

2016-10-05 Thread Yegor Yefremov
Hi Neil, On Tue, Oct 4, 2016 at 12:21 PM, Neil Armstrong wrote: > On 10/04/2016 12:14 PM, Yegor Yefremov wrote: >> On Tue, Oct 4, 2016 at 12:11 PM, Neil Armstrong >> wrote: >>> On 10/04/2016 12:09 PM, Yegor Yefremov wrote: >>>> Hi Neil, >>>> >

Re: [PATCH] MIPS: ath79: Add initial support for the HAPROXY Aloha Pocket board

2016-10-04 Thread Yegor Yefremov
On Tue, Oct 4, 2016 at 12:11 PM, Neil Armstrong wrote: > On 10/04/2016 12:09 PM, Yegor Yefremov wrote: >> Hi Neil, >> >> On Tue, Oct 4, 2016 at 11:40 AM, Neil Armstrong >> wrote: >>> On 10/04/2016 11:09 AM, Alban wrote: >>>> On Mon, 3 Oc

Re: [PATCH] MIPS: ath79: Add initial support for the HAPROXY Aloha Pocket board

2016-10-04 Thread Yegor Yefremov
Hi Neil, On Tue, Oct 4, 2016 at 11:40 AM, Neil Armstrong wrote: > On 10/04/2016 11:09 AM, Alban wrote: >> On Mon, 3 Oct 2016 17:35:31 +0200 >> Neil Armstrong wrote: >> >>> The HAPROXY Aloha pocket board is a Load Balancer demo board based on the >>> Atheros AR9331 SoC with 64Mbytes DDR and 16Mb

Re: tty/serial/8250: use mctrl_gpio helpers - Causes problems on ACPI systems

2016-08-18 Thread Yegor Yefremov
Hi Uwe, On Tue, Aug 9, 2016 at 6:07 PM, Andy Shevchenko wrote: > +Peter > > On Tue, 2016-08-09 at 16:02 +0300, Mika Westerberg wrote: >> Hi, >> >> I noticed that with v4.8-rc1 serial console of some of our Broxton >> systems does not work properly anymore. I'm able to see output but >> input >> d

Re: [PATCHv2] musb_host: fix lockup on rxcsr_h_error

2016-05-04 Thread Yegor Yefremov
On Tue, May 3, 2016 at 4:35 PM, Bin Liu wrote: > Hi, > > On Tue, May 03, 2016 at 04:25:58PM +0200, Yegor Yefremov wrote: >> On Tue, May 3, 2016 at 3:48 PM, Bin Liu wrote: >> > Hi, >> > >> > On Tue, May 03, 2016 at 12:03:52PM +0200, Yegor Yefremov wrote:

Re: [PATCHv2] musb_host: fix lockup on rxcsr_h_error

2016-05-03 Thread Yegor Yefremov
On Tue, May 3, 2016 at 3:48 PM, Bin Liu wrote: > Hi, > > On Tue, May 03, 2016 at 12:03:52PM +0200, Yegor Yefremov wrote: >> On Thu, Apr 28, 2016 at 4:37 PM, Bin Liu wrote: >> > Hi, >> > >> > On Thu, Apr 28, 2016 at 09:51:37AM +0300, Maxim Uvarov wr

Re: [PATCHv2] musb_host: fix lockup on rxcsr_h_error

2016-05-03 Thread Yegor Yefremov
t;> >> if (USB_ENDPOINT_XFER_ISOC != qh->type) { >> > > Thanks for testing it. Have tested your patch and now both FT4232 and Huawei don't freeze on removal. Bin, Max thanks for fixing this issue. Tested-by: Yegor Yefremov >> That I think a key

Re: [PATCH v2] serial: mctrl_gpio: Drop support for out1-gpios and out2-gpios

2016-04-29 Thread Yegor Yefremov
l_mctrl_gpio.h >> index bcfad5d1db61decf..332a33ab0647cbe3 100644 >> --- a/drivers/tty/serial/serial_mctrl_gpio.h >> +++ b/drivers/tty/serial/serial_mctrl_gpio.h >> @@ -32,8 +32,6 @@ enum mctrl_gpio_idx { >> UART_GPIO_RI = UART_GPIO_RNG, >> UART_GPIO_RTS, >> UART_GPIO_DTR, >> - UART_GPIO_OUT1, >> - UART_GPIO_OUT2, >> UART_GPIO_MAX, >> }; >> >> -- >> 1.9.1 >> > It seems all right now ! > > > Reviewed-by: Richard Genoud Reviewed-by: Yegor Yefremov

Re: [PATCH v2] tty/serial/8250: fix RS485 half-duplex RX

2016-03-30 Thread Yegor Yefremov
On Thu, Mar 24, 2016 at 9:03 AM, wrote: > From: Yegor Yefremov > > When in half-duplex mode RX will be disabled before TX, but not > enabled after deactivating transmitter. This patch enables > UART_IER_RLSI and UART_IER_RDI interrupts after TX is over. > > Cc: Matwey V. K

Re: [PATCH 10/13] tty: serial: omap: remove some dead code

2014-04-25 Thread Yegor Yefremov
On Fri, Apr 25, 2014 at 11:34 AM, NeilBrown wrote: > On Thu, 24 Apr 2014 15:19:14 +0100 One Thousand Gnomes > wrote: > >> > > But I don't have discrete hardware. I have a bunch of stuff soldered >> > > onto a >> > > board with ad-hoc connections chosen to make the life of the hardware >> > > b

Re: [PATCH v4 0/8] wilink: add device tree support

2014-03-06 Thread Yegor Yefremov
On Fri, Feb 28, 2014 at 10:22 AM, Alexandre Belloni wrote: > On 28/02/2014 at 08:26:46 +0100, Yegor Yefremov wrote : >> >> What is the state of the series? Who is now responsible for the >> patches? What issues were still not handled? >> > > We probably want to

Re: [PATCH v4 0/8] wilink: add device tree support

2014-02-27 Thread Yegor Yefremov
On Tue, Jul 30, 2013 at 3:04 PM, Luciano Coelho wrote: > Hi, > > This patch series adds device tree support to the wlcore_sdio driver, > which is used by WiLink6, WiLink7 and WiLink8. > > The first patches do some clean-up to make the data needed in the > wilink device tree node smaller. The rema

Re: am33xx beaglebone mainline status?

2012-11-27 Thread Yegor Yefremov
On Tue, Nov 27, 2012 at 1:58 PM, Richard Cochran wrote: > On Tue, Nov 27, 2012 at 09:41:51AM +0100, Tim Sander wrote: >> Hi >> >> I have been trying to get the 3.7-rc6 kernel to compile for a beaglebone >> board >> with device tree but it seems there are still bits missing. Especially it >> seems