Re: [PATCH 1/1] scripts/checkpatch.pl: to give more detailed warning message in case printk is used in any patch

2014-03-02 Thread Yogesh Chaudhari
On 2 March 2014 21:19, Levente Kurusa wrote: > Hi, > > 2014-03-02 16:40 GMT+01:00 Joe Perches : >> On Sun, 2014-03-02 at 16:20 +0100, Levente Kurusa wrote: >>> IMHO, this message is too big. The one we already have is nice and clean. >>> I would simply do: s/netdev/[subsystem]/ or something among

[PATCH 1/1] scripts/checkpatch.pl: to give more detailed warning message in case printk is used in any patch

2014-03-02 Thread Yogesh Chaudhari
/checkpatch.pl to give more detailed warning message in case printk is used in any patch. Signed-off-by: Yogesh Chaudhari --- scripts/checkpatch.pl | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 464dcef..526f33aa 100755

scripts/checkpatch.pl

2014-03-02 Thread Yogesh Chaudhari
Hello, I recently ran "scripts/checkpatch.pl" after adding the simplest form of "hello world" module to the source tree. I used the old "printk"s in this module and got this warning message: WARNING: Prefer netdev_dbg(netdev, ... then dev_dbg(dev, ... then pr_debug(... to printk(KERN_DEBUG ...

scripts/checkpatch.pl

2014-03-02 Thread Yogesh Chaudhari
Hello, I recently ran scripts/checkpatch.pl after adding the simplest form of hello world module to the source tree. I used the old printks in this module and got this warning message: WARNING: Prefer netdev_dbg(netdev, ... then dev_dbg(dev, ... then pr_debug(... to printk(KERN_DEBUG ... It

[PATCH 1/1] scripts/checkpatch.pl: to give more detailed warning message in case printk is used in any patch

2014-03-02 Thread Yogesh Chaudhari
/checkpatch.pl to give more detailed warning message in case printk is used in any patch. Signed-off-by: Yogesh Chaudhari mr.yog...@gmail.com --- scripts/checkpatch.pl | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 464dcef

Re: [PATCH 1/1] scripts/checkpatch.pl: to give more detailed warning message in case printk is used in any patch

2014-03-02 Thread Yogesh Chaudhari
On 2 March 2014 21:19, Levente Kurusa le...@linux.com wrote: Hi, 2014-03-02 16:40 GMT+01:00 Joe Perches j...@perches.com: On Sun, 2014-03-02 at 16:20 +0100, Levente Kurusa wrote: IMHO, this message is too big. The one we already have is nice and clean. I would simply do: