Re: [PATCH v2, 3/5] Revert "dt-bindings: mailbox: mtk-gce: fix incorrect mbox-cells value"

2021-04-13 Thread Yongqiang Niu
On Wed, 2021-04-14 at 07:38 +0800, Chun-Kuang Hu wrote: > Hi, Yongqiang: > > Yongqiang Niu 於 2021年4月12日 週一 下午7:19寫道: > > > > This reverts commit f83b03fc727ab56a77e68713d6e40299698f3c9f. > > > > Signed-off-by: Yongqiang Niu > > --- > > Documentatio

[PATCH v7, 5/5] drm/mediatek: add support for mediatek SOC MT8192

2021-04-12 Thread Yongqiang Niu
add support for mediatek SOC MT8192 Signed-off-by: Yongqiang Niu Signed-off-by: Hsin-Yi Wang Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/mtk_disp_ccorr.c | 6 + drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 20 +++ drivers/gpu/drm/mediatek/mtk_disp_rdma.c | 6

[PATCH v7, 3/5] drm/mediatek: add component RDMA4

2021-04-12 Thread Yongqiang Niu
This patch add component RDMA4 Signed-off-by: Yongqiang Niu Reviewed-by: Chun-Kuang Hu Signed-off-by: Hsin-Yi Wang --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/drm/mediatek

[PATCH v7, 4/5] soc: mediatek: add mtk mutex support for MT8192

2021-04-12 Thread Yongqiang Niu
Add mtk mutex support for MT8192 SoC. Signed-off-by: Yongqiang Niu Signed-off-by: Hsin-Yi Wang Reviewed-by: CK Hu --- drivers/soc/mediatek/mtk-mutex.c | 35 +++ 1 file changed, 35 insertions(+) diff --git a/drivers/soc/mediatek/mtk-mutex.c b/drivers/soc

[PATCH v7, 1/5] drm/mediatek: add component OVL_2L2

2021-04-12 Thread Yongqiang Niu
This patch add component OVL_2L2 Signed-off-by: Yongqiang Niu Reviewed-by: Chun-Kuang Hu Signed-off-by: Hsin-Yi Wang --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/drm/mediatek

[PATCH v7, 0/5] drm/mediatek: add support for mediatek SOC MT8192

2021-04-12 Thread Yongqiang Niu
This series are based on Linux v5.12-rc2 and following patch: https://patchwork.kernel.org/project/linux-mediatek/cover/1618236288-1617-1-git-send-email-yongqiang@mediatek.com/ Change since v6: - rebase Yongqiang Niu (5): drm/mediatek: add component OVL_2L2 drm/mediatek: add component

[PATCH v7, 2/5] drm/mediatek: add component POSTMASK

2021-04-12 Thread Yongqiang Niu
This patch add component POSTMASK. Signed-off-by: Yongqiang Niu Signed-off-by: Hsin-Yi Wang Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 102 drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h | 1 + 2 files changed, 73 insertions(+), 30

[PATCH v5, 2/4] soc: mediatek: mmsys: add component POSTMASK

2021-04-12 Thread Yongqiang Niu
This patch add component POSTMASK Signed-off-by: Yongqiang Niu --- include/linux/soc/mediatek/mtk-mmsys.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/soc/mediatek/mtk-mmsys.h b/include/linux/soc/mediatek/mtk-mmsys.h index f6b58f9..7718cd6 100644 --- a/include/linux/soc

[PATCH v5, 4/4] soc: mediatek: mmsys: Add mt8192 mmsys routing table

2021-04-12 Thread Yongqiang Niu
mt8192 has different routing registers than mt8183 Signed-off-by: Yongqiang Niu --- drivers/soc/mediatek/mt8192-mmsys.h | 68 + drivers/soc/mediatek/mtk-mmsys.c| 7 2 files changed, 75 insertions(+) create mode 100644 drivers/soc/mediatek/mt8192

[PATCH v5, 1/4] soc: mediatek: mmsys: add component OVL_2L2

2021-04-12 Thread Yongqiang Niu
This patch add component OVL_2L2 Signed-off-by: Yongqiang Niu Reviewed-by: Chun-Kuang Hu --- include/linux/soc/mediatek/mtk-mmsys.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/soc/mediatek/mtk-mmsys.h b/include/linux/soc/mediatek/mtk-mmsys.h index 2228bf6..f6b58f9 100644

[PATCH v5, 3/4] soc: mediatek: mmsys: add component RDMA4

2021-04-12 Thread Yongqiang Niu
This patch add component RDMA4 Signed-off-by: Yongqiang Niu Reviewed-by: Chun-Kuang Hu --- include/linux/soc/mediatek/mtk-mmsys.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/soc/mediatek/mtk-mmsys.h b/include/linux/soc/mediatek/mtk-mmsys.h index 7718cd6..4bba275 100644

[PATCH v5, 0/4] soc: mediatek: mmsys: add mt8192 mmsys support

2021-04-12 Thread Yongqiang Niu
base 5.12-rc2 and https://patchwork.kernel.org/project/linux-mediatek/patch/20210330110423.3542163-1-hsi...@chromium.org/ Change since v4: - use routing table Yongqiang Niu (4): soc: mediatek: mmsys: add component OVL_2L2 soc: mediatek: mmsys: add component POSTMASK soc: mediatek: mmsys

[PATCH v4, 1/3] dt-binding: gce: add gce header file for mt8192

2021-04-12 Thread Yongqiang Niu
Add documentation for the mt8192 gce. Add gce header file defined the gce hardware event, subsys number and constant for mt8192. Signed-off-by: Yongqiang Niu Reviewed-by: Rob Herring Signed-off-by: Hsin-Yi Wang --- .../devicetree/bindings/mailbox/mtk-gce.txt| 7 +- include/dt

[PATCH v4, 2/3] arm64: dts: mt8192: add gce node

2021-04-12 Thread Yongqiang Niu
add gce node for mt8192 Signed-off-by: Yongqiang Niu Signed-off-by: Hsin-Yi Wang --- arch/arm64/boot/dts/mediatek/mt8192.dtsi | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi b/arch/arm64/boot/dts/mediatek/mt8192.dtsi index 9757138

[PATCH v4, 3/3] mailbox: cmdq: add mt8192 support

2021-04-12 Thread Yongqiang Niu
add mt8192 support Signed-off-by: Yongqiang Niu Signed-off-by: Hsin-Yi Wang --- drivers/mailbox/mtk-cmdq-mailbox.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c index e0d9a86..8da700a 100644

[PATCH v4, 0/3] support gce on mt8192 platform

2021-04-12 Thread Yongqiang Niu
Change since v3: -fix review comment in v2 Change since v2: - add controy_by_sw for mt8192 Change since v1: - move out shift jump patch - remove useless patch Yongqiang Niu (3): dt-binding: gce: add gce header file for mt8192 arm64: dts: mt8192: add gce node mailbox: cmdq: add mt8192

[PATCH v2, 5/5] arm64: dts: mediatek: mt8183: add gce information for mmsys

2021-04-12 Thread Yongqiang Niu
add gce information for mmsys Signed-off-by: Yongqiang Niu --- arch/arm64/boot/dts/mediatek/mt8183.dtsi | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi index bc89283..e3a8b10 100644 --- a/arch/arm64/boot

[PATCH v2, 2/5] Revert "mailbox: mediatek: remove implementation related to atomic_exec"

2021-04-12 Thread Yongqiang Niu
This reverts commit c9ea564f3d9dd20d88bd34f40a6ff6d31a0d7e8c. Signed-off-by: Yongqiang Niu --- drivers/mailbox/mtk-cmdq-mailbox.c | 80 +- 1 file changed, 71 insertions(+), 9 deletions(-) diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk

[PATCH v2, 1/5] Revert "drm/mediatek: Make sure previous message done or be aborted before send"

2021-04-12 Thread Yongqiang Niu
This reverts commit 839cbf0531428f3f9535077a461b8631359c1165. Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c index 8b0de90..c76f446

[PATCH v2, 4/5] Revert "arm64: dts: mediatek: mt8183: fix gce incorrect mbox-cells value"

2021-04-12 Thread Yongqiang Niu
This reverts commit e55c56df43dd11de4a6c08e3ea52ca45b51c8800. Signed-off-by: Yongqiang Niu --- arch/arm64/boot/dts/mediatek/mt8183.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi index

[PATCH v2, 3/5] Revert "dt-bindings: mailbox: mtk-gce: fix incorrect mbox-cells value"

2021-04-12 Thread Yongqiang Niu
This reverts commit f83b03fc727ab56a77e68713d6e40299698f3c9f. Signed-off-by: Yongqiang Niu --- Documentation/devicetree/bindings/mailbox/mtk-gce.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/mailbox/mtk-gce.txt b/Documentation

[PATCH v2, 0/5] Revert "mailbox: mediatek: remove implementation related to atomic_exec"

2021-04-12 Thread Yongqiang Niu
This series base linux 5.12-rc2 these patches will cause home ui flick when cursor moved, there is no fix solution yet, revert these patches first. change since v1: add mtk-gce.txt and dts modification Yongqiang Niu (5): Revert "drm/mediatek: Make sure previous message done or be ab

Re: [PATCH v1, 3/3] drm/mediatek: gamma set with cmdq

2021-04-12 Thread Yongqiang Niu
On Mon, 2021-04-12 at 16:28 +0800, CK Hu wrote: > Hi, Yongqiang: > > On Mon, 2021-04-12 at 14:35 +0800, Yongqiang Niu wrote: > > gamma lut set in vsync active will caused display flash issue > > set gamma lut with cmdq > > In MT8173, it's ok to set gammma out o

[PATCH v1] drm/mediatek: adjust rdma fifo threshold calculate formula

2021-04-12 Thread Yongqiang Niu
the orginal formula will caused rdma fifo threshold config overflow Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_disp_rdma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mediatek/mtk_disp_rdma.c b/drivers/gpu/drm/mediatek/mtk_disp_rdma.c

adjust rdma fifo threshold calculate formula

2021-04-12 Thread Yongqiang Niu
This patch base Linux 5.12-rc2 provide one patch Yongqiang Niu (1): drm/mediatek: adjust rdma fifo threshold calculate formula drivers/gpu/drm/mediatek/mtk_disp_rdma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 1.8.1.1.dirty

[PATCH v1, 1/3] drm/mediatek: Separate aal module

2021-04-12 Thread Yongqiang Niu
mt8183 aal has no gamma function Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/Makefile | 3 +- drivers/gpu/drm/mediatek/mtk_disp_aal.c | 167 drivers/gpu/drm/mediatek/mtk_disp_drv.h | 9 ++ drivers/gpu/drm/mediatek

[PATCH v1, 3/3] drm/mediatek: gamma set with cmdq

2021-04-12 Thread Yongqiang Niu
gamma lut set in vsync active will caused display flash issue set gamma lut with cmdq Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_disp_aal.c | 4 ++-- drivers/gpu/drm/mediatek/mtk_disp_drv.h | 7 --- drivers/gpu/drm/mediatek/mtk_disp_gamma.c | 11

[PATCH v1, 2/3] arm64: dts: mt8183: refine aal compatible name

2021-04-12 Thread Yongqiang Niu
mt8183 aal is different with mt8173 remove mt8173 compatible name for mt8183 aal Signed-off-by: Yongqiang Niu --- arch/arm64/boot/dts/mediatek/mt8183.dtsi | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts

[PATCH v1, 0/3] gamma set with cmdq

2021-04-12 Thread Yongqiang Niu
This series are based on 5.12-rc2 and provide 3 patch to set gamma lut with cmdq Yongqiang Niu (3): drm/mediatek: Separate aal module arm64: dts: mt8183: refine aal compatible name drm/mediatek: gamma set with cmdq arch/arm64/boot/dts/mediatek/mt8183.dtsi| 3 +- drivers/gpu/drm

[RESEND PATCH v1 2/2] Revert "mailbox: mediatek: remove implementation related to atomic_exec"

2021-03-10 Thread Yongqiang Niu
This reverts commit c9ea564f3d9dd20d88bd34f40a6ff6d31a0d7e8c. Signed-off-by: Yongqiang Niu --- drivers/mailbox/mtk-cmdq-mailbox.c | 80 +- 1 file changed, 71 insertions(+), 9 deletions(-) diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk

[RESEND PATCH v1 0/2] Revert "mailbox: mediatek: remove implementation related to atomic_exec"

2021-03-10 Thread Yongqiang Niu
This series base linux 5.12-rc1 these two patches will cause home ui flick when cursor moved, there is no fix solution yet, revert these patches first. change since v1: fix build error Yongqiang Niu (2): Revert "drm/mediatek: Make sure previous message done or be aborted before

[RESEND PATCH v1 1/2] Revert "drm/mediatek: Make sure previous message done or be aborted before send"

2021-03-10 Thread Yongqiang Niu
This reverts commit 839cbf0531428f3f9535077a461b8631359c1165. Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c index 8b0de90..c76f446

[PATCH v1 2/2] Revert "mailbox: mediatek: remove implementation related to atomic_exec"

2021-03-09 Thread Yongqiang Niu
This reverts commit c9ea564f3d9dd20d88bd34f40a6ff6d31a0d7e8c. Signed-off-by: Yongqiang Niu pa_base, prev_task->pkt->cmd_buf_size, DMA_TO_DEVICE); prev_task_base[CMDQ_NUM_CMD(prev_task->pkt) - 1] = - (u64)CMDQ_JUMP_BY_PA << 32

[PATCH v1 0/2] Revert "mailbox: mediatek: remove implementation related to atomic_exec"

2021-03-09 Thread Yongqiang Niu
This series base linux 5.12-rc1 these two patches will cause home ui flick when cursor moved, there is no fix solution yet, revert these patches first. Yongqiang Niu (2): Revert "drm/mediatek: Make sure previous message done or be aborted before send" Revert "mailbox: m

[PATCH v1 1/2] Revert "drm/mediatek: Make sure previous message done or be aborted before send"

2021-03-09 Thread Yongqiang Niu
This reverts commit 839cbf0531428f3f9535077a461b8631359c1165. Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c index 8b0de90..c76f446

[PATCH v1] move page flip handle into cmdq cb

2021-02-19 Thread Yongqiang Niu
irq callback will before cmdq flush ddp register into hardware, that will cause the display frame page flip event before it realy display out time Yongqiang Niu (1): CHROMIUM: drm/mediatek: move page flip handle into cmdq cb drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 33

[PATCH v1] drm/mediatek: move page flip handle into cmdq cb

2021-02-19 Thread Yongqiang Niu
move page flip handle into cmdq cb irq callback will before cmdq flush ddp register into hardware, that will cause the display frame page flip event before it realy display out time Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 33

Re: [PATCH v12 6/8] drm/mediatek: enable dither function

2021-01-28 Thread Yongqiang Niu
On Fri, 2021-01-29 at 14:46 +0800, Hsin-Yi Wang wrote: > On Fri, Jan 29, 2021 at 2:30 PM Yongqiang Niu > wrote: > > > > On Fri, 2021-01-29 at 14:24 +0800, Hsin-Yi Wang wrote: > > > On Fri, Jan 29, 2021 at 9:33 AM CK Hu wrote: > > > > > > > > Hi

Re: [PATCH v12 6/8] drm/mediatek: enable dither function

2021-01-28 Thread Yongqiang Niu
On Fri, 2021-01-29 at 14:24 +0800, Hsin-Yi Wang wrote: > On Fri, Jan 29, 2021 at 9:33 AM CK Hu wrote: > > > > Hi, Hsin-Yi: > > > > On Thu, 2021-01-28 at 19:23 +0800, Hsin-Yi Wang wrote: > > > From: Yongqiang Niu > > > > > > for 5 or 6 bpc

Re: [PATCH v11 7/9] drm/mediatek: enable dither function

2021-01-28 Thread Yongqiang Niu
On Thu, 2021-01-28 at 16:28 +0800, CK Hu wrote: > On Thu, 2021-01-28 at 16:18 +0800, Hsin-Yi Wang wrote: > > On Thu, Jan 28, 2021 at 4:10 PM Yongqiang Niu > > wrote: > > > > > > On Thu, 2021-01-28 at 16:07 +0800, CK Hu wrote: > > > > On Thu, 2

Re: [PATCH v11 7/9] drm/mediatek: enable dither function

2021-01-28 Thread Yongqiang Niu
On Thu, 2021-01-28 at 16:18 +0800, Hsin-Yi Wang wrote: > On Thu, Jan 28, 2021 at 4:10 PM Yongqiang Niu > wrote: > > > > On Thu, 2021-01-28 at 16:07 +0800, CK Hu wrote: > > > On Thu, 2021-01-28 at 15:59 +0800, Yongqiang Niu wrote: > > > > On Thu,

Re: [PATCH v11 7/9] drm/mediatek: enable dither function

2021-01-28 Thread Yongqiang Niu
On Thu, 2021-01-28 at 16:07 +0800, CK Hu wrote: > On Thu, 2021-01-28 at 15:59 +0800, Yongqiang Niu wrote: > > On Thu, 2021-01-28 at 15:42 +0800, CK Hu wrote: > > > Hi, Hsin-Yi: > > > > > > On Thu, 2021-01-28 at 15:28 +0800, Hsin-Yi Wang wrote: > > >

Re: [PATCH v11 7/9] drm/mediatek: enable dither function

2021-01-28 Thread Yongqiang Niu
On Thu, 2021-01-28 at 15:42 +0800, CK Hu wrote: > Hi, Hsin-Yi: > > On Thu, 2021-01-28 at 15:28 +0800, Hsin-Yi Wang wrote: > > From: Yongqiang Niu > > > > for 5 or 6 bpc panel, we need enable dither function > > to improve the display quality > > > >

Re: [PATCH v3, 07/15] drm/mediatek: enable OVL_LAYER_SMI_ID_EN for multi-layer usecase

2021-01-27 Thread Yongqiang Niu
On Tue, 2021-01-12 at 07:59 +0800, Chun-Kuang Hu wrote: > Hi, Yongqiang: > > Yongqiang Niu 於 2021年1月11日 週一 下午3:44寫道: > > > > enable OVL_LAYER_SMI_ID_EN for multi-layer usecase > > Could you describe more information? Without this patch, what would happen? > wit

Re: [PATCH v4, 03/10] soc: mediatek: mmsys: move register operation into mmsys path select function

2021-01-20 Thread Yongqiang Niu
On Wed, 2021-01-20 at 20:38 +0100, Matthias Brugger wrote: > On Tue, Jan 05, 2021 at 11:06:26AM +0800, Yongqiang Niu wrote: > > move register operation into mmsys path select function > > Why do you want to do that. It seems the register access pattern is the > same for all SoC

[PATCH v3, 13/15] drm/mediatek: add matrix bits private data for ccorr

2021-01-10 Thread Yongqiang Niu
matrix bits of mt8183 is 12 matrix bits of mt8192 is 13 Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_disp_ccorr.c | 23 --- 1 file changed, 20 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ccorr.c b/drivers/gpu/drm/mediatek

[PATCH v3, 01/15] dt-bindings: mediatek: add description for postmask

2021-01-10 Thread Yongqiang Niu
add description for postmask postmask is used control round corner for display frame Signed-off-by: Yongqiang Niu --- Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/display/mediatek

[PATCH v3, 12/15] drm/mediatek: separate ccorr module

2021-01-10 Thread Yongqiang Niu
ccorr ctm matrix bits will be different in mt8192 Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/Makefile | 3 +- drivers/gpu/drm/mediatek/mtk_disp_ccorr.c | 222 drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 92 +--- drivers/gpu

[PATCH v3, 14/15] drm/mediatek: add DDP support for MT8192

2021-01-10 Thread Yongqiang Niu
Add DDP support for MT8192 SoC. Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 35 ++ 1 file changed, 35 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c index 1308046..7aa7fc3

[PATCH v3, 15/15] drm/mediatek: add support for mediatek SOC MT8192

2021-01-10 Thread Yongqiang Niu
add support for mediatek SOC MT8192 Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_disp_ccorr.c| 6 drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 20 + drivers/gpu/drm/mediatek/mtk_disp_postmask.c | 1 + drivers/gpu/drm/mediatek/mtk_disp_rdma.c | 6

[PATCH v3, 10/15] drm/mediatek: Add pm runtime support for color

2021-01-10 Thread Yongqiang Niu
color power domain need controled in the device. Signed-off-by: Yongqiang Niu Signed-off-by: Yidi Lin --- drivers/gpu/drm/mediatek/mtk_disp_color.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_disp_color.c b/drivers/gpu/drm/mediatek/mtk_disp_color.c

[PATCH v3, 11/15] drm/mediatek: fix aal size config

2021-01-10 Thread Yongqiang Niu
the orginal setting is not correct, fix it follow hardware data sheet. if keep this error setting, mt8173/mt8183 display ok but mt8192 display abnormal. Fixes: 0664d1392c26 (drm/mediatek: Add AAL engine basic function) Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek

[PATCH v3, 07/15] drm/mediatek: enable OVL_LAYER_SMI_ID_EN for multi-layer usecase

2021-01-10 Thread Yongqiang Niu
enable OVL_LAYER_SMI_ID_EN for multi-layer usecase Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c index b47c238..4934bee

[PATCH v3, 03/15] arm64: dts: mt8192: add display node

2021-01-10 Thread Yongqiang Niu
add display node Signed-off-by: Yongqiang Niu --- arch/arm64/boot/dts/mediatek/mt8192.dtsi | 134 +++ 1 file changed, 134 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi b/arch/arm64/boot/dts/mediatek/mt8192.dtsi index e12e024..dcf9fdf 100644

[PATCH v3, 06/15] drm/mediatek: add component RDMA4

2021-01-10 Thread Yongqiang Niu
This patch add component RDMA4 Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c index bc6b10a..fc01fea 100644 --- a/drivers

[PATCH v3, 05/15] drm/mediatek: add component POSTMASK

2021-01-10 Thread Yongqiang Niu
This patch add component POSTMASK, Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/Makefile| 1 + drivers/gpu/drm/mediatek/mtk_disp_postmask.c | 160 +++ drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 2 + drivers/gpu/drm/mediatek

[PATCH v3, 09/15] drm/mediatek: Add pm runtime support for gamma

2021-01-10 Thread Yongqiang Niu
gamma power domain need controled in the device. Signed-off-by: Yongqiang Niu Signed-off-by: Yidi Lin --- drivers/gpu/drm/mediatek/mtk_disp_gamma.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_disp_gamma.c b/drivers/gpu/drm/mediatek/mtk_disp_gamma.c

[PATCH v3, 08/15] drm/mediatek: check if fb is null

2021-01-10 Thread Yongqiang Niu
It's possible that state->base.fb is null. Add a check before access its format. Fixes: b6b1bb980ec4 ( drm/mediatek: Turn off Alpha bit when plane format has no alpha) Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 2 +- 1 file changed, 1 insertion(+), 1 delet

[PATCH v3, 00/15] drm/mediatek: add support for mediatek SOC MT8192

2021-01-10 Thread Yongqiang Niu
This series are based on 5.11-rc1 and SoC MT8183, and provide 15 patch to support mediatek SOC MT8192 Changes since v2: - fix review comment in v2 - add pm runtime for gamma and color - move ddp path select patch to mmsys series - remove some useless patch Yongqiang Niu (15): dt-bindings

[PATCH v3, 04/15] drm/mediatek: add component OVL_2L2

2021-01-10 Thread Yongqiang Niu
This patch add component OVL_2L2 Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c index 81ed076..a715127 100644

[PATCH v3, 02/15] dt-bindings: mediatek: add description for mt8192 display

2021-01-10 Thread Yongqiang Niu
add description for mt8192 display Signed-off-by: Yongqiang Niu Reviewed-by: Chun-Kuang Hu Acked-by: Rob Herring --- Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings

Re: [PATCH v2] soc: mediatek: cmdq: add address shift in jump

2021-01-07 Thread Yongqiang Niu
On Wed, 2020-12-23 at 16:34 +0800, Yongqiang Niu wrote: > Add address shift when compose jump instruction > to compatible with 35bit format. > > Fixes: 0858fde496f8 ("mailbox: cmdq: variablize address shift in platform") > > Signed-off-by: Yongqiang Niu &g

[PATCH v9, 10/11] drm/mediatek: add DDP support for MT8183

2021-01-06 Thread Yongqiang Niu
Add DDP support for MT8167 SoC. Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 48 ++ 1 file changed, 48 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c index 1f99db6..1308046

[PATCH v9, 11/11] This patch add support for mediatek SOC MT8183

2021-01-06 Thread Yongqiang Niu
1. add ovl private data 2. add rdma private data 3. add gamma privte data 4. add main and external path module for crtc create Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_disp_gamma.c | 1 + drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 18 + drivers/gpu/drm

[PATCH v9, 09/11] drm/mediatek: enable dither function

2021-01-06 Thread Yongqiang Niu
for 5 or 6 bpc panel, we need enable dither function to improve the display quality Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 38 - 1 file changed, 37 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mediatek

[PATCH v9, 07/11] drm/mediatek: separate gamma module

2021-01-06 Thread Yongqiang Niu
mt8183 gamma module will different with mt8173 separate gamma for add private data Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/Makefile | 1 + drivers/gpu/drm/mediatek/mtk_disp_gamma.c | 185 drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c

[PATCH v9, 05/11] drm/mediatek: add fifo_size into rdma private data

2021-01-06 Thread Yongqiang Niu
Get the fifo size from device tree because each rdma in the same SoC may have different fifo size Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_disp_rdma.c | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mediatek

[PATCH v9, 08/11] drm/mediatek: add has_dither private data for gamma

2021-01-06 Thread Yongqiang Niu
not all SoC has dither function in gamma module dd private data to control this function setting Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_disp_gamma.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_disp_gamma.c

[PATCH v9, 06/11] drm/mediatek: add RDMA fifo size error handle

2021-01-06 Thread Yongqiang Niu
This patch add RDMA fifo size error handle rdma fifo size will not always bigger than the calculated threshold if that case happened, we need set fifo size as the threshold Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_disp_rdma.c | 4 1 file changed, 4 insertions(+) diff

[PATCH v9, 02/11] dt-bindings: mediatek: add description for mt8183 display

2021-01-06 Thread Yongqiang Niu
add description for mt8183 display Signed-off-by: Yongqiang Niu Reviewed-by: Chun-Kuang Hu Acked-by: Rob Herring --- Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings

[PATCH v9, 04/11] arm64: dts: mt8183: refine gamma compatible name

2021-01-06 Thread Yongqiang Niu
mt8183 gamma is different with mt8173 remove mt8173 compatible name for mt8183 gamma Signed-off-by: Yongqiang Niu --- arch/arm64/boot/dts/mediatek/mt8183.dtsi | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts

[PATCH v9, 03/11] arm64: dts: mt8183: rename rdma fifo size

2021-01-06 Thread Yongqiang Niu
property name must include only lowercase and '-' Signed-off-by: Yongqiang Niu --- arch/arm64/boot/dts/mediatek/mt8183.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi index 5b782a4

[PATCH v9, 01/11] dt-bindings: mediatek: add rdma-fifo-size description for mt8183 display

2021-01-06 Thread Yongqiang Niu
rdma fifo size may be different even in same SOC, add this property to the corresponding rdma Signed-off-by: Yongqiang Niu --- .../devicetree/bindings/display/mediatek/mediatek,disp.txt | 9 + 1 file changed, 9 insertions(+) diff --git a/Documentation/devicetree/bindings/display

[PATCH v9, 00/11] drm/mediatek: add support for mediatek SOC MT8183

2021-01-06 Thread Yongqiang Niu
24 - enable allow_fb_modifiers for mediatek drm in patch 25 Yongqiang Niu (11): dt-bindings: mediatek: add rdma-fifo-size description for mt8183 display dt-bindings: mediatek: add description for mt8183 display arm64: dts: mt8183: rename rdma fifo size arm64: dts: mt8183: refine gamma

Re: [PATCH v8, 5/6] drm/mediatek: add RDMA fifo size error handle

2021-01-04 Thread Yongqiang Niu
On Mon, 2020-12-14 at 22:54 +0800, Chun-Kuang Hu wrote: > Hi, Yongqiang: > > Yongqiang Niu 於 2020年12月11日 週五 上午8:45寫道: > > > > On Thu, 2020-12-10 at 23:50 +0800, Chun-Kuang Hu wrote: > > > Hi, Yongqiang: > > > > > > Yongqiang Niu 於 2020年12月10日

[PATCH v4, 07/10] soc: mediatek: mmsys: add component POSTMASK

2021-01-04 Thread Yongqiang Niu
This patch add component POSTMASK Signed-off-by: Yongqiang Niu --- include/linux/soc/mediatek/mtk-mmsys.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/soc/mediatek/mtk-mmsys.h b/include/linux/soc/mediatek/mtk-mmsys.h index ed99122..13546e9 100644 --- a/include/linux/soc

[PATCH v4, 10/10] soc: mediatek: mmsys: add mt8192 mmsys support

2021-01-04 Thread Yongqiang Niu
add mt8192 mmsys support Signed-off-by: Yongqiang Niu --- drivers/soc/mediatek/mmsys/Makefile | 1 + drivers/soc/mediatek/mmsys/mt8192-mmsys.c | 149 ++ drivers/soc/mediatek/mmsys/mtk-mmsys.c| 9 ++ include/linux/soc/mediatek/mtk-mmsys.h| 1 + 4

[PATCH v4, 04/10] soc: mediatek: mmsys: Use function call for setting the routing registers

2021-01-04 Thread Yongqiang Niu
Actually, setting the registers for routing, use multiple 'if-else' for different routes, but this code would be more and more complicated while we support more and more SoCs. Change that and use a function call per SoC so the code will be more portable and clear. Signed-off-by: Yongqiang Niu

[PATCH v4, 05/10] soc: mediatek: mmsys: add mt8183 function call for setting the routing registers

2021-01-04 Thread Yongqiang Niu
add mt8183 function call for setting the routing registers Signed-off-by: Yongqiang Niu --- drivers/soc/mediatek/mmsys/Makefile | 1 + drivers/soc/mediatek/mmsys/mt8183-mmsys.c | 110 ++ drivers/soc/mediatek/mmsys/mtk-mmsys.c| 1 + include/linux/soc

[PATCH v4, 09/10] soc: mediatek: mmsys: Use function call for setting mmsys ovl mout register

2021-01-04 Thread Yongqiang Niu
Use function call for setting mmsys ovl mout register Signed-off-by: Yongqiang Niu --- drivers/soc/mediatek/mmsys/mtk-mmsys.c | 6 ++ include/linux/soc/mediatek/mtk-mmsys.h | 4 2 files changed, 10 insertions(+) diff --git a/drivers/soc/mediatek/mmsys/mtk-mmsys.c b/drivers/soc

[PATCH v4, 01/10] soc: mediatek: mmsys: create mmsys folder

2021-01-04 Thread Yongqiang Niu
the mmsys will more and more complicated after support more and more SoCs, add an independent folder will be more clear Signed-off-by: Yongqiang Niu --- drivers/soc/mediatek/Makefile | 2 +- drivers/soc/mediatek/mmsys/Makefile| 2 + drivers/soc/mediatek/mmsys/mtk-mmsys.c | 373

[PATCH v4, 06/10] soc: mediatek: mmsys: add component OVL_2L2

2021-01-04 Thread Yongqiang Niu
This patch add component OVL_2L2 Signed-off-by: Yongqiang Niu Reviewed-by: Chun-Kuang Hu --- include/linux/soc/mediatek/mtk-mmsys.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/soc/mediatek/mtk-mmsys.h b/include/linux/soc/mediatek/mtk-mmsys.h index 7e2c0fe..ed99122 100644

[PATCH v4, 08/10] soc: mediatek: mmsys: add component RDMA4

2021-01-04 Thread Yongqiang Niu
This patch add component RDMA4 Signed-off-by: Yongqiang Niu Reviewed-by: Chun-Kuang Hu --- include/linux/soc/mediatek/mtk-mmsys.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/soc/mediatek/mtk-mmsys.h b/include/linux/soc/mediatek/mtk-mmsys.h index 13546e9..2c11617 100644

[PATCH v4, 02/10] soc: mediatek: mmsys: Create struct mtk_mmsys to store context data

2021-01-04 Thread Yongqiang Niu
Apart from the driver data, in order to extend the driver to support more and more SoCs, we will need to store other configuration data. So, create a mtk_mmsys struct to encapsulate all that information. Signed-off-by: CK Hu Signed-off-by: Enric Balletbo i Serra Signed-off-by: Yongqiang Niu

[PATCH v4, 03/10] soc: mediatek: mmsys: move register operation into mmsys path select function

2021-01-04 Thread Yongqiang Niu
move register operation into mmsys path select function Signed-off-by: Yongqiang Niu --- drivers/soc/mediatek/mmsys/mtk-mmsys.c | 140 + 1 file changed, 71 insertions(+), 69 deletions(-) diff --git a/drivers/soc/mediatek/mmsys/mtk-mmsys.c b/drivers/soc/mediatek

[PATCH v4, 00/10] soc: mediatek: mmsys: Use function call for setting the routing registers

2021-01-04 Thread Yongqiang Niu
The following series are intended to prepare the mtk-mmsys driver to allow different DDP (Data Display Path) function call per SoC. base 5.11-rc1 change since v3: - move register operation into mmsys path select function Yongqiang Niu (10): soc: mediatek: mmsys: create mmsys folder soc

Re: [PATCH v3, 1/8] soc: mediatek: mmsys: create mmsys folder

2021-01-03 Thread Yongqiang Niu
On Thu, 2020-12-31 at 09:21 +0800, Nicolas Boichat wrote: > On Mon, Dec 28, 2020 at 4:38 PM Yongqiang Niu > wrote: > > > > the mmsys will more and more complicated after support > > more and more SoCs, add an independent folder will be > > more clear > &

Re: [PATCH v3, 1/8] soc: mediatek: mmsys: create mmsys folder

2021-01-03 Thread Yongqiang Niu
On Thu, 2020-12-31 at 09:21 +0800, Nicolas Boichat wrote: > On Mon, Dec 28, 2020 at 4:38 PM Yongqiang Niu > wrote: > > > > the mmsys will more and more complicated after support > > more and more SoCs, add an independent folder will be > > more clear > &

Re: [PATCH v3, 7/8] soc: mediatek: mmsys: Use function call for setting mmsys ovl mout register

2020-12-28 Thread Yongqiang Niu
On Tue, 2020-12-29 at 00:38 +0800, Chun-Kuang Hu wrote: > Hi, Yongqiang: > > Yongqiang Niu 於 2020年12月28日 週一 下午4:38寫道: > > > > Use function call for setting mmsys ovl mout register > > > > Signed-off-by: Yongqiang Niu > > --- > >

Re: [PATCH v3, 7/8] soc: mediatek: mmsys: Use function call for setting mmsys ovl mout register

2020-12-28 Thread Yongqiang Niu
On Tue, 2020-12-29 at 00:38 +0800, Chun-Kuang Hu wrote: > Hi, Yongqiang: > > Yongqiang Niu 於 2020年12月28日 週一 下午4:38寫道: > > > > Use function call for setting mmsys ovl mout register > > > > Signed-off-by: Yongqiang Niu > > --- > >

[PATCH v3, 8/8] soc: mediatek: mmsys: add mt8192 mmsys support

2020-12-28 Thread Yongqiang Niu
add mt8192 mmsys support Signed-off-by: Yongqiang Niu --- drivers/soc/mediatek/mmsys/Makefile | 1 + drivers/soc/mediatek/mmsys/mt8192-mmsys.c | 119 ++ drivers/soc/mediatek/mmsys/mtk-mmsys.c| 9 +++ include/linux/soc/mediatek/mtk-mmsys.h| 1 + 4

[PATCH v3, 6/8] soc: mediatek: mmsys: add component RDMA4

2020-12-28 Thread Yongqiang Niu
This patch add component RDMA4 Signed-off-by: Yongqiang Niu --- include/linux/soc/mediatek/mtk-mmsys.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/soc/mediatek/mtk-mmsys.h b/include/linux/soc/mediatek/mtk-mmsys.h index 09ee424..aa4f60e 100644 --- a/include/linux/soc

[PATCH v3, 2/8] soc: mediatek: mmsys: Use function call for setting the routing registers

2020-12-28 Thread Yongqiang Niu
Actually, setting the registers for routing, use multiple 'if-else' for different routes, but this code would be more and more complicated while we support more and more SoCs. Change that and use a function call per SoC so the code will be more portable and clear. Signed-off-by: Yongqiang Niu

[PATCH v3, 7/8] soc: mediatek: mmsys: Use function call for setting mmsys ovl mout register

2020-12-28 Thread Yongqiang Niu
Use function call for setting mmsys ovl mout register Signed-off-by: Yongqiang Niu --- drivers/soc/mediatek/mmsys/mtk-mmsys.c | 20 include/linux/soc/mediatek/mtk-mmsys.h | 3 +++ 2 files changed, 23 insertions(+) diff --git a/drivers/soc/mediatek/mmsys/mtk-mmsys.c b

[PATCH v3, 3/8] soc: mediatek: mmsys: add mt8183 function call for setting the routing registers

2020-12-28 Thread Yongqiang Niu
add mt8183 function call for setting the routing registers Signed-off-by: Yongqiang Niu --- drivers/soc/mediatek/mmsys/Makefile | 1 + drivers/soc/mediatek/mmsys/mt8183-mmsys.c | 90 +++ drivers/soc/mediatek/mmsys/mtk-mmsys.c| 1 + include/linux/soc

[PATCH v3, 1/8] soc: mediatek: mmsys: create mmsys folder

2020-12-28 Thread Yongqiang Niu
the mmsys will more and more complicated after support more and more SoCs, add an independent folder will be more clear Signed-off-by: Yongqiang Niu --- drivers/soc/mediatek/Makefile | 2 +- drivers/soc/mediatek/mmsys/Makefile| 2 + drivers/soc/mediatek/mmsys/mtk-mmsys.c | 380

[PATCH v3, 5/8] soc: mediatek: mmsys: add component POSTMASK

2020-12-28 Thread Yongqiang Niu
This patch add component POSTMASK Signed-off-by: Yongqiang Niu --- include/linux/soc/mediatek/mtk-mmsys.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/soc/mediatek/mtk-mmsys.h b/include/linux/soc/mediatek/mtk-mmsys.h index 42476c2..09ee424 100644 --- a/include/linux/soc

[PATCH v3, 4/8] soc: mediatek: mmsys: add component OVL_2L2

2020-12-28 Thread Yongqiang Niu
This patch add component OVL_2L2 Signed-off-by: Yongqiang Niu --- include/linux/soc/mediatek/mtk-mmsys.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/soc/mediatek/mtk-mmsys.h b/include/linux/soc/mediatek/mtk-mmsys.h index 4b6c514..42476c2 100644 --- a/include/linux/soc

soc: mediatek: Prepare MMSYS for DDP routing using function call

2020-12-28 Thread Yongqiang Niu
The following series are intended to prepare the mtk-mmsys driver to allow different DDP (Data Display Path) function call per SoC. base change: https://patchwork.kernel.org/project/linux-mediatek/patch/20201006193320.405529-4-enric.balle...@collabora.com/ Change since v2: - fix review issue in

Re: [PATCH v2, 3/3] mailbox: cmdq: add mt8192 support

2020-12-24 Thread Yongqiang Niu
On Thu, 2020-12-24 at 22:28 +0800, Chun-Kuang Hu wrote: > Hi, Yongqiang: > > Yongqiang Niu 於 2020年12月24日 週四 上午8:55寫道: > > > > add mt8192 support > > > > Signed-off-by: Yongqiang Niu > > --- > > drivers/mailbox/mtk-cmdq-mailbox.c | 1 + > >

  1   2   >