Re: [PATCH] ARM: mm: remove unused variables

On 2019/6/4 2:45, Krzysztof Kozlowski wrote: > On Sun, 12 May 2019 at 13:51, YueHaibing wrote: >> >> Fix gcc warnings: >> >> arch/arm/mm/init.c: In function 'mem_init': >> arch/arm/mm/init.c:456:13: warning: unused variable 'itcm_end' >> [-Wun

[PATCH v3] kernel/module: Fix mem leak in module_add_modinfo_attrs

In module_add_modinfo_attrs if sysfs_create_file fails, we forget to free allocated modinfo_attrs and roll back the sysfs files. Fixes: 03e88ae1b13d ("[PATCH] fix module sysfs files reference counting") Signed-off-by: YueHaibing --- v3: reuse module_remove_modinfo_attrs v2: free

Re: [PATCH v2] kernel/module: Fix mem leak in module_add_modinfo_attrs

On 2019/6/3 20:11, Miroslav Benes wrote: > On Thu, 30 May 2019, YueHaibing wrote: > >> In module_add_modinfo_attrs if sysfs_create_file >> fails, we forget to free allocated modinfo_attrs >> and roll back the sysfs files. >> >> Fixes: 03e88ae1b13d ("

Re: [PATCH v2] kernel/module: Fix mem leak in module_add_modinfo_attrs

On 2019/6/3 18:47, Jessica Yu wrote: > +++ YueHaibing [30/05/19 21:43 +0800]: >> In module_add_modinfo_attrs if sysfs_create_file >> fails, we forget to free allocated modinfo_attrs >> and roll back the sysfs files. >> >> Fixes: 03e88ae1b13d ("[PATCH] fix

[PATCH] scsi: fcoe: Fix possible memleak in fcoe_if_init

If it fails to alloc fcoe_vport_scsi_transport in fcoe_if_init, we should check the err and free allocted fcoe_nport_scsi_transport. Also return ENOMEM instead of ENODEV. Fixes: 8ca86f84dd5f ("[SCSI] fcoe: prepare fcoe for using fcoe transport") Signed-off-by: YueHaibing --- drivers

[PATCH] ASoC: da7219: Fix build error without CONFIG_I2C

a7219 codec driver") Signed-off-by: YueHaibing --- sound/soc/mediatek/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/mediatek/Kconfig b/sound/soc/mediatek/Kconfig index 933ab51..111e44b 100644 --- a/sound/soc/mediatek/Kconfig +++ b/sound/soc/mediatek/Kconfig

[PATCH net-next] qed: Fix build error without CONFIG_DEVLINK

vlink parameters table") Signed-off-by: YueHaibing --- drivers/net/ethernet/qlogic/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/qlogic/Kconfig b/drivers/net/ethernet/qlogic/Kconfig index fdbb3ce..a391cf6 100644 --- a/drivers/net/ethernet/qlogic/Kconfig +++ b/d

[PATCH -next] ALSA: lx6464es - Remove set but not used variables 'orun_mask, urun_mask'

'orun_mask' set but not used [-Wunused-but-set-variable] They are never used, so can be removed. Signed-off-by: YueHaibing --- sound/pci/lx6464es/lx_core.c | 5 - 1 file changed, 5 deletions(-) diff --git a/sound/pci/lx6464es/lx_core.c b/sound/pci/lx6464es/lx_core.c index 9236a1a8c49b

[PATCH -next] pwm: pca9685: Remove set but not used variable 'pwm'

m_put()") Signed-off-by: YueHaibing --- drivers/pwm/pwm-pca9685.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/pwm/pwm-pca9685.c b/drivers/pwm/pwm-pca9685.c index 567f5e2771c4..d16215c276bd 100644 --- a/drivers/pwm/pwm-pca9685.c +++ b/drivers/pwm/pwm-pca9685.c @@ -170,12 +170,10 @@ s

[PATCH -next] scsi: lpfc: Make some symbols static

' was not declared. Should it be static? Reported-by: Hulk Robot Signed-off-by: YueHaibing --- drivers/scsi/lpfc/lpfc_init.c | 2 +- drivers/scsi/lpfc/lpfc_nvmet.c | 4 ++-- drivers/scsi/lpfc/lpfc_sli.c | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/lpfc

[PATCH -next] scsi: lpfc: Remove set but not used variables 'qp'

r use of hardware queues if fewer irq vectors") Signed-off-by: YueHaibing --- drivers/scsi/lpfc/lpfc_init.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c index 24965a06f55d..cd8e47544d07 100644 --- a/drivers/scsi/lpfc/lpfc_init.c +++

[PATCH] PCI: hv: Fix build error without CONFIG_SYSFS

reference to 'pci_destroy_slot' Select SYSFS while PCI_HYPERV is set to fix this. Reported-by: Hulk Robot Fixes: a15f2c08c708 ("PCI: hv: support reporting serial number as slot information") Signed-off-by: YueHaibing --- drivers/pci/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH] ASoC: SOF: Intel: hda: Fix COMPILE_TEST build error

to `pci_ioremap_bar' hda.c:(.text+0x7c4): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `pci_ioremap_bar' Reported-by: Hulk Robot Fixes: e13ef82a9ab8 ("ASoC: SOF: add COMPILE_TEST for PCI options") Signed-off-by: YueHaibing --- sound/soc/sof/intel/hda.c |

[PATCH v2 -next] crypto: atmel-i2c - Fix build error while CRC16 set to m

-by: Hulk Robot Fixes: da001fb651b0 ("crypto: atmel-i2c - add support for SHA204A random number generator") Signed-off-by: YueHaibing --- v2：use 'select' instead of 'depends on' --- drivers/crypto/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/crypto/Kconfig b/driv

[PATCH -next] crypto: atmel-i2c - Fix build error while CRC16 set to m

make CRYPTO_DEV_ATMEL_ECC depends on CRC16. Reported-by: Hulk Robot Fixes: da001fb651b0 ("crypto: atmel-i2c - add support for SHA204A random number generator") Signed-off-by: YueHaibing --- drivers/crypto/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [PATCH net-next] netfilter: nf_conntrack_bridge: Fix build error without IPV6

On 2019/5/31 16:02, Pablo Neira Ayuso wrote: > On Fri, May 31, 2019 at 11:06:49AM +0800, Yuehaibing wrote: >> +cc netdev >> >> On 2019/5/31 10:46, YueHaibing wrote: >>> Fix gcc build error while CONFIG_IPV6 is not set >>> >>> In file included fro

Re: [PATCH net-next] netfilter: nf_conntrack_bridge: Fix build error without IPV6

+cc netdev On 2019/5/31 10:46, YueHaibing wrote: > Fix gcc build error while CONFIG_IPV6 is not set > > In file included from net/netfilter/core.c:19:0: > ./include/linux/netfilter_ipv6.h: In function 'nf_ipv6_br_defrag': > ./include/linux/netfilter_ipv6.h:110:9: error: impli

[PATCH net-next] netfilter: nf_conntrack_bridge: Fix build error without IPV6

-declaration] Reported-by: Hulk Robot Fixes: 764dd163ac92 ("netfilter: nf_conntrack_bridge: add support for IPv6") Signed-off-by: YueHaibing --- include/linux/netfilter_ipv6.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux/netfilter_ipv6.h b/include/linux/netfilter_ip

Re: [PATCH -next] phy: ti: am654-serdes: Make serdes_am654_xlate() static

Friendly ping... On 2019/4/18 21:36, Yue Haibing wrote: > From: YueHaibing > > Fix sparse warning: > > drivers/phy/ti/phy-am654-serdes.c:250:12: warning: > symbol 'serdes_am654_xlate' was not declared. Should it be static? > > Reported-by: Hulk Robot >

Re: [PATCH v2] powerpc/pseries: Use correct event modifier in rtas_parse_epow_errlog()

Hi all, Friendly ping: Who can take this? On 2019/4/24 10:17, Yue Haibing wrote: > From: YueHaibing > > rtas_parse_epow_errlog() should pass 'modifier' to > handle_system_shutdown, because event modifier only use > bottom 4 bits. > > Fixes: 55fc0c561742 ("powerpc

[PATCH v2] kernel/module: Fix mem leak in module_add_modinfo_attrs

In module_add_modinfo_attrs if sysfs_create_file fails, we forget to free allocated modinfo_attrs and roll back the sysfs files. Fixes: 03e88ae1b13d ("[PATCH] fix module sysfs files reference counting") Signed-off-by: YueHaibing --- v2: free from '--i' instead of 'i--' --- kerne

Re: [PATCH] kernel/module: Fix mem leak in module_add_modinfo_attrs

On 2019/5/30 19:45, Jessica Yu wrote: > +++ YueHaibing [16/05/19 00:12 +0800]: >> In module_add_modinfo_attrs if sysfs_create_file >> fails, we forget to free allocated modinfo_attrs >> and roll back the sysfs files. >> >> Fixes: 03e88ae1b13d ("[PATCH] fix

Re: [PATCH] kernel/module: Fix mem leak in module_add_modinfo_attrs

Friendly ping... On 2019/5/16 0:12, YueHaibing wrote: > In module_add_modinfo_attrs if sysfs_create_file > fails, we forget to free allocated modinfo_attrs > and roll back the sysfs files. > > Fixes: 03e88ae1b13d ("[PATCH] fix module sysfs files reference counting") &g

[PATCH v2 -next] platform/chrome: cros_ec: Make some symbols static

: symbol 'cros_ec_vbc_attr_group' was not declared. Should it be static? drivers/platform/chrome/cros_ec_lpc.c:408:25: warning: symbol 'cros_ec_lpc_pm_ops' was not declared. Should it be static? Reported-by: Hulk Robot Signed-off-by: YueHaibing --- v2: fix patch title --- drivers/platform

Re: [PATCH -next] platform/chrome: cros_ec_lpc: Make some symbols static

On 2019/5/29 23:12, Guenter Roeck wrote: > On Wed, May 29, 2019 at 8:08 AM YueHaibing wrote: >> >> Fix sparse warning: >> >> drivers/platform/chrome/cros_ec_debugfs.c:256:30: warning: symbol >> 'cros_ec_console_log_fops' was not declared. Should it be s

[PATCH -next] usb: phy: mv-usb: Remove set but not used variable 'phy'

B PHY to the OTG structure") Signed-off-by: YueHaibing --- drivers/usb/phy/phy-mv-usb.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/usb/phy/phy-mv-usb.c b/drivers/usb/phy/phy-mv-usb.c index cfd9add10bf4..cf7ecdc9a9d4 100644 --- a/drivers/usb/phy/phy-mv-usb.c +++ b/drivers/usb/phy/ph

[PATCH -next] platform/chrome: cros_ec_lpc: Make some symbols static

: symbol 'cros_ec_vbc_attr_group' was not declared. Should it be static? drivers/platform/chrome/cros_ec_lpc.c:408:25: warning: symbol 'cros_ec_lpc_pm_ops' was not declared. Should it be static? Reported-by: Hulk Robot Signed-off-by: YueHaibing --- drivers/platform/chrome/cros_ec_debugfs.c | 4

[PATCH -next] ASoC: mediatek: Make some symbols static

/mtk-btcvsd.c:779:9: warning: symbol 'mtk_btcvsd_snd_write' was not declared. Should it be static? Reported-by: Hulk Robot Signed-off-by: YueHaibing --- sound/soc/mediatek/common/mtk-btcvsd.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/sound/soc

[PATCH -next] eeprom: at24: Remove set but not used variable 'addr'

: use devm_i2c_new_dummy_device()") Signed-off-by: YueHaibing --- drivers/misc/eeprom/at24.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c index ba8e73812644..fa730bb342e8 100644 --- a/drivers/misc/eeprom/at24.c +++ b/drivers/misc/eeprom/at24.c

[PATCH] rtw88: Remove set but not used variable 'ip_sel' and 'orig'

phy_tx_power_limit_config: drivers/net/wireless/realtek/rtw88/phy.c:1607:11: warning: variable orig set but not used [-Wunused-but-set-variable] They are never used, so can be removed. Signed-off-by: YueHaibing --- drivers/net/wireless/realtek/rtw88/pci.c | 3 --- drivers/net/wireless/realtek/rtw88

[PATCH] mt76: Remove set but not used variables 'pid' and 'final_mpdu'

/wireless/mediatek/mt76/mt7615/mac.c:552:19: warning: variable final_mpdu set but not used [-Wunused-but-set-variable] They are never used, so can be removed. Signed-off-by: YueHaibing --- drivers/net/wireless/mediatek/mt76/mt7603/mac.c | 4 drivers/net/wireless/mediatek/mt76/mt7615/mac.c | 5

[PATCH -next] x86: apuv2: Make two symbols static

-off-by: YueHaibing --- drivers/platform/x86/pcengines-apuv2.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/platform/x86/pcengines-apuv2.c b/drivers/platform/x86/pcengines-apuv2.c index c1ca931e1fab..b0d3110ae378 100644 --- a/drivers/platform/x86/pcengines-apuv2.c

[PATCH net-next] net: dsa: sja1105: Make static_config_check_memory_size static

Fix sparse warning: drivers/net/dsa/sja1105/sja1105_static_config.c:446:1: warning: symbol 'static_config_check_memory_size' was not declared. Should it be static? Reported-by: Hulk Robot Signed-off-by: YueHaibing --- drivers/net/dsa/sja1105/sja1105_static_config.c | 2 +- 1 file changed, 1

[PATCH v3] clk: ti: Remove unused functions

They are not used any more since commit 7558562a70fb ("clk: ti: Drop legacy clk-3xxx-legacy code") Reported-by: Hulk Robot Suggested-by: Tero Kristo Signed-off-by: YueHaibing --- v3: remove ti_clk_build_component_div and _get_div_table_from_setup v2: also remove mux/div unused

[PATCH v2 net-next] net: mvpp2: cls: Remove unnessesary check in mvpp2_ethtool_cls_rule_ins

Fix smatch warning: drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c:1236 mvpp2_ethtool_cls_rule_ins() warn: unsigned 'info->fs.location' is never less than zero. 'info->fs.location' is u32 type, never less than zero. Signed-off-by: YueHaibing --- v2: rework patch based net-next --- d

Re: [PATCH v2 -next] staging: fieldbus: Fix build error without CONFIG_REGMAP_MMIO

On 2019/5/28 22:35, Sven Van Asbroeck wrote: > On Tue, May 28, 2019 at 10:31 AM YueHaibing wrote: >> >> Fix gcc build error while CONFIG_REGMAP_MMIO is not set >> > > checkpatch.pl errors remain: > > $ ./scripts/checkpatch.pl < ~/Downloads/YueHaibing.eml &

Re: [PATCH v2 -next] staging: fieldbus: Fix build error without CONFIG_REGMAP_MMIO

Sorry, this is broken, Pls igore this. On 2019/5/28 22:29, YueHaibing wrote: > Fix gcc build error while CONFIG_REGMAP_MMIO is not set > > drivers/staging/fieldbus/anybuss/arcx-anybus.o: In function > `controller_probe': > arcx-anybus.c: undefined reference to `__devm_regma

[PATCH v2 -next] staging: fieldbus: Fix build error without CONFIG_REGMAP_MMIO

aging: fieldbus: arcx-anybus: change custom -> mmio regmap") Signed-off-by: YueHaibing --- v2: fix patch style warning --- drivers/staging/fieldbus/anybuss/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/fieldbus/anybuss/Kconfig b/drivers/staging/fieldbus/anybuss/

Re: [PATCH -next] staging: fieldbus: Fix build error without CONFIG_REGMAP_MMIO

On 2019/5/28 21:41, Sven Van Asbroeck wrote: > Hello YueHaibing, > > On Tue, May 28, 2019 at 9:33 AM YueHaibing wrote: >> >> Fix gcc build error while CONFIG_REGMAP_MMIO is not set >> >> drivers/staging/fieldbus/anybuss/arcx-anybus.o: In function >> `con

[PATCH -next] usb: host: ehci-st: Remove set but not used variable 'ehci'

Fixes gcc '-Wunused-but-set-variable' warning: drivers/usb/host/ehci-st.c: In function st_ehci_platform_probe: drivers/usb/host/ehci-st.c:155:19: warning: variable ehci set but not used [-Wunused-but-set-variable] It is never used, so can be removed. Signed-off-by: YueHaibing --- drivers/usb

[PATCH -next] usb: ohci-s3c2410: Remove set but not used variable 'hcd'

Fixes gcc '-Wunused-but-set-variable' warning: drivers/usb/host/ohci-s3c2410.c: In function s3c2410_hcd_oc: drivers/usb/host/ohci-s3c2410.c:296:18: warning: variable hcd set but not used [-Wunused-but-set-variable] It is never used, so can be removed. Signed-off-by: YueHaibing --- drivers

[PATCH -next] usb: host: ohci-st: Remove set but not used variable 'ohci'

Fixes gcc '-Wunused-but-set-variable' warning: drivers/usb/host/ohci-st.c: In function st_ohci_platform_probe: drivers/usb/host/ohci-st.c:135:19: warning: variable ohci set but not used [-Wunused-but-set-variable] It's never used, so can be removed. Signed-off-by: YueHaibing --- drivers/usb

[PATCH -next] staging: fieldbus: Fix build error without CONFIG_REGMAP_MMIO

("staging: fieldbus: arcx-anybus: change custom -> mmio regmap") Signed-off-by: YueHaibing --- drivers/staging/fieldbus/anybuss/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/fieldbus/anybuss/Kconfig b/drivers/staging/fieldbus/anybuss/Kconfig index 8bc

[PATCH -next 2/2] Platform: OLPC: Add INPUT dependencies

to `input_set_capability' olpc-xo175-ec.c:(.text+0x91c): undefined reference to `input_register_device' This patch add INPUT dependencies to fix this. Reported-by: Hulk Robot Fixes: 0c3d931b3ab9 ("Platform: OLPC: Add XO-1.75 EC driver") Signed-off-by: YueHaibing --- drivers/platform/ol

[PATCH -next 1/2] Platform: OLPC: Fix build error without CONFIG_SPI

:(.init.text+0x14): undefined reference to `__spi_register_driver' We should depends on CONFIG_SPI_SLAVE other than directly select it. Reported-by: Hulk Robot Fixes: 0c3d931b3ab9 ("Platform: OLPC: Add XO-1.75 EC driver") Signed-off-by: YueHaibing --- drivers/platform/olpc/Kconfig | 2 +- 1 fi

[PATCH -next 0/2] Platform: OLPC: Fix two randbuild error

Fix two randbuild error: 1) Fix build error with CONFIG_SPI is not set 2) Fix build error with CONFIG_INPUT is set to m YueHaibing (2): Platform: OLPC: Fix build error without CONFIG_SPI Platform: OLPC: Add INPUT dependencies drivers/platform/olpc/Kconfig | 3 ++- 1 file changed, 2

[PATCH -next] pinctrl: bcm2835: Fix build error without CONFIG_OF

/pinctrl-bcm2835.c:1022:15: error: struct gpio_chip has no member named of_node pc->gpio_chip.of_node = np; Reported-by: Hulk Robot Fixes: 0de704955ee4 ("pinctrl: bcm2835: Add support for generic pinctrl binding") Signed-off-by: YueHaibing --- drivers/pinctrl/bcm/Kconfig | 2 +- 1

[PATCH net-next] net: stmmac: Fix build error without CONFIG_INET

CONFIG_INET dependency to fix this. Reported-by: Hulk Robot Fixes: 091810dbded9 ("net: stmmac: Introduce selftests support") Signed-off-by: YueHaibing --- drivers/net/ethernet/stmicro/stmmac/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/stmicro/stmmac/

[PATCH -next] lockd: Make two symbols static

Fix sparse warnings: fs/lockd/clntproc.c:57:6: warning: symbol 'nlmclnt_put_lockowner' was not declared. Should it be static? fs/lockd/svclock.c:409:35: warning: symbol 'nlmsvc_lock_ops' was not declared. Should it be static? Reported-by: Hulk Robot Signed-off-by: YueHaibing --- fs/lockd

[PATCH -next] serial: stm32: Make stm32_get_databits static

Fix sparse warning: drivers/tty/serial/stm32-usart.c:603:14: warning: symbol 'stm32_get_databits' was not declared. Should it be static? Reported-by: Hulk Robot Signed-off-by: YueHaibing --- drivers/tty/serial/stm32-usart.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH -next] memory: emif: Remove set but not used variables 'custom_configs' and 'cs1_used'

: warning: variable cs1_used set but not used [-Wunused-but-set-variable] They are not used since introduction in commit a93de288aad3 ("memory: emif: handle frequency and voltage change events") Signed-off-by: YueHaibing --- drivers/memory/emif.c | 5 + 1 file changed, 1 inser

[PATCH -next] intel_th: msu: Remove set but not used variable 'last'

: msu: Add current window tracking") Signed-off-by: YueHaibing --- drivers/hwtracing/intel_th/msu.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/hwtracing/intel_th/msu.c b/drivers/hwtracing/intel_th/msu.c index 81bb54fa3ce8..33072ca5fc4d 100644 --- a/drivers

[PATCH -next] fpga: dfl: afu: Remove set but not used variable 'afu'

d afu sub feature support") Signed-off-by: YueHaibing --- drivers/fpga/dfl-afu-main.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/fpga/dfl-afu-main.c b/drivers/fpga/dfl-afu-main.c index 02baa6a227c0..5e166b81d14a 100644 --- a/drivers/fpga/dfl-afu-main.c +++ b/drivers/fpga/dfl-

[PATCH -next] fpga: dfl: fme: Remove set but not used variable 'fme'

rtial reconfiguration sub feature support") Signed-off-by: YueHaibing --- drivers/fpga/dfl-fme-main.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/fpga/dfl-fme-main.c b/drivers/fpga/dfl-fme-main.c index 086ad2420ade..cb7c4e258298 100644 --- a/drivers/fpga/dfl-fme-main.c +++

[PATCH] scsi: scsi_dh_alua: Fix possible null-ptr-deref

lua: Use workqueue for RTPG") Signed-off-by: YueHaibing --- drivers/scsi/device_handler/scsi_dh_alua.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/device_handler/scsi_dh_alua.c b/drivers/scsi/device_handler/scsi_dh_alua.c index d7ac498ba35a..2a9dcb

[PATCH -next] drivers: thermal: tsens: Change hw_id type to int in is_sensor_enabled

check if a sensor is enabled") Signed-off-by: YueHaibing --- drivers/thermal/qcom/tsens-common.c | 2 +- drivers/thermal/qcom/tsens.h| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/thermal/qcom/tsens-common.c b/drivers/thermal/qcom/tsens-common.c index 92

[PATCH net-next] net: mvpp2: cls: Remove unnessesary check in mvpp2_ethtool_cls_rule_ins

Fix smatch warning: drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c:1236 mvpp2_ethtool_cls_rule_ins() warn: unsigned 'info->fs.location' is never less than zero. 'info->fs.location' is u32 type, never less than zero. Signed-off-by: YueHaibing --- drivers/net/ethernet/marvell

[PATCH -next] ecryptfs: remove unnessesary null check in ecryptfs_keyring_auth_tok_for_sig

request_key and ecryptfs_get_encrypted_key never return a NULL pointer, so no need do a null check. Signed-off-by: YueHaibing --- fs/ecryptfs/keystore.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/ecryptfs/keystore.c b/fs/ecryptfs/keystore.c index 95662fd46b1d

Re: [PATCH 1/4] ecryptfs: remove unnessesary null check in ecryptfs_keyring_auth_tok_for_sig

Pls ignore this, will fix patch title On 2019/5/27 21:15, YueHaibing wrote: > request_key and ecryptfs_get_encrypted_key never > return a NULL pointer, so no need do a null check. > > Signed-off-by: YueHaibing > --- > fs/ecryptfs/keystore.c | 4 ++-- > 1 file change

[PATCH 1/4] ecryptfs: remove unnessesary null check in ecryptfs_keyring_auth_tok_for_sig

request_key and ecryptfs_get_encrypted_key never return a NULL pointer, so no need do a null check. Signed-off-by: YueHaibing --- fs/ecryptfs/keystore.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/ecryptfs/keystore.c b/fs/ecryptfs/keystore.c index 95662fd46b1d

[PATCH] rtlwifi: btcoex: remove unused function exhalbtc_stack_operation_notify

There is no callers in tree, so can be removed. Signed-off-by: YueHaibing --- .../realtek/rtlwifi/btcoexist/halbtcoutsrc.c | 24 --- .../realtek/rtlwifi/btcoexist/halbtcoutsrc.h | 1 - 2 files changed, 25 deletions(-) diff --git a/drivers/net/wireless/realtek/rtlwifi

[PATCH] rtlwifi: btcoex: Remove set but not used variable 'len' and 'asso_type_v2'

_INFO to c2h handler.") so can be removed. 'asso_type_v2' is not used since introduction in commit 0843e98a3b9a ("rtlwifi: btcoex: add assoc type v2 to connection notify") Signed-off-by: YueHaibing --- .../wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c | 11 +++ .../

[PATCH] rtlwifi: rtl8821ae: Remove set but not used variables 'cur_txokcnt' and 'b_last_is_cur_rdl_state'

/wireless/realtek/rtlwifi/rtl8821ae/dm.c: In function rtl8821ae_dm_check_edca_turbo: drivers/net/wireless/realtek/rtlwifi/rtl8821ae/dm.c:2657:7: warning: variable b_last_is_cur_rdl_state set but not used [-Wunused-but-set-variable] They are never used so can be removed. Signed-off-by: YueHaibing

[PATCH -next] EDAC: aspeed: Remove set but not used variable 'np'

Fixes gcc '-Wunused-but-set-variable' warning: drivers/edac/aspeed_edac.c: In function aspeed_probe: drivers/edac/aspeed_edac.c:284:22: warning: variable np set but not used [-Wunused-but-set-variable] It is never used and can be removed. Signed-off-by: YueHaibing --- drivers/edac

[PATCH -next] USB: ohci-spear: Remove set but not used variable 'ohci'

spear a separate driver") Signed-off-by: YueHaibing --- drivers/usb/host/ohci-spear.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/usb/host/ohci-spear.c b/drivers/usb/host/ohci-spear.c index 69fa04697793..5cc05449281c 100644 --- a/drivers/usb/host/ohci-spear.c +++ b/drivers/usb

[PATCH -next] staging: rtl8723bs: hal: Remove set but not used variable 'no_res' and 'phal'

: In function rtl8723bs_free_xmit_priv: drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c:640:23: warning: variable phal set but not used [-Wunused-but-set-variable] They are never used and can be removed. Signed-off-by: YueHaibing --- drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c | 5 + 1

[PATCH -next] Input: tca8418 - Remove set but not used variable ''

Input: tca8418-keypad - switch to using managed resources") Signed-off-by: YueHaibing --- drivers/input/keyboard/tca8418_keypad.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/input/keyboard/tca8418_keypad.c b/drivers/input/keyboard/tca8418_keypad.c index 6d

[PATCH -next] clk: mmp: frac: Remove set but not used variable 'prev_rate'

Fixes gcc '-Wunused-but-set-variable' warning: drivers/clk/mmp/clk-frac.c: In function clk_factor_set_rate: drivers/clk/mmp/clk-frac.c:81:16: warning: variable prev_rate set but not used [-Wunused-but-set-variable] It's never used and can be removed. Signed-off-by: YueHaibing --- drivers/clk

[PATCH -next] xen/pvcalls: Remove set but not used variable

/pvcalls-front.c:638:25: warning: variable bedata set but not used [-Wunused-but-set-variable] They are never used since introduction. Signed-off-by: YueHaibing --- drivers/xen/pvcalls-front.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/xen/pvcalls-front.c b/drivers/xen/pvcalls

[PATCH -next] leds: max77650: Remove set but not used variable 'parent'

Fixes gcc '-Wunused-but-set-variable' warning: drivers/leds/leds-max77650.c: In function max77650_led_probe: drivers/leds/leds-max77650.c:67:17: warning: variable parent set but not used [-Wunused-but-set-variable] It is never used and can be removed. Signed-off-by: YueHaibing --- drivers

[PATCH -next] Input: synaptics-rmi4 - Remove set but not used variable 'sensor_flags'

Input: synaptics-rmi4 - add support for F12") Signed-off-by: YueHaibing --- drivers/input/rmi4/rmi_f12.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/input/rmi4/rmi_f12.c b/drivers/input/rmi4/rmi_f12.c index 5c7f48915779..72b5498e1a9f 100644 --- a/drivers/

[PATCH -next] HID: logitech-dj: fix return value of logi_dj_recv_query_hidpp_devices

We should return 'retval' as the correct return value instead of always zero. Fixes: 74808f9115ce ("HID: logitech-dj: add support for non unifying receivers") Signed-off-by: YueHaibing --- drivers/hid/hid-logitech-dj.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH -next] ufs: remove set but not used variable 'usb3'

Fixes gcc '-Wunused-but-set-variable' warning: fs/ufs/super.c: In function ufs_statfs: fs/ufs/super.c:1409:32: warning: variable usb3 set but not used [-Wunused-but-set-variable] It is not used since commmit c596961d1b4c ("ufs: fix s_size/s_dsize users") Signed-off-by: YueHaibing -

[PATCH -next] agp: remove some set but not used variables

. Signed-off-by: YueHaibing --- drivers/char/agp/frontend.c | 3 +-- drivers/char/agp/isoch.c| 9 + 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/drivers/char/agp/frontend.c b/drivers/char/agp/frontend.c index f6955888e676..47098648502d 100644 --- a/drivers/char/agp

[PATCH -next] sample/mdev/mbochs: remove set but not used variable 'mdev_state'

bochs sample driver") Signed-off-by: YueHaibing --- samples/vfio-mdev/mbochs.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/samples/vfio-mdev/mbochs.c b/samples/vfio-mdev/mbochs.c index b038aa9f5a70..ac5c8c17b1ff 100644 --- a/samples/vfio-mdev/mbochs.c +++ b/samples/vfio-mde

[PATCH -next] IB/hfi1: remove set but not used variables 'offset' and 'fspsn'

troduciotn in commit 9e93e967f7b4 ("IB/hfi1: Add a function to receive TID RDMA ACK packet") Signed-off-by: YueHaibing --- drivers/infiniband/hw/hfi1/tid_rdma.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/infiniband/hw/hfi1/tid_rdma.c b/driver

[PATCH -next] binfmt_flat: remove set but not used variable 'inode'

Fixes gcc '-Wunused-but-set-variable' warning: fs/binfmt_flat.c: In function load_flat_file: fs/binfmt_flat.c:419:16: warning: variable inode set but not used [-Wunused-but-set-variable] It's never used and can be removed. Signed-off-by: YueHaibing --- fs/binfmt_flat.c | 2 -- 1 file changed

[PATCH net-next] cxgb4: Make t4_get_tp_e2c_map static

Fix sparse warning: drivers/net/ethernet/chelsio/cxgb4/t4_hw.c:6216:14: warning: symbol 't4_get_tp_e2c_map' was not declared. Should it be static? Reported-by: Hulk Robot Signed-off-by: YueHaibing --- drivers/net/ethernet/chelsio/cxgb4/t4_hw.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH -next] scsi: megaraid_sas: remove set but not used variables 'host' and 'wait_time'

nce commit 11c71cb4ab7c ("megaraid_sas: Do not allow PCI access during OCR") Signed-off-by: YueHaibing --- drivers/scsi/megaraid/megaraid_sas_base.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid

[PATCH -next] scsi: megaraid_sas: remove set but not used variables 'buff_addr' and 'ci_h'

s not used since commit 9b3d028f3468 ("scsi: megaraid_sas: Pre-allocate frequently used DMA buffers") Signed-off-by: YueHaibing --- drivers/scsi/megaraid/megaraid_sas_base.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/d

[PATCH -next] scsi: megaraid_sas: remove set but not used variable 'cur_state'

7218df69e360 ("[SCSI] megaraid_sas: use the firmware boot timeout when waiting for commands") Signed-off-by: YueHaibing --- drivers/scsi/megaraid/megaraid_sas_base.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scs

[PATCH -next] scsi: megaraid_sas: remove set but not used variable 'sge_sz'

200aed582d61 ("megaraid_sas: endianness related bug fixes and code optimization") Signed-off-by: YueHaibing --- drivers/scsi/megaraid/megaraid_sas_base.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_

[PATCH -next] ASoC: cx2072x: remove set but not used variable 'is_right_j '

Fixes gcc '-Wunused-but-set-variable' warning: sound/soc/codecs/cx2072x.c: In function cx2072x_config_i2spcm: sound/soc/codecs/cx2072x.c:679:6: warning: variable is_right_j set but not used [-Wunused-but-set-variable] It's never used and can be removed. Signed-off-by: YueHaibing --- sound

[PATCH -next] MIPS: uprobes: remove set but not used variable 'epc'

robes support.") Signed-off-by: YueHaibing --- arch/mips/kernel/uprobes.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/arch/mips/kernel/uprobes.c b/arch/mips/kernel/uprobes.c index 4aaff3b3175c..6dbe4eab0a0e 100644 --- a/arch/mips/kernel/uprobes.c +++ b/arch/mips/kernel/uprobes.c @@ -11

Re: [PATCH] Input: walkera0701 - Fix possible NULL pointer dereference in walkera0701_detach

ping... On 2019/4/23 22:56, Yue Haibing wrote: > From: YueHaibing > > KASAN report this: > > walkera0701: failed to allocate input device > kasan: CONFIG_KASAN_INLINE enabled > kasan: GPF could be caused by NULL-ptr deref or user memory access > general protection fa

Re: [PATCH] spi: bitbang: Fix NULL pointer dereference in spi_unregister_master

On 2019/5/16 17:51, Mark Brown wrote: > On Thu, May 16, 2019 at 03:56:56PM +0800, YueHaibing wrote: > >> Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.10.2-1ubuntu1 >> 04/01/2014 >> Call Trace: >> dump_stack+0xa9/0x10e >>

[PATCH] spi: bitbang: Fix NULL pointer dereference in spi_unregister_master

tbang: Let spi_bitbang_start() take a reference to master") Signed-off-by: YueHaibing --- drivers/spi/spi-bitbang.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi-bitbang.c b/drivers/spi/spi-bitbang.c index dd9a8c54..be95be4 100644 --- a/drivers/spi/spi-bitba

[PATCH] serial-uartlite: Fix null-ptr-deref in ulite_exit

: 415b43bdb008 ("tty: serial: uartlite: Move uart register to probe") Signed-off-by: YueHaibing --- drivers/tty/serial/uartlite.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/uartlite.c b/drivers/tty/serial/uartlite.c index b8b912b..2e49fb6 100644 ---

[PATCH] kernel/module: Fix mem leak in module_add_modinfo_attrs

In module_add_modinfo_attrs if sysfs_create_file fails, we forget to free allocated modinfo_attrs and roll back the sysfs files. Fixes: 03e88ae1b13d ("[PATCH] fix module sysfs files reference counting") Signed-off-by: YueHaibing --- kernel/module.c | 16 +++- 1 file c

[PATCH] parport: Fix mem leak in parport_register_dev_model

987f06fc>] 0xc15d803e After commit 4e5a74f1db8d ("parport: Revert "parport: fix memory leak""), free_pardevice do not free par_dev->state, we should free it in error path of parport_register_dev_model before return. Reported-by: Hulk Robot Fixes: 4e5a74f1db8d

[PATCH] ppp: deflate: Fix possible crash in deflate_init

initialization failed out, however ppp_deflate_draft may has been regiestred and not unregistered before return. Then the seconed modprobe will trigger crash like this. Reported-by: Hulk Robot Signed-off-by: YueHaibing --- drivers/net/ppp/ppp_deflate.c | 14 +- 1 file changed, 9

[PATCH] thermal: tsens: Make some symbols static

? drivers/thermal/qcom/tsens-v2.c:38:24: warning: symbol 'tsens_v2_regfields' was not declared. Should it be static? Reported-by: Hulk Robot Signed-off-by: YueHaibing --- drivers/thermal/qcom/tsens-v0_1.c | 4 ++-- drivers/thermal/qcom/tsens-v1.c | 4 ++-- drivers/thermal/qcom/tsens-v2.c | 4

[PATCH] thermal: tegra: Make tegra210_tsensor_thermtrips static

Fix sparse warning: drivers/thermal/tegra/tegra210-soctherm.c:211:33: warning: symbol 'tegra210_tsensor_thermtrips' was not declared. Should it be static? Reported-by: Hulk Robot Signed-off-by: YueHaibing --- drivers/thermal/tegra/tegra210-soctherm.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH v2] clk: ti: Remove unused functions

They are not used any more since commit 7558562a70fb ("clk: ti: Drop legacy clk-3xxx-legacy code") Reported-by: Hulk Robot Suggested-by: Tero Kristo Signed-off-by: YueHaibing --- v2: also remove mux/div unused functions --- drivers/clk/ti/divi

Re: [PATCH] clk: ti: Remove unused function ti_clk_build_component_gate

On 2019/5/13 15:22, Tero Kristo wrote: > On 12/05/2019 13:03, YueHaibing wrote: >> There is no callers in tree, so can be removed. > > Looks ok to me, basically legacy code that we forgot to remove while doing: > > commit 7558562a70fbd6b3fa746fa33c76c9333aa0bb32 > Autho

[PATCH] ARM: mm: remove unused variables

; ^ They are not used any more since commit 1c31d4e96b8c ("ARM: 8820/1: mm: Stop printing the virtual memory layout") Signed-off-by: YueHaibing --- arch/arm/mm/init.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/arch/arm/mm/init.c b/arch/arm/mm/init.c index be0b42

[PATCH] clk: ti: Remove unused function ti_clk_build_component_gate

There is no callers in tree, so can be removed. Reported-by: Hulk Robot Signed-off-by: YueHaibing --- drivers/clk/ti/gate.c | 30 -- 1 file changed, 30 deletions(-) diff --git a/drivers/clk/ti/gate.c b/drivers/clk/ti/gate.c index 504c0e9..4238955 100644

[PATCH -next] staging: kpc2000: remove unused function kp2000_cdev_write

There is no callers in tree, so can be removed. Reported-by: Hulk Robot Signed-off-by: YueHaibing --- drivers/staging/kpc2000/kpc2000/fileops.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/staging/kpc2000/kpc2000/fileops.c b/drivers/staging/kpc2000/kpc2000/fileops.c

[PATCH] clocksource/drivers/ixp4xx: Fix build warning

Fix gcc build warning: drivers/clocksource/timer-ixp4xx.c:78:20: warning: 'ixp4xx_read_sched_clock' defined but not used [-Wunused-function] Reported-by: Hulk Robot Signed-off-by: YueHaibing --- drivers/clocksource/timer-ixp4xx.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers

[PATCH] staging: kpc2000: Fix build error without CONFIG_UIO

y: Hulk Robot Fixes: 7dc7967fc39a ("staging: kpc2000: add initial set of Daktronics drivers") Signed-off-by: YueHaibing --- drivers/staging/kpc2000/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/kpc2000/Kconfig b/drivers/staging/kpc2000/Kconfig index fb59229

<    5   6   7   8   9   10   11   12   13   14   >