On Wed, Apr 16, 2014 at 5:22 PM, Michal Hocko wrote:
> cannot say I like the new code much more than the previous one and
> I've never seen the old one being a bottleneck. So I am not entirely
> fond of optimization without a good reason. (Hint, if you are optimizing
> something always show us
On Wed, Apr 16, 2014 at 5:22 PM, Michal Hocko mho...@suse.cz wrote:
cannot say I like the new code much more than the previous one and
I've never seen the old one being a bottleneck. So I am not entirely
fond of optimization without a good reason. (Hint, if you are optimizing
something always
On Tue, Apr 15, 2014 at 8:51 PM, Tejun Heo wrote:
> The problem there is that there could be programs / scripts parsing it
> assuming single tab between entries. It surely is ugly but do we
> care?
Oh, you are right. It is an exposed user interface. This will make lots of
administrator unhappy
On Tue, Apr 15, 2014 at 4:27 PM, Masami Hiramatsu
wrote:
>
> Plus, if the p->offset and offs are different, fail too.
Oh, yeah, I have did this check it patch too. BTW, I found that the
offset has different types
in kallsyms_lookup(which is unsigned long) and in struct kprobe(which
is
On Mon, Apr 14, 2014 at 11:00 PM, Masami Hiramatsu
wrote:
> if (p->addr) {
> if (p->symbol) {
> sym = kallsyms_lookup(p->addr, ... ...);
> if (strcmp(sym,p->symbol) != 0 || offs != p->offset) {
> pr_warning("Error! ...");
> goto fail;
> }
> }
> } else if (p->symbol) {
On Tue, Apr 15, 2014 at 8:14 AM, Eric Dumazet wrote:
>
> Zhan, could you try following patch, thanks !
>
> drivers/net/vxlan.c |4 ++--
> include/net/dst.h | 14 +++---
> include/net/inet6_connection_sock.h |2 +-
>
On Tue, Apr 15, 2014 at 8:14 AM, Eric Dumazet eric.duma...@gmail.com wrote:
Zhan, could you try following patch, thanks !
drivers/net/vxlan.c |4 ++--
include/net/dst.h | 14 +++---
include/net/inet6_connection_sock.h |2 +-
On Mon, Apr 14, 2014 at 11:00 PM, Masami Hiramatsu
masami.hiramatsu...@hitachi.com wrote:
if (p-addr) {
if (p-symbol) {
sym = kallsyms_lookup(p-addr, ... offs ...);
if (strcmp(sym,p-symbol) != 0 || offs != p-offset) {
pr_warning(Error! ...);
goto fail;
}
}
}
On Tue, Apr 15, 2014 at 4:27 PM, Masami Hiramatsu
masami.hiramatsu...@hitachi.com wrote:
Plus, if the p-offset and offs are different, fail too.
Oh, yeah, I have did this check it patch too. BTW, I found that the
offset has different types
in kallsyms_lookup(which is unsigned long) and in
On Tue, Apr 15, 2014 at 8:51 PM, Tejun Heo t...@kernel.org wrote:
The problem there is that there could be programs / scripts parsing it
assuming single tab between entries. It surely is ugly but do we
care?
Oh, you are right. It is an exposed user interface. This will make lots of
On Mon, Apr 14, 2014 at 11:19 PM, James Chapman wrote:
> Please send the complete oops message.
Hi, complete oops message is :
[ 100.243737] BUG: unable to handle kernel NULL pointer dereference
at 02c0
[ 100.244985] IP: [] ip_queue_xmit+0x20/0x3e0
[ 100.262266] PGD 0
[
On Mon, Apr 14, 2014 at 11:19 PM, James Chapman jchap...@katalix.com wrote:
Please send the complete oops message.
Hi, complete oops message is :
[ 100.243737] BUG: unable to handle kernel NULL pointer dereference
at 02c0
[ 100.244985] IP: [815d4cb0]
On Thu, Apr 3, 2014 at 2:13 AM, Jan Kara wrote:
> OK, but have you checked the generated code is actually any better? This
> is something I'd expect a compiler might be able to optimize anyway. And the
> original code looks more readable to me.
Hi, Jan,
I've disassemble the code on my x86_64
On Thu, Apr 3, 2014 at 2:13 AM, Jan Kara j...@suse.cz wrote:
OK, but have you checked the generated code is actually any better? This
is something I'd expect a compiler might be able to optimize anyway. And the
original code looks more readable to me.
Hi, Jan,
I've disassemble the code on
On Wed, Apr 2, 2014 at 12:23 AM, Steven Rostedt wrote:
> Liked-by: Steven Rostedt
lovely Liked-by :-)
Liked-by: Jianyu Zhan
Regards,
Jianyu Zhan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo
On Wed, Apr 2, 2014 at 12:23 AM, Steven Rostedt rost...@goodmis.org wrote:
Liked-by: Steven Rostedt rost...@goodmis.org
lovely Liked-by :-)
Liked-by: Jianyu Zhan nasa4...@gmail.com
Regards,
Jianyu Zhan
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a
confusion. So this patch cleans up them.
>
> Acked-by: Christoph Lameter
Thanks, Christoph Lameter.
--
Regards,
Zhan Jianyu
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at ht
this patch cleans up them.
Acked-by: Christoph Lameter c...@linux.com
Thanks, Christoph Lameter.
--
Regards,
Zhan Jianyu
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
vrange flag
should be squashed into the vm_flags ? I am not sure .
--
Regards,
Zhan Jianyu
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Pl
be squashed into the vm_flags ? I am not sure .
--
Regards,
Zhan Jianyu
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http
e time and not even generate a
> branch for this.
>
Hi, Johannes Weiner,
Thanks for your comment ;)
Andrew has pointed this out and this patch is abandoned.
--
Regards,
Zhan Jianyu
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a messag
comment ;)
Andrew has pointed this out and this patch is abandoned.
--
Regards,
Zhan Jianyu
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read
this.
Signed-off-by: Zhan Jianyu
---
Documentation/memory-barriers.txt | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/Documentation/memory-barriers.txt
b/Documentation/memory-barriers.txt
index fa5d8a9..590a5a9 100644
--- a/Documentation/memory-barriers.txt
+++ b
this, and adds
a paragraph to explain why a full barrier should guarantee this.
Signed-off-by: Zhan Jianyu nasa4...@gmail.com
---
Documentation/memory-barriers.txt | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/Documentation/memory-barriers.txt
b/Documentation/memory
a look at commit e3366016?
Cc: linux...@kvack.org
--
Regards,
Zhan Jianyu
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
at commit e3366016?
Cc: linux...@kvack.org
--
Regards,
Zhan Jianyu
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http
26 matches
Mail list logo
