RE: [Bug fix] octeon-i2c driver improvement [2/2]

Hi Jan and David, Any other comment for these three patches? I sent them separately. 1. [Bug fix] octeon-i2c driver updates 2. [Bug fix] octeon-i2c driver improvement [1/2] 3. [Bug fix] octeon-i2c driver improvement [2/2] BR, Sean Zhang -Original Message- From: Zhang, Sean C. (NSB - CN

RE: [Bug fix] octeon-i2c driver improvement [2/2]

Hi Jan and David, Any other comment for these three patches? I sent them separately. 1. [Bug fix] octeon-i2c driver updates 2. [Bug fix] octeon-i2c driver improvement [1/2] 3. [Bug fix] octeon-i2c driver improvement [2/2] BR, Sean Zhang -Original Message- From: Zhang, Sean C. (NSB - CN

[Bug fix] octeon-i2c driver improvement [2/2]

Hi Jan and David, For octeon-i2c driver, there has duplicated interrupt disable in octeon_i2c_isr(), octeon_i2c_hlc_wait() and octeon_i2c_wait(), since octeon_i2c_hlc_wait() and octeon_i2c_wait() has pair of interrupt enable and disable, so the interrupt disable in octeon_i2c_isr() is not

[Bug fix] octeon-i2c driver improvement [2/2]

Hi Jan and David, For octeon-i2c driver, there has duplicated interrupt disable in octeon_i2c_isr(), octeon_i2c_hlc_wait() and octeon_i2c_wait(), since octeon_i2c_hlc_wait() and octeon_i2c_wait() has pair of interrupt enable and disable, so the interrupt disable in octeon_i2c_isr() is not

[Bug fix] octeon-i2c driver improvement [1/2]

Hi Jan and David, For octeon-i2c driver, there only has bus recovery for octeon TWSI low level control mode, no recovery for high level control mode, attached patch is used to extend the recovery step from octeon_i2c_start() to octeon_i2c_xfer() for some case octeon TWSI high level control

[Bug fix] octeon-i2c driver improvement [1/2]

Hi Jan and David, For octeon-i2c driver, there only has bus recovery for octeon TWSI low level control mode, no recovery for high level control mode, attached patch is used to extend the recovery step from octeon_i2c_start() to octeon_i2c_xfer() for some case octeon TWSI high level control

RE: [Bug fix] octeon-i2c driver updates

in advance. BR, Sean Zhang -Original Message- From: David Daney [mailto:dda...@caviumnetworks.com] Sent: Wednesday, December 06, 2017 12:43 AM To: Zhang, Sean C. (NSB - CN/Hangzhou) <sean.c.zh...@nokia-sbell.com>; Jan Glauber <jan.glau...@caviumnetworks.com>; david.da...@cavium.

RE: [Bug fix] octeon-i2c driver updates

in advance. BR, Sean Zhang -Original Message- From: David Daney [mailto:dda...@caviumnetworks.com] Sent: Wednesday, December 06, 2017 12:43 AM To: Zhang, Sean C. (NSB - CN/Hangzhou) ; Jan Glauber ; david.da...@cavium.com Cc: w...@the-dreams.de; linux-...@vger.kernel.org; linux-kernel@vger.k

RE: [Bug fix] octeon-i2c driver updates

nt: Friday, December 01, 2017 6:07 PM To: Zhang, Sean C. (NSB - CN/Hangzhou) <sean.c.zh...@nokia-sbell.com> Cc: david.da...@cavium.com; w...@the-dreams.de; linux-...@vger.kernel.org; linux-kernel@vger.kernel.org Subject: Re: [Bug fix] octeon-i2c driver updates Hi Sean, as you try to solve two di

RE: [Bug fix] octeon-i2c driver updates

nt: Friday, December 01, 2017 6:07 PM To: Zhang, Sean C. (NSB - CN/Hangzhou) Cc: david.da...@cavium.com; w...@the-dreams.de; linux-...@vger.kernel.org; linux-kernel@vger.kernel.org Subject: Re: [Bug fix] octeon-i2c driver updates Hi Sean, as you try to solve two different issues I suggest that you

RE: [Bug fix] octeon-i2c driver updates

Hi Jan, Any other comments for this patch? BR, Sean Zhang -Original Message- From: Zhang, Sean C. (NSB - CN/Hangzhou) Sent: Monday, November 27, 2017 4:38 PM To: 'Jan Glauber' <jan.glau...@caviumnetworks.com> Cc: david.da...@cavium.com; w...@the-dreams.de; linux-...@vger.kern

RE: [Bug fix] octeon-i2c driver updates

Hi Jan, Any other comments for this patch? BR, Sean Zhang -Original Message- From: Zhang, Sean C. (NSB - CN/Hangzhou) Sent: Monday, November 27, 2017 4:38 PM To: 'Jan Glauber' Cc: david.da...@cavium.com; w...@the-dreams.de; linux-...@vger.kernel.org; linux-kernel@vger.kernel.org

RE: [Bug fix] octeon-i2c driver updates

() should not return error from this condition. BR, Sean Zhang -Original Message- From: Jan Glauber [mailto:jan.glau...@caviumnetworks.com] Sent: Friday, November 24, 2017 9:10 PM To: Zhang, Sean C. (NSB - CN/Hangzhou) <sean.c.zh...@nokia-sbell.com> Cc: david.da...@cavium.

RE: [Bug fix] octeon-i2c driver updates

() should not return error from this condition. BR, Sean Zhang -Original Message- From: Jan Glauber [mailto:jan.glau...@caviumnetworks.com] Sent: Friday, November 24, 2017 9:10 PM To: Zhang, Sean C. (NSB - CN/Hangzhou) Cc: david.da...@cavium.com; w...@the-dreams.de; linux

[Bug fix] octeon-i2c driver updates

Dear Maintainer, For octeon TWSI controller, I found below two cases, maybe can be improved. >From 09d9f0ce658d7f6a50d1af352dde619c29bc8bcf Mon Sep 17 00:00:00 2001 From: hgt463 Date: Thu, 23 Nov 2017 18:46:09 +0800 Subject: [PATCH] Driver updates: - In the case of I2C

[Bug fix] octeon-i2c driver updates

Dear Maintainer, For octeon TWSI controller, I found below two cases, maybe can be improved. >From 09d9f0ce658d7f6a50d1af352dde619c29bc8bcf Mon Sep 17 00:00:00 2001 From: hgt463 Date: Thu, 23 Nov 2017 18:46:09 +0800 Subject: [PATCH] Driver updates: - In the case of I2C bus dead lock occurred