Re: How delete node or property in overlayd dts?

2018-08-18 Thread Zhang Bo
在 2018/8/18 1:47, Rob Herring 写道: On Tue, Aug 14, 2018 at 7:26 PM Frank Rowand wrote: On 08/14/18 07:46, 张波 wrote: /delete-node/ /delete-prop/ could be used in dtsi files without device tree overlay. but with device tree overlay, /delete-node/ and /delete-prop/ are not work. How to delete

[PATCH v3] Input: matrix_keypad - fix keypad does not response

2018-02-03 Thread Zhang Bo
his condition the device will start keypad and enable irq once after resume. and then irqs are disabled yet because irqs are disabled twice and only enable once. Take lock around keypad->stopped to ensure irqs operation is in atomic operation. Signed-off-by: Zhang Bo --- Changes in v3: - del

Re: [PATCH v2] Input: matrix_keypad - fix keypad does not response

2018-02-03 Thread Zhang Bo
disabled > > twice and > > only enable once. > > > > Take lock around keypad->stopped and queue delayed work in > > matrix_keypad_start() and matrix_keypad_stop() to ensure irqs > > operation and > > scheduling scan work are in atomic operation. >

Re: [PATCH] Input: matrix_keypad - fix keypad does not response

2018-02-03 Thread Zhang Bo
At 2018-02-03 21:44:50, "Marcus Folkesson" wrote: >> diff --git a/drivers/input/keyboard/matrix_keypad.c >> b/drivers/input/keyboard/matrix_keypad.c >> index 1f316d66e6f7..13fe51824637 100644 >> --- a/drivers/input/keyboard/matrix_keypad.c >> +++ b/drivers/input/keyboard/matrix_keypad.c >> @@ -16

Re:Re: [PATCH] Input: matrix_keypad - fix keypad does not response

2018-02-03 Thread Zhang Bo
At 2018-02-03 21:44:50, "Marcus Folkesson" wrote: >> diff --git a/drivers/input/keyboard/matrix_keypad.c >> b/drivers/input/keyboard/matrix_keypad.c >> index 1f316d66e6f7..13fe51824637 100644 >> --- a/drivers/input/keyboard/matrix_keypad.c >> +++ b/drivers/input/keyboard/matrix_keypad.c >> @@ -16

[PATCH v2] Input: matrix_keypad - fix keypad does not response

2018-02-03 Thread Zhang Bo
on and scheduling scan work are in atomic operation. Signed-off-by: Zhang Bo --- Changes in v2: - Change commit message and full name in the signed-off-by tag. drivers/input/keyboard/matrix_keypad.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers

[PATCH] Input: matrix_keypad - fix keypad does not response

2018-02-03 Thread Zhang Bo
on and scheduling scan work are in atomic operation. Signed-off-by: Zhang Bo --- drivers/input/keyboard/matrix_keypad.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers/input/keyboard/matrix_keypad.c b/drivers/input/keyboard/matrix_keypad.c index 1f316d

[PATCH] Input: matrix_keypad - fix keypad does not response

2018-02-03 Thread Zhang Bo
From: zhangbo If matrix_keypad_stop() is calling and the keypad interrupt is triggered, disable_row_irqs() is called by both matrix_keypad_interrupt() and matrix_keypad_stop() at the same time. then disable_row_irqs() is called twice, and the device enter suspend state before keypad->work is exec