r...@sisk.pl]
> Sent: Saturday, January 05, 2013 6:00 AM
> To: ACPI Devel Maling List
> Cc: LKML; Len Brown; Zheng, Lv; Huang, Ying
> Subject: [PATCH 1/6] ACPI / PM: Change the way power transitions to D3cold
> are carried out
>
> From: Rafael J. Wysocki
>
> Du
To: ACPI Devel Maling List
Cc: LKML; Len Brown; Zheng, Lv; Huang, Ying
Subject: [PATCH 1/6] ACPI / PM: Change the way power transitions to D3cold
are carried out
From: Rafael J. Wysocki rafael.j.wyso...@intel.com
During power transitions into D3cold from any shallower power states we
x PM list; ACPI Devel Maling List; Zhang, Rui;
> Svahn, Kai; Mika Westerberg; Huang, Ying; Lan, Tianyu; Zheng, Lv; Lu, Aaron;
> Grant Likely
> Subject: [PATCH 2/2] platform / ACPI: Attach/detach ACPI PM during
> probe/remove/shutdown
>
> From: Rafael J. Wysocki
>
>
Maling List; Zhang, Rui;
Svahn, Kai; Mika Westerberg; Huang, Ying; Lan, Tianyu; Zheng, Lv; Lu, Aaron;
Grant Likely
Subject: [PATCH 2/2] platform / ACPI: Attach/detach ACPI PM during
probe/remove/shutdown
From: Rafael J. Wysocki rafael.j.wyso...@intel.com
Drivers usually expect
> > +static __initdata DECLARE_BITMAP(acpi_early_flags,
> > +MAX_ACPI_DBG_PORTS*2);
It's OK since the keep bit will be derived by the real earlycon drivers in the
__acpi_early_console_start() which is an arch specific interface.
You can find this usage in the [PATCH v6 2/2].
> > +
+static __initdata DECLARE_BITMAP(acpi_early_flags,
+MAX_ACPI_DBG_PORTS*2);
It's OK since the keep bit will be derived by the real earlycon drivers in the
__acpi_early_console_start() which is an arch specific interface.
You can find this usage in the [PATCH v6 2/2].
+ set_bit(port,
> > +#ifdef CONFIG_EARLY_PRINTK_INTEL_MID_SPI
> > + if (info->port_type == ACPI_DBG2_SERIAL_PORT
> > + && info->port_subtype == ACPI_DBG2_INTEL_MID_SPI
> > + && info->register_count > 0) {
> Is it ever going to be zero?
NAK.
No register base definition (buggy BIOS?) is meaningless
> > +int __init acpi_early_console_keep(struct acpi_debug_port *info)
>
> Why not make it 'bool' like the other (acpi_early_console_enabled)?
NAK.
"keep" is "int" in "setup_early_printk".
Best regards/Lv Zheng
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the
> > earlyprintk=acpi
> .. or earlyprintk=mrst
> ?
ACK.
The two launchers are all workable for MID_SPI. I'll add more comments and
resend this patch. Thanks
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More
> > Signed-off-by: Lv Zheng
> > Reviewed-by: Len Brown
> > Reviewed-by: Rui Zhang
> > Reviewed-by: Ying Huang
> > Reviewed-by: Konrad Rzeszutek Wilk
> Please don't include that unless I (or other folks looking at your code) say
> explicitly 'Acked' or 'Reviewed-by'
ACK.
I'll remove these
Signed-off-by: Lv Zheng lv.zh...@intel.com
Reviewed-by: Len Brown len.br...@intel.com
Reviewed-by: Rui Zhang rui.zh...@intel.com
Reviewed-by: Ying Huang ying.hu...@intel.com
Reviewed-by: Konrad Rzeszutek Wilk kon...@kernel.org
Please don't include that unless I (or other folks looking
earlyprintk=acpi
.. or earlyprintk=mrst
?
ACK.
The two launchers are all workable for MID_SPI. I'll add more comments and
resend this patch. Thanks
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More
+int __init acpi_early_console_keep(struct acpi_debug_port *info)
Why not make it 'bool' like the other (acpi_early_console_enabled)?
NAK.
keep is int in setup_early_printk.
Best regards/Lv Zheng
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a
+#ifdef CONFIG_EARLY_PRINTK_INTEL_MID_SPI
+ if (info-port_type == ACPI_DBG2_SERIAL_PORT
+info-port_subtype == ACPI_DBG2_INTEL_MID_SPI
+info-register_count 0) {
Is it ever going to be zero?
NAK.
No register base definition (buggy BIOS?) is meaningless for ACPI launched
> go ahead and take the series in tip 3.8, Peter, thanks.
>
> I looked over this series a while back and my feedback was that it should be
> disabled by default and enabled by bootparam -- like other earlyprink -- else
> an
> issue here would render a system un-bootable. I see that LV has
go ahead and take the series in tip 3.8, Peter, thanks.
I looked over this series a while back and my feedback was that it should be
disabled by default and enabled by bootparam -- like other earlyprink -- else
an
issue here would render a system un-bootable. I see that LV has addressed
Forgot to Cc x86 maintainers, will send again. Sorry for the noise.
> -Original Message-
> From: Zheng, Lv
> Sent: Friday, September 28, 2012 10:40 AM
> To: Brown, Len
> Cc: linux-kernel@vger.kernel.org; linux-a...@vger.kernel.org; Zheng, Lv
> Subject: [PATCH v4 0/2] ACP
Forgot to Cc x86 maintainers, will send again. Sorry for the noise.
-Original Message-
From: Zheng, Lv
Sent: Friday, September 28, 2012 10:40 AM
To: Brown, Len
Cc: linux-kernel@vger.kernel.org; linux-a...@vger.kernel.org; Zheng, Lv
Subject: [PATCH v4 0/2] ACPI: DBGP/DBG2 early
901 - 918 of 918 matches
Mail list logo
