[PATCH v6 05/11] VFS hot tracking: Add an ioctl to get hot tracking information

2013-11-06 Thread Zhi Yong Wu
From: Zhi Yong Wu FS_IOC_GET_HEAT_INFO: return a struct containing the various metrics collected in hot_freq_data structs, and also return a calculated data temperature based on those metrics. Optionally, retrieve the temperature from the hot data hash list instead of recalculating it. Signed

[PATCH v6 02/11] VFS hot tracking: Track IO and record heat information

2013-11-06 Thread Zhi Yong Wu
From: Zhi Yong Wu This patch adds read/write code paths: include read_pages(), do_writepages(), do_generic_file_read() and __blockdev_direct_IO() to record heat information. When real disk i/o for an inode is done, its own hot_inode_item will be created or updated in the RB tree

[PATCH v6 04/11] VFS hot tracking: Add shrinker functionality to curtail memory usage

2013-11-06 Thread Zhi Yong Wu
From: Zhi Yong Wu Register a shrinker to control the amount of memory that is used in tracking hot regions. If we are throwing inodes out of memory due to memory pressure, we most definitely are going to need to reduce the amount of memory the tracking code is using, even if it means losing

[PATCH v6 00/11] VFS hot tracking

2013-11-06 Thread Zhi Yong Wu
From: Zhi Yong Wu The patchset is trying to introduce hot tracking function in VFS layer, which will keep track of real disk I/O in memory. By it, you will easily know more details about disk I/O, and then detect where disk I/O hot spots are. Also, specific FS can take use of it to do accurate

[PATCH v6 00/11] VFS hot tracking

2013-11-06 Thread Zhi Yong Wu
From: Zhi Yong Wu wu...@linux.vnet.ibm.com The patchset is trying to introduce hot tracking function in VFS layer, which will keep track of real disk I/O in memory. By it, you will easily know more details about disk I/O, and then detect where disk I/O hot spots are. Also, specific FS can take

[PATCH v6 02/11] VFS hot tracking: Track IO and record heat information

2013-11-06 Thread Zhi Yong Wu
From: Zhi Yong Wu wu...@linux.vnet.ibm.com This patch adds read/write code paths: include read_pages(), do_writepages(), do_generic_file_read() and __blockdev_direct_IO() to record heat information. When real disk i/o for an inode is done, its own hot_inode_item will be created or updated

[PATCH v6 04/11] VFS hot tracking: Add shrinker functionality to curtail memory usage

2013-11-06 Thread Zhi Yong Wu
From: Zhi Yong Wu wu...@linux.vnet.ibm.com Register a shrinker to control the amount of memory that is used in tracking hot regions. If we are throwing inodes out of memory due to memory pressure, we most definitely are going to need to reduce the amount of memory the tracking code is using, even

[PATCH v6 05/11] VFS hot tracking: Add an ioctl to get hot tracking information

2013-11-06 Thread Zhi Yong Wu
From: Zhi Yong Wu wu...@linux.vnet.ibm.com FS_IOC_GET_HEAT_INFO: return a struct containing the various metrics collected in hot_freq_data structs, and also return a calculated data temperature based on those metrics. Optionally, retrieve the temperature from the hot data hash list instead

[PATCH v6 07/11] VFS hot tracking: Add a /proc interface to control memory usage

2013-11-06 Thread Zhi Yong Wu
From: Zhi Yong Wu wu...@linux.vnet.ibm.com Introduce a /proc interface hot-mem-high-thresh and to cap the memory which is consumed by hot_inode_item and hot_range_item, and they will be in the unit of 1M bytes. Signed-off-by: Chandra Seetharaman sekha...@us.ibm.com Signed-off-by: Zhi Yong Wu wu

[PATCH v6 06/11] VFS hot tracking: Add a /proc interface to make the interval tunable

2013-11-06 Thread Zhi Yong Wu
From: Zhi Yong Wu wu...@linux.vnet.ibm.com Add a /proc interface hot-update-interval under the dir /proc/sys/fs/ in order to turn HOT_UPDATE_INTERVAL into a tunable parameter. Signed-off-by: Chandra Seetharaman sekha...@us.ibm.com Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com --- fs

[PATCH v6 08/11] VFS hot tracking: Add documentation

2013-11-06 Thread Zhi Yong Wu
From: Zhi Yong Wu wu...@linux.vnet.ibm.com Add Documentation for VFS hot tracking feature Signed-off-by: Chandra Seetharaman sekha...@us.ibm.com Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com --- Documentation/filesystems/00-INDEX | 2 + Documentation/filesystems/hot_tracking.txt

[PATCH v6 11/11] MAINTAINERS: add the maintainers for VFS hot tracking

2013-11-06 Thread Zhi Yong Wu
From: Zhi Yong Wu wu...@linux.vnet.ibm.com This patch adds maintainer information for VFS hot tracking into the MAINTAINERS file. Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com Signed-off-by: Chandra Seetharaman sekha...@us.ibm.com --- MAINTAINERS | 12 1 file changed, 12

[PATCH v6 10/11] VFS hot tracking, xfs: Add hot tracking support

2013-11-06 Thread Zhi Yong Wu
From: Dave Chinner dchin...@redhat.com Connect up the VFS hot tracking support so XFS filesystem can make use of it. Signed-off-by: Dave Chinner dchin...@redhat.com Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com --- fs/xfs/xfs_mount.h | 1 + fs/xfs/xfs_super.c | 18 ++ 2

[PATCH v6 09/11] VFS hot tracking, btrfs: Add hot tracking support

2013-11-06 Thread Zhi Yong Wu
From: Zhi Yong Wu wu...@linux.vnet.ibm.com Introduce one new mount option '-o hot_track', and add its parsing support. Its usage looks like: mount -o hot_track mount -o nouser,hot_track mount -o nouser,hot_track,loop mount -o hot_track,nouser Reviewed-by: David Sterba dste

[PATCH v6 01/11] VFS hot tracking: Define basic data structures and functions

2013-11-06 Thread Zhi Yong Wu
From: Zhi Yong Wu wu...@linux.vnet.ibm.com This patch includes the basic data structure and functions needed for VFS hot tracking. It adds hot_inode_tree struct to keep track of frequently accessed files, and is keyed by {inode, offset}. Trees contain hot_inode_items representing those files

[PATCH v6 03/11] VFS hot tracking: Add a workqueue to move items between hot maps

2013-11-06 Thread Zhi Yong Wu
From: Zhi Yong Wu wu...@linux.vnet.ibm.com Add a workqueue per superblock and a delayed_work to run periodic work to update map info on each superblock. Two arrays of map list are defined, one is for hot inode items, and the other is for hot extent items. The hot items in the RB-tree

Re: [PATCH 2/2] mm: fix the comment in zlc_setup()

2013-11-04 Thread Zhi Yong Wu
CCed Andrew Morton On Thu, Oct 31, 2013 at 8:52 PM, Zhi Yong Wu wrote: > From: Zhi Yong Wu > > Signed-off-by: Zhi Yong Wu > --- > mm/page_alloc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > in

Re: [PATCH 1/2] mm: fix the incorrect function name in alloc_low_pages()

2013-11-04 Thread Zhi Yong Wu
CCed Andrew Morton On Thu, Oct 31, 2013 at 8:52 PM, Zhi Yong Wu wrote: > From: Zhi Yong Wu > > Signed-off-by: Zhi Yong Wu > --- > arch/x86/mm/init.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/mm/init.c b/arch/x86/mm/init.c

Re: [PATCH 1/2] mm: fix the incorrect function name in alloc_low_pages()

2013-11-04 Thread Zhi Yong Wu
CCed Andrew Morton On Thu, Oct 31, 2013 at 8:52 PM, Zhi Yong Wu zwu.ker...@gmail.com wrote: From: Zhi Yong Wu wu...@linux.vnet.ibm.com Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com --- arch/x86/mm/init.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch

Re: [PATCH 2/2] mm: fix the comment in zlc_setup()

2013-11-04 Thread Zhi Yong Wu
CCed Andrew Morton On Thu, Oct 31, 2013 at 8:52 PM, Zhi Yong Wu zwu.ker...@gmail.com wrote: From: Zhi Yong Wu wu...@linux.vnet.ibm.com Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com --- mm/page_alloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm

[PATCH 1/2] mm: fix the incorrect function name in alloc_low_pages()

2013-10-31 Thread Zhi Yong Wu
From: Zhi Yong Wu Signed-off-by: Zhi Yong Wu --- arch/x86/mm/init.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/mm/init.c b/arch/x86/mm/init.c index 04664cd..64d860f 100644 --- a/arch/x86/mm/init.c +++ b/arch/x86/mm/init.c @@ -53,12 +53,12 @@ __ref void

[PATCH 2/2] mm: fix the comment in zlc_setup()

2013-10-31 Thread Zhi Yong Wu
From: Zhi Yong Wu Signed-off-by: Zhi Yong Wu --- mm/page_alloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index dd886fa..3d94d0c 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -1711,7 +1711,7 @@ bool zone_watermark_ok_safe

[PATCH 1/2] mm: fix the incorrect function name in alloc_low_pages()

2013-10-31 Thread Zhi Yong Wu
From: Zhi Yong Wu wu...@linux.vnet.ibm.com Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com --- arch/x86/mm/init.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/mm/init.c b/arch/x86/mm/init.c index 04664cd..64d860f 100644 --- a/arch/x86/mm/init.c +++ b/arch

[PATCH 2/2] mm: fix the comment in zlc_setup()

2013-10-31 Thread Zhi Yong Wu
From: Zhi Yong Wu wu...@linux.vnet.ibm.com Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com --- mm/page_alloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index dd886fa..3d94d0c 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c

[PATCH] net, mc: fix the incorrect comments in two mc-related functions

2013-10-28 Thread Zhi Yong Wu
From: Zhi Yong Wu Signed-off-by: Zhi Yong Wu --- net/core/dev_addr_lists.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/core/dev_addr_lists.c b/net/core/dev_addr_lists.c index 6cda4e2..ec40a84 100644 --- a/net/core/dev_addr_lists.c +++ b/net/core/dev_addr_lists.c

[PATCH v2 3/3] net, iovec: fix the incorrect comment in memcpy_fromiovecend()

2013-10-28 Thread Zhi Yong Wu
From: Zhi Yong Wu Signed-off-by: Zhi Yong Wu --- net/core/iovec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/iovec.c b/net/core/iovec.c index b77eeec..4cdb7c4 100644 --- a/net/core/iovec.c +++ b/net/core/iovec.c @@ -100,7 +100,7 @@ int memcpy_toiovecend(const

[PATCH v2 1/3] vxlan: silence one build warning

2013-10-28 Thread Zhi Yong Wu
From: Zhi Yong Wu drivers/net/vxlan.c: In function ‘vxlan_sock_add’: drivers/net/vxlan.c:2298:11: warning: ‘sock’ may be used uninitialized in this function [-Wmaybe-uninitialized] drivers/net/vxlan.c:2275:17: note: ‘sock’ was declared here LD drivers/net/built-in.o Signed-off-by: Zhi

[PATCH v2 2/3] net, datagram: fix the incorrect comment in zerocopy_sg_from_iovec()

2013-10-28 Thread Zhi Yong Wu
From: Zhi Yong Wu Signed-off-by: Zhi Yong Wu --- net/core/datagram.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/datagram.c b/net/core/datagram.c index af814e7..a16ed7b 100644 --- a/net/core/datagram.c +++ b/net/core/datagram.c @@ -577,7 +577,7 @@ EXPORT_SYMBOL

[PATCH v2 2/3] net, datagram: fix the incorrect comment in zerocopy_sg_from_iovec()

2013-10-28 Thread Zhi Yong Wu
From: Zhi Yong Wu wu...@linux.vnet.ibm.com Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com --- net/core/datagram.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/datagram.c b/net/core/datagram.c index af814e7..a16ed7b 100644 --- a/net/core/datagram.c +++ b/net

[PATCH v2 1/3] vxlan: silence one build warning

2013-10-28 Thread Zhi Yong Wu
From: Zhi Yong Wu wu...@linux.vnet.ibm.com drivers/net/vxlan.c: In function ‘vxlan_sock_add’: drivers/net/vxlan.c:2298:11: warning: ‘sock’ may be used uninitialized in this function [-Wmaybe-uninitialized] drivers/net/vxlan.c:2275:17: note: ‘sock’ was declared here LD drivers/net/built

[PATCH v2 3/3] net, iovec: fix the incorrect comment in memcpy_fromiovecend()

2013-10-28 Thread Zhi Yong Wu
From: Zhi Yong Wu wu...@linux.vnet.ibm.com Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com --- net/core/iovec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/iovec.c b/net/core/iovec.c index b77eeec..4cdb7c4 100644 --- a/net/core/iovec.c +++ b/net/core/iovec.c

[PATCH] net, mc: fix the incorrect comments in two mc-related functions

2013-10-28 Thread Zhi Yong Wu
From: Zhi Yong Wu wu...@linux.vnet.ibm.com Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com --- net/core/dev_addr_lists.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/core/dev_addr_lists.c b/net/core/dev_addr_lists.c index 6cda4e2..ec40a84 100644 --- a/net/core

Re: [PATCH 1/3] vxlan: silence one build warning

2013-10-26 Thread Zhi Yong Wu
HI, Stephen I saw it on Fedora 17 without latest kernel. Then what do you think that it is appropriate to solve this problem? discard this patch? If yes, i can also agree. On Sat, Oct 26, 2013 at 10:48 PM, Stephen Hemminger wrote: > On Sat, 26 Oct 2013 15:06:04 +0800 > Zhi Yong Wu

Re: [PATCH 1/3] vxlan: silence one build warning

2013-10-26 Thread Zhi Yong Wu
On Fri, Oct 25, 2013 at 11:41 PM, Stephen Hemminger wrote: > On Fri, 25 Oct 2013 15:49:18 +0800 > Zhi Yong Wu wrote: > >> From: Zhi Yong Wu >> >> drivers/net/vxlan.c: In function ‘vxlan_sock_add’: >> drivers/net/vxlan.c:2298:11: warning: ‘sock’ may be used u

Re: [PATCH 1/3] vxlan: silence one build warning

2013-10-26 Thread Zhi Yong Wu
On Fri, Oct 25, 2013 at 11:41 PM, Stephen Hemminger step...@networkplumber.org wrote: On Fri, 25 Oct 2013 15:49:18 +0800 Zhi Yong Wu zwu.ker...@gmail.com wrote: From: Zhi Yong Wu wu...@linux.vnet.ibm.com drivers/net/vxlan.c: In function ‘vxlan_sock_add’: drivers/net/vxlan.c:2298:11: warning

Re: [PATCH 1/3] vxlan: silence one build warning

2013-10-26 Thread Zhi Yong Wu
Zhi Yong Wu zwu.ker...@gmail.com wrote: On Fri, Oct 25, 2013 at 11:41 PM, Stephen Hemminger step...@networkplumber.org wrote: On Fri, 25 Oct 2013 15:49:18 +0800 Zhi Yong Wu zwu.ker...@gmail.com wrote: From: Zhi Yong Wu wu...@linux.vnet.ibm.com drivers/net/vxlan.c: In function

[PATCH 1/3] vxlan: silence one build warning

2013-10-25 Thread Zhi Yong Wu
From: Zhi Yong Wu drivers/net/vxlan.c: In function ‘vxlan_sock_add’: drivers/net/vxlan.c:2298:11: warning: ‘sock’ may be used uninitialized in this function [-Wmaybe-uninitialized] drivers/net/vxlan.c:2275:17: note: ‘sock’ was declared here LD drivers/net/built-in.o Signed-off-by: Zhi

[PATCH 2/3] net, datagram: fix the uncorrect comment in zerocopy_sg_from_iovec()

2013-10-25 Thread Zhi Yong Wu
From: Zhi Yong Wu Signed-off-by: Zhi Yong Wu --- net/core/datagram.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/datagram.c b/net/core/datagram.c index af814e7..a16ed7b 100644 --- a/net/core/datagram.c +++ b/net/core/datagram.c @@ -577,7 +577,7 @@ EXPORT_SYMBOL

[PATCH 3/3] net, iovec: fix the uncorrect comment in memcpy_fromiovecend()

2013-10-25 Thread Zhi Yong Wu
From: Zhi Yong Wu Signed-off-by: Zhi Yong Wu --- net/core/iovec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/iovec.c b/net/core/iovec.c index b77eeec..4cdb7c4 100644 --- a/net/core/iovec.c +++ b/net/core/iovec.c @@ -100,7 +100,7 @@ int memcpy_toiovecend(const

[PATCH 3/3] net, iovec: fix the uncorrect comment in memcpy_fromiovecend()

2013-10-25 Thread Zhi Yong Wu
From: Zhi Yong Wu wu...@linux.vnet.ibm.com Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com --- net/core/iovec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/iovec.c b/net/core/iovec.c index b77eeec..4cdb7c4 100644 --- a/net/core/iovec.c +++ b/net/core/iovec.c

[PATCH 1/3] vxlan: silence one build warning

2013-10-25 Thread Zhi Yong Wu
From: Zhi Yong Wu wu...@linux.vnet.ibm.com drivers/net/vxlan.c: In function ‘vxlan_sock_add’: drivers/net/vxlan.c:2298:11: warning: ‘sock’ may be used uninitialized in this function [-Wmaybe-uninitialized] drivers/net/vxlan.c:2275:17: note: ‘sock’ was declared here LD drivers/net/built

[PATCH 2/3] net, datagram: fix the uncorrect comment in zerocopy_sg_from_iovec()

2013-10-25 Thread Zhi Yong Wu
From: Zhi Yong Wu wu...@linux.vnet.ibm.com Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com --- net/core/datagram.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/datagram.c b/net/core/datagram.c index af814e7..a16ed7b 100644 --- a/net/core/datagram.c +++ b/net

Re: [PATCH v5 00/10] VFS hot tracking

2013-09-24 Thread Zhi Yong Wu
On Tue, Sep 24, 2013 at 8:20 AM, Al Viro wrote: > On Tue, Sep 17, 2013 at 06:17:45AM +0800, zwu.ker...@gmail.com wrote: >> From: Zhi Yong Wu >> >> The patchset is trying to introduce hot tracking function in >> VFS layer, which will keep track of real disk I

Re: [PATCH v5 00/10] VFS hot tracking

2013-09-24 Thread Zhi Yong Wu
On Tue, Sep 24, 2013 at 8:20 AM, Al Viro v...@zeniv.linux.org.uk wrote: On Tue, Sep 17, 2013 at 06:17:45AM +0800, zwu.ker...@gmail.com wrote: From: Zhi Yong Wu wu...@linux.vnet.ibm.com The patchset is trying to introduce hot tracking function in VFS layer, which will keep track of real disk

Re: [PATCH] rbtree: Add some necessary condition checks

2013-09-04 Thread Zhi Yong Wu
On Thu, Sep 5, 2013 at 9:12 AM, Davidlohr Bueso wrote: > On Thu, 2013-09-05 at 08:37 +0800, Zhi Yong Wu wrote: >> On Thu, Sep 5, 2013 at 7:59 AM, Davidlohr Bueso wrote: >> > On Thu, 2013-09-05 at 01:22 +0800, Zhi Yong Wu wrote: >> >> On Mon, Sep 2, 2013

Re: [PATCH] rbtree: Add some necessary condition checks

2013-09-04 Thread Zhi Yong Wu
On Thu, Sep 5, 2013 at 7:59 AM, Davidlohr Bueso wrote: > On Thu, 2013-09-05 at 01:22 +0800, Zhi Yong Wu wrote: >> On Mon, Sep 2, 2013 at 4:57 PM, Michel Lespinasse wrote: >> > On Sun, Sep 1, 2013 at 11:30 PM, Zhi Yong Wu wrote: >> >> In Tue, Aug 27, 2013

Re: [PATCH] rbtree: Add some necessary condition checks

2013-09-04 Thread Zhi Yong Wu
On Mon, Sep 2, 2013 at 4:57 PM, Michel Lespinasse wrote: > On Sun, Sep 1, 2013 at 11:30 PM, Zhi Yong Wu wrote: >> In Tue, Aug 27, 2013 at 6:01 AM, Michel Lespinasse wrote: >>> On Fri, Aug 23, 2013 at 7:45 AM, wrote: >>>> From: Zhi Yong Wu >&g

Re: [PATCH] rbtree: Add some necessary condition checks

2013-09-04 Thread Zhi Yong Wu
On Mon, Sep 2, 2013 at 4:57 PM, Michel Lespinasse wal...@google.com wrote: On Sun, Sep 1, 2013 at 11:30 PM, Zhi Yong Wu zwu.ker...@gmail.com wrote: In Tue, Aug 27, 2013 at 6:01 AM, Michel Lespinasse wal...@google.com wrote: On Fri, Aug 23, 2013 at 7:45 AM, zwu.ker...@gmail.com wrote: From

Re: [PATCH] rbtree: Add some necessary condition checks

2013-09-04 Thread Zhi Yong Wu
On Thu, Sep 5, 2013 at 7:59 AM, Davidlohr Bueso davidl...@hp.com wrote: On Thu, 2013-09-05 at 01:22 +0800, Zhi Yong Wu wrote: On Mon, Sep 2, 2013 at 4:57 PM, Michel Lespinasse wal...@google.com wrote: On Sun, Sep 1, 2013 at 11:30 PM, Zhi Yong Wu zwu.ker...@gmail.com wrote: In Tue, Aug 27

Re: [PATCH] rbtree: Add some necessary condition checks

2013-09-04 Thread Zhi Yong Wu
On Thu, Sep 5, 2013 at 9:12 AM, Davidlohr Bueso davidl...@hp.com wrote: On Thu, 2013-09-05 at 08:37 +0800, Zhi Yong Wu wrote: On Thu, Sep 5, 2013 at 7:59 AM, Davidlohr Bueso davidl...@hp.com wrote: On Thu, 2013-09-05 at 01:22 +0800, Zhi Yong Wu wrote: On Mon, Sep 2, 2013 at 4:57 PM, Michel

Re: [PATCH] rbtree: Add some necessary condition checks

2013-09-03 Thread Zhi Yong Wu
On Tue, Sep 3, 2013 at 1:48 PM, Michel Lespinasse wrote: > On Mon, Sep 2, 2013 at 9:45 PM, Zhi Yong Wu wrote: >> On Mon, Sep 2, 2013 at 4:57 PM, Michel Lespinasse wrote: >>> Thanks for the link - I now better understand where you are coming >>> from with thes

Re: [PATCH] rbtree: Add some necessary condition checks

2013-09-03 Thread Zhi Yong Wu
On Tue, Sep 3, 2013 at 1:48 PM, Michel Lespinasse wrote: > On Mon, Sep 2, 2013 at 9:45 PM, Zhi Yong Wu wrote: >> On Mon, Sep 2, 2013 at 4:57 PM, Michel Lespinasse wrote: >>> Thanks for the link - I now better understand where you are coming >>> from with thes

Re: [PATCH] rbtree: Add some necessary condition checks

2013-09-03 Thread Zhi Yong Wu
On Tue, Sep 3, 2013 at 1:48 PM, Michel Lespinasse wal...@google.com wrote: On Mon, Sep 2, 2013 at 9:45 PM, Zhi Yong Wu zwu.ker...@gmail.com wrote: On Mon, Sep 2, 2013 at 4:57 PM, Michel Lespinasse wal...@google.com wrote: Thanks for the link - I now better understand where you are coming from

Re: [PATCH] rbtree: Add some necessary condition checks

2013-09-03 Thread Zhi Yong Wu
On Tue, Sep 3, 2013 at 1:48 PM, Michel Lespinasse wal...@google.com wrote: On Mon, Sep 2, 2013 at 9:45 PM, Zhi Yong Wu zwu.ker...@gmail.com wrote: On Mon, Sep 2, 2013 at 4:57 PM, Michel Lespinasse wal...@google.com wrote: Thanks for the link - I now better understand where you are coming from

Re: [PATCH] rbtree: Add some necessary condition checks

2013-09-02 Thread Zhi Yong Wu
On Mon, Sep 2, 2013 at 4:57 PM, Michel Lespinasse wrote: > On Sun, Sep 1, 2013 at 11:30 PM, Zhi Yong Wu wrote: >> In Tue, Aug 27, 2013 at 6:01 AM, Michel Lespinasse wrote: >>> On Fri, Aug 23, 2013 at 7:45 AM, wrote: >>>> From: Zhi Yong Wu >&g

Re: [PATCH] rbtree: Add some necessary condition checks

2013-09-02 Thread Zhi Yong Wu
In Tue, Aug 27, 2013 at 6:01 AM, Michel Lespinasse wrote: > On Fri, Aug 23, 2013 at 7:45 AM, wrote: >> From: Zhi Yong Wu >> >> Signed-off-by: Zhi Yong Wu >> --- >> include/linux/rbtree_augmented.h | 3 ++- >> lib/rbtree.c | 5 +++--

Re: [PATCH] rbtree: Add some necessary condition checks

2013-09-02 Thread Zhi Yong Wu
In Tue, Aug 27, 2013 at 6:01 AM, Michel Lespinasse wal...@google.com wrote: On Fri, Aug 23, 2013 at 7:45 AM, zwu.ker...@gmail.com wrote: From: Zhi Yong Wu wu...@linux.vnet.ibm.com Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com --- include/linux/rbtree_augmented.h | 3 ++- lib

Re: [PATCH] rbtree: Add some necessary condition checks

2013-09-02 Thread Zhi Yong Wu
On Mon, Sep 2, 2013 at 4:57 PM, Michel Lespinasse wal...@google.com wrote: On Sun, Sep 1, 2013 at 11:30 PM, Zhi Yong Wu zwu.ker...@gmail.com wrote: In Tue, Aug 27, 2013 at 6:01 AM, Michel Lespinasse wal...@google.com wrote: On Fri, Aug 23, 2013 at 7:45 AM, zwu.ker...@gmail.com wrote: From

Re: [PATCH] scsi: fix the build warning

2013-08-21 Thread Zhi Yong Wu
> } > > - if (scsi_debug_guard > 1) { > + if (scsi_debug_guard < 0 || scsi_debug_guard > 1) { I don't think that it can fix that issue. > printk(KERN_ERR "scsi_debug_init: guard must be 0 or 1\n"); > return -

Re: [PATCH] scsi: fix the build warning

2013-08-21 Thread Zhi Yong Wu
HI, If you'd like, you should draft one patch for this warning. On Thu, Aug 22, 2013 at 9:02 AM, Joe Perches wrote: > On Thu, 2013-08-22 at 08:44 +0800, zwu.ker...@gmail.com wrote: >> From: Zhi Yong Wu >> >> Initialize csum variable to fix the build warning. >

Re: [PATCH] scsi: fix the build warning

2013-08-21 Thread Zhi Yong Wu
HI, If you'd like, you should draft one patch for this warning. On Thu, Aug 22, 2013 at 9:02 AM, Joe Perches j...@perches.com wrote: On Thu, 2013-08-22 at 08:44 +0800, zwu.ker...@gmail.com wrote: From: Zhi Yong Wu wu...@linux.vnet.ibm.com Initialize csum variable to fix the build warning

Re: [PATCH] scsi: fix the build warning

2013-08-21 Thread Zhi Yong Wu
that it can fix that issue. printk(KERN_ERR scsi_debug_init: guard must be 0 or 1\n); return -EINVAL; } -- Regards, Zhi Yong Wu -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

Re: [PATCH v3] xfs: introduce object readahead to log recovery

2013-08-13 Thread Zhi Yong Wu
On Wed, Aug 14, 2013 at 1:35 PM, Dave Chinner wrote: > On Wed, Jul 31, 2013 at 04:42:45PM +0800, zwu.ker...@gmail.com wrote: >> From: Zhi Yong Wu >> >> It can take a long time to run log recovery operation because it is >> single threaded and is bound by read latenc

Re: [PATCH v3] xfs: introduce object readahead to log recovery

2013-08-13 Thread Zhi Yong Wu
On Wed, Aug 14, 2013 at 1:35 PM, Dave Chinner da...@fromorbit.com wrote: On Wed, Jul 31, 2013 at 04:42:45PM +0800, zwu.ker...@gmail.com wrote: From: Zhi Yong Wu wu...@linux.vnet.ibm.com It can take a long time to run log recovery operation because it is single threaded and is bound by read

Re: [PATCH v3] xfs: introduce object readahead to log recovery

2013-08-07 Thread Zhi Yong Wu
HI, xfs maintainers, any comments? On Wed, Jul 31, 2013 at 4:42 PM, wrote: > From: Zhi Yong Wu > > It can take a long time to run log recovery operation because it is > single threaded and is bound by read latency. We can find that it took > most of the time to wait for the r

Re: [PATCH v3] xfs: introduce object readahead to log recovery

2013-08-07 Thread Zhi Yong Wu
HI, xfs maintainers, any comments? On Wed, Jul 31, 2013 at 4:42 PM, zwu.ker...@gmail.com wrote: From: Zhi Yong Wu wu...@linux.vnet.ibm.com It can take a long time to run log recovery operation because it is single threaded and is bound by read latency. We can find that it took most

Re: [PATCH v2] xfs: introduce object readahead to log recovery

2013-07-31 Thread Zhi Yong Wu
On Wed, Jul 31, 2013 at 9:35 PM, Ben Myers wrote: > Hey Zhi, > > On Wed, Jul 31, 2013 at 12:07:32PM +0800, Zhi Yong Wu wrote: >> On Wed, Jul 31, 2013 at 7:11 AM, Dave Chinner wrote: >> > On Tue, Jul 30, 2013 at 05:59:07PM +0800, zwu.ker...@gmail.com wrote:

Re: [PATCH v2] xfs: introduce object readahead to log recovery

2013-07-31 Thread Zhi Yong Wu
On Wed, Jul 31, 2013 at 9:35 PM, Ben Myers b...@sgi.com wrote: Hey Zhi, On Wed, Jul 31, 2013 at 12:07:32PM +0800, Zhi Yong Wu wrote: On Wed, Jul 31, 2013 at 7:11 AM, Dave Chinner da...@fromorbit.com wrote: On Tue, Jul 30, 2013 at 05:59:07PM +0800, zwu.ker...@gmail.com wrote: From: Zhi Yong

Re: [PATCH v2] xfs: introduce object readahead to log recovery

2013-07-30 Thread Zhi Yong Wu
On Wed, Jul 31, 2013 at 7:11 AM, Dave Chinner wrote: > On Tue, Jul 30, 2013 at 05:59:07PM +0800, zwu.ker...@gmail.com wrote: >> From: Zhi Yong Wu >> >> It can take a long time to run log recovery operation because it is >> single threaded and is bound by read latenc

Re: [PATCH v2] xfs: introduce object readahead to log recovery

2013-07-30 Thread Zhi Yong Wu
On Tue, Jul 30, 2013 at 9:10 PM, Brian Foster wrote: > On 07/30/2013 05:59 AM, zwu.ker...@gmail.com wrote: >> From: Zhi Yong Wu >> >> It can take a long time to run log recovery operation because it is >> single threaded and is bound by read latency. We ca

Re: [PATCH v2] xfs: introduce object readahead to log recovery

2013-07-30 Thread Zhi Yong Wu
On Tue, Jul 30, 2013 at 9:10 PM, Brian Foster bfos...@redhat.com wrote: On 07/30/2013 05:59 AM, zwu.ker...@gmail.com wrote: From: Zhi Yong Wu wu...@linux.vnet.ibm.com It can take a long time to run log recovery operation because it is single threaded and is bound by read latency. We can

Re: [PATCH v2] xfs: introduce object readahead to log recovery

2013-07-30 Thread Zhi Yong Wu
On Wed, Jul 31, 2013 at 7:11 AM, Dave Chinner da...@fromorbit.com wrote: On Tue, Jul 30, 2013 at 05:59:07PM +0800, zwu.ker...@gmail.com wrote: From: Zhi Yong Wu wu...@linux.vnet.ibm.com It can take a long time to run log recovery operation because it is single threaded and is bound by read

Re: [PATCH] xfs: fix an assertion failure

2013-07-29 Thread Zhi Yong Wu
On Fri, Jul 26, 2013 at 7:37 PM, Dave Chinner wrote: > On Fri, Jul 26, 2013 at 02:01:23PM +0800, Zhi Yong Wu wrote: >> No, it still raised the same assertion as below: >> >> [ 521.715103] XFS: Assertion failed: !(bip->bli_item.li_flags & >> XFS_LI_IN_AIL), file

Re: [PATCH] xfs: fix an assertion failure

2013-07-29 Thread Zhi Yong Wu
On Fri, Jul 26, 2013 at 7:37 PM, Dave Chinner da...@fromorbit.com wrote: On Fri, Jul 26, 2013 at 02:01:23PM +0800, Zhi Yong Wu wrote: No, it still raised the same assertion as below: [ 521.715103] XFS: Assertion failed: !(bip-bli_item.li_flags XFS_LI_IN_AIL), file: fs/xfs/xfs_buf_item.c

Re: [PATCH] xfs: introduce object readahead to log recovery

2013-07-28 Thread Zhi Yong Wu
On Mon, Jul 29, 2013 at 10:45 AM, Dave Chinner wrote: > On Mon, Jul 29, 2013 at 09:38:11AM +0800, Zhi Yong Wu wrote: >> By the way, how do you try the workload which has nothing but dirty >> dquote objects? > > Create quota limits for non-existent users. That will allocate t

Re: [PATCH] xfs: introduce object readahead to log recovery

2013-07-28 Thread Zhi Yong Wu
On Fri, Jul 26, 2013 at 7:35 PM, Dave Chinner wrote: > On Fri, Jul 26, 2013 at 02:36:15PM +0800, Zhi Yong Wu wrote: >> Dave, >> >> All comments are good to me, and will be applied to next version, thanks a >> lot. >> >> On Fri, Jul 26, 2013 at 10:50 AM, D

Re: [PATCH] xfs: introduce object readahead to log recovery

2013-07-28 Thread Zhi Yong Wu
On Fri, Jul 26, 2013 at 7:35 PM, Dave Chinner da...@fromorbit.com wrote: On Fri, Jul 26, 2013 at 02:36:15PM +0800, Zhi Yong Wu wrote: Dave, All comments are good to me, and will be applied to next version, thanks a lot. On Fri, Jul 26, 2013 at 10:50 AM, Dave Chinner da...@fromorbit.com

Re: [PATCH] xfs: introduce object readahead to log recovery

2013-07-28 Thread Zhi Yong Wu
On Mon, Jul 29, 2013 at 10:45 AM, Dave Chinner da...@fromorbit.com wrote: On Mon, Jul 29, 2013 at 09:38:11AM +0800, Zhi Yong Wu wrote: By the way, how do you try the workload which has nothing but dirty dquote objects? Create quota limits for non-existent users. That will allocate the dquots

Re: [PATCH] xfs: introduce object readahead to log recovery

2013-07-26 Thread Zhi Yong Wu
Dave, All comments are good to me, and will be applied to next version, thanks a lot. On Fri, Jul 26, 2013 at 10:50 AM, Dave Chinner wrote: > On Thu, Jul 25, 2013 at 04:23:39PM +0800, zwu.ker...@gmail.com wrote: >> From: Zhi Yong Wu >> >> It can take a long time to run l

Re: [PATCH] xfs: fix an assertion failure

2013-07-26 Thread Zhi Yong Wu
800, zwu.ker...@gmail.com wrote: >> From: Zhi Yong Wu >> >> When running the compilebench, one assertion failure was found. >> This related line of code was introduced by commit 5f6bed76c0. >> >> commit 5f6bed76c0c85cb4d04885a5de00b629deee550b >> Author: Da

Re: [PATCH] xfs: fix an assertion failure

2013-07-26 Thread Zhi Yong Wu
)); xfs_buf_item_relse(bp); } } else [root@f17 linux-2.6]# On Fri, Jul 26, 2013 at 10:03 AM, Dave Chinner da...@fromorbit.com wrote: On Thu, Jul 25, 2013 at 09:38:44PM +0800, zwu.ker...@gmail.com wrote: From: Zhi Yong Wu wu...@linux.vnet.ibm.com When running the compilebench, one

Re: [PATCH] xfs: introduce object readahead to log recovery

2013-07-26 Thread Zhi Yong Wu
Dave, All comments are good to me, and will be applied to next version, thanks a lot. On Fri, Jul 26, 2013 at 10:50 AM, Dave Chinner da...@fromorbit.com wrote: On Thu, Jul 25, 2013 at 04:23:39PM +0800, zwu.ker...@gmail.com wrote: From: Zhi Yong Wu wu...@linux.vnet.ibm.com It can take

Re: [PATCH v2 00/12] VFS hot tracking

2013-05-23 Thread Zhi Yong Wu
HI, Al Viro. I have incorporated all comments from all reviewers and waited for so long time. If you have no comments, can you merge the patchset? thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More

Re: [PATCH v2 00/12] VFS hot tracking

2013-05-23 Thread Zhi Yong Wu
HI, Al Viro. I have incorporated all comments from all reviewers and waited for so long time. If you have no comments, can you merge the patchset? thanks. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More

Re: [PATCH v2 00/12] VFS hot tracking

2013-05-21 Thread Zhi Yong Wu
Ping... On Tue, May 14, 2013 at 8:59 AM, wrote: > From: Zhi Yong Wu > > The patchset is trying to introduce hot tracking function in > VFS layer, which will keep track of real disk I/O in memory. > By it, you will easily know more details about disk I/O, and > then detect

Re: [PATCH v2 00/12] VFS hot tracking

2013-05-21 Thread Zhi Yong Wu
Ping... On Tue, May 14, 2013 at 8:59 AM, zwu.ker...@gmail.com wrote: From: Zhi Yong Wu wu...@linux.vnet.ibm.com The patchset is trying to introduce hot tracking function in VFS layer, which will keep track of real disk I/O in memory. By it, you will easily know more details about disk I/O

Re: [PATCH RESEND v1 00/16] vfs: hot data tracking

2013-02-21 Thread Zhi Yong Wu
ping? any comments? On Thu, Dec 20, 2012 at 10:43 PM, wrote: > From: Zhi Yong Wu > > HI, guys, > > This patchset has been done scalability or performance tests > by fs_mark, ffsb and compilebench. > I have done the perf testing on Linux 3.7.0-rc8+ with Intel(R) C

Re: [PATCH RESEND v1 00/16] vfs: hot data tracking

2013-02-21 Thread Zhi Yong Wu
ping? any comments? On Thu, Dec 20, 2012 at 10:43 PM, zwu.ker...@gmail.com wrote: From: Zhi Yong Wu wu...@linux.vnet.ibm.com HI, guys, This patchset has been done scalability or performance tests by fs_mark, ffsb and compilebench. I have done the perf testing on Linux 3.7.0-rc8

Re: [PATCH RESEND v1 03/16] vfs: add I/O frequency update function

2013-01-11 Thread Zhi Yong Wu
On Fri, Jan 11, 2013 at 10:27 PM, David Sterba wrote: > On Fri, Jan 11, 2013 at 03:38:31PM +0800, Zhi Yong Wu wrote: >> On Thu, Jan 10, 2013 at 8:51 AM, David Sterba wrote: >> > On Thu, Dec 20, 2012 at 10:43:22PM +0800, zwu.ker...@gmail.com wrote: >> >> --- a/fs

Re: [PATCH RESEND v1 06/16] vfs: add temp calculation function

2013-01-11 Thread Zhi Yong Wu
lost in the shifts that > I don't see the meaning of the resulting value and how can I interpet it > if I watch it change over time. What are the expected weights of the > number and time factors? There are more details in the documentation, but > the big picture is blurred by talking implementati

Re: [PATCH RESEND v1 06/16] vfs: add temp calculation function

2013-01-11 Thread Zhi Yong Wu
the temperature? You've been benchmarking this patchset, I'm sure you can write up a few examples based on that. + + return result; +} david -- Regards, Zhi Yong Wu -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

Re: [PATCH RESEND v1 03/16] vfs: add I/O frequency update function

2013-01-11 Thread Zhi Yong Wu
On Fri, Jan 11, 2013 at 10:27 PM, David Sterba dste...@suse.cz wrote: On Fri, Jan 11, 2013 at 03:38:31PM +0800, Zhi Yong Wu wrote: On Thu, Jan 10, 2013 at 8:51 AM, David Sterba dste...@suse.cz wrote: On Thu, Dec 20, 2012 at 10:43:22PM +0800, zwu.ker...@gmail.com wrote: --- a/fs

Re: [PATCH RESEND v1 05/16] vfs: add hooks to enable hot tracking

2013-01-10 Thread Zhi Yong Wu
,6 +139,12 @@ static int read_pages(struct address_space *mapping, >> struct file *filp, >> out: >> blk_finish_plug(); >> >> + /* Hot data tracking */ >> + hot_update_freqs(mapping->host, >> + (loff_t)(list_entry(pages->prev, struct page, lru)->index) >> + << PAGE_CACHE_SHIFT, >> + (size_t)nr_pages * PAGE_CACHE_SIZE, 0); > > same comment here Ditto. thanks. > >> + >> return ret; >> } > > > david -- Regards, Zhi Yong Wu -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH RESEND v1 03/16] vfs: add I/O frequency update function

2013-01-10 Thread Zhi Yong Wu
_freq_data_update(struct hot_freq_data *freq_data, bool >> write) >> +{ >> + struct timespec cur_time = current_kernel_time(); >> + >> + if (write) { >> + freq_data->nr_writes += 1; > > The preferred style is > > freq_data->nr_writes++ OK, done. > >> + hot_rw_freq_calc(freq_data->last_write_time, >> + cur_time, >> + _data->avg_delta_writes); >> + freq_data->last_write_time = cur_time; >> + } else { >> + freq_data->nr_reads += 1; > > (...) > >> + hot_rw_freq_calc(freq_data->last_read_time, >> + freq_data->last_read_time, >> + cur_time, >> + _data->avg_delta_reads); >> + freq_data->last_read_time = cur_time; >> + } >> +} >> + > > david -- Regards, Zhi Yong Wu -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH RESEND v1 02/16] vfs: add init and cleanup functions

2013-01-10 Thread Zhi Yong Wu
On Thu, Jan 10, 2013 at 8:48 AM, David Sterba wrote: > On Thu, Dec 20, 2012 at 10:43:21PM +0800, zwu.ker...@gmail.com wrote: >> From: Zhi Yong Wu >> --- a/fs/hot_tracking.c >> +++ b/fs/hot_tracking.c >> @@ -107,3 +189,38 @@ err: >> kmem_ca

Re: [PATCH RESEND v1 02/16] vfs: add init and cleanup functions

2013-01-10 Thread Zhi Yong Wu
On Thu, Jan 10, 2013 at 8:48 AM, David Sterba dste...@suse.cz wrote: On Thu, Dec 20, 2012 at 10:43:21PM +0800, zwu.ker...@gmail.com wrote: From: Zhi Yong Wu wu...@linux.vnet.ibm.com --- a/fs/hot_tracking.c +++ b/fs/hot_tracking.c @@ -107,3 +189,38 @@ err: kmem_cache_destroy

Re: [PATCH RESEND v1 03/16] vfs: add I/O frequency update function

2013-01-10 Thread Zhi Yong Wu
-avg_delta_reads); + freq_data-last_read_time = cur_time; + } +} + david -- Regards, Zhi Yong Wu -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH RESEND v1 05/16] vfs: add hooks to enable hot tracking

2013-01-10 Thread Zhi Yong Wu
(mapping-host, + (loff_t)(list_entry(pages-prev, struct page, lru)-index) + PAGE_CACHE_SHIFT, + (size_t)nr_pages * PAGE_CACHE_SIZE, 0); same comment here Ditto. thanks. + return ret; } david -- Regards, Zhi Yong Wu -- To unsubscribe

Re: [PATCH RESEND v1 01/16] vfs: introduce some data structures

2013-01-09 Thread Zhi Yong Wu
ile name written here is not wanted, so > please drop it (and from .h too) Done. > >> + * >> + * Copyright (C) 2012 IBM Corp. All rights reserved. >> + * Written by Zhi Yong Wu >> + * >> + * This program is free software; you can redistribute it and/or &

Re: [PATCH RESEND v1 01/16] vfs: introduce some data structures

2013-01-09 Thread Zhi Yong Wu
, so please drop it (and from .h too) Done. + * + * Copyright (C) 2012 IBM Corp. All rights reserved. + * Written by Zhi Yong Wu wu...@linux.vnet.ibm.com + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public + * License v2

<    1   2   3   4   5   >