[PATCH v6 1/2] scsi: ufs: Fix ufs clk specs violation

2021-01-08 Thread Ziqi Chen
As per specs, e.g, JESD220E chapter 7.2, while powering off/on the ufs device, REF_CLK signal should be between VSS(Ground) and VCCQ/VCCQ2. Reviewed-by: Can Guo Signed-off-by: Ziqi Chen --- drivers/scsi/ufs/ufshcd.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions

[PATCH v6 2/2] scsi: ufs-qcom: Fix ufs RST_n specs violation

2021-01-08 Thread Ziqi Chen
As per specs, e.g, JESD220E chapter 7.2, while powering off/on the ufs device, RST_n signal should be between VSS(Ground) and VCCQ/VCCQ2. Signed-off-by: Ziqi Chen --- drivers/scsi/ufs/ufs-qcom.c | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/drivers/scsi

[PATCH v5 2/2] scsi: ufs-qcom: Fix ufs RST_n specs violation

2021-01-07 Thread Ziqi Chen
As per specs, e.g, JESD220E chapter 7.2, while powering off/on the ufs device, RST_n signal should be between VSS(Ground) and VCCQ/VCCQ2. Signed-off-by: Ziqi Chen --- drivers/scsi/ufs/ufs-qcom.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/scsi/ufs/ufs-qcom.c b/drivers/scsi

[PATCH v5 1/2] scsi: ufs: Fix ufs clk specs violation

2021-01-07 Thread Ziqi Chen
As per specs, e.g, JESD220E chapter 7.2, while powering off/on the ufs device, REF_CLK signal should be between VSS(Ground) and VCCQ/VCCQ2. Signed-off-by: Ziqi Chen --- drivers/scsi/ufs/ufshcd.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers

[PATCH RFC v4 1/1] scsi: ufs: Fix ufs power down/on specs violation

2020-12-22 Thread Ziqi Chen
(sturct ufs_hba *hba, bool asserted). The new parameter "bool asserted" is used to separate device reset line pulling down from pulling up. Cc: Kiwoong Kim Cc: Stanley Chu Signed-off-by: Ziqi Chen --- drivers/scsi/ufs/ufs-mediatek.c | 32 drivers/scsi/ufs/

[PATCH RFC v3 1/1] scsi: ufs: Fix ufs power down/on specs violation

2020-12-20 Thread Ziqi Chen
vops_toggle_device_reset(sturct ufs_hba *hba, bool down). The new parameter "bool down" is used to separate device reset line pulling down from pulling up. Cc: Kiwoong Kim Cc: Stanley Chu Signed-off-by: Ziqi Chen --- drivers/scsi/ufs/ufs-mediatek.c | 27 +- drivers/scsi/ufs/ufs-qcom.

[PATCH RFC v2 1/1] scsi: ufs: Fix ufs power down/on specs violation

2020-12-20 Thread Ziqi Chen
vops_toggle_device_reset(sturct ufs_hba *hba, bool up). The new parameter "bool up" is used to separate device reset line pulling up from pulling down. Cc: Kiwoong Kim Cc: Stanley Chu Signed-off-by: Ziqi Chen --- drivers/scsi/ufs/ufs-mediatek.c | 27 +- drivers/scsi/ufs/ufs-qcom.

[PATCH v1 1/1] scsi: ufs: Fix ufs power down/on specs violation

2020-12-08 Thread Ziqi Chen
. Turn-On REF_CLK 4. Deassert RST_N high. Signed-off-by: Ziqi Chen --- drivers/scsi/ufs/ufs-qcom.c | 14 ++ drivers/scsi/ufs/ufshcd.c | 19 +-- drivers/scsi/ufs/ufshcd.h | 4 ++-- 3 files changed, 21 insertions(+), 16 deletions(-) diff --git a/drivers/scsi/ufs