Re: [PATCH 1/2] phy: rockchip-emmc: retry calpad busy trimming

hi , On 01/02/2018 10:21 AM, Shawn Lin wrote: It turns out that 5us isn't enough for all cases, so let's retry some more times to wait for caldone. Signed-off-by: Shawn Lin<shawn@rock-chips.com> Tested-by: Ziyuan Xu <xzy...@rock-chips.com> On the Firefly RK3399 board. Thanks

Re: [PATCH 1/2] phy: rockchip-emmc: retry calpad busy trimming

hi , On 01/02/2018 10:21 AM, Shawn Lin wrote: It turns out that 5us isn't enough for all cases, so let's retry some more times to wait for caldone. Signed-off-by: Shawn Lin Tested-by: Ziyuan Xu On the Firefly RK3399 board. Thanks. -- Ziyuan Xu

Re: [BUG] Boot failure since df9bcc2bc on veyron_speedy

is on the way, https://patchwork.kernel.org/patch/9498527/ Great - thanks for letting me know. Can you share the result ? BR Ziyuan Xu Thanks, S. Gilles -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majord...@vger.kernel.org More

Re: [BUG] Boot failure since df9bcc2bc on veyron_speedy

is on the way, https://patchwork.kernel.org/patch/9498527/ Great - thanks for letting me know. Can you share the result ? BR Ziyuan Xu Thanks, S. Gilles -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majord...@vger.kernel.org More

Re: [PATCH v4] mmc: dw_mmc: force setup bus if active slots exist

On 01/05/2017 03:34 PM, Shawn Lin wrote: On 2017/1/5 15:23, Ziyuan Xu wrote: It's necessary to setup bus if any slots are present. - update clock after ctrl reset - if the host has genpd node, we can guarantee the clock is available before starting request. Otherwies, the clock register

Re: [PATCH v4] mmc: dw_mmc: force setup bus if active slots exist

On 01/05/2017 03:34 PM, Shawn Lin wrote: On 2017/1/5 15:23, Ziyuan Xu wrote: It's necessary to setup bus if any slots are present. - update clock after ctrl reset - if the host has genpd node, we can guarantee the clock is available before starting request. Otherwies, the clock register

Re: [PATCH] mmc: dw_mmc: Fix some coding style

On 01/05/2017 02:32 AM, Joe Perches wrote: On Wed, 2017-01-04 at 20:52 +0800, Ziyuan Xu wrote: Let's fix the warnings from checkpatch.pl: - line over 80 characters; - block comments should align the * on each Lines; - statements not starting on a tabstop. Signed-off-by: Ziyuan Xu <

Re: [PATCH] mmc: dw_mmc: Fix some coding style

On 01/05/2017 02:32 AM, Joe Perches wrote: On Wed, 2017-01-04 at 20:52 +0800, Ziyuan Xu wrote: Let's fix the warnings from checkpatch.pl: - line over 80 characters; - block comments should align the * on each Lines; - statements not starting on a tabstop. Signed-off-by: Ziyuan Xu

[PATCH v4] mmc: dw_mmc: force setup bus if active slots exist

communication. fixes: e9ed8835e990 ("mmc: dw_mmc: add runtime PM callback") Reported-by: Randy Li <randy...@rock-chips.com> Signed-off-by: Ziyuan Xu <xzy...@rock-chips.com> --- Hi guys, I found a similar issue on rk3399 platform, which has a genpd node for SD card host. Powe

[PATCH v4] mmc: dw_mmc: force setup bus if active slots exist

communication. fixes: e9ed8835e990 ("mmc: dw_mmc: add runtime PM callback") Reported-by: Randy Li Signed-off-by: Ziyuan Xu --- Hi guys, I found a similar issue on rk3399 platform, which has a genpd node for SD card host. Power off-on pd will reset the registers to a default value (ie. C

[PATCH v3] mmc: dw_mmc: revise the reset path in runtime resume

t;mmc: dw_mmc: add runtime PM callback"). MMC_PM_KEEP_POWEP is disabled for SD card and eMMC slots, so that they have no chance to invoke dw_mci_setup_bus for update clock behaviour. Let's consummate it. Reported-by: Randy Li <randy...@rock-chips.com> Signed-off-by: Ziyuan Xu <xz

[PATCH v3] mmc: dw_mmc: revise the reset path in runtime resume

t;mmc: dw_mmc: add runtime PM callback"). MMC_PM_KEEP_POWEP is disabled for SD card and eMMC slots, so that they have no chance to invoke dw_mci_setup_bus for update clock behaviour. Let's consummate it. Reported-by: Randy Li Signed-off-by: Ziyuan Xu --- Changes in v3: - only reset host with a

Re: [PATCH v2] mmc: dw_mmc: revise the reset path in runtime resume

On 01/05/2017 09:29 AM, Jaehoon Chung wrote: On 01/05/2017 01:04 AM, ayaka wrote: On 01/04/2017 08:51 PM, Ziyuan Xu wrote: Immediately after reset, issue the command which sets update_clock_register_only bit, the card clock will restart. Revise dw_mci_ctrl_reset to dw_mci_reset, which has

Re: [PATCH v2] mmc: dw_mmc: revise the reset path in runtime resume

On 01/05/2017 09:29 AM, Jaehoon Chung wrote: On 01/05/2017 01:04 AM, ayaka wrote: On 01/04/2017 08:51 PM, Ziyuan Xu wrote: Immediately after reset, issue the command which sets update_clock_register_only bit, the card clock will restart. Revise dw_mci_ctrl_reset to dw_mci_reset, which has

[RESEND PATCH v3] mmc: dw_mmc: revise the reset path in runtime resume

t;mmc: dw_mmc: add runtime PM callback"). MMC_PM_KEEP_POWEP is disabled for SD card and eMMC slots, so that they have no chance to invoke dw_mci_setup_bus for update clock behaviour. Let's consummate it. Reported-by: Randy Li <randy...@rock-chips.com> Signed-off-by: Ziyuan Xu <xzy...@roc

[RESEND PATCH v3] mmc: dw_mmc: revise the reset path in runtime resume

t;mmc: dw_mmc: add runtime PM callback"). MMC_PM_KEEP_POWEP is disabled for SD card and eMMC slots, so that they have no chance to invoke dw_mci_setup_bus for update clock behaviour. Let's consummate it. Reported-by: Randy Li Signed-off-by: Ziyuan Xu Signed-off-by: Shawn Lin --- Changes in

[PATCH v2] mmc: dw_mmc: revise the reset path in runtime resume

s disabled for SD card and eMMC slots, so that they have no chance to invoke dw_mci_setup_bus for update clock behaviour. Let's consummate it. Reported-by: Randy Li <randy...@rock-chips.com> Signed-off-by: Ziyuan Xu <xzy...@rock-chips.com> --- Changes in v2: - update the commit mess

[PATCH v2] mmc: dw_mmc: revise the reset path in runtime resume

s disabled for SD card and eMMC slots, so that they have no chance to invoke dw_mci_setup_bus for update clock behaviour. Let's consummate it. Reported-by: Randy Li Signed-off-by: Ziyuan Xu --- Changes in v2: - update the commit message - use dw_mci_reset instead of dw_mci_ctrl_reset driver

[PATCH] mmc: dw_mmc: Fix some coding style

Let's fix the warnings from checkpatch.pl: - line over 80 characters; - block comments should align the * on each Lines; - statements not starting on a tabstop. Signed-off-by: Ziyuan Xu <xzy...@rock-chips.com> --- drivers/mmc/host/dw_mmc.c | 33 + 1 file c

[PATCH] mmc: dw_mmc: Fix some coding style

Let's fix the warnings from checkpatch.pl: - line over 80 characters; - block comments should align the * on each Lines; - statements not starting on a tabstop. Signed-off-by: Ziyuan Xu --- drivers/mmc/host/dw_mmc.c | 33 + 1 file changed, 17 insertions(+), 16

Re: [PATCH 2/6] arm64: dts: rockchip: add pd_emmc power node for rk3399

hi Elaine, On 2016年09月09日 15:40, Elaine Zhang wrote: 1.add pd node for RK3399 Soc 2.create power domain tree 3.add qos node for domain 4.add the pd_emmc consumers node Signed-off-by: Elaine Zhang I had push this patch, see [0] [0]

Re: [PATCH 2/6] arm64: dts: rockchip: add pd_emmc power node for rk3399

hi Elaine, On 2016年09月09日 15:40, Elaine Zhang wrote: 1.add pd node for RK3399 Soc 2.create power domain tree 3.add qos node for domain 4.add the pd_emmc consumers node Signed-off-by: Elaine Zhang I had push this patch, see [0] [0] https://patchwork.kernel.org/patch/9320423/ ---

Re: [PATCH 2/2] arm64: dts: rockchip: add eMMC's power domain support for rk3399

Hi Ulf, On 2016年09月02日 18:24, Ulf Hansson wrote: On 1 September 2016 at 23:50, Doug Anderson wrote: >Hi, > >On Thu, Sep 1, 2016 at 6:45 AM, Ulf Hansson wrote: >>I was reading the discussion regarding this change and browsing the DT

Re: [PATCH 2/2] arm64: dts: rockchip: add eMMC's power domain support for rk3399

Hi Ulf, On 2016年09月02日 18:24, Ulf Hansson wrote: On 1 September 2016 at 23:50, Doug Anderson wrote: >Hi, > >On Thu, Sep 1, 2016 at 6:45 AM, Ulf Hansson wrote: >>I was reading the discussion regarding this change and browsing the DT >>documentation around this... Can you guys explain what

Re: [PATCH 2/2] arm64: dts: rockchip: add eMMC's power domain support for rk3399

On 2016年09月02日 05:29, Doug Anderson wrote: Hi, On Wed, Aug 31, 2016 at 11:56 PM, Ziyuan Xu <xzy...@rock-chips.com> wrote: Hi On 2016年09月01日 12:20, Doug Anderson wrote: Hi, On Wed, Aug 31, 2016 at 7:29 PM, Ziyuan Xu <xzy...@rock-chips.com> wrote: This is fine to pick up _

Re: [PATCH 2/2] arm64: dts: rockchip: add eMMC's power domain support for rk3399

On 2016年09月02日 05:29, Doug Anderson wrote: Hi, On Wed, Aug 31, 2016 at 11:56 PM, Ziyuan Xu wrote: Hi On 2016年09月01日 12:20, Doug Anderson wrote: Hi, On Wed, Aug 31, 2016 at 7:29 PM, Ziyuan Xu wrote: This is fine to pick up _only_ if you don't care about suspend/resume. If you care

Re: [PATCH 2/2] arm64: dts: rockchip: add eMMC's power domain support for rk3399

Hi On 2016年09月01日 12:20, Doug Anderson wrote: Hi, On Wed, Aug 31, 2016 at 7:29 PM, Ziyuan Xu <xzy...@rock-chips.com> wrote: This is fine to pick up _only_ if you don't care about suspend/resume. If you care about suspend/resume then someone needs to first write a patch that will re-in

Re: [PATCH 2/2] arm64: dts: rockchip: add eMMC's power domain support for rk3399

Hi On 2016年09月01日 12:20, Doug Anderson wrote: Hi, On Wed, Aug 31, 2016 at 7:29 PM, Ziyuan Xu wrote: This is fine to pick up _only_ if you don't care about suspend/resume. If you care about suspend/resume then someone needs to first write a patch that will re-init all "corecfg" va

Re: [PATCH 2/2] arm64: dts: rockchip: add eMMC's power domain support for rk3399

Hi, On 2016年09月01日 01:42, Doug Anderson wrote: Hi, On Sun, Aug 28, 2016 at 8:25 PM, Shawn Lin <shawn@rock-chips.com> wrote: On 2016/8/29 10:50, Elaine Zhang wrote: On 08/27/2016 11:05 PM, Shawn Lin wrote: On 2016/8/27 21:41, Ziyuan Xu wrote: Control power domain for eMMC via

Re: [PATCH 2/2] arm64: dts: rockchip: add eMMC's power domain support for rk3399

Hi, On 2016年09月01日 01:42, Doug Anderson wrote: Hi, On Sun, Aug 28, 2016 at 8:25 PM, Shawn Lin wrote: On 2016/8/29 10:50, Elaine Zhang wrote: On 08/27/2016 11:05 PM, Shawn Lin wrote: On 2016/8/27 21:41, Ziyuan Xu wrote: Control power domain for eMMC via genpd to reduce power consumption

Re: [PATCH v2 2/4] mmc: sdhci-of-arasan: Control clock for accessing syscon

ock-chips.com> --- Without this series of patches, we can't gate aclk_emmcgrf even though driver enter suspend/remove. It meaningful to save power consumption. It looks nice to me, and also I have tested on rk3399 board, so Tested-by: Ziyuan Xu <xzy...@rock-chips.com> Change

Re: [PATCH v2 3/4] arm64: dts: rockchip: add clk_syscon for sdhci on rk3399

uspend. Reviewed-by: Ziyuan Xu <xzy...@rock-chips.com> Tested-by: Ziyuan Xu <xzy...@rock-chips.com> Changes in v2: None arch/arm64/boot/dts/rockchip/rk3399.dtsi | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/a

Re: [PATCH v2 2/4] mmc: sdhci-of-arasan: Control clock for accessing syscon

his series of patches, we can't gate aclk_emmcgrf even though driver enter suspend/remove. It meaningful to save power consumption. It looks nice to me, and also I have tested on rk3399 board, so Tested-by: Ziyuan Xu Changes in v2: - assign NULL to clk_syscon if it's not deferral error. d

Re: [PATCH v2 3/4] arm64: dts: rockchip: add clk_syscon for sdhci on rk3399

Hi Shawn, On 2016年08月31日 09:37, Shawn Lin wrote: We are intent on letting the sdhci variant driver handle this optional clock on rk3399 platform now. Signed-off-by: Shawn Lin --- Thanks for your patch, we can gate aclk_emmcgrf now as soon as sdhci driver suspend. Reviewed-by: Ziyuan Xu

Re: [PATCH v2 4/4] clk: rockchip: remove CLK_IGNORE_UNUSED flag for aclk_emmc_grf on rk3399

760380 0x0415 It works sane, so Tested-by: Ziyuan Xu <xzy...@rock-chips.com> --- Changes in v2: None drivers/clk/rockchip/clk-rk3399.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/rockchip/clk-rk3399.c b/drivers/clk/rockchip/clk-rk3399.c index ede6

Re: [PATCH v2 4/4] clk: rockchip: remove CLK_IGNORE_UNUSED flag for aclk_emmc_grf on rk3399

Tested-by: Ziyuan Xu --- Changes in v2: None drivers/clk/rockchip/clk-rk3399.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/rockchip/clk-rk3399.c b/drivers/clk/rockchip/clk-rk3399.c index ede6c47..908f684 100644 --- a/drivers/clk/rockchip/clk-rk3399.c

Re: [PATCH 1/2] Documentation: mmc: sdhci-of-arasan: add description of power domain

On 2016年08月27日 22:50, Shawn Lin wrote: On 2016/8/27 21:41, Ziyuan Xu wrote: Add power domain as a optional property for sdhci-of-arasan, which can be truned off in the so-called unused condition, such as suspend and remove. Aim to lower power requirements. Signed-off-by: Ziyuan Xu <

Re: [PATCH 1/2] Documentation: mmc: sdhci-of-arasan: add description of power domain

On 2016年08月27日 22:50, Shawn Lin wrote: On 2016/8/27 21:41, Ziyuan Xu wrote: Add power domain as a optional property for sdhci-of-arasan, which can be truned off in the so-called unused condition, such as suspend and remove. Aim to lower power requirements. Signed-off-by: Ziyuan Xu

[PATCH 1/2] Documentation: mmc: sdhci-of-arasan: add description of power domain

Add power domain as a optional property for sdhci-of-arasan, which can be truned off in the so-called unused condition, such as suspend and remove. Aim to lower power requirements. Signed-off-by: Ziyuan Xu <xzy...@rock-chips.com> --- Documentation/devicetree/bindings/mmc/arasan,sdhci.t

[PATCH 1/2] Documentation: mmc: sdhci-of-arasan: add description of power domain

Add power domain as a optional property for sdhci-of-arasan, which can be truned off in the so-called unused condition, such as suspend and remove. Aim to lower power requirements. Signed-off-by: Ziyuan Xu --- Documentation/devicetree/bindings/mmc/arasan,sdhci.txt | 6 +- 1 file changed

[PATCH 2/2] arm64: dts: rockchip: add eMMC's power domain support for rk3399

Control power domain for eMMC via genpd to reduce power consumption. Signed-off-by: Elaine Zhang <zhangq...@rock-chips.com> Signed-off-by: Ziyuan Xu <xzy...@rock-chips.com> --- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 11 +++ 1 file changed, 11 insertions(+) diff --git

[PATCH 0/2] Add power domain support for eMMC node on rk3399

This series add power domain for eMMC node which will be controlled by genpd to make sure it's available in probing state, and will be off once suspend/remove. Ziyuan Xu (2): Documentation: mmc: sdhci-of-arasan: add description of power domain arm64: dts: rockchip: add eMMC's power domain

[PATCH 2/2] arm64: dts: rockchip: add eMMC's power domain support for rk3399

Control power domain for eMMC via genpd to reduce power consumption. Signed-off-by: Elaine Zhang Signed-off-by: Ziyuan Xu --- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 11 +++ 1 file changed, 11 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot

[PATCH 0/2] Add power domain support for eMMC node on rk3399

This series add power domain for eMMC node which will be controlled by genpd to make sure it's available in probing state, and will be off once suspend/remove. Ziyuan Xu (2): Documentation: mmc: sdhci-of-arasan: add description of power domain arm64: dts: rockchip: add eMMC's power domain