Re: [PATCH] v4l: fix build error for et61x251 driver

2007-09-14 Thread aherrman
On Fri, Sep 14, 2007 at 03:53:06AM +0200, Luca Risolia wrote: > On Friday 14 September 2007 02:09:01 Linus Torvalds wrote: > > On Fri, 14 Sep 2007, Luca Risolia wrote: > > > Hacked-by: Luca Risolia <[EMAIL PROTECTED]> > > > > > > On Friday 14 September 2007 00:27:17 Andreas Herrmann wrote: > > > >

Re: [PATCH] v4l: fix build error for et61x251 driver

2007-09-14 Thread aherrman
On Fri, Sep 14, 2007 at 03:53:06AM +0200, Luca Risolia wrote: On Friday 14 September 2007 02:09:01 Linus Torvalds wrote: On Fri, 14 Sep 2007, Luca Risolia wrote: Hacked-by: Luca Risolia [EMAIL PROTECTED] On Friday 14 September 2007 00:27:17 Andreas Herrmann wrote: This fixes a

Commit 02a5e0acb3cb85d80d0fe834e366d38a92bbaa22 might break kernel build

2007-09-13 Thread aherrman
Due to commit 02a5e0acb3cb85d80d0fe834e366d38a92bbaa22 kernel build is broken if (CONFIG_COMPAT && ! CONFIG_BLOCK): CC fs/compat_ioctl.o In file included from include/linux/raid/md_k.h:19, from include/linux/raid/md.h:54, from fs/compat_ioctl.c:25:

Re: [PATCH] v4l: Build error with et61x251, if V4L1_COMPAT is not selected

2007-09-13 Thread aherrman
On Thu, Sep 13, 2007 at 05:07:16PM +0200, Luca Risolia wrote: > On Thursday 13 September 2007 14:36:27 [EMAIL PROTECTED] wrote: > > With current git tree I get an build error > > for et61x251, if V4L1_COMPAT is not selected: > > > > drivers/media/video/et61x251/et61x251_core.c: In et61x251_show_:

[PATCH] v4l: Build error with et61x251, if V4L1_COMPAT is not selected

2007-09-13 Thread aherrman
With current git tree I get an build error for et61x251, if V4L1_COMPAT is not selected: drivers/media/video/et61x251/et61x251_core.c: In et61x251_show_: drivers/media/video/et61x251/et61x251_core.c:718: error: implicit declaration of to_video_device Fix: add VIDEO_V4L1_COMPAT as a dependency

[PATCH] v4l: Build error with et61x251, if V4L1_COMPAT is not selected

2007-09-13 Thread aherrman
With current git tree I get an build error for et61x251, if V4L1_COMPAT is not selected: drivers/media/video/et61x251/et61x251_core.c: In et61x251_show_: drivers/media/video/et61x251/et61x251_core.c:718: error: implicit declaration of to_video_device Fix: add VIDEO_V4L1_COMPAT as a dependency

Re: [PATCH] v4l: Build error with et61x251, if V4L1_COMPAT is not selected

2007-09-13 Thread aherrman
On Thu, Sep 13, 2007 at 05:07:16PM +0200, Luca Risolia wrote: On Thursday 13 September 2007 14:36:27 [EMAIL PROTECTED] wrote: With current git tree I get an build error for et61x251, if V4L1_COMPAT is not selected: drivers/media/video/et61x251/et61x251_core.c: In et61x251_show_:

Commit 02a5e0acb3cb85d80d0fe834e366d38a92bbaa22 might break kernel build

2007-09-13 Thread aherrman
Due to commit 02a5e0acb3cb85d80d0fe834e366d38a92bbaa22 kernel build is broken if (CONFIG_COMPAT ! CONFIG_BLOCK): CC fs/compat_ioctl.o In file included from include/linux/raid/md_k.h:19, from include/linux/raid/md.h:54, from fs/compat_ioctl.c:25:

[PATCH] radeonfb: fix chip definition for Radeon Xpress 200M 0x5975

2007-09-11 Thread aherrman
I think this is 2.6.23 material. Please apply. Thanks. Regards, Andreas -- radeonfb: fix chip definition for Radeon Xpress 200M 0x5975 This fixes a problem introduced with commit b5f2f4d1a6d7efde39cfb5e1d034981c69f2214c The commit added a wrong chip definition to radeonfb which causes a blank

[PATCH] radeonfb: fix setting of PPLL_REF_DIV for RV370 5B60

2007-09-11 Thread aherrman
IMHO this is 2.6.23 material. Please apply. Thanks a lot. Regards, Andreas -- radeonfb: fix setting of PPLL_REF_DIV for RV370 5B60. As observed with various Radeon X300 cards console goes blank without that fix. Acked-by: Benjamin Herrenschmidt <[EMAIL PROTECTED]> Signed-off-by: Andreas

[PATCH] radeonfb: fix setting of PPLL_REF_DIV for RV370 5B60

2007-09-11 Thread aherrman
IMHO this is 2.6.23 material. Please apply. Thanks a lot. Regards, Andreas -- radeonfb: fix setting of PPLL_REF_DIV for RV370 5B60. As observed with various Radeon X300 cards console goes blank without that fix. Acked-by: Benjamin Herrenschmidt [EMAIL PROTECTED] Signed-off-by: Andreas

[PATCH] radeonfb: fix chip definition for Radeon Xpress 200M 0x5975

2007-09-11 Thread aherrman
I think this is 2.6.23 material. Please apply. Thanks. Regards, Andreas -- radeonfb: fix chip definition for Radeon Xpress 200M 0x5975 This fixes a problem introduced with commit b5f2f4d1a6d7efde39cfb5e1d034981c69f2214c The commit added a wrong chip definition to radeonfb which causes a blank

[PATCH] radeonfb: bug fix for 2.6.23-rc5

2007-09-10 Thread aherrman
Commit b5f2f4d1a6d7efde39cfb5e1d034981c69f2214c adds PCI ID 0x5975 to radeonfb. But the chip family is wrong. Instead of R300 it should be RS480. With 2.6.23-rc5 and radeonfb enabled my Laptop hangs and console blanks. My ATI Radeon is the following model: ATI Technologies Inc RS482 [Radeon

Re: [Linux-fbdev-devel] [PATCH 1/4] radeonfb: add PCI Id for RS482/Radeon Xpress 200M

2007-09-10 Thread aherrman
On Tue, Sep 04, 2007 at 03:45:12PM +0200, Benjamin Herrenschmidt wrote: > On Tue, 2007-09-04 at 12:58 +0200, [EMAIL PROTECTED] wrote: > > .. which can be found in Acer Aspire 5100. > > > > Signed-off-by: Andreas Herrmann <[EMAIL PROTECTED]> > > Acked-by: Benjamin Herrenschmidt <[EMAIL

Re: [PATCH 2/4] radeonfb: add new module parameter to force PLL calculation

2007-09-10 Thread aherrman
On Tue, Sep 04, 2007 at 03:46:29PM +0200, Benjamin Herrenschmidt wrote: > I don't like those tunables. First we should get a look at what values > we obtain from the BIOS. Could be something with the parsing of ATOM > BIOS. In any case, we might be able to detect we got wrong values or use >

Re: [PATCH 4/4] radeonfb: use PCI device Id in hex for name string

2007-09-10 Thread aherrman
On Tue, Sep 04, 2007 at 03:48:07PM +0200, Benjamin Herrenschmidt wrote: > Well... ATI used to have printable characters and those were commonly > used to identify the cards. I'm not sure we want to unilateraly switch > to hex here... I see. How about the following patch? As an illustration this

Re: [PATCH 4/4] radeonfb: use PCI device Id in hex for name string

2007-09-10 Thread aherrman
On Tue, Sep 04, 2007 at 03:48:07PM +0200, Benjamin Herrenschmidt wrote: Well... ATI used to have printable characters and those were commonly used to identify the cards. I'm not sure we want to unilateraly switch to hex here... I see. How about the following patch? As an illustration this

Re: [PATCH 2/4] radeonfb: add new module parameter to force PLL calculation

2007-09-10 Thread aherrman
On Tue, Sep 04, 2007 at 03:46:29PM +0200, Benjamin Herrenschmidt wrote: I don't like those tunables. First we should get a look at what values we obtain from the BIOS. Could be something with the parsing of ATOM BIOS. In any case, we might be able to detect we got wrong values or use subsystem

Re: [Linux-fbdev-devel] [PATCH 1/4] radeonfb: add PCI Id for RS482/Radeon Xpress 200M

2007-09-10 Thread aherrman
On Tue, Sep 04, 2007 at 03:45:12PM +0200, Benjamin Herrenschmidt wrote: On Tue, 2007-09-04 at 12:58 +0200, [EMAIL PROTECTED] wrote: .. which can be found in Acer Aspire 5100. Signed-off-by: Andreas Herrmann [EMAIL PROTECTED] Acked-by: Benjamin Herrenschmidt [EMAIL PROTECTED] Sorry, I

[PATCH] radeonfb: bug fix for 2.6.23-rc5

2007-09-10 Thread aherrman
Commit b5f2f4d1a6d7efde39cfb5e1d034981c69f2214c adds PCI ID 0x5975 to radeonfb. But the chip family is wrong. Instead of R300 it should be RS480. With 2.6.23-rc5 and radeonfb enabled my Laptop hangs and console blanks. My ATI Radeon is the following model: ATI Technologies Inc RS482 [Radeon

[PATCH 4/4] radeonfb: use PCI device Id in hex for name string

2007-09-04 Thread aherrman
.. instead of potentially using nonprintable characters. I guess the former (odd) concatenation was used to construct name strings that match the "*_ATI_RADEON_??" macros in include/linux/pci_ids.h The PCI Id in hex is much more convenient to use. E.g. it can easily be verified against "lspci

[PATCH 2/4] radeonfb: add new module parameter to force PLL calculation

2007-09-04 Thread aherrman
On my Acer Aspire 5100 (with 0x5975) I need to force PLL caclulation. Most probably the BIOS dividers are incorrect/insufficient. Without pll calculation console goes blank. Signed-off-by: Andreas Herrmann <[EMAIL PROTECTED]> --- drivers/video/aty/radeon_base.c |7 ++- 1 files changed, 6

[PATCH 3/4] radeonfb: fix setting of PPLL_REF_DIV for RV370 5B60

2007-09-04 Thread aherrman
As observed with various Radeon X300: console goes blank without fixing setting of PPLL_REF_DIV. Signed-off-by: Andreas Herrmann <[EMAIL PROTECTED]> --- drivers/video/aty/radeon_base.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/video/aty/radeon_base.c

[PATCH 1/4] radeonfb: add PCI Id for RS482/Radeon Xpress 200M

2007-09-04 Thread aherrman
.. which can be found in Acer Aspire 5100. Signed-off-by: Andreas Herrmann <[EMAIL PROTECTED]> --- drivers/video/aty/ati_ids.h |1 + drivers/video/aty/radeon_base.c |1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/video/aty/ati_ids.h

[PATCH 0/4] radeonfb: minor fixes

2007-09-04 Thread aherrman
Hi, Following some minor changes for radeonfb. Main purpose is to get it working on my own Radeon cards. Patches are against current git. Regards, Andreas - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo

[PATCH 0/4] radeonfb: minor fixes

2007-09-04 Thread aherrman
Hi, Following some minor changes for radeonfb. Main purpose is to get it working on my own Radeon cards. Patches are against current git. Regards, Andreas - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info

[PATCH 1/4] radeonfb: add PCI Id for RS482/Radeon Xpress 200M

2007-09-04 Thread aherrman
.. which can be found in Acer Aspire 5100. Signed-off-by: Andreas Herrmann [EMAIL PROTECTED] --- drivers/video/aty/ati_ids.h |1 + drivers/video/aty/radeon_base.c |1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/video/aty/ati_ids.h

[PATCH 2/4] radeonfb: add new module parameter to force PLL calculation

2007-09-04 Thread aherrman
On my Acer Aspire 5100 (with 0x5975) I need to force PLL caclulation. Most probably the BIOS dividers are incorrect/insufficient. Without pll calculation console goes blank. Signed-off-by: Andreas Herrmann [EMAIL PROTECTED] --- drivers/video/aty/radeon_base.c |7 ++- 1 files changed, 6

[PATCH 3/4] radeonfb: fix setting of PPLL_REF_DIV for RV370 5B60

2007-09-04 Thread aherrman
As observed with various Radeon X300: console goes blank without fixing setting of PPLL_REF_DIV. Signed-off-by: Andreas Herrmann [EMAIL PROTECTED] --- drivers/video/aty/radeon_base.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/video/aty/radeon_base.c

[PATCH 4/4] radeonfb: use PCI device Id in hex for name string

2007-09-04 Thread aherrman
.. instead of potentially using nonprintable characters. I guess the former (odd) concatenation was used to construct name strings that match the *_ATI_RADEON_?? macros in include/linux/pci_ids.h The PCI Id in hex is much more convenient to use. E.g. it can easily be verified against lspci -nn

RE: [PATCH] x86: limit mwait_idle to Intel CPUs

2007-04-05 Thread aherrman
Peter Anvin wrote: > Andreas Herrmann wrote: > > > > It is not equivalent. Usually users check /proc/cpuinfo for their > > CPU features. Deleting that flag is kind of obfuscation. > > > > I guess some time ago people did not care about their "svm" or "vmx" > > flags. Nowadays (e.g. with kvm)

RE: [PATCH] x86: limit mwait_idle to Intel CPUs

2007-04-05 Thread aherrman
Peter Anvin wrote: Andreas Herrmann wrote: It is not equivalent. Usually users check /proc/cpuinfo for their CPU features. Deleting that flag is kind of obfuscation. I guess some time ago people did not care about their svm or vmx flags. Nowadays (e.g. with kvm) some people are