Re: [PATCH V3] Thermal: imx: add i.mx6sx thermal support

2014-08-06 Thread anson.hu...@freescale.com
Hi, Eduardo Thanks again for review, please see below in lines: Sent from my iPad 在 2014-8-6,21:24,"edubez...@gmail.com" 写道: > Hello Anson, > > On Wed, Aug 6, 2014 at 3:12 AM, Anson Huang wrote: >> i.MX6SX has some new features of thermal interrupt function, >> there are LOW, HIGH and

RE: [PATCH] ARM: imx: improve the comment of CCM lpm SW workaround

2013-12-24 Thread anson.hu...@freescale.com
Hi, Shawn Thanks for the detail review, I think it is better to have such info in comments if we already have such hardware errata created, I will sent out V2 soon. Best Regards. Anson huang 黄勇才   Freescale Semiconductor Shanghai 上海浦东新区亮景路192号A座2楼 201203 Tel:021-28937058 >-Original

Re: [PATCH] thermal: imx: correct suspend/resume flow

2013-12-23 Thread anson.hu...@freescale.com
Sent from Anson's iPhone > 在 2013年12月23日,22:28,"Shawn Guo" 写道: > >> On Mon, Dec 23, 2013 at 03:51:58PM -0500, Anson Huang wrote: >> Current imx thermal sensor's suspend function will return fail if >> thermal sensor is always enabled, but because alarm function is enabled, >> thermal sensor wi

Re: [PATCH] regulator: anatop: add is_enabled interface

2013-12-17 Thread anson.hu...@freescale.com
Sent from Anson's iPhone > 在 2013年12月17日,21:00,"Mark Brown" 写道: > > On Tue, Dec 17, 2013 at 12:38:33PM +, anson.hu...@freescale.com wrote: > >>> better to add the error checking there wouldn't it? > >> Okay, than what about other fu

Re: [PATCH] regulator: anatop: add is_enabled interface

2013-12-17 Thread anson.hu...@freescale.com
Sent from Anson's iPhone > 在 2013年12月17日,20:29,"Mark Brown" 写道: > > On Tue, Dec 17, 2013 at 02:38:56AM +, anson.hu...@freescale.com wrote: > > Please fix the line length you're using to word wrap, it should be less > than 80 columns to mak

RE: [PATCH] regulator: anatop: add is_enabled interface

2013-12-16 Thread anson.hu...@freescale.com
Hi, Mark Thanks for your quick reply, see below inline: Best Regards. Anson huang 黄勇才   Freescale Semiconductor Shanghai 上海浦东新区亮景路192号A座2楼 201203 Tel:021-28937058 >-Original Message- >From: Mark Brown [mailto:broo...@kernel.org] >Sent: Tuesday, December 17, 2013 2:58 AM >To: Huan