Re: [RFC PATCH] badblocks: Improvement badblocks_set() for handling multiple ranges

2020-12-22 Thread antlists
On 20/12/2020 09:46, Coly Li wrote: Currently blocks/badblocks.c is used by md raid and nvdimm code, and the badblocks table is irrelevant to any of these two subsystems. Good to know. If there will be better code for similar or better functionality, it should be cool. For me, if the reportin

Re: [RFC PATCH] badblocks: Improvement badblocks_set() for handling multiple ranges

2020-12-19 Thread antlists
On 03/12/2020 17:15, Coly Li wrote: This patch is an initial effort to improve badblocks_set() for setting bad blocks range when it covers multiple already set bad ranges in the bad blocks table, and to do it as fast as possible. Is this your patch, or submitted as part of the bug report? "Hea

Re: [PATCH 11/19] gdrom: use bdev_check_media_change

2020-09-02 Thread antlists
On 02/09/2020 15:12, Christoph Hellwig wrote: The GD-ROM driver does not have a ->revalidate_disk method, so it can ^^ (sic) Cheers, Wol

Re: [PATCH 09/16] initrd: remove the BLKFLSBUF call in handle_initrd

2020-07-03 Thread antlists
On 03/07/2020 04:40, H. Peter Anvin wrote: On 2020-06-15 05:53, Christoph Hellwig wrote: BLKFLSBUF used to be overloaded for the ramdisk driver to free the whole ramdisk, which was completely different behavior compared to all other drivers. But this magic overload got removed in commit ff26956

Re: [PATCH 0/4] eliminate SECTOR related magic numbers and duplicated conversions

2020-05-05 Thread antlists
On 05/05/2020 12:55, Zhen Lei wrote: When I studied the code of mm/swap, I found "1 << (PAGE_SHIFT - 9)" appears many times. So I try to clean up it. 1. Replace "1 << (PAGE_SHIFT - 9)" or similar with SECTORS_PER_PAGE 2. Replace "PAGE_SHIFT - 9" with SECTORS_PER_PAGE_SHIFT 3. Replace "9" with SE