Re: [PATCH] mm: memory_hotplug: use put_device() if device_register fail

On Friday 27 April 2018 08:26 PM, Michal Hocko wrote: On Thu 26-04-18 21:12:09, Arvind Yadav wrote: if device_register() returned an error. Always use put_device() to give up the initialized reference and release allocated memory. Is this patch correct? The docummentation says * NOTE:

Re: [PATCH] mm: memory_hotplug: use put_device() if device_register fail

On Friday 27 April 2018 08:26 PM, Michal Hocko wrote: On Thu 26-04-18 21:12:09, Arvind Yadav wrote: if device_register() returned an error. Always use put_device() to give up the initialized reference and release allocated memory. Is this patch correct? The docummentation says * NOTE:

Re: [greybus-dev] [PATCH] staging: greybus: Use gpio_is_valid()

On Friday 27 April 2018 06:32 PM, Alex Elder wrote: On 04/27/2018 07:50 AM, Arvind Yadav wrote: On Friday 27 April 2018 05:47 PM, Alex Elder wrote: On 04/27/2018 05:52 AM, Arvind Yadav wrote: Replace the manual validity checks for the GPIO with the gpio_is_valid(). I haven't looked

Re: [greybus-dev] [PATCH] staging: greybus: Use gpio_is_valid()

On Friday 27 April 2018 06:32 PM, Alex Elder wrote: On 04/27/2018 07:50 AM, Arvind Yadav wrote: On Friday 27 April 2018 05:47 PM, Alex Elder wrote: On 04/27/2018 05:52 AM, Arvind Yadav wrote: Replace the manual validity checks for the GPIO with the gpio_is_valid(). I haven't looked

Re: [PATCH] sparc: vio: use put_device() instead of kfree()

On Wednesday 25 April 2018 09:14 PM, Shannon Nelson wrote: On 4/25/2018 7:56 AM, Arvind Yadav wrote: Never directly free @dev after calling device_register(), even if it returned an error. Always use put_device() to give up the reference initialized. Signed-off-by: Arvind Yadav

Re: [PATCH] sparc: vio: use put_device() instead of kfree()

On Wednesday 25 April 2018 09:14 PM, Shannon Nelson wrote: On 4/25/2018 7:56 AM, Arvind Yadav wrote: Never directly free @dev after calling device_register(), even if it returned an error. Always use put_device() to give up the reference initialized. Signed-off-by: Arvind Yadav ---

Re: [PATCH] PM / devfreq: use put_device() instead of kfree()

On Friday 13 April 2018 07:59 AM, Chanwoo Choi wrote: On 2018년 04월 13일 11:15, arvindY wrote: Hi Chanwoo, On Friday 13 April 2018 06:43 AM, Chanwoo Choi wrote: On 2018년 04월 13일 10:03, Chanwoo Choi wrote: Hi, I'm sorry for the late reply. On 2018년 03월 30일 20:44, Arvind Yadav wrote: Never

Re: [PATCH] PM / devfreq: use put_device() instead of kfree()

On Friday 13 April 2018 07:59 AM, Chanwoo Choi wrote: On 2018년 04월 13일 11:15, arvindY wrote: Hi Chanwoo, On Friday 13 April 2018 06:43 AM, Chanwoo Choi wrote: On 2018년 04월 13일 10:03, Chanwoo Choi wrote: Hi, I'm sorry for the late reply. On 2018년 03월 30일 20:44, Arvind Yadav wrote: Never

Re: [PATCH] PM / devfreq: use put_device() instead of kfree()

Hi Chanwoo, On Friday 13 April 2018 06:43 AM, Chanwoo Choi wrote: On 2018년 04월 13일 10:03, Chanwoo Choi wrote: Hi, I'm sorry for the late reply. On 2018년 03월 30일 20:44, Arvind Yadav wrote: Never directly free @dev after calling device_register() or device_unregister(), even if

Re: [PATCH] PM / devfreq: use put_device() instead of kfree()

Hi Chanwoo, On Friday 13 April 2018 06:43 AM, Chanwoo Choi wrote: On 2018년 04월 13일 10:03, Chanwoo Choi wrote: Hi, I'm sorry for the late reply. On 2018년 03월 30일 20:44, Arvind Yadav wrote: Never directly free @dev after calling device_register() or device_unregister(), even if

Re: [PATCH v2] dec: tulip: de4x5: Replace mdelay with usleep_range in de4x5_hw_init

On Thursday 12 April 2018 07:00 AM, Jia-Ju Bai wrote: On 2018/4/12 0:16, James Bottomley wrote: On Wed, 2018-04-11 at 23:39 +0800, Jia-Ju Bai wrote: de4x5_hw_init() is never called in atomic context. de4x5_hw_init() is only called by de4x5_pci_probe(), which is only set as ".probe" in

Re: [PATCH v2] dec: tulip: de4x5: Replace mdelay with usleep_range in de4x5_hw_init

On Thursday 12 April 2018 07:00 AM, Jia-Ju Bai wrote: On 2018/4/12 0:16, James Bottomley wrote: On Wed, 2018-04-11 at 23:39 +0800, Jia-Ju Bai wrote: de4x5_hw_init() is never called in atomic context. de4x5_hw_init() is only called by de4x5_pci_probe(), which is only set as ".probe" in

Re: [PATCH] coresight: use put_device() instead of kfree()

On Tuesday 27 March 2018 09:37 PM, Mathieu Poirier wrote: On 26 March 2018 at 20:30, arvindY <arvind.yadav...@gmail.com> wrote: On Tuesday 27 March 2018 03:16 AM, Mathieu Poirier wrote: drivers/hwtracing/coresight/coresight.c On 18 March 2018 at 01:38, Arvind Yadav <arv

Re: [PATCH] coresight: use put_device() instead of kfree()

On Tuesday 27 March 2018 09:37 PM, Mathieu Poirier wrote: On 26 March 2018 at 20:30, arvindY wrote: On Tuesday 27 March 2018 03:16 AM, Mathieu Poirier wrote: drivers/hwtracing/coresight/coresight.c On 18 March 2018 at 01:38, Arvind Yadav wrote: Never directly free @dev after calling

Re: [PATCH] coresight: use put_device() instead of kfree()

On Tuesday 27 March 2018 03:16 AM, Mathieu Poirier wrote: drivers/hwtracing/coresight/coresight.c On 18 March 2018 at 01:38, Arvind Yadav wrote: Never directly free @dev after calling device_register(), even if it returned an error. Always use put_device() to give

Re: [PATCH] coresight: use put_device() instead of kfree()

On Tuesday 27 March 2018 03:16 AM, Mathieu Poirier wrote: drivers/hwtracing/coresight/coresight.c On 18 March 2018 at 01:38, Arvind Yadav wrote: Never directly free @dev after calling device_register(), even if it returned an error. Always use put_device() to give up the reference

Re: [PATCH 1/2] mtd: use put_device() if device_register fail

On Wednesday 14 March 2018 08:06 PM, Boris Brezillon wrote: On Fri, 9 Mar 2018 16:20:48 +0530 Arvind Yadav wrote: if device_register() returned an error! Always use put_device() to give up the reference initialized. Signed-off-by: Arvind Yadav

Re: [PATCH 1/2] mtd: use put_device() if device_register fail

On Wednesday 14 March 2018 08:06 PM, Boris Brezillon wrote: On Fri, 9 Mar 2018 16:20:48 +0530 Arvind Yadav wrote: if device_register() returned an error! Always use put_device() to give up the reference initialized. Signed-off-by: Arvind Yadav --- drivers/mtd/mtdcore.c | 1 + 1 file

Re: [PATCH] scsi: scsi_transport_iscsi: use put_device() instead of kfree()

On Thursday 15 March 2018 11:14 PM, Chris Leech wrote: On Wed, Mar 07, 2018 at 05:07:33PM +0530, Arvind Yadav wrote: Never directly free @dev after calling device_register(), even if it returned an error! Always use put_device() to give up the reference initialized. Signed-off-by: Arvind

Re: [PATCH] scsi: scsi_transport_iscsi: use put_device() instead of kfree()

On Thursday 15 March 2018 11:14 PM, Chris Leech wrote: On Wed, Mar 07, 2018 at 05:07:33PM +0530, Arvind Yadav wrote: Never directly free @dev after calling device_register(), even if it returned an error! Always use put_device() to give up the reference initialized. Signed-off-by: Arvind

Re: [PATCH 2/2 v2] mtd: ubi: use put_device() if device_register fail

On Thursday 15 March 2018 02:17 PM, Arvind Yadav wrote: On Thursday 15 March 2018 01:25 PM, Richard Weinberger wrote: Am Donnerstag, 15. März 2018, 08:20:31 CET schrieb Arvind Yadav: if device_register() returned an error! Always use put_device() to give up the reference initialized. Like

Re: [PATCH 2/2 v2] mtd: ubi: use put_device() if device_register fail

On Thursday 15 March 2018 02:17 PM, Arvind Yadav wrote: On Thursday 15 March 2018 01:25 PM, Richard Weinberger wrote: Am Donnerstag, 15. März 2018, 08:20:31 CET schrieb Arvind Yadav: if device_register() returned an error! Always use put_device() to give up the reference initialized. Like

Re: [PATCH] net: hns: use put_device() if device_register fail

On Monday 12 March 2018 10:59 PM, Richard Weinberger wrote: On Mon, Mar 12, 2018 at 5:27 PM, arvindY <arvind.yadav...@gmail.com> wrote: On Monday 12 March 2018 08:13 PM, David Miller wrote: From: Arvind Yadav <arvind.yadav...@gmail.com> Date: Fri, 9 Mar 2018 16

Re: [PATCH] net: hns: use put_device() if device_register fail

On Monday 12 March 2018 10:59 PM, Richard Weinberger wrote: On Mon, Mar 12, 2018 at 5:27 PM, arvindY wrote: On Monday 12 March 2018 08:13 PM, David Miller wrote: From: Arvind Yadav Date: Fri, 9 Mar 2018 16:11:17 +0530 if device_register() returned an error! Always use put_device

Re: [PATCH] net: hns: use put_device() if device_register fail

On Monday 12 March 2018 08:13 PM, David Miller wrote: From: Arvind Yadav Date: Fri, 9 Mar 2018 16:11:17 +0530 if device_register() returned an error! Always use put_device() to give up the reference initialized. Signed-off-by: Arvind Yadav

Re: [PATCH] net: hns: use put_device() if device_register fail

On Monday 12 March 2018 08:13 PM, David Miller wrote: From: Arvind Yadav Date: Fri, 9 Mar 2018 16:11:17 +0530 if device_register() returned an error! Always use put_device() to give up the reference initialized. Signed-off-by: Arvind Yadav I do not see anything giving cls_dev an initial

Re: [PATCH] ssb:: use put_device() if device_register fail

On Wednesday 07 March 2018 11:08 PM, Michael Büsch wrote: On Wed, 7 Mar 2018 22:46:14 +0530 arvindY <arvind.yadav...@gmail.com> wrote: diff --git a/drivers/ssb/main.c b/drivers/ssb/main.c index 65420a9..c4449e0 100644 --- a/drivers/ssb/main.c +++ b/drivers/ssb/main.c @@ -521,6

Re: [PATCH] ssb:: use put_device() if device_register fail

On Wednesday 07 March 2018 11:08 PM, Michael Büsch wrote: On Wed, 7 Mar 2018 22:46:14 +0530 arvindY wrote: diff --git a/drivers/ssb/main.c b/drivers/ssb/main.c index 65420a9..c4449e0 100644 --- a/drivers/ssb/main.c +++ b/drivers/ssb/main.c @@ -521,6 +521,7 @@ static int ssb_devices_register

Re: [PATCH] ssb:: use put_device() if device_register fail

On Wednesday 07 March 2018 10:17 PM, Michael Büsch wrote: On Wed, 7 Mar 2018 15:31:30 +0530 Arvind Yadav wrote: if device_register() returned an error! Always use put_device() to give up the reference initialized. Signed-off-by: Arvind Yadav

Re: [PATCH] ssb:: use put_device() if device_register fail

On Wednesday 07 March 2018 10:17 PM, Michael Büsch wrote: On Wed, 7 Mar 2018 15:31:30 +0530 Arvind Yadav wrote: if device_register() returned an error! Always use put_device() to give up the reference initialized. Signed-off-by: Arvind Yadav --- drivers/ssb/main.c | 1 + 1 file

Re: [PATCH 10/11 v3] ARM: s3c24xx/s3c64xx: constify gpio_led

Hi, On Wednesday 27 December 2017 01:49 PM, Krzysztof Kozlowski wrote: On Tue, Dec 26, 2017 at 7:50 PM, Arvind Yadav wrote: gpio_led are not supposed to change at runtime. struct gpio_led_platform_data working with const gpio_led provided by . So mark the non-const

Re: [PATCH 10/11 v3] ARM: s3c24xx/s3c64xx: constify gpio_led

Hi, On Wednesday 27 December 2017 01:49 PM, Krzysztof Kozlowski wrote: On Tue, Dec 26, 2017 at 7:50 PM, Arvind Yadav wrote: gpio_led are not supposed to change at runtime. struct gpio_led_platform_data working with const gpio_led provided by . So mark the non-const structs as const.

Re: [PATCH 10/11 v2] ARM: s3c24xx/s3c64xx: constify gpio_led

Hi, On Tuesday 26 December 2017 11:12 PM, Krzysztof Kozlowski wrote: On Tue, Dec 26, 2017 at 7:37 AM, Arvind Yadav wrote: Signed-off-by: Arvind Yadav Please write one-sentence long, easy to understand message describing the change. Best

Re: [PATCH 10/11 v2] ARM: s3c24xx/s3c64xx: constify gpio_led

Hi, On Tuesday 26 December 2017 11:12 PM, Krzysztof Kozlowski wrote: On Tue, Dec 26, 2017 at 7:37 AM, Arvind Yadav wrote: Signed-off-by: Arvind Yadav Please write one-sentence long, easy to understand message describing the change. Best regards, Krzysztof Thanks for review comment. I will

Re: [PATCH 00/11] constify gpio_led

Hi Ressell, On Saturday 23 December 2017 03:43 PM, Russell King - ARM Linux wrote: On Wed, Dec 20, 2017 at 02:17:41PM +0530, Arvind Yadav wrote: gpio_led are not supposed to change at runtime. struct gpio_led_platform_data working with const gpio_led provided by . So mark the non-const structs

Re: [PATCH 00/11] constify gpio_led

Hi Ressell, On Saturday 23 December 2017 03:43 PM, Russell King - ARM Linux wrote: On Wed, Dec 20, 2017 at 02:17:41PM +0530, Arvind Yadav wrote: gpio_led are not supposed to change at runtime. struct gpio_led_platform_data working with const gpio_led provided by . So mark the non-const structs

Re: [PATCH 11/11] ARM: pxa: constify gpio_led

Hi, Sorry for trouble, I will send updated patch. On Sunday 24 December 2017 11:24 PM, kbuild test robot wrote: Hi Arvind, Thank you for the patch! Yet something to improve: [auto build test ERROR on arm-soc/for-next] [also build test ERROR on v4.15-rc5 next-20171222] [if your patch is

Re: [PATCH 11/11] ARM: pxa: constify gpio_led

Hi, Sorry for trouble, I will send updated patch. On Sunday 24 December 2017 11:24 PM, kbuild test robot wrote: Hi Arvind, Thank you for the patch! Yet something to improve: [auto build test ERROR on arm-soc/for-next] [also build test ERROR on v4.15-rc5 next-20171222] [if your patch is

Re: [PATCH 4/7 v2] net: ethernet: i825xx: Fix platform_get_irq's error checking

Hi David, On Wednesday 06 December 2017 05:49 PM, Sergei Shtylyov wrote: On 12/05/2017 06:49 PM, David Miller wrote: From: Arvind Yadav Date: Mon, 4 Dec 2017 23:18:20 +0530 @@ -120,9 +120,10 @@ static int sni_82596_probe(struct platform_device *dev)

Re: [PATCH 4/7 v2] net: ethernet: i825xx: Fix platform_get_irq's error checking

Hi David, On Wednesday 06 December 2017 05:49 PM, Sergei Shtylyov wrote: On 12/05/2017 06:49 PM, David Miller wrote: From: Arvind Yadav Date: Mon, 4 Dec 2017 23:18:20 +0530 @@ -120,9 +120,10 @@ static int sni_82596_probe(struct platform_device *dev) netdevice->dev_addr[5] =

Re: [PATCH 03/10] net: ezchip: nps_enet: Fix platform_get_irq's error checking

On Monday 04 December 2017 10:12 PM, Russell King - ARM Linux wrote: On Mon, Dec 04, 2017 at 11:34:48AM -0500, David Miller wrote: From: Russell King - ARM Linux Date: Mon, 4 Dec 2017 16:24:47 + On Mon, Dec 04, 2017 at 11:20:49AM -0500, David Miller wrote: From:

Re: [PATCH 03/10] net: ezchip: nps_enet: Fix platform_get_irq's error checking

On Monday 04 December 2017 10:12 PM, Russell King - ARM Linux wrote: On Mon, Dec 04, 2017 at 11:34:48AM -0500, David Miller wrote: From: Russell King - ARM Linux Date: Mon, 4 Dec 2017 16:24:47 + On Mon, Dec 04, 2017 at 11:20:49AM -0500, David Miller wrote: From: Arvind Yadav Date:

Re: [PATCH 08/10] net: fjes: Handle return value of platform_get_irq and platform_get_resource

Hi Sergei, On Sunday 03 December 2017 01:36 AM, Sergei Shtylyov wrote: Hello! On 12/02/2017 10:26 PM, Arvind Yadav wrote: platform_get_irq() and platform_get_resource() can fail here and we must check its return value. Signed-off-by: Arvind Yadav ---

Re: [PATCH 08/10] net: fjes: Handle return value of platform_get_irq and platform_get_resource

Hi Sergei, On Sunday 03 December 2017 01:36 AM, Sergei Shtylyov wrote: Hello! On 12/02/2017 10:26 PM, Arvind Yadav wrote: platform_get_irq() and platform_get_resource() can fail here and we must check its return value. Signed-off-by: Arvind Yadav --- drivers/net/fjes/fjes_main.c | 10

Re: [PATCH 05/10] net: ethernet: i825xx: Fix platform_get_irq's error checking

Hi Sergei, On Sunday 03 December 2017 01:38 AM, Sergei Shtylyov wrote: Hello. On 12/02/2017 10:26 PM, Arvind Yadav wrote: The platform_get_irq() function returns negative if an error occurs. zero or positive number on success. platform_get_irq() error checking for zero is not correct.

Re: [PATCH 05/10] net: ethernet: i825xx: Fix platform_get_irq's error checking

Hi Sergei, On Sunday 03 December 2017 01:38 AM, Sergei Shtylyov wrote: Hello. On 12/02/2017 10:26 PM, Arvind Yadav wrote: The platform_get_irq() function returns negative if an error occurs. zero or positive number on success. platform_get_irq() error checking for zero is not correct.

Re: [PATCH] gpio: ftgpio010: Fix platform_get_irq's error checking

Hi Linus, On Saturday 02 December 2017 09:00 PM, Linus Walleij wrote: Hi Arvind, thanks for the patch! On Thu, Nov 30, 2017 at 3:12 PM, Arvind Yadav wrote: The platform_get_irq() function returns negative if an error occurs. zero or positive number on success.

Re: [PATCH] gpio: ftgpio010: Fix platform_get_irq's error checking

Hi Linus, On Saturday 02 December 2017 09:00 PM, Linus Walleij wrote: Hi Arvind, thanks for the patch! On Thu, Nov 30, 2017 at 3:12 PM, Arvind Yadav wrote: The platform_get_irq() function returns negative if an error occurs. zero or positive number on success. platform_get_irq() error

Re: [PATCH 2/3] staging: irda: Handle return value of platform_get_irq

Hi Greg, On Thursday 30 November 2017 10:11 PM, Greg KH wrote: On Thu, Nov 30, 2017 at 09:13:35PM +0530, Arvind Yadav wrote: platform_get_irq() can fail here and we must check its return value. Signed-off-by: Arvind Yadav ---

Re: [PATCH 2/3] staging: irda: Handle return value of platform_get_irq

Hi Greg, On Thursday 30 November 2017 10:11 PM, Greg KH wrote: On Thu, Nov 30, 2017 at 09:13:35PM +0530, Arvind Yadav wrote: platform_get_irq() can fail here and we must check its return value. Signed-off-by: Arvind Yadav --- drivers/staging/irda/drivers/pxaficp_ir.c | 10 ++ 1

Re: [PATCH 01/10 v5] Input: ep93xx_keypad: Fix platform_get_irq's error checking

Hi Dmitry, Sorry for troubling you. I need to push others also. Please share your review comment. Thanks, On Tuesday 21 November 2017 09:41 PM, Arvind Yadav wrote: The platform_get_irq() function returns negative if an error occurs. zero or positive number on success. platform_get_irq() error

Re: [PATCH 01/10 v5] Input: ep93xx_keypad: Fix platform_get_irq's error checking

Hi Dmitry, Sorry for troubling you. I need to push others also. Please share your review comment. Thanks, On Tuesday 21 November 2017 09:41 PM, Arvind Yadav wrote: The platform_get_irq() function returns negative if an error occurs. zero or positive number on success. platform_get_irq() error

Re: [PATCH] pata_pdc2027x: Fix coding sytle error

Hi Joe, On Saturday 25 November 2017 04:32 PM, Joe Perches wrote: On Sat, 2017-11-25 at 16:04 +0530, Arvind Yadav wrote: [] diff --git a/drivers/ata/pata_pdc2027x.c b/drivers/ata/pata_pdc2027x.c [] @@ -84,7 +84,7 @@ static int pdc2027x_set_mode(struct ata_link *link, struct ata_device

Re: [PATCH] pata_pdc2027x: Fix coding sytle error

Hi Joe, On Saturday 25 November 2017 04:32 PM, Joe Perches wrote: On Sat, 2017-11-25 at 16:04 +0530, Arvind Yadav wrote: [] diff --git a/drivers/ata/pata_pdc2027x.c b/drivers/ata/pata_pdc2027x.c [] @@ -84,7 +84,7 @@ static int pdc2027x_set_mode(struct ata_link *link, struct ata_device

Re: [PATCH] pata_pdc2027x: Remove unnecessary error check and coding style error.

Hi Sergei, On Saturday 25 November 2017 03:30 PM, Sergei Shtylyov wrote: On 11/25/2017 7:15 AM, Arvind Yadav wrote: Here, The function pdc_hardware_init always return zero. So it is not necessary to check its return value. Fix these checkpatch.pl error: ERROR: space prohibited after that

Re: [PATCH] pata_pdc2027x: Remove unnecessary error check and coding style error.

Hi Sergei, On Saturday 25 November 2017 03:30 PM, Sergei Shtylyov wrote: On 11/25/2017 7:15 AM, Arvind Yadav wrote: Here, The function pdc_hardware_init always return zero. So it is not necessary to check its return value. Fix these checkpatch.pl error: ERROR: space prohibited after that

Re: [PATCH 01/10 v3] Input: ep93xx_keypad: Fix platform_get_irq's error checking

Hi Dmitry, On Sunday 19 November 2017 12:00 AM, Dmitry Torokhov wrote: On Sat, Nov 18, 2017 at 04:25:08PM +0530, Arvind Yadav wrote: The platform_get_irq() function returns negative if an error occurs. zero or positive number on success. platform_get_irq() error checking for zero is not

Re: [PATCH 01/10 v3] Input: ep93xx_keypad: Fix platform_get_irq's error checking

Hi Dmitry, On Sunday 19 November 2017 12:00 AM, Dmitry Torokhov wrote: On Sat, Nov 18, 2017 at 04:25:08PM +0530, Arvind Yadav wrote: The platform_get_irq() function returns negative if an error occurs. zero or positive number on success. platform_get_irq() error checking for zero is not

Re: [alsa-devel] [PATCH 1/5 v4] ASoC: ep93xx-ac97: Fix platform_get_irq's error checking

Hi, On Monday 20 November 2017 07:07 PM, Alexandre Belloni wrote: On 19/11/2017 at 09:45:00 +0530, Arvind Yadav wrote: The platform_get_irq() function returns negative if an error occurs. zero or positive number on success. platform_get_irq() error checking for zero is not correct.

Re: [alsa-devel] [PATCH 1/5 v4] ASoC: ep93xx-ac97: Fix platform_get_irq's error checking

Hi, On Monday 20 November 2017 07:07 PM, Alexandre Belloni wrote: On 19/11/2017 at 09:45:00 +0530, Arvind Yadav wrote: The platform_get_irq() function returns negative if an error occurs. zero or positive number on success. platform_get_irq() error checking for zero is not correct.

Re: [PATCH] staging: comedi: ni_atmio: Handle return value of pnp_*

hi, On Thursday 16 November 2017 07:27 PM, Ian Abbott wrote: On 16/11/17 04:32, Arvind Yadav wrote: pnp_irq() and pnp_port_start() can fail here and we must check its return value. Signed-off-by: Arvind Yadav --- drivers/staging/comedi/drivers/ni_atmio.c | 3 +++

Re: [PATCH] staging: comedi: ni_atmio: Handle return value of pnp_*

hi, On Thursday 16 November 2017 07:27 PM, Ian Abbott wrote: On 16/11/17 04:32, Arvind Yadav wrote: pnp_irq() and pnp_port_start() can fail here and we must check its return value. Signed-off-by: Arvind Yadav --- drivers/staging/comedi/drivers/ni_atmio.c | 3 +++ 1 file changed, 3

Re: [PATCH] Input: davinci_keyscan: Free memory occupied by davinci key scan device

On Tuesday 14 November 2017 11:44 PM, Dmitry Torokhov wrote: On Tue, Nov 14, 2017 at 07:15:14PM +0530, Arvind Yadav wrote: Here, key_dev is NULL in input_free_device() and It will not free memory occupied by davinci key scan device. Move "key_dev = NULL" after input_free_device(). No, this

Re: [PATCH] Input: davinci_keyscan: Free memory occupied by davinci key scan device

On Tuesday 14 November 2017 11:44 PM, Dmitry Torokhov wrote: On Tue, Nov 14, 2017 at 07:15:14PM +0530, Arvind Yadav wrote: Here, key_dev is NULL in input_free_device() and It will not free memory occupied by davinci key scan device. Move "key_dev = NULL" after input_free_device(). No, this

Re: usb/media/imon: null-ptr-deref in imon_probe

Hi Andrey, I have added NULL check for usb_ifnum_to_if() and send a patch. Please re-test it. ~arvind On Monday 09 October 2017 11:20 PM, Andrey Konovalov wrote: Hi! I've got the following report while fuzzing the kernel with syzkaller. On commit 8a5776a5f49812d29fe4b2d0a2d71675c3facf3f

Re: usb/media/imon: null-ptr-deref in imon_probe

Hi Andrey, I have added NULL check for usb_ifnum_to_if() and send a patch. Please re-test it. ~arvind On Monday 09 October 2017 11:20 PM, Andrey Konovalov wrote: Hi! I've got the following report while fuzzing the kernel with syzkaller. On commit 8a5776a5f49812d29fe4b2d0a2d71675c3facf3f

Re: [PATCH] staging: comedi: dt282x: release irq on dt282x detach

Sorry for noise, ignore this patch. On Friday 06 October 2017 10:06 PM, Arvind Yadav wrote: free_irq() should be called on driver 'dt282x' detach. Signed-off-by: Arvind Yadav --- drivers/staging/comedi/drivers/dt282x.c | 5 + 1 file changed, 5 insertions(+)

Re: [PATCH] staging: comedi: dt282x: release irq on dt282x detach

Sorry for noise, ignore this patch. On Friday 06 October 2017 10:06 PM, Arvind Yadav wrote: free_irq() should be called on driver 'dt282x' detach. Signed-off-by: Arvind Yadav --- drivers/staging/comedi/drivers/dt282x.c | 5 + 1 file changed, 5 insertions(+) diff --git