Re: [Outreachy kernel] [PATCH v2] staging: media: atomisp: pci: Change line break to avoid an open parenthesis at the end of the line

Em qui, 2021-04-15 às 18:14 +0100, Matthew Wilcox escreveu: > On Thu, Apr 15, 2021 at 02:08:19PM -0300, Aline Santana Cordeiro > wrote: > > -const struct atomisp_format_bridge > > *get_atomisp_format_bridge_from_mbus( > > -    u32 mbus_code); > > +const struct atomisp_format_bridge* > >

Re: [PATCH v2] staging: media: atomisp: pci: Format comments according to coding-style in file atomisp_cmd.c

Em qui, 2021-04-15 às 08:48 +0300, Dan Carpenter escreveu: > On Wed, Apr 14, 2021 at 05:42:44PM -0300, Aline Santana Cordeiro > wrote: > > @@ -90,18 +92,14 @@ struct camera_mipi_info > > *atomisp_to_sensor_mipi_info(struct v4l2_subdev *sd) > > return (struct camera_mipi_info > >

Re: [PATCH] staging: media: atomisp: pci: Format multi-line comments according to coding-style in file atomisp_cmd.c

Em qua, 2021-04-14 às 21:33 +0300, Sakari Ailus escreveu: > Hi Aline, > > Thanks for the patch. > > On Wed, Apr 14, 2021 at 03:27:55PM -0300, Aline Santana Cordeiro > wrote: > > Format multi-line comments according to the coding-style. > > Issue detected by checkpatch.pl. > > > > Signed-off-by:

Re: [Outreachy kernel] Re: [PATCH 1/2] staging: media: atomisp: pci: Correct identation in block of conditional statements in file atomisp_v4l2.c

Em qua, 2021-04-14 às 17:45 +0300, Dan Carpenter escreveu: > On Wed, Apr 14, 2021 at 04:39:20PM +0200, Julia Lawall wrote: > > > > > > On Wed, 14 Apr 2021, Dan Carpenter wrote: > > > > > On Wed, Apr 14, 2021 at 11:06:02AM -0300, Aline Santana Cordeiro > > > wrote: > > > > Correct identation in

Re: [PATCH 1/2] staging: media: atomisp: pci: Correct identation in block of conditional statements in file atomisp_v4l2.c

Em qua, 2021-04-14 às 17:30 +0300, Dan Carpenter escreveu: > On Wed, Apr 14, 2021 at 11:06:02AM -0300, Aline Santana Cordeiro > wrote: > > Correct identation in block of conditional statements. > > The function "v4l2_device_unregister_subdev()" depends on > > the results of the macro function

Re: [PATCH] staging: media: omap4iss: Remove unused macro functions

Em ter, 2021-04-13 às 17:06 +0200, Hans Verkuil escreveu: > On 12/04/2021 15:42, Aline Santana Cordeiro wrote: > > Remove unused macro functions "to_iss_device()", "to_device()", > > and "v4l2_dev_to_iss_device(dev)". > > 'git grep to_iss_device drivers/staging/omap4iss' gives me lots of > hits!

Re: [Outreachy kernel][PATCH 1/2] staging: media: omap4iss: Align line break to the open parenthesis in file iss.c

Em ter, 2021-04-13 às 16:32 +0200, Hans Verkuil escreveu: > On 09/04/2021 21:01, Aline Santana Cordeiro wrote: > > Aligns line break with the remaining function arguments > > to the open parenthesis. Issue found by checkpatch. > > > > Signed-off-by: Aline Santana Cordeiro < > >

Re: [Outreachy kernel][PATCH 1/4 v2] staging: media: omap4iss: Replace macro function by static inline function in file iss.c

Em seg, 2021-04-12 às 19:36 +0200, Julia Lawall escreveu: > > > On Mon, 12 Apr 2021, ascordeiro wrote: > > > Em seg, 2021-04-12 às 18:11 +0300, Laurent Pinchart escreveu: > > > Hi Aline, > > > > > > On Mon, Apr 12, 2021 at 10:58:45AM -0300, ascordei

Re: [Outreachy kernel][PATCH 1/4 v2] staging: media: omap4iss: Replace macro function by static inline function in file iss.c

Em seg, 2021-04-12 às 18:11 +0300, Laurent Pinchart escreveu: > Hi Aline, > > On Mon, Apr 12, 2021 at 10:58:45AM -0300, ascordeiro wrote: > > Em seg, 2021-04-12 às 16:40 +0300, Laurent Pinchart escreveu: > > > While testing on a device isn't a requirement as you

Re: [Outreachy kernel][PATCH 1/4 v2] staging: media: omap4iss: Replace macro function by static inline function in file iss.c

Em seg, 2021-04-12 às 16:40 +0300, Laurent Pinchart escreveu: > While testing on a device isn't a requirement as you can't be > expected > to have the necessary hardware, changes are expected to be at least > compile-tested before being submitted. Hi Laurent, I thought recompiling the kernel

Re: [Outreachy kernel][PATCH] staging: media: hantro: Rewrite macro function in lower case

Em sex, 2021-04-09 às 14:42 -0300, Ezequiel Garcia escreveu: > On Fri, 2021-04-09 at 19:25 +0200, Julia Lawall wrote: > > > > > > On Fri, 9 Apr 2021, ascordeiro wrote: > > > > > Em sex, 2021-04-09 às 13:44 -0300, Ezequiel Garcia escreveu: > &

Re: [Outreachy kernel][PATCH] staging: media: hantro: Rewrite macro function in lower case

Em sex, 2021-04-09 às 19:25 +0200, Julia Lawall escreveu: > > > On Fri, 9 Apr 2021, ascordeiro wrote: > > > Em sex, 2021-04-09 às 13:44 -0300, Ezequiel Garcia escreveu: > > > Hi Aline, > > > > Hi Ezequiel, > > > > > > On Fri

Re: [Outreachy kernel][PATCH] staging: media: hantro: Rewrite macro function in lower case

Em sex, 2021-04-09 às 14:15 -0300, Ezequiel Garcia escreveu: > On Fri, 2021-04-09 at 14:00 -0300, ascordeiro wrote: > > Em sex, 2021-04-09 às 13:44 -0300, Ezequiel Garcia escreveu: > > > Hi Aline, > > > > Hi Ezequiel, > > > > > > On Fri, 2021-04

Re: [Outreachy kernel][PATCH 1/2 v3] staging: media: hantro: Align line break to the open parenthesis in file hantro_hw.h

Em sex, 2021-04-09 às 13:45 -0300, Ezequiel Garcia escreveu: > Hi Aline, Hi Ezequiel, > > On Fri, 2021-04-09 at 09:24 -0300, Aline Santana Cordeiro wrote: > > Aligns line break with the remaining function arguments > > to the open parenthesis. Issue found by checkpatch. > > > > Signed-off-by:

Re: [Outreachy kernel][PATCH] staging: media: hantro: Rewrite macro function in lower case

Em sex, 2021-04-09 às 13:44 -0300, Ezequiel Garcia escreveu: > Hi Aline, Hi Ezequiel, > > On Fri, 2021-04-09 at 10:54 -0300, Aline Santana Cordeiro wrote: > > Rewrite macros resembling functions #define HANTRO_PP_REG_WRITE > > and #define HANTRO_PP_RED_WRITE_S in lower case, according with > >

Re: [Outreachy kernel] Re: [PATCH 1/2 v2] staging: media: hantro: Align line break to the open parenthesis in file hantro_hw.h

Em sex, 2021-04-09 às 10:25 +0200, Vaishali Thakkar escreveu: > On Thu, Apr 8, 2021 at 7:41 PM ascordeiro > wrote: > > > > Em qui, 2021-04-08 às 13:20 -0300, Ezequiel Garcia escreveu: > > > Ola Aline, > > Ola Ezequiel, > > > > > Welc

Re: [PATCH 1/2 v2] staging: media: hantro: Align line break to the open parenthesis in file hantro_hw.h

Em qui, 2021-04-08 às 13:20 -0300, Ezequiel Garcia escreveu: > Ola Aline, Ola Ezequiel, > Welcome to the kernel community. Hope you enjoy some of this > Outreachy adventures. Thank you! > Normally, when you submit a v2, we want to know what changed > between the first submission and v2. > > If