[PATCH] vop: Add missing __iomem annotation in vop_dc_to_vdev()

2020-08-02 Thread Ashutosh Dixit
] __iomem *dc Cc: Michael S. Tsirkin Cc: Sudeep Dutt Cc: Arnd Bergmann Cc: Vincent Whitchurch Cc: stable Signed-off-by: Ashutosh Dixit --- drivers/misc/mic/vop/vop_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/mic/vop/vop_main.c b/drivers/misc/mic/vop

Re: [PATCH-next] misc: mic: Use PTR_ERR_OR_ZERO

2018-01-26 Thread Ashutosh Dixit
On Tue, Jan 23 2018 at 02:55:19 PM, Al Viro wrote: > On Tue, Jan 23, 2018 at 03:10:09PM -0500, Christopher Díaz Riveros wrote: >> Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR >> >> This issue was detected by using the Coccinelle software. > > ... and that's a wonderful demonstration

Re: hfi1 use of PCI internals

2016-06-17 Thread Ashutosh Dixit
On Thu, Jun 16 2016 at 04:08:17 PM, Bjorn Helgaas wrote: > > That's a good start, but leads to more questions. For example, it > doesn't answer the obvious question of why the driver needs to > enable/disable ASPM from interrupt context. For power saving reasons we keep ASPM L1 enabled, but impl

Re: hfi1 use of PCI internals

2016-06-16 Thread Ashutosh Dixit
On Thu, Jun 16 2016 at 12:20:52 PM, Bjorn Helgaas wrote: > I noticed drivers/infiniband/hw/hfi1 got moved from staging to > drivers/ for v4.7. It does a bunch of grubbing around in PCIe ASPM > configuration, e.g., see drivers/infiniband/hw/hfi1/aspm.h. > > I know there have been lots of ASPM issu

Re: [PATCH] mpssd: fix buffer overflow warning

2016-05-19 Thread Ashutosh Dixit
On Fri, May 20 2016 at 12:54:51 AM, Mike Danese wrote: > The compilation emits a warning in function ‘snprintf’, > inlined from ‘set_cmdline’ at > ../Documentation/mic/mpssd/mpssd.c:1541:9: > /usr/include/x86_64-linux-gnu/bits/stdio2.h:64:10: > warning: call to __builtin___snprintf_chk

[PATCH char-misc-linus] misc: mic: Fix for double fetch security bug in VOP driver

2016-04-27 Thread Ashutosh Dixit
=116651 Reported by: Pengfei Wang Reviewed-by: Sudeep Dutt Signed-off-by: Ashutosh Dixit --- drivers/misc/mic/vop/vop_vringh.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/misc/mic/vop/vop_vringh.c b/drivers/misc/mic/vop/vop_vringh.c index e94c7fb..88e4523 100644 --- a

Re: [PATCH] dma: Revert "dmaengine: mic_x100: add missing spin_unlock"

2016-01-04 Thread Ashutosh Dixit
On Sun, Jan 03 2016 at 10:35:26 PM, "Koul, Vinod" wrote: > On Tue, Dec 22, 2015 at 07:35:23PM -0800, Ashutosh Dixit wrote: >> This reverts commit e958e079e254 ("dmaengine: mic_x100: add missing >> spin_unlock"). >> >> The above patch is incorrect. T

Re: [PATCH] dma: Revert "dmaengine: mic_x100: add missing spin_unlock"

2015-12-22 Thread Ashutosh Dixit
On Wed, Dec 23 2015 at 12:45:31 AM, Saurabh Sengar wrote: > On 23 December 2015 at 09:05, Ashutosh Dixit wrote: >> This reverts commit e958e079e254 ("dmaengine: mic_x100: add missing >> spin_unlock"). >> >> The above patch is incorrect. There is nothing

[PATCH] dma: Revert "dmaengine: mic_x100: add missing spin_unlock"

2015-12-22 Thread Ashutosh Dixit
This reverts commit e958e079e254 ("dmaengine: mic_x100: add missing spin_unlock"). The above patch is incorrect. There is nothing wrong with the original code. The spin_lock is acquired in the "prep" functions and released in "submit". Signed-off-by: As

[PATCH RESEND] misc: mic: Fix crash when MIC reset is invoked in RESET_FAILED state

2015-12-15 Thread Ashutosh Dixit
in a new cosm_device member cdev->prev_state. Reviewed-by: Sudeep Dutt Signed-off-by: Ashutosh Dixit --- drivers/misc/mic/bus/cosm_bus.h | 2 ++ drivers/misc/mic/cosm/cosm_main.c | 13 + 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/drivers/misc/mic/bus/cosm

[PATCH] misc: mic: Fix crash when MIC reset is invoked in RESET_FAILED state

2015-11-17 Thread Ashutosh Dixit
in a new cosm_device member cdev->prev_state. Reviewed-by: Sudeep Dutt Signed-off-by: Ashutosh Dixit --- drivers/misc/mic/bus/cosm_bus.h | 2 ++ drivers/misc/mic/cosm/cosm_main.c | 13 + 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/drivers/misc/mic/bus/cosm

Re: [PATCH v2] misc: mic: replace kfree with put_device

2015-10-11 Thread Ashutosh Dixit
On Sun, Oct 04 2015 at 05:33:47 PM, Geliang Tang wrote: > Handle a failed device_register(), replace kfree() with put_device(), > which will call mbus_release_dev() or scif_release_dev(). Could you add the same change to cosm_bus.c too in the same path and resubmit the patch. Thanks. -- To unsubs

Re: [PATCH] misc: mic: use kstrdup() in cosm_sysfs

2015-10-10 Thread Ashutosh Dixit
On Sat, Oct 10 2015 at 12:14:30 PM, Joe Perches wrote: > On Sat, 2015-10-10 at 04:46 -0700, Geliang Tang wrote: >> Use kstrdup instead of kmalloc and strncpy. > >> diff --git a/drivers/misc/mic/cosm/cosm_sysfs.c >> b/drivers/misc/mic/cosm/cosm_sysfs.c > [] >> @@ -211,18 +211,14 @@ cmdline_store(s

[PATCH char-misc-next] misc: mic: Fix randconfig build error

2015-10-07 Thread Ashutosh Dixit
Fixes randconfig build error reported at http://www.spinics.net/lists/kernel/msg2092346.html Reported-by: Jim Davis Reviewed-by: Dasaratharaman Chandramouli Signed-off-by: Ashutosh Dixit --- drivers/misc/mic/cosm/cosm_debugfs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/misc

[PATCH char-misc-next v2 19/22] misc: mic: SCIF remote memory map/unmap interface

2015-09-29 Thread Ashutosh Dixit
mappings are zapped to avoid RMA accesses from user space, if a Coprocessor is reset. Reviewed-by: Ashutosh Dixit Reviewed-by: Nikhil Rao Signed-off-by: Sudeep Dutt --- drivers/misc/mic/scif/scif_mmap.c | 699 ++ 1 file changed, 699 insertions(+) create mode 100644

[PATCH char-misc-next v2 22/22] misc: mic: SCIF RMA nodeqp and minor miscellaneous changes

2015-09-29 Thread Ashutosh Dixit
and updating RMA specific debugfs hooks. Reviewed-by: Ashutosh Dixit Reviewed-by: Nikhil Rao Signed-off-by: Sudeep Dutt --- drivers/misc/mic/Kconfig | 1 + drivers/misc/mic/scif/Makefile| 5 + drivers/misc/mic/scif/scif_api.c | 33 +-- drivers/misc/mic/scif

[PATCH char-misc-next v2 18/22] misc: mic: SCIF RMA list operations

2015-09-29 Thread Ashutosh Dixit
operation is used by SCIF APIs which initiate DMAs, CPU copies or fences to ensure that a window remains valid during a transfer. Reviewed-by: Ashutosh Dixit Signed-off-by: Nikhil Rao Signed-off-by: Sudeep Dutt --- drivers/misc/mic/scif/scif_rma_list.c | 291

[PATCH char-misc-next v2 20/22] misc: mic: SCIF DMA and CPU copy interface

2015-09-29 Thread Ashutosh Dixit
that window are drained. Users can request synchronous DMA operations as well as tail byte ordering if required. CPU copies are always performed synchronously. Reviewed-by: Ashutosh Dixit Reviewed-by: Nikhil Rao Signed-off-by: Sudeep Dutt --- drivers/misc/mic/scif/scif_dma.c | 1979

[PATCH char-misc-next v2 21/22] misc: mic: SCIF fence

2015-09-29 Thread Ashutosh Dixit
local and the remote node for both the mark/wait or the fence signal APIs. Reviewed-by: Ashutosh Dixit Reviewed-by: Nikhil Rao Signed-off-by: Jacek Lawrynowicz Signed-off-by: Sudeep Dutt --- drivers/misc/mic/scif/scif_fence.c | 771 + 1 file changed,

[PATCH char-misc-next v2 13/22] misc: mic: Remove COSM functionality from the MIC card driver

2015-09-29 Thread Ashutosh Dixit
by COSM rather than maintain its own device index. Reviewed-by: Nikhil Rao Reviewed-by: Sudeep Dutt Signed-off-by: Ashutosh Dixit --- drivers/misc/mic/bus/mic_bus.c | 22 ++ drivers/misc/mic/card/mic_device.c | 88 ++ drivers/misc/mic/card

[PATCH char-misc-next v2 15/22] misc: mic: SCIF RMA header file and IOCTL changes

2015-09-29 Thread Ashutosh Dixit
CPU. The user space IOCTL interface has been updated to enable SCIF registration, RDMA/CPU copies and fence APIs for RDMA synchronization. Reviewed-by: Nikhil Rao Reviewed-by: Ashutosh Dixit Signed-off-by: Sudeep Dutt --- include/linux/scif.h| 234

[PATCH char-misc-next v2 17/22] misc: mic: SCIF memory registration and unregistration

2015-09-29 Thread Ashutosh Dixit
. The unregistration API tears down the registration at both self and remote nodes. Reviewed-by: Nikhil Rao Reviewed-by: Ashutosh Dixit Signed-off-by: Sudeep Dutt --- drivers/misc/mic/scif/scif_rma.c | 1770 ++ 1 file changed, 1770 insertions(+) create mode

[PATCH char-misc-next v2 14/22] misc: mic: Update MIC host daemon with COSM changes

2015-09-29 Thread Ashutosh Dixit
: Dasaratharaman Chandramouli Signed-off-by: Ashutosh Dixit --- Documentation/ABI/testing/sysfs-class-mic.txt | 29 ++- Documentation/mic/mic_overview.txt| 31 ++- Documentation/mic/mpssd/mpss | 4 +- Documentation/mic/mpssd/mpssd.c | 362

[PATCH char-misc-next v2 12/22] misc: mic: Remove COSM functionality from the MIC host driver

2015-09-29 Thread Ashutosh Dixit
via the cosm_hw_ops. Reviewed-by: Nikhil Rao Reviewed-by: Sudeep Dutt Signed-off-by: Dasaratharaman Chandramouli Signed-off-by: Ashutosh Dixit --- drivers/misc/mic/Makefile | 2 - drivers/misc/mic/host/Makefile | 1 - drivers/misc/mic/host/mic_boot.c| 317

[PATCH char-misc-next v2 16/22] misc: mic: SCIF RMA header file

2015-09-29 Thread Ashutosh Dixit
scif_window is a data structure which contains all the fields required to describe a SCIF registered window on self and remote nodes. It contains an offset which is used as a key to perform SCIF DMAs and CPU copies between self and remote registered windows. Reviewed-by: Nikhil Rao Reviewed-by: Ashutosh

[PATCH char-misc-next v2 11/22] misc: mic: COSM client driver

2015-09-29 Thread Ashutosh Dixit
me to that of the host. Because SCIF messaging cannot be used in a panic context, the COSM client driver also periodically sends a heartbeat SCIF message to the host thereby enabling the host to detect card crashes. Reviewed-by: Nikhil Rao Reviewed-by: Sudeep Dutt Signed-off-by: Ashutosh Dixit --

[PATCH char-misc-next v2 10/22] misc: mic: COSM SCIF server

2015-09-29 Thread Ashutosh Dixit
ard crashes (d) send host time to the card to enable the card to sync its time to the host. Reviewed-by: Nikhil Rao Reviewed-by: Sudeep Dutt Signed-off-by: Ashutosh Dixit --- drivers/misc/mic/cosm/cosm_scif_server.c | 405 +++ 1 file changed, 405 insertions(+) create

[PATCH char-misc-next v2 04/22] iommu: Allow iova to be used without requiring IOMMU_SUPPORT

2015-09-29 Thread Ashutosh Dixit
From: Sudeep Dutt iova is a library which can be built without IOMMU_SUPPORT Signed-off-by: Sudeep Dutt --- drivers/iommu/Kconfig | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig index d9da766..71d1c46 100644 --- a/drivers/

[PATCH char-misc-next v2 06/22] misc: mic: SCIF poll

2015-09-29 Thread Ashutosh Dixit
: Nikhil Rao Reviewed-by: Sudeep Dutt Signed-off-by: Ashutosh Dixit --- drivers/misc/mic/scif/scif_api.c | 158 +- drivers/misc/mic/scif/scif_epd.h | 22 ++ drivers/misc/mic/scif/scif_fd.c | 9 +++ drivers/misc/mic/scif/scif_main.h | 2 + include

[PATCH char-misc-next v2 09/22] misc: mic: Coprocessor State Management (COSM) driver

2015-09-29 Thread Ashutosh Dixit
in the MIC host driver has now largely been moved to user space and only a small required OSPM functionality is now present in the driver. Reviewed-by: Nikhil Rao Reviewed-by: Sudeep Dutt Signed-off-by: Dasaratharaman Chandramouli Signed-off-by: Ashutosh Dixit --- drivers/misc/mic/cos

[PATCH char-misc-next v2 08/22] misc: mic: MIC COSM bus

2015-09-29 Thread Ashutosh Dixit
driver being probed with the COSM devices. COSM bus ops, e.g. start, stop, ready, reset, therefore abstract out common functionality from its specific implementation for individual generations of MIC products. Reviewed-by: Nikhil Rao Reviewed-by: Sudeep Dutt Signed-off-by: Ashutosh Dixit

[PATCH char-misc-next v2 07/22] misc: mic: Add support for kernel mode SCIF clients

2015-09-29 Thread Ashutosh Dixit
SCIF clients are also included in this patch. Reviewed-by: Nikhil Rao Reviewed-by: Sudeep Dutt Signed-off-by: Ashutosh Dixit --- drivers/misc/mic/scif/scif_api.c | 43 + drivers/misc/mic/scif/scif_main.c | 88 -- drivers/misc/mic/scif/scif_main.h | 5

[PATCH char-misc-next v2 05/22] dma: Add support to program MIC x100 status descriptiors

2015-09-29 Thread Ashutosh Dixit
destination address with an 8 byte immediate data value. Reviewed-by: Nikhil Rao Reviewed-by: Ashutosh Dixit Signed-off-by: Lawrynowicz, Jacek Signed-off-by: Sudeep Dutt Signed-off-by: Siva Yerramreddy --- drivers/dma/mic_x100_dma.c | 39 ++- include/linux

[PATCH char-misc-next v2 03/22] iommu: Make the iova library a module

2015-09-29 Thread Ashutosh Dixit
From: Sakari Ailus The iova library has use outside the intel-iommu driver, thus make it a module. Signed-off-by: Sakari Ailus Signed-off-by: David Woodhouse --- drivers/iommu/Kconfig | 2 +- drivers/iommu/iova.c | 4 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers

[PATCH char-misc-next v2 02/22] iommu: iova: Export symbols

2015-09-29 Thread Ashutosh Dixit
From: Sakari Ailus Use EXPORT_SYMBOL_GPL() to export the iova library symbols. The symbols include: init_iova_domain(); iova_cache_get(); iova_cache_put(); iova_cache_init(); alloc_iova(); find_iova(); __free_iova(); free_iova();

[PATCH char-misc-next v2 01/22] iommu: iova: Move iova cache management to the iova library

2015-09-29 Thread Ashutosh Dixit
From: Sakari Ailus This is necessary to separate intel-iommu from the iova library. Signed-off-by: Sakari Ailus Signed-off-by: David Woodhouse --- drivers/iommu/intel-iommu.c | 6 ++-- drivers/iommu/iova.c| 83 ++--- include/linux/iova.h

[PATCH char-misc-next v2 00/22] misc: mic: Enable COSM and remaining SCIF functionality

2015-09-29 Thread Ashutosh Dixit
ist operations 19) SCIF remote memory map/unmap interface 20) SCIF DMA and CPU copy interface 21) SCIF fence 22) SCIF RMA nodeqp and minor miscellaneous changes These patches have also been scanned by Fengguang Wu's 0-day infrastructure and no issues have been reported. Ashutosh Dixit (9)

Re: [PATCH char-misc-next 10/19] lib: convert iova.c into a library

2015-07-30 Thread Ashutosh Dixit
On Tue, Jul 28 2015 at 01:40:19 PM, Andrew Morton wrote: > On Mon, 27 Jul 2015 16:57:32 -0700 Ashutosh Dixit > wrote: > >> From: Harish Chegondi >> >> This patch converts iova.c into a library, moving it from >> drivers/iommu/ to lib/, and exports its

[PATCH char-misc-next 06/19] misc: mic: COSM client driver

2015-07-27 Thread Ashutosh Dixit
me to that of the host. Because SCIF messaging cannot be used in a panic context, the COSM client driver also periodically sends a heartbeat SCIF message to the host thereby enabling the host to detect card crashes. Reviewed-by: Nikhil Rao Reviewed-by: Sudeep Dutt Signed-off-by: Ashutosh Dixit --

[PATCH char-misc-next 08/19] misc: mic: Remove COSM functionality from the MIC card driver

2015-07-27 Thread Ashutosh Dixit
by COSM rather than maintain its own device index. Reviewed-by: Nikhil Rao Reviewed-by: Sudeep Dutt Signed-off-by: Ashutosh Dixit --- drivers/misc/mic/bus/mic_bus.c | 22 ++ drivers/misc/mic/card/mic_device.c | 88 ++ drivers/misc/mic/card

[PATCH char-misc-next 16/19] misc: mic: SCIF remote memory map/unmap interface

2015-07-27 Thread Ashutosh Dixit
mappings are zapped to avoid RMA accesses from user space, if a Coprocessor is reset. Reviewed-by: Ashutosh Dixit Reviewed-by: Nikhil Rao Signed-off-by: Sudeep Dutt --- drivers/misc/mic/scif/scif_mmap.c | 711 ++ 1 file changed, 711 insertions(+) create mode 100644

[PATCH char-misc-next 19/19] misc: mic: SCIF RMA nodeqp and minor miscellaneous changes

2015-07-27 Thread Ashutosh Dixit
and updating RMA specific debugfs hooks. Reviewed-by: Ashutosh Dixit Reviewed-by: Nikhil Rao Signed-off-by: Sudeep Dutt --- drivers/misc/mic/Kconfig | 1 + drivers/misc/mic/scif/Makefile| 5 ++ drivers/misc/mic/scif/scif_api.c | 21 + drivers/misc/mic/scif

[PATCH char-misc-next 17/19] misc: mic: SCIF DMA and CPU copy interface

2015-07-27 Thread Ashutosh Dixit
that window are drained. Users can request synchronous DMA operations as well as tail byte ordering if required. CPU copies are always performed synchronously. Reviewed-by: Ashutosh Dixit Reviewed-by: Nikhil Rao Signed-off-by: Sudeep Dutt --- drivers/misc/mic/scif/scif_dma.c | 1979

[PATCH char-misc-next 18/19] misc: mic: SCIF fence

2015-07-27 Thread Ashutosh Dixit
local and the remote node for both the mark/wait or the fence signal APIs. Reviewed-by: Ashutosh Dixit Reviewed-by: Nikhil Rao Signed-off-by: Sudeep Dutt --- drivers/misc/mic/scif/scif_fence.c | 773 + 1 file changed, 773 insertions(+) create mod

[PATCH char-misc-next 15/19] misc: mic: SCIF RMA list operations

2015-07-27 Thread Ashutosh Dixit
operation is used by SCIF APIs which initiate DMAs, CPU copies or fences to ensure that a window remains valid during a transfer. Reviewed-by: Ashutosh Dixit Signed-off-by: Nikhil Rao Signed-off-by: Sudeep Dutt --- drivers/misc/mic/scif/scif_rma_list.c | 291

[PATCH char-misc-next 14/19] misc: mic: SCIF memory registration and unregistration

2015-07-27 Thread Ashutosh Dixit
. The unregistration API tears down the registration at both self and remote nodes. Reviewed-by: Nikhil Rao Reviewed-by: Ashutosh Dixit Signed-off-by: Sudeep Dutt --- drivers/misc/mic/scif/scif_rma.c | 1761 ++ 1 file changed, 1761 insertions(+) create mode

[PATCH char-misc-next 13/19] misc: mic: SCIF RMA header file

2015-07-27 Thread Ashutosh Dixit
scif_window is a data structure which contains all the fields required to describe a SCIF registered window on self and remote nodes. It contains an offset which is used as a key to perform SCIF DMAs and CPU copies between self and remote registered windows. Reviewed-by: Nikhil Rao Reviewed-by: Ashutosh

[PATCH char-misc-next 11/19] dma: Add support to program MIC x100 status descriptiors

2015-07-27 Thread Ashutosh Dixit
DMA engine API. Reviewed-by: Nikhil Rao Reviewed-by: Ashutosh Dixit Reviewed-by: Sudeep Dutt Signed-off-by: Siva Yerramreddy --- drivers/dma/mic_x100_dma.c | 44 +++- 1 file changed, 43 insertions(+), 1 deletion(-) diff --git a/drivers/dma/mic_x100_dma.c

[PATCH char-misc-next 12/19] misc: mic: SCIF RMA header file and IOCTL changes

2015-07-27 Thread Ashutosh Dixit
CPU. The user space IOCTL interface has been updated to enable SCIF registration, RDMA/CPU copies and fence APIs for RDMA synchronization. Reviewed-by: Nikhil Rao Reviewed-by: Ashutosh Dixit Signed-off-by: Sudeep Dutt --- include/linux/scif.h| 232

[PATCH char-misc-next 10/19] lib: convert iova.c into a library

2015-07-27 Thread Ashutosh Dixit
From: Harish Chegondi This patch converts iova.c into a library, moving it from drivers/iommu/ to lib/, and exports its virtual address allocation and management functions so that other modules can reuse them. Cc: Joerg Roedel Reviewed-by: Anil S Keshavamurthy Reviewed-by: Sudeep Dutt Signed-

[PATCH char-misc-next 09/19] misc: mic: Update MIC host daemon with COSM changes

2015-07-27 Thread Ashutosh Dixit
: Dasaratharaman Chandramouli Signed-off-by: Ashutosh Dixit --- Documentation/ABI/testing/sysfs-class-mic.txt | 29 ++- Documentation/mic/mic_overview.txt| 31 ++- Documentation/mic/mpssd/mpss | 4 +- Documentation/mic/mpssd/mpssd.c | 362

[PATCH char-misc-next 07/19] misc: mic: Remove COSM functionality from the MIC host driver

2015-07-27 Thread Ashutosh Dixit
via the cosm_hw_ops. Reviewed-by: Nikhil Rao Reviewed-by: Sudeep Dutt Signed-off-by: Dasaratharaman Chandramouli Signed-off-by: Ashutosh Dixit --- drivers/misc/mic/Makefile | 2 - drivers/misc/mic/host/Makefile | 1 - drivers/misc/mic/host/mic_boot.c| 317

[PATCH char-misc-next 05/19] misc: mic: COSM SCIF server

2015-07-27 Thread Ashutosh Dixit
ard crashes (d) send host time to the card to enable the card to sync its time to the host. Reviewed-by: Nikhil Rao Reviewed-by: Sudeep Dutt Signed-off-by: Ashutosh Dixit --- drivers/misc/mic/cosm/cosm_scif_server.c | 405 +++ 1 file changed, 405 insertions(+) create

[PATCH char-misc-next 04/19] misc: mic: Coprocessor State Management (COSM) driver

2015-07-27 Thread Ashutosh Dixit
in the MIC host driver has now largely been moved to user space and only a small required OSPM functionality is now present in the driver. Reviewed-by: Nikhil Rao Reviewed-by: Sudeep Dutt Signed-off-by: Dasaratharaman Chandramouli Signed-off-by: Ashutosh Dixit --- drivers/misc/mic/cos

[PATCH char-misc-next 03/19] misc: mic: MIC COSM bus

2015-07-27 Thread Ashutosh Dixit
driver being probed with the COSM devices. COSM bus ops, e.g. start, stop, ready, reset, therefore abstract out common functionality from its specific implementation for individual generations of MIC products. Reviewed-by: Nikhil Rao Reviewed-by: Sudeep Dutt Signed-off-by: Ashutosh Dixit

[PATCH char-misc-next 02/19] misc: mic: Add support for kernel mode SCIF clients

2015-07-27 Thread Ashutosh Dixit
SCIF clients are also included in this patch. Reviewed-by: Nikhil Rao Reviewed-by: Sudeep Dutt Signed-off-by: Ashutosh Dixit --- drivers/misc/mic/scif/scif_api.c | 44 + drivers/misc/mic/scif/scif_main.c | 88 -- drivers/misc/mic/scif/scif_main.h | 5

[PATCH char-misc-next 01/19] misc: mic: SCIF poll

2015-07-27 Thread Ashutosh Dixit
: Nikhil Rao Reviewed-by: Sudeep Dutt Signed-off-by: Ashutosh Dixit --- drivers/misc/mic/scif/scif_api.c | 158 +- drivers/misc/mic/scif/scif_epd.h | 22 ++ drivers/misc/mic/scif/scif_fd.c | 9 +++ drivers/misc/mic/scif/scif_main.h | 2 + include

[PATCH char-misc-next 00/19] misc: mic: Enable COSM and remaining SCIF functionality

2015-07-27 Thread Ashutosh Dixit
IOVA patch (patch 10) is being sent to char-misc because of the dependency between that patch and SCIF patches 12 through 19. Ashutosh Dixit (9): misc: mic: SCIF poll misc: mic: Add support for kernel mode SCIF clients misc: mic: MIC COSM bus misc: mic: Coprocessor State Management (COSM) d

Re: Regression in v4.2-rc1: vmalloc_to_page with ioremap

2015-07-22 Thread Ashutosh Dixit
On Tue, Jul 21 2015 at 01:39:10 PM, Toshi Kani wrote: > > You can do the following instead. If you have the physical address already > (i.e. the address you passed to ioremap), you can skip slow_virt_to_phys(). > pfn_to_page() is a hack for the time being so that you can use the same > DMA mappi

Re: Regression in v4.2-rc1: vmalloc_to_page with ioremap

2015-07-21 Thread Ashutosh Dixit
On Mon, Jul 20 2015 at 12:21:18 PM, Toshi Kani wrote: >> > Can you send me outputs of the following files? If the driver >> > fails to load in v4.2-rc1, you can obtain the info in v4.1. >> > >> > /proc/mtrr >> > /proc/iomem >> > /proc/vmallocinfo >> > /sys/kernel/debug/kernel_page_tables

Re: Regression in v4.2-rc1: vmalloc_to_page with ioremap

2015-07-20 Thread Ashutosh Dixit
On Mon, Jul 20 2015 at 08:59:02 AM, Toshi Kani wrote: > Can you also try the 'nohugeiomap' kernel option to the 4.2-rc1 kernel > to see if the problem goes away? Yes the problem goes away with 'nohugeiomap'. > Yes, vmalloc_to_page() assumes 4KB mappings. But ioremap with huge > pages was enabl

Re: [PATCH linux-next] Documentation: Build mic/mpssd only for x86_64

2014-12-05 Thread Ashutosh Dixit
On Fri, Dec 05 2014 at 08:18:18 AM, Jonathan Corbet wrote: > On Thu, 4 Dec 2014 13:27:29 -0800 > Ashutosh Dixit wrote: > >> mic/mpssd along with MIC drivers are currently only usable on >> x86_64. So build mic/mpssd only for x86_64 to avoid build breaks on >> bi

Re: [PATCH linux-next] Documentation: Build mic/mpssd only for x86_64

2014-12-05 Thread Ashutosh Dixit
On Fri, Dec 05 2014 at 08:18:18 AM, Jonathan Corbet wrote: > On Thu, 4 Dec 2014 13:27:29 -0800 > Ashutosh Dixit wrote: > >> mic/mpssd along with MIC drivers are currently only usable on >> x86_64. So build mic/mpssd only for x86_64 to avoid build breaks on >> bi

Re: [PATCH linux-next] Documentation: Build mic/mpssd only for x86_64

2014-12-05 Thread Ashutosh Dixit
On Thu, Dec 04 2014 at 07:27:06 PM, Dan Streetman wrote: > On Thu, Dec 4, 2014 at 4:27 PM, Ashutosh Dixit > wrote: >> mic/mpssd along with MIC drivers are currently only usable on >> x86_64. So build mic/mpssd only for x86_64 to avoid build breaks on >> big-endian system

Re: [PATCH] Documentation/mic/mpssd: fix compile error on BE platforms

2014-12-04 Thread Ashutosh Dixit
On Thu, Dec 04 2014 at 08:01:15 AM, Dan Streetman wrote: > Change any use of htole* macro in static context to instead manually check > for endianness and use __bswap_constant_* macro instead. > > The current glibc definitions of the htole* macros don't allow their use > in a static context; on bi

[PATCH linux-next] Documentation: Build mic/mpssd only for x86_64

2014-12-04 Thread Ashutosh Dixit
mic/mpssd along with MIC drivers are currently only usable on x86_64. So build mic/mpssd only for x86_64 to avoid build breaks on big-endian systems. Reported-by: Daniel Borkmann Reported-by: Dan Streetman Suggested-by: Peter Foley Signed-off-by: Ashutosh Dixit --- Documentation/mic/mpssd

Re: [PATCH linux-next] Documentation: mic: mpssd: Disable mpssd builds for kernels < 3.13

2014-09-23 Thread ashutosh dixit
On Tue, Sep 23 2014 at 09:59:32 PM, Andrew Morton wrote: > On Tue, 23 Sep 2014 21:51:09 -0700 ashutosh dixit > wrote: > >> On Tue, Sep 23 2014 at 05:58:19 PM, Peter Foley wrote: >> > On Tue, Sep 23, 2014 at 8:51 PM, Andrew Morton >> > wrote: >> >>

Re: [PATCH linux-next] Documentation: mic: mpssd: Disable mpssd builds for kernels < 3.13

2014-09-23 Thread ashutosh dixit
On Tue, Sep 23 2014 at 05:58:19 PM, Peter Foley wrote: > On Tue, Sep 23, 2014 at 8:51 PM, Andrew Morton > wrote: >> Can't we just fix the Makefiles? Cook up a rule which makes >> headers_install (if needed) before building Documentation/? > > Currently, the ordering is enforced by > http://git.k

Re: [PATCH linux-next] Documentation: mic: mpssd: Disable mpssd builds for kernels < 3.13

2014-09-23 Thread ashutosh dixit
On Tue, Sep 23 2014 at 02:46:10 PM, Randy Dunlap wrote: > On 09/23/14 14:55, Ashutosh Dixit wrote: >> mpssd depends on headers available in kernels >= 3.13. Therefore >> disable the build for kernels < 3.13. For kernels < 3.13, to avoid the >> appearance of a bui

[PATCH linux-next] Documentation: mic: mpssd: Disable mpssd builds for kernels < 3.13

2014-09-23 Thread Ashutosh Dixit
ter Foley Reviewed-by: Sudeep Dutt Reviewed-by: Nikhil Rao Signed-off-by: Ashutosh Dixit --- Documentation/mic/mpssd/mpssd.c | 15 +++ Documentation/mic/mpssd/sysfs.c | 5 + 2 files changed, 20 insertions(+) diff --git a/Documentation/mic/mpssd/mpssd.c b/Documentation/mic/mpssd/mpss

Re: [PATCH char-misc-linus 4/5] misc: mic: Fix sparse warnings and other endianness issues.

2013-11-27 Thread Ashutosh Dixit
On Tue, Nov 26 2013 at 11:15:25 AM, Greg Kroah-Hartman wrote: > On Tue, Nov 26, 2013 at 10:14:21AM -0800, Ashutosh Dixit wrote: >> Endianness issues are now consistent as per the documentation in >> host/mic_virtio.h. Note that the host can be both BE or LE whereas the >&

[PATCH char-misc-linus v3 5/6] misc: mic: Fix endianness issues.

2013-11-27 Thread Ashutosh Dixit
: Sudeep Dutt Reviewed-by: Nikhil Rao Signed-off-by: Ashutosh Dixit --- Documentation/mic/mpssd/mpssd.c| 8 drivers/misc/mic/card/mic_virtio.c | 14 +++--- drivers/misc/mic/host/mic_boot.c | 2 +- drivers/misc/mic/host/mic_virtio.c | 14 +++--- drivers/misc/mic/host

[PATCH char-misc-linus v3 3/6] misc: mic: Bug fix for sysfs poll usage.

2013-11-27 Thread Ashutosh Dixit
resulted in the daemon spinning continuously rather than getting blocked in 'poll'. This bug was exposed by commit aea585ef8fa65163 introduced as part of sysfs changes in 3.13-rc1. A seek to 0 has been introduced to fix it. Reviewed-by: Sudeep Dutt Signed-off-by: Ashutosh Dixit --- Docume

[PATCH char-misc-linus v3 0/6] misc: mic: Fixes for 3.13-final

2013-11-27 Thread Ashutosh Dixit
https://lkml.org/lkml/2013/11/26/443 in patch 5. v1: Initial post @ https://lkml.org/lkml/2013/11/26/321 Ashutosh Dixit (4): misc: mic: Bug fix for sysfs poll usage. misc: mic: Fix user space namespace pollution from mic_common.h. misc: mic: Fix endianness issues. misc: mic: Suppress memory

[PATCH char-misc-linus v3 2/6] misc: mic: Minor bug fix in 'retry' loops.

2013-11-27 Thread Ashutosh Dixit
From: Sudeep Dutt The bug would result in incorrect 'retry' value being printed in debug statements as well as dead code in mic_find_vqs(...) in drivers/misc/mic/card/mic_virtio.c. Reported-by: Michael Opdenacker Reviewed-by: Ashutosh Dixit Signed-off-by: Sudeep Dutt --- driver

[PATCH char-misc-linus v3 6/6] misc: mic: Suppress memory space sparse warnings

2013-11-27 Thread Ashutosh Dixit
issue, this patch suppresses these warnings. Reported-by: Fengguang Wu Reviewed-by: Sudeep Dutt Signed-off-by: Nikhil Rao Signed-off-by: Ashutosh Dixit --- drivers/misc/mic/card/mic_virtio.c | 8 +--- drivers/misc/mic/host/mic_virtio.c | 8 2 files changed, 9 insertions(+), 7

[PATCH char-misc-linus v3 1/6] misc: mic: Change mic_notify(...) to return true.

2013-11-27 Thread Ashutosh Dixit
From: Sudeep Dutt virtqueue_{kick()/notify()} methods are required to return bool due to API changes introduced in commit 5b1bf7cb673a. Reported-by: Fengguang Wu Reported-by: Geert Uytterhoeven Reviewed-by: Ashutosh Dixit Signed-off-by: Sudeep Dutt --- drivers/misc/mic/card/mic_virtio.c

[PATCH char-misc-linus v3 4/6] misc: mic: Fix user space namespace pollution from mic_common.h.

2013-11-27 Thread Ashutosh Dixit
generic. ... When these structures are forced-aligned, they will in fact have padding automatically added by the compiler to an 8-byte boundary anyway, so mic_aligned_size() does nothing. ... Reported-by: H Peter Anvin Reviewed-by: Sudeep Dutt Signed-off-by: Nikhil Rao Signed-off-by: Ashuto

[PATCH char-misc-linus v2 5/5] misc: mic: Fix user space namespace pollution from mic_common.h.

2013-11-26 Thread Ashutosh Dixit
generic. ... When these structures are forced-aligned, they will in fact have padding automatically added by the compiler to an 8-byte boundary anyway, so mic_aligned_size() does nothing. ... Reported-by: H Peter Anvin Reviewed-by: Sudeep Dutt Signed-off-by: Nikhil Rao Signed-off-by: Ashuto

[PATCH char-misc-linus 5/5] misc: mic: Fix user space namespace pollution from mic_common.h.

2013-11-26 Thread Ashutosh Dixit
generic. ... When these structures are forced-aligned, they will in fact have padding automatically added by the compiler to an 8-byte boundary anyway, so mic_aligned_size() does nothing. ... Reported-by: H Peter Anvin Reviewed-by: Sudeep Dutt Signed-off-by: Nikhil Rao Signed-off-by: Ashuto

[PATCH char-misc-linus 4/5] misc: mic: Fix sparse warnings and other endianness issues.

2013-11-26 Thread Ashutosh Dixit
be revisited if we support other architectures which treat I/O memory differently from system memory. Reported-by: Fengguang Wu Reviewed-by: Sudeep Dutt Cc: Nikhil Rao Signed-off-by: Ashutosh Dixit --- Documentation/mic/mpssd/mpssd.c| 8 drivers/misc/mic/card/mic_virtio.c | 18

[PATCH char-misc-linus 3/5] misc: mic: Bug fix for sysfs poll usage.

2013-11-26 Thread Ashutosh Dixit
resulted in the daemon spinning continuously rather than getting blocked in 'poll'. This bug was exposed by commit aea585ef8fa65163 introduced as part of sysfs changes in 3.13-rc1. A seek to 0 has been introduced to fix it. Reviewed-by: Sudeep Dutt Signed-off-by: Ashutosh Dixit --- Docume

[PATCH char-misc-linus 0/5] misc: mic: Fixes for 3.13-rc2

2013-11-26 Thread Ashutosh Dixit
These patches fix various issues which were reported or found with the MIC driver. Ashutosh Dixit (3): misc: mic: Bug fix for sysfs poll usage. misc: mic: Fix sparse warnings and other endianness issues. misc: mic: Fix user space namespace pollution from mic_common.h. Sudeep Dutt (2

[PATCH char-misc-linus 2/5] misc: mic: Minor bug fix in 'retry' loops.

2013-11-26 Thread Ashutosh Dixit
From: Sudeep Dutt The bug would result in incorrect 'retry' value being printed in debug statements as well as dead code in mic_find_vqs(...) in drivers/misc/mic/card/mic_virtio.c. Reported-by: Michael Opdenacker Reviewed-by: Ashutosh Dixit Signed-off-by: Sudeep Dutt --- driver

[PATCH char-misc-linus 1/5] misc: mic: Change mic_notify(...) to return true.

2013-11-26 Thread Ashutosh Dixit
From: Sudeep Dutt virtqueue_{kick()/notify()} methods are required to return bool due to API changes introduced in commit 5b1bf7cb673a. Reported-by: Fengguang Wu Reported-by: Geert Uytterhoeven Reviewed-by: Ashutosh Dixit Signed-off-by: Sudeep Dutt --- drivers/misc/mic/card/mic_virtio.c

[PATCH char-misc-next] misc: mic: Fixes for randconfig build errors and warnings.

2013-10-29 Thread Ashutosh Dixit
This patch fixes the build errors and warnings reported at https://lkml.org/lkml/2013/10/29/421. Co-author: Dasaratharaman Chandramouli Reviewed-by: Sudeep Dutt Reported-by: Jim Davis Signed-off-by: Ashutosh Dixit --- drivers/misc/mic/host/mic_boot.c | 1 + drivers/misc/mic/host/mic_fops.c