Re: bus/mhi/core: Double lock in mhi_device_put() and dev_wake inc/dec

2020-09-18 Thread bbhatt
On 2020-09-17 16:16, Shuah Khan wrote: While looking at this file for an unrelated issue, I happen to notice there is a double locking on mhi_cntrl->pm_lock in the mhi_device_put() when it gets called from mhi_driver_remove() The other two calls from mhi_driver_probe() don't hold the pm_lock.

Re: [PATCH v1 1/3] bus: mhi: core: Remove warnings for missing MODULE_LICENSE()

2020-09-18 Thread bbhatt
On 2020-09-18 10:18, Manivannan Sadhasivam wrote: On Fri, Sep 18, 2020 at 09:49:05AM -0700, bbh...@codeaurora.org wrote: On 2020-09-18 07:27, Jeffrey Hugo wrote: > On 9/17/2020 4:19 PM, Bhaumik Bhatt wrote: > > When building MHI as a module, missing MODULE_LICENSE() warnings > > are seen. Avoid

Re: [PATCH v1 2/3] bus: mhi: core: Introduce debugfs entries for MHI

2020-09-18 Thread bbhatt
On 2020-09-17 16:36, Randy Dunlap wrote: On 9/17/20 3:19 PM, Bhaumik Bhatt wrote: diff --git a/drivers/bus/mhi/Kconfig b/drivers/bus/mhi/Kconfig index a8bd9bd..ae68347 100644 --- a/drivers/bus/mhi/Kconfig +++ b/drivers/bus/mhi/Kconfig @@ -12,3 +12,11 @@ config MHI_BUS communication

Re: [PATCH v1 1/3] bus: mhi: core: Remove warnings for missing MODULE_LICENSE()

2020-09-18 Thread bbhatt
On 2020-09-18 07:27, Jeffrey Hugo wrote: On 9/17/2020 4:19 PM, Bhaumik Bhatt wrote: When building MHI as a module, missing MODULE_LICENSE() warnings are seen. Avoid them by adding the license and description information for the files where the warnings are seen. Signed-off-by: Bhaumik Bhatt

Re: [PATCH v7 00/11] Introduce features and debugfs/sysfs entries for MHI

2020-08-11 Thread bbhatt
On 2020-08-10 23:26, Manivannan Sadhasivam wrote: Hi Bhaumik, On Mon, Aug 10, 2020 at 03:00:54PM -0700, Bhaumik Bhatt wrote: Save hardware information from BHI. Allow reading and modifying some MHI variables for debug, test, and informational purposes using debugfs. Read values for device

Re: [PATCH v6 11/11] bus: mhi: core: Introduce sysfs entries for MHI

2020-08-10 Thread bbhatt
On 2020-08-06 22:22, Manivannan Sadhasivam wrote: On Mon, Jul 27, 2020 at 07:02:20PM -0700, Bhaumik Bhatt wrote: Introduce sysfs entries to enable userspace clients the ability to read the serial number and the OEM PK Hash values obtained from BHI. OEMs need to read these device-specific

Re: [PATCH v5 10/10] bus: mhi: core: Introduce sysfs entries for MHI

2020-07-27 Thread bbhatt
On 2020-07-23 22:42, Manivannan Sadhasivam wrote: On Thu, Jul 23, 2020 at 03:36:42PM -0700, Bhaumik Bhatt wrote: Introduce sysfs entries to enable userspace clients the ability to read the serial number and the OEM PK Hash values obtained from BHI. OEMs need to read these device-specific

Re: [PATCH v4 7/9] bus: mhi: core: Introduce debugfs entries and counters for MHI

2020-07-09 Thread bbhatt
On 2020-07-04 08:41, Manivannan Sadhasivam wrote: On Mon, Jun 29, 2020 at 09:39:40AM -0700, Bhaumik Bhatt wrote: Introduce debugfs entries to show state, register, channel, and event ring information. Add MHI state counters to keep track of the state changes on the device. Also, allow the host

Re: [PATCH v4 3/9] bus: mhi: core: Use helper API to trigger a non-blocking host resume

2020-07-08 Thread bbhatt
On 2020-07-04 07:47, Manivannan Sadhasivam wrote: On Mon, Jun 29, 2020 at 09:39:36AM -0700, Bhaumik Bhatt wrote: Autonomous low power mode support requires the MHI host to resume from multiple places and post a wakeup source to exit system suspend. This needs to be done in a non-blocking

Re: [PATCH v3 0/7] Introduce features and debugfs/sysfs entries for MHI

2020-05-21 Thread bbhatt
On 2020-05-21 06:23, Manivannan Sadhasivam wrote: Hi, On Mon, May 18, 2020 at 01:03:54PM -0700, Bhaumik Bhatt wrote: Introduce independent bus and device voting mechanism for clients and save hardware information from BHI. Allow reading and modifying some MHI variables for debug, test, and

Re: [PATCH v3 2/7] bus: mhi: core: Introduce independent voting mechanism

2020-05-20 Thread bbhatt
On 2020-05-20 12:06, Jeffrey Hugo wrote: On 5/20/2020 12:43 PM, bbh...@codeaurora.org wrote: On 2020-05-20 09:54, Jeffrey Hugo wrote: On 5/18/2020 2:03 PM, Bhaumik Bhatt wrote: Allow independent votes from clients such that they can choose to vote for either the device or the bus or both.

Re: [PATCH v3 2/7] bus: mhi: core: Introduce independent voting mechanism

2020-05-20 Thread bbhatt
On 2020-05-20 09:54, Jeffrey Hugo wrote: On 5/18/2020 2:03 PM, Bhaumik Bhatt wrote: Allow independent votes from clients such that they can choose to vote for either the device or the bus or both. This helps in cases where the device supports autonomous low power mode wherein it can move to

Re: [PATCH] bus: mhi: core: Use current ee in intvec handler

2020-05-18 Thread bbhatt
On 2020-05-17 12:38, Jeffrey Hugo wrote: On 5/15/2020 8:58 PM, bbh...@codeaurora.org wrote: On 2020-05-14 19:17, Jeffrey Hugo wrote: The intvec handler stores the caches ee in a local variable for use in processing the intvec.  It should instead use the current ee which is read at the

Re: [PATCH] bus: mhi: core: Use current ee in intvec handler

2020-05-15 Thread bbhatt
On 2020-05-14 19:17, Jeffrey Hugo wrote: The intvec handler stores the caches ee in a local variable for use in processing the intvec. It should instead use the current ee which is read at the beginning of the intvec incase that the intvec is related to an ee change. Otherwise, the handler

Re: [PATCH v5 8/8] bus: mhi: core: Ensure non-zero session or sequence ID values are used

2020-05-05 Thread bbhatt
On 2020-05-05 08:57, Jeffrey Hugo wrote: On 5/4/2020 8:44 PM, Bhaumik Bhatt wrote: While writing any sequence or session identifiers, it is possible that the host could write a zero value, whereas only non-zero values should be supported writes to those registers. Ensure that the host does not

Re: [PATCH v4 8/8] bus: mhi: core: Ensure non-zero session or sequence ID values are used

2020-05-04 Thread bbhatt
On 2020-05-04 07:33, Jeffrey Hugo wrote: On 5/1/2020 8:32 PM, Bhaumik Bhatt wrote: While writing any sequence or session identifiers, it is possible that the host could write a zero value, whereas only non-zero values should be supported writes to those registers. Ensure that the host does not

Re: [PATCH v3 6/9] bus: mhi: core: WARN_ON for malformed vector table

2020-05-01 Thread bbhatt
On 2020-04-30 08:02, Jeffrey Hugo wrote: On 4/29/2020 2:52 PM, Bhaumik Bhatt wrote: Add a bounds check in the firmware copy routine to exit if a malformed vector table is found while attempting to load the firmware in to the BHIe vector table. Signed-off-by: Bhaumik Bhatt ---

Re: [PATCH v3 9/9] bus: mhi: core: Ensure non-zero session or sequence ID values

2020-05-01 Thread bbhatt
On 2020-04-30 08:12, Jeffrey Hugo wrote: On 4/29/2020 2:52 PM, Bhaumik Bhatt wrote: While writing any sequence or session identifiers, it is possible that the host could write a zero value, whereas only non-zero values are supported writes to those registers. Ensure that host does not write a