Re: [RFC v2 1/2] PCI-Express Non-Transparent Bridge Support

2012-07-31 Thread chetan loke
ecific(if any) ntb_structs/variables/logic with the 'intc'(Intel ticker or pick your string) keyword. Chetan Loke -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.ke

Re: [RFC v2 1/2] PCI-Express Non-Transparent Bridge Support

2012-07-31 Thread chetan loke
+ ntb_list_add_tail(&qp->ntb_tx_free_q_lock, &entry->entry, > + &qp->tx_free_q); > +} I know you talked about a fixed array. But it's not here yet. So at all the call-sites, for [r/t]x_free_q , add the 'entry' t

Re: [RFC v2 1/2] PCI-Express Non-Transparent Bridge Support

2012-07-31 Thread chetan loke
review this design? Just thinking if this could sit in staging for some time(so that others get a chance to review/suggest changes as well) and then get promoted out of staging. Chetan Loke -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a messag

Re: [PATCH 1/1] block/nbd: micro-optimization in nbd request completion

2012-07-30 Thread chetan loke
On Wed, Jun 6, 2012 at 1:20 PM, Paul Clements wrote: > Makes sense. Looks good to me. > > Acked-by: paul.cleme...@steeleye.com > > On Wed, Jun 6, 2012 at 10:15 AM, Chetan Loke wrote: >> >> Add in-flight cmds to the tail. That way while searching(during request >&g

Re: [RFC 1/2] PCI-Express Non-Transparent Bridge Support

2012-07-16 Thread chetan loke
On Mon, Jul 16, 2012 at 2:38 PM, Jon Mason wrote: > On Mon, Jul 16, 2012 at 12:49:39PM -0400, chetan loke wrote: >> Is it ok to rename the following vars for convenience sake? >> >> > + struct list_head txq; >> tx_pend_q - (pending_queue) or tx_ou

Re: [RFC 1/2] PCI-Express Non-Transparent Bridge Support

2012-07-16 Thread chetan loke
gt;txc_lock, &entry->entry, &qp->txc); > + > + if (qp->tx_handler) > + qp->tx_handler(qp); > + > + return 0; > + } > + > + ntb_tx_copy_task(qp, entry, offset); > + > + qp->tx_offset = > +

Re: [RFC 1/2] PCI-Express Non-Transparent Bridge Support

2012-07-16 Thread chetan loke
header); > + > + qp->tx_pkts++; > + > + return 0; > +} > + > +void *ntb_transport_tx_dequeue(struct ntb_transport_qp *qp, unsigned int > *len) > +{ > + struct ntb_queue_entry *entry; > + void *buf; > + > + if (!q