tions(-)
Reviewed-by: Chris Lew
| 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
Reviewed-by: Chris Lew
of the various messages.
Signed-off-by: Bjorn Andersson
---
drivers/rpmsg/qcom_glink_native.c | 22 +++---
1 file changed, 15 insertions(+), 7 deletions(-)
Reviewed-by: Chris Lew
introduced but I think
they're unavoidable. Some IMHO don´t make sense at all, I think they
would apply for most regular macros but initcall macros are just way
different.
Fixes: 061b1bd394ca ("Staging: add TAINT_CRAP for all drivers/staging code")
Signed-off-by: Ágatha Isabell
Hello,
Please disregard this one, there will be a v3 soon.
There were some oversights on my side regarding some review points, and
also the code itself.
On Thu, Jul 04, 2024 at 09:20:49PM GMT, Ágatha Isabelle Chris Moreira Guedes
wrote:
> diff --git a/init/main.c b/init/main.c
>
introduced but I think
they're unavoidable. Some IMHO don´t make sense at all, I think they
would apply for most regular macros but initcall macros are just way
different.
Signed-off-by: Ágatha Isabelle Chris Moreira Guedes
---
CHANGELOG
v2:
- Changed the way we hook into the initcal
On Tue, Jul 02, 2024 at 09:50:49AM GMT, Uwe Kleine-König wrote:
> Hello Ágatha,
>
> On Tue, Jul 02, 2024 at 02:44:31AM -0300, Ágatha Isabelle Chris Moreira
> Guedes wrote:
> > ACKNOWLEDGEMENTS
> > Thanks for Jookia, heat and ukleinek for the important comments &
&
through
initcalls and not through load_module().
This might prevent relevant information of being available on a bug
report (i.e. on a panic log) among other possible problems.
Signed-off-by: Ágatha Isabelle Chris Moreira Guedes
---
ACKNOWLEDGEMENTS
Thanks for Jookia, heat and ukleinek for the
@@ config QCOM_PIL_INFO
config QCOM_RPROC_COMMON
tristate
+ select AUXILIARY_BUS
config QCOM_Q6V5_COMMON
tristate
Reviewed-by: Chris Lew
_OCMEM
config QCOM_PD_MAPPER
tristate "Qualcomm Protection Domain Mapper"
select QCOM_QMI_HELPERS
+ select QCOM_PDR_MSG
+ select AUXILIARY_BUS
depends on NET && QRTR
default QCOM_RPROC_COMMON
help
Reviewed-by: Chris Lew
otection Domain Restart helpers")
Tested-by: Neil Armstrong # on SM8550-QRD
Tested-by: Steev Klimaszewski
Tested-by: Alexey Minnekhanov
Signed-off-by: Dmitry Baryshkov
Reviewed-by: Chris Lew
On 6/11/2024 5:33 AM, Sudeepgoud Patil wrote:
This commit introduces tracepoint support for smp2p,
enabling logging of communication between local and remote processors.
The tracepoints include information about the remote processor ID,
remote subsystem name, negotiation details, supported fea
On 6/11/2024 9:06 AM, Bjorn Andersson wrote:
On Tue, Jun 11, 2024 at 06:03:50PM +0530, Sudeepgoud Patil wrote:
Add smp2p irq devname which fetches remote name from respective
smp2p dtsi node, which makes the wakeup source distinguishable
in irq wakeup prints.
Signed-off-by: Sudeepgoud Patil
changed, 109 insertions(+)
Thanks for looking into whether this could be implemented as a
remoteproc subdevice.
Reviewed-by: Chris Lew
-
drivers/soc/qcom/Kconfig | 11 +
drivers/soc/qcom/Makefile | 1 +
drivers/soc/qcom/pdr_internal.h | 14 +
drivers/soc/qcom/qcom_pd_mapper.c | 676 ++
drivers/soc/qcom/qcom_pdr_msg.c | 34 ++
5 files changed, 736 insertions(+)
Reviewed-by: Chris Lew
goto out;
- for (i = domains_read; i < resp->domain_list_len; i++) {
+ for (i = 0; i < resp->domain_list_len; i++) {
entry = &resp->domain_list[i];
if (strnlen(entry->name, sizeof(entry->name)) == sizeof(entry->name))
Reviewed-by: Chris Lew
t is
locator_addr.
Wouldn't this delay other work like new/del server notifications if this
qmi service is delayed or non-responsive?
Thanks,
Chris
if (resp->resp.result != QMI_RESULT_SUCCESS_V01) {
pr_err("PDR: %s get domain list failed: 0x%x\n",
@@
may stall.
The glink protocol traffic not tied to a TX_DATA command, such as intent
requests, wouldn't wake the system even if the channel is configured to
be wake capable.
Thanks,
Chris
Thanks and regards,
Signed-off-by: Deepak Kumar Singh
---
drivers/rpmsg/qcom_glink_smem.c |
On 4/29/2024 12:55 AM, Sudeepgoud Patil wrote:
Introduce tracepoint support for smp2p providing useful logging
for communication between clients.
Let's add some more description as to why these tracepoint are useful.
Do they help us track latency? debugging information for us? for clients?
On 4/26/2024 6:36 PM, Dmitry Baryshkov wrote:
On Sat, 27 Apr 2024 at 04:03, Chris Lew wrote:
On 4/24/2024 2:28 AM, Dmitry Baryshkov wrote:
diff --git a/drivers/remoteproc/qcom_q6v5_adsp.c
b/drivers/remoteproc/qcom_q6v5_adsp.c
index 1d24c9b656a8..02d0c626b03b 100644
--- a/drivers
on. I'm not an expert on remoteproc organization but this
was just a thought.
Thanks!
Chris
+ ret = qcom_q6v5_prepare(&adsp->q6v5);
+ if (ret)
+ goto put_pdm;
+
ret = adsp_map_carveout(rproc);
if (ret) {
dev_err(adsp->dev, &qu
On 4/24/2024 2:28 AM, Dmitry Baryshkov wrote:
+static int qcom_pdm_start(void)
+{
+ const struct of_device_id *match;
+ const struct qcom_pdm_domain_data * const *domains;
+ struct device_node *root;
+ int ret, i;
+
+ root = of_find_node_by_path("/");
+ if
On 4/24/2024 2:28 AM, Dmitry Baryshkov wrote:
Add qmi_del_server(), a pair to qmi_add_server(), a way to remove
running server from the QMI socket. This is e.g. necessary for
pd-mapper, which needs to readd a server each time the DSP is started or
s/readd/read/
stopped.
Tested-by: Neil Ar
it as an
ordered_workqueue? Even in a fast pdr scenario I don't think we would
see a race condition between these two functions.
The other access these two functions do race against is in the
pdr_notifier_work. I think you would need to protect locator_addr in
pdr_get_domain_list since the qmi_send_request there uses
'pdr->locator_addr'.
Thanks!
Chris
wrote:
From: Chris Lew
Ignore the ENODEV failures returned by kernel_sendmsg(). These errors
indicate that either the local port has been closed or the remote has
gone down. Neither of these scenarios are fatal and will eventually be
handled through packets that are later queued on the control port
Tested by: Chris Yan
message is gone and I still
get console output.
Tested-by: Chris Packham
> arch/powerpc/kernel/legacy_serial.c | 33 +
> 1 file changed, 29 insertions(+), 4 deletions(-)
>
> diff --git a/arch/powerpc/kernel/legacy_serial.c
> b/arch/powerpc/kernel/leg
From: Chris Chiu
Realtek Hub (0bda:5487) in Dell Dock WD19 sometimes fails to work
after the system resumes from suspend with remote wakeup enabled
device connected:
[ 1947.640907] hub 5-2.3:1.0: hub_ext_port_status failed (err = -71)
[ 1947.641208] usb 5-2.3-port5: cannot disable (err = -71
On Tue, Apr 20, 2021 at 11:28 PM Alan Stern wrote:
>
> On Tue, Apr 20, 2021 at 03:14:56PM +0800, Chris Chiu wrote:
> > On Mon, Apr 19, 2021 at 10:19 PM Alan Stern
> > wrote:
> > >
> > > On Mon, Apr 19, 2021 at 01:11:38AM -0400, Chris Chiu wrote:
> > &g
erify the consistent of e820 memory map
by md5 digest")
Reviewed-by: Eric Biggers
Tested-by: Dexuan Cui
Reviewed-by: Dexuan Cui
Signed-off-by: Chris von Recklinghausen
---
v1 -> v2
bump up RESTORE_MAGIC
v2 -> v3
move embelishment from cover letter to commit comments (no code
erify the consistent of e820 memory map
by md5 digest")
Signed-off-by: Chris von Recklinghausen
---
v1 -> v2
bump up RESTORE_MAGIC
v2 -> v3
move embelishment from cover letter to commit comments (no code change)
v3 -> v4
add note to comments that md5 isn't used
On Mon, Apr 19, 2021 at 10:19 PM Alan Stern wrote:
>
> On Mon, Apr 19, 2021 at 01:11:38AM -0400, Chris Chiu wrote:
> > Sorry that I didn't make myself clear. I found that if I applied
> > RESET_RESUME
> > quirk on the problematic hub, the Set-Port-Feature(suspend)
0:45:00.0: JBOD sequence map support : Yes
[ 104.550585] megaraid_sas :45:00.0: PCI Lane Margining support: No
[ 104.550999] megaraid_sas :45:00.0: megasas_enable_intr_fusion
is called outbound_intr_mask:0x4000
Chris
On Fri, Apr 16, 2021 at 11:39 AM Alan Stern wrote:
>
> On Fri, Apr 16, 2021 at 09:24:30AM +0800, Chris Chiu wrote:
> > On Fri, Apr 16, 2021 at 2:46 AM Alan Stern
> > wrote:
> > >
> > > On Fri, Apr 16, 2021 at 12:13:43AM +0800, Chris Chiu wrote:
> > &g
Joe Perches writes:
On Fri, 2021-04-16 at 14:56 +0100, Chris Down wrote:
Any better suggestions? :-)
A gcc plugin that looks for functions marked __printf(fmt, pos)
so any const fmt is stored.
I fail to see any way in which that can solve the problem described, which is
mobility of the
ntry, with semantics that if it's some sentinel value, look at
the format itself for the format, otherwise if it's some other value, the level
field itself is the level.
This will work, but it's pretty ugly. Any better suggestions? :-)
Thanks,
Chris
erify the consistent of e820 memory map
by md5 digest")
Signed-off-by: Chris von Recklinghausen
---
v1 -> v2
bump up RESTORE_MAGIC
v2 -> v3
move embelishment from cover letter to commit comments (no code change)
v3 -> v4
add note to comments that md5 isn't used
On Fri, Apr 16, 2021 at 2:46 AM Alan Stern wrote:
>
> On Fri, Apr 16, 2021 at 12:13:43AM +0800, Chris Chiu wrote:
> > One thing worth mentioning here, I never hit the hub_ext_port_status -71
> > problem if I resume by waking up from the keyboard connected to the hub.
>
inadvertent deviations.
Fixes: 62a03defeabd ("PM / hibernate: Verify the consistent of e820 memory map
by md5 digest")
Signed-off-by: Chris von Recklinghausen
---
v1 -> v2
bump up RESTORE_MAGIC
v2 -> v3
move embelishment from cover letter to commit comments (no code
On Thu, Apr 15, 2021 at 8:32 PM Greg KH wrote:
>
> On Thu, Apr 15, 2021 at 07:48:56PM +0800, chris.c...@canonical.com wrote:
> > From: Chris Chiu
> >
> > Realtek Hub (0bda:5487) in Dell Dock WD19 sometimes fails to work
> > after the system resumes from susp
From: Chris Chiu
Realtek Hub (0bda:5487) in Dell Dock WD19 sometimes fails to work
after the system resumes from suspend with remote wakeup enabled
device connected:
[ 1947.640907] hub 5-2.3:1.0: hub_ext_port_status failed (err = -71)
[ 1947.641208] usb 5-2.3-port5: cannot disable (err = -71
From: Andy Shevchenko
devm_platform_ioremap_resource() prints a message in case of error.
Drop custom one.
Signed-off-by: Andy Shevchenko
Reviewed-by: Chris Packham
Signed-off-by: Chris Packham
---
drivers/i2c/busses/i2c-mpc.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff
From: Andy Shevchenko
The peripheral clock is optional and we may get an -EPROBE_DEFER error code
which would not be propagated correctly, fix this by using
devm_clk_get_optional().
Signed-off-by: Andy Shevchenko
Reviewed-by: Chris Packham
Signed-off-by: Chris Packham
---
drivers/i2c/busses
From: Andy Shevchenko
Use the device_get_match_data() helper instead of open coding.
Signed-off-by: Andy Shevchenko
Reviewed-by: Chris Packham
Signed-off-by: Chris Packham
---
drivers/i2c/busses/i2c-mpc.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a
timeout if we take too long between bytes in a transfer.
Signed-off-by: Chris Packham
---
Notes:
Changes in v4:
- Split license/copyright change to separate patch
- Remove MPC_I2C_ACTION_INVALID
- make action_str const
- Remove __func__ from dev_dbg output
- Use Tx ACK/Rx ACK
From: Andy Shevchenko
Use __maybe_unused for the suspend()/resume() hooks and get rid of
the CONFIG_PM_SLEEP ifdeffery to improve the code.
Signed-off-by: Andy Shevchenko
Reviewed-by: Chris Packham
Signed-off-by: Chris Packham
---
Notes:
Changes in v4:
- Fix compile error due to
Use SPDX-License-Identifier and add copyright for Allied Telesis
because of the reasonably large rewrite in the preceding patch.
Signed-off-by: Chris Packham
---
Notes:
Changes in v4:
- New, split out from "i2c: mpc: Interrupt driven transfer"
drivers/i2c/busses/i2c-
i2c: mpc: Use device_get_match_data() helper
i2c: mpc: Drop duplicate message from devm_platform_ioremap_resource()
Chris Packham (2):
i2c: mpc: Interrupt driven transfer
i2c: mpc: Update license and copyright
drivers/i2c/busses/i2c-mpc.c | 492 +++
1 file ch
On 15/04/21 12:14 am, Andy Shevchenko wrote:
> On Tue, Apr 13, 2021 at 11:43:25PM +0000, Chris Packham wrote:
>> On 14/04/21 2:37 am, Andy Shevchenko wrote:
>>> Use __maybe_unused for the suspend()/resume() hooks and get rid of
>>> the CONFIG_PM_SLEEP ifdeffery to impr
On Wed, Apr 14, 2021 at 10:32 PM Alan Stern wrote:
>
> On Wed, Apr 14, 2021 at 01:07:43PM +0800, Chris Chiu wrote:
> > Thanks for the instructions. I can hit the same timeout problem with
> > runtime PM. The
> > fail rate seems the same as normal PM. (around 1/4 ~ 1/7
On Tue, Apr 13, 2021 at 10:44 PM Alan Stern wrote:
>
> On Tue, Apr 13, 2021 at 03:52:14PM +0800, Chris Chiu wrote:
> > On Mon, Apr 12, 2021 at 11:12 PM Alan Stern
> > wrote:
> > >
> > > On Mon, Apr 12, 2021 at 11:00:06PM +0800, chris.c...@canonical.com wrot
That line was using tab + 4 spaces on the left and was reformatted to
use 2 tabs.
If you don't like it I've uploaded patch v5 not touching that line.
On Tue, Apr 13, 2021 at 5:34 AM Bastien Nocera wrote:
>
> On Tue, 2021-04-13 at 01:02 +, Chris Ye wrote:
> > Add
Add "Select" button input capability and input event mapping for
Microsoft Xbox One controller. From product site this is also referred as
"Share" button.
Fixed Microsoft Xbox One controller select button not working under USB
connection.
Signed-off-by: Chris Ye
---
dr
On 14/04/21 2:37 am, Andy Shevchenko wrote:
> devm_platform_ioremap_resource() prints a message in case of error.
> Drop custom one.
>
> Signed-off-by: Andy Shevchenko
Reviewed-by: Chris Packham
> ---
> drivers/i2c/busses/i2c-mpc.c | 4 +---
> 1 file changed, 1 inse
On 14/04/21 2:37 am, Andy Shevchenko wrote:
> Use the device_get_match_data() helper instead of open coding.
>
> Signed-off-by: Andy Shevchenko
Reviewed-by: Chris Packham
> ---
> drivers/i2c/busses/i2c-mpc.c | 12
> 1 file changed, 4 insertions(+), 8 deletions
On 14/04/21 2:37 am, Andy Shevchenko wrote:
> Use __maybe_unused for the suspend()/resume() hooks and get rid of
> the CONFIG_PM_SLEEP ifdeffery to improve the code.
>
> Signed-off-by: Andy Shevchenko
> ---
> drivers/i2c/busses/i2c-mpc.c | 12 ++--
> 1 file changed, 2 insertions(+), 10
On 14/04/21 2:37 am, Andy Shevchenko wrote:
> The peripheral clock is optional and we may get an -EPROBE_DEFER error code
> which would not be propagated correctly, fix this by using
> devm_clk_get_optional().
>
> Signed-off-by: Andy Shevchenko
Reviewed-by: Chris Packham
None o
On 14/04/21 10:28 am, Chris Packham wrote:
>
> On 14/04/21 1:52 am, Andy Shevchenko wrote:
>> On Tue, Apr 13, 2021 at 8:10 AM Chris Packham
>> wrote:
>>> The fsl-i2c controller will generate an interrupt after every byte
>>> transferred. Make use of this inte
On 14/04/21 1:52 am, Andy Shevchenko wrote:
> On Tue, Apr 13, 2021 at 8:10 AM Chris Packham
> wrote:
>> The fsl-i2c controller will generate an interrupt after every byte
>> transferred. Make use of this interrupt to drive a state machine which
>> allows the next part of
inadvertent deviations.
Signed-off-by: Chris von Recklinghausen
---
v1 -> v2
bump up RESTORE_MAGIC
v2 -> v3
move embelishment from cover letter to commit comments (no code change)
v3 -> v4
add note to comments that md5 isn't used for encryption here.
v4 -> v5
reword c
From: Chris Chiu
Realtek Hub (0bda:5487) in Dell Dock WD19 sometimes fails to work
after the system resumes from suspend with remote wakeup enabled
device connected:
[ 1947.640907] hub 5-2.3:1.0: hub_ext_port_status failed (err = -71)
[ 1947.641208] usb 5-2.3-port5: cannot disable (err = -71
On Mon, Apr 12, 2021 at 11:12 PM Alan Stern wrote:
>
> On Mon, Apr 12, 2021 at 11:00:06PM +0800, chris.c...@canonical.com wrote:
> > From: Chris Chiu
> >
> > Realtek Hub (0bda:5413) in Dell Dock WD19 sometimes fails to work
> > after the system resumes from susp
On 13/04/21 5:09 pm, Chris Packham wrote:
> Add Chris Packham as FREESCALE MPC I2C maintainer.
>
> Signed-off-by: Chris Packham
Sorry for the duplicate. I had existing output from an earlier
invocation of git format-patch lying around. "[PATCH v3 4/4]
MAINTAINERS: ..." is th
Add Chris Packham as FREESCALE MPC I2C maintainer.
Signed-off-by: Chris Packham
---
MAINTAINERS | 7 +++
1 file changed, 7 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 56e9e4d777d8..3bc77ba8cd05 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -7135,6 +7135,13 @@ S
Use device managed functions an clean up error handling.
Signed-off-by: Chris Packham
Signed-off-by: Wolfram Sang
---
Notes:
Changes in v3:
- Assuming 09aab7add7bf is reverted I've folded in the fix from Wei
Yongjun[1] into the original patch. If Wei's patch is appl
redundant so remove the check.
Reported-by: Wolfram Sang
Signed-off-by: Chris Packham
---
drivers/i2c/busses/i2c-mpc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-mpc.c b/drivers/i2c/busses/i2c-mpc.c
index 9818f9f6a553..c30687483147 100644
--- a/drivers
verted.
I've tested on T2081 and P2041 based systems with a number of i2c and smbus
devices. Also this time I included a few iterations of module insert/remove
which would have caught the earlier errors.
Chris Packham (4):
i2c: mpc: use device managed APIs
i2c: mpc: Interrupt driven tr
timeout if we take too long between bytes in a transfer.
Signed-off-by: Chris Packham
---
Notes:
Changes in v3:
- use WARN/WARN_ON instead of BUG/BUG_ON
Changes in v2:
- add static_assert for state debug strings
- remove superfluous space
drivers/i2c/busses/i2c-mpc.c | 434
Add Chris Packham as FREESCALE MPC I2C maintainer.
Signed-off-by: Chris Packham
---
MAINTAINERS | 7 +++
1 file changed, 7 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 56e9e4d777d8..3bc77ba8cd05 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -7135,6 +7135,13 @@ S
Add "Select" button input capability and input event mapping for
Microsoft Xbox One controller. From product site this is also referred as
"Share" button.
Fixed Microsoft Xbox One controller select button not working under USB
connection.
Signed-off-by: Chris Ye
---
dr
On 13/04/21 11:21 am, Chris Packham wrote:
>
> On 13/04/21 10:52 am, Andy Shevchenko wrote:
>> On Mon, Mar 29, 2021 at 4:54 AM Chris Packham
>> wrote:
>>> Use device managed functions an clean up error handling.
>> For the god sake how have you tested this?
>&
On 13/04/21 10:52 am, Andy Shevchenko wrote:
> On Mon, Mar 29, 2021 at 4:54 AM Chris Packham
> wrote:
>> Use device managed functions an clean up error handling.
> For the god sake how have you tested this?
> The patch is broken.
I've clearly missed the remove path in my
On 4/12/21 3:27 PM, Ard Biesheuvel wrote:
On Mon, 12 Apr 2021 at 21:20, Eric Biggers wrote:
On Mon, Apr 12, 2021 at 03:04:58PM -0400, Chris von Recklinghausen wrote:
On 4/12/21 1:45 PM, Eric Biggers wrote:
On Mon, Apr 12, 2021 at 10:09:32AM -0400, Chris von Recklinghausen wrote:
Suspend
On 4/12/21 3:20 PM, Eric Biggers wrote:
On Mon, Apr 12, 2021 at 03:04:58PM -0400, Chris von Recklinghausen wrote:
On 4/12/21 1:45 PM, Eric Biggers wrote:
On Mon, Apr 12, 2021 at 10:09:32AM -0400, Chris von Recklinghausen wrote:
Suspend fails on a system in fips mode because md5 is used for
On 4/12/21 1:45 PM, Eric Biggers wrote:
On Mon, Apr 12, 2021 at 10:09:32AM -0400, Chris von Recklinghausen wrote:
Suspend fails on a system in fips mode because md5 is used for the e820
integrity check and is not available. Use crc32 instead.
This patch changes the integrity check algorithm
From: Chris Chiu
Realtek Hub (0bda:5413) in Dell Dock WD19 sometimes fails to work
after the system resumes from suspend with remote wakeup enabled
device connected:
[ 1947.640907] hub 5-2.3:1.0: hub_ext_port_status failed (err = -71)
[ 1947.641208] usb 5-2.3-port5: cannot disable (err = -71
grity check.
Fixes: 62a03defeabd ("PM / hibernate: Verify the consistent of e820 memory map
by md5 digest")
Signed-off-by: Chris von Recklinghausen
---
v1 -> v2
bump up RESTORE_MAGIC
v2 -> v3
move embelishment from cover letter to commit comments (no code change)
v3
On 11/04/21 8:16 am, Wolfram Sang wrote:
> On Mon, Mar 29, 2021 at 02:52:04PM +1300, Chris Packham wrote:
>> All the in-tree dts files that use one of the compatible strings from
>> i2c-mpc.c provide an interrupt property. By making this mandatory we
>> can simplify the code
On 11/04/21 8:13 am, Wolfram Sang wrote:
> On Mon, Mar 29, 2021 at 02:52:06PM +1300, Chris Packham wrote:
>> The fsl-i2c controller will generate an interrupt after every byte
>> transferred. Make use of this interrupt to drive a state machine which
>> allows the next
Quickly pair
with, play on, and switch between devices "
Should we override the product button name and name it "Select" in
driver? I am ok with either way but can we have a name everyone can
agree on and move forward?
Thanks!
Chris
On Tue, Mar 23, 2021 at 2:52 PM Chris Ye wrote:
On 4/9/21 12:56 PM, David Laight wrote:
From: Chris von Recklinghausen
Sent: 08 April 2021 11:46
Suspend fails on a system in fips mode because md5 is used for the e820
integrity check and is not available. Use crc32 instead.
Prior to this patch, MD5 is used only to create a digest to ensure
was a
more straight-forward correction inside the spinlock section. I
didn't carry it forward into the lockless page counters for
simplicity, but it turns out this is quite useful in practice. ]
Signed-off-by: Johannes Weiner
Acked-by: Chris Down
---
mm/page_counter.c | 8 ++--
1 file ch
On 4/8/21 11:30 AM, Eric Biggers wrote:
On Thu, Apr 08, 2021 at 09:15:06AM -0400, Chris von Recklinghausen wrote:
Suspend fails on a system in fips mode because md5 is used for the e820
integrity check and is not available. Use crc32 instead.
This patch changes the integrity check algorithm
Dexuan Cui
Reviewed-by: Dexuan Cui
Signed-off-by: Chris von Recklinghausen
---
v1 -> v2
bump up RESTORE_MAGIC
v2 -> v3
move embelishment from cover letter to commit comments (no code change)
v3 -> v4
add note to comments that md5 isn't used for encryption here.
v4 -> v5
Dexuan Cui
Reviewed-by: Dexuan Cui
Signed-off-by: Chris von Recklinghausen
---
v1 -> v2
bump up RESTORE_MAGIC
v2 -> v3
move embelishment from cover letter to commit comments (no code change)
v3 -> v4
add note to comments that md5 isn't used for encryption here.
arch/x8
use crc32 instead of md5 since crc32 is available in both FIPS and
non-FIPS modes.
Fixes: 62a03defeabd ("PM / hibernate: Verify the consistent of e820 memory map
by md5 digest")
Tested-by: Dexuan Cui
Reviewed-by: Dexuan Cui
Signed-off-by: Chris von Recklinghausen
---
v1 ->
which the ETIMEOUT is processed
back to the caller, the cpu spinning stops, and normal operations
continue
Fixes: 7de62bc09fe6 ("SUNRPC dont update timeout value on connection reset")
Signed-off-by: Chris Dion
---
Hello,
We recently have noticed an issue where we see a cpu spin
ity checking here AFAICS. It
might be made a fallback option if MD5 is not available, but making it
the default would be somewhat over the top IMO.
Would ghash be a better choice? It produces the same size digest as md5.
Does anyone have any other suggestions of algorithms to try?
Thanks,
. This patch set changes the integrity check to use crc32
instead of md5 since crc32 is available in both FIPS and non-FIPS modes.
Chris von Recklinghausen (1):
use crc32 instead of md5 for hibernation e820 integrity check
arch/x86/power/hibernate.c | 35 +++
1 file
Suspend fails on a system in fips mode because md5 is used for the e820
integrity check and is not available. Use crc32 instead.
Fixes: 62a03defeabd ("PM / hibernate: Verify the consistent of e820 memory map
by md5 digest")
Signed-off-by: Chris von Recklinghausen
---
arch
. This patch set changes the integrity check to use crc32
instead of md5 since crc32 is available in both FIPS and non-FIPS modes.
Chris von Recklinghausen (1):
use crc32 instead of md5 for hibernation image integrity check
arch/x86/power/hibernate.c | 31 +--
1 file
Suspend fails on a system in fips mode because md5 is used for the e820
integrity check and is not available. Use crc32 instead.
Fixes: 62a03defeabd ("PM / hibernate: Verify the consistent of e820 memory map
by md5 digest")
Signed-off-by: Chris von Recklinghausen
---
arch
My bad. I'll send a patch shortly
On 30/03/21 8:27 pm, Stephen Rothwell wrote:
> Hi all,
>
> After merging the hwmon-staging tree, today's linux-next build (htmldocs)
> produced this warning:
>
> Documentation/hwmon/bpa-rs600.rst: WARNING: document isn't included in any
> toctree
>
> Introduced b
On 3/30/21 10:46 AM, Rafael J. Wysocki wrote:
On Tue, Mar 30, 2021 at 12:14 AM Dexuan Cui wrote:
Hi,
MD5 was marked incompliant with FIPS in 2009:
a3bef3a31a19 ("crypto: testmgr - Skip algs not flagged fips_allowed in fips
mode")
a1915d51e8e7 ("crypto: testmgr - Mark algs allowed in fips mode"
uapi headers definition of
__UAPI_DEF_IN6_ADDR_ALT conflicts with the musl libc definition. It
looks like libc-compat.h tries to co-exists with GNU libc but this
isn't working for musl. I've identified an egregious hack that I think
should make things work (CFLAGS+=-D__USE_MISC) but I wanted to know if
there was a nicer way to make this work.
Regards,
Chris
timeout if we take too long between bytes in a transfer.
Signed-off-by: Chris Packham
---
Notes:
Changes in v2:
- add static_assert for state debug strings
- remove superfluous space
drivers/i2c/busses/i2c-mpc.c | 434 +++
1 file changed, 241 insertions
All the in-tree dts files that use one of the compatible strings from
i2c-mpc.c provide an interrupt property. By making this mandatory we
can simplify the code.
Signed-off-by: Chris Packham
---
drivers/i2c/busses/i2c-mpc.c | 51 ++--
1 file changed, 19
Use device managed functions an clean up error handling.
Signed-off-by: Chris Packham
---
drivers/i2c/busses/i2c-mpc.c | 46 ++--
1 file changed, 18 insertions(+), 28 deletions(-)
diff --git a/drivers/i2c/busses/i2c-mpc.c b/drivers/i2c/busses/i2c-mpc.c
index
Move the existing calls of mpc_i2c_fixup() to a recovery function
registered via bus_recovery_info. This makes it more obvious that
recovery is supported and allows for a future where recovery is
triggered by the i2c core.
Signed-off-by: Chris Packham
---
drivers/i2c/busses/i2c-mpc.c | 18
1 based systems with a number of i2c and smbus
devices.
Chris Packham (6):
dt-bindings: i2c-mpc: Document interrupt property as required
dt-bindings: i2c: convert i2c-mpc to json-schema
i2c: mpc: Make use of i2c_recover_bus()
i2c: mpc: make interrupt mandatory and remove polling code
1 - 100 of 5164 matches
Mail list logo