Re: [PATCH 08/11] irqchip/gic: Configure SGIs as standard interrupts

2021-04-20 Thread dann frazier
On Tue, Apr 20, 2021 at 02:37:10PM -0600, dann frazier wrote: > On Tue, May 19, 2020 at 05:17:52PM +0100, Marc Zyngier wrote: > > Change the way we deal with GIC SGIs by turning them into proper > > IRQs, and calling into the arch code to register the interrupt range > >

Re: [PATCH 08/11] irqchip/gic: Configure SGIs as standard interrupts

2021-04-20 Thread dann frazier
On Tue, May 19, 2020 at 05:17:52PM +0100, Marc Zyngier wrote: > Change the way we deal with GIC SGIs by turning them into proper > IRQs, and calling into the arch code to register the interrupt range > instead of a callback. > > Signed-off-by: Marc Zyngier hey Marc, I bisected a boot failure

Re: [PATCH] PCI: xgene: fix a mistake about cfg address

2021-03-28 Thread dann frazier
variable, So after this commit, the port->cfg_addr > will get a wrong address. Now, revert it. > > Fixes: e2dcd20b1645a ("PCI: controller: Convert to > devm_platform_ioremap_resource_byname()") > Reported-by: dann.fraz...@canonical.com > Signed-off-by: Dejin Zheng

Re: [PATCH v2] PCI: controller: convert to devm_platform_ioremap_resource_byname()

2021-03-27 Thread dann frazier
On Wed, Jun 03, 2020 at 01:16:01AM +0800, Dejin Zheng wrote: > Use devm_platform_ioremap_resource_byname() to simplify codes. > it contains platform_get_resource_byname() and devm_ioremap_resource(). > > Signed-off-by: Dejin Zheng > --- > v1 -> v2: > - Discard changes to the file drivers/pc

Re: [PATCH 4.4 17/70] crypto: arm64/sha - avoid non-standard inline asm tricks

2020-12-05 Thread dann frazier
On Mon, Nov 23, 2020 at 01:49:07PM -0700, dann frazier wrote: > On Mon, Nov 26, 2018 at 11:50:32AM +0100, Greg Kroah-Hartman wrote: > > 4.4-stable review patch. If anyone has any objections, please let me know. > > fyi, I bisected a regression down to this commit. This apparen

Re: [PATCH 4.4 17/70] crypto: arm64/sha - avoid non-standard inline asm tricks

2020-11-23 Thread dann frazier
On Mon, Nov 26, 2018 at 11:50:32AM +0100, Greg Kroah-Hartman wrote: > 4.4-stable review patch. If anyone has any objections, please let me know. fyi, I bisected a regression down to this commit. This apparently causes an ADR_PREL_PG_HI21 relocation to be added to the sha{1,2}_ce modules. Back in

5.9-rc7 oops in nvkm_udevice_info() w/ GA100

2020-10-02 Thread dann frazier
hey, I'm seeing an Oops when nouveau loads (see below). I've verified that this is because both device->chip and device->name are NULL prior to the strncpy()s at the end of nvkm_udevice_info(). Bisect shows that this started happening after: commit 24d5ff40a732633dceab68c6559ba723784f4a68 Author

Re: [for-next][PATCH 09/18] tracing: Move pipe reference to trace array instead of current_tracer

2020-07-31 Thread dann frazier
On Fri, Jul 31, 2020 at 3:16 PM Steven Rostedt wrote: > > On Fri, 31 Jul 2020 13:33:45 -0600 > dann frazier wrote: > > > > This is marked as "Fixes" but is more of a clean up than a true fix. > > > Backport if you want, but its not critical. > >

Re: [for-next][PATCH 09/18] tracing: Move pipe reference to trace array instead of current_tracer

2020-07-31 Thread dann frazier
On Thu, Jul 02, 2020 at 05:58:21PM -0400, Steven Rostedt wrote: > From: "Steven Rostedt (VMware)" > > If a process has the trace_pipe open on a trace_array, the current tracer > for that trace array should not be changed. This was original enforced by a > global lock, but when instances were intr

Re: [PATCH net-next] hinic: fix a bug in set rx mode

2019-06-10 Thread dann frazier
On Mon, May 27, 2019 at 10:10:05PM +, Xue Chaojing wrote: > in set_rx_mode, __dev_mc_sync and netdev_for_each_mc_addr will > repeatedly set the multicast mac address. so we delete this loop. fyi, I'm told this fixes the following Oops (in case it makes sense to queue it for stable): [ 642.914

Re: [PATCH] ixgbe: Avoid NULL pointer dereference with VF on non-IPsec hw

2019-06-06 Thread dann frazier
hey David, Jeff - is it possible to get this queued up as a fix for 5.2? -dann On Wed, May 22, 2019 at 05:22:58PM -0600, dann frazier wrote: > An ipsec structure will not be allocated if the hardware does not support > offload. Fixes the following Oops: > > [ 191.045452] Unab

[PATCH] ixgbe: Avoid NULL pointer dereference with VF on non-IPsec hw

2019-05-22 Thread dann frazier
[ 191.378077] cpu_startup_entry+0x2c/0x30 [ 191.381988] secondary_start_kernel+0x150/0x1e0 [ 191.386506] Code: 6b15003f 54000320 f1404a9f 5460 (79400260) Fixes: eda0333ac2930 ("ixgbe: add VF IPsec management") Signed-off-by: dann frazier --- drivers/net/ethernet/intel/ixgbe/ixgbe_i

Re: [PATCH] scsi: libsas: Fix rphy phy_identifier for PHYs with end devices attached

2019-02-15 Thread dann frazier
aaa1f-phy8-lun-0-part1 -> ../../sdf1 > lrwxrwxrwx 1 root root 10 Feb 13 11:53 > platform-HISI0162:01-sas-exp0x500e004aaa1f-phy8-lun-0-part2 -> ../../sdf2 > lrwxrwxrwx 1 root root 10 Feb 13 11:53 > platform-HISI0162:01-sas-exp0x500e004aaa1f-phy8-lun-0-part3 -> ../../sd

Re: [PATCH net-next] net: hns3: Config NIC port speed same as that of optical module

2019-01-03 Thread dann frazier
On Wed, Jan 02, 2019 at 08:45:36PM +0800, lipeng (Y) wrote: > > > On 2019/1/1 9:22, dann frazier wrote: > > On Mon, Nov 26, 2018 at 06:43:00PM +, Salil Mehta wrote: > > > From: Peng Li > > > > > > Port 0/1 of HiP08 supports 10G and 25G. This patch

Re: [PATCH net-next] net: hns3: Config NIC port speed same as that of optical module

2018-12-31 Thread dann frazier
On Mon, Nov 26, 2018 at 06:43:00PM +, Salil Mehta wrote: > From: Peng Li > > Port 0/1 of HiP08 supports 10G and 25G. This patch adds a > change to configure NIC port speed same as that of optical > module(SFP/QFSP). Driver gets the optical module speed and > sets NIC port speed accordingly.

Re: [Bisect] ext4_validate_inode_bitmap:98: comm stress-ng: Corrupt inode bitmap

2018-07-16 Thread dann frazier
On Sat, Jul 14, 2018 at 5:21 AM dann frazier wrote: > > On Thu, Jul 12, 2018 at 5:08 PM Theodore Y. Ts'o wrote: > > > > > > > > Review console log and on each run I have filesystem rebuild. The problem > > > is that mke2fs I am using is 1.44.3-rc2. I

Re: [Bisect] ext4_validate_inode_bitmap:98: comm stress-ng: Corrupt inode bitmap

2018-07-14 Thread dann frazier
several iterations w/ the block bitmap fix as well, and still no problems, so: Tested-by: dann frazier > commit 8d5a803c6a6ce4ec258e31f76059ea5153ba46ef > Author: Theodore Ts'o > Date: Thu Jul 12 19:08:05 2018 -0400 > > ext4: check for allocation block vali

Re: [Bisect] ext4_validate_inode_bitmap:98: comm stress-ng: Corrupt inode bitmap

2018-07-10 Thread dann frazier
On Tue, Jul 10, 2018 at 10:51:43AM -0600, dann frazier wrote: > On Sat, Jul 07, 2018 at 12:10:18AM -0400, Theodore Y. Ts'o wrote: > > On Fri, Jul 06, 2018 at 11:43:24AM -0600, dann frazier wrote: > > > Hi, > > > We're seeing a regression triggered by the stre

Re: [Bisect] ext4_validate_inode_bitmap:98: comm stress-ng: Corrupt inode bitmap

2018-07-10 Thread dann frazier
On Sat, Jul 07, 2018 at 12:10:18AM -0400, Theodore Y. Ts'o wrote: > On Fri, Jul 06, 2018 at 11:43:24AM -0600, dann frazier wrote: > > Hi, > > We're seeing a regression triggered by the stress-ng[*] "chdir" test > > that I've bisected to: > >

[Bisect] ext4_validate_inode_bitmap:98: comm stress-ng: Corrupt inode bitmap

2018-07-06 Thread dann frazier
Hi, We're seeing a regression triggered by the stress-ng[*] "chdir" test that I've bisected to: 044e6e3d74a3 ext4: don't update checksum of new initialized bitmaps So far we've only seen failures on servers based on HiSilicon's family of ARM64 SoCs (D05/Hi1616 SoC, D06/Hi1620 SoC). On these sys

[PATCH] net: hns: Avoid action name truncation

2018-04-18 Thread dann frazier
$ grep enahisic2i0-tx /proc/interrupts | sed 's/.* //' enahisic2i0-tx0 enahisic2i0-tx1 enahisic2i0-tx2 [...] enahisic2i0-tx8 enahisic2i0-tx9 enahisic2i0-tx10 enahisic2i0-tx11 enahisic2i0-tx12 enahisic2i0-tx13 enahisic2i0-tx14 enahisic2i0-tx15 Signed-off-by: dann frazi

Re: [PATCH 1/4] i2c: xlp9xx: return ENXIO on slave address NACK

2018-02-22 Thread dann frazier
On Tue, Jan 30, 2018 at 7:28 AM, George Cherian wrote: > Gentle Ping on this series. I've been using these on a few Cavium Sabre boards, which previously had an unusable system interface (/dev/ipmi) due to timeouts or just enumerations failures. So, fwiw: Tested-by: dann frazier -da

Re: [PATCH v14 0/9] LPC: legacy ISA I/O support

2018-02-21 Thread dann frazier
ivers/of/address.c | 96 ++- > drivers/pci/pci.c | 95 +-- > include/asm-generic/io.h | 4 +- > include/linux/logic_pio.h | 131 + > include/linux/pci.h| 3 +- > lib/Kconfig| 15 + > lib/Makefile | 2 + > lib/logic_pio.c| 285 + > 15 files changed, 1250 insertions(+), 98 deletions(-) > create mode 100644 > Documentation/devicetree/bindings/arm/hisilicon/hisilicon-low-pin-count.txt > create mode 100644 drivers/bus/hisi_lpc.c > create mode 100644 include/linux/logic_pio.h > create mode 100644 lib/logic_pio.c Tested this version on a D05 board, no problems. So, for the series: Tested-by: dann frazier

Re: [PATCH v13 4/9] PCI: Apply the new generic I/O management on PCI IO hosts

2018-02-14 Thread dann frazier
On Wed, Feb 14, 2018 at 8:42 AM, John Garry wrote: > On 13/02/2018 22:57, dann frazier wrote: >> >> On Wed, Feb 14, 2018 at 01:45:28AM +0800, John Garry wrote: >>> >>> From: Zhichang Yuan >>> >>> After introducing the new generic I/O space

Re: [PATCH v13 1/9] LIB: Introduce a generic PIO mapping method

2018-02-13 Thread dann frazier
On Wed, Feb 14, 2018 at 01:45:25AM +0800, John Garry wrote: > From: Zhichang Yuan > > In commit 41f8bba7f555 ("of/pci: Add pci_register_io_range() and > pci_pio_to_address()"), a new I/O space management was supported. With > that driver, the I/O ranges configured for PCI/PCIe hosts on some > arc

Re: [PATCH v13 4/9] PCI: Apply the new generic I/O management on PCI IO hosts

2018-02-13 Thread dann frazier
On Wed, Feb 14, 2018 at 01:45:28AM +0800, John Garry wrote: > From: Zhichang Yuan > > After introducing the new generic I/O space management in logic pio, the > original PCI MMIO relevant helpers need to be updated based on the new > interfaces. > This patch adapts the corresponding code to match

Re: [PATCH v12 6/9] LPC: Support the LPC host on Hip06/Hip07 with DT bindings

2018-02-13 Thread dann frazier
On Wed, Jan 24, 2018 at 12:36:22AM +0800, John Garry wrote: > From: Zhichang Yuan > > The low-pin-count(LPC) interface of Hip06/Hip07 accesses the peripherals in > I/O port addresses. This patch implements the LPC host controller driver > which perform the I/O operations on the underlying hardwar

Re: [PATCH v12 0/9] LPC: legacy ISA I/O support

2018-02-07 Thread dann frazier
> corresponding device-specific I/O hooks to perform the I/O accesses. > > Based on this patch-set, all the I/O accesses to Hip06/Hip07 LPC peripherals > can > be supported without any changes on the existing ipmi-si driver. > > The whole patchset has been tested on Hip07

Re: [PATCH v10 0/9] LPC: legacy ISA I/O support

2017-11-09 Thread dann frazier
MI SI worked fine. Tested-by: dann frazier

Re: [PATCH v10 6/9] LPC: Support the LPC host on Hip06/Hip07 with DT bindings

2017-11-08 Thread dann frazier
On Fri, Oct 27, 2017 at 05:11:24PM +0100, Gabriele Paoloni wrote: > From: "zhichang.yuan" > > The low-pin-count(LPC) interface of Hip06/Hip07 accesses the peripherals in > I/O port addresses. This patch implements the LPC host controller driver > which perform the I/O operations on the underlying

Re: [bug report] regression bisected to "block: Make most scsi_req_init() calls implicit"

2017-10-23 Thread dann frazier
On Mon, Oct 23, 2017 at 3:08 PM, Bart Van Assche wrote: > On Mon, 2017-10-23 at 09:41 -0600, dann frazier wrote: >> (gdb) list *(sg_io+0x120) >> 0x084e71a8 is in sg_io (./include/linux/uaccess.h:113). >> 108 static inline unsigned long >> 109 _copy_fro

Re: [bug report] regression bisected to "block: Make most scsi_req_init() calls implicit"

2017-10-23 Thread dann frazier
On Fri, Oct 20, 2017 at 11:30:55PM +, Bart Van Assche wrote: > On Fri, 2017-10-20 at 16:54 -0600, dann frazier wrote: > > hey, > > I'm seeing a regression when executing 'dmraid -r -c' in an arm64 > > QEMU guest, which I've bisected to the following

[bug report] regression bisected to "block: Make most scsi_req_init() calls implicit"

2017-10-20 Thread dann frazier
hey, I'm seeing a regression when executing 'dmraid -r -c' in an arm64 QEMU guest, which I've bisected to the following commit: ca18d6f7 "block: Make most scsi_req_init() calls implicit" I haven't yet had time to try and debug it yet, but wanted to get the report out there before the weekend.

Re: [PATCH V8 5/6] ACPI: Support the probing on the devices which apply indirect-IO

2017-04-20 Thread dann frazier
On Thu, Mar 30, 2017 at 9:26 AM, zhichang.yuan wrote: > On some platforms(such as Hip06/Hip07), the legacy ISA/LPC devices access I/O > with some special host-local I/O ports known on x86. To access the I/O > peripherals, an indirect-IO mechanism is introduced to mapped the host-local > I/O to sys

Re: [PATCH V8 0/7] LPC: legacy ISA I/O support

2017-03-30 Thread dann frazier
> lib/Makefile | 2 + > lib/logic_pio.c | 413 > 22 files changed, 1758 insertions(+), 102 deletions(-) > create mode 100644 > Documentation/devicetree/bindings/arm/hisilicon/hisilicon-low-pin-count.txt > create mode 100644 drivers/acpi/acpi_indirectio.c > create mode 100644 drivers/bus/hisi_lpc.c > create mode 100644 include/linux/logic_pio.h > create mode 100644 lib/logic_pio.c Booted up on a D05, was able to use the LPC-connected IPMI interface. Tested-by: dann frazier

Re: [PATCH V7 2/7] PCI: Apply the new generic I/O management on PCI IO hosts

2017-03-27 Thread dann frazier
On Sun, Mar 12, 2017 at 8:42 PM, zhichang.yuan wrote: > After introducing the new generic I/O space management(LIBIO), the original > PCI > MMIO relevant helpers need to be updated based on the new interfaces defined > in > LIBIO. > This patch adapts the corresponding code to match the changes i

Re: [PATCH v2 06/18] arm64: arch_timer: Add infrastructure for multiple erratum detection methods

2017-03-24 Thread dann frazier
On Mon, Mar 20, 2017 at 11:48 AM, Marc Zyngier wrote: > We're currently stuck with DT when it comes to handling errata, which > is pretty restrictive. In order to make things more flexible, let's > introduce an infrastructure that could support alternative discovery > methods. No change in functio

Re: [PATCH 00/17] clocksource/arch_timer: Errara workaround infrastructure rework

2017-03-06 Thread dann frazier
und for HiSilicon erratum 161010101 [0.00] arm_arch_timer: CPU0: Trapping CNTVCT access [0.00] arm_arch_timer: Architected cp15 timer(s) running at 50.00MHz (phys). [0.266571] arm_arch_timer: CPU1: Trapping CNTVCT access [0.270108] arm_arch_timer: CPU2: Trapping CNTVCT access [...] Tested-by: dann frazier -dann

[PATCH] arm64: Disallow combination of ARCH_XGENE and 16K page size

2016-01-27 Thread dann frazier
16K page size is an optional feature of the architecture, and is not supported by the X-Gene SoC family. Signed-off-by: dann frazier --- arch/arm64/Kconfig.platforms | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms index 21074f6

Re: [PATCH 2/2 RESEND] power: reset: Add syscon poweroff device node for APM X-Gene platform

2015-06-10 Thread Dann Frazier
On Tue, Jun 9, 2015 at 9:31 AM, Dann Frazier wrote: > On Mon, Jun 8, 2015 at 10:34 PM, Tai Tri Nguyen wrote: >> Hi Dann, >> >> On Mon, Jun 8, 2015 at 8:44 PM, Dann Frazier >> wrote: >>> On Tue, Jun 2, 2015 at 1:19 PM, Tai Nguyen wrote: >>>>

Re: [PATCH 1/2 RESEND] power: reset: Add syscon reboot device node for APM X-Gene platform

2015-06-09 Thread Dann Frazier
On Tue, Jun 2, 2015 at 1:19 PM, Tai Nguyen wrote: > This patch adds syscon reboot device node to support reboot feature on APM > X-Gene platform Tested-by: dann frazier > Signed-off-by: Feng Kan > Signed-off-by: Tai Nguyen > --- > arch/arm64/boot/dts/apm/apm

Re: [PATCH 2/2 RESEND] power: reset: Add syscon poweroff device node for APM X-Gene platform

2015-06-09 Thread Dann Frazier
On Mon, Jun 8, 2015 at 10:34 PM, Tai Tri Nguyen wrote: > Hi Dann, > > On Mon, Jun 8, 2015 at 8:44 PM, Dann Frazier > wrote: >> On Tue, Jun 2, 2015 at 1:19 PM, Tai Nguyen wrote: >>> This patch adds syscon poweroff device node to support poweroff feature >>

Re: [PATCH 2/2 RESEND] power: reset: Add syscon poweroff device node for APM X-Gene platform

2015-06-08 Thread Dann Frazier
On Tue, Jun 2, 2015 at 1:19 PM, Tai Nguyen wrote: > This patch adds syscon poweroff device node to support poweroff feature > on APM X-Gene Mustang platform hey Tai, The reboot changes work just fine for me, but poweroff does not: [ OK ] Reached target Final Step. Starting Power-Off.

[PATCH] tools: testing: selftests: mq_perf_tests: Fix infinite loop on ARM

2015-01-05 Thread dann frazier
We can't use a char type to check for a negative return value since char isn't guaranteed to be signed. Indeed, the char type tends to be unsigned on ARM. Signed-off-by: dann frazier --- tools/testing/selftests/mqueue/mq_perf_tests.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletion

Re: [PATCH v8 4/4] drivers: net: Add APM X-Gene SoC ethernet driver support.

2014-06-24 Thread Dann Frazier
On Fri, Jun 20, 2014 at 5:18 PM, Iyappan Subramanian wrote: > This patch adds network driver for APM X-Gene SoC ethernet. > > Signed-off-by: Iyappan Subramanian > Signed-off-by: Ravi Patel > Signed-off-by: Keyur Chudgar > --- > drivers/net/ethernet/Kconfig | 1 + > driv

lustre virtual block device doesn't build w/ CONFIG_ARM64_64K_PAGES=y

2014-06-19 Thread dann frazier
With current git, lustre fails to build with CONFIG_ARM64_64K_PAGES=y and CONFIG_LUSTRE_LLITE_LLOOP=m: make -f scripts/Makefile.build obj=drivers/staging/lustre/lustre/llite gcc -Wp,-MD,drivers/staging/lustre/lustre/llite/.lloop.o.d -nostdinc -isystem /usr/lib/gcc/aarch64-linux-gnu/4.8/include

Re: [PATCH v2] serial: uart: add hw flow control support configuration

2014-06-11 Thread Dann Frazier
On Wed, Jun 11, 2014 at 2:53 PM, Murali Karicheri wrote: > On 5/28/2014 4:04 PM, Dann Frazier wrote: >> >> On Thu, May 1, 2014 at 1:04 PM, Murali Karicheri >> wrote: >>> >>> 8250 uart driver currently supports only software assisted hw flow >>>

Re: [PATCH v2] serial: uart: add hw flow control support configuration

2014-05-28 Thread Dann Frazier
, 22:58:30) [GCC 4.8.2] on linux2 Type "help", "copyright", "credits" or "license" for more information. >>> UPF_HARDWARE_FLOW = 1 << 21 >>> if 0xB920 & UPF_HARDWARE_FLOW: ... print "OK" ... OK Hope that's a reaso

Re: [RFC PATCH V3 0/4] APM X-Gene PCIe controller

2014-01-25 Thread Dann Frazier
On Fri, Jan 24, 2014 at 2:32 PM, Tanmay Inamdar wrote: > This patch adds support for AppliedMicro X-Gene PCIe host controller. The > driver is tested on X-Gene platform with different gen1/2/3 PCIe endpoint > cards. > > X-Gene PCIe controller driver has depedency on the pcie arch support for > arm

Re: PROBLEM: 2.4.36.1 hangs.

2008-02-26 Thread dann frazier
ded, we'd better ask Theo or Al > for some advices, as I'm not tempted by merging an uncertain patch when > it comes to filesystems. Looks like a test case may be available: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=2d7f2ea9c989853310c

[PATCH] 2.4: [POWERPC] CHRP: Fix possible NULL pointer dereference

2008-02-22 Thread dann frazier
strncmp() if of_get_property() fails. Signed-off-by: dann frazier <[EMAIL PROTECTED]> diff --git a/arch/ppc/platforms/chrp_setup.c b/arch/ppc/platforms/chrp_setup.c index 0ffbbd2..28747db 100644 --- a/arch/ppc/platforms/chrp_setup.c +++ b/arch/ppc/platforms/chrp_setup.c @@ -121,7

[PATCH] 2.4: USB: fix DoS in pwc USB video driver

2008-02-06 Thread dann frazier
to close the device. This opens up an opportunity for a DoS attack, blocking the USB subsystem and making khubd's task busy wait in kernel space. This patch shifts freeing resources to close if an opened device is disconnected. Signed-off-by: dann frazier <[EMAIL PROTECTED]> -

[PATCH] 2.4: [PPPOE]: memory leak when socket is release()d before PPPIOCGCHAN has been called on it

2008-02-06 Thread dann frazier
cating all session IDs for a known AC is a kind of DoS, too, after all - with Juniper ERXes, this is really easy, actually, since they don't ever assign session ids above 8000 ... Signed-off-by: dann frazier <[EMAIL PROTECTED]> --- drivers/net/pppox.c |2 +- 1 files change

[PATCH] 2.4: [SCSI] aacraid: Fix security hole

2008-02-05 Thread dann frazier
licit permissions check for ioctls (and indeed other drivers implement unprivileged ioctls). aacraid however allows all sorts of very admin only things to be done so should check. --- drivers/scsi/aacraid/linit.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) Signed-off-by: dann fr

Re: [PATCH] 2.4: fix memory corruption from misinterpreted bad_inode_ops return values

2008-01-24 Thread dann frazier
On Thu, Jan 24, 2008 at 03:06:58PM -0600, Eric Sandeen wrote: > Willy Tarreau wrote: > > Hi Dann, > > > > On Wed, Jan 23, 2008 at 11:12:12PM -0700, dann frazier wrote: > >> This is a 2.4 backport of a linux-2.6 change by Eric Sandeen > >> (commit b

[PATCH] 2.4: fix memory corruption from misinterpreted bad_inode_ops return values

2008-01-23 Thread dann frazier
are a signature, I just went ahead & created an EIO function for each individual file & inode op that returns a value. Signed-off-by: dann frazier <[EMAIL PROTECTED]> --- fs/bad_inode.c | 191 +++- 1 files changed, 161 inserti

Re: old buffer overflow in moxa driver

2007-05-01 Thread dann frazier
iced this, but yes - the CAP_SYS_RAWIO check was added in 2.6.16. -- dann frazier | HP Open Source and Linux Organization - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/major

old buffer overflow in moxa driver

2007-04-30 Thread dann frazier
contacting the listed maintainer a few months ago but received no response. I've tested that this still applies to and compiles against 2.6.21. Signed-off-by: dann frazier <[EMAIL PROTECTED]> diff --git a/drivers/char/moxa.c b/drivers/char/moxa.c index 7dbaee8..e0d35c2 100644 --- a/drivers/

Re: problems with latest smbfs changes on 2.4.34 and security backports

2007-01-23 Thread dann frazier
On Wed, Jan 24, 2007 at 10:46:24AM +1100, Grant Coady wrote: > On Tue, 23 Jan 2007 14:12:57 -0700, dann frazier <[EMAIL PROTECTED]> wrote: > > >Users have reported a symlink issue with my recent smbfs backport. > >Turns out my backport overlooked a second 2.6 pa

Re: problems with latest smbfs changes on 2.4.34 and security backports

2007-01-23 Thread dann frazier
ns out this was an issue that was already fixed in 2.6, and that fix is more complete than my previous one. You'll need the additional userspace patches to use the server-provided perms (i.e., get rid of the +x bits). -- dann frazier - To unsubscribe from this list: send the line "unsubscr

Re: problems with latest smbfs changes on 2.4.34 and security backports

2007-01-23 Thread dann frazier
ink issue, and also cleans up an unnecessary double assignment. As his commit message notes, you will need the userspace patches from Samba Bug #999 in order to use the permission/ownership assigned by the server. Signed-off-by: dann frazier <[EMAIL PROTECTED]> diff --git a/fs/smbfs/inode.c b/f

Re: problems with latest smbfs changes on 2.4.34 and security backports

2007-01-23 Thread dann frazier
On Mon, Jan 22, 2007 at 12:03:21AM +0100, Willy Tarreau wrote: > Hi Grant ! > > On Mon, Jan 22, 2007 at 09:52:44AM +1100, Grant Coady wrote: > > On Fri, 19 Jan 2007 18:05:44 -0700, dann frazier <[EMAIL PROTECTED]> wrote: > > > > >On Thu, Jan 18, 2007 at

Re: problems with latest smbfs changes on 2.4.34 and security backports

2007-01-22 Thread dann frazier
ntly dropping user-provided mount options. When the behavior needs to change to honor them, I'll try to match what current 2.6 does. Make sense? -- dann frazier - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: problems with latest smbfs changes on 2.4.34 and security backports

2007-01-19 Thread dann frazier
On Thu, Jan 18, 2007 at 06:00:40PM -0700, dann frazier wrote: > On Wed, Jan 17, 2007 at 10:55:19PM +0100, Willy Tarreau wrote: > > @@ -505,8 +510,13 @@ > > mnt->file_mode = (oldmnt->file_mode & S_IRWXUGO) | S_IFREG; > > mnt->dir_mo

Re: [PATCH 9/12] repost: cciss: add busy_configuring flag

2007-01-19 Thread dann frazier
blk_start_queue() when you set ->busy_configuring to 0. > > > > Jens, please see Chase's reply to your concerns: > > > busy_configuring - I do not think this is racy. This > > > flag is used only when we are removing/deleting a disk. In > > > this c

Re: problems with latest smbfs changes on 2.4.34 and security backports

2007-01-18 Thread dann frazier
certainly a cut & paste error. But the end result appears to match current 2.6, which was the intent. > Also, would not it be necessary to add "|S_IFLNK" to the file_mode ? Maybe > what I say is stupid, but it's just a guess. I really don't know the correct answer

Re: problems with latest smbfs changes on 2.4.34 and security backports

2007-01-18 Thread dann frazier
On Wed, Jan 17, 2007 at 10:55:19PM +0100, Willy Tarreau wrote: > Dann, do you still have your samba server ready to try to reproduce this > problem ? Also, there are very suspect lines right there in the patch : I can set it up again, hopefully have some feedback by tomorrow. -- dann f

Re: udev/aacraid interaction - should aacraid set 'removable'?

2007-01-05 Thread dann frazier
tp://bugs.debian.org/404927 for details). -- dann frazier - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

udev/aacraid interaction - should aacraid set 'removable'?

2007-01-03 Thread dann frazier
100, Marco d'Itri wrote: > On Jan 03, dann frazier <[EMAIL PROTECTED]> wrote: > > > Can you elaborate on what you believe the kernel is doing > > incorrectly? My first guess would be the setting of the removable > > flag, but aacraid claims to be setting this to

Re: 2.6.19-git20 cciss: cmd f7b00000 timedout

2006-12-14 Thread dann frazier
On Thu, Dec 14, 2006 at 04:16:39PM -0600, Miller, Mike (OS Dev) wrote: > H. Dann, did you see this on 32-bit Debian? yep - all reports I've seen so far are on i386 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More ma

Re: 2.6.19-git20 cciss: cmd f7b00000 timedout

2006-12-14 Thread dann frazier
one is connected > to an MSA500. Do either of you have MSA500? What controller fw are you > running? Check /proc/driver/cciss/ccissN. fyi, we've been seeing this in Debian too (which is why Mike added me to the CC list), and I've narrowed it down to the 2TB patch that went into 2.