[PATCH net-next v3] selftests: forwarding: Reorder (ar)ping arguments to obey POSIX getopt

2025-09-18 Thread David Yang
for tools using getopt() (in this case, (ar)ping) do not always come last. Fix it by reordering arguments. Signed-off-by: David Yang --- v2: https://lore.kernel.org/r/20250906170440.3513399-1-mmyan...@gmail.com - fix (ar)ping only v1: https://lore.kernel.org/r/20250905173947.3164807-1-mmyan

Re: [PATCH v2 1/1] selftests/mm: skip soft-dirty tests when CONFIG_MEM_SOFT_DIRTY is disabled

2025-09-17 Thread David Hildenbrand
this could just be supported = check_vmflag(addr, "sd"); LGTM Acked-by: David Hildenbrand -- Cheers David / dhildenb

Re: [PATCH RESEND 1/1] selftests/mm: skip soft-dirty tests when CONFIG_MEM_SOFT_DIRTY is disabled

2025-09-17 Thread David Hildenbrand
enabled. I'll note that tools/testing/selftests/mm/config contains CONFIG_MEM_SOFT_DIRTY=y But yes, the current arm64 handling is nasty, because some other archs (e.g., riscv) also don't support it yet. LGTM, some nits below: Suggested-by: David Hildenbrand Signed-off-by:

Re: [PATCH RESEND v5 0/7] Input: synaptics-rmi4 - add quirks for third party touchscreen controllers

2025-09-16 Thread David Heidelberg
On 07/08/2025 06:29, Dmitry Torokhov wrote: Hi David, On Thu, Jul 31, 2025 at 11:06:50PM +0200, David Heidelberg via B4 Relay wrote: With the growing popularity of running upstream Linux on mobile devices, we're beginning to run into more and more edgecases. The OnePlus 6 is a fairly

Re: [PATCH] kunit: Extend kconfig help text for KUNIT_UML_PCI

2025-09-16 Thread David Gow
y: Shuah Khan > Link: > https://lore.kernel.org/lkml/3dc95227-2be9-48a0-bdea-3f283d9b2...@linuxfoundation.org/ > Signed-off-by: Thomas Weißschuh > --- Reviewed-by: David Gow Thanks, -- David smime.p7s Description: S/MIME Cryptographic Signature

Re: [PATCH v5 1/2] KVM: guest_memfd: add generic population via write

2025-09-13 Thread David Hildenbrand
e that a page is actually inaccessible and should not be touched? IOW, with CXL you could crash the host. There is likely some state check missing, or it should be restricted to VM types. Do we know how this would interact with the direct-map removal? -- Cheers David / dhildenb

Re: [PATCH v5 1/2] KVM: guest_memfd: add generic population via write

2025-09-13 Thread David Hildenbrand
On 12.09.25 16:48, Nikita Kalyazin wrote: On 12/09/2025 14:36, David Hildenbrand wrote: On 11.09.25 12:15, Nikita Kalyazin wrote: On 10/09/2025 22:23, James Houghton wrote: On Tue, Sep 2, 2025 at 4:20 AM Kalyazin, Nikita wrote: From: Nikita Kalyazin Hi Nikita, Hi James, Thanks

Re: [PATCH RESEND v2] kunit: Enable PCI on UML without triggering WARN()

2025-09-13 Thread David Gow
enables CONFIG_UML_PCI without triggering > warnings or building dead code. > > Signed-off-by: Thomas Weißschuh > Reviewed-by: Johannes Berg > --- Reviewed-by: David Gow Cheers, -- David > Changes in v2: > - Rebase onto v6.17-rc1 > - Pick up review from Johannes >

[RFC] PatchWise: Unified Static Analysis for Kernel Development

2025-09-12 Thread David Gantman
st tools, while offering optional advanced features for those who want them. Thanks, David

Re: [PATCH v3 3/3] selftests/mm: fix va_high_addr_switch.sh failure on x86_64

2025-09-12 Thread David Hildenbrand
(2 hugepages) will be one hugepage above the DEFAULT_MAP_WINDOW. An aligned address won't be affected by the page round up or round down from kernel, so it's determistic. Fixes: cc92882ee218 ("mm: drop hugetlb_get_unmapped_area{_*} functions") Suggested-by: David Hildenbrand

Re: [PATCH] mm: transhuge-stress: fix potential memory leak on realloc failure

2025-09-12 Thread David Hildenbrand
allocated to that process gets freed, avoiding any memory leaks. -- Cheers David / dhildenb

Re: [PATCH] selftests/mm: centralize the __always_unused macro

2025-09-12 Thread David Hildenbrand
On 12.09.25 14:51, Muhammad Usama Anjum wrote: This macro gets used in different tests. Add it to kselftest.h which is central location and tests use this header. Then use this new macro. Signed-off-by: Muhammad Usama Anjum --- Acked-by: David Hildenbrand -- Cheers David / dhildenb

Re: [PATCH 1/2] selftests/mm: Add -Wunreachable-code and fix warnings

2025-09-12 Thread David Hildenbrand
uplicate inline. pkey_sighandler_tests.c:44:15: warning: duplicate 'inline' declaration specifier [-Wduplicate-decl-specifier] static inline __always_inline Reviewed-by: Sidhartha Kumar Reviewed-by: Kevin Brodsky Signed-off-by: Muhammad Usama Anjum --- Acked-by: David Hilde

Re: [PATCH] mm: transhuge-stress: fix potential memory leak on realloc failure

2025-09-12 Thread David Hildenbrand
On 12.09.25 12:10, Haofeng Li wrote: From: David Hildenbrand What do you think happens when a process exits? :) Correct! All memory ever allocated to that process gets freed, avoiding any memory leaks. Thanks for pointing this out. You are absolutely correct that the operating system

[PATCH v1] selftests/mm: gup_tests: option to GUP all pages in a single call

2025-09-10 Thread David Hildenbrand
u Cc: Lorenzo Stoakes Cc: "Liam R. Howlett" Cc: Vlastimil Babka Cc: Mike Rapoport Cc: Suren Baghdasaryan Cc: Michal Hocko Cc: Shuah Khan Signed-off-by: David Hildenbrand --- tools/testing/selftests/mm/gup_test.c | 2 ++ tools/testing/selftests/mm/run_vmtests.sh | 8 +---

Re: [PATCH] selftests/mm: remove PROT_EXEC req from file-collapse tests

2025-09-09 Thread David Hildenbrand
OT_READ | PROT_EXEC, + p = mmap(BASE_ADDR, size, PROT_READ, MAP_PRIVATE, finfo.fd, 0); if (p == MAP_FAILED || p != BASE_ADDR) { perror("mmap()"); Acked-by: David Hildenbrand -- Cheers David / dhildenb

Re: [PATCH v2 3/3] selftests/mm: fix va_high_addr_switch.sh failure on x86_64

2025-09-08 Thread David Hildenbrand
dr_switch_hint - hugepagesize), would just work and be aligned? -- Cheers David / dhildenb

Re: [PATCH v2 1/3] selftests/mm: fix hugepages cleanup too early

2025-09-08 Thread David Hildenbrand
it's also the value before userfaultfd test starts, and the correct value to be restored after userfaultfd finishes. The va_high_addr_switch.sh broken will be resolved. Signed-off-by: Chunyu Hu Acked-by: David Hildenbrand -- Cheers David / dhildenb

Re: next-20250905: x86_64: udpgso_bench.sh triggers NULL deref in zerocopy_fill_skb_from_iter

2025-09-07 Thread David Hildenbrand
On 05.09.25 15:07, David Hildenbrand wrote: On 05.09.25 14:55, Eric Dumazet wrote: On Fri, Sep 5, 2025 at 2:30 AM Naresh Kamboju wrote: The following kernel crash was noticed on x86_64 running selftests net udpgso_bench.sh on Linux next-20250905 tag. Regression Analysis: - New regression

[PATCH net-next v2] selftests: forwarding: Reorder arguments to obey POSIX getopt

2025-09-06 Thread David Yang
do not always come last. Fix it by reordering arguments. Signed-off-by: David Yang v1: https://lore.kernel.org/r/20250905173947.3164807-1-mmyan...@gmail.com - fix CI errors --- .../selftests/net/forwarding/bridge_igmp.sh | 26 ++--- .../net/forwarding/bridge_locked_port.sh | 10

[PATCH net-next] selftests: forwarding: Reorder arguments to obey POSIX getopt

2025-09-05 Thread David Yang
do not always come last. Fix it by reordering arguments. Signed-off-by: David Yang --- .../selftests/net/forwarding/bridge_igmp.sh | 26 ++--- .../net/forwarding/bridge_locked_port.sh | 10 +- .../selftests/net/forwarding/bridge_mdb.sh| 54 - .../net/forwarding

Re: next-20250905: x86_64: udpgso_bench.sh triggers NULL deref in zerocopy_fill_skb_from_iter

2025-09-05 Thread David Hildenbrand
On 05.09.25 15:28, David Hildenbrand wrote: On 05.09.25 15:07, David Hildenbrand wrote: On 05.09.25 14:55, Eric Dumazet wrote: On Fri, Sep 5, 2025 at 2:30 AM Naresh Kamboju wrote: The following kernel crash was noticed on x86_64 running selftests net udpgso_bench.sh on Linux next-20250905

Re: next-20250905: x86_64: udpgso_bench.sh triggers NULL deref in zerocopy_fill_skb_from_iter

2025-09-05 Thread David Hildenbrand
ft.linaro.org I suspect a bug added in mm/gup.c recently commit db076b5db550aa34169dceee81d0974c7b2a2482 Author: David Hildenbrand Date: Mon Sep 1 17:03:40 2025 +0200 mm/gup: remove record_subpages() We can just cleanup the code by calculating the #refs earlier, so we can

[PATCH v2 2/2] selftests/mm: split_huge_page_test: cleanups for split_pte_mapped_thp test

2025-09-03 Thread David Hildenbrand
HPs after mremap. (6) Rename "pte_mapped2" to "tmp", used to verify mremap(MAP_FIXED) result. (7) Split the corruption test from the failed-split test, so we can just iterate bytes vs. thps naturally. (8) Extend comments and clarify why we are using mremap in the first

[PATCH v2 2/2] selftests/mm: split_huge_page_test: cleanups for split_pte_mapped_thp test

2025-09-03 Thread David Hildenbrand
HPs after mremap. (6) Rename "pte_mapped2" to "tmp", used to verify mremap(MAP_FIXED) result. (7) Split the corruption test from the failed-split test, so we can just iterate bytes vs. thps naturally. (8) Extend comments and clarify why we are using mremap in t

[PATCH v2 1/2] selftests/mm: split_huge_page_test: fix occasional is_backed_by_folio() wrong results

2025-09-03 Thread David Hildenbrand
s/folio_head_flags to improve readability and use these masks also when just testing for any compound page. Fixes: 169b456b0162 ("selftests/mm: reimplement is_backed_by_thp() with more precise check") Reviewed-by: Zi Yan Reviewed-by: Wei Yang Signed-off-by: David Hildenbrand --- tools/testing/s

[PATCH v2 0/2] selftests/mm: split_huge_page_test: split_pte_mapped_thp improvements

2025-09-03 Thread David Hildenbrand
) wrong results" -> Fixup missing ")" in patch description David Hildenbrand (2): selftests/mm: split_huge_page_test: fix occasional is_backed_by_folio() wrong results selftests/mm: split_huge_page_test: cleanups for split_pte_mapped_thp test .../selftests/mm/split_huge

[PATCH v2 1/2] selftests/mm: split_huge_page_test: fix occasional is_backed_by_folio() wrong results

2025-09-02 Thread David Hildenbrand
_flags to improve readability and use these masks also when just testing for any compound page. Fixes: 169b456b0162 ("selftests/mm: reimplement is_backed_by_thp() with more precise check") Signed-off-by: David Hildenbrand --- tools/testing/selftests/mm/split_huge_page_test.c

[PATCH v2 0/2] selftests/mm: split_huge_page_test: split_pte_mapped_thp improvements

2025-09-02 Thread David Hildenbrand
Cc: Ryan Roberts Cc: Dev Jain Cc: Barry Song Cc: Wei Yang David Hildenbrand (2): selftests/mm: split_huge_page_test: fix occasional is_backed_by_folio() wrong results selftests/mm: split_huge_page_test: cleanups for split_pte_mapped_thp test .../selftests/mm/split_huge_page_test.c

Re: [PATCH v4 1/2] KVM: guest_memfd: add generic population via write

2025-09-01 Thread David Hildenbrand
On 01.09.25 16:29, Nikita Kalyazin wrote: On 28/08/2025 21:01, David Hildenbrand wrote: On 28.08.25 17:31, Kalyazin, Nikita wrote: write syscall populates guest_memfd with user-supplied data in a generic way, ie no vendor-specific preparation is performed.  This is supposed to be used in non

Re: [PATCH v4 1/2] KVM: guest_memfd: add generic population via write

2025-09-01 Thread David Hildenbrand
>>, old ones prefixed by <<): ERROR: modpost: "filemap_remove_folio" [arch/x86/kvm/kvm.ko] undefined! Right, that one is not exported. -- Cheers David / dhildenb

Re: [PATCH 1/2] iio: adc: Add driver for Marvell 88PM886 PMIC ADC

2025-08-29 Thread David Lechner
On 8/29/25 10:20 AM, Duje Mihanović wrote: > On Friday, 29 August 2025 01:40:56 Central European Summer Time David Lechner > wrote: ... >>> + *val = raw; >>> + dev_dbg(&iio->dev, "chan: %d, raw: %d\n", chan->chann

Re: [PATCH 1/2] iio: adc: Add driver for Marvell 88PM886 PMIC ADC

2025-08-28 Thread David Lechner
On 8/28/25 5:17 PM, Duje Mihanović wrote: > Marvell's 88PM886 PMIC has a so-called General Purpose ADC used for > monitoring various system voltages and temperatures. Add the relevant > register definitions to the MFD header and a driver for the ADC. > > Signed-off-by: Duje Mihanović > --- > MAI

Re: [PATCH v4 0/2] KVM: guest_memfd: use write for population

2025-08-28 Thread David Hildenbrand
added this patch to the pile of guestmemfd preview patches located at https://git.kernel.org/pub/scm/linux/kernel/git/david/linux.git/log/?h=guestmemfd-preview There was only one minor conflict regarding setting file->f_mode. -- Cheers David / dhildenb

Re: [PATCH v4 1/2] KVM: guest_memfd: add generic population via write

2025-08-28 Thread David Hildenbrand
Signed-off-by: Nikita Kalyazin --- Just nothing that checkpatch complains about a) Usage of "unsigned" instead of "unsigned int" b) The From doesn't completely match the SOB: "Kalyazin, Nikita" vs "Nikita Kalyazin" -- Cheers David / dhildenb

Re: [PATCH v1] virtio_fs: fix page fault for DAX page address

2025-08-28 Thread David Hildenbrand
ages; } Yeah, looks like that's the only instance we got wrong in that commit. Acked-by: David Hildenbrand -- Cheers David / dhildenb

Re: [PATCH v3 06/11] powerpc/ptdump: rename "struct pgtable_level" to "struct ptdump_pglevel"

2025-08-27 Thread David Hildenbrand
On 26.08.25 18:28, Ritesh Harjani (IBM) wrote: David Hildenbrand writes: We want to make use of "pgtable_level" for an enum in core-mm. Other architectures seem to call "struct pgtable_level" either: * "struct pg_level" when not exposed in a header (riscv, arm) *

Re: [PATCH 1/2] selftests/mm: fix hugepages cleanup too early

2025-08-27 Thread David Hildenbrand
ag" run_test ./test_page_frag.sh nonaligned +if [ "${HAVE_HUGEPAGES}" = 1 ]; then + echo "$nr_hugepgs_origin" > /proc/sys/vm/nr_hugepages +fi FWIW, I think the tests should maybe be doing that (save+configure+restore) themselves, like we do with THP settings through. thp_save_settings() thp_write_settings() and friends. This is not really something run_vmtests.sh should bother with. A bigger rework, though ... -- Cheers David / dhildenb

Re: [PATCH v3 4/8] selftests/mm: Add -Wunused family of flags

2025-08-26 Thread David Hildenbrand
here. Certainly not enough to be worth it. Fully agreed. -- Cheers David / dhildenb

Re: [PATCH v3 08/11] mm/memory: convert print_bad_pte() to print_bad_page_map()

2025-08-25 Thread David Hildenbrand
On 26.08.25 07:25, Lorenzo Stoakes wrote: On Mon, Aug 25, 2025 at 02:31:00PM +0200, David Hildenbrand wrote: On 11.08.25 13:26, David Hildenbrand wrote: print_bad_pte() looks like something that should actually be a WARN or similar, but historically it apparently has proven to be useful to

Re: [PATCH v3 08/11] mm/memory: convert print_bad_pte() to print_bad_page_map()

2025-08-25 Thread David Hildenbrand
On 11.08.25 13:26, David Hildenbrand wrote: print_bad_pte() looks like something that should actually be a WARN or similar, but historically it apparently has proven to be useful to detect corruption of page tables even on production systems -- report the issue and keep the system running to

[PATCH v2 1/2] drm/xe/tests: Fix some additional gen_params signatures

2025-08-21 Thread David Gow
4be9072fca ("kunit: Pass parameterized test context to generate_params()") Signed-off-by: David Gow --- Sorry, the last fix here caused a warning (thanks to the test robot for finding it). I'm still happy to sqash and re-send the whole original series if that's prefe

[PATCH v2 2/2] kunit: Only output a test plan if we're using kunit_array_gen_params

2025-08-21 Thread David Gow
e provided kunit_array_gen_params. Unfortunately, this catches a lot of tests which would work, but at least makes sure we don't regress anything until we can rework how some of these macros function. Fixes: 6a2a027e254b ("kunit: Enable direct registration of parameter arrays to a KUnit test&qu

Re: [PATCH v5 3/5] selftests/mm: reimplement is_backed_by_thp() with more precise check

2025-08-19 Thread David Hildenbrand
igned long pfn; + unsigned long i; Final nit (sorry!) :) const unsigned long nr_pages = 1ul << order; so you can make some of the code below easier to read. Acked-by: David Hildenbrand -- Cheers David / dhildenb

[PATCH 2/2] kunit: Only output a test plan if we're using kunit_array_gen_params

2025-08-19 Thread David Gow
e provided kunit_array_gen_params. Unfortunately, this catches a lot of tests which would work, but at least makes sure we don't regress anything until we can rework how some of these macros function. Fixes: 6a2a027e254b ("kunit: Enable direct registration of parameter arrays to a KUnit test&qu

[PATCH 1/2] drm/xe/tests: Fix some additional gen_params signatures

2025-08-19 Thread David Gow
4be9072fca ("kunit: Pass parameterized test context to generate_params()") Signed-off-by: David Gow --- This should fix the issues found with the linux-next merge: https://lore.kernel.org/linux-next/20250818120846.347d6...@canb.auug.org.au/ The following should reproduce them: .

Re: [Fixup PATCH] mm/selftests: Fix formattig in split_huge_page_test

2025-08-19 Thread David Hildenbrand
On 19.08.25 09:25, David Hildenbrand wrote: On 19.08.25 06:12, Aboorva Devarajan wrote: Removed an extra space in split_huge_page_test that was introduced by commit 4b76e221794b ("mm/selftests: fix split_huge_page_test failure on systems with 64KB page size"). Signed-off-by: Aboorva

Re: [Fixup PATCH] mm/selftests: Fix formattig in split_huge_page_test

2025-08-19 Thread David Hildenbrand
sz2ord(pmd_pagesize, pagesize); tests = 2 + (max_order - 1) + (2 * max_order) + (max_order - 1) * 4 + 2; ksft_set_plan(tests); Please just comment next time one the respective patch as review comment. -- Cheers David / dhildenb

Re: [PATCH 5/6] selftests: kvm: s390: fixed spelling mistake in output

2025-08-18 Thread David Hildenbrand
On 15.08.25 02:18, Soham Metha wrote: found/fixed the following typo - avaialable -> available in `tools/testing/selftests/kvm/s390/cpumodel_subfuncs_test.c` Signed-off-by: Soham Metha --- Reviewed-by: David Hildenbrand -- Cheers David / dhildenb

Re: [PATCH v4 3/5] selftests/mm: reimplement is_backed_by_thp() with more precise check

2025-08-18 Thread David Hildenbrand
pfn, int kpageflags_fd, uint64_t *flags) +{ + size_t count; + + count = pread(kpageflags_fd, flags, sizeof(*flags), + pfn * sizeof(*flags)); + + if (count != sizeof(*flags)) + return -1; + + return 0; +} I would have called this function "pageflags_get()" to resemble "pagemap_get" -- Cheers David / dhildenb

Re: [PATCH v7 1/1] selftests/mm/uffd: Refactor non-composite global vars into struct

2025-08-18 Thread David Hildenbrand
bool hugetlb) Please avoid that. static void test_one_folio(uffd_global_test_opts_t *gopts, size_t size, bool private, bool swapout, bool hugetlb) -- Cheers David / dhildenb

Re: [PATCH v4 2/5] selftests/mm: mark all functions static in split_huge_page_test.c

2025-08-18 Thread David Hildenbrand
On 15.08.25 04:39, Zi Yan wrote: All functions are only used within the file. Signed-off-by: Zi Yan --- Acked-by: David Hildenbrand -- Cheers David / dhildenb

Re: [PATCH v4 4/7] mm/selftests: Fix split_huge_page_test failure on systems with 64KB page size

2025-08-17 Thread David Hildenbrand
hould look into using kselftest_harness as a separate effort, so we can avoid this manual test calculation completely. I'm afraid even using defines will not make this significntly more readable. -- Cheers David / dhildenb

Re: [PATCH RFC V10 4/7] KVM: guest_memfd: Use guest mem inodes instead of anonymous inodes

2025-08-11 Thread David Hildenbrand
t;f_flags |= O_LARGEFILE; + file->private_data = priv; + +out: + return file; + +err_put_inode: + iput(inode); +err_put_module: + module_put(kvm_gmem_fops.owner); fops_put(&kvm_gmem_fops); ? Acked-by: David Hildenbrand -- Cheers, David / dhildenb

Re: [PATCH RFC V10 0/7] Add NUMA mempolicy support for KVM guest-memfd

2025-08-11 Thread David Hildenbrand
e tag. -- Cheers, David / dhildenb

[PATCH v3 00/11] mm: vm_normal_page*() improvements

2025-08-11 Thread David Hildenbrand
ellini Cc: Oleksandr Tyshchenko Cc: Dan Williams Cc: Matthew Wilcox Cc: Jan Kara Cc: Alexander Viro Cc: Christian Brauner Cc: Lorenzo Stoakes Cc: "Liam R. Howlett" Cc: Vlastimil Babka Cc: Mike Rapoport Cc: Suren Baghdasaryan Cc: Michal Hocko Cc: Zi Yan Cc: Baolin Wang C

[PATCH v3 11/11] mm: rename vm_ops->find_special_page() to vm_ops->find_normal_page()

2025-08-11 Thread David Hildenbrand
mentation, and add a comment in the code where XEN ends up performing the pte_mkspecial() through a hypercall. More details can be found in commit 923b2919e2c3 ("xen/gntdev: mark userspace PTEs as special on x86 PV guests"). Cc: David Vrabel Reviewed-by: Oscar Salvador Reviewed-by: Loren

[PATCH v3 10/11] mm: introduce and use vm_normal_page_pud()

2025-08-11 Thread David Hildenbrand
ucing vm_normal_folio_pud() until really used. Note that we can so far get PUDs with hugetlb, daxfs and PFNMAP entries. Reviewed-by: Wei Yang Reviewed-by: Oscar Salvador Signed-off-by: David Hildenbrand --- include/linux/mm.h | 2 ++ mm/memory.c| 19 +++ mm/pagewalk.c

[PATCH v3 07/11] mm/rmap: convert "enum rmap_level" to "enum pgtable_level"

2025-08-11 Thread David Hildenbrand
Let's factor it out, and convert all checks for unsupported levels to BUILD_BUG(). The code is written in a way such that force-inlining will optimize out the levels. Signed-off-by: David Hildenbrand --- include/linux/pgtable.h | 8 ++ include/linux/rmap.h

[PATCH v3 08/11] mm/memory: convert print_bad_pte() to print_bad_page_map()

2025-08-11 Thread David Hildenbrand
evels even when levels are folded for simplicity. Signed-off-by: David Hildenbrand --- include/linux/pgtable.h | 19 mm/memory.c | 104 2 files changed, 103 insertions(+), 20 deletions(-) diff --git a/include/linux/pgtable.h

[PATCH v3 09/11] mm/memory: factor out common code from vm_normal_page_*()

2025-08-11 Thread David Hildenbrand
_zero_pfn() anymore if we have CONFIG_ARCH_HAS_PTE_SPECIAL and the PMD is not special. The VM_WARN_ON_ONCE would catch any abuse No functional change intended. Reviewed-by: Oscar Salvador Signed-off-by: David Hildenbrand --- mm/memory.c | 186 ++--

[PATCH v3 06/11] powerpc/ptdump: rename "struct pgtable_level" to "struct ptdump_pglevel"

2025-08-11 Thread David Hildenbrand
#x27;s follow what arm64 does. Signed-off-by: David Hildenbrand --- arch/powerpc/mm/ptdump/8xx.c | 2 +- arch/powerpc/mm/ptdump/book3s64.c | 2 +- arch/powerpc/mm/ptdump/ptdump.h | 4 ++-- arch/powerpc/mm/ptdump/shared.c | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH v3 05/11] mm/huge_memory: mark PMD mappings of the huge zero folio special

2025-08-11 Thread David Hildenbrand
L when it encounters the huge zero folio. Reviewed-by: Oscar Salvador Signed-off-by: David Hildenbrand --- mm/huge_memory.c | 8 ++-- mm/memory.c | 15 ++- 2 files changed, 16 insertions(+), 7 deletions(-) diff --git a/mm/huge_memory.c b/mm/huge_memory.c index ec89e060

[PATCH v3 04/11] fs/dax: use vmf_insert_folio_pmd() to insert the huge zero folio

2025-08-11 Thread David Hildenbrand
ng to insert a PMD mapping a folio through dax_fault_iter()->vmf_insert_folio_pmd(). So, it sounds reasonable to not handle huge zero folios differently to inserting PMDs mapping folios when there already is something mapped. Reviewed-by: Alistair Popple Reviewed-by: Lorenzo Stoakes Signed-off-

[PATCH v3 02/11] mm/huge_memory: move more common code into insert_pud()

2025-08-11 Thread David Hildenbrand
Let's clean it all further up. No functional change intended. Reviewed-by: Oscar Salvador Reviewed-by: Alistair Popple Reviewed-by: Lorenzo Stoakes Reviewed-by: Wei Yang Signed-off-by: David Hildenbrand --- mm/huge_memory.c | 36 +--- 1 file change

[PATCH v3 03/11] mm/huge_memory: support huge zero folio in vmf_insert_folio_pmd()

2025-08-11 Thread David Hildenbrand
shared zeropage. For now, the huge zero folio is not marked as special yet, although vm_normal_page_pmd() really wants to treat it as special. We'll change that next. Reviewed-by: Oscar Salvador Reviewed-by: Lorenzo Stoakes Reviewed-by: Wei Yang Signed-off-by: David Hildenbrand --- mm/huge_m

[PATCH v3 01/11] mm/huge_memory: move more common code into insert_pmd()

2025-08-11 Thread David Hildenbrand
Let's clean it all further up. No functional change intended. Reviewed-by: Oscar Salvador Reviewed-by: Alistair Popple Reviewed-by: Lorenzo Stoakes Reviewed-by: Wei Yang Signed-off-by: David Hildenbrand --- mm/huge_memory.c | 72 1

Re: [PATCH v2 1/3] mm/huge_memory: add new_order and offset to split_huge_pages*() pr_debug.

2025-08-11 Thread David Hildenbrand
le: %s, page offset: [0x%lx - 0x%lx], new_order: %u, in_folio_offset: %ld\n", +file_path, off_start, off_end, new_order, in_folio_offset); mapping = candidate->f_mapping; min_order = mapping_min_folio_order(mapping); Acked-by: David Hildenbrand -- Cheers, David / dhildenb

Re: [PATCH] virtio_balloon: Remove redundant __GFP_NOWARN

2025-08-07 Thread David Hildenbrand
these redundant flags across subsystems. No functional changes. Signed-off-by: Qianfeng Rong --- Acked-by: David Hildenbrand -- Cheers, David / dhildenb

Re: [PATCH 2/4] mm/huge_memory: move to next folio after folio_split() succeeds.

2025-08-06 Thread David Hildenbrand
ges; Hm, but won't we do another "addr += PAGE_SIZE" in the for loop? -- Cheers, David / dhildenb

Re: [PATCH 1/4] mm/huge_memory: add new_order and offset to split_huge_pages*() pr_debug.

2025-08-06 Thread David Hildenbrand
On 06.08.25 04:20, Zi Yan wrote: They are useful information for debugging split huge page tests. Signed-off-by: Zi Yan --- Acked-by: David Hildenbrand -- Cheers, David / dhildenb

Re: [PATCH] selftests/mm: fix FORCE_READ to read input value correctly.

2025-08-05 Thread David Hildenbrand
uot; (XXX));"") Signed-off-by: Zi Yan --- Ouch, thank! Acked-by: David Hildenbrand -- Cheers, David / dhildenb

Re: [PATCH v3] selftests/mm: pass filename as input param to VM_PFNMAP tests

2025-08-05 Thread David Hildenbrand
nmap'ed file as input: pfnmap -r pfnmap.madvise_disallowed -- randfile.txt TAP version 13 1..1 # Starting 1 tests from 1 test cases. # RUN pfnmap.madvise_disallowed ... # SKIP Invalid file: 'randfile.txt'. Not pfnmap'ed Signe

Re: [PATCH v3 3/7] selftest/mm: Fix ksm_funtional_test failures

2025-08-04 Thread David Hildenbrand
test_prctl_fork(void) child_pid = fork(); if (!child_pid) { + init_global_file_handles(); Would this leave fd in parent as orphan? Probably yes, but only until the child quits, so likely we don't care. -- Cheers, David / dhildenb

Re: [PATCH v3 4/7] mm/selftests: Fix split_huge_page_test failure on systems with 64KB page size

2025-08-04 Thread David Hildenbrand
can factor it into vm_util.h and use it here. That sounds reasonable to me. -- Cheers, David / dhildenb

Re: [PATCH v2] selftests/mm: pass filename as input param to VM_PFNMAP tests

2025-08-04 Thread David Hildenbrand
ething unrelated, like the vdso or something odd like that) We have a helper in vm_util.c that might be useful: __get_smap_entry() We also have a check_vmflag_io() in there. So likely you want to add a helper check_vmflag_pfnmap(). Nothing else jumped at me, except that phys_addr might be better called something like "offset" now. -- Cheers, David / dhildenb

Re: [GIT PULL v2] virtio, vhost: features, fixes

2025-08-01 Thread Dr. David Alan Gilbert
Linus > -- -Open up your eyes, open up your mind, open up your code --- / Dr. David Alan Gilbert| Running GNU/Linux | Happy \ \dave @ treblig.org | | In Hex / \ _|_ http://www.treblig.org |___/

Re: [PATCH] selftests/mm: pass filename as input param to VM_PFNMAP tests

2025-08-01 Thread David Hildenbrand
dev/mem. That doesn't make any sense with what you are doing here. If we are not provided /dev/mem, you should probably try mapping offset 0 of the file. -- Cheers, David / dhildenb

[PATCH RESEND v5 6/7] Input: synaptics-rmi4 - read product ID on aftermarket touch ICs

2025-07-31 Thread David Heidelberg via B4 Relay
Connolly Signed-off-by: David Heidelberg --- drivers/input/rmi4/rmi_f01.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/input/rmi4/rmi_f01.c b/drivers/input/rmi4/rmi_f01.c index 47be64284b25ede8103ada86d6b58fd3a26976bb..2278e9b6a920774b07ec9dd3e452cedc69469be8 100644

[PATCH RESEND v5 5/7] Input: synaptics-rmi4 - don't do unaligned reads in IRQ context

2025-07-31 Thread David Heidelberg via B4 Relay
unaligned address. Signed-off-by: Kaustabh Chakraborty Signed-off-by: Caleb Connolly Signed-off-by: David Heidelberg --- drivers/input/rmi4/rmi_driver.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/drivers/input/rmi4/rmi_driver.c b/drivers/input/rmi4

[PATCH RESEND v5 4/7] Input: synaptics-rmi4 - f55: handle zero electrode count

2025-07-31 Thread David Heidelberg via B4 Relay
nolly Signed-off-by: David Heidelberg --- drivers/input/rmi4/rmi_f55.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/input/rmi4/rmi_f55.c b/drivers/input/rmi4/rmi_f55.c index 488adaca4dd00482cd1106d813b32871092c83a0..776c915b82e72b8a6eb5ec701cce9059c87089c4 100644 --- a/drivers/

[PATCH RESEND v5 7/7] Input: synaptics-rmi4 - support fallback values for PDT descriptor bytes

2025-07-31 Thread David Heidelberg via B4 Relay
IC) rmi4_i2c 12-0020: read 6 bytes at 0x00e3: 0 (2c 23 0d 06 00 00) Signed-off-by: Kaustabh Chakraborty [codeflow adjustments, checkpatch fixes, wording] Signed-off-by: Caleb Connolly Co-developed-by: David Heidelberg Signed-off-by: David Heidelberg --- drivers/input/rmi4/rmi_driver.c | 62

[PATCH RESEND v5 3/7] Input: synaptics-rmi4 - f12: use hardcoded values for aftermarket touch ICs

2025-07-31 Thread David Heidelberg via B4 Relay
t, so these fallback values are offered as an alternative to the error path when register descriptors aren't available. Signed-off-by: Kaustabh Chakraborty [changes for readability / codeflow, checkpatch fixes] Signed-off-by: Caleb Connolly Signed-off-by: David Heidelberg --- drivers/

[PATCH RESEND v5 0/7] Input: synaptics-rmi4 - add quirks for third party touchscreen controllers

2025-07-31 Thread David Heidelberg via B4 Relay
v1: https://lore.kernel.org/r/20230929-caleb-rmi4-quirks-v1-0-cc3c703f0...@linaro.org --- Caleb Connolly (1): Input: synaptics-rmi4 - handle duplicate/unknown PDT entries David Heidelberg (1): dt-bindings: input: syna,rmi4: Document syna,rmi4-s3706b Kaustabh Chakraborty (5): In

[PATCH RESEND v5 1/7] dt-bindings: input: syna,rmi4: Document syna,rmi4-s3706b

2025-07-31 Thread David Heidelberg via B4 Relay
From: David Heidelberg Mostly irrelevant for authentic Synaptics touchscreens, but very important for applying workarounds to cheap TS knockoffs. These knockoffs work well with the downstream driver, and since the user has no way to distinguish them, later in this patch set, we introduce

[PATCH RESEND v5 2/7] Input: synaptics-rmi4 - handle duplicate/unknown PDT entries

2025-07-31 Thread David Heidelberg via B4 Relay
us 6T (original parts): manufacturer: Synaptics, product: S3706B, fw id: 2852315 Co-developed-by: Kaustabh Chakraborty Signed-off-by: Kaustabh Chakraborty Signed-off-by: Caleb Connolly Co-developed-by: David Heidelberg Signed-off-by: David Heidelberg --- drivers/input/rmi4/rmi_driver.c

[RFC PATCH 2/2] kunit: tool: Automatically pick a default architecture if none is specified

2025-07-30 Thread David Gow
g/kunit/kunit.py run` should function out-of-the-box on most non-x86 architectures, assuming qemu is installed. Signed-off-by: David Gow --- tools/testing/kunit/kunit.py | 2 +- tools/testing/kunit/kunit_kernel.py| 43 -- tools/testing/kunit/kunit_tool_te

[RFC PATCH 1/2] kunit: tool: Move qemu architecture dependency checks into a function

2025-07-30 Thread David Gow
esent. Instead, have kunit.py look for a check_dependencies function, and call it if present only when the architecture config is being used. This is necessary for future changes which enumerate or automatically select an architecture. Signed-off-by: David Gow --- tools/testing/kunit/kunit_kern

Re: [PATCH v2 7/9] mm/memory: factor out common code from vm_normal_page_*()

2025-07-30 Thread David Hildenbrand
On 18.07.25 14:43, Lorenzo Stoakes wrote: On Thu, Jul 17, 2025 at 10:03:44PM +0200, David Hildenbrand wrote: On 17.07.25 21:55, Lorenzo Stoakes wrote: On Thu, Jul 17, 2025 at 08:51:51PM +0100, Lorenzo Stoakes wrote: @@ -721,37 +772,21 @@ struct page *vm_normal_page_pmd(struct vm_area_struct

[PATCH] kunit: tool: Accept --raw_output=full as an alias of 'all'

2025-07-29 Thread David Gow
I can never remember whether --raw_output takes 'all' or 'full'. No reason we can't support both. For the record, 'all' is the recommended, documented option. Signed-off-by: David Gow --- tools/testing/kunit/kunit.py | 4 ++-- 1 file changed, 2 insertions(+),

Re: [PATCH] rust: kernel: remove support for unused host `#[test]`s

2025-07-28 Thread David Gow
BVgOS=AKHSfifp0S68K3jgNZAkALBr=7iFb=niryg5wdxj...@mail.gmail.com/ > [1] > Signed-off-by: Miguel Ojeda > --- With my (biased) KUnit hat on, this looks good to me. _Maybe_ it's worth updating Documentation/rust/testing.rst, though it already says these are "mostly used for testin

Re: [PATCH][next] tools/testing/selftests: Fix spelling mistake "unnmap" -> "unmap"

2025-07-23 Thread David Hildenbrand
On 23.07.25 11:50, Colin Ian King wrote: There is a spelling mistake in ksft_test_result_fail messages. Fix them. Signed-off-by: Colin Ian King --- Acked-by: David Hildenbrand -- Cheers, David / dhildenb

Re: [PATCH V9 0/7] Add NUMA mempolicy support for KVM guest-memfd

2025-07-23 Thread David Hildenbrand
On 23.07.25 01:07, Sean Christopherson wrote: On Tue, Jul 22, 2025, David Hildenbrand wrote: On 22.07.25 16:45, Sean Christopherson wrote: On Tue, Jul 22, 2025, David Hildenbrand wrote: Just to clarify: this is based on Fuad's stage 1 and should probably still be tagged "RFC" u

Re: [PATCH V9 0/7] Add NUMA mempolicy support for KVM guest-memfd

2025-07-22 Thread David Hildenbrand
On 22.07.25 16:45, Sean Christopherson wrote: On Tue, Jul 22, 2025, David Hildenbrand wrote: Just to clarify: this is based on Fuad's stage 1 and should probably still be tagged "RFC" until stage-1 is finally upstream. (I was hoping stage-1 would go upstream in 6.17, but I am

Re: [PATCH V9 6/7] KVM: guest_memfd: Enforce NUMA mempolicy using shared policy

2025-07-22 Thread David Hildenbrand
, which are not supported for guest_memfd as it is unmovable. Suggested-by: David Hildenbrand Signed-off-by: Shivank Garg --- Acked-by: David Hildenbrand -- Cheers, David / dhildenb

Re: [PATCH V9 3/7] mm/filemap: Extend __filemap_get_folio() to support NUMA memory policies

2025-07-22 Thread David Hildenbrand
eviewed-by: David Hildenbrand -- Cheers, David / dhildenb

Re: [PATCH V9 2/7] mm/filemap: Add NUMA mempolicy support to filemap_alloc_folio()

2025-07-22 Thread David Hildenbrand
cated NUMA policy specified by VMM. All existing users pass NULL maintaining current behavior. Reviewed-by: Pankaj Gupta Reviewed-by: Vlastimil Babka Signed-off-by: Matthew Wilcox (Oracle) Signed-off-by: Shivank Garg --- Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb

Re: [PATCH V9 1/7] KVM: guest_memfd: Use guest mem inodes instead of anonymous inodes

2025-07-22 Thread David Hildenbrand
+&kvm_gmem_fops); + if (IS_ERR(file)) { + err = PTR_ERR(file); + goto err_put_inode; + } + + file->f_flags |= O_LARGEFILE; + file->private_data = priv; + Nothing else jumped at me. -- Cheers, David / dhildenb

Re: [PATCH V9 0/7] Add NUMA mempolicy support for KVM guest-memfd

2025-07-22 Thread David Hildenbrand
2025 + fs: export anon_inode_make_secure_inode() and fix secretmem LSM bypass was merged with the kvm export EXPORT_SYMBOL_GPL_FOR_MODULES(anon_inode_make_secure_inode, "kvm"); I thought I commented that this is something to done separately and not really "fix&quo

Re: [PATCH 06/14] vdso/gettimeofday: Return bool from clock_gettime() helpers

2025-07-19 Thread David Laight
if (unlikely(!ok)) Do you even need 'ok' at all, just: if (unlikely(!__cvdso_clock_gettime_common(vd, clock, &ts))) > return clock_gettime32_fallback(clock, res); > > - /* For ret == 0 */ > + /* For ok == true */ > res->tv_sec = ts.tv_sec; > res->tv_nsec = ts.tv_nsec; > > - return ret; > + return 0; > } > > static __maybe_unused int David

  1   2   3   4   5   6   7   8   9   10   >