Re: [PATCH 2/2] percpu: pcpu_next_md_free_region: inclusive check for PCPU_BITMAP_BLOCK_BITS

2019-03-04 Thread den...@kernel.org
Hi Peng, On Mon, Mar 04, 2019 at 10:33:55AM +, Peng Fan wrote: > If the block [contig_hint_start, contig_hint_start + contig_hint) > matches block->right_free area, need use "<=", not "<". > > Signed-off-by: Peng Fan > --- > > V1: > Based on https://patchwork.kernel.org/cover/10832459/ ap

Re: [RFC] percpu: decrease pcpu_nr_slots by 1

2019-02-25 Thread den...@kernel.org
On Sun, Feb 24, 2019 at 09:17:08AM +, Peng Fan wrote: > Entry pcpu_slot[pcpu_nr_slots - 2] is wasted with current code logic. > pcpu_nr_slots is calculated with `__pcpu_size_to_slot(size) + 2`. > Take pcpu_unit_size as 1024 for example, __pcpu_size_to_slot will > return max(11 - PCPU_SLOT_BASE_

Re: [PATCH 2/2] percpu: km: no need to consider pcpu_group_offsets[0]

2019-02-25 Thread den...@kernel.org
On Sun, Feb 24, 2019 at 01:13:50PM +, Peng Fan wrote: > percpu-km is used on UP systems which only has one group, > so the group offset will be always 0, there is no need > to subtract pcpu_group_offsets[0] when assigning chunk->base_addr > > Signed-off-by: Peng Fan > --- > mm/percpu-km.c |