[PATCH] vfio/pci: Add missing range check in vfio_pci_mmap

2021-04-12 Thread Christian A. Ehrhardt
When mmaping an extra device region verify that the region index derived from the mmap offset is valid. Fixes: a15b1883fee1 ("vfio_pci: Allow mapping extra regions") Cc: sta...@vger.kernel.org Signed-off-by: Christian A. Ehrhardt --- drivers/vfio/pci/vfio_pci.c | 4 +++- 1 file

Re: [ovs-dev] openvswitch crash on i386

2019-03-05 Thread Christian Ehrhardt
raid :-/ [1]: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1736390 [2]: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1736390/comments/55 > Reverting that commit from 5.0 makes the problem go away. I'm not able to > reproduce the crash on x86_64. > > ...Juerg > ___ > dev mailing list > d...@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev -- Christian Ehrhardt Software Engineer, Ubuntu Server Canonical Ltd

Re: Fix lapic time counter read for periodic mode

2012-11-12 Thread Christian Ehrhardt
hat the proposed patch in my first mail is incomplete, as the mod_64 does not work correctly for negative values. A fixed version is below. regards Christian Signed-off-by: Christian Ehrhardt diff --git a/arch/x86/kvm/lapic.c b/arch/x86/kvm/lapic.c index 43e9fad..ec7242c 100644 --- a/arch/x86/kvm/la

Fix lapic time counter read for periodic mode

2012-11-11 Thread Christian Ehrhardt
use the negative difference unmodified. regards Christian Fix lapic time counter read for periodic mode. Signed-off-by: Christian Ehrhardt diff --git a/arch/x86/kvm/lapic.c b/arch/x86/kvm/lapic.c index 43e9fad..eff902d 100644 --- a/arch/x86/kvm/lapic.c +++ b/arch/x86/kvm/lapic.c

Re: New x86-Setup code breaks HVM-XEN boot

2007-09-03 Thread Christian Ehrhardt
Hi, On Thu, Aug 30, 2007 at 07:49:26AM -0700, H. Peter Anvin wrote: > Christian Ehrhardt wrote: > > > >Note the the xm console command terminates on its own, i.e. the guest > >machine seems to halt and not hang somewhere. > > > >I could verify that the real mod

Re: New x86-Setup code breaks HVM-XEN boot

2007-08-31 Thread Christian Ehrhardt
7], [\047name\047, \047ceh-lin-hvm\047], [\047on_poweroff\047, \047destroy\047], [\047on_reboot\047, \047restart\047], [\047on_crash\047, \047restart\047], [\047image\047, [\047hvm\047, [\047kernel\047, \047/usr/lib/xen-3.0.3-1/boot/hvmloader\047], [\047vcpus\047, 1], [\047boot\047, \047cad\047], [\047se

New x886-Setup code breaks HVM-XEN boot

2007-08-30 Thread Christian Ehrhardt
Hi, I am trying to boot a current 2.6 kernel as a guest under XEN in HVM mode. With linux-2.6.22.(5) as the guest this works fine but current git kernels fail very early in the boot process. The XEN host is a debian kernel with XEN enabled (2.6.18-4-xen-686). The XEN guest is a vanilla kernel fr

Re: [RFC][PATCH 2/5] pagemap: use PAGE_MASK/PAGE_ALIGN()

2007-08-08 Thread Christian Ehrhardt
In linux.kernel, you wrote: > > Use existing macros (PAGE_MASK/PAGE_ALIGN()) instead of > open-coding them. > > Signed-off-by: Dave Hansen <[EMAIL PROTECTED]> > --- > > lxc-dave/fs/proc/task_mmu.c |4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff -puN fs/proc/task_mmu.c~pagem

Re: [PATCH try #3] security: Convert LSM into a static interface

2007-07-19 Thread Christian Ehrhardt
On Thu, Jul 19, 2007 at 09:54:30AM -0700, Arjan van de Ven wrote: > the next step after this patch is to have an option to get rid of all > the function pointer chasing (which is expensive) for the case where you > know you only want one security module (which you then can turn on or > off)... that

Re: [PATCH try #3] security: Convert LSM into a static interface

2007-07-19 Thread Christian Ehrhardt
On Wed, Jul 18, 2007 at 06:35:03PM -0700, Andrew Morton wrote: > On Sat, 14 Jul 2007 12:37:01 -0400 (EDT) > James Morris <[EMAIL PROTECTED]> wrote: > > > Convert LSM into a static interface, as the ability to unload a security > > module is not required by in-tree users and potentially complicates

Undefined behaviour with get_cpu_vendor

2005-08-17 Thread Christian Ehrhardt
Hi, Your Patch at (URL wrapped) http://www.kernel.org/git/?p=linux/kernel/git/torvalds/old-2.6-bkcvs.git; \ a=commit;h=99c6e60afff8a7bc6121aeb847dab27c556cf0c9 introduced an additional Parameter (int early) to get_cpu_vendor. However, the same function is called in arch/i386/ker

Re: all processes waiting in TASK_UNINTERRUPTIBLE state

2001-06-26 Thread Christian Ehrhardt
On Mon, Jun 25, 2001 at 12:05:14PM -0500, Jeff Dike wrote: > [EMAIL PROTECTED] said: > > I am running in to a problem, seemingly a deadlock situation, where > > almost all the processes end up in the TASK_UNINTERRUPTIBLE state. > > All the process eventually stop responding, including login shell,

Re: Long standing bug in alternate stack handling

2001-04-25 Thread Christian Ehrhardt
On Wed, Feb 21, 2001 at 11:02:17PM +0100, Christian Ehrhardt wrote: Hi, [ Sorry for the follow up on my own post ] > If a signal handler is registered with the SA_ONSTACK flag the > kernel will try to execute the signal handler on the alternate > stack even if no such stack is r

Re: BUG: Global FPU corruption in 2.2

2001-04-24 Thread Christian Ehrhardt
On Tue, Apr 24, 2001 at 09:10:07AM -0700, Linus Torvalds wrote: > ptrace only operates on processes that are stopped. So there are no > locking issues - we've synchronized on a much higher level than a > spinlock or semaphore. This is only true for requests other than PTRACE_ATTACH and PTRACE_ATT

Re: BUG: Global FPU corruption in 2.2

2001-04-24 Thread Christian Ehrhardt
nd isn't meant to be a fix for the actual problem. regards Christian Ehrhardt -- THAT'S ALL FOLKS! - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordom

Re: BUG: Global FPU corruption in 2.2

2001-04-23 Thread Christian Ehrhardt
On Thu, Apr 19, 2001 at 11:05:03AM -0500, Victor Zandy wrote: > > We have found that one of our programs can cause system-wide > corruption of the x86 FPU under 2.2.16 and 2.2.17. That is, after we > run this program, the FPU gives bad results to all subsequent > processes. A few comments, not

Long standing bug in alternate stack handling

2001-02-21 Thread Christian Ehrhardt
Hi, I just found this out the hard way: If a signal handler is registered with the SA_ONSTACK flag the kernel will try to execute the signal handler on the alternate stack even if no such stack is registered. This is an explicit violation of Unix98 and probably Posix. Architectures affected in

Serial Console and plam (was: Where are you going with 2.4.x?)

2001-02-13 Thread ehrhardt
On Mon, Feb 12, 2001 at 05:32:39PM +0100, I wrote: > I wrote a little palm app some time ago that can capture serial > console output. If anyone is interested I'll build a tar ball with > sources and binary. It is now availiable at http://www.mathematik.uni-ulm.de/~ehrhardt/seri

Re: Where are you going with 2.4.x?

2001-02-12 Thread Christian Ehrhardt
On Sun, Feb 11, 2001 at 07:13:29PM +0100, David Weinehall wrote: > Considering this is an enterprise-server, you should have a serial-console > to it; this will allow you to log all error-messages. Alternatively > (not as nice, though), is to connect a printer to the parallel-port and > use the pa

Re: Posible Bug at page_alloc.c in the [2.4.0-test11] kernel

2000-12-04 Thread ehrhardt
On Tue, Dec 05, 2000 at 01:04:05AM +0100, Stefan Pfetzing wrote: > Hello, > > I think i possibly foun a Bug in the Linux Kernel 2.4.0-test11. > I patched the kernel with the bttv driver 7.49 but nothing else. > My system was up for 5 1/2 days and than it crashed. > [ page_alloc: BUG at line 84 ]

Re: [PATCH] fix for VM test9-pre7

2000-10-02 Thread ehrhardt
Hi, On Mon, Oct 02, 2000 at 12:42:47AM -0300, Rik van Riel wrote: > --- linux-2.4.0-test9-pre7/fs/buffer.c.orig Sat Sep 30 18:09:18 2000 > +++ linux-2.4.0-test9-pre7/fs/buffer.cMon Oct 2 00:19:41 2000 > @@ -706,7 +706,9 @@ > static void refill_freelist(int size) > { > if (!grow

Re: [PATCH 2.4.0-test8] mm/filemap.c

2000-09-14 Thread Christian Ehrhardt
On Thu, Sep 14, 2000 at 07:05:20PM +0200, Juan J. Quintela wrote: [ Removed linus from cc, he probably knows this ] > > "bill" == Bill Wendling <[EMAIL PROTECTED]> writes: > Linus, please don't apply. > bill> - The `head = &mapping->pages;' statement is useless inside the