throughout the UAPI header.
Eugene Syromiatnikov (2):
bpf: fix alignment of netns_dev/netns_ino fields in
bpf_{map,prog}_info
bpf: enforce usage of __aligned_u64 in the UAPI header
include/uapi/linux/bpf.h | 30 +++---
tools/include/uapi/linux/bpf.h | 30
were added to struct bpf_sock_ops in commit
v4.16-rc1~123^2~33^2~5^2~4, struct bpf_perf_event_value was added
in commit v4.15-rc1~84^2~532^2~3).
Signed-off-by: Eugene Syromiatnikov
---
include/uapi/linux/bpf.h | 22 +++---
tools/include/uapi/linux/bpf.h | 22 +++--
for these fields.
Reported-by: Dmitry V. Levin
Fixes: 52775b33bb507 ("bpf: offload: report device information about
offloaded maps")
Fixes: 675fc275a3a2d ("bpf: offload: report device information for
offloaded programs")
Signed-off-by: Eugene Syromiatnikov
---
include/uapi/l
ed, May 23, 2018 at 02:18:19PM +0200, Eugene Syromiatnikov wrote:
> > > > Some BPF sysctl knobs affect the loading of BPF programs, and during
> > > > system boot/init stages these sysctls are not yet configured.
> > > > A concrete example is systemd, that has impl
On Thu, May 24, 2018 at 04:34:51PM -0700, Alexei Starovoitov wrote:
> On Thu, May 24, 2018 at 09:41:08AM +0200, Jesper Dangaard Brouer wrote:
> > On Wed, 23 May 2018 15:02:45 -0700
> > Alexei Starovoitov wrote:
> >
> > > On Wed, May 23, 2018 at 02:18:19PM +02
Commit-ID: 82489c5fe5f99ca95f708fecae9f2c8aa99398bb
Gitweb: https://git.kernel.org/tip/82489c5fe5f99ca95f708fecae9f2c8aa99398bb
Author: Eugene Syromiatnikov <e...@redhat.com>
AuthorDate: Mon, 21 May 2018 14:34:20 +0200
Committer: Ingo Molnar <mi...@kernel.org>
CommitDate:
Commit-ID: 82489c5fe5f99ca95f708fecae9f2c8aa99398bb
Gitweb: https://git.kernel.org/tip/82489c5fe5f99ca95f708fecae9f2c8aa99398bb
Author: Eugene Syromiatnikov
AuthorDate: Mon, 21 May 2018 14:34:20 +0200
Committer: Ingo Molnar
CommitDate: Fri, 25 May 2018 08:11:11 +0200
perf/core: Wire
, and net.core.bpf_jit_kallsyms.
Eugene Syromiatnikov (3):
bpf: add ability to configure unprivileged BPF via boot-time parameter
bpf: add ability to configure BPF JIT hardening via boot-time
parameter
bpf: add ability to configure BPF JIT kallsyms export at the boot time
Documentation
, and net.core.bpf_jit_kallsyms.
Eugene Syromiatnikov (3):
bpf: add ability to configure unprivileged BPF via boot-time parameter
bpf: add ability to configure BPF JIT hardening via boot-time
parameter
bpf: add ability to configure BPF JIT kallsyms export at the boot time
Documentation
is desirable.
Signed-off-by: Eugene Syromiatnikov <e...@redhat.com>
---
Documentation/admin-guide/kernel-parameters.txt | 8 +++
init/Kconfig| 31 +
kernel/bpf/syscall.c| 16 +
3 files c
is desirable.
Signed-off-by: Eugene Syromiatnikov
---
Documentation/admin-guide/kernel-parameters.txt | 8 +++
init/Kconfig| 31 +
kernel/bpf/syscall.c| 16 +
3 files changed, 55 insertions
-off-by: Eugene Syromiatnikov <e...@redhat.com>
---
Documentation/admin-guide/kernel-parameters.txt | 10 +
init/Kconfig| 30 +
kernel/bpf/core.c | 14
3 files changed, 54 inse
-off-by: Eugene Syromiatnikov
---
Documentation/admin-guide/kernel-parameters.txt | 10 +
init/Kconfig| 30 +
kernel/bpf/core.c | 14
3 files changed, 54 insertions(+)
diff --git
This patch introduces two configuration options,
BPF_JIT_HARDEN_BOOTPARAM and BPF_JIT_HARDEN_BOOTPARAM_VALUE, that allow
configuring the initial value of net.core.bpf_jit_harden sysctl knob,
which is useful for enforcing JIT hardening during the early boot.
Signed-off-by: Eugene Syromiatnikov &l
This patch introduces two configuration options,
BPF_JIT_HARDEN_BOOTPARAM and BPF_JIT_HARDEN_BOOTPARAM_VALUE, that allow
configuring the initial value of net.core.bpf_jit_harden sysctl knob,
which is useful for enforcing JIT hardening during the early boot.
Signed-off-by: Eugene Syromiatnikov
On Mon, May 21, 2018 at 11:58:13AM -0700, Alexei Starovoitov wrote:
> On Mon, May 21, 2018 at 02:29:30PM +0200, Eugene Syromiatnikov wrote:
> > Hello.
> >
> > This patch set adds ability to set default values for
> > kernel.unprivileged_bpf_disab
On Mon, May 21, 2018 at 11:58:13AM -0700, Alexei Starovoitov wrote:
> On Mon, May 21, 2018 at 02:29:30PM +0200, Eugene Syromiatnikov wrote:
> > Hello.
> >
> > This patch set adds ability to set default values for
> > kernel.unprivileged_bpf_disab
argument of _IO* macros was honored).
* kernel/events/core.c (perf_compat_ioctl): Add
_IOC_NR(PERF_EVENT_IOC_QUERY_BPF) and _IOC_NR(PERF_EVENT_IOC_MODIFY_ATTRIBUTES)
to the switch statement.
Signed-off-by: Eugene Syromiatnikov <e...@redhat.com>
---
kernel/events/core.c | 2 ++
1 file chan
argument of _IO* macros was honored).
* kernel/events/core.c (perf_compat_ioctl): Add
_IOC_NR(PERF_EVENT_IOC_QUERY_BPF) and _IOC_NR(PERF_EVENT_IOC_MODIFY_ATTRIBUTES)
to the switch statement.
Signed-off-by: Eugene Syromiatnikov
---
kernel/events/core.c | 2 ++
1 file changed, 2 insertions(+)
diff --git
-off-by: Eugene Syromiatnikov <e...@redhat.com>
---
Documentation/admin-guide/kernel-parameters.txt | 10 +
init/Kconfig| 30 +
kernel/bpf/core.c | 14
3 files changed, 54 inse
-off-by: Eugene Syromiatnikov
---
Documentation/admin-guide/kernel-parameters.txt | 10 +
init/Kconfig| 30 +
kernel/bpf/core.c | 14
3 files changed, 54 insertions(+)
diff --git
This patch introduces two configuration options,
BPF_JIT_HARDEN_BOOTPARAM and BPF_JIT_HARDEN_BOOTPARAM_VALUE, that allow
configuring the initial value of net.core.bpf_jit_harden sysctl knob,
which is useful for enforcing JIT hardening during the early boot.
Signed-off-by: Eugene Syromiatnikov &l
This patch introduces two configuration options,
BPF_JIT_HARDEN_BOOTPARAM and BPF_JIT_HARDEN_BOOTPARAM_VALUE, that allow
configuring the initial value of net.core.bpf_jit_harden sysctl knob,
which is useful for enforcing JIT hardening during the early boot.
Signed-off-by: Eugene Syromiatnikov
is desirable.
Signed-off-by: Eugene Syromiatnikov <e...@redhat.com>
---
Documentation/admin-guide/kernel-parameters.txt | 8 +++
init/Kconfig| 31 +
kernel/bpf/syscall.c| 16 +
3 files c
is desirable.
Signed-off-by: Eugene Syromiatnikov
---
Documentation/admin-guide/kernel-parameters.txt | 8 +++
init/Kconfig| 31 +
kernel/bpf/syscall.c| 16 +
3 files changed, 55 insertions
Hello.
This patch set adds ability to set default values for
kernel.unprivileged_bpf_disable, net.core.bpf_jit_harden,
net.core.bpf_jit_kallsyms sysctl knobs as well as option to override
them via a boot-time kernel parameter.
Eugene Syromiatnikov (3):
bpf: add ability to configure
Hello.
This patch set adds ability to set default values for
kernel.unprivileged_bpf_disable, net.core.bpf_jit_harden,
net.core.bpf_jit_kallsyms sysctl knobs as well as option to override
them via a boot-time kernel parameter.
Eugene Syromiatnikov (3):
bpf: add ability to configure
On Wed, May 16, 2018 at 11:49:33AM -0600, Jason Gunthorpe wrote:
> On Wed, May 16, 2018 at 07:39:08PM +0200, Eugene Syromiatnikov wrote:
> > On Fri, Apr 06, 2018 at 10:05:41AM -0600, Jason Gunthorpe wrote:
> > > RDMA: Change all uapi headers to use __aligned_u64 instead
On Wed, May 16, 2018 at 11:49:33AM -0600, Jason Gunthorpe wrote:
> On Wed, May 16, 2018 at 07:39:08PM +0200, Eugene Syromiatnikov wrote:
> > On Fri, Apr 06, 2018 at 10:05:41AM -0600, Jason Gunthorpe wrote:
> > > RDMA: Change all uapi headers to use __aligned_u64 instead
On Fri, Apr 06, 2018 at 10:05:41AM -0600, Jason Gunthorpe wrote:
> RDMA: Change all uapi headers to use __aligned_u64 instead of __u64
Looks like this change changed the size of struct hfi1_ctxt_info and the
value of HFI1_IOCTL_CTXT_INFO ioctl number as a result.
> IB/uverbs: Extend
On Fri, Apr 06, 2018 at 10:05:41AM -0600, Jason Gunthorpe wrote:
> RDMA: Change all uapi headers to use __aligned_u64 instead of __u64
Looks like this change changed the size of struct hfi1_ctxt_info and the
value of HFI1_IOCTL_CTXT_INFO ioctl number as a result.
> IB/uverbs: Extend
On Tue, Mar 06, 2018 at 01:11:03AM -0600, Eric W. Biederman wrote:
> Linus,
>
> Please pull the siginfo-linus branch from the git tree:
>
>git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace.git
> siginfo-linus
>
>HEAD: f6a015498dcaee72f80283cb7873d88deb07129c
On Tue, Mar 06, 2018 at 01:11:03AM -0600, Eric W. Biederman wrote:
> Linus,
>
> Please pull the siginfo-linus branch from the git tree:
>
>git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace.git
> siginfo-linus
>
>HEAD: f6a015498dcaee72f80283cb7873d88deb07129c
On Sun, Dec 03, 2017 at 11:22:56AM -0500, Linus Torvalds wrote:
>
> Linus Torvalds (6):
> Rename superblock flags (MS_xyz -> SB_xyz)
This commit, while claims that it changes internal flags, also touches
an UAPI header (include/uapi/linux/bfs_fs.h), specifically, the macro
BFS_UNCLEAN. I
On Sun, Dec 03, 2017 at 11:22:56AM -0500, Linus Torvalds wrote:
>
> Linus Torvalds (6):
> Rename superblock flags (MS_xyz -> SB_xyz)
This commit, while claims that it changes internal flags, also touches
an UAPI header (include/uapi/linux/bfs_fs.h), specifically, the macro
BFS_UNCLEAN. I
On Tue, Nov 14, 2017 at 07:00:19PM -0700, Tycho Andersen wrote:
> With the new SECCOMP_FILTER_FLAG_LOG, we need to be able to extract these
> flags for checkpoint restore, since they describe the state of a filter.
>
> So, let's add PTRACE_SECCOMP_GET_METADATA, similar to ..._GET_FILTER, which
>
On Tue, Nov 14, 2017 at 07:00:19PM -0700, Tycho Andersen wrote:
> With the new SECCOMP_FILTER_FLAG_LOG, we need to be able to extract these
> flags for checkpoint restore, since they describe the state of a filter.
>
> So, let's add PTRACE_SECCOMP_GET_METADATA, similar to ..._GET_FILTER, which
>
).
Discovered by strace test suite.
Cc: sta...@vger.kernel.org
Signed-off-by: Eugene Syromiatnikov <e...@redhat.com>
---
arch/s390/kernel/compat_linux.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/s390/kernel/compat_linux.c b/arch/s390/kernel/compat_linux.c
index f
).
Discovered by strace test suite.
Cc: sta...@vger.kernel.org
Signed-off-by: Eugene Syromiatnikov
---
arch/s390/kernel/compat_linux.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/s390/kernel/compat_linux.c b/arch/s390/kernel/compat_linux.c
index f04db37..9ba2ab2 100644
For some reason, the implementation of these two 16-bit ID system calls
used cast instead of low2highgid/low2highuid macros for converting [GU]IDs,
which leads to incorrect handling of value of -1 (which ought to be
considered invalid).
Discovered by strace test suite.
Signed-off-by: Eugene
For some reason, the implementation of these two 16-bit ID system calls
used cast instead of low2highgid/low2highuid macros for converting [GU]IDs,
which leads to incorrect handling of value of -1 (which ought to be
considered invalid).
Discovered by strace test suite.
Signed-off-by: Eugene
On Mon, Apr 24, 2017 at 06:39:28PM +0300, Cyrill Gorcunov wrote:
> With current epoll architecture target files are addressed
> with file_struct and file descriptor number, where the last
> is not unique. Moreover files can be transferred from another
> process via unix socket, added into queue
On Mon, Apr 24, 2017 at 06:39:28PM +0300, Cyrill Gorcunov wrote:
> With current epoll architecture target files are addressed
> with file_struct and file descriptor number, where the last
> is not unique. Moreover files can be transferred from another
> process via unix socket, added into queue
efinition of struct seccomp_data
--
Eugene Syromyatnikov
mailto:evg...@gmail.com
xmpp:esyr@jabber.{ru|org}
ata
--
Eugene Syromyatnikov
mailto:evg...@gmail.com
xmpp:esyr@jabber.{ru|org}
3.
Signed-off-by: Eugene Syromiatnikov <e...@redhat.com>
---
arch/alpha/include/uapi/asm/termbits.h | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/arch/alpha/include/uapi/asm/termbits.h
b/arch/alpha/include/uapi/asm/termbits.h
index 879dd35..5510770 100644
--- a/ar
3.
Signed-off-by: Eugene Syromiatnikov
---
arch/alpha/include/uapi/asm/termbits.h | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/arch/alpha/include/uapi/asm/termbits.h
b/arch/alpha/include/uapi/asm/termbits.h
index 879dd35..5510770 100644
--- a/arch/alpha/includ
On Wed, Aug 30, 2017 at 10:25:01PM +0200, Arnd Bergmann wrote:
> >> diff --git a/include/uapi/linux/dvb/video.h
> >> b/include/uapi/linux/dvb/video.h
> >> index d3d14a59d2d5..6c7f9298d7c2 100644
> >> --- a/include/uapi/linux/dvb/video.h
> >> +++ b/include/uapi/linux/dvb/video.h
> >> @@ -135,7
On Wed, Aug 30, 2017 at 10:25:01PM +0200, Arnd Bergmann wrote:
> >> diff --git a/include/uapi/linux/dvb/video.h
> >> b/include/uapi/linux/dvb/video.h
> >> index d3d14a59d2d5..6c7f9298d7c2 100644
> >> --- a/include/uapi/linux/dvb/video.h
> >> +++ b/include/uapi/linux/dvb/video.h
> >> @@ -135,7
On Tue, Sep 15, 2015 at 05:49:04PM +0200, Arnd Bergmann wrote:
> 'struct video_event' is used for the VIDEO_GET_EVENT ioctl, implemented
> by drivers/media/pci/ivtv/ivtv-ioctl.c and
> drivers/media/pci/ttpci/av7110_av.c. The structure contains a 'time_t',
> which will be redefined in the future to
On Tue, Sep 15, 2015 at 05:49:04PM +0200, Arnd Bergmann wrote:
> 'struct video_event' is used for the VIDEO_GET_EVENT ioctl, implemented
> by drivers/media/pci/ivtv/ivtv-ioctl.c and
> drivers/media/pci/ttpci/av7110_av.c. The structure contains a 'time_t',
> which will be redefined in the future to
Rework smelling code (goto inside compound statement). Perhaps this is
legacy. Anyway such code is not appropriate for Linux kernel.
Signed-off-by: Eugene Korenevsky <ekorenev...@gmail.com>
---
Changes in v7: rename hub_check_descriptor_sanity -> hub_descriptor_is_sane
Changes in
Rework smelling code (goto inside compound statement). Perhaps this is
legacy. Anyway such code is not appropriate for Linux kernel.
Signed-off-by: Eugene Korenevsky
---
Changes in v7: rename hub_check_descriptor_sanity -> hub_descriptor_is_sane
Changes in v6: more pedantic conversion from `
Please inform whether or not the latest Bluez 5.45 supports Bluetooth
3.0+HS 24Mbps? I did some testing using the wilink 8 and only obtain
speeds of up to 156Kbps. Thanks. Please CC my email address when
responding.
Thanks,
Eugene
Please inform whether or not the latest Bluez 5.45 supports Bluetooth
3.0+HS 24Mbps? I did some testing using the wilink 8 and only obtain
speeds of up to 156Kbps. Thanks. Please CC my email address when
responding.
Thanks,
Eugene
Commit-ID: 540f4c0e894f7e46a66dfa424b16424cbdc12c38
Gitweb: http://git.kernel.org/tip/540f4c0e894f7e46a66dfa424b16424cbdc12c38
Author: Cohen, Eugene <eug...@hp.com>
AuthorDate: Tue, 4 Apr 2017 16:27:43 +0100
Committer: Ingo Molnar <mi...@kernel.org>
CommitDate: Wed, 5 Apr 2
Commit-ID: 540f4c0e894f7e46a66dfa424b16424cbdc12c38
Gitweb: http://git.kernel.org/tip/540f4c0e894f7e46a66dfa424b16424cbdc12c38
Author: Cohen, Eugene
AuthorDate: Tue, 4 Apr 2017 16:27:43 +0100
Committer: Ingo Molnar
CommitDate: Wed, 5 Apr 2017 09:20:18 +0200
efi/libstub: Skip GOP
On Wed, Mar 29, 2017 at 08:56:16PM +0200, Clemens Ladisch wrote:
> Eugene Ganeev wrote:
> > My Xonar DG SI card is showing up in lspci but no module is loaded for
> > it.
> >
> > The patch just adds a new value with card's PCI ID to oxygen_ids array.
>
> I
On Wed, Mar 29, 2017 at 08:56:16PM +0200, Clemens Ladisch wrote:
> Eugene Ganeev wrote:
> > My Xonar DG SI card is showing up in lspci but no module is loaded for
> > it.
> >
> > The patch just adds a new value with card's PCI ID to oxygen_ids array.
>
> I
My Xonar DG SI card is showing up in lspci but no module is loaded for
it.
The patch just adds a new value with card's PCI ID to oxygen_ids array.
Signed-off-by: Eugene Ganeev <easymodo...@gmail.com>
---
sound/pci/oxygen/oxygen.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sou
My Xonar DG SI card is showing up in lspci but no module is loaded for
it.
The patch just adds a new value with card's PCI ID to oxygen_ids array.
Signed-off-by: Eugene Ganeev
---
sound/pci/oxygen/oxygen.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/pci/oxygen/oxygen.c b/sound
> case PR_GET_FP_MODE:
> error = GET_FP_MODE(me);
> break;
> +#ifdef CONFIG_TASK_ISOLATION
> + case PR_SET_TASK_ISOLATION:
> + error = task_isolation_set(arg2);
> + break;
> + case PR_GET_TASK_ISOLATION:
> + error =
> case PR_GET_FP_MODE:
> error = GET_FP_MODE(me);
> break;
> +#ifdef CONFIG_TASK_ISOLATION
> + case PR_SET_TASK_ISOLATION:
> + error = task_isolation_set(arg2);
> + break;
> + case PR_GET_TASK_ISOLATION:
> + error =
http://www.kernel.org/doc/man-pages/
> Linux/UNIX System Programming Training: http://man7.org/training/
--
Eugene Syromyatnikov
mailto:evg...@gmail.com
xmpp:esyr@jabber.{ru|org}
gt; Since 4.8, that is.
>
> Which commit was that? I could not find it?
13100a72f40f5748a04017e0ab3df4cf27c809ef, v4.7-rc1~124^2~2^2~2^2~1
>
> --
> Michael Kerrisk
> Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
> Linux/UNIX System Programming Training: http://man
fitted with comments
regarding necessity of these guards useful only in kernel space?
--
Eugene Syromyatnikov
mailto:evg...@gmail.com
xmpp:esyr@jabber.{ru|org}
fitted with comments
regarding necessity of these guards useful only in kernel space?
--
Eugene Syromyatnikov
mailto:evg...@gmail.com
xmpp:esyr@jabber.{ru|org}
Rework smelling code (goto inside compound statement). Perhaps this is
legacy. Anyway such code is not appropriate for Linux kernel.
Signed-off-by: Eugene Korenevsky <ekorenev...@gmail.com>
---
Changes in v6: more pedantic conversion from `int` to `bool`; fix comment
Changes in v5: make
Rework smelling code (goto inside compound statement). Perhaps this is
legacy. Anyway such code is not appropriate for Linux kernel.
Signed-off-by: Eugene Korenevsky
---
Changes in v6: more pedantic conversion from `int` to `bool`; fix comment
Changes in v5: make `bool` a return type
false, last statement is `return
true`).
--
Eugene
false, last statement is `return
true`).
--
Eugene
Rework smelling code (goto inside compound statement). Perhaps this is
legacy. Anyway such code is not appropriate for Linux kernel.
Signed-off-by: Eugene Korenevsky <ekorenev...@gmail.com>
---
Changes in v5: make `bool` a return type of `hub_check_descriptor_sanity()`
Changes in v4: fi
Rework smelling code (goto inside compound statement). Perhaps this is
legacy. Anyway such code is not appropriate for Linux kernel.
Signed-off-by: Eugene Korenevsky
---
Changes in v5: make `bool` a return type of `hub_check_descriptor_sanity()`
Changes in v4: fix typo
Changes in v3: extract
-off-by: Eugene Korenevsky <ekorenev...@gmail.com>
---
drivers/usb/core/hub.c | 35 ++-
1 file changed, 18 insertions(+), 17 deletions(-)
diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
index cbb1467..b770c8d 100644
--- a/drivers/usb/core/hub.c
-off-by: Eugene Korenevsky
---
drivers/usb/core/hub.c | 35 ++-
1 file changed, 18 insertions(+), 17 deletions(-)
diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
index cbb1467..b770c8d 100644
--- a/drivers/usb/core/hub.c
+++ b/drivers/usb/core/hub.c
Rework smelling code (goto inside compound statement). Perhaps this is
legacy. Anyway such code is not appropriate for Linux kernel.
Changes since v2: extract the code to static function
Changes since v1: fix spaces instead of tab, add missing 'Signed-off-by'
Signed-off-by: Eugene Korenevsky
Rework smelling code (goto inside compound statement). Perhaps this is
legacy. Anyway such code is not appropriate for Linux kernel.
Changes since v2: extract the code to static function
Changes since v1: fix spaces instead of tab, add missing 'Signed-off-by'
Signed-off-by: Eugene Korenevsky
Minor optimization: move initialization immediately before usage.
This gives a chance for more accurate register allocation by the compiler.
Signed-off-by: Eugene Korenevsky <ekorenev...@gmail.com>
---
drivers/usb/core/hub.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
Minor optimization: move initialization immediately before usage.
This gives a chance for more accurate register allocation by the compiler.
Signed-off-by: Eugene Korenevsky
---
drivers/usb/core/hub.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/core/hub.c b
Rework smelling code (goto inside compound statement). Perhaps this is
legacy. Anyway such code is not appropriate for Linux kernel.
Signed-off-by: Eugene Korenevsky <ekorenev...@gmail.com>
---
drivers/usb/core/hub.c | 33 -
1 file changed, 16 insertions(
Rework smelling code (goto inside compound statement). Perhaps this is
legacy. Anyway such code is not appropriate for Linux kernel.
Signed-off-by: Eugene Korenevsky
---
drivers/usb/core/hub.c | 33 -
1 file changed, 16 insertions(+), 17 deletions(-)
diff --git
On Mon, Nov 07, 2016 at 10:09:17AM +0100, Greg Kroah-Hartman wrote:
> > Rework smelling code (goto inside compound statement). Perhaps this is
> > legacy.
> > Anyway such code is not appropriate for Linux kernel.
> >
> > Signed-off-by: Eugene Kor
On Mon, Nov 07, 2016 at 10:09:17AM +0100, Greg Kroah-Hartman wrote:
> > Rework smelling code (goto inside compound statement). Perhaps this is
> > legacy.
> > Anyway such code is not appropriate for Linux kernel.
> >
> > Signed-off-by: Eugene Korenevsky
> >
Rework smelling code (goto inside compound statement). Perhaps this is legacy.
Anyway such code is not appropriate for Linux kernel.
Signed-off-by: Eugene Korenevsky <ekorenev...@gmail.com>
---
drivers/usb/core/hub.c | 24 +++-
1 file changed, 11 insertions(+), 13 del
Rework smelling code (goto inside compound statement). Perhaps this is legacy.
Anyway such code is not appropriate for Linux kernel.
Signed-off-by: Eugene Korenevsky
---
drivers/usb/core/hub.c | 24 +++-
1 file changed, 11 insertions(+), 13 deletions(-)
diff --git a/drivers
Rework smelling code (goto inside compound statement). Perhaps this is legacy.
Anyway such code is not appropriate for Linux kernel.
---
drivers/usb/core/hub.c | 24 +++-
1 file changed, 11 insertions(+), 13 deletions(-)
diff --git a/drivers/usb/core/hub.c
Rework smelling code (goto inside compound statement). Perhaps this is legacy.
Anyway such code is not appropriate for Linux kernel.
---
drivers/usb/core/hub.c | 24 +++-
1 file changed, 11 insertions(+), 13 deletions(-)
diff --git a/drivers/usb/core/hub.c
An obvious cleanup. "if" statement does nothing and should be removed.
---
arch/x86/boot/compressed/eboot.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/arch/x86/boot/compressed/eboot.c b/arch/x86/boot/compressed/eboot.c
index cc69e37..202f2aa 100644
---
An obvious cleanup. "if" statement does nothing and should be removed.
---
arch/x86/boot/compressed/eboot.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/arch/x86/boot/compressed/eboot.c b/arch/x86/boot/compressed/eboot.c
index cc69e37..202f2aa 100644
---
- }
> > + if (*e820ext)
> > + return EFI_INVALID_PARAMETER;
> >
> > status = efi_call_early(allocate_pool, EFI_LOADER_DATA,
> > size, (void **)e820ext);
> > --
--
Eugene
- }
> > + if (*e820ext)
> > + return EFI_INVALID_PARAMETER;
> >
> > status = efi_call_early(allocate_pool, EFI_LOADER_DATA,
> > size, (void **)e820ext);
> > --
--
Eugene
Applied your notice. Sent v2 patch.
--
Eugene
Applied your notice. Sent v2 patch.
--
Eugene
*e820ext is always NULL in 'alloc_e820ext()' (see the code of 'exit_boot()').
Without loss of generality we can replace freeing with returning
EFI_INVALID_PARAMETER. So if the caller would ever incorrectly pass non-NULL
*e820ext, he will obtain a returned error code.
---
*e820ext is always NULL in 'alloc_e820ext()' (see the code of 'exit_boot()').
Without loss of generality we can replace freeing with returning
EFI_INVALID_PARAMETER. So if the caller would ever incorrectly pass non-NULL
*e820ext, he will obtain a returned error code.
---
*e820ext is always NULL in 'alloc_e820ext()' (see the code of 'exit_boot()').
Therefore the 'if' condition is always false and the entire 'if' statement is
pointless. Remove it.
---
arch/x86/boot/compressed/eboot.c | 6 --
1 file changed, 6 deletions(-)
diff --git
*e820ext is always NULL in 'alloc_e820ext()' (see the code of 'exit_boot()').
Therefore the 'if' condition is always false and the entire 'if' statement is
pointless. Remove it.
---
arch/x86/boot/compressed/eboot.c | 6 --
1 file changed, 6 deletions(-)
diff --git
01.09.2015 17:05, Eugene Shatokhin пишет:
The race may happen when a device (e.g. YOTA 4G LTE Modem) is
unplugged while the system is downloading a large file from the Net.
Hardware breakpoints and Kprobes with delays were used to confirm that
the race does actually happen.
The race
01.09.2015 17:05, Eugene Shatokhin пишет:
The race may happen when a device (e.g. YOTA 4G LTE Modem) is
unplugged while the system is downloading a large file from the Net.
Hardware breakpoints and Kprobes with delays were used to confirm that
the race does actually happen.
The race
e dev->done
queue still has an item.
Locking in defer_bh() and usbnet_terminate_urbs() was revisited to avoid
this race.
Signed-off-by: Eugene Shatokhin
---
drivers/net/usb/usbnet.c | 39 ---
1 file changed, 28 insertions(+), 11 deletions(-)
diff --git a
101 - 200 of 554 matches
Mail list logo
