[PATCH v3 0/2] of: Add unit tests for applying overlays

2017-04-25 Thread frowand . list
From: Frank Rowand Existing overlay unit tests examine individual pieces of the overlay code. The new tests target the entire process of applying an overlay. Changes from v2: - of_private.h: move __unflatten_device_tree() outside #ifdef CONFIG_OF_UNITTEST - unittest.c: move overlay

[PATCH v3 1/2] of: support dtc compiler flags for overlays

2017-04-25 Thread frowand . list
From: Frank Rowand The dtc compiler version that adds initial support was available in 4.11-rc1. Add the ability to set the dtc compiler flags needed by overlays. Signed-off-by: Frank Rowand --- scripts/Makefile.lib | 2 ++ 1 file changed, 2

[PATCH v3 1/2] of: support dtc compiler flags for overlays

2017-04-25 Thread frowand . list
From: Frank Rowand The dtc compiler version that adds initial support was available in 4.11-rc1. Add the ability to set the dtc compiler flags needed by overlays. Signed-off-by: Frank Rowand --- scripts/Makefile.lib | 2 ++ 1 file changed, 2 insertions(+) diff --git a/scripts/Makefile.lib

[PATCH v3 2/2] of: Add unit tests for applying overlays

2017-04-25 Thread frowand . list
From: Frank Rowand Existing overlay unit tests examine individual pieces of the overlay code. The new tests target the entire process of applying an overlay. Signed-off-by: Frank Rowand --- There are checkpatch warnings. I have reviewed them and

[PATCH v3 2/2] of: Add unit tests for applying overlays

2017-04-25 Thread frowand . list
From: Frank Rowand Existing overlay unit tests examine individual pieces of the overlay code. The new tests target the entire process of applying an overlay. Signed-off-by: Frank Rowand --- There are checkpatch warnings. I have reviewed them and feel they can be ignored. drivers/of/fdt.c

[PATCH v3 4/4] of: detect invalid phandle in overlay

2017-04-25 Thread frowand . list
From: Frank Rowand Overlays are not allowed to modify phandle values of previously existing nodes because there is no information available to allow fixup up properties that use the previously existing phandle. Signed-off-by: Frank Rowand ---

[PATCH v3 4/4] of: detect invalid phandle in overlay

2017-04-25 Thread frowand . list
From: Frank Rowand Overlays are not allowed to modify phandle values of previously existing nodes because there is no information available to allow fixup up properties that use the previously existing phandle. Signed-off-by: Frank Rowand --- drivers/of/overlay.c | 4 1 file changed, 4

[PATCH v3 2/4] of: make __of_attach_node() static

2017-04-25 Thread frowand . list
From: Frank Rowand __of_attach_node() is not used outside of drivers/of/dynamic.c. Make it static and remove it from drivers/of/of_private.h. Signed-off-by: Frank Rowand --- drivers/of/dynamic.c| 2 +- drivers/of/of_private.h | 1 - 2 files

[PATCH v3 2/4] of: make __of_attach_node() static

2017-04-25 Thread frowand . list
From: Frank Rowand __of_attach_node() is not used outside of drivers/of/dynamic.c. Make it static and remove it from drivers/of/of_private.h. Signed-off-by: Frank Rowand --- drivers/of/dynamic.c| 2 +- drivers/of/of_private.h | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff

[PATCH v3 3/4] of: be consistent in form of file mode

2017-04-25 Thread frowand . list
From: Frank Rowand checkpatch whined about using S_IRUGO instead of octal equivalent when adding phandle sysfs code, so used octal in that patch. Change other instances of the S_* constants in the same file to the octal form. Signed-off-by: Frank Rowand

[PATCH v3 3/4] of: be consistent in form of file mode

2017-04-25 Thread frowand . list
From: Frank Rowand checkpatch whined about using S_IRUGO instead of octal equivalent when adding phandle sysfs code, so used octal in that patch. Change other instances of the S_* constants in the same file to the octal form. Signed-off-by: Frank Rowand --- drivers/of/base.c | 2 +- 1 file

[PATCH v3 0/4] of: remove *phandle properties from expanded device tree

2017-04-25 Thread frowand . list
From: Frank Rowand Remove "phandle" and "linux,phandle" properties from the internal device tree. The phandle will still be in the struct device_node phandle field. This is to resolve the issue found by Stephen Boyd [1] when he changed the type of struct property.value

[PATCH v3 0/4] of: remove *phandle properties from expanded device tree

2017-04-25 Thread frowand . list
From: Frank Rowand Remove "phandle" and "linux,phandle" properties from the internal device tree. The phandle will still be in the struct device_node phandle field. This is to resolve the issue found by Stephen Boyd [1] when he changed the type of struct property.value from void * to const

[PATCH v3 1/4] of: remove *phandle properties from expanded device tree

2017-04-25 Thread frowand . list
From: Frank Rowand Remove "phandle", "linux,phandle", and "ibm,phandle" properties from the internal device tree. The phandle will still be in the struct device_node phandle field. This is to resolve the issue found by Stephen Boyd [1] when he changed the type of struct

[PATCH v3 1/4] of: remove *phandle properties from expanded device tree

2017-04-25 Thread frowand . list
From: Frank Rowand Remove "phandle", "linux,phandle", and "ibm,phandle" properties from the internal device tree. The phandle will still be in the struct device_node phandle field. This is to resolve the issue found by Stephen Boyd [1] when he changed the type of struct property.value from

[PATCH v2 1/4] of: remove *phandle properties from expanded device tree

2017-04-25 Thread frowand . list
From: Frank Rowand Remove "phandle", "linux,phandle", and "ibm,phandle" properties from the internal device tree. The phandle will still be in the struct device_node phandle field. This is to resolve the issue found by Stephen Boyd [1] when he changed the type of struct

[PATCH v2 4/4] of: detect invalid phandle in overlay

2017-04-25 Thread frowand . list
From: Frank Rowand Overlays are not allowed to modify phandle values of previously existing nodes because there is no information available to allow fixup up properties that use the previously existing phandle. Signed-off-by: Frank Rowand ---

[PATCH v2 1/4] of: remove *phandle properties from expanded device tree

2017-04-25 Thread frowand . list
From: Frank Rowand Remove "phandle", "linux,phandle", and "ibm,phandle" properties from the internal device tree. The phandle will still be in the struct device_node phandle field. This is to resolve the issue found by Stephen Boyd [1] when he changed the type of struct property.value from

[PATCH v2 4/4] of: detect invalid phandle in overlay

2017-04-25 Thread frowand . list
From: Frank Rowand Overlays are not allowed to modify phandle values of previously existing nodes because there is no information available to allow fixup up properties that use the previously existing phandle. Signed-off-by: Frank Rowand --- drivers/of/overlay.c | 4 1 file changed, 4

[PATCH v2 2/4] of: make __of_attach_node() static

2017-04-25 Thread frowand . list
From: Frank Rowand __of_attach_node() is not used outside of drivers/of/dynamic.c. Make it static and remove it from drivers/of/of_private.h. Signed-off-by: Frank Rowand --- drivers/of/dynamic.c| 2 +- drivers/of/of_private.h | 1 - 2 files

[PATCH v2 0/4] of: remove *phandle properties from expanded device tree

2017-04-25 Thread frowand . list
From: Frank Rowand Remove "phandle" and "linux,phandle" properties from the internal device tree. The phandle will still be in the struct device_node phandle field. This is to resolve the issue found by Stephen Boyd [1] when he changed the type of struct property.value

[PATCH v2 2/4] of: make __of_attach_node() static

2017-04-25 Thread frowand . list
From: Frank Rowand __of_attach_node() is not used outside of drivers/of/dynamic.c. Make it static and remove it from drivers/of/of_private.h. Signed-off-by: Frank Rowand --- drivers/of/dynamic.c| 2 +- drivers/of/of_private.h | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff

[PATCH v2 0/4] of: remove *phandle properties from expanded device tree

2017-04-25 Thread frowand . list
From: Frank Rowand Remove "phandle" and "linux,phandle" properties from the internal device tree. The phandle will still be in the struct device_node phandle field. This is to resolve the issue found by Stephen Boyd [1] when he changed the type of struct property.value from void * to const

[PATCH v2 3/4] of: be consistent in form of file mode

2017-04-25 Thread frowand . list
From: Frank Rowand checkpatch whined about using S_IRUGO instead of octal equivalent when adding phandle sysfs code, so used octal in that patch. Change other instances of the S_* constants in the same file to the octal form. Signed-off-by: Frank Rowand

[PATCH v2 3/4] of: be consistent in form of file mode

2017-04-25 Thread frowand . list
From: Frank Rowand checkpatch whined about using S_IRUGO instead of octal equivalent when adding phandle sysfs code, so used octal in that patch. Change other instances of the S_* constants in the same file to the octal form. Signed-off-by: Frank Rowand --- drivers/of/base.c | 2 +- 1 file

[PATCH v2 1/2] of: support dtc compiler flags for overlays

2017-04-24 Thread frowand . list
From: Frank Rowand The dtc compiler version that adds initial support was available in 4.11-rc1. Add the ability to set the dtc compiler flags needed by overlays. Signed-off-by: Frank Rowand --- scripts/Makefile.lib | 2 ++ 1 file changed, 2

[PATCH v2 1/2] of: support dtc compiler flags for overlays

2017-04-24 Thread frowand . list
From: Frank Rowand The dtc compiler version that adds initial support was available in 4.11-rc1. Add the ability to set the dtc compiler flags needed by overlays. Signed-off-by: Frank Rowand --- scripts/Makefile.lib | 2 ++ 1 file changed, 2 insertions(+) diff --git a/scripts/Makefile.lib

[PATCH v2 0/2] of: Add unit tests for applying overlays

2017-04-24 Thread frowand . list
From: Frank Rowand Existing overlay unit tests examine individual pieces of the overlay code. The new tests target the entire process of applying an overlay. Changes from v1: - Move overlay base dtb unflattening into unittest.c. Call from fdt.c. - Clarify file and

[PATCH v2 2/2] of: Add unit tests for applying overlays

2017-04-24 Thread frowand . list
From: Frank Rowand Existing overlay unit tests examine individual pieces of the overlay code. The new tests target the entire process of applying an overlay. Signed-off-by: Frank Rowand --- There are checkpatch warnings. I have reviewed them and

[PATCH v2 0/2] of: Add unit tests for applying overlays

2017-04-24 Thread frowand . list
From: Frank Rowand Existing overlay unit tests examine individual pieces of the overlay code. The new tests target the entire process of applying an overlay. Changes from v1: - Move overlay base dtb unflattening into unittest.c. Call from fdt.c. - Clarify file and variable names,

[PATCH v2 2/2] of: Add unit tests for applying overlays

2017-04-24 Thread frowand . list
From: Frank Rowand Existing overlay unit tests examine individual pieces of the overlay code. The new tests target the entire process of applying an overlay. Signed-off-by: Frank Rowand --- There are checkpatch warnings. I have reviewed them and feel they can be ignored. drivers/of/fdt.c

[PATCH 1/2] of: add support of dtc compiler flags for device tree overlays

2017-04-23 Thread frowand . list
From: Frank Rowand The dtc compiler version that adds initial support was available in 4.11-rc1. Add the ability to set the dtc compiler flags needed by overlays. Signed-off-by: Frank Rowand --- scripts/Makefile.lib | 2 ++ 1 file changed, 2

[PATCH 0/2] of: Add unit tests for applying overlays

2017-04-23 Thread frowand . list
From: Frank Rowand Existing overlay unit tests examine individual pieces of the overlay code. The new tests target the entire process of applying an overlay. Frank Rowand (2): of: add support of dtc compiler flags for device tree overlays of: Add unit tests for

[PATCH 1/2] of: add support of dtc compiler flags for device tree overlays

2017-04-23 Thread frowand . list
From: Frank Rowand The dtc compiler version that adds initial support was available in 4.11-rc1. Add the ability to set the dtc compiler flags needed by overlays. Signed-off-by: Frank Rowand --- scripts/Makefile.lib | 2 ++ 1 file changed, 2 insertions(+) diff --git a/scripts/Makefile.lib

[PATCH 0/2] of: Add unit tests for applying overlays

2017-04-23 Thread frowand . list
From: Frank Rowand Existing overlay unit tests examine individual pieces of the overlay code. The new tests target the entire process of applying an overlay. Frank Rowand (2): of: add support of dtc compiler flags for device tree overlays of: Add unit tests for applying overlays.

[PATCH 2/2] of: Add unit tests for applying overlays.

2017-04-23 Thread frowand . list
From: Frank Rowand Existing overlay unit tests examine individual pieces of the overlay code. The new tests target the entire process of applying an overlay. Signed-off-by: Frank Rowand --- There are checkpatch warnings. I have reviewed them and

[PATCH 2/2] of: Add unit tests for applying overlays.

2017-04-23 Thread frowand . list
From: Frank Rowand Existing overlay unit tests examine individual pieces of the overlay code. The new tests target the entire process of applying an overlay. Signed-off-by: Frank Rowand --- There are checkpatch warnings. I have reviewed them and feel they can be ignored. drivers/of/fdt.c

[PATCH 1/3] of: overlay_adjust_phandles() - do not modify const field

2017-04-23 Thread frowand . list
From: Frank Rowand When adjusting overlay phandles to apply to the live device tree, can not modify the property value because it is type const. This is to resolve the issue found by Stephen Boyd [1] when he changed the type of struct property.value from void * to const

[PATCH 2/3] of: make __of_attach_node() static

2017-04-23 Thread frowand . list
From: Frank Rowand __of_attach_node() is not used outside of drivers/of/dynamic.c. Make it static and remove it from drivers/of/of_private.h. Signed-off-by: Frank Rowand --- drivers/of/dynamic.c| 2 +- drivers/of/of_private.h | 1 - 2 files

[PATCH 3/3] of: detect invalid phandle in overlay

2017-04-23 Thread frowand . list
From: Frank Rowand Overlays are not allowed to modify phandle values of previously existing nodes because there is no information available to allow fixup up of properties that use the previously existing phandle. Signed-off-by: Frank Rowand ---

[PATCH 1/3] of: overlay_adjust_phandles() - do not modify const field

2017-04-23 Thread frowand . list
From: Frank Rowand When adjusting overlay phandles to apply to the live device tree, can not modify the property value because it is type const. This is to resolve the issue found by Stephen Boyd [1] when he changed the type of struct property.value from void * to const void *. As a result of

[PATCH 2/3] of: make __of_attach_node() static

2017-04-23 Thread frowand . list
From: Frank Rowand __of_attach_node() is not used outside of drivers/of/dynamic.c. Make it static and remove it from drivers/of/of_private.h. Signed-off-by: Frank Rowand --- drivers/of/dynamic.c| 2 +- drivers/of/of_private.h | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff

[PATCH 3/3] of: detect invalid phandle in overlay

2017-04-23 Thread frowand . list
From: Frank Rowand Overlays are not allowed to modify phandle values of previously existing nodes because there is no information available to allow fixup up of properties that use the previously existing phandle. Signed-off-by: Frank Rowand --- drivers/of/overlay.c | 4 1 file changed,

[PATCH 0/3] of: fix overlay modification of const variable

2017-04-23 Thread frowand . list
From: Frank Rowand When adjusting overlay phandles to apply to the live device tree, can not modify the property value because it is type const. This is to resolve the issue found by Stephen Boyd [1] when he changed the type of struct property.value from void * to

[PATCH 0/3] of: fix overlay modification of const variable

2017-04-23 Thread frowand . list
From: Frank Rowand When adjusting overlay phandles to apply to the live device tree, can not modify the property value because it is type const. This is to resolve the issue found by Stephen Boyd [1] when he changed the type of struct property.value from void * to const void *. As a result

[PATCH 1/4] of: remove *phandle properties from expanded device tree

2017-04-14 Thread frowand . list
From: Frank Rowand Remove "phandle" and "linux,phandle" properties from the internal device tree. The phandle will still be in the struct device_node phandle field. This is to resolve the issue found by Stephen Boyd [1] when he changed the type of struct property.value

[PATCH 1/4] of: remove *phandle properties from expanded device tree

2017-04-14 Thread frowand . list
From: Frank Rowand Remove "phandle" and "linux,phandle" properties from the internal device tree. The phandle will still be in the struct device_node phandle field. This is to resolve the issue found by Stephen Boyd [1] when he changed the type of struct property.value from void * to const

[PATCH 0/4] of: remove *phandle properties from expanded device tree

2017-04-14 Thread frowand . list
From: Frank Rowand Remove "phandle" and "linux,phandle" properties from the internal device tree. The phandle will still be in the struct device_node phandle field. This is to resolve the issue found by Stephen Boyd [1] when he changed the type of struct property.value

[PATCH 2/4] of: make __of_attach_node() static

2017-04-14 Thread frowand . list
From: Frank Rowand __of_attach_node() is not used outside of drivers/of/dynamic.c. Make it static and remove it from drivers/of/of_private.h. Signed-off-by: Frank Rowand --- drivers/of/dynamic.c| 2 +- drivers/of/of_private.h | 1 - 2 files

[PATCH 4/4] of: detect invalid phandle in overlay

2017-04-14 Thread frowand . list
From: Frank Rowand Overlays are not allowed to modify phandle values of previously existing nodes because there is no information available to allow fixup up properties that use the previously existing phandle. Signed-off-by: Frank Rowand ---

[PATCH 0/4] of: remove *phandle properties from expanded device tree

2017-04-14 Thread frowand . list
From: Frank Rowand Remove "phandle" and "linux,phandle" properties from the internal device tree. The phandle will still be in the struct device_node phandle field. This is to resolve the issue found by Stephen Boyd [1] when he changed the type of struct property.value from void * to const

[PATCH 2/4] of: make __of_attach_node() static

2017-04-14 Thread frowand . list
From: Frank Rowand __of_attach_node() is not used outside of drivers/of/dynamic.c. Make it static and remove it from drivers/of/of_private.h. Signed-off-by: Frank Rowand --- drivers/of/dynamic.c| 2 +- drivers/of/of_private.h | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff

[PATCH 4/4] of: detect invalid phandle in overlay

2017-04-14 Thread frowand . list
From: Frank Rowand Overlays are not allowed to modify phandle values of previously existing nodes because there is no information available to allow fixup up properties that use the previously existing phandle. Signed-off-by: Frank Rowand --- drivers/of/overlay.c | 4 1 file changed, 4

[PATCH 3/4] of: be consistent in form of file mode

2017-04-14 Thread frowand . list
From: Frank Rowand checkpatch whined about using S_IRUGO instead of octal equivalent when adding phandle sysfs code, so used octal in that patch. Change other instances of the S_* constants in the same file to the octal form. Signed-off-by: Frank Rowand

[PATCH 3/4] of: be consistent in form of file mode

2017-04-14 Thread frowand . list
From: Frank Rowand checkpatch whined about using S_IRUGO instead of octal equivalent when adding phandle sysfs code, so used octal in that patch. Change other instances of the S_* constants in the same file to the octal form. Signed-off-by: Frank Rowand --- drivers/of/base.c | 2 +- 1 file

[PATCH] of: change fixup of dma-ranges size to error

2017-04-06 Thread frowand . list
From: Frank Rowand of_dma_get_range() has workaround code to fixup a device tree that incorrectly specified a mask instead of a size for property dma-ranges. That device tree was fixed a year ago in v4.6, so the workaround is no longer needed. Leave a data validation

[PATCH] of: change fixup of dma-ranges size to error

2017-04-06 Thread frowand . list
From: Frank Rowand of_dma_get_range() has workaround code to fixup a device tree that incorrectly specified a mask instead of a size for property dma-ranges. That device tree was fixed a year ago in v4.6, so the workaround is no longer needed. Leave a data validation check in place, but no

[PATCH 10/12] of: Add back an error message, restructured

2016-10-29 Thread frowand . list
From: Frank Rowand Add a single pr_err() to cover a range of errors that were reported by several pr_err() that were removed earlier in this series. Signed-off-by: Frank Rowand --- drivers/of/resolver.c | 18 -- 1 file

[PATCH 10/12] of: Add back an error message, restructured

2016-10-29 Thread frowand . list
From: Frank Rowand Add a single pr_err() to cover a range of errors that were reported by several pr_err() that were removed earlier in this series. Signed-off-by: Frank Rowand --- drivers/of/resolver.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git

[PATCH 11/12] of: Move setting of pointer to beside test for non-null

2016-10-29 Thread frowand . list
From: Frank Rowand Value of pointer was calculated in an earlier block than where it was used. Move it down into the block where it is used, immediately before where is is checked to be valid. Signed-off-by: Frank Rowand ---

[PATCH 03/12] of: Convert comparisons to zero or NULL to logical expressions

2016-10-29 Thread frowand . list
From: Frank Rowand Convert comparisons to zero or NULL to logical expressions. A small number of such comparisons remain where they provide more clarity of the numeric nature of a variable. Signed-off-by: Frank Rowand ---

[PATCH 08/12] of: Remove redundant size check

2016-10-29 Thread frowand . list
From: Frank Rowand Remove a redundant check of buffer size. Signed-off-by: Frank Rowand --- drivers/of/resolver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/of/resolver.c b/drivers/of/resolver.c index

[PATCH 03/12] of: Convert comparisons to zero or NULL to logical expressions

2016-10-29 Thread frowand . list
From: Frank Rowand Convert comparisons to zero or NULL to logical expressions. A small number of such comparisons remain where they provide more clarity of the numeric nature of a variable. Signed-off-by: Frank Rowand --- drivers/of/resolver.c | 42 --

[PATCH 08/12] of: Remove redundant size check

2016-10-29 Thread frowand . list
From: Frank Rowand Remove a redundant check of buffer size. Signed-off-by: Frank Rowand --- drivers/of/resolver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/of/resolver.c b/drivers/of/resolver.c index 708daca1d522..76c09cb57eae 100644 ---

[PATCH 11/12] of: Move setting of pointer to beside test for non-null

2016-10-29 Thread frowand . list
From: Frank Rowand Value of pointer was calculated in an earlier block than where it was used. Move it down into the block where it is used, immediately before where is is checked to be valid. Signed-off-by: Frank Rowand --- drivers/of/resolver.c | 3 +-- 1 file changed, 1 insertion(+), 2

[PATCH 04/12] of: Rename functions to more accurately reflect what they do

2016-10-29 Thread frowand . list
From: Frank Rowand Some function names are misleading or do not provide a good sense of what they do. Rename the functions to ne more informative. Signed-off-by: Frank Rowand --- drivers/of/resolver.c | 22 +++--- 1 file

[PATCH 04/12] of: Rename functions to more accurately reflect what they do

2016-10-29 Thread frowand . list
From: Frank Rowand Some function names are misleading or do not provide a good sense of what they do. Rename the functions to ne more informative. Signed-off-by: Frank Rowand --- drivers/of/resolver.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git

[PATCH 12/12] of: Remove unused variable overlay_symbols

2016-10-29 Thread frowand . list
From: Frank Rowand Remove unused pointer to node "__symbols__". Signed-off-by: Frank Rowand --- drivers/of/resolver.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/of/resolver.c b/drivers/of/resolver.c index

[PATCH 02/12] of: Remove excessive printks to reduce clutter.

2016-10-29 Thread frowand . list
From: Frank Rowand Remove extra debug and error printks. A single pr_err() will be added at the end of this series to replace many of these error messages. Signed-off-by: Frank Rowand --- drivers/of/resolver.c | 53

[PATCH 01/12] of: Remove comments that state the obvious, to reduce clutter

2016-10-29 Thread frowand . list
From: Frank Rowand Remove comments that report what is obvious from the code. Signed-off-by: Frank Rowand --- drivers/of/resolver.c | 31 ++- 1 file changed, 2 insertions(+), 29 deletions(-) diff --git

[PATCH 07/12] of: Update structure of code to be clearer, also remove BUG_ON()

2016-10-29 Thread frowand . list
From: Frank Rowand Remove BUG_ON(), which is frowned upon and not needed here. Restructure to remove some excessive complexity. Signed-off-by: Frank Rowand --- drivers/of/resolver.c | 48 +--- 1

[PATCH 12/12] of: Remove unused variable overlay_symbols

2016-10-29 Thread frowand . list
From: Frank Rowand Remove unused pointer to node "__symbols__". Signed-off-by: Frank Rowand --- drivers/of/resolver.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/of/resolver.c b/drivers/of/resolver.c index 53353cc8f2bb..783bd09463b5 100644 ---

[PATCH 02/12] of: Remove excessive printks to reduce clutter.

2016-10-29 Thread frowand . list
From: Frank Rowand Remove extra debug and error printks. A single pr_err() will be added at the end of this series to replace many of these error messages. Signed-off-by: Frank Rowand --- drivers/of/resolver.c | 53 --- 1 file changed, 8

[PATCH 01/12] of: Remove comments that state the obvious, to reduce clutter

2016-10-29 Thread frowand . list
From: Frank Rowand Remove comments that report what is obvious from the code. Signed-off-by: Frank Rowand --- drivers/of/resolver.c | 31 ++- 1 file changed, 2 insertions(+), 29 deletions(-) diff --git a/drivers/of/resolver.c b/drivers/of/resolver.c index

[PATCH 07/12] of: Update structure of code to be clearer, also remove BUG_ON()

2016-10-29 Thread frowand . list
From: Frank Rowand Remove BUG_ON(), which is frowned upon and not needed here. Restructure to remove some excessive complexity. Signed-off-by: Frank Rowand --- drivers/of/resolver.c | 48 +--- 1 file changed, 17 insertions(+), 31 deletions(-) diff

[PATCH 00/12] of: Make drivers/of/resolver.c more readable

2016-10-29 Thread frowand . list
From: Frank Rowand drivers/of/resolve.c is a bit difficult to read. Clean it up so that review of future overlay related patches will be easier. Most of the patches are intended to be reformatting, with no functional change. Patches that are expected to have a

[PATCH 09/12] of: Update comments to reflect changes and increase clarity

2016-10-29 Thread frowand . list
From: Frank Rowand Update comments to better explain what functions are doing. Signed-off-by: Frank Rowand --- drivers/of/resolver.c | 66 --- 1 file changed, 47 insertions(+), 19 deletions(-)

[PATCH 06/12] of: Rename variables to better reflect purpose or follow convention

2016-10-29 Thread frowand . list
From: Frank Rowand Rename variables to better reflect what their purpose is. As a side effect, this reduces the need for some of the comments previously removed in this series. Signed-off-by: Frank Rowand --- drivers/of/resolver.c | 172

[PATCH 05/12] of: Remove prefix "__of_" from local function names

2016-10-29 Thread frowand . list
From: Frank Rowand Remove "__of_" prefix from local function names. The pattern of a leading "__" is used in drivers/of/ to signify a function that must be called with a lock held. These functions do not fit that pattern. Signed-off-by: Frank Rowand

[PATCH 00/12] of: Make drivers/of/resolver.c more readable

2016-10-29 Thread frowand . list
From: Frank Rowand drivers/of/resolve.c is a bit difficult to read. Clean it up so that review of future overlay related patches will be easier. Most of the patches are intended to be reformatting, with no functional change. Patches that are expected to have a functional change are: Remove

[PATCH 09/12] of: Update comments to reflect changes and increase clarity

2016-10-29 Thread frowand . list
From: Frank Rowand Update comments to better explain what functions are doing. Signed-off-by: Frank Rowand --- drivers/of/resolver.c | 66 --- 1 file changed, 47 insertions(+), 19 deletions(-) diff --git a/drivers/of/resolver.c

[PATCH 06/12] of: Rename variables to better reflect purpose or follow convention

2016-10-29 Thread frowand . list
From: Frank Rowand Rename variables to better reflect what their purpose is. As a side effect, this reduces the need for some of the comments previously removed in this series. Signed-off-by: Frank Rowand --- drivers/of/resolver.c | 172 +- 1

[PATCH 05/12] of: Remove prefix "__of_" from local function names

2016-10-29 Thread frowand . list
From: Frank Rowand Remove "__of_" prefix from local function names. The pattern of a leading "__" is used in drivers/of/ to signify a function that must be called with a lock held. These functions do not fit that pattern. Signed-off-by: Frank Rowand --- drivers/of/resolver.c | 10 +-

[RFC PATCH 00/13] of: Make drivers/of/resolver.c more readable

2016-10-25 Thread frowand . list
From: Frank Rowand drivers/of/resolve.c is a bit difficult to read. Clean it up so that review of future overlay related patches will be easier. Most of the patches are intended to be reformatting, with no functional change. Patches that are expected to have a

[RFC PATCH 00/13] of: Make drivers/of/resolver.c more readable

2016-10-25 Thread frowand . list
From: Frank Rowand drivers/of/resolve.c is a bit difficult to read. Clean it up so that review of future overlay related patches will be easier. Most of the patches are intended to be reformatting, with no functional change. Patches that are expected to have a functional change are: Remove

[RFC PATCH 03/13] of: Remove braces around single line blocks.

2016-10-25 Thread frowand . list
From: Frank Rowand The single line blocks were created by previous patches in the series. Signed-off-by: Frank Rowand --- drivers/of/resolver.c | 25 - 1 file changed, 8 insertions(+), 17 deletions(-) diff --git

[RFC PATCH 03/13] of: Remove braces around single line blocks.

2016-10-25 Thread frowand . list
From: Frank Rowand The single line blocks were created by previous patches in the series. Signed-off-by: Frank Rowand --- drivers/of/resolver.c | 25 - 1 file changed, 8 insertions(+), 17 deletions(-) diff --git a/drivers/of/resolver.c b/drivers/of/resolver.c index

[RFC PATCH 02/13] of: Remove excessive printks to reduce clutter

2016-10-25 Thread frowand . list
From: Frank Rowand Signed-off-by: Frank Rowand --- drivers/of/resolver.c | 28 1 file changed, 28 deletions(-) diff --git a/drivers/of/resolver.c b/drivers/of/resolver.c index 4ff0220d7aa2..93a7ca0bf98c 100644

[RFC PATCH 02/13] of: Remove excessive printks to reduce clutter

2016-10-25 Thread frowand . list
From: Frank Rowand Signed-off-by: Frank Rowand --- drivers/of/resolver.c | 28 1 file changed, 28 deletions(-) diff --git a/drivers/of/resolver.c b/drivers/of/resolver.c index 4ff0220d7aa2..93a7ca0bf98c 100644 --- a/drivers/of/resolver.c +++

[RFC PATCH 09/13] of: Remove redundant size check

2016-10-25 Thread frowand . list
From: Frank Rowand Signed-off-by: Frank Rowand --- drivers/of/resolver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/of/resolver.c b/drivers/of/resolver.c index 708daca1d522..76c09cb57eae 100644 ---

[RFC PATCH 09/13] of: Remove redundant size check

2016-10-25 Thread frowand . list
From: Frank Rowand Signed-off-by: Frank Rowand --- drivers/of/resolver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/of/resolver.c b/drivers/of/resolver.c index 708daca1d522..76c09cb57eae 100644 --- a/drivers/of/resolver.c +++ b/drivers/of/resolver.c @@ -216,7

[RFC PATCH 05/13] of: Rename functions to more accurately reflect what they do

2016-10-25 Thread frowand . list
From: Frank Rowand Signed-off-by: Frank Rowand --- drivers/of/resolver.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/of/resolver.c b/drivers/of/resolver.c index

[RFC PATCH 05/13] of: Rename functions to more accurately reflect what they do

2016-10-25 Thread frowand . list
From: Frank Rowand Signed-off-by: Frank Rowand --- drivers/of/resolver.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/of/resolver.c b/drivers/of/resolver.c index 31fd3800787a..3d123b612789 100644 --- a/drivers/of/resolver.c +++

[RFC PATCH 01/13] of: Remove comments that state the obvious

2016-10-25 Thread frowand . list
From: Frank Rowand Remove comments that state the obvious, to reduce clutter Signed-off-by: Frank Rowand --- drivers/of/resolver.c | 31 ++- 1 file changed, 2 insertions(+), 29 deletions(-) diff --git

[RFC PATCH 01/13] of: Remove comments that state the obvious

2016-10-25 Thread frowand . list
From: Frank Rowand Remove comments that state the obvious, to reduce clutter Signed-off-by: Frank Rowand --- drivers/of/resolver.c | 31 ++- 1 file changed, 2 insertions(+), 29 deletions(-) diff --git a/drivers/of/resolver.c b/drivers/of/resolver.c index

[RFC PATCH 08/13] of: Update structure of code, remove BUG_ON()

2016-10-25 Thread frowand . list
From: Frank Rowand Signed-off-by: Frank Rowand --- drivers/of/resolver.c | 48 +--- 1 file changed, 17 insertions(+), 31 deletions(-) diff --git a/drivers/of/resolver.c b/drivers/of/resolver.c

[RFC PATCH 11/13] of: Add back an error message, restructured

2016-10-25 Thread frowand . list
From: Frank Rowand Signed-off-by: Frank Rowand --- drivers/of/resolver.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers/of/resolver.c b/drivers/of/resolver.c index 4e6df385118b..664c97e1ecb4

[RFC PATCH 10/13] of: Update comments to reflect changes and increase clarity

2016-10-25 Thread frowand . list
From: Frank Rowand Signed-off-by: Frank Rowand --- drivers/of/resolver.c | 51 --- 1 file changed, 32 insertions(+), 19 deletions(-) diff --git a/drivers/of/resolver.c b/drivers/of/resolver.c

[RFC PATCH 07/13] of: Rename variables to better reflect purpose or follow convention

2016-10-25 Thread frowand . list
From: Frank Rowand Signed-off-by: Frank Rowand --- drivers/of/resolver.c | 172 +- 1 file changed, 85 insertions(+), 87 deletions(-) diff --git a/drivers/of/resolver.c b/drivers/of/resolver.c

[RFC PATCH 11/13] of: Add back an error message, restructured

2016-10-25 Thread frowand . list
From: Frank Rowand Signed-off-by: Frank Rowand --- drivers/of/resolver.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers/of/resolver.c b/drivers/of/resolver.c index 4e6df385118b..664c97e1ecb4 100644 --- a/drivers/of/resolver.c +++

<    1   2   3   4   5   6   >