Re: Bogus struct page layout on 32-bit

2021-04-16 Thread Grygorii Strashko
Hi Ilias, All, On 10/04/2021 11:52, Ilias Apalodimas wrote: +CC Grygorii for the cpsw part as Ivan's email is not valid anymore Thanks for catching this. Interesting indeed... On Sat, 10 Apr 2021 at 09:22, Jesper Dangaard Brouer wrote: On Sat, 10 Apr 2021 03:43:13 +0100 Matthew Wilcox

Re: [PATCH 4/4] clk: ti: add am33xx spread spectrum clock support

2021-03-18 Thread Grygorii Strashko
On 18/03/2021 09:38, Dario Binacchi wrote: Hi Grygorii, Il 16/03/2021 12:52 Grygorii Strashko ha scritto: On 14/03/2021 17:12, Dario Binacchi wrote: The patch enables spread spectrum clocking (SSC) for MPU and LCD PLLs. As reported by the TI spruh73x RM, SSC is only supported

Re: [PATCH v5 2/3] arm64: dts: ti: k3-j7200-common-proc-board: Disable unused gpio modules

2021-03-16 Thread Grygorii Strashko
(+) Reviewed-by: Grygorii Strashko -- Best regards, grygorii

Re: [PATCH 4/4] clk: ti: add am33xx spread spectrum clock support

2021-03-16 Thread Grygorii Strashko
e *node, if (of_property_read_bool(node, "ti,lock")) dpll_mode |= 1 << DPLL_LOCKED; + if (!of_property_read_u32(node, "ti,min-div", _div) && + min_div > dd->min_divider) + dd->min_divider = min_div; + New bindings. [...] -- Best regards, grygorii

Re: [PATCH v5 1/3] arm64: dts: ti: k3-j7200: Add gpio nodes

2021-03-11 Thread Grygorii Strashko
/boot/dts/ti/k3-j7200-main.dtsi | 72 +++ .../boot/dts/ti/k3-j7200-mcu-wakeup.dtsi | 34 + 2 files changed, 106 insertions(+) Reviewed-by: Grygorii Strashko -- Best regards, grygorii

Re: [PATCH 1/3] clocksource/drivers/timer-ti-dm: Fix posted mode status check order

2021-03-05 Thread Grygorii Strashko
On 05/03/2021 09:53, Tony Lindgren wrote: * Grygorii Strashko [210304 20:58]: On 04/03/2021 09:21, Tony Lindgren wrote: When the timer is configured in posted mode, we need to check the write- posted status register (TWPS) before writing to the register. ... --- a/drivers/clocksource

[PATCH v2 1/4] arm64: dts: ti: k3-am64-main: Add CPSW DT node

2021-03-04 Thread Grygorii Strashko
. This improves bidirectional TCP performance by up to 100Mbps (on 1G link). Signed-off-by: Vignesh Raghavendra Signed-off-by: Grygorii Strashko Reviewed-by: Lokesh Vutla --- arch/arm64/boot/dts/ti/k3-am64-main.dtsi | 74 arch/arm64/boot/dts/ti/k3-am64.dtsi | 2 + 2 files

[PATCH v2 3/4] arm64: dts: ti: k3-am642-evm: add CPSW3g DT nodes

2021-03-04 Thread Grygorii Strashko
above topology. Signed-off-by: Vignesh Raghavendra Signed-off-by: Grygorii Strashko Reviewed-by: Lokesh Vutla --- arch/arm64/boot/dts/ti/k3-am642-evm.dts | 93 + 1 file changed, 93 insertions(+) diff --git a/arch/arm64/boot/dts/ti/k3-am642-evm.dts b/arch/arm64/boot/dts

[PATCH v2 2/4] arm64: dts: ti: k3-am64-main: add main CPTS entry

2021-03-04 Thread Grygorii Strashko
Add DT node for the Main domain CPTS. Signed-off-by: Grygorii Strashko Signed-off-by: Vignesh Raghavendra Reviewed-by: Lokesh Vutla --- arch/arm64/boot/dts/ti/k3-am64-main.dtsi | 15 +++ 1 file changed, 15 insertions(+) diff --git a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi b

[PATCH v2 4/4] arm64: dts: ti: k3-am642-sk: Add CPSW DT nodes

2021-03-04 Thread Grygorii Strashko
From: Vignesh Raghavendra AM642 SK board has 2 CPSW3g ports connected through TI DP83867 PHYs. Add DT entries for the same. Signed-off-by: Vignesh Raghavendra Signed-off-by: Grygorii Strashko Reviewed-by: Lokesh Vutla --- arch/arm64/boot/dts/ti/k3-am642-sk.dts | 73

[PATCH v2 0/4] arm64: dts: ti: am642x: add CPSW3g DT nodes

2021-03-04 Thread Grygorii Strashko
/ Changes in v2: - minor comment fixed - add Reviewed-by: Lokesh Vutla v1: https://lore.kernel.org/patchwork/cover/1389305/ Grygorii Strashko (1): arm64: dts: ti: k3-am64-main: add main CPTS entry Vignesh Raghavendra (3): arm64: dts: ti: am64-main: Add CPSW DT node arm64: dts: ti: k3-am642-evm

Re: [PATCH 1/3] clocksource/drivers/timer-ti-dm: Fix posted mode status check order

2021-03-04 Thread Grygorii Strashko
p; WP_TCLR) cpu_relax(); + writel_relaxed(OMAP_TIMER_CTRL_AR | OMAP_TIMER_CTRL_ST, + t->base + t->ctrl); return 0; } -- Best regards, grygorii

Re: [PATCH 2/3] clocksource/drivers/timer-ti-dm: Remove extra of_node_put()

2021-03-04 Thread Grygorii Strashko
continue; } - of_node_put(np); break; } } -- Best regards, grygorii

[PATCH 4/4] arm64: dts: ti: k3-am642-sk: Add CPSW DT nodes

2021-03-03 Thread Grygorii Strashko
From: Vignesh Raghavendra AM642 SK board has 2 CPSW3g ports connected through TI DP83867 PHYs. Add DT entries for the same. Signed-off-by: Vignesh Raghavendra Signed-off-by: Grygorii Strashko --- arch/arm64/boot/dts/ti/k3-am642-sk.dts | 73 ++ 1 file changed, 73

[PATCH 1/4] arm64: dts: ti: am64-main: Add CPSW DT node

2021-03-03 Thread Grygorii Strashko
. This improves bidirectional TCP performance by up to 100Mbps (on 1G link). Signed-off-by: Vignesh Raghavendra Signed-off-by: Grygorii Strashko --- arch/arm64/boot/dts/ti/k3-am64-main.dtsi | 74 arch/arm64/boot/dts/ti/k3-am64.dtsi | 2 + 2 files changed, 76 insertions(+) diff

[PATCH 0/4] arm64: dts: ti: am642x: add CPSW3g DT nodes

2021-03-03 Thread Grygorii Strashko
/ Grygorii Strashko (1): arm64: dts: ti: k3-am64-main: add main CPTS entry Vignesh Raghavendra (3): arm64: dts: ti: am64-main: Add CPSW DT node arm64: dts: ti: k3-am642-evm: add CPSW3g DT nodes arm64: dts: ti: k3-am642-sk: Add CPSW DT nodes arch/arm64/boot/dts/ti/k3-am64-main.dtsi | 89

[PATCH 3/4] arm64: dts: ti: k3-am642-evm: add CPSW3g DT nodes

2021-03-03 Thread Grygorii Strashko
above topology. Signed-off-by: Vignesh Raghavendra Signed-off-by: Grygorii Strashko --- arch/arm64/boot/dts/ti/k3-am642-evm.dts | 93 + 1 file changed, 93 insertions(+) diff --git a/arch/arm64/boot/dts/ti/k3-am642-evm.dts b/arch/arm64/boot/dts/ti/k3-am642-evm.dts index

[PATCH 2/4] arm64: dts: ti: k3-am64-main: add main CPTS entry

2021-03-03 Thread Grygorii Strashko
Add DT node for the Main domain CPTS. Signed-off-by: Grygorii Strashko Signed-off-by: Vignesh Raghavendra --- arch/arm64/boot/dts/ti/k3-am64-main.dtsi | 15 +++ 1 file changed, 15 insertions(+) diff --git a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi b/arch/arm64/boot/dts/ti/k3-am64

Re: [PATCH] gpio: omap: Honor "aliases" node

2021-03-02 Thread Grygorii Strashko
pio-%d-%d", gpio, gpio + bank->width - 1); if (!label) You're not the first one, this was not accepted. See [1] [1] https://patchwork.kernel.org/project/linux-omap/patch/1465898604-16294-1-git-send-email-u.kleine-koe...@pengutronix.de/ -- Best regards, grygorii

Re: [PATCH] arm64: dts: ti: k3-am64-main: Add GPIO DT nodes

2021-03-01 Thread Grygorii Strashko
#interrupt-cells = <2>; + ti,ngpio = <88>; + ti,davinci-gpio-unbanked = <0>; + power-domains = <_pds 78 TI_SCI_PD_EXCLUSIVE>; + clocks = <_clks 78 0>; + clock-names = "gpio"; + }; + sdhci0: mmc@fa1 { compatible = "ti,am64-sdhci-8bit"; reg = <0x00 0xfa1 0x00 0x260>, <0x00 0xfa18000 0x00 0x134>; Reviewed-by: Grygorii Strashko -- Best regards, grygorii

Re: linux-next: manual merge of the devicetree tree with the net-next tree

2021-02-22 Thread Grygorii Strashko
, this is a reminder that this conflict still exists. This is now a conflict between the devicetree tree and Linus' tree. Sorry for inconvenience, is there anything I can do to help resolve it? (Changes went through a different trees) -- Best regards, grygorii

Re: [PATCH v5 net-next 05/10] net: switchdev: pass flags and mask to both {PRE_,}BRIDGE_FLAGS attributes

2021-02-12 Thread Grygorii Strashko
10 files changed, 129 insertions(+), 89 deletions(-) Reviewed-by: Grygorii Strashko -- Best regards, grygorii

Re: [PATCH v5 net-next 01/10] net: switchdev: propagate extack to port attributes

2021-02-12 Thread Grygorii Strashko
++- net/switchdev/switchdev.c | 11 --- 8 files changed, 24 insertions(+), 11 deletions(-) Reviewed-by: Grygorii Strashko -- Best regards, grygorii

Re: [PATCH v4 net-next 0/9] Cleanup in brport flags switchdev offload for DSA

2021-02-12 Thread Grygorii Strashko
(-) Sorry, but we seems just added more work for you. https://lore.kernel.org/patchwork/cover/1379380/ -- Best regards, grygorii

Re: [Linuxarm] Re: [PATCH for next v1 1/2] gpio: omap: Replace raw_spin_lock_irqsave with raw_spin_lock in omap_gpio_irq_handler()

2021-02-12 Thread Grygorii Strashko
On 12/02/2021 15:12, Song Bao Hua (Barry Song) wrote: -Original Message- From: Grygorii Strashko [mailto:grygorii.stras...@ti.com] Sent: Saturday, February 13, 2021 12:53 AM To: Song Bao Hua (Barry Song) ; Andy Shevchenko Cc: Arnd Bergmann ; luojiaxing ; Linus Walleij ; Santosh

Re: [Linuxarm] Re: [PATCH for next v1 1/2] gpio: omap: Replace raw_spin_lock_irqsave with raw_spin_lock in omap_gpio_irq_handler()

2021-02-12 Thread Grygorii Strashko
On 12/02/2021 13:29, Song Bao Hua (Barry Song) wrote: -Original Message- From: Andy Shevchenko [mailto:andy.shevche...@gmail.com] Sent: Friday, February 12, 2021 11:57 PM To: Song Bao Hua (Barry Song) Cc: Grygorii Strashko ; Arnd Bergmann ; luojiaxing ; Linus Walleij ; Santosh

Re: [Linuxarm] Re: [PATCH for next v1 1/2] gpio: omap: Replace raw_spin_lock_irqsave with raw_spin_lock in omap_gpio_irq_handler()

2021-02-12 Thread Grygorii Strashko
and generic_handle_irq() will call one of handle_level_irq or handle_edge_irq. The history behind this is commit 450fa54cfd66 ("gpio: omap: convert to use generic irq handler"). The resent related discussion: https://lkml.org/lkml/2020/12/5/208 -- Best regards, grygorii

Re: [PATCH for next v1 1/2] gpio: omap: Replace raw_spin_lock_irqsave with raw_spin_lock in omap_gpio_irq_handler()

2021-02-11 Thread Grygorii Strashko
On 11/02/2021 21:39, Arnd Bergmann wrote: On Thu, Feb 11, 2021 at 7:25 PM Grygorii Strashko wrote: On 08/02/2021 10:56, Luo Jiaxing wrote: There is no need to use API with _irqsave in omap_gpio_irq_handler(), because it already be in a irq-disabled context. NACK. Who said

Re: [PATCH for next v1 1/2] gpio: omap: Replace raw_spin_lock_irqsave with raw_spin_lock in omap_gpio_irq_handler()

2021-02-11 Thread Grygorii Strashko
wa_lock); } } exit: NACK. Who said that this is always hard IRQ handler? What about RT-kernel or boot with "threadirqs"? -- Best regards, grygorii

Re: [PATCH] soc: ti: k3-ringacc: Use of_device_get_match_data()

2021-02-05 Thread Grygorii Strashko
(dev, sizeof(*ringacc), GFP_KERNEL); if (!ringacc) Thank you Reviewed-by: Grygorii Strashko -- Best regards, grygorii

[PATCH] dmaengine: ti: k3-psil: optimize struct psil_endpoint_config for size

2021-01-29 Thread Grygorii Strashko
5211472 666904 1853247611ac87c vmlinux after: 126541005208528 666904 1852953211abcfc vmlinux diff: 2944 bytes Signed-off-by: Grygorii Strashko --- include/linux/dma/k3-psil.h | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/include/linux

Re: [PATCH v2 2/6] drivers: net: davinci_mdio: Use of_device_get_match_data()

2021-01-26 Thread Grygorii Strashko
Bergmann Cc: Geert Uytterhoeven Cc: Grygorii Strashko Cc: "David S. Miller" Cc: Rob Herring Cc: Frank Rowand Cc: --- Please ack so Rob can apply. drivers/net/ethernet/ti/davinci_mdio.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/net/e

[PATCH] dt-bindings: mmc: sdhci-am654: fix compatible for j7200

2021-01-15 Thread Grygorii Strashko
: 407d0c2cdd12 ("dt-bindings: mmc: sdhci-am654: Convert sdhci-am654 controller documentation to json schema") Signed-off-by: Grygorii Strashko --- .../devicetree/bindings/mmc/sdhci-am654.yaml | 21 --- 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/Documen

[PATCH] dt-bindings: usb: j721e: add ranges and dma-coherent props

2021-01-15 Thread Grygorii Strashko
-by: Grygorii Strashko --- Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml | 4 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml b/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml index 4423f0a29f54..7ec87a783c5c 100644

[PATCH] arm64: dts: ti: k3: mmc: fix dtbs_check warnings

2021-01-15 Thread Grygorii Strashko
: - rename sdhci dt nodes to 'mmc@' - swap clk_xin/clk_ahb clocks, the clk_ahb clock expected to be defined first Signed-off-by: Grygorii Strashko --- arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 4 ++-- arch/arm64/boot/dts/ti/k3-j7200-main.dtsi | 8 arch/arm64/boot/dts/ti/k3-j721e

[net-next 1/6] dt-binding: ti: am65x-cpts: add assigned-clock and power-domains props

2021-01-15 Thread Grygorii Strashko
' and 'power-domains' properties to the CPTS DT bindings to avoid dtbs_check warnings: cpts@310d: 'assigned-clock-parents', 'assigned-clocks' do not match any of the regexes: 'pinctrl-[0-9]+' cpts@310d: 'power-domains' does not match any of the regexes: 'pinctrl-[0-9]+' Signed-off-by: Grygorii

[net-next 2/6] dt-binding: net: ti: k3-am654-cpsw-nuss: update bindings for am64x cpsw3g

2021-01-15 Thread Grygorii Strashko
binding changes are minimal: - reword description - add new compatible 'ti,am642-cpsw-nuss' - allow 2 external ports child nodes - add missed 'assigned-clock' props [1] https://www.ti.com/lit/pdf/spruim2 Signed-off-by: Grygorii Strashko --- .../bindings/net/ti,k3-am654-cpsw-nuss.yaml | 50

[net-next 5/6] net: ti: cpsw_ale: add driver data for AM64 CPSW3g

2021-01-15 Thread Grygorii Strashko
From: Vignesh Raghavendra The AM642x CPSW3g is similar to j721e-cpswxg except its ALE table size is 512 entries. Add entry for the same. Signed-off-by: Vignesh Raghavendra Signed-off-by: Grygorii Strashko --- drivers/net/ethernet/ti/cpsw_ale.c | 7 +++ 1 file changed, 7 insertions

[net-next 0/6] net: ethernet: ti: am65-cpsw-nuss: introduce support for am64x cpsw3g

2021-01-15 Thread Grygorii Strashko
/spruim2 [2] https://patchwork.ozlabs.org/project/netdev/cover/20201130082046.16292-1-vigne...@ti.com/ Grygorii Strashko (2): dt-binding: ti: am65x-cpts: add assigned-clock and power-domains props dt-binding: net: ti: k3-am654-cpsw-nuss: update bindings for am64x cpsw3g Peter Ujfalusi (2): net

[net-next 6/6] net: ethernet: ti: am65-cpsw: add support for am64x cpsw3g

2021-01-15 Thread Grygorii Strashko
CPSW3g version. Signed-off-by: Vignesh Raghavendra Signed-off-by: Grygorii Strashko --- drivers/net/ethernet/ti/am65-cpsw-nuss.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/ethernet/ti/am65-cpsw-nuss.c b/drivers/net/ethernet/ti/am65-cpsw-nuss.c index d060744dd0b2

[net-next 4/6] net: ethernet: ti: am65-cpsw-nuss: Support for transparent ASEL handling

2021-01-15 Thread Grygorii Strashko
coherent individually by configuring the ASEL to appropriate value. [1] https://lore.kernel.org/patchwork/cover/1350756/ Signed-off-by: Peter Ujfalusi Co-developed-by: Vignesh Raghavendra Signed-off-by: Vignesh Raghavendra Signed-off-by: Grygorii Strashko --- drivers/net/ethernet/ti/am65-cpsw

[net-next 3/6] net: ethernet: ti: am65-cpsw-nuss: Use DMA device for DMA API

2021-01-15 Thread Grygorii Strashko
for adding AM64x CPSW3g support where DMA coherency supported per DMA channel. Signed-off-by: Peter Ujfalusi Co-developed-by: Vignesh Raghavendra Signed-off-by: Vignesh Raghavendra Signed-off-by: Grygorii Strashko --- drivers/net/ethernet/ti/am65-cpsw-nuss.c | 79 drivers

[PATCH net] net: ethernet: ti: cpts: fix ethtool output when no ptp_clock registered

2020-12-24 Thread Grygorii Strashko
netifs are down. This patch ensures that -1 is returned by ethtool when PTP PHC clock is not registered any more. Fixes: 8a2c9a5ab4b9 ("net: ethernet: ti: cpts: rework initialization/deinitialization") Signed-off-by: Grygorii Strashko --- drivers/net/ethernet/ti/cpts.c | 2 ++ 1 file

Re: [v2] i2c: mediatek: Move suspend and resume handling to NOIRQ phase

2020-12-14 Thread Grygorii Strashko
On 14/12/2020 10:48, Qii Wang wrote: On Thu, 2020-12-10 at 15:03 +0200, Grygorii Strashko wrote: On 10/12/2020 03:56, Qii Wang wrote: On Mon, 2020-12-07 at 18:35 +0200, Grygorii Strashko wrote: On Thu, 2020-12-03 at 10:01 +0200, Grygorii Strashko wrote: On 03/12/2020 03:25, Qii Wang

Re: [RFC PATCH] RFC: drivers: gpio: helper for generic pin IRQ handling

2020-12-10 Thread Grygorii Strashko
On 09/12/2020 12:23, Enrico Weigelt, metux IT consult wrote: On 08.12.20 17:18, Grygorii Strashko wrote: Having all GPIO drivers doing their IRQ management entirely through the GPIO subsystem (eg. never calling generic_handle_irq() and using the builtin IRQ handling) would also allow a more

Re: Howto listen to/handle gpio state changes ? Re: [PATCH v2 2/2] drivers: gpio: add virtio-gpio guest driver

2020-12-10 Thread Grygorii Strashko
On 09/12/2020 22:38, Arnd Bergmann wrote: On Wed, Dec 9, 2020 at 9:22 PM Grygorii Strashko wrote: On 09/12/2020 14:53, Linus Walleij wrote: On Wed, Dec 9, 2020 at 12:19 PM Arnd Bergmann wrote: On Wed, Dec 9, 2020 at 9:51 AM Linus Walleij wrote: On Tue, Dec 8, 2020 at 3:07 PM Enrico

Re: [v2] i2c: mediatek: Move suspend and resume handling to NOIRQ phase

2020-12-10 Thread Grygorii Strashko
On 10/12/2020 03:56, Qii Wang wrote: On Mon, 2020-12-07 at 18:35 +0200, Grygorii Strashko wrote: On Thu, 2020-12-03 at 10:01 +0200, Grygorii Strashko wrote: On 03/12/2020 03:25, Qii Wang wrote: On Wed, 2020-12-02 at 16:35 +0100, Wolfram Sang wrote: Hi, Some i2c device driver

Re: Howto listen to/handle gpio state changes ? Re: [PATCH v2 2/2] drivers: gpio: add virtio-gpio guest driver

2020-12-09 Thread Grygorii Strashko
iggering type. Overall, it might be better to start from pure gpio and leave GPIO IRQ aside. -- Best regards, grygorii

Re: [RFC PATCH] RFC: drivers: gpio: helper for generic pin IRQ handling

2020-12-08 Thread Grygorii Strashko
that you weren't able to test. agree. -- Best regards, grygorii

Re: Howto listen to/handle gpio state changes ? Re: [PATCH v2 2/2] drivers: gpio: add virtio-gpio guest driver

2020-12-08 Thread Grygorii Strashko
More over most consumers doesn't know where the IRQ came from - on one HW it can be gpio, while on another HW - direct interrupt controller line. -- Best regards, grygorii

Re: [PATCH v3 13/20] dmaengine: ti: k3-psil: Extend psil_endpoint_config for K3 PKTDMA

2020-12-08 Thread Grygorii Strashko
architecture. Signed-off-by: Peter Ujfalusi --- include/linux/dma/k3-psil.h | 16 1 file changed, 16 insertions(+) Reviewed-by: Grygorii Strashko -- Best regards, grygorii

Re: [PATCH v3 06/20] dmaengine: ti: k3-udma-glue: Configure the dma_dev for rings

2020-12-08 Thread Grygorii Strashko
to select the correct device to use for DMA API. Signed-off-by: Peter Ujfalusi --- drivers/dma/ti/k3-udma-glue.c | 8 1 file changed, 8 insertions(+) Reviewed-by: Grygorii Strashko -- Best regards, grygorii

Re: [PATCH v3 05/20] dmaengine: ti: k3-udma-glue: Get the ringacc from udma_dev

2020-12-08 Thread Grygorii Strashko
-udma-glue.c| 6 +- drivers/dma/ti/k3-udma-private.c | 6 ++ drivers/dma/ti/k3-udma.h | 1 + 3 files changed, 8 insertions(+), 5 deletions(-) Reviewed-by: Grygorii Strashko -- Best regards, grygorii

Re: [PATCH v3 04/20] dmaengine: ti: k3-udma-glue: Add function to get device pointer for DMA API

2020-12-08 Thread Grygorii Strashko
On 08/12/2020 11:04, Peter Ujfalusi wrote: Glue layer users should use the device of the DMA for DMA mapping and allocations as it is the DMA which accesses to descriptors and buffers, not the clients Signed-off-by: Peter Ujfalusi Reviewed-by: Grygorii Strashko -- Best regards, grygorii

Re: [v2] i2c: mediatek: Move suspend and resume handling to NOIRQ phase

2020-12-07 Thread Grygorii Strashko
IRQF_NO_SUSPEND. https://patchwork.kernel.org/project/linux-acpi/patch/20180923135812.29574-8-hdego...@redhat.com/ Pls, do not top post. On Thu, 2020-12-03 at 10:01 +0200, Grygorii Strashko wrote: On 03/12/2020 03:25, Qii Wang wrote: On Wed, 2020-12-02 at 16:35 +0100, Wolfram Sang wrote: Hi

Re: [PATCH 1/4] net: ti: am65-cpsw-nuss: Add devlink support

2020-12-03 Thread Grygorii Strashko
generation of TI CPSW (am3/4/5). -- Best regards, grygorii

Re: [v2] i2c: mediatek: Move suspend and resume handling to NOIRQ phase

2020-12-03 Thread Grygorii Strashko
i2c device which accessing i2c buss after _noirq stage and your driver does not implement .master_xfer_atomic() - you definitely have a bigger problem. So adding IRQF_NO_SUSPEND sound like a hack and probably works just by luck. -- Best regards, grygorii

Re: [PATCH] gpiolib: do not print err message for EPROBE_DEFER

2020-12-01 Thread Grygorii Strashko
hi Bartosz, All, On 18/11/2020 16:29, Grygorii Strashko wrote: The gpiochip may have dependencies from pinmux and so got deferred. Now it will print error message every time -EPROBE_DEFER is returned which is unnecessary: "gpiochip_add_data_with_key: GPIOs 0..31 (gpio-0-31) failed to reg

Re: [PATCH 5/8] i2c: omap: fix reference leak when pm_runtime_get_sync fails

2020-12-01 Thread Grygorii Strashko
_mem: return r; } @@ -1525,7 +1525,7 @@ static int omap_i2c_remove(struct platform_device *pdev) int ret; i2c_del_adapter(>adapter); - ret = pm_runtime_get_sync(>dev); + ret = pm_runtime_resume_and_get(>dev); if (ret < 0)

Re: [PATCH] gpio: omap: handle deferred probe with dev_err_probe() for gpiochip_add_data()

2020-11-30 Thread Grygorii Strashko
Hi All, On 19/11/2020 11:19, Tony Lindgren wrote: * Grygorii Strashko [201118 14:33]: The gpiochip_add_data() may return -EPROBE_DEFER which is not handled properly by TI GPIO driver and causes unnecessary boot log messages. Hence, add proper deferred probe handling with new dev_err_probe

Re: [PATCH v2 0/2] arm64: dts: ti: k3-j7200-som/cpb: Correct i2c bus representations

2020-11-26 Thread Grygorii Strashko
files changed, 37 insertions(+), 12 deletions(-) Thank you. Reviewed-by: Grygorii Strashko -- Best regards, grygorii

Re: [PATCH v2] mdio_bus: suppress err message for reset gpio EPROBE_DEFER

2020-11-19 Thread Grygorii Strashko
On 19/11/2020 23:11, Heiner Kallweit wrote: Am 19.11.2020 um 21:34 schrieb Grygorii Strashko: The mdio_bus may have dependencies from GPIO controller and so got deferred. Now it will print error message every time -EPROBE_DEFER is returned which from: __mdiobus_register

[PATCH v2] mdio_bus: suppress err message for reset gpio EPROBE_DEFER

2020-11-19 Thread Grygorii Strashko
.mdio couldn't get reset GPIO" Hence, suppress error message for devm_gpiod_get_optional() returning -EPROBE_DEFER case by using dev_err_probe(). Signed-off-by: Grygorii Strashko --- drivers/net/phy/mdio_bus.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drive

[PATCH 2/2] ARM: dts: am335x-evm/evmsk/icev2: switch to new cpsw switch drv

2020-11-19 Thread Grygorii Strashko
wired and configured in dual_mac mode by default, or only 1 Ext. port. Signed-off-by: Grygorii Strashko --- arch/arm/boot/dts/am335x-evm.dts | 13 - arch/arm/boot/dts/am335x-evmsk.dts | 14 ++ arch/arm/boot/dts/am335x-icev2.dts | 14 ++ 3 files changed, 20

[PATCH 1/2] ARM: dts: am33xx-l4: add dt node for new cpsw switchdev driver

2020-11-19 Thread Grygorii Strashko
Add DT node for the new cpsw switchdev based driver. Signed-off-by: Grygorii Strashko --- arch/arm/boot/dts/am33xx-l4.dtsi | 49 1 file changed, 49 insertions(+) diff --git a/arch/arm/boot/dts/am33xx-l4.dtsi b/arch/arm/boot/dts/am33xx-l4.dtsi index ea20e4bdf040

[PATCH 0/2] ARM: dts: am335x-evm/evmsk/icev2: switch to new cpsw switch drv

2020-11-19 Thread Grygorii Strashko
Hi Tony, This is the initial conversation of am335x boards to use new cpsw switch driver. This series adds the cpsw switch driver DT definition and am335x-evm/evmsk/icev2 boards are converted to use it. Grygorii Strashko (2): ARM: dts: am33xx-l4: add dt node for new cpsw switchdev driver ARM

Re: [PATCH] mdio_bus: suppress err message for reset gpio EPROBE_DEFER

2020-11-19 Thread Grygorii Strashko
On 19/11/2020 14:30, Heiner Kallweit wrote: Am 18.11.2020 um 15:24 schrieb Grygorii Strashko: The mdio_bus may have dependencies from GPIO controller and so got deferred. Now it will print error message every time -EPROBE_DEFER is returned from: __mdiobus_register

Re: [PATCH v2 0/4] arm64: dts: ti: J7200 GPIO support and warning fixes

2020-11-19 Thread Grygorii Strashko
-wakeup.dtsi | 35 + .../dts/ti/k3-j721e-common-proc-board.dts | 1 + arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 12 +++ .../boot/dts/ti/k3-j721e-mcu-wakeup.dtsi | 3 + 9 files changed, 151 insertions(+) For patches 1,3,4 Reviewed-by: Grygorii Strashko -- Best regards

Re: [PATCH v2 2/4] arm64: dts: ti: k3: squelch warnings regarding no #address-cells for interrupt-controller

2020-11-19 Thread Grygorii Strashko
On 18/11/2020 17:12, Nishanth Menon wrote: On 13:38-20201118, Grygorii Strashko wrote: Hi Rob, On 17/11/2020 18:19, Sekhar Nori wrote: With dtc 1.6.0, building TI device-tree files with W=2 results in warnings like below for all interrupt controllers. /bus@10/bus@3000/interrupt

[PATCH] gpio: omap: handle deferred probe with dev_err_probe() for gpiochip_add_data()

2020-11-18 Thread Grygorii Strashko
The gpiochip_add_data() may return -EPROBE_DEFER which is not handled properly by TI GPIO driver and causes unnecessary boot log messages. Hence, add proper deferred probe handling with new dev_err_probe() API. Signed-off-by: Grygorii Strashko --- drivers/gpio/gpio-omap.c | 7 ++- 1 file

[PATCH] gpiolib: do not print err message for EPROBE_DEFER

2020-11-18 Thread Grygorii Strashko
DEFER case. Signed-off-by: Grygorii Strashko --- drivers/gpio/gpiolib.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index 089ddcaa9bc6..fd2c503a6aab 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c

[PATCH] mdio_bus: suppress err message for reset gpio EPROBE_DEFER

2020-11-18 Thread Grygorii Strashko
.mdio couldn't get reset GPIO" Hence, suppress error message when devm_gpiod_get_optional() returning -EPROBE_DEFER case. Signed-off-by: Grygorii Strashko --- drivers/net/phy/mdio_bus.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/phy/mdio_bus.c b/drive

[PATCH] bus: ti-sysc: suppress err msg for timers used as clockevent/source

2020-11-18 Thread Grygorii Strashko
press them by returning -ENXIO instead of -EBUSY. Signed-off-by: Grygorii Strashko --- drivers/bus/ti-sysc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c index 792a2878cb16..02186bac1b0b 100644 --- a/drivers/bus/ti-sysc.c +++ b/d

Re: [PATCH v2 2/4] arm64: dts: ti: k3: squelch warnings regarding no #address-cells for interrupt-controller

2020-11-18 Thread Grygorii Strashko
#address-cells = <0>; Does it really required or mandatory to have #address-cells = <0>; defined for interrupt-controller DT nodes which do not have child nodes and no "interrupt-map"? -- Best regards, grygorii

Re: [PATCH net-next 3/3] net: ethernet: ti: am65-cpsw: enable broadcast/multicast rate limit support

2020-11-16 Thread Grygorii Strashko
On 14/11/2020 21:17, Vladimir Oltean wrote: On Sat, Nov 14, 2020 at 05:56:54AM +0200, Grygorii Strashko wrote: This patch enables support for ingress broadcast(BC)/multicast(MC) rate limiting in TI AM65x CPSW driver (the corresponding ALE support was added in previous patch) by implementing

Re: [PATCH net-next 2/3] net: ethernet: ti: cpsw_new: enable broadcast/multicast rate limit support

2020-11-16 Thread Grygorii Strashko
On 14/11/2020 21:09, Vladimir Oltean wrote: On Sat, Nov 14, 2020 at 05:56:53AM +0200, Grygorii Strashko wrote: This patch enables support for ingress broadcast(BC)/multicast(MC) rate limiting in TI CPSW switchdev driver (the corresponding ALE support was added in previous patch

Re: [PATCH 1/3] arm64: dts: ti: k3-j7200-main: Add gpio nodes in main domain

2020-11-13 Thread Grygorii Strashko
.0-11-g9d7888cbf19c"). In my opinion it's false warning as there is no requirement to have #address-cells in interrupt provider node. by the way, above commit description says: "The interrupt_provider check is noisy, so turn it off for now." -- Best regards, grygorii

[PATCH net-next 2/3] net: ethernet: ti: cpsw_new: enable broadcast/multicast rate limit support

2020-11-13 Thread Grygorii Strashko
to 2pps: tc qdisc add dev eth0 clsact tc filter add dev eth0 ingress flower skip_sw dst_mac 01:00:00:00:00:00 \ action police rate 9600kbit burst 64k rate 9600kbit - 2pps * 60 bytes * 8, burst - not used. Signed-off-by: Grygorii Strashko --- drivers/net/ethernet/ti/cpsw_new.c | 4

[PATCH net-next 0/3] net: ethernet: ti: cpsw: enable broadcast/multicast rate limit support

2020-11-13 Thread Grygorii Strashko
eth0/statistics/rx_packets - server route add -host 239.255.1.3 eth0 iperf -c 239.255.1.3 -u -f m -i 5 -t 30 -l1472 -b12176 -t1 //~1pps [1] https://lore.kernel.org/patchwork/patch/1217254/ Grygorii Strashko (3): drivers: net: cpsw: ale: add broadcast/multicast rate limit support

[PATCH net-next 3/3] net: ethernet: ti: am65-cpsw: enable broadcast/multicast rate limit support

2020-11-13 Thread Grygorii Strashko
to 2pps: tc qdisc add dev eth0 clsact tc filter add dev eth0 ingress flower skip_sw dst_mac 01:00:00:00:00:00 \ action police rate 9600kbit burst 64k rate 9600kbit - 2pps * 60 bytes * 8, burst - not used. Signed-off-by: Grygorii Strashko --- drivers/net/ethernet/ti/am65-cpsw-qos.c | 148

[PATCH net-next 1/3] drivers: net: cpsw: ale: add broadcast/multicast rate limit support

2020-11-13 Thread Grygorii Strashko
port.BCASTMCAST/_LIMIT values. This patch implements above logic in ALE and adds new ALE APIs cpsw_ale_rx_ratelimit_bc(); cpsw_ale_rx_ratelimit_mc(); Signed-off-by: Grygorii Strashko --- drivers/net/ethernet/ti/cpsw_ale.c | 66 ++ drivers/net/ethernet/ti/cpsw_ale.h

[PATCH v5] net: ethernet: ti: am65-cpts: update ret when ptp_clock is ERROR

2020-11-12 Thread Grygorii Strashko
fixes tag] Signed-off-by: Grygorii Strashko Acked-by: Richard Cochran --- Hi I've update patch as requested and added Acked-by from Richard from v1. v4: https://lore.kernel.org/patchwork/patch/1336771/ v3: https://lore.kernel.org/patchwork/patch/1334871/ v2: https://lore.kernel.org/patchwork/pat

[PATCH] net: ethernet: ti: cpsw: fix cpts irq after suspend

2020-11-12 Thread Grygorii Strashko
. Fixes: 84ea9c0a95d7 ("net: ethernet: ti: cpsw: enable cpts irq") Reported-by: Tony Lindgren Signed-off-by: Grygorii Strashko --- drivers/net/ethernet/ti/cpsw.c | 10 ++ drivers/net/ethernet/ti/cpsw_new.c | 9 ++--- 2 files changed, 12 insertions(+), 7 deletions(-)

Re: [PATCH V4 net-bugfixs] net/ethernet: Update ret when ptp_clock is ERROR

2020-11-12 Thread Grygorii Strashko
On 12/11/2020 10:25, Arnd Bergmann wrote: On Thu, Nov 12, 2020 at 2:48 AM 王擎 wrote: On Wed, Nov 11, 2020 at 03:24:33PM +0200, Grygorii Strashko wrote: I don't think v1 builds cleanly folks (not 100% sure, cpts is not compiled on x86): ret = cpts->ptp_clock ? c

Re: [PATCHv2] bus: ti-sysc: Fix bogus resetdone warning on enable for cpsw

2020-11-11 Thread Grygorii Strashko
On 10/11/2020 11:21, Tony Lindgren wrote: Bail out early from sysc_wait_softreset() just like we do in sysc_reset() if there's no sysstatus srst_shift to fix a bogus resetdone warning on enable as suggested by Grygorii Strashko . We do not currently handle resets for modules that need

Re: [PATCH V4 net-bugfixs] net/ethernet: Update ret when ptp_clock is ERROR

2020-11-11 Thread Grygorii Strashko
to be applied [1]. I've also added my Reviewed-by there. [1] https://lore.kernel.org/patchwork/patch/1334067/ -- Best regards, grygorii

Re: [PATCH] net/ethernet: update ret when ptp_clock is ERROR

2020-11-11 Thread Grygorii Strashko
: Reviewed-by: Grygorii Strashko --- drivers/net/ethernet/ti/am65-cpts.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/ti/am65-cpts.c b/drivers/net/ethernet/ti/am65-cpts.c index 75056c1..b77ff61 --- a/drivers/net/ethernet/ti/am65-cpts.c +++ b/drivers

Re: [PATCH] net/ethernet: update ret when ptp_clock is ERROR

2020-11-06 Thread Grygorii Strashko
On 06/11/2020 14:58, Kurt Kanzenbach wrote: On Fri Nov 06 2020, Arnd Bergmann wrote: On Fri, Nov 6, 2020 at 12:35 PM Grygorii Strashko wrote: On 06/11/2020 09:56, Wang Qing wrote: +++ b/drivers/net/ethernet/ti/am65-cpts.c @@ -1001,8 +1001,7 @@ struct am65_cpts *am65_cpts_create(struct

Re: [PATCH v1 00/18] Refactor fw_devlink to significantly improve boot time

2020-11-06 Thread Grygorii Strashko
to add fw_devlink support to ACPI and other firmware types. A refactor to move the common bits from DT specific code to driver core was in my TODO list as a prerequisite to adding ACPI support to fw_devlink. This series gets that done. Tomi/Laurent/Grygorii, If you can test this series

Re: [PATCH] net/ethernet: update ret when ptp_clock is ERROR

2020-11-06 Thread Grygorii Strashko
ock : (-ENODEV); goto refclk_disable; } cpts->phc_index = ptp_clock_index(cpts->ptp_clock); -- Best regards, grygorii

Re: [PATCH 07/12] net: ethernet: ti: am65-cpts: Document am65_cpts_rx_enable()'s 'en' parameter

2020-11-04 Thread Grygorii Strashko
'skb' description in 'am65_cpts_rx_enable' Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Grygorii Strashko Cc: Kurt Kanzenbach Cc: net...@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/ethernet/ti/am65-cpts.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH] dmaengine: ti: k3-udma-glue: move psi-l pairing in channel en/dis functions

2020-11-04 Thread Grygorii Strashko
On 02/11/2020 09:46, Peter Ujfalusi wrote: On 30/10/2020 22.30, Grygorii Strashko wrote: The NAVSS UDMA will stuck if target IP module is disabled by PM while PSI-L threads are paired UDMA<->IP and no further transfers is possible. This could be the case for IPs J721E Main CPSW (

[PATCH] dmaengine: ti: k3-udma-glue: move psi-l pairing in channel en/dis functions

2020-10-30 Thread Grygorii Strashko
going to be enabled as at this time DMA consumer module expected to be active already. Signed-off-by: Grygorii Strashko --- drivers/dma/ti/k3-udma-glue.c | 64 +-- 1 file changed, 38 insertions(+), 26 deletions(-) diff --git a/drivers/dma/ti/k3-udma-glue.c b/drivers/dma

[PATCH net-next v3 07/10] net: ethernet: ti: am65-cpsw: fix tx csum offload for multi mac mode

2020-10-30 Thread Grygorii Strashko
ing .ndo_set_features() callback implementation, which was used only NETIF_F_HW_CSUM feature update purposes Signed-off-by: Grygorii Strashko Reviewed-by: Jesse Brandeburg --- drivers/net/ethernet/ti/am65-cpsw-nuss.c | 30 +--- 1 file changed, 1 insertion(+), 29 deletions(-) diff --

[PATCH net-next v3 06/10] net: ethernet: ti: am65-cpsw: keep active if cpts enabled

2020-10-30 Thread Grygorii Strashko
3 CPSW active by forbidding PM runtime if CPTS is enabled. Signed-off-by: Grygorii Strashko Reviewed-by: Jesse Brandeburg --- drivers/net/ethernet/ti/am65-cpsw-nuss.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/ethernet/ti/am65-cpsw-nuss.c b/drivers/net/ethernet/ti/am6

[PATCH] pwm: tiehrpwm: handle deferred probe with dev_err_probe()

2020-10-30 Thread Grygorii Strashko
The devm_clk_get() may return -EPROBE_DEFER which is not handled properly by TI EHRPWM driver and causes unnecessary boot log messages. Hence, add proper deferred probe handling with new dev_err_probe() API. Signed-off-by: Grygorii Strashko --- drivers/pwm/pwm-tiehrpwm.c | 12 1

[PATCH net-next v3 10/10] net: ethernet: ti: am65-cpsw: handle deferred probe with dev_err_probe()

2020-10-30 Thread Grygorii Strashko
Use new dev_err_probe() API to handle deferred probe properly and simplify the code. Signed-off-by: Grygorii Strashko --- drivers/net/ethernet/ti/am65-cpsw-nuss.c | 28 +--- 1 file changed, 10 insertions(+), 18 deletions(-) diff --git a/drivers/net/ethernet/ti/am65-cpsw

[PATCH net-next v3 08/10] net: ethernet: ti: am65-cpsw: prepare xmit/rx path for multi-port devices in mac-only mode

2020-10-30 Thread Grygorii Strashko
() as every completed TX skb can have different ndev assigned (come from different netdevs). To avoid performance issues for existing one-port CPSW2g devices the above changes are done only for multi-port devices by splitting xmit path for one-port and multi-port devices. Signed-off-by: Grygorii

[PATCH net-next v3 05/10] net: ethernet: ti: am65-cpsw: fix vlan offload for multi mac mode

2020-10-30 Thread Grygorii Strashko
to preserve existing legacy CPSW drivers functionality. Signed-off-by: Grygorii Strashko Reviewed-by: Jesse Brandeburg --- drivers/net/ethernet/ti/am65-cpsw-nuss.c | 8 +--- drivers/net/ethernet/ti/cpsw_ale.c | 19 +++ 2 files changed, 20 insertions(+), 7 deletions(-)

[PATCH net-next v3 09/10] net: ethernet: ti: am65-cpsw: add multi port support in mac-only mode

2020-10-30 Thread Grygorii Strashko
No packet switching between external ports happens. - every port supports the same features as current AM65x CPSW on external device. Signed-off-by: Grygorii Strashko Reviewed-by: Jesse Brandeburg --- drivers/net/ethernet/ti/am65-cpsw-nuss.c | 129 ++- drivers/net/ethernet/ti

  1   2   3   4   5   6   7   8   9   10   >